David Bremner writes:
> This obsoletes id:20200617110441.1262683-1-da...@tethera.net
>
> I have updated patch 2/3 based on discussions with Olly and Tomi.
>
> Olly gave the previous series thumbs up on IRC, so I'll probably merge
> this version if I don't here any corrections.
Seeing none,
I decided before commiting to a style of error return for existing
Boolean API functions I should try it out. I eliminated all of the
deprecation warnings for notmuch_message_get_flag. Honestly the worst
part was dealing with interprocedural error propagation, I don't thing
the choice of error
Depending on the flag, this actually can return an errror, so raise a
ruby exception if so.
---
bindings/ruby/message.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/bindings/ruby/message.c b/bindings/ruby/message.c
index c55cf6e2..6ea82afa 100644
---
This can be seen as moving an abort out of the library, into the CLI
where we can both print to stderr and shut the process down without
ill effect.
---
notmuch-show.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/notmuch-show.c b/notmuch-show.c
As a side effect, we revert the switch from notmuch_bool_t to bool
here. This is because those two types are not actually compatible when
passing by reference.
---
lib/add-message.cc | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/add-message.cc b/lib/add-message.cc
Our handling of errors is all or nothing here, but it's an improvement
on the status quo, and it avoids rippling internal API changes.
---
notmuch-search.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/notmuch-search.c b/notmuch-search.c
index fd0b58c5..2805d960
This adds one more reason why _notmuch_thread_create might return
NULL, but those were not previously enumerated, so no promises are
broken.
---
lib/thread.cc | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/lib/thread.cc b/lib/thread.cc
index
Jonas Witschel writes:
> gzip includes the name of the uncompressed file and its modification
> timestamp into the compressed archive. The latter makes it hard to
> reproduce the generated files bit for bit at a later time, so omit this
> information from the archive using the "--no-name"
On Sat, Jul 11 2020, Jonas Witschel wrote:
> gzip includes the name of the uncompressed file and its modification
> timestamp into the compressed archive. The latter makes it hard to
> reproduce the generated files bit for bit at a later time, so omit this
> information from the archive using the
gzip includes the name of the uncompressed file and its modification
timestamp into the compressed archive. The latter makes it hard to
reproduce the generated files bit for bit at a later time, so omit this
information from the archive using the "--no-name" option. This is a
reproducibility best
On Sat, Jul 11 2020, David Bremner wrote:
> I don't love the use of exec, but it is getting unwieldy to pass
> configuration options on the sphinx-build command line, and I
> anticipate further use of conditionals.
Perhaps less "opinions" in commit message.
(and as I think I don't comment 2/2,
A seperate conf.py and doc directory will be needed if someone wants
to build the bindings docs separately from notmuch.
---
configure | 4
doc/conf.py | 8
doc/index.rst | 1 +
doc/python-bindings.rst | 5 +
4 files changed, 18 insertions(+)
I don't love the use of exec, but it is getting unwieldy to pass
configuration options on the sphinx-build command line, and I
anticipate further use of conditionals.
---
configure | 8
doc/Makefile.local | 2 +-
doc/conf.py| 11 ---
3 files changed, 17
13 matches
Mail list logo
