Re: [PATCH] configure: Check if emacs >= 25 (instead of >= 24) is available

2020-08-12 Thread David Bremner
Tomi Ollila writes: > "The minimum supported major version of GNU Emacs is now 25.1." > > 25.1 is the first "released" version of Emacs 25. applied to master. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to

Re: [PATCH] notmuch-mutt: replace shell pipeline with internal pipe processing

2020-08-12 Thread David Bremner
Tomi Ollila writes: > The shell pipeline used to symlink files based in search results > to "cache" directory for mutt(1) to use was prone to portability > problems (due to /bin/sh differences). > > The replacement executes `notmuch search` without intermediate shell > (so shell_quote was

Re: [PATCH v2] Emacs: Indent first header line only when indentation is turned on

2020-08-12 Thread David Bremner
Teemu Likonen writes: > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 0eb27e33..444b2a45 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -474,7 +474,10 @@ message at DEPTH in the current thread." >;; invisible U+200E LEFT-TO-RIGHT MARK

[PATCH 2/6] lib: factor out feature name related code.

2020-08-12 Thread David Bremner
database.cc is uncomfortably large, and some of the static data structures do not need to be shared as much as they are. This is a somewhat small piece to factor out, but it will turn out to be helpful to further refactoring. --- lib/Makefile.local | 3 +- lib/database-private.h | 14

[PATCH 6/6] lib: factor out notmuch_database_open* related code to own file

2020-08-12 Thread David Bremner
Reduce the size of database.cc, and prepare for extending the database opening API --- lib/Makefile.local | 3 +- lib/database.cc| 219 - lib/open.cc| 218 3 files changed, 220 insertions(+),

preliminaries for merged config

2020-08-12 Thread David Bremner
This collects all of the patches from id:20200808141653.1124111-1-da...@tethera.net that are reasonable changes on their own, without wading into the new API design. Two updates to tests [PATCH 1/6] test: use keys with group 'test' in T590-libconfig [PATCH 5/6] test: add regression test for

[PATCH 3/6] lib: factor out prefix related code to its own file

2020-08-12 Thread David Bremner
Reduce the size of database.cc, and limit the scope of prefix_table, make sure it's accessed via a well-defined internal API. --- lib/Makefile.local | 4 +- lib/database-private.h | 7 ++ lib/database.cc| 201 ++- lib/prefix.cc | 210

[PATCH 1/6] test: use keys with group 'test' in T590-libconfig

2020-08-12 Thread David Bremner
In a future commit we want to interoperate better with glib KeyFiles, which need groups for all keys. --- test/T590-libconfig.sh | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/test/T590-libconfig.sh b/test/T590-libconfig.sh index

[PATCH 5/6] test: add regression test for searching with alternate config

2020-08-12 Thread David Bremner
Make sure upcoming changes to config handling do not break command line specification. --- test/T140-excludes.sh | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/T140-excludes.sh b/test/T140-excludes.sh index 0cf69975..cef07095 100755 --- a/test/T140-excludes.sh +++

[PATCH 4/6] lib/config: delay setting talloc destructor

2020-08-12 Thread David Bremner
If Xapian has thrown an exception, it is not safe to invoke the destuctor when freeing the list struct. --- lib/config.cc | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/config.cc b/lib/config.cc index dae0ff0e..d0497052 100644 --- a/lib/config.cc +++

Re: New release for Emacs 27.1?

2020-08-12 Thread Damien Cassou
Tomi Ollila writes: > Release cycle for 0.31 could be shorter, just for that reason. To fix the build, I updated Notmuch package in Nixpkgs: this will now use commit 1c80020e701c7323de137c0616fc8864443d7bd3. -- Damien Cassou "Success is the ability to go from one failure to another without