Re: [PATCH 1/2] Emacs: Add a new function for balancing bidi control chars

2020-08-16 Thread Teemu Likonen
* 2020-08-16 19:28:51+03, Tomi Ollila wrote: > Good stuff -- implementation looks like port of the php code in > >https://www.iamcal.com/understanding-bidirectional-text > > to emacs lisp... anyway nice implementation took be a bit of > time for me to understand it... I don't read PHP and

[PATCH v2] Emacs: Fix notmuch-message-summary-face definition

2020-08-16 Thread Teemu Likonen
Emacs face definition forms are either ((DISPLAY . PLIST) (DISPLAY . PLIST)) or ((DISPLAY PLIST) ;For backward compatibility. (DISPLAY PLIST)) Commit a2388bc56e55da5d5695816818274f8a84b0ed92 (2020-08-08) follows neither of the correct formats. It defines: `class

[PATCH] test: fix uninitialized variable use in T562-lib-database

2020-08-16 Thread David Bremner
Fix a copy paste error of using the boolean ret as a notmuch_status_t, and uninitialized. --- test/T562-lib-database.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/test/T562-lib-database.sh b/test/T562-lib-database.sh index d6097418..dd4f2566 100755 ---

Re: [PATCH 1/2] Emacs: Add a new function for balancing bidi control chars

2020-08-16 Thread Tomi Ollila
On Sat, Aug 15 2020, Teemu Likonen wrote: > The following Unicode's bidirectional control chars are modal so that > they push a new bidirectional rendering mode to a stack: > > U+202A LEFT-TO-RIGHT EMBEDDING > U+202B RIGHT-TO-LEFT EMBEDDING > U+202D LEFT-TO-RIGHT OVERRIDE > U+202E

[PATCH] build: clean up sphinx.config

2020-08-16 Thread David Bremner
Follow the existing practice and remove it under "distclean", same as sh.config and Makefile.config --- Makefile.local | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.local b/Makefile.local index 156c8ce1..c65cee7c 100644 --- a/Makefile.local +++ b/Makefile.local @@

Re: [PATCH] devel/release-checks.sh: use grep to find copyright year.

2020-08-16 Thread Tomi Ollila
On Sun, Aug 16 2020, David Bremner wrote: > This is quite fragile, but it works for now, unlike the python > version. > > In general it seems conf.py is not intended to be evaluated outside of > sphinx, as it assumes certain global names (in particular "tags") are > defined. > --- > > I am going

starting release process for 0.31

2020-08-16 Thread David Bremner
I've tagged the first release candidate for 0.31 (0.31_rc0), and uploaded signed tarballs to the usual place [1]. We need to sort out NEWS, and possibly add one or two small patches before final release of 0.31 [1]: https://notmuchmail.org/releases/ signature.asc Description: PGP signature

[PATCH] devel/release-checks.sh: use grep to find copyright year.

2020-08-16 Thread David Bremner
This is quite fragile, but it works for now, unlike the python version. In general it seems conf.py is not intended to be evaluated outside of sphinx, as it assumes certain global names (in particular "tags") are defined. --- I am going to apply this to unblock the release process, but I

Re: [PATCH v2 1/3] emacs/tree: introduce notmuch-tree-parent-buffer variable

2020-08-16 Thread David Bremner
William Casarin writes: > This variable will be used in a similar fashion to > notmuch-show-parent-buffer. It will be used to navigate between > threads from the parent search buffer. > > Signed-off-by: William Casarin v2 applied to master ___

Re: [PATCH] test: update README to reflect dropping upgrade tests

2020-08-16 Thread David Bremner
David Bremner writes: > These test databases have been unneeded since ee897cab8. applied to master. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH] Emacs: Fix notmuch-message-summary-face definition

2020-08-16 Thread Jonas Bernoulli
Teemu Likonen writes: > Emacs face definition forms are either > > ((DISPLAY . PLIST) > (DISPLAY . PLIST)) > > or > > ((DISPLAY PLIST) ;For backward compatibility. > (DISPLAY PLIST)) > > Commit a2388bc56e55da5d5695816818274f8a84b0ed92 (2020-08-08) follows > neither of the

[PATCH] Emacs: Fix notmuch-message-summary-face definition

2020-08-16 Thread Teemu Likonen
Emacs face definition forms are either ((DISPLAY . PLIST) (DISPLAY . PLIST)) or ((DISPLAY PLIST) ;For backward compatibility. (DISPLAY PLIST)) Commit a2388bc56e55da5d5695816818274f8a84b0ed92 (2020-08-08) follows neither of the correct formats. It defines: `class