emacs: `message-send-hook` being called twice

[Tim Quelch]

Hi all,

I've been working through a bug that I've been having with org-msg
(https://github.com/jeremy-compostella/org-msg/issues/58#issuecomment-675177076)
and it looks like a bug in the internals of notmuch.

It appears as though the `message-send-hooks` are being called twice,
1. In `notmuch-mua-send-common` when `notmuch-mua-send-hook` are run
(which by default is set to `notmuch-mua-message-send-hook`, which just
runs `message-send-hook`)
2. When `notmuch-mua-send-common` delegates sending of the message to
`message-send` or `message-send-and-exit`. These functions both run 
`message-send-hook`

The specific issue this was causing in org-msg was that the message was
being converted to html twice, causing raw html to be included in the
sent message. This kind of issue could easily pop up again with other
non-idempotent hook functions.

I was wondering what the design descision was to set up
`notmuch-mua-send-hook` to delegate to running `message-send-hook` when
this is already done in `message-send`

If this was not intentional, I don't think `notmuch-mua-send-hook` needs
to contain `notmuch-mua-message-send-hook` by default.

Thanks,
Tim
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH] devel/release-checks.sh: use grep to find copyright year.

[David Bremner]

Tomi Ollila  writes:

> On Sun, Aug 16 2020, David Bremner wrote:
>
>
> For consistency and to save one fork(2) $(exec grep ...), but I could
> live with this, too ;D
>
> So LGTM.

I guess I was a bit impatient. We can add the exec in the next cleanup
pass of configure I guess.

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org

[PATCH] NEWS: notmuch-mutt: system(shell pipeline) replaced internally

[Tomi Ollila]

---
 NEWS | 8 
 1 file changed, 8 insertions(+)

diff --git a/NEWS b/NEWS
index 4160e39c9c30..b25bfaa38254 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,14 @@ Emacs
 
 The minimum supported major version of GNU Emacs is now 25.1.
 
+Notmuch-Mutt
+
+
+The shell pipeline executed by notmuch-mutt, which symlinked matched
+files to a maildir for mutt to access is replaced with internal perl
+processing. This search operation is now more portable, and somewhat
+faster.
+
 Notmuch 0.30 (2020-07-10)
 =
 
-- 
2.13.3
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org