Re: [PATCH 2/5] NEWS: mention exception handling changes
William Casarin writes: > subjective nit: > > Many small changes to exception handling in the library. This should > largely eliminate terminations due to uncaught exceptions or internal > errors. No doubt there are a few uncovered code paths still; please > report them as bugs. > > Otherwise series LGTM Sure, I used your version. Applied series to release and master. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] NEWS: add news entry for tree navigation changes
William Casarin writes: > The elisp code has plenty of comments that document each function, > perhaps there could be a way to generate documentation from that? Not > sure how magit does it. We already have the docstrings available in the notmuch-emacs manual, but they need to be referenced in the rst source. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 2/5] NEWS: mention exception handling changes
David Bremner writes: > --- > NEWS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/NEWS b/NEWS > index c1f09b18..e6392e81 100644 > --- a/NEWS > +++ b/NEWS > @@ -16,6 +16,14 @@ files to a maildir for mutt to access is replaced with > internal perl > processing. This search operation is now more portable, and somewhat > faster. > > +Library > +--- > + > +Many small changes to exception handling in the library; this should > +largely eliminate terminations inside the library due to uncaught > +exceptions or internal errors. No doubt there are a few uncovered > +code paths still; please report them as bugs. subjective nit: Many small changes to exception handling in the library. This should largely eliminate terminations due to uncaught exceptions or internal errors. No doubt there are a few uncovered code paths still; please report them as bugs. Otherwise series LGTM ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] NEWS: add news entry for tree navigation changes
David Bremner writes: > William Casarin writes: > >> Signed-off-by: William Casarin >> --- >> NEWS | 2 ++ >> 1 file changed, 2 insertions(+) >> > > Applied to master and release, with a tiny wording change. > > I realized when looking at this that I had completely forgotten > notmuch-tree-from-search-thread. I suspect some of emacs interface is > not as discoverable as we think it is Indeed, I only discovered this function after Teemu mentioned[1] it in a mailing list thread. I've always like the magit docs, maybe we can get to something like that eventually. [1] id:87pnhxceoy@iki.fi The elisp code has plenty of comments that document each function, perhaps there could be a way to generate documentation from that? Not sure how magit does it. > and it would be worth updating > (not for the upcoming release, but afterwards) doc/notmuch-emacs.rst > with some of the nifty features that have been added since I > optimistically wrote (eb6fb36d) > > This is pretty minimal, but will hopefully inspire others to > contribute more complete documentation Oh good to know! Didn't realize this was a thing. Cheers, Will ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH 5/5] NEWS: remaining user visible library changes
These could both cause / fix crashes for user code. --- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index a1106130..9f649ff6 100644 --- a/NEWS +++ b/NEWS @@ -28,6 +28,12 @@ Add `notmuch_message_get_flag_st` and `notmuch_message_has_maildir_flag_st`, and deprecate the existing non-status providing versions. +Move memory de-allocation from `notmuch_database_close` to +`notmuch_database_destroy`. + +Handle relative filenames in `notmuch_database_index_file`, as +promised in the documentation. + Python Bindings --- -- 2.28.0 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH 2/5] NEWS: mention exception handling changes
--- NEWS | 8 1 file changed, 8 insertions(+) diff --git a/NEWS b/NEWS index c1f09b18..e6392e81 100644 --- a/NEWS +++ b/NEWS @@ -16,6 +16,14 @@ files to a maildir for mutt to access is replaced with internal perl processing. This search operation is now more portable, and somewhat faster. +Library +--- + +Many small changes to exception handling in the library; this should +largely eliminate terminations inside the library due to uncaught +exceptions or internal errors. No doubt there are a few uncovered +code paths still; please report them as bugs. + Python Bindings --- -- 2.28.0 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH 3/5] NEWS: mention port to Xapian 1.5
--- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index e6392e81..ece208a3 100644 --- a/NEWS +++ b/NEWS @@ -31,6 +31,12 @@ Documentation for the python bindings is merged into the main sphinx-doc documentation tree. The merged documentation can be built with e.g. `make sphinx-html` +Dependencies + + +We now support building notmuch against Xapian 1.5 (the current +development version). + Notmuch 0.30 (2020-07-10) = -- 2.28.0 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH 4/5] NEWS: mention new API entries
--- NEWS | 4 1 file changed, 4 insertions(+) diff --git a/NEWS b/NEWS index ece208a3..a1106130 100644 --- a/NEWS +++ b/NEWS @@ -24,6 +24,10 @@ largely eliminate terminations inside the library due to uncaught exceptions or internal errors. No doubt there are a few uncovered code paths still; please report them as bugs. +Add `notmuch_message_get_flag_st` and +`notmuch_message_has_maildir_flag_st`, and deprecate the existing +non-status providing versions. + Python Bindings --- -- 2.28.0 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH 1/5] NEWS: mention merging of documentation for python bindings
--- NEWS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS b/NEWS index 040df4fd..c1f09b18 100644 --- a/NEWS +++ b/NEWS @@ -16,6 +16,13 @@ files to a maildir for mutt to access is replaced with internal perl processing. This search operation is now more portable, and somewhat faster. +Python Bindings +--- + +Documentation for the python bindings is merged into the main +sphinx-doc documentation tree. The merged documentation can be built +with e.g. `make sphinx-html` + Notmuch 0.30 (2020-07-10) = -- 2.28.0 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] NEWS: add news entry for tree navigation changes
William Casarin writes: > Signed-off-by: William Casarin > --- > NEWS | 2 ++ > 1 file changed, 2 insertions(+) > Applied to master and release, with a tiny wording change. I realized when looking at this that I had completely forgotten notmuch-tree-from-search-thread. I suspect some of emacs interface is not as discoverable as we think it is, and it would be worth updating (not for the upcoming release, but afterwards) doc/notmuch-emacs.rst with some of the nifty features that have been added since I optimistically wrote (eb6fb36d) This is pretty minimal, but will hopefully inspire others to contribute more complete documentation ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
