Re: Debugging slow down over time

2020-11-11 Thread Sebastian Fischmeister
I can confirm that after calling (garbage-collect) the search is responsive again. Then I remembered that my init.el changes the gc-cons-threshold speed up the launch. Guess that wasn't a good idea. Sebastian Dan Čermák writes: > Hi Sebastian, > > Sebastian Fischmeister writes: > >> Hi,

Re: [PATCH 04/27] emacs: don't fset keymaps

2020-11-11 Thread David Bremner
William Casarin writes: > Jonas Bernoulli writes: > > > I believe this makes sense. Looks like they were first introduced in > early versions of the code... > > Reviewed-by: William Casarin > Tested-by: William Casarin I have applied the first 4 patches. d

Re: [PATCH 04/27] emacs: don't fset keymaps

2020-11-11 Thread William Casarin
Jonas Bernoulli writes: > These keymaps are never invoked as commands > so the function definitions serve no purpose. > --- > emacs/notmuch-show.el | 1 - > emacs/notmuch-tree.el | 1 - > emacs/notmuch.el | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/emacs/notmuch-show.el

Re: [PATCH 02/27] emacs: define notmuch-message-mode-map explicitly

2020-11-11 Thread William Casarin
Jonas Bernoulli writes: > Key bindings should not be defined at the top-level but inside > a `defvar' form. Doing it at the top-level makes it harder to > reliably customize key bindings. > --- > emacs/notmuch-mua.el | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > >

Re: [PATCH 01/27] emacs: silence byte-compiler

2020-11-11 Thread William Casarin
Jonas Bernoulli writes: > William Casarin writes: >> LGTM, I have a similar patch here: id:20200908171536.20679-1-j...@jb55.com > > So if I understood correctly the problem with that was that you were > unable to run the tests and therefore couldn't confirm that you fixed > the issue or even

Re: [PATCH 01/27] emacs: silence byte-compiler

2020-11-11 Thread Jonas Bernoulli
William Casarin writes: > LGTM, I have a similar patch here: id:20200908171536.20679-1-j...@jb55.com So if I understood correctly the problem with that was that you were unable to run the tests and therefore couldn't confirm that you fixed the issue or even that there was an issue in the first

Re: Debugging slow down over time

2020-11-11 Thread Jonas Bernoulli
Sebastian Fischmeister writes: > For some time already I experience a slowdown of the emacs notmuch > interface over time. Please check if my recent patch in id:20201108174929.1227-1-jo...@bernoul.li fixes that. Cheers, Jonas ___ notmuch

Re: Debugging slow down over time

2020-11-11 Thread Dan Čermák
Hi Sebastian, Sebastian Fischmeister writes: > Hi, > > For some time already I experience a slowdown of the emacs notmuch interface > over time. After using emacs with notmuch for a day or two, loading the inbox > tree view (a search on tag:inbox) takes a significant amount of time to build