Re: [PATCH v2 23/23] emacs: various cosmetic improvements

2020-12-06 Thread David Bremner
Jonas Bernoulli  writes:

> ---
>  emacs/notmuch-address.el | 31 ++
>  emacs/notmuch-hello.el   | 28 +
>  emacs/notmuch-lib.el | 38 +
>  emacs/notmuch-mua.el | 10 ++---
>  emacs/notmuch-tag.el |  2 +-
>  emacs/notmuch.el | 88 
>  6 files changed, 91 insertions(+), 106 deletions(-)

Apologies for the delay, I missed the second review. I've applied the
first 22, but this last one is not applying to (current) master for me.

notmuch mailing list --
To unsubscribe send an email to

Re: why doesn't notmuch-search-toggle-order work in unthreaded view?

2020-12-06 Thread David Bremner
Wenlong Dai  writes:

> I thought notmuch-search-toggle-order would be more useful in unthreaded
> view than search view.
> But I found that it doesn't work in unthreaded view? am I doing something
> wrong? or is this by default?

I think it is just a missing feature. The unthreaded view is fairly new,
and the underlying code in the notmuch-show command never supported an
ordering argument before. I think the actual code to enable the other
ordering for unsorted output would be fairly easy to add. The challenge
is probably what to do with that argument for the threaded
output. Probably it can just be ignored.  If someone wants to tackle
this they can probably get an idea of how to get started by looking at
the implementation of the "sort" argument notmuch-search

notmuch mailing list --
To unsubscribe send an email to