Re: [PATCH 00/13] vim: a bunch of updates from upstream
On Mon, Apr 19, 2021 at 5:14 PM David Bremner wrote: > Felipe Contreras writes: > > > Then I think we could consider removing the vim stuff from notmuch. In > > the meantime I think the three code-bases serve a purpose. > > Thanks for the detailed explanation. Your reasoning makes sense to > me. Now if only we could get more than one person at a time interested > in the notmuch version of the code. Indeed, but this is open source; nobody is paying me (or others) to do this, so not much can be demanded. I guess we'll have to wait and see. Cheers. -- Felipe Contreras ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 00/13] vim: a bunch of updates from upstream
Felipe Contreras writes: > > Then I think we could consider removing the vim stuff from notmuch. In > the meantime I think the three code-bases serve a purpose. > Thanks for the detailed explanation. Your reasoning makes sense to me. Now if only we could get more than one person at a time interested in the notmuch version of the code. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 00/13] vim: a bunch of updates from upstream
On Mon, Apr 19, 2021 at 5:16 AM David Bremner wrote: > > Felipe Contreras writes: > > > I finally took some time to update notmuch-vim and include some fixes, > > as well as pull requests. > > > > Here are the transplanted patches. > > > > So, big picture question. If notmuch is not upstream for this code, > should we be distributing it? I'm not sure which should be considered "upstream" at this point. Apparently there's also a fork by Ian Main that a lot of people are using. >From my point of view the code in notmuch is the one that has been maintained the best. It also has the advantage that there's debian packaging. However, it doesn't have all the improvements of my code-base, nor the features from Ian's code-base. If I manage to: 1. Provide debian packaging 2. Merge the important features from Ian's code (cleanly) 3. Remain active merging future patches Then I think we could consider removing the vim stuff from notmuch. In the meantime I think the three code-bases serve a purpose. Cheers. -- Felipe Contreras ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] ruby: fix ruby 3.1 warnings
On Mon, Apr 19, 2021 at 1:50 PM Tomi Ollila wrote: > (otoh?) latest git-send-email has this option: --8bit-encoding > -- and if not given (and not in git config), according to namual page, > will prompt for an encoding (IIRC I've seen this w/ git 2.30) I have this configured: sendemail.assume8bitEncoding = utf-8 I don't know if this is the right thing to do, but in git world everything is utf-8. -- Felipe Contreras ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] ruby: fix ruby 3.1 warnings
On Mon, Apr 19 2021, David Bremner wrote: > Felipe Contreras writes: > >> Hello. >> >> On Sat, Apr 17, 2021 at 7:20 AM David Bremner wrote: >> >>> Thanks for the patch. I have a couple of questions / comments >>> >>> - It doesn't apply against current master (5248f55d5f1). Can you rebase >>> it? >> >> Huh? That's precisely the commit I used as a base. It applies cleanly. >> > > Ah right, you hit an annoying mailman bug related to encodings and line > endings. I have unmangled the patch and applied it to master. ...which is not actually a bug, just features of git and mailman that does not work together... IIRC what happens there: - smtp server receives message encoded as 8bit, possibly only LF (line-feed 0x10) as line endings (I saw this when sent to myself message routed back to me via smtp.iki.fi) - if only LF as line ending, something in pipeline changes that to CRLF (carriage-return line-feed 0x13 0x10) (allowed according to specs) - now (if not before) mailman gets the message, notices it has 8bit encoding, converts that message to have base64 encoding - mailman sends the email now base64-encoded to recipients - user saves message and runs git-am to the message - since content now has CRLF line endings and the content it is comparing to has only NL, the content just does not match. git-am cannot know that (w/o some magical heuristics) that the CRs are actually extra characters should not be there (having CRLF may be as relevant as only LF) In another machine I still have David's email to mailman in one firefox tab; I recall trying to write something there to explain why mailman is buggy there, but eventually could not be convincing enough ;/) git-am could have an option to strip CR's from messages just to overcome the possibility shown above (otoh?) latest git-send-email has this option: --8bit-encoding -- and if not given (and not in git config), according to namual page, will prompt for an encoding (IIRC I've seen this w/ git 2.30) HTH :D Tomi ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 00/13] vim: a bunch of updates from upstream
Felipe Contreras writes: > I finally took some time to update notmuch-vim and include some fixes, > as well as pull requests. > > Here are the transplanted patches. > So, big picture question. If notmuch is not upstream for this code, should we be distributing it? d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] ruby: fix ruby 3.1 warnings
Felipe Contreras writes: > Hello. > > On Sat, Apr 17, 2021 at 7:20 AM David Bremner wrote: > >> Thanks for the patch. I have a couple of questions / comments >> >> - It doesn't apply against current master (5248f55d5f1). Can you rebase >> it? > > Huh? That's precisely the commit I used as a base. It applies cleanly. > Ah right, you hit an annoying mailman bug related to encodings and line endings. I have unmangled the patch and applied it to master. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH v2 0/2] scaffolding for autocrypt support
On Friday, 2021-04-16 at 09:05:29 -03, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> Hi David, all-- >> >> On Sun 2021-02-21 15:21:30 +, David Edmondson wrote: >>> I started looking at how to add autocrypt support based on >>> https://git.sr.ht/~zge/autocrypt. >> >> Thanks for this work, i'm glad to see the interest in autocrypt! >> >> I tend to think that the autocrypt handling belongs in libnotmuch, and >> not just in the emacs frontend, so i'm a bit concerned about what we'll >> have to prune out of the emacs frontend if we do manage to land the >> features in libnotmuch itself. > > FTR, I'm waiting for the two of you to come to some concensus before > proceding with these patches. At the moment I don't really have time to make any progress, sorry. dme. -- Welcome to Conditioning. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
