Re: The future of Ruby bindings

On Fri, Apr 30, 2021 at 5:14 PM Felipe Contreras wrote: > I understand why Ali Polatel did commit c7893408 (ruby: Kill garbage > collection related cruft., 2010-05-26); because the order of the object > destruction cannot be ensured in Ruby, however, there's ways to > workaround that. > > 1. We

Re: [PATCH 7/9] doc: document (tersely) the intended behaviour of relative paths.

On Friday, 2021-05-07 at 08:30:27 -03, David Bremner wrote: > --- > doc/man1/notmuch-config.rst | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/doc/man1/notmuch-config.rst b/doc/man1/notmuch-config.rst > index 32290a38..5cb6e203 100644 > --- a/doc/man1/notmuch-config.r

Re: [PATCH 5/9] test: test relative paths for database.hook_dir

On Fri, May 07 2021, David Bremner wrote: > --- > test/T400-hooks.sh | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/test/T400-hooks.sh b/test/T400-hooks.sh > index 3a2df2f4..00c99337 100755 > --- a/test/T400-hooks.sh > +++ b/test/T400-hooks.sh > @@ -43,7 +43,7 @@ a

[PATCH 8/9] doc: document database.backup_dir

Most users will not need to change this, but documenting it helps preserve the interface. --- doc/man1/notmuch-config.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/man1/notmuch-config.rst b/doc/man1/notmuch-config.rst index 5cb6e203..a6cfeb41 100644 --- a/doc/man1/notmuch-con

[PATCH 4/9] lib/config: expand relative paths when reading from database

This makes the treatment of relative paths consistent between the database and config files. --- lib/config.cc| 8 +--- test/T050-new.sh | 1 - 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/config.cc b/lib/config.cc index e08c6bf7..74339694 100644 --- a/lib/config.cc +

[PATCH 3/9] test: add known broken test for relative setting of mail_root

The behaviour should not change depending on where the configuration is stored. --- test/T050-new.sh | 13 + 1 file changed, 13 insertions(+) diff --git a/test/T050-new.sh b/test/T050-new.sh index 33ad7f5a..f28497bf 100755 --- a/test/T050-new.sh +++ b/test/T050-new.sh @@ -406,6 +406,1

[PATCH 5/9] test: test relative paths for database.hook_dir

--- test/T400-hooks.sh | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/T400-hooks.sh b/test/T400-hooks.sh index 3a2df2f4..00c99337 100755 --- a/test/T400-hooks.sh +++ b/test/T400-hooks.sh @@ -43,7 +43,7 @@ add_message # create maildir structure for notmuch-insert m

[PATCH 6/9] test: test explicit configuration of backup directory

Including the relative path that was broken until a recent commit. --- test/T530-upgrade.sh | 19 +++ 1 file changed, 19 insertions(+) diff --git a/test/T530-upgrade.sh b/test/T530-upgrade.sh index cce29f45..5f0de2ed 100755 --- a/test/T530-upgrade.sh +++ b/test/T530-upgrade.sh @@

[PATCH 9/9] NEWS: start NEWS for 0.32.1

--- NEWS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS b/NEWS index 8cb9b345..44a18951 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,10 @@ +Notmuch 0.32.1 (UNRELEASED) +=== + +Restore handling of relative values for `database.path` that was +broken by 0.32. Exte

[PATCH 2/9] lib/config: canonicalize paths relative to $HOME.

Prior to 0.32, notmuch had the (undocumented) behaviour that it expanded a relative value of database.path with respect to $HOME. In 0.32 this was special cased for database.path but broken for database.mail_root, which causes problems for at least notmuch-new when database.path is set to a relativ

[PATCH 7/9] doc: document (tersely) the intended behaviour of relative paths.

--- doc/man1/notmuch-config.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/man1/notmuch-config.rst b/doc/man1/notmuch-config.rst index 32290a38..5cb6e203 100644 --- a/doc/man1/notmuch-config.rst +++ b/doc/man1/notmuch-config.rst @@ -44,7 +44,9 @@ configuration file

[PATCH 1/9] test: add known broken test for relative database path in new

This test highlights a bug introduced in 0.32. The new split between path and mail_root does not properly canonicalize relative paths in the latter. --- test/T050-new.sh | 13 + 1 file changed, 13 insertions(+) diff --git a/test/T050-new.sh b/test/T050-new.sh index 2985e24c..5faf6839

Restore relative path handling for database.path

Release 0.32 broke (at least) `notmuch new` if database.path has a relative value. Although support for relative paths was undocumented, it was introduced as an easier (to implement) alternative to ~ expansion. Restore the pre-0.32 functionality, and treat path config items introduced in 0.32 cons