Re: [PATCH 0/5] doc: man page cleanup

2021-05-22 Thread David Bremner
Jani Nikula writes: > On Sat, 22 May 2021, David Bremner wrote: >> Jani Nikula writes: >>> On Sat, 22 May 2021, David Bremner wrote: >>> I was wondering about that myself. Should I respin with that? >>> >> >> Either that or an addon to the series, whatever is easiest. > > If I get to choose, I

Re: [PATCH 0/5] doc: man page cleanup

2021-05-22 Thread Jani Nikula
On Sat, 22 May 2021, David Bremner wrote: > Jani Nikula writes: >> On Sat, 22 May 2021, David Bremner wrote: >> I was wondering about that myself. Should I respin with that? >> > > Either that or an addon to the series, whatever is easiest. If I get to choose, I'll take the latter. ;) BR, Jani

Re: [PATCH 0/5] doc: man page cleanup

2021-05-22 Thread David Bremner
Jani Nikula writes: > On Sat, 22 May 2021, David Bremner wrote: >> Jani Nikula writes: >> >>> I saw [1] and decided to give it some love. :) >>> >>> Mostly this is all about adding html cross-references all over the place >>> while trying to keep the roff man pages roughly the same. Also updati

Re: [PATCH] test: say_color() in one write(2)

2021-05-22 Thread David Bremner
Tomi Ollila writes: > say_color() used to call (builtin) printf (and tput(1) to stdout) > several times, which caused attempts to write messages with color > to have partial content (e.g. escape sequences) often intermixed > with other tests when parallel tests were run. I still see things like:

Re: [PATCH 0/5] doc: man page cleanup

2021-05-22 Thread Jani Nikula
On Sat, 22 May 2021, David Bremner wrote: > Jani Nikula writes: > >> I saw [1] and decided to give it some love. :) >> >> Mostly this is all about adding html cross-references all over the place >> while trying to keep the roff man pages roughly the same. Also updating >> the man page rst becomes

Re: [PATCH 0/5] doc: man page cleanup

2021-05-22 Thread David Bremner
Jani Nikula writes: > I saw [1] and decided to give it some love. :) > > Mostly this is all about adding html cross-references all over the place > while trying to keep the roff man pages roughly the same. Also updating > the man page rst becomes easier by setting a clean example. > > BR, > Jani.

Re: [PATCH] test: source $NOTMUCH_BUILDDIR/test/test-lib-emacs.sh

2021-05-22 Thread Tomi Ollila
On Sat, May 22 2021, Tomi Ollila wrote: > Sourcing test-lib.sh will cd to TMP_DIRECTORY, so > relative path in $0 will not work in previous version > . $(dirname "$0")/test-lib-emacs.sh > > Now individual test scripts -- e.g. ./test/T310-emacs.sh > will work. > --- > test/T160-json.sh

Re: [PATCH] emacs: PATCH [1/2] mail user agent

2021-05-22 Thread Tory S. Anderson
I'm coming from very limited experience here -- gnus is the only MUA I've used -- but I'd be surprised if it's common practice to hijack a setting to set the MUA to something. As far as ripping the bandage off, I've followed that strategy many times in my professional life, but have come to dis

[PATCH] test: source $NOTMUCH_BUILDDIR/test/test-lib-emacs.sh

2021-05-22 Thread Tomi Ollila
Sourcing test-lib.sh will cd to TMP_DIRECTORY, so relative path in $0 will not work in previous version . $(dirname "$0")/test-lib-emacs.sh Now individual test scripts -- e.g. ./test/T310-emacs.sh will work. --- test/T160-json.sh | 2 +- test/T170-sexp.sh

[PATCH 1/2] test-lib-emacs: re-define test_emacs() after initialization

2021-05-22 Thread Tomi Ollila
After test_emacs() has started emacs, it re-defines itself as just calling the started emacs. First call to test_emacs() will execute to the end of it; next calls will just execute the 2 lines, first clearing OUTPUT, second and last executing TEST_EMACSCLIENT... This simplifies away one if constr

[PATCH v5] test: replace notmuch_passwd_sanitize() with _libconfig_sanitize()

2021-05-22 Thread Tomi Ollila
notmuch_passwd_sanitize() in test-lib.sh is too generic, it cannot work in many cases... The more specific version _libconfig_sanitize() replaces it in T590-libconfig.sh and the code that uses it is modified to output the keys (ascending numbers printed in hex) so the sanitizer knows what to sanit

Re: [PATCH] emacs: PATCH [1/2] mail user agent

2021-05-22 Thread Tomi Ollila
On Sat, May 22 2021, David Bremner wrote: > web...@toryanderson.com (Tory S. Anderson) writes: > >> >> +(defcustom notmuch-mail-user-agent 'notmuch-user-agent >> + "The mail user-agent to use when creating mail after using Notmuch. For >> historical purposes, the default is 'notmuch-user-agent

Re: [PATCH] test: add known broken test for duplicate thread-id terms

2021-05-22 Thread David Bremner
David Bremner writes: > According to my bijection, this bug has been present since commit > 411675a6ce in 2017. It is apparently harmless for regular use, but > does make notmuch crash when compiled with -DDEBUG_DATABASE_SANITY. applied to master, with updates to commit message and shell script

Re: [PATCH] ruby: improve compilation with CFLAGS

2021-05-22 Thread David Bremner
David Bremner writes: > Felipe Contreras writes: > >> The ruby MakeMakefile generates a makefile that is suboptimal, which has >> CFLAGS like this: >> >> CFLAGS = $(CCDLFLAGS) -march=x86-64 -mtune=generic \ >> -O2 -pipe -fno-plt -fPIC $(ARCH_FLAG) > > Ruby 2.7 doesn't seem to add -fno-pl

Re: [PATCH] emacs: PATCH [1/2] mail user agent

2021-05-22 Thread David Bremner
web...@toryanderson.com (Tory S. Anderson) writes: > > +(defcustom notmuch-mail-user-agent 'notmuch-user-agent > + "The mail user-agent to use when creating mail after using Notmuch. For > historical purposes, the default is 'notmuch-user-agent" > + :group 'notmuch) > ;;; Mime Utilities >

Re: [PATCH v4] test: replace notmuch_passwd_sanitize() with _libconfig_sanitize()

2021-05-22 Thread David Bremner
Tomi Ollila writes: > cat < c_head > #include > #include > @@ -380,26 +399,26 @@ cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} '' > %NULL% >key < NOTMUCH_CONFIG_LAST; >key = (notmuch_config_key_t)(key + 1)) { > const char *val = notmuch_config_get (db, key); > -

Re: [PATCH] configure: $(CC) -o /dev/null when output not run

2021-05-22 Thread David Bremner
Tomi Ollila writes: > When C compilation is used just to see whether compilation > succeeds, there is no need to write any output file. > > Some compilations in configure already did this. > > Now also rm -f lines are used more consistently. > > While at it reformatted code that prints > LIBNOTMU

[PATCH] lib: update transaction documentation

2021-05-22 Thread David Bremner
Partly this is to recognize the semantics we inherit from Xapian, partly to mention the new autocommit feature. --- lib/notmuch.h | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/notmuch.h b/lib/notmuch.h index 5c3be342..3b28bea3 100644 --- a/lib/notmuch.h ++

Re: [PATCH 0/2] ruby: enable garbage collection

2021-05-22 Thread David Bremner
Felipe Contreras writes: > Ruby is a gc language, we shouldn't be doing workaround to free memory when > Ruby is perfectly > capable of doing so. > > The problem is that talloc wants to be smart, and Ruby and talloc both fight > to free memory. We can > let Ruby win by stealing all the objects