Re: [PATCH] emacs: notmuch-tree: mark the initial message at point as read

Jonas Bernoulli writes: > > Please merge the proposed fix; IMO it is sound. My follow-up, the reply > to Tomi, seems quite confused though. But just because we are uncertain > whether there is further room for improvement, that shouldn't keep us > from fixing the bug. Maybe in the future we

Re: [PATCH] emacs: remove useless lexically bound variable

David Bremner writes: > A let binding without a value is just an obfuscated way of saying > nil, especially if you are not going to mutate the variable. applied to master ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email

[PATCH 5/5] emacs: shorten lines in two doc-strings

The byte-compiler wasn't happy about those. --- emacs/notmuch-draft.el | 2 +- emacs/notmuch-hello.el | 8 +--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/emacs/notmuch-draft.el b/emacs/notmuch-draft.el index a68b7d8d..aeb6c588 100644 --- a/emacs/notmuch-draft.el +++

[PATCH 4/5] emacs: notmuch-show-pipe-message: cosmetics

--- emacs/notmuch-show.el | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 9a95eb34..b14db1dd 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -2076,19 +2076,19 @@ (defun

[PATCH 3/5] emacs: fix some option type declarations

Also improve their doc-strings. --- emacs/notmuch-tree.el | 66 +-- emacs/notmuch.el | 13 + 2 files changed, 47 insertions(+), 32 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index b288c05d..d11ef38c 100644 ---

[PATCH 2/5] emacs: add some function declarations

--- emacs/notmuch-jump.el | 4 1 file changed, 4 insertions(+) diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el index c0760638..555ecd1f 100644 --- a/emacs/notmuch-jump.el +++ b/emacs/notmuch-jump.el @@ -25,6 +25,10 @@ (require 'notmuch-lib) (require 'notmuch-hello)

[PATCH 1/5] emacs: use closures instead of backquoted lambdas

--- emacs/notmuch-hello.el | 16 emacs/notmuch-jump.el | 26 ++ emacs/notmuch-tag.el | 2 +- 3 files changed, 23 insertions(+), 21 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 1e66555b..c1b67e22 100644 ---

[PATCH 0/5] Use closures and other emacs cleanup

Some assorted emacs cleanup and fixes. The big one is the switch to using closures instead of backquoted lambdas. The other commits for the most part just deal with things the compiler complained about. Jonas Bernoulli (5): emacs: use closures instead of backquoted lambdas emacs: add some

Re: [PATCH] emacs: notmuch-tree: mark the initial message at point as read

David Bremner writes: > Jonas Bernoulli writes: > >> Hm, when no tree buffer is involved, then `notmuch-show-command-hook' >> probably is required. Anyway, there seems to be some undead code and >> rethinking all this would be a good idea. > > I'm not sure I followed the discussion, but I'm

Re: [PATCH] emacs: remove useless lexically bound variable

+1 (I was gonna suggest the same change.) David Bremner writes: > A let binding without a value is just an obfuscated way of saying > nil, especially if you are not going to mutate the variable. > --- > emacs/notmuch-tree.el | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > >