[PATCH 2/3] ruby: don't use a directory as a target.

2021-10-30 Thread David Bremner
The directory is (neccesarily) not updated by the build, so it keeps trying to build. The proposed fix is to use the name of the dynamic library containing the extension. This is a partial fix for the rebuilding reported at [1]. [1]: id:87r29wwgq2@fifthhorseman.net --- bindings/Makefile.loca

[PATCH 3/3] python-cffi: introduce stamp file

2021-10-30 Thread David Bremner
Although the rebuild does not take long, it is a bit noisy, so assume if it succeeds once, it doesn't need to re-invoke setup.py until the shared library is rebuilt. This is a partial fix for [1]. [1]: id:87r29wwgq2@fifthhorseman.net --- bindings/Makefile.local | 9 ++--- 1 file changed,

[PATCH 1/3] doc: introduce stamp file for info build

2021-10-30 Thread David Bremner
This partially fixes (i.e. just for sphinx) the problem reported by Daniel in id:87r29wwgq2@fifthhorseman.net. --- doc/Makefile.local | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/Makefile.local b/doc/Makefile.local index f476d1da..12e83140 100644 --- a/doc/Mak

Add stamp files to prevent rebuilds

2021-10-30 Thread David Bremner
There are several places where the current Makefiles either have a dependency on a phony target, or on a directory. Both of these lead to constant rebuilds. Stamp files are not the most elegant solution, but it seems to prevent the rebuilds. ___ notmuc

Re: parallel tests broken on Debian stable

2021-10-30 Thread David Bremner
David Bremner writes: > In a debian stretch neither gnu parallel nor moreutils parallel > successfully completes the tests. Logs are attached. One thing worth > investigating is that gnu parallel inside timeout doesn't really work > right, since it says something like I can't figure out if this

[PATCH v2] emacs: drop C-tab binding in hello mode, document .

2021-10-30 Thread David Bremner
The binding has always been there, but the docs were apparently mistakenly changed to say [1] Revert to in the documentation. The commit also drops the C- binding, since it seems redundant and it interferes with tab-bar-mode. [1]: 703dec7754da477b5683867c88cb940b8553be91. --- doc/notmuch-ema

Re: [PATCH] emacs: drop C-tab binding in hello mode, document .

2021-10-30 Thread David Bremner
Ralph Seichter writes: > * David Bremner: > >> - >> + > > Are you sure you mean "backstab" with an "s"? I am currently watching a > newbie play Dark Souls, so I am unsure. ;-) > Hah, thanks for the correction. d ___ notmuch mailing list -- not

[PATCH] rename built_with.sexpr_query to built_with.sexp_queries

2021-10-30 Thread David Bremner
It is confusing to use two different names (sexp vs sexpr) when compared with the command line option --query=sexp and (furthermore) singular vs plural when compared with the man page title. --- doc/man7/notmuch-sexp-queries.rst | 2 +- lib/built-with.c | 2 +- notmuch-config.c

Re: [PATCH] emacs: drop C-tab binding in hello mode, document .

2021-10-30 Thread Ralph Seichter
* David Bremner: > - > + Are you sure you mean "backstab" with an "s"? I am currently watching a newbie play Dark Souls, so I am unsure. ;-) -Ralph ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le..

[PATCH] emacs: drop C-tab binding in hello mode, document .

2021-10-30 Thread David Bremner
The binding has always been there, but the docs were apparently mistakenly changed to say [1] Revert to in the documentation. The commit also drops the C- binding, since it seems redundant and it (apparently) interferes with tabbar mode. [1]: 703dec7754da477b5683867c88cb940b8553be91. --- doc

Re: [PATCH] emacs: add minimal docstring for notmuch-unthreaded

2021-10-30 Thread David Bremner
David Bremner writes: > The missing docstring causes a blank in the notmuch-help display > [1]. Since the function is a simple wrapper for notmuch-tree, it seems > fair to forward the reader there for more detailed information. series applied to master. d ___

Re: [PATCH 1/2] lib/compact: replace deprecated notmuch_database_open_verbose

2021-10-30 Thread David Bremner
David Bremner writes: > It should not be necesary to have any config information here, hence > passing "" to n_d_open_with_config. series applied to master (since that's where the deprecation warnings are). ___ notmuch mailing list -- notmuch@notmuchma

Re: [PATCH] lib: document n_o_w_config can return NOTMUCH_STATUS_NO_CONFIG

2021-10-30 Thread David Bremner
David Bremner writes: > This should be treated as fatal by callers, since we didn't succeed in > opening a Xapian database. patch applied (with an extra *, thanks to check-notmuch-commit) to release and master. ___ notmuch mailing list -- notmuch@notmu

Re: Clean up de-allocation / nulling of notmuch database structure

2021-10-30 Thread David Bremner
David Bremner writes: > Notmuch 0.32 introduced some bugs in the handling of the > notmuch_database_t output parameters. We didn't see them in the > notmuch CLI, but they caused some crashes for neomutt. This series > attempts to clean up those problems. > > I plan to do a point release with this

[PATCH 3/4] test: add known broken tests for python bindings in split configs

2021-10-30 Thread David Bremner
This reproduces the bug(s) reported in id:87h7d4wp6b@tethera.net --- test/T055-path-config.sh | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/test/T055-path-config.sh b/test/T055-path-config.sh index ef22e964..d6494b92 100755 --- a/test/T055-path-config.

[PATCH 4/4] python-cffi: switch to notmuch_database_{open,create}_with_config

2021-10-30 Thread David Bremner
Since release 0.32, libnotmuch provides searching for database and configuration paths. This commit changes the python module notmuch2 to use those facilities. This fixes the bug reported in [1], along with a couple of the deprecation warnings in the python bindings. Database.default_path is depr

[PATCH 1/4] python-cffi: fix typos in docstring for Database.default_path

2021-10-30 Thread David Bremner
These generate warnings from sphinx doc, which makes it harder to debug documentation changes. They also corrupt the output. --- bindings/python-cffi/notmuch2/_database.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bindings/python-cffi/notmuch2/_database.py b/bindin

[PATCH 2/4] test: add python-cffi bindings to path for test_python

2021-10-30 Thread David Bremner
This will allow testing the new python bindings using test_python, in addition to the current invocation of pytest. --- test/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 32f710a5..e476a69b 100644 --- a/test/test-lib.sh ++

Use libnotmuch config / database search in python-cffi bindings

2021-10-30 Thread David Bremner
This is my first "serious" attempt at modifying the python-cffi bindings, so I would appreciate feedback, particularly on the API changes. In my dev branch this is applied on top the series [1] and the patch [2]. The first is mandatory, the second might be optional, I didn't test. [1]: id:202110

Re: [PATCH] emacs: don't add space to tag completion candidates.

2021-10-30 Thread David Bremner
"inwit" writes: > Works as expected under selectrum! Thanks! > > right, I guess the question is how annoying it is for users of standard emacs completion. I generally enter one tag at a time, so it won't really affect me. d ___ notmuch mailing list --