Re: [PATCH 2/2] python-cffi: returned OwnedMessage objects from Message.replies
Floris Bruynooghe writes: > On Sun 09 Jan 2022 at 09:26 -0400, David Bremner wrote: >> One thing I would like to think >> about is the length of time it takes to run the pytests. It is not >> currently the bottleneck in running the parallel tests for me, but it is >> among the slower T*.sh. So it might be nice at some point to split into >> several invocations for pytest, assuming multiple invocations of pytest >> can run in parallel. > > There is the pytest-xdist plugin which is widely used and probably will > work fine on the notmuch testsuite (I even contributed to the plugin at > some point). It will split the workload between however many processes > you choose, running them in parallel. It sounds like it has potential, but I'm not sure how it would interact with the existing scheme controlled by make. I suspect we'd end up with too many processes/threads in total. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH] test/gpgsm: use --with-colons when calculating fingerprint.
As stressed by the gpg documentation, the non-'with-colons' output
format is subject to change, and indeed it did in 2.3.x (x<=3). This
should make the the test suite more robust against such changes.
---
test/test-lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 6bc0b723..f1275b85 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -145,7 +145,7 @@ add_gpgsm_home () {
mkdir -p -m 0700 "$GNUPGHOME"
gpgsm --batch --no-tty --no-common-certs-import --pinentry-mode=loopback
--passphrase-fd 3 \
--disable-dirmngr --import >"$GNUPGHOME"/import.log 2>&1 3<<<''
<$NOTMUCH_SRCDIR/test/smime/0xE0972A47.p12
-fpr=$(gpgsm --batch --list-key test_su...@notmuchmail.org | sed -n
's/.*fingerprint: //p')
+fpr=$(gpgsm --batch --with-colons --list-key test_su...@notmuchmail.org |
awk -F: '/^fpr/ {print $10}')
echo "$fpr S relax" >> "$GNUPGHOME/trustlist.txt"
gpgsm --quiet --batch --no-tty --no-common-certs-import --disable-dirmngr
--import < $NOTMUCH_SRCDIR/test/smime/ca.crt
echo "4D:E0:FF:63:C0:E9:EC:01:29:11:C8:7A:EE:DA:3A:9A:7F:6E:C1:0D S" >>
"$GNUPGHOME/trustlist.txt"
--
2.34.1
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 2/2] python-cffi: returned OwnedMessage objects from Message.replies
On Sun 09 Jan 2022 at 09:26 -0400, David Bremner wrote: > One thing I would like to think > about is the length of time it takes to run the pytests. It is not > currently the bottleneck in running the parallel tests for me, but it is > among the slower T*.sh. So it might be nice at some point to split into > several invocations for pytest, assuming multiple invocations of pytest > can run in parallel. There is the pytest-xdist plugin which is widely used and probably will work fine on the notmuch testsuite (I even contributed to the plugin at some point). It will split the workload between however many processes you choose, running them in parallel. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] configure: Ignore more options that Fedora spec macros expect
Tomi Ollila writes: > On Tue, Jan 11 2022, michaeljgruber wrote: > >> From: Michael J Gruber >> >> Signed-off-by: Michael J Gruber >> --- > > LGTM. > > Tomi applied to master. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] configure: Ignore more options that Fedora spec macros expect
On Tue, Jan 11 2022, michaeljgruber wrote:
> From: Michael J Gruber
>
> Signed-off-by: Michael J Gruber
> ---
LGTM.
Tomi
> This allows the Fedora packager to use the standard Fedora packaging
> macros rather than a hand-tailored configure call.
>
> [Sorry for resend, my mails don't seem to get through, again.]
>
> configure | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/configure b/configure
> index e7bb7edc..9e45cbe6 100755
> --- a/configure
> +++ b/configure
> @@ -312,12 +312,22 @@ for option; do
> true
> elif [ "${option%%=*}" = '--host' ] ; then
> true
> +elif [ "${option%%=*}" = '--bindir' ] ; then
> + true
> +elif [ "${option%%=*}" = '--sbindir' ] ; then
> + true
> elif [ "${option%%=*}" = '--datadir' ] ; then
> true
> elif [ "${option%%=*}" = '--localstatedir' ] ; then
> true
> +elif [ "${option%%=*}" = '--sharedstatedir' ] ; then
> + true
> elif [ "${option%%=*}" = '--libexecdir' ] ; then
> true
> +elif [ "${option%%=*}" = '--exec-prefix' ] ; then
> + true
> +elif [ "${option%%=*}" = '--program-prefix' ] ; then
> + true
> elif [ "${option}" = '--disable-maintainer-mode' ] ; then
> true
> elif [ "${option}" = '--disable-dependency-tracking' ] ; then
> --
> 2.34.1.653.g3264c0b0fb
>
> ___
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-le...@notmuchmail.org
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] test: fix support for gpgsm in gnupg 2.3
Stig Palmquist writes:
> gpgsm --list-keys output changed the label for fingerprints from
> "fingerprint: " to "sha[12] fpr: " breaking tests with gnupg 2.3. this
> adds support for both.
> ---
> test/test-lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 6bc0b723..3de608f9 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -145,7 +145,7 @@ add_gpgsm_home () {
> mkdir -p -m 0700 "$GNUPGHOME"
> gpgsm --batch --no-tty --no-common-certs-import --pinentry-mode=loopback
> --passphrase-fd 3 \
> --disable-dirmngr --import >"$GNUPGHOME"/import.log 2>&1 3<<<''
> <$NOTMUCH_SRCDIR/test/smime/0xE0972A47.p12
> -fpr=$(gpgsm --batch --list-key test_su...@notmuchmail.org | sed -n
> 's/.*fingerprint: //p')
> +fpr=$(gpgsm --batch --list-key test_su...@notmuchmail.org | sed -n
> 's/.*\(fingerprint\|sha1 fpr\): //p')
Thanks for the patch. It occurs to me that we should probably use
--with-colons to avoid future issues like this. It looks like we wabt
the row labelled "fpr"; I assume this has not changed with 2.3?
d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH] test: fix support for gpgsm in gnupg 2.3
gpgsm --list-keys output changed the label for fingerprints from
"fingerprint: " to "sha[12] fpr: " breaking tests with gnupg 2.3. this
adds support for both.
---
test/test-lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 6bc0b723..3de608f9 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -145,7 +145,7 @@ add_gpgsm_home () {
mkdir -p -m 0700 "$GNUPGHOME"
gpgsm --batch --no-tty --no-common-certs-import --pinentry-mode=loopback
--passphrase-fd 3 \
--disable-dirmngr --import >"$GNUPGHOME"/import.log 2>&1 3<<<''
<$NOTMUCH_SRCDIR/test/smime/0xE0972A47.p12
-fpr=$(gpgsm --batch --list-key test_su...@notmuchmail.org | sed -n
's/.*fingerprint: //p')
+fpr=$(gpgsm --batch --list-key test_su...@notmuchmail.org | sed -n
's/.*\(fingerprint\|sha1 fpr\): //p')
echo "$fpr S relax" >> "$GNUPGHOME/trustlist.txt"
gpgsm --quiet --batch --no-tty --no-common-certs-import --disable-dirmngr
--import < $NOTMUCH_SRCDIR/test/smime/ca.crt
echo "4D:E0:FF:63:C0:E9:EC:01:29:11:C8:7A:EE:DA:3A:9A:7F:6E:C1:0D S" >>
"$GNUPGHOME/trustlist.txt"
--
2.34.1
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH] configure: Ignore more options that Fedora spec macros expect
From: Michael J Gruber
Signed-off-by: Michael J Gruber
---
This allows the Fedora packager to use the standard Fedora packaging
macros rather than a hand-tailored configure call.
[Sorry for resend, my mails don't seem to get through, again.]
configure | 10 ++
1 file changed, 10 insertions(+)
diff --git a/configure b/configure
index e7bb7edc..9e45cbe6 100755
--- a/configure
+++ b/configure
@@ -312,12 +312,22 @@ for option; do
true
elif [ "${option%%=*}" = '--host' ] ; then
true
+elif [ "${option%%=*}" = '--bindir' ] ; then
+ true
+elif [ "${option%%=*}" = '--sbindir' ] ; then
+ true
elif [ "${option%%=*}" = '--datadir' ] ; then
true
elif [ "${option%%=*}" = '--localstatedir' ] ; then
true
+elif [ "${option%%=*}" = '--sharedstatedir' ] ; then
+ true
elif [ "${option%%=*}" = '--libexecdir' ] ; then
true
+elif [ "${option%%=*}" = '--exec-prefix' ] ; then
+ true
+elif [ "${option%%=*}" = '--program-prefix' ] ; then
+ true
elif [ "${option}" = '--disable-maintainer-mode' ] ; then
true
elif [ "${option}" = '--disable-dependency-tracking' ] ; then
--
2.34.1.653.g3264c0b0fb
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org
