[Utkarsh Singh] Re: [PATCH] emacs: Add more front ends for address completion

2022-02-09 Thread Utkarsh Singh
Start of forwarded message From: Utkarsh Singh To: Tomi Ollila Subject: Re: [PATCH] emacs: Add more front ends for address completion Date: Thu, 10 Feb 2022 08:58:49 +0530 Hello Tomi, On 2022-02-09, 23:59 +0200, Tomi Ollila wrote: > On Tue, Feb 08

Re: [PATCH 2/4] test: due not pass T380.1 for the wrong reasons

2022-02-09 Thread David Bremner
Michael J Gruber writes: > If gdb is missing then some files are never written to so that the > comparisons of non-existing files succeeds for the wrong reason, > claiming that `notmch new` is idempotent when it was in fact never run. > > Catch this and (for lack of a better spot) set up the

Re: [PATCH] emacs: Add more front ends for address completion

2022-02-09 Thread Tomi Ollila
On Tue, Feb 08 2022, Utkarsh Singh wrote: > Hello maintainers, > > Emacs Lisp Package Archive (ELPA) now includes a package called 'corfu', > according to its documentation: > > Corfu enhances the default completion in region function with a > completion overlay. The current

Re: [PATCH 4/4] test: set up the outcount file for T380.1

2022-02-09 Thread Tomi Ollila
On Wed, Feb 09 2022, Michael J. Gruber wrote: > If gdb is present but for some reason `atomicity.py` fails to write to > the output file then the test fails with some ugly bash errors in the > wrong places (because the outcount variable is empty). > > Therefore, set up the outcount file with `0`

Re: [PATCH 3/4] test: reword T380.2 to be clearer

2022-02-09 Thread Tomi Ollila
On Wed, Feb 09 2022, Michael J. Gruber wrote: > T380.2 gives a test description which depends on the actual test output, > rather than the expected outcome or actual test which is performed. > > So, when the test fails due missing abort points, the test describes > itself as `detected 0>10 abort

Re: [PATCH 2/4] test: due not pass T380.1 for the wrong reasons

2022-02-09 Thread Tomi Ollila
On Wed, Feb 09 2022, Michael J. Gruber wrote: > If gdb is missing then some files are never written to so that the > comparisons of non-existing files succeeds for the wrong reason, > claiming that `notmch new` is idempotent when it was in fact never run. > > Catch this and (for lack of a better

Re: [PATCH 1/4] test: correct comparison order in T380

2022-02-09 Thread Tomi Ollila
On Wed, Feb 09 2022, Michael J. Gruber wrote: > Specifying test comparisons as "expected actual" gives a better readable > diff since the "-" indicates missing, "+" additional items compared to > the expectations. > > Signed-off-by: Michael J Gruber > --- > test/T380-atomicity.sh | 2 +- > 1

[PATCH 1/4] test: correct comparison order in T380

2022-02-09 Thread Michael J Gruber
Specifying test comparisons as "expected actual" gives a better readable diff since the "-" indicates missing, "+" additional items compared to the expectations. Signed-off-by: Michael J Gruber --- test/T380-atomicity.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/4] test: reword T380.2 to be clearer

2022-02-09 Thread Michael J Gruber
T380.2 gives a test description which depends on the actual test output, rather than the expected outcome or actual test which is performed. So, when the test fails due missing abort points, the test describes itself as `detected 0>10 abort points` so that it's not clear which part or which

[PATCH 2/4] test: due not pass T380.1 for the wrong reasons

2022-02-09 Thread Michael J Gruber
If gdb is missing then some files are never written to so that the comparisons of non-existing files succeeds for the wrong reason, claiming that `notmch new` is idempotent when it was in fact never run. Catch this and (for lack of a better spot) set up the files with a reason for the FAIL.

[PATCH 4/4] test: set up the outcount file for T380.1

2022-02-09 Thread Michael J Gruber
If gdb is present but for some reason `atomicity.py` fails to write to the output file then the test fails with some ugly bash errors in the wrong places (because the outcount variable is empty). Therefore, set up the outcount file with `0` to get the test script to rund and the test to fail fpr

[PATCH 0/4] test: T380 rework

2022-02-09 Thread Michael J Gruber
I've been testing with tests now (duh), i.e. enabling the tests for regular Fedora distribution builds. This seems to be mostly OK, no flaky fails so far. asan works locally (on x86_64) but we don't release build with asan; and we don't have sfsexp in Fedora yet (working on it). All other tests

Re: fcc and external attachments

2022-02-09 Thread Alfredo Finelli
David Bremner writes: > It seems likely this is an unintended consequence of > da302e1cbaaab89b2bbb32c0f59e1aa6ee708455. > > Since notmuch-emacs does it's own Fcc processing, it's a bit > hit-and-miss whether a given message-fcc-* variable is respected. I'll > have a look at how hard it is to