[PATCH] nmbug: write tags out to a temporary file, not 'nmbug.index'

If more than nmbug process is running at once, then each will try to read and write the same file. The particular failure I've seen is that the process which finishes first deletes nmbug.index, and then the other process dies with a FileNotFoundError. So use a distinct temporary file per process.

Re: [PATCH] emacs: remove png logo

David Bremner writes: > Reduce chance of downstream packagers packing the wrong file. > --- I have applied this master. People automatically packaging master will need up update their packaging rules to take the svg logo instead of the png. In fact such packaging was already broken since the pn

Re: Test suite timing issues?

On Sat, Feb 12 2022, David Bremner wrote: > Tomi Ollila writes: > >> >> Does such a change hide "buggy" functionality ? > > We mostly don't use add_message, call notmuch new via NOTMUCH_NEW in > T050-new.sh. So I think it would mostly not hide bugs in notmuch > new. OTOH, I'm surprised the same i

Re: Test suite timing issues?

Am Sa., 12. Feb. 2022 um 22:10 Uhr schrieb David Bremner : > Tomi Ollila writes: > > > > > Does such a change hide "buggy" functionality ? > > We mostly don't use add_message, call notmuch new via NOTMUCH_NEW in > T050-new.sh. So I think it would mostly not hide bugs in notmuch > new. OTOH, I'm s

Re: [Utkarsh Singh] Re: [PATCH] emacs: Add more front ends for address completion

On Fri, Feb 11 2022, Utkarsh Singh wrote: > On 2022-02-10, 19:37 +0200, Tomi Ollila wrote: > >> >> When doing in notmuch repo, one can execute ./devel/try-emacs-mua -Q >> >> ... which probably uses the same package database (under $HOME) as any >> other emacs invocation would do -- what is the wa

Re: Test suite timing issues?

Tomi Ollila writes: > > Does such a change hide "buggy" functionality ? We mostly don't use add_message, call notmuch new via NOTMUCH_NEW in T050-new.sh. So I think it would mostly not hide bugs in notmuch new. OTOH, I'm surprised the same issues with timestamps don't show up there, if that is r

Re: Test suite timing issues?

Am Sa., 12. Feb. 2022 um 21:45 Uhr schrieb Tomi Ollila : > On Sat, Feb 12 2022, David Bremner wrote: > > > Tomi Ollila writes: > > > >> On Sat, Feb 12 2022, Michael J. Gruber wrote: > >> > >> Only thing that came into mind are directory timestamps... if directory > >> (m)time is same as before no

Re: Test suite timing issues?

On Sat, Feb 12 2022, David Bremner wrote: > Tomi Ollila writes: > >> On Sat, Feb 12 2022, Michael J. Gruber wrote: >> >> Only thing that came into mind are directory timestamps... if directory >> (m)time is same as before notmuch will not scan it for files... >> >> ... following that if the granu

Re: [PATCH 2/4] test: due not pass T380.1 for the wrong reasons

Michael J Gruber writes: > When analysing this, I was confused by the way > test_require_external_prereq works and the "if" in T380 (as opposed to how > test_require_external_prereq is used in other tests). Over at git.git, > we have test setup code in functions which don't get executed if > pre

[PATCH v4 10/11] emacs: Document undo binding.

This messes up whitespace, which will require a global change to fix. --- devel/emacs-keybindings.org | 1 + doc/notmuch-emacs.rst | 2 ++ 2 files changed, 3 insertions(+) diff --git a/devel/emacs-keybindings.org b/devel/emacs-keybindings.org index 2f73a198..7f0d26bb 100644 --- a/devel/emac

[PATCH v4 04/11] perf-test: allow running test_emacs from performance test suite.

test_require_external prereq has to move to test-lib-common.sh, and the new shell functions print_emacs_header and time_emacs are provided. The somewhat indirect way of printing the output is to avoid the extra "" present on string values from emacsclient. --- performance-test/perf-test-lib.sh |

[PATCH v4 08/11] emacs: add notmuch-tag-undo

Keybindings are deferred to a future commit. --- doc/notmuch-emacs.rst | 15 emacs/notmuch-tag.el | 14 +++ test/T315-emacs-tagging.sh | 50 ++ 3 files changed, 79 insertions(+) diff --git a/doc/notmuch-emacs.rst b/doc/notmuch-em

[PATCH v4 07/11] emacs/tag: keep tag history

This buffer local list will be used to provide an undo facility for tagging operations. Keeping history can be disabled with the new OMIT-HIST option. --- emacs/notmuch-tag.el | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/emacs/notmuch-tag.el b/em

[PATCH v4 11/11] emacs: whitespace cleanup for keybindings

Changing the width of a column requires rewriting all the rows. --- devel/emacs-keybindings.org | 116 ++-- 1 file changed, 58 insertions(+), 58 deletions(-) diff --git a/devel/emacs-keybindings.org b/devel/emacs-keybindings.org index 7f0d26bb..00977bc3 100644 ---

[PATCH v4 03/11] test/emacs: split out tagging related tests

T310-emacs is one of the largest and longest running sets of tests. Splitting out the tagging operations will help maintainability as well as potentially improve the parallel running time of the test suite. Some slowdown in running the tests sequentially may result since there is repeated setup. --

[PATCH v4 09/11] emacs: redirect undo to notmuch-tag-undo

The double remap is a bit ugly, but it seems better than adding another layer of keymaps for those modes where notmuch-tag-undo makes sense. --- emacs/notmuch-hello.el | 3 +++ emacs/notmuch-lib.el | 1 + test/T315-emacs-tagging.sh | 11 ++- 3 files changed, 14 insertions(+), 1

[PATCH v4 05/11] perf-test: emacs tagging

Time tag operations, to see if it is worthwhile keeping both the batch and the non-batch calls to notmuch tag. --- performance-test/T06-emacs.sh | 21 + 1 file changed, 21 insertions(+) create mode 100755 performance-test/T06-emacs.sh diff --git a/performance-test/T06-emacs.s

[PATCH v4 06/11] emacs: remove non-batch code path from function notmuch-tag

It is no slower (according to T06-emacs) to use batch for everything, and it simplifies the code. --- emacs/notmuch-tag.el | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el index 8af09e68..ad0cb1c1 100644 --- a/e

[PATCH v4 02/11] test: split variable settings to their own file

This allows sharing more variable settings between the (correctness) tests and the performance-tests. Unfortunately it seems a bit tricky to move settings to test-lib-common.sh, as that is sourced late in test-lib.sh, and moving it earlier breaks things. --- performance-test/perf-test-lib.sh | 2

[PATCH v4 01/11] doc/emacs: add minimal documentation for notmuch-unthreaded mode.

If nothing else it means the mode is discoverable by browsing the documentation, and also provides a target for links when enumerating modes. --- doc/notmuch-emacs.rst | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/doc/notmuch-emacs.rst b/doc/notmuch-emacs.rst ind

v4 undo tagging

This obsoletes the series at id:20220203143254.3344753-1-da...@tethera.net. This revision includes a few commit message cleanups, and drops one patch to the emacs test-lib (it turns out it was unneeded for this simplified approach). ___ notmuch mailing

Re: Test suite timing issues?

David Bremner writes: > Tomi Ollila writes: > >> On Sat, Feb 12 2022, Michael J. Gruber wrote: >> >> Only thing that came into mind are directory timestamps... if directory >> (m)time is same as before notmuch will not scan it for files... >> >> ... following that if the granularity of directory

Re: [PATCH] emacs: Add more front ends for address completion

Tomi Ollila writes: > On Tue, Feb 08 2022, Utkarsh Singh wrote: > >> [...] >> Corfu enhances the default completion in region function with a >> completion overlay. The current candidates are shown in a popup >> below or above the point. Corfu is the minimalistic >>

Re: Test suite timing issues?

Tomi Ollila writes: > On Sat, Feb 12 2022, Michael J. Gruber wrote: > > Only thing that came into mind are directory timestamps... if directory > (m)time is same as before notmuch will not scan it for files... > > ... following that if the granularity of directory timestamp were 1 second, > then

Re: Test suite timing issues?

On Sat, Feb 12 2022, Michael J. Gruber wrote: > David Bremner venit, vidit, dixit 2022-02-12 01:03:00: >> Michael J Gruber writes: >> >> > Hi there, >> > >> > I'm trying to package notmuch for Redhat's enterprise linux and clones >> > (EPEL, extra packages for enterprise linux). >> > >> > This

Re: Debugging Starting Point for S/MIME Signature Verification?

David Bremner writes: > [...] > This should be fixed in Gmime commit > 0dfc44ad5b8f4eb1dbcfb010dddc02675a699ab8, although I haven't tested it > personally. If you want to test you will either need to build gmime from > source Head scratcher... > or wait for a gmime release. [...] I'll rather d

Re: Test suite timing issues?

Michael J Gruber writes: >> >> It's hard to see what can go wrong (maybe perl doesn't work?), but >> failing to generate a message should be a fatal error. Maybe try >> something like I was unclear. I meant "should" as in "in a perfect world", not as a prediction about the current code. So we sh

Re: Test suite timing issues?

David Bremner venit, vidit, dixit 2022-02-12 01:03:00: > Michael J Gruber writes: > > > Hi there, > > > > I'm trying to package notmuch for Redhat's enterprise linux and clones > > (EPEL, extra packages for enterprise linux). > > > > This looks mostly fine, including the tests, except for interm

Re: Questions regarding headers that may occur multiple times

mbw...@mailbox.org writes: TL;DR: yes, the things you think are not supported are not supported. > > it appears that only the first occurrence of these header values are > taken into account? Yes, we use g_mime_object_get_header, which "Gets the value of the first header with the specified name.

Re: WIP: filter out envelope headers in notmuch-insert.

David Bremner writes: > I thought about a more ambitious version that would replace any > existing "Return-Path" headers, but it seems like significantly more > work (the current code is not line based), and not obviously > better. Or maybe I missed the wording in the RFCs that talks about how >