Re: [bug]: notmuch-emacs: notmuch-show: "c F" shows same file name for different instances of duplicate messages

2022-08-04 Thread David Bremner
David Bremner writes: > Gregor Zattler writes: > >> Since the emails in this test case differ in Subjects they >> reveal another problem with showing different instances of >> seemingly same emails: While cycling through the three >> emails in notmuch show the Subject line is duly showed as >>

Re: [bug]: notmuch-emacs: notmuch-show: "c F" shows same file name for different instances of duplicate messages

2022-08-04 Thread David Bremner
Gregor Zattler writes: > Dear notmuch developers, > > the new feature of showing different instances of emails > with same Message-Id is great and very helpful. > > But in notmuch-emacs, when hitting "c F" in notmuch show > always stashes the very same filename, in my case the one > fitting the

[PATCH 3/3] emacs: add duplicate support to notmuch-show-view-raw-message

2022-08-04 Thread David Bremner
This fixes one of the bugs reported by Gregor in [1] [1]: id:87edxw8jp4.fsf@no.workgroup --- emacs/notmuch-show.el | 8 ++-- test/T450-emacs-show.sh | 1 - 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index e9a9ac2c..a6650678

[PATCH 2/3] emacs/show: provide a more friendly function to get duplicate num

2022-08-04 Thread David Bremner
There is not much code here, but at least we can fix the indexing as 1 based. --- emacs/notmuch-show.el | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 527db4bb..e9a9ac2c 100644 --- a/emacs/notmuch-show.el +++

[PATCH 1/3] test/emacs: add known broken test for viewing raw duplicate

2022-08-04 Thread David Bremner
This duplicates one of the bugs reported by Gregor in [1]. [1]: id:87edxw8jp4.fsf@no.workgroup --- test/T450-emacs-show.sh | 11 +++ 1 file changed, 11 insertions(+) diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh index ab611d56..83e902f1 100755 ---

[PATCH 2/2] emacs: update notmuch-show-get-filename to handle duplicates

2022-08-04 Thread David Bremner
This fixes one of the bugs reported by Gregor in [1]. [1]: id:87edxw8jp4.fsf@no.workgroup --- emacs/notmuch-show.el | 4 ++-- test/T450-emacs-show.sh | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 1bc3b319..527db4bb

[PATCH 1/2] test/emacs: add known broken test for stashing duplicate filename

2022-08-04 Thread David Bremner
This duplicates (no pun intended) one of the bugs reported by Gregor in id:87edxw8jp4.fsf@no.workgroup --- test/T450-emacs-show.sh | 9 + 1 file changed, 9 insertions(+) diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh index 37940c96..2cebd43d 100755 ---

[bug]: notmuch-emacs: notmuch-show: "c F" shows same file name for different instances of duplicate messages

2022-08-04 Thread Gregor Zattler
Dear notmuch developers, the new feature of showing different instances of emails with same Message-Id is great and very helpful. But in notmuch-emacs, when hitting "c F" in notmuch show always stashes the very same filename, in my case the one fitting the search term. Also hitting "V" in