Re: Embed elisp.py from flycheck, use it in notmuch-emacs doc
On Sun, Jul 31 2022, David Bremner wrote: > After finding myself spending a while trying to re-create one of the > features [0] of the el sphinx domain used in flycheck, I decided to try > just converting the docs to use that sphinx extension. > > As I remarked in 2018 [1], there doesn't seem to be a distributed > version of this sphinx extension. It also seems like the use-case in > notmuch is a bit different in terms of what we want to put in the > index, but perhaps someone better at sphinx than I could do those > customizations without modifying the extension (as this series does). > > Overall I think the quality of the resulting HTML documentation is > quite nice. The change in the info documentation is less clear. This > may also be tweakable, but in the first version the info docs seem > more verbose than necessary (e.g. writing "Key Binding" everywhere) On > the other hand, if it encourages people (e.g. me) to document things, > then it's probably a win overall. > > [0]: documenting both a keybinding and a function name with the same > directive, with nice index entries. This series is probably good; at least it does not break software (and if doc quality (or making of it) gets better then good :D) Tomi > > [1]: id:20180521200856.17103-1-da...@tethera.net > > > ___ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-le...@notmuchmail.org ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 2/2] emacs/show: restrict inlined mimetypes on refresh.
On Mon, Aug 01 2022, David Bremner wrote: > This fixes the bug reported by Al [1]. Essentially apply the same fix > as [2] in a different place. > > [1]: id:877d41nmr1@gmail.com > [2]: 90a7c1af368a527700dcde9b0dcbd760afc7bd92 LGTM. Tomi > --- > emacs/notmuch-show.el | 1 + > test/T450-emacs-show.sh | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 1bc3b319..c072e81d 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -1528,6 +1528,7 @@ non-nil) then the state of the buffer (open/closed > messages) is > reset based on the original query." >(interactive "P") >(let ((inhibit-read-only t) > + (mm-inline-override-types (notmuch--inline-override-types)) > (state (unless reset-state >(notmuch-show-capture-state > ;; `erase-buffer' does not seem to remove overlays, which can lead > diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh > index b77f8c0e..e161ee4f 100755 > --- a/test/T450-emacs-show.sh > +++ b/test/T450-emacs-show.sh > @@ -339,7 +339,6 @@ EOF > test_expect_equal_file EXPECTED OUTPUT > > test_begin_subtest "tar not inlined by default on refresh" > -test_subtest_known_broken > test_emacs '(notmuch-show "id:874llc2bkp@curie.anarc.at") > (notmuch-show-refresh-view) > (test-visible-output "OUTPUT")' > -- > 2.35.2 > > ___ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-le...@notmuchmail.org ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
