Re: [PATCH 1/2] test: compute expected keyid from fingerprint

2022-09-12 Thread Daniel Kahn Gillmor
On Sun 2022-09-11 23:50:18 +0200, Justus Winter wrote: > Tomi Ollila writes: > >> On Fri, Sep 09 2022, Justus Winter wrote: >> >>> --- >>> test/T350-crypto.sh | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh >>> index 3c6626b

Re: [PATCH 2/2] test: replace aging OpenPGP key used in the test suite

2022-09-12 Thread Daniel Kahn Gillmor
This series looks good to me. i've tested it and there are no failures, and there's nothing i can see that's obviously missing from it. Thanks for the thorough fix, Justus! A few notes about the change (none of them even close to being blockers): - i note that signature creation timestamps had

"-1 tests skipped"

2022-09-12 Thread Daniel Kahn Gillmor
I'm running the test suite on notmuch master (8eabd6388ecb7bea8246a9ba6943a0432d23406e), and i see the following report: ``` All 1758 tests behaved as expected (12 expected failures). -1 tests skipped. All tests in 2 files skipped. ``` -1 tests skipped is pretty strange! I haven't tracked it dow