Re: [PATCH] nmweb: escape subject in search view
David Bremner writes:
> Fix a bug reported by Jakub Wilk [1].
>
> [1]: id:20220822064717.qftn4tr7cs4r2...@jwilk.net
> ---
> devel/notmuch-web/nmweb.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devel/notmuch-web/nmweb.py b/devel/notmuch-web/nmweb.py
> index 928e4863..7b555c62 100755
> --- a/devel/notmuch-web/nmweb.py
> +++ b/devel/notmuch-web/nmweb.py
> @@ -131,7 +131,7 @@ env.globals['mailto_addrs'] = mailto_addrs
> def link_msg(msg):
>lnk = quote_plus(msg.messageid.encode('utf8'))
>try:
> -subj = msg.header('Subject')
> +subj = html.escape(msg.header('Subject'))
>except LookupError:
> subj = ""
>out = '%s' % (prefix, lnk, subj)
> --
> 2.35.2
I've deployed this patch on nmbug.notmuchmail.org. It seems to do the
right thing, at least for Jakub's original reported message.
d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 1/2] test: compute expected keyid from fingerprint
On Mon, Sep 12 2022, Daniel Kahn Gillmor wrote:
> On Sun 2022-09-11 23:50:18 +0200, Justus Winter wrote:
>> Tomi Ollila writes:
>>
>>> On Fri, Sep 09 2022, Justus Winter wrote:
>>>
---
test/T350-crypto.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh
index 3c6626b4..721cbfdd 100755
--- a/test/T350-crypto.sh
+++ b/test/T350-crypto.sh
@@ -467,7 +467,7 @@ expected='[[[{"id": "X",
"Date": "Sat, 01 Jan 2000 12:00:00 +"},
"body": [{"id": 1,
"sigstatus": [{"status": "error",
- "keyid": "6D92612D94E46381",
+ "keyid": "'$(echo $FINGERPRINT | cut -c 25-)'",
>>>
>>> The "bashism" (works also in zsh) ${FINGERPRINT:24} works here
>>> (and has been used in other lines in this file
>>
>> Interesting. FTR, I saw this method being used elsewhere and simply
>> copied it. If that'd prevent merging the change, I'd actually prefer
>> introducing a variable KEYID that is set explicitly in the test library.
>> The reason for that is that in v5 OpenPGP, the keyid will be computed
>> differently.
>
> I don't think this should prevent merging the change -- Tomi is just
> offering an efficiency improvement.
Right, especially if it is consistent w/ code somewhere else.
(and it sure looks like: grep cut' ' test/* shows consistent usage)
Tomi
>
> i'd also be happy with the introduction of an explicitly-set KEYID
> variable. These could be distinct changes.
>
>--dkg
> ___
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-le...@notmuchmail.org
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: "-1 tests skipped"
On Sun, Sep 11 2022, Daniel Kahn Gillmor wrote: > I'm running the test suite on notmuch master > (8eabd6388ecb7bea8246a9ba6943a0432d23406e), and i see the following > report: > > ``` > All 1758 tests behaved as expected (12 expected failures). > -1 tests skipped. > All tests in 2 files skipped. > ``` yes, that may happen... cannot recall when ;D Tomi > > -1 tests skipped is pretty strange! > > I haven't tracked it down to fix the counting yet, but i thought i'd > report it in case it's not known. i see some commentary about weird > aggregate results from the test suite from last year in the thread > anchored in id:20210517081109.31897-1-tomi.oll...@iki.fi but haven't > looked deep enough to see whether that's the same thing. > >--dkg > ___ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-le...@notmuchmail.org ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
