On Sat, 2023-04-08 at 08:42 -0300, David Bremner wrote:
> did you test this with a message-id with spaces in it?
> the quoting is a delicate.
You are correct that the quoting for this was wrong, as it was also
wrong in the code before my patch and I just copied that, however...
I noticed that
Spaces need to be stripped when querying the Message-Id,
because notmuch stores them in Xapian with spaces stripped.
All double-quote characters need to be doubled to escape them,
otherwise they will be added as extra query terms outside the id.
---
contrib/notmuch-mutt/notmuch-mutt | 11
This should be be slightly faster since it avoids forking a shell
and is less code in and less dependencies for the script.
Since String::ShellQuote isn't used elsewhere, drop mention of it.
---
contrib/notmuch-mutt/README | 2 --
contrib/notmuch-mutt/notmuch-mutt | 9 ++---
Carl Worth writes:
>
> What it could also do is create some placeholder file like
> .NOTMUCH-MUTT-OUTPUT-DIR when it writes its output. And then it could
> check for that file's existence before removing a directory.
>
Sounds reasonable to me. Would someone like to make a patch for
notmuch-mutt?
Paul Wise writes:
> +search($results_dir, $remove_dups, qq{thread:"{id:$mid}"});
did you test this with a message-id with spaces in it? the quoting is a
delicate.
d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email
