[PATCH v3 3/3] notmuch-mutt: check that the search cache Maildir is not a real Maildir

2023-05-27 Thread Paul Wise
This prevents data loss when users configure the search cache Maildir to be a real Maildir containing their real mail data, since the search cache Maildir is expected to contain only symlinks to the real mail data. Prevents: --- contrib/notmuch-mutt/notmuch-mutt | 46

[PATCH v2 3/3] notmuch-mutt: check that the search cache Maildir is not a real Maildir

2023-05-27 Thread Paul Wise
This prevents data loss when users configure the search cache Maildir to be a real Maildir containing their real mail data, since the search cache Maildir is expected to contain only symlinks to the real mail data. Prevents: --- contrib/notmuch-mutt/notmuch-mutt | 46

[PATCH v2 1/3] notmuch-mutt: clarify the empty Maildir function operates on search caches

2023-05-27 Thread Paul Wise
Rename the function and adjust the documentation comment. --- contrib/notmuch-mutt/notmuch-mutt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt index 01db6908..0f7379ac 100755 ---

[PATCH v2 2/3] notmuch-mutt: do not clear search cache Maildir when nothing is found

2023-05-27 Thread Paul Wise
The previous results might be useful to the user but an empty directory definitely isn't useful. --- contrib/notmuch-mutt/notmuch-mutt | 1 - 1 file changed, 1 deletion(-) diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt index 0f7379ac..875fd032 100755 ---

Re: [PATCH] notmuch-mutt: check that the search cache Maildir is not a real Maildir WAS: Re: Data loss

2023-05-27 Thread Paul Wise
On Sat, 2023-05-27 at 21:10 -0300, David Bremner wrote: > If possible, please use git-send-email for future series. Will do, I forgot about the --cover-letter option. > This seems to have introduced a warning, and I think there's a bug. > > % notmuch mutt search tag:inbox > Argument "new"

Re: [PATCH] notmuch-mutt: check that the search cache Maildir is not a real Maildir WAS: Re: Data loss

2023-05-27 Thread David Bremner
Paul Wise writes: > I think a better option is to detect if the search cache Maildir is > actually a Maildir and doesn't contain any data that could be lost. > > I have attached three patches I created to improve notmuch-mutt safety. If possible, please use git-send-email for future series. >

Re: [PATCH v2 2/2] notmuch-mutt: replace extra command with notmuch thread search feature

2023-05-27 Thread David Bremner
Paul Wise writes: > This should be be slightly faster since it avoids forking a shell > and is less code in and less dependencies for the script. > > Since String::ShellQuote isn't used elsewhere, drop mention of it. applied to master. d ___ notmuch

[PATCH] test: add known broken test for message-id with embedded spaces.

2023-05-27 Thread David Bremner
According to my reading of RFC5322, there is an obsolete syntax for Message-Id which permits folding whitespace (i.e. to be removed / ignored by parsers). In [1] Paul Wise observed that notmuch removed whitespace on indexing, but does not do any corresponding normalization of queries. Mark the

Re: T350-crypto T357-index-decryption: possible race condition?

2023-05-27 Thread David Bremner
David Bremner writes: > > I'm not sure if this is the main issue, but in commit bf8aa34324cc91a > that key was replaced by an ed255519 key > 9A3AFE6C60065A148FD4B58A7E6ABE924645CC60 > > Did the fedora sources get out of synch somehow? > > d > > PS. Currently spinning up a Fedora Rawhide VM to

Re: T350-crypto T357-index-decryption: possible race condition?

2023-05-27 Thread David Bremner
Michael J Gruber writes: > > Are all gpg related tests emacs based? Either gpg or emacs is the red > herring here, or both ... The issue (at least on rawhide) seems to be the interaction between gpg and emacs https://dev.gnupg.org/T6481 A fix seems to be in progress. Do you have problems

Re: T350-crypto T357-index-decryption: possible race condition?

2023-05-27 Thread David Bremner
Michael J Gruber writes: > David Bremner venit, vidit, dixit 2023-05-12 21:17:45: >> Michael J Gruber writes: >> >> > oh well, attachments ... >> > >> >> Can you encrypt to the key 6D92612D94E46381 interactively using an >> approriately simplified version of that command? > > Took me a while,