[RFC][PATCH] emacs: Provide scaffolding so that the new `shr' HTML renderer can run.

ion. Aaron [1] I see that (featurep 'gnus) returns t for me, so that horse is already out of the barn. But it isn?t something we should be seeking to perpetuate. -- Aaron Ecay

[PATCH] emacs: Add `notmuch-jump-to-recent-buffer'.

y unrolls it into a native Lisp loop. Thus the performance hit, if any, is negligible.) > > ... memq is also nice; in case used the list should be done beforehand with > (let* ... Given the fact about loop, let* isn?t really applicable. -- Aaron Ecay

Re: [RFC][PATCH] emacs: Provide scaffolding so that the new `shr' HTML renderer can run.

be loaded to function. Aaron [1] I see that (featurep 'gnus) returns t for me, so that horse is already out of the barn. But it isn’t something we should be seeking to perpetuate. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH] emacs: Add `notmuch-jump-to-recent-buffer'.

(Please excuse the lack of inline comments on the patch ? the original patch email is so old that I had deleted it from my archives!) progn...set-buffer should be with-current-buffer or...eq...eq... would be cleaner as (memq major-mode '(foo bar baz)) Otherwise, LGTM -- Aaron Ecay

[RFC][PATCH] emacs: Provide scaffolding so that the new `shr' HTML renderer can run.

ader problem. Aaron * I think that inhibit -> nil, block -> ".*" should achieve this, but I?m not sure/haven?t tested ** For example, Gmail makes you click a link at the top of an email before it will load any network images contained therein. -- Aaron Ecay

[PATCH] Give a path name to mktemp in Makefile.local

is called unconditionally, on all systems. So it doesn't matter if one does "make debian-snapshot" or not, the error is still generated. -- Aaron Ecay

[PATCH] [emacs] Don't quote lambda forms

This generates byte-compiler warnings on (at least) current trunk versions of Emacs. The quote is not necessary; lambda forms are self-quoting. --- emacs/notmuch-crypto.el |4 +- emacs/notmuch-hello.el | 64 +- emacs/notmuch-maildir-fcc.el

[PATCH] Ignore dynamic libraries on OS X.

Parallel to ignoring .so for linux. --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 9468e30..d64ec9f 100644 --- a/.gitignore +++ b/.gitignore @@ -9,6 +9,7 @@ notmuch.sym notmuch-shared notmuch.1.gz libnotmuch.so*

[PATCH] Give a path name to mktemp in Makefile.local

On some systems (incl. OS X 10.6), mktemp expects an argument giving it the place to put the new temporary file. --- On my machine without this patch, make prints a message from mktemp about expecting an argument each time it is run. At some point, make got into a situation where it would print

[PATCH] [emacs] Add an argument to notmuch-mua-mail

>From the emacs changelog: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail

[PATCH] [emacs] Add an argument to notmuch-mua-mail

>From the emacs changelog: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail

[PATCH] [emacs] Add an argument to notmuch-mua-mail

From the emacs changelog: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail window.

[PATCH] [emacs] Add an argument to notmuch-mua-mail

From the emacs changelog: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail window.

[PATCH] Give a path name to mktemp in Makefile.local

On some systems (incl. OS X 10.6), mktemp expects an argument giving it the place to put the new temporary file. --- On my machine without this patch, make prints a message from mktemp about expecting an argument each time it is run. At some point, make got into a situation where it would print

[PATCH] Ignore dynamic libraries on OS X.

Parallel to ignoring .so for linux. --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 9468e30..d64ec9f 100644 --- a/.gitignore +++ b/.gitignore @@ -9,6 +9,7 @@ notmuch.sym notmuch-shared notmuch.1.gz libnotmuch.so*

Re: [PATCH] Give a path name to mktemp in Makefile.local

of the makefile is called unconditionally, on all systems. So it doesn't matter if one does make debian-snapshot or not, the error is still generated. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo

[PATCH] [emacs] Add an argument to notmuch-mua-mail

>From the emacs changelog: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail

[PATCH] [emacs] Add an argument to notmuch-mua-mail

ure-proof against such changes. This is adapted from the approach taken by message-mail, a similar function built into emacs. This patch was originally submitted by richardmurri at gmail.com on Aug. 1: id:"877h6x6oor.fsf at veracitynetworks.com" Signed-off-by: Aaron Ecay --- emacs/n

[PATCH] [emacs] Add an argument to notmuch-mua-mail

, to future-proof against such changes. This is adapted from the approach taken by message-mail, a similar function built into emacs. This patch was originally submitted by richardmu...@gmail.com on Aug. 1: id:877h6x6oor@veracitynetworks.com Signed-off-by: Aaron Ecay aarone...@gmail.com --- emacs

[PATCH] [emacs] Add an argument to notmuch-mua-mail

From the emacs changelog: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail window.

[PATCH] Add missing call to g_type_init()

The Glib docs state "Prior to any use of the type system, g_type_init() has to be called".[1] To not do so can lead to segfaults. The g_type system is currently used by various "filters" that operate on uuencoded text, message headers, etc. [1]

[PATCH] Add missing call to g_type_init()

Signed-off-by: Aaron Ecay --- notmuch.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/notmuch.c b/notmuch.c index 3973e35..f9d6629 100644 --- a/notmuch.c +++ b/notmuch.c @@ -579,6 +579,7 @@ main (int argc, char *argv[]) local = talloc_new (NULL

[PATCH] Add missing call to g_type_init()

Signed-off-by: Aaron Ecay aarone...@gmail.com --- notmuch.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/notmuch.c b/notmuch.c index 3973e35..f9d6629 100644 --- a/notmuch.c +++ b/notmuch.c @@ -579,6 +579,7 @@ main (int argc, char *argv[]) local = talloc_new (NULL

[PATCH] Add missing call to g_type_init()

The Glib docs state Prior to any use of the type system, g_type_init() has to be called.[1] To not do so can lead to segfaults. The g_type system is currently used by various filters that operate on uuencoded text, message headers, etc. [1]

segfault: g_type_init() missing

Dear all, I just pulled the last couple weeks' worth of changes and rebuilt notmuch, only to have the new binary give a segfault on "notmuch new" (running on OS X.6). The error message printed was: (process:21821): GLib-GObject-CRITICAL **: gtype.c:2708: You forgot to call g_type_init() And

segfault: g_type_init() missing

Dear all, I just pulled the last couple weeks' worth of changes and rebuilt notmuch, only to have the new binary give a segfault on notmuch new (running on OS X.6). The error message printed was: (process:21821): GLib-GObject-CRITICAL **: gtype.c:2708: You forgot to call g_type_init() And the

Use of strcasestr

--- 2010ko Apirilak 12an, Tomas Carnecky-ek idatzi zuen: > > Adding that function to compat/ probably is the way to go, but the whole > compat mechanism doesn't work here. It's like if compat/Makefile.local was > not included in the top-level makefile, notmuch_compat_srcs is empty > there. Any

Re: Use of strcasestr

--- 2010ko Apirilak 12an, Tomas Carnecky-ek idatzi zuen: Adding that function to compat/ probably is the way to go, but the whole compat mechanism doesn't work here. It's like if compat/Makefile.local was not included in the top-level makefile, notmuch_compat_srcs is empty there. Any ideas

[PATCH 4/4] Add CONFIGURE_LDFLAGS to the notmuch-shared buld command line.

Otherwise, symbol not found errors result on OS X. I am not sure this is the correct solution for the problem, but it gets the build working. Signed-off-by: Aaron Ecay --- Makefile.local |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local

[PATCH 3/4] Add infrastructure for building shared library on OS X.

This patch adds a configure check for OS X (actually Darwin), and sets up the Makefiles to build a proper shared library on that platform. Signed-off-by: Aaron Ecay --- Makefile |2 +- Makefile.local |2 +- configure | 13 + lib/Makefile.local | 16

[PATCH 2/4] Fix up Makefile for build.

Must set extra_c(xx)flags before including subdir Makefile.local's, so that there is a blank slate that the subdirs can add on to. Must include subdir Makefile.local's before global one, otherwise the compat sources are not added to the list of those to be compiled. Signed-off-by: Aaron Ecay

[PATCH 1/4] Use C++ compiler to link notmuch binaries

Since the binaries contain C++ code, it is necessary to use the C++ linker, or errors result on some platforms (OS X). Signed-off-by: Aaron Ecay --- Makefile.local |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.local b/Makefile.local index 71525e2..9e753cd

Build problems on OS X

In the process of updating to the latest sources, I've discovered that notmuch no longer builds on OS X. As a reply to this email, I'll be sending 4 patches. The first two are bugfixes; the third adds the infrastructure to the Makefiles to build a shared library on OS X, since the Mach-O

[PATCH] Further improvements to tag-based coloring in search.

Makes the following improvements: - fix up doc strings - suppress the creation of unnecessary let-bindings - create overlays lazily (to avoid creating many overlays for threads that do not get colored) Signed-off-by: Aaron Ecay --- emacs/notmuch.el | 21 ++--- 1 files

Build problems on OS X

In the process of updating to the latest sources, I've discovered that notmuch no longer builds on OS X. As a reply to this email, I'll be sending 4 patches. The first two are bugfixes; the third adds the infrastructure to the Makefiles to build a shared library on OS X, since the Mach-O

[PATCH 1/4] Use C++ compiler to link notmuch binaries

Since the binaries contain C++ code, it is necessary to use the C++ linker, or errors result on some platforms (OS X). Signed-off-by: Aaron Ecay aarone...@gmail.com --- Makefile.local |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.local b/Makefile.local

[PATCH 2/4] Fix up Makefile for build.

Must set extra_c(xx)flags before including subdir Makefile.local's, so that there is a blank slate that the subdirs can add on to. Must include subdir Makefile.local's before global one, otherwise the compat sources are not added to the list of those to be compiled. Signed-off-by: Aaron Ecay

[PATCH 4/4] Add CONFIGURE_LDFLAGS to the notmuch-shared buld command line.

Otherwise, symbol not found errors result on OS X. I am not sure this is the correct solution for the problem, but it gets the build working. Signed-off-by: Aaron Ecay aarone...@gmail.com --- Makefile.local |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local

[notmuch] [PATCH] notmuch.el: colorize lines in notmuch-search based on thread tags.

--- 2010ko Otsailak 7an, "Aneesh Kumar K. V"-ek idatzi zuen: > Doesn't 92c4dcc641e9dfb5f65026ebae5cedc8eb1d9e21 help you achive something > similar ? That commit allows colors to be applied to the tag name only, whereas this patch applies the color to the whole line. Which method(s) notmuch

Re: [notmuch] [PATCH] notmuch.el: colorize lines in notmuch-search based on thread tags.

--- 2010ko Otsailak 7an, Aneesh Kumar K. V-ek idatzi zuen: Doesn't 92c4dcc641e9dfb5f65026ebae5cedc8eb1d9e21 help you achive something similar ? That commit allows colors to be applied to the tag name only, whereas this patch applies the color to the whole line. Which method(s) notmuch should

[notmuch] [PATCH] Further improvements to tag-based coloring in search.

Makes the following improvements: - fix up doc strings - suppress the creation of unnecessary let-bindings - create overlays lazily (to avoid creating many overlays for threads that do not get colored) Signed-off-by: Aaron Ecay --- notmuch.el | 29 ++--- 1 files

[notmuch] Notmuch's search view sucks

--- 2009ko Abenudak 4an, Olly Betts-ek idatzi zuen: [...] > TextCat is in Perl. I don't know if there's a C or C++ implementation but > it isn't a huge piece of code - finding a good technique was the clever part > of it. The same algorithm is implemented in C here:

Re: [notmuch] Notmuch's search view sucks

--- 2009ko Abenudak 4an, Olly Betts-ek idatzi zuen: [...] TextCat is in Perl. I don't know if there's a C or C++ implementation but it isn't a huge piece of code - finding a good technique was the clever part of it. The same algorithm is implemented in C here:

<    1   2