Quoth Jameson Graef Rollins on May 23 at 3:40 pm:
This new structure, notmuch_crypto_t, keeps all relevant crypto
contexts and parameters together, and will make it easier to pass the
stuff around and clean it up. The name of the crypto context inside
this new struct will change, to reflect
Quoth Jameson Graef Rollins on May 23 at 3:40 pm:
Ok, hopefully last version. This addresses Jani's latest comments.
The first patch uses a typedef to handle the incompatibility between
the crypto context between GMIME 2.4 and 2.6. We probably should have
done this originally, as it gets
Quoth Jameson Graef Rollins on May 25 at 8:47 am:
On Fri, May 25 2012, Austin Clements amdra...@mit.edu wrote:
diff --git a/notmuch-client.h b/notmuch-client.h
index 19b7f01..337409f 100644
--- a/notmuch-client.h
+++ b/notmuch-client.h
@@ -36,6 +36,8 @@
* these to check the version
Commit 5fddc07 changed this API, but missed this use of it.
---
contrib/notmuch-deliver/src/main.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/contrib/notmuch-deliver/src/main.c
b/contrib/notmuch-deliver/src/main.c
index 37d2919..032b9d6 100644
---
This problem came up again on IRC a few days ago, so I'm finally
posting this series (which I've been running locally for months).
The idea---which is explained in detail in the first patch---is that
messages in new/ are maildir messages with an empty set of maildir
flags. Currently we treat
---
lib/message.cc |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/message.cc b/lib/message.cc
index ed96477..bbac2ff 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -1074,7 +1074,7 @@ notmuch_message_maildir_flags_to_tags (notmuch_message_t
*message)
This way notmuch_message_maildir_flags_to_tags can call it. It makes
more sense for this to be just above all of the maildir
synchronization code rather than mixed in the middle.
---
lib/message.cc | 82
1 file changed, 41 insertions(+),
This fixes the broken test added a few patches ago by synchronizing
the tags of messages in new/, even if they have no info part. See
the test patch for rationale.
---
lib/message.cc| 20 +---
test/maildir-sync |1 -
2 files changed, 13 insertions(+), 8 deletions(-)
Quoth Jani Nikula on Jun 04 at 7:10 am:
On Sun, 03 Jun 2012, Austin Clements amdra...@mit.edu wrote:
Currently, notmuch new only synchronizs maildir flags to tags for
+e to synchronizs.
Vowels are so web 1.0.
Updated series on its way
Previously, notmuch new only synchronized maildir flags to tags for
files with a maildir info part. Since messages in new/ don't have
an info part, notmuch would ignore them for flag-to-tag
synchronization.
This patch makes notmuch consider messages in new/ to be legitimate
maildir messages that
Previously, we synchronized flags to tags for any message that looked
like it had maildir flags in its file name, regardless of whether it
was in a maildir-like directory structure. This was asymmetric with
tag-to-flag synchronization, which only applied to messages in
directories named new/ and
This way notmuch_message_maildir_flags_to_tags can call it. It makes
more sense for this to be just above all of the maildir
synchronization code rather than mixed in the middle.
---
lib/message.cc | 82
1 file changed, 41 insertions(+),
Currently, notmuch new only synchronizes maildir flags to tags for
files that have an info part. However, in maildir, new mail doesn't
gain the info part until it moves from new/ to cur/. Hence, even
though mail in new/ doesn't have an info part, it is still a maildir
message and thus has
v2 hopefully addresses Jani's comments about v1's commit messages. It
also adds a news patch.
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Quoth Jameson Graef Rollins on May 26 at 11:45 am:
I'm not going to claim this is the last version, but I think it
addresses the remaining comments. I implemented Austin's of
introducing a new type to handle the gmime 2.4/2.6 context
incompatibility.
LGTM. Sorry for dropping the ball on
Quoth David Belohrad on Jun 20 at 1:25 pm:
Dear All,
could someone give a hint?
I have an opened mail message. When I press 'r' to reply, a new mail
buffer is opened and the 'From' field is correctly filled with
'da...@belohrad.ch'.
When on the same message I press however 'f' to
The JSON format change LGTM. This seems like the right way to do this.
On Sat, 16 Jun 2012, Mark Walters markwalters1...@gmail.com wrote:
All formats except Json can output empty messages for non
entire-thread, but in Json format we output null to keep the other
elements (e.g. the replies to
On Sat, 16 Jun 2012, Mark Walters markwalters1...@gmail.com wrote:
Also remove the Json --entire-thread item from devel/TODO.
---
devel/TODO |2 --
devel/schemata |2 +-
2 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/devel/TODO b/devel/TODO
index
Quoth Sascha Silbe on Jun 26 at 12:13 am:
Austin Clements amdra...@mit.edu writes:
On Sun, 24 Jun 2012, Sascha Silbe sascha-...@silbe.org wrote:
[notmuch new listing every directory, even if it's unchanged]
I haven't looked over your patches yet, but this result surprises me.
Could you
LGTM.
On Sat, 30 Jun 2012, Mark Walters markwalters1...@gmail.com wrote:
In id:87sjdm12d1@awakening.csail.mit.edu Austin pointed out that
devel/schemata needs a slight correction with the new
--entire-thread=false option. This is that correction.
---
Resend with better commit message
Quoth Tomi Ollila on Jul 02 at 1:13 am:
On Sat, Jun 30 2012, Mark Walters markwalters1...@gmail.com wrote:
Add newlines between complete threads to make asynchronous parsing
of the JSON easier.
---
notmuch-pick uses the JSON output of notmuch show but, in many cases,
for many
Quoth myself on Jul 01 at 8:12 pm:
Quoth Tomi Ollila on Jul 02 at 1:13 am:
On Sat, Jun 30 2012, Mark Walters markwalters1...@gmail.com wrote:
Add newlines between complete threads to make asynchronous parsing
of the JSON easier.
---
notmuch-pick uses the JSON output of
This field is output by search, but it didn't make it into the
documentation.
---
devel/schemata |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/devel/schemata b/devel/schemata
index 8fcab8e..06320f4 100644
--- a/devel/schemata
+++ b/devel/schemata
@@ -128,7 +128,8 @@
This is a simpler place to do this, since we can avoid any point
motion and hence any save-excursions in
`notmuch-search-process-filter', which in turn lets us put all of the
search-target logic outside of any save-excursions.
`notmuch-search-process-filter' could use some reindentation after
This removes the last bit of direct output from the parsing function.
With the parser now responsible solely for parsing, we can swap it out
for another parser.
---
emacs/notmuch.el | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
Rather than passing lots of arguments and then further passing those
to `notmuch-search-insert-field', pass a plist containing all of the
search result information. This plist is compatible JSON format
search results.
---
emacs/notmuch.el | 65
This advises the search process filter to make it process one
character at a time in order to test the pessimal case for incremental
search output parsing.
The text parser fails this test because it gets tricked into thinking
a parenthetical remark in a subject is the tag list.
---
test/emacs
Previously, much of the display of search lines was done in the same
function that parsed the CLI's output. Now the parsing function only
parses, and notmuch-search-show-result fully inserts the search result
in the search buffer.
---
emacs/notmuch.el | 33 +
1
This parser is designed to read streaming JSON whose structure is
known to the caller. Like a typical JSON parsing interface, it
provides a function to read a complete JSON value from the input.
However, it extends this with an additional function that
requires the next value in the input to be a
Quoth Mark Walters on Jul 04 at 9:34 am:
On Tue, 03 Jul 2012, Austin Clements amdra...@mit.edu wrote:
This is a simpler place to do this, since we can avoid any point
motion and hence any save-excursions in
`notmuch-search-process-filter', which in turn lets us put all of the
search
Quoth Mark Walters on Jul 04 at 8:53 am:
On Tue, 03 Jul 2012, Austin Clements amdra...@mit.edu wrote:
This simplifies the code and makes it no longer cubic in the number of
result fields.
This looks good to me and all tests pass, and I agree that this patch
can be pushed independently
Quoth Mark Walters on Jul 05 at 9:47 am:
On Wed, 04 Jul 2012, Peter Wang noval...@gmail.com wrote:
On Tue, 03 Jul 2012 19:22:18 -0700, Jameson Graef Rollins
jroll...@finestructure.net wrote:
On Tue, Jul 03 2012, Peter Wang noval...@gmail.com wrote:
I want to see what the sender
Quoth Mark Walters on Jul 05 at 9:30 am:
On Tue, 03 Jul 2012, Austin Clements amdra...@mit.edu wrote:
This parser is designed to read streaming JSON whose structure is
known to the caller. Like a typical JSON parsing interface, it
provides a function to read a complete JSON value from
---
NEWS | 17 +
1 file changed, 17 insertions(+)
diff --git a/NEWS b/NEWS
index d29ec5b..a1a6e93 100644
--- a/NEWS
+++ b/NEWS
@@ -14,6 +14,23 @@ Maildir tag synchronization
messages (typically causing new messages to not receive the unread
tag).
+Emacs Interface
This should account for all of Mark's and Tomi's comments. This
version
* renames the format variables to format-string and spec to be
less confusing,
* reverts to the original behavior of ignoring the user's format
specification for tags (since we make assumptions about this format
Rather than passing lots of arguments and then further passing those
to `notmuch-search-insert-field', pass a plist containing all of the
search result information. This plist is compatible with the JSON
format search results.
---
emacs/notmuch.el | 65
This removes the last bit of direct output from the parsing function.
With the parser now responsible solely for parsing, we can swap it out
for another parser.
---
emacs/notmuch.el |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
The JSON format eliminates the complex escaping issues that have
plagued the text search format. This uses the incremental JSON parser
so that, like the text parser, it can output search results
incrementally.
This slows down the parser by about ~4X, but puts us in a good
position to optimize
This parser is designed to read streaming JSON whose structure is
known to the caller. Like a typical JSON parsing interface, it
provides a function to read a complete JSON value from the input.
However, it extends this with an additional function that
requires the next value in the input to be a
This simplifies the code and makes it no longer cubic in the number of
result fields.
---
emacs/notmuch.el | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index c6236db..8ad0b68 100644
--- a/emacs/notmuch.el
+++
This is a simpler place to do this, since we can avoid any point
motion and hence any save-excursions in
`notmuch-search-process-filter', which in turn lets us put all of the
search-target logic outside of any save-excursions.
`notmuch-search-show-{result,error}' are now responsible for their own
Quoth Mark Walters on Jul 05 at 10:44 pm:
On Thu, 05 Jul 2012, Austin Clements amdra...@mit.edu wrote:
This should account for all of Mark's and Tomi's comments. This
version
* renames the format variables to format-string and spec to be
less confusing,
* reverts to the original
Quoth Sebastien Binet on Jul 09 at 10:25 am:
hi there,
I was trying to reduce the I/O stress during my usual email
fetching+tagging by writing a little program using the go bindings to
notmuch.
ie:
db, status := notmuch.OpenDatabase(db_path,
This simplifies the code and makes it no longer cubic in the number of
result fields.
---
emacs/notmuch.el | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index c6236db..8ad0b68 100644
--- a/emacs/notmuch.el
+++
Previously, much of the display of search lines was done in the same
function that parsed the CLI's output. Now the parsing function only
parses, and notmuch-search-show-result fully inserts the search result
in the search buffer.
---
emacs/notmuch.el | 33 +
1
This fixes the docstings for notmuch-json-read and notmuch-json-eof as
suggested by Mark. No other changes.
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
This advises the search process filter to make it process one
character at a time in order to test the pessimal case for incremental
search output parsing.
The text parser fails this test because it gets tricked into thinking
a parenthetical remark in a subject is the tag list.
---
test/emacs
Rather than passing lots of arguments and then further passing those
to `notmuch-search-insert-field', pass a plist containing all of the
search result information. This plist is compatible with the JSON
format search results.
---
emacs/notmuch.el | 65
This removes the last bit of direct output from the parsing function.
With the parser now responsible solely for parsing, we can swap it out
for another parser.
---
emacs/notmuch.el |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
This parser is designed to read streaming JSON whose structure is
known to the caller. Like a typical JSON parsing interface, it
provides a function to read a complete JSON value from the input.
However, it extends this with an additional function that
requires the next value in the input to be a
This is a simpler place to do this, since we can avoid any point
motion and hence any save-excursions in
`notmuch-search-process-filter', which in turn lets us put all of the
search-target logic outside of any save-excursions.
`notmuch-search-show-{result,error}' are now responsible for their own
Quoth Jameson Graef Rollins on Jul 10 at 10:04 am:
On Tue, Jul 10 2012, Mark Walters markwalters1...@gmail.com wrote:
I think I would also add something saying that the text format is just
different (and that a significant chunk of the patch is just that).
Can we not just dump this output
Since it would be great to use the structure printer for show as well,
it would make sense to put it in its own source file, where it can
easily be shared between commands.
There are a few systematic code formatting problems in your patch. To
be consistent with other notmuch code, there should
Quoth cra...@gmx.net on Jul 12 at 9:43 am:
This patch adds a new type sprinter_t, which is used for structured
formatting, e.g. JSON or S-Expressions. The structure printer is the
code from Austin Clements (id:87d34hsdx8@awakening.csail.mit.edu).
The structure printer contains
Quoth Tomi Ollila on Jul 12 at 1:10 pm:
On Thu, Jul 12 2012, cra...@gmx.net wrote:
Using the new structured printer support in sprinter.h, implement
sprinter_json_new, which returns a new JSON structured output
formatter.
The formatter prints output similar to the existing JSON, but
Quoth cra...@gmx.net on Jul 12 at 9:43 am:
Using the new structured printer support in sprinter.h, implement
sprinter_json_new, which returns a new JSON structured output
formatter.
The formatter prints output similar to the existing JSON, but with
differences in whitespace (mostly
Quoth cra...@gmx.net on Jul 12 at 9:43 am:
This patch adds a new type sprinter_t, which is used for structured
formatting, e.g. JSON or S-Expressions. The structure printer is the
code from Austin Clements (id:87d34hsdx8@awakening.csail.mit.edu).
The structure printer contains
This is fantastic. It simplifies the code a lot, and I think it opens
up opportunities to simplify it even further.
Detailed comments are below, but first one general comment. For the
text format, I wonder if most of the special case code would go away
with a stub sprinter that did nothing for
Quoth myself on Jul 12 at 8:02 pm:
This is fantastic. It simplifies the code a lot, and I think it opens
up opportunities to simplify it even further.
Detailed comments are below, but first one general comment. For the
text format, I wonder if most of the special case code would go away
Previously, tag-based search result highlighting was done by creating
an overlay over each search result. However, overlays have annoying
front- and rear-advancement semantics that make it difficult to
manipulate text at their boundaries, which the next patch will do.
They also have performance
This simplifies the traversal of regions of results and eliminates the
need for save-excursions (which tend to get in the way of maintaining
point when we make changes to the buffer). It also fixes some strange
corner cases in the old line-based code where results that bordered
the region but
This also provides utility functions for working with this text
property that get its value, find its start, and find its end.
---
emacs/notmuch.el | 27 +++
1 file changed, 27 insertions(+)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index fabb7c0..ef18927 100644
Now that we keep the full thread result object, we can refresh a
result after any changes by simply deleting and reconstructing the
result line from scratch.
A convenient side-effect of this wholesale replacement is that search
now re-applies notmuch-search-line-faces when tags change.
---
This series builds on the JSON-based search series [0] to clean up
several other aspects of search-mode. It removes constraints on the
formatting of tags in the result line (you can even leave them out
entirely), it recolors lines when tags change, it adds supports for
multi-line result formats,
At this point, the only remaining functions that don't support
multi-line search result formats are the thread navigation functions.
This patch fixes that by rewriting them in terms of
notmuch-search-result-{beginning,end}.
---
emacs/notmuch.el | 12 +---
1 file changed, 9
Since the result object contains everything that the other text
properties recorded, we can remove the other text properties and
simply look in the plist of the appropriate result object.
---
emacs/notmuch.el | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
diff
Quoth Jani Nikula on Jul 10 at 8:10 am:
On Jul 10, 2012 4:49 AM, Austin Clements [1]amdra...@mit.edu wrote:
Quoth Jani Nikula on Jun 15 at 6:53 pm:
Add no-display arg to notmuch-hello-refresh-hook to allow each hook to
decide what is appropriate when no-display is t
Quoth Mark Walters on Jul 13 at 6:21 pm:
On Fri, 13 Jul 2012, Austin Clements amdra...@mit.edu wrote:
At this point, the only remaining functions that don't support
multi-line search result formats are the thread navigation functions.
This patch fixes that by rewriting them in terms
Quoth Mark Walters on Jul 13 at 6:59 pm:
On Fri, 13 Jul 2012, Austin Clements amdra...@mit.edu wrote:
Previously, tag-based search result highlighting was done by creating
an overlay over each search result. However, overlays have annoying
front- and rear-advancement semantics that make
Quoth Peter Feigl on Jul 13 at 10:11 am:
From: cra...@gmx.net
This patch adds a new type sprinter_t, which is used for structured
formatting, e.g. JSON or S-Expressions. The structure printer is the
code from Austin Clements (id:87d34hsdx8@awakening.csail.mit.edu)
with minor
Quoth Peter Feigl on Jul 13 at 10:11 am:
From: cra...@gmx.net
Using the new structured printer support in sprinter.h, implement
sprinter_json_create, which returns a new JSON structured output
formatter. The formatter prints output similar to the existing JSON, but
with differences in
Just one comment below. Otherwise this patch LGTM (though some of my
comments on the previous patch will affect this one). It's nice to
see all of that old newline logic disappear.
Quoth Peter Feigl on Jul 13 at 10:11 am:
From: cra...@gmx.net
This patch switches from the current ad-hoc
Previously we ignored any notmuch-search-result-format customizations
for tag formatting because we needed to be able to parse back in the
result line and update the tags in place. We no longer do either of
these things, so we can allow customization of this format.
(Coincidentally, previously
Previously, tag-based search result highlighting was done by creating
an overlay over each search result. However, overlays have annoying
front- and rear-advancement semantics that make it difficult to
manipulate text at their boundaries, which the next patch will do.
They also have performance
Now that we keep the full thread result object, we can refresh a
result after any changes by simply deleting and reconstructing the
result line from scratch.
A convenient side-effect of this wholesale replacement is that search
now re-applies notmuch-search-line-faces when tags change.
---
This version updates the docstrings for notmuch-search-update-result
and notmuch-search-show-result and fixes the scrolling artifact in
notmuch-search-update-result. I also updated the commit message of
patch 7 to mention that it changes the behavior of
notmuch-search-previous-thread.
The diff
This simplifies the traversal of regions of results and eliminates the
need for save-excursions (which tend to get in the way of maintaining
point when we make changes to the buffer). It also fixes some strange
corner cases in the old line-based code where results that bordered
the region but
This also provides utility functions for working with this text
property that get its value, find its start, and find its end.
---
emacs/notmuch.el | 27 +++
1 file changed, 27 insertions(+)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index fabb7c0..ef18927 100644
Previously, notmuch-show-previous-message would move to the beginning
of the message before the message containing point. This patch makes
it instead move to the previous message *boundary*. That is, if point
isn't already at the beginning of the message, it moves to the
beginning of the current
Quoth Jameson Graef Rollins on Jul 14 at 12:31 pm:
On Fri, Jul 13 2012, Austin Clements amdra...@mit.edu wrote:
Coincidentally, this also essentially enables multi-line search result
formats; the only remaining non-multi-line-capable functions are
notmuch-search-{next,previous}-thread
Quoth myself on Jul 14 at 3:50 pm:
Quoth Jameson Graef Rollins on Jul 14 at 12:31 pm:
On Fri, Jul 13 2012, Austin Clements amdra...@mit.edu wrote:
+(defmacro notmuch-search-do-results (beg end pos-sym rest body)
+ Invoke BODY for each result between BEG and END.
+
+POS-SYM
Quoth Jameson Graef Rollins on Jul 14 at 2:13 pm:
On Sat, Jul 14 2012, Austin Clements amdra...@mit.edu wrote:
That's strange. What was the error?
I've been testing with
((date . %12s )
(count . %-7s )
(authors . %-20s )
(subject . \n%s )
(tags . (%s
This also provides utility functions for working with this text
property that get its value, find its start, and find its end.
---
emacs/notmuch.el | 27 +++
1 file changed, 27 insertions(+)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index fabb7c0..ef18927 100644
This version swaps out the notmuch-search-do-results macro for a
higher-order function, notmuch-search-foreach-result. This requires
less squiting to understand and clearly distinguishes the arguments
passed in to the function from the arguments passed to the callback.
This version also updates
At this point, the only remaining functions that don't support
multi-line search result formats are the thread navigation functions.
This patch fixes that by rewriting them in terms of
notmuch-search-result-{beginning,end}.
This changes the behavior of notmuch-search-previous-thread slightly
so
Since the result object contains everything that the other text
properties recorded, we can remove the other text properties and
simply look in the plist of the appropriate result object.
---
emacs/notmuch.el | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
diff
This simplifies the traversal of regions of results and eliminates the
need for save-excursions (which tend to get in the way of maintaining
point when we make changes to the buffer). It also fixes some strange
corner cases in the old line-based code where results that bordered
the region but
Now that we keep the full thread result object, we can refresh a
result after any changes by simply deleting and reconstructing the
result line from scratch.
A convenient side-effect of this wholesale replacement is that search
now re-applies notmuch-search-line-faces when tags change.
---
On Sun, 15 Jul 2012, Mark Walters markwalters1...@gmail.com wrote:
On Sun, 15 Jul 2012, Austin Clements amdra...@mit.edu wrote:
This version swaps out the notmuch-search-do-results macro for a
higher-order function, notmuch-search-foreach-result. This requires
less squiting to understand
Quoth cra...@gmx.net on Jul 16 at 10:35 am:
Using the new structured printer support in sprinter.h, implement
sprinter_json_create, which returns a new JSON structured output
formatter. The formatter prints output similar to the existing JSON, but
with differences in whitespace (mostly
Just a few comments (don't forget to scroll all the way down).
Overall this is looking pretty good.
Quoth cra...@gmx.net on Jul 16 at 10:35 am:
This patch switches from the current ad-hoc printer to the structured
formatters in sprinter.h, sprinter-text-search.c and sprinter-json.c.
The JSON
Hah. I guess nobody has tried to modify a notmuch database using the
Go bindings.
Could this instead assign the constants to
C.NOTMUCH_DATABASE_MODE_READ_ONLY, etc, rather than duplicating their
values? It would be nice to do that for the Status values as well
(which are correctly using iota,
This is subtle enough that I think it deserves a comment in the source
code explaining that tracking the talloc owner reference, combined
with the fact that Go finalizers are run in dependency order, ensures
that the C objects will always be destroyed from the talloc leaves up.
Just one inline
Quoth Adrien Bustany on Jul 18 at 9:34 pm:
This binding does not handle the progress callback, but at least allows
opening and upgrading a database if needed.
---
bindings/go/src/notmuch/notmuch.go | 13 -
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git
Quoth Adrien Bustany on Jul 18 at 9:34 pm:
---
bindings/go/src/notmuch/notmuch.go | 253
+++-
1 files changed, 252 insertions(+), 1 deletions(-)
diff --git a/bindings/go/src/notmuch/notmuch.go
b/bindings/go/src/notmuch/notmuch.go
index be4cb8c..f667dbb
This series looks good to me other than the few things I commented on.
It's nice to see the Go bindings get a bit of love!
Quoth Adrien Bustany on Jul 18 at 9:34 pm:
The following patches fix some serious memory management issues with
the Go bindings, and add some missing functions as well.
Quoth Adrien Bustany on Jul 19 at 9:25 pm:
Le 18/07/2012 23:40, Austin Clements a écrit :
This is subtle enough that I think it deserves a comment in the source
code explaining that tracking the talloc owner reference, combined
with the fact that Go finalizers are run in dependency order
On Fri, 15 Jun 2012, David Belohrad da...@belohrad.ch wrote:
Dear all,
recently I got an email from matplotlib list, which fails to parse in
notmuch-saved-search-unread.
It looks like this:
Yest. 21:04 [3/5] Jesse Rosenthal, Tomi Ollila [PATCHv2] emacs: derive
correct timestamp in FCC
At this point, the only remaining functions that don't support
multi-line search result formats are the thread navigation functions.
This patch fixes that by rewriting them in terms of
notmuch-search-result-{beginning,end}.
This changes the behavior of notmuch-search-previous-thread slightly
so
This simplifies the traversal of regions of results and eliminates the
need for save-excursions (which tend to get in the way of maintaining
point when we make changes to the buffer). It also fixes some strange
corner cases in the old line-based code where results that bordered
the region but
701 - 800 of 3381 matches
Mail list logo
