Re: [PATCH] configure: resolve real path to bash
David Bremner writes: > Đoàn Trần Công Danh writes: > >> The old code somehow resolves to `bin/sh' on Arch Linux/Void Linux >> auto build systems. >> > > I'm not sure if this is better or worse than > > > https://nmbug.notmuchmail.org/nmweb/show/20190117021132.28327-1-david%40tethera.net Sorry for the noise, I somehow couldn't find your patch at that time. And I only recognized readlink(1) is not POSIX after sending the patch. I wonder if it's better to keep `/usr/bin/env bash` instead of resolving bash to specific file. Something like this: diff --git a/emacs/Makefile.local b/emacs/Makefile.local index 04913a06..2252e818 100644 --- a/emacs/Makefile.local +++ b/emacs/Makefile.local @@ -117,7 +117,6 @@ endif install -m0644 $(emacs_images) "$(DESTDIR)$(emacsetcdir)" mkdir -p "$(DESTDIR)$(prefix)/bin/" ifeq ($(HAVE_BASH),1) - sed "1s|^#!.*|#! $(BASH_ABSOLUTE)|" < $(emacs_mua) > $(DESTDIR)$(prefix)/bin/notmuch-emacs-mua chmod 755 $(DESTDIR)$(prefix)/bin/notmuch-emacs-mua endif ifeq ($(WITH_DESKTOP),1) > > I welcome input on this. > > One issue is that readlink(1) is not in POSIX, so we can expect some > portability pains. > > d -- Danh ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] configure: resolve real path to bash
David Bremner writes: > Have you verified that you need to set an evironment variable? If there > is only one bash in $PATH, command -v should work fine. The previous bug > was using the variable BASH, which bash itself sets to /bin/sh (which I > find odd, but nobody asked me). I hadn't tested at that time since I had taken a quick skim over your second patch. I've just tested your patch, I confirm your patch is good with Void XBPS autobuild system. -- Danh ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] configure: resolve real path to bash
David Bremner writes: > Danh Doan writes: > >> >> I wonder if it's better to keep `/usr/bin/env bash` instead of resolving >> bash to specific file. Something like this: >> > > This will require Debian (and I think Fedora) to do the resolution > themselves, because they don't support "#! /usr/bin/env interpreter" > Of course the distro specific patches are slightly less complicated, > since they can hard code the location of bash. I have nothing against your approach, but I still slightly prefer to be able to run `configure` script without setting environment variable. Is it acceptable to emulate `realpath` in `configure` script? If yes, we could borrow this script (MIT licensed). https://github.com/chriskempson/base16-shell/blob/master/realpath/realpath.sh -- Danh ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: getting all attachments, getting images
On Thu, May 23, 2019 at 07:06:39AM -0700, meOme wrote: > Hi! > How can I get a list of all mails with an attachment in notmuch? Notmuch has already tagged all mails with attachment with tag: attachment, hasn't it? Does this command work for you? notmuch search tag:attachment -- Danh ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] doc: Makefile: stop build notmuch-emacs.info when not have emacs
No, I haven't seen it, until now. I used to follow the list but I stopped using notmuch. It seems like David has come up with a fix. I'll check the list first, next time. On June 11, 2019 3:21:42 PM UTC, Ralph Seichter wrote: >* Doan Tran Cong Danh: > >> I don't know if this is a _good_ fix for this issue. > >Did you see id:20190611005024.22814-2-da...@tethera.net ? > >-Ralph >___ >notmuch mailing list >notmuch@notmuchmail.org >https://notmuchmail.org/mailman/listinfo/notmuch -- Danh ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch