On Wed, 16 Nov 2011 22:04:05 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
On Wed, 16 Nov 2011 18:53:13 +0100, Daniel Schoepe dan...@schoepe.org wrote:
There is an unrelated white space change here...
Sigh. I should have caught that. OK, cleaned up now.
On Wed, 16 Nov 2011 18:53:11 +0100, Daniel Schoepe dan...@schoepe.org wrote:
Here are the two missing news entries for the two patches of
mine that were applied recently.
pushed
___
notmuch mailing list
notmuch@notmuchmail.org
From: David Bremner brem...@debian.org
This makes the test easier to extend to more targets. It also corrects
a bug where special targets were only detected when given alone.
---
Makefile.local |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/Makefile.local b
From: David Bremner brem...@debian.org
The version from file version is propagated to the man page and the
python bindings via sed. Note that the git version is ignored because
of the check for MAKECMDGOALS.
---
Makefile.local | 14 +-
1 files changed, 13 insertions(+), 1 deletions
From: David Bremner brem...@debian.org
The instructions are purposely a bit coy about what files are updated,
so we don't have to update immediately when something else is plugged
into the make recipe.
---
RELEASING |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git
On Wed, 16 Nov 2011 12:38:19 +0100, Pieter Praet pie...@praet.org wrote:
Merge expected output into the actual test, so we can verify the stashed
filename using ${gen_msg_filename} instead of doing sed tricks.
pushed to master
d
___
notmuch mailing
On Tue, 08 Nov 2011 18:02:25 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
Some tests don't break when HUP signal is sent tho those (by
pressing ctrl-c on the terminal). Therefore, the top-level
test script catches the HUP and sends TERM signal to the
started test script.
Pushed to master
d
On Sat, 19 Nov 2011 08:18:41 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
Before the change, notmuch used g_mime_content_type_to_string(3)
function to output Content-Type header value. Turns out it outputs
only type/subtype part and ignores all parameters. Also, if there
is no
On Sun, 13 Nov 2011 11:34:42 -0500, Tom Prince tom.pri...@ualberta.net wrote:
For some reason, on my machine, the link is picking up
/usr/lib/libutil.so instead of util/libutil.a. This causes there to be
undefined symbols in libnotmuch, making it unuseable. This patch causes
the link to fail
On Sun, 13 Nov 2011 13:16:48 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
This patch breaks out much of the functionality of
notmuch-show-advance-and-archive into a new function:
notmuch-show-advance. This new function does all the advancing
through a show buffer that
On Tue, 01 Nov 2011 21:00:28 +0100, Pieter Praet pie...@praet.org wrote:
Thanks for testing, Daniel and Jameson!
It still applies cleanly, so if there's anything preventing it from
being merged in, I'd like to hear about it.
Oops. Some time in the last few weeks, it stopped applying
On Tue, 15 Nov 2011 23:11:49 -0400, David Bremner da...@tethera.net wrote:
We are now frozen for 0.10 release. As is my habit, I tagged 0.10_rc1,
but didn't upload tarballs. I also upload 0.10~rc1 packages to Debian
experimental.
I have now tagged 0.10_rc2, which mainly has doc changes since
On Thu, 15 Sep 2011 00:23:19 +0200, Louis Rilling l.rill...@av7.net wrote:
The for loop right after already does the job.
I pushed the first two patches in this series; the second two need to be
updated for the new broken test framework, and reviewed.
d
/releases/notmuch-0.10.tar.gz.sha1.asc
(signed by David Bremner)
What's new in notmuch 0.10
=
New build and testing features
--
Emacs tests are now done in dtach. This means that dtach is now
needed to run the notmuch test suite, at least until
On Sun, 23 Oct 2011 21:38:43 +0200, Gregor Zattler telegr...@gmx.net wrote:
From e9cbb995c2d51cb3de3baa485e9a6861f6c36b0a Mon Sep 17 00:00:00 2001
From: Gregor Zattler telegr...@gmx.net
Date: Sun, 23 Oct 2011 21:10:18 +0200
Subject: [PATCH] emacs: test notmuch-indent-messages-width default
Hi
On Mon, 10 Oct 2011 15:39:41 +0200, Daniel Schoepe dan...@schoepe.org wrote:
From: Daniel Schoepe daniel.scho...@googlemail.com
This patch makes the notmuch-hello screen fully customizable
by allowing the user to add and remove arbitrary sections. It
also provides some convenience functions
On Mon, 21 Nov 2011 17:18:00 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
Since version 0.8 of dtach -n does no longer require controlling
tty to be present when executed. Currently controlling tty is not
always (if ever) present when tests are executed.
Pushed.
d
On Sun, 20 Nov 2011 20:07:02 -0500, Austin Clements amdra...@mit.edu wrote:
This is just cleanup. These markers are all immediately resolved to
points by Emacs, so using markers here is just unncessary overhead.
Pushed.
d
___
notmuch mailing list
On Sun, 20 Nov 2011 20:00:55 -0500, Austin Clements amdra...@mit.edu wrote:
There's no reason to record undo information for read-only,
programmatically-constructed buffers. The undo list just chews up
memory keeping track of our calls to insert.
Pushed.
d
On Sun, 6 Nov 2011 23:15:54 +0100, Antoine Amarilli antoine.amari...@ens.fr
wrote:
Hello,
The attached message makes python-notmuch crash when trying to access it (see
attached log).
I don't know if the encoding of Subject is valid or not, but it would probably
be better anyway to ignore
From: David Bremner brem...@debian.org
When I changed the calling convention to pass in all but the zero-th
argument to subcommands, I missed this one call, resulting in a
segmentation fault.
---
notmuch.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/notmuch.c b
On Fri, 25 Nov 2011 09:04:06 +, Patrick Totzke
patricktot...@googlemail.com wrote:
Silly question: how do i get Antoine's msg stup into notmuch? i tried
using pythons mailbox lib to add this string to one of my mailboxes,
which works fine. but upon `notmuch new` I get something along the
On Fri, 25 Nov 2011 11:54:51 +0100, Amadeusz Żołnowski aide...@aidecoe.name
wrote:
+$(dir)/symbol-test: $(dir)/symbol-test.o
+ $(call quiet,CC) $^ -o $@ -Llib -lnotmuch -lxapian
I'm a bit surprised no -I is neaded here. Is that taken care in the CC call?
.PHONY: test check
-test:
On Fri, 25 Nov 2011 11:54:52 +0100, Amadeusz Żołnowski aide...@aidecoe.name
wrote:
---
+ //notmuch_database_t *notmuch =
+ notmuch_database_open (fakedb, NOTMUCH_DATABASE_MODE_READ_ONLY);
Leaving commented out code in is for people without version control ;).
Shouldn't this cast to void?
From: David Bremner brem...@debian.org
Nothing fancy, but we can at least detect segmentation faults.
---
I think Jani was just making fun of me when he suggested tests for notmuch
--help, but I thought, why not.
test/help-test| 12
test/notmuch-test |1 +
2 files
On Thu, 24 Nov 2011 21:45:20 +, Darren McGuicken
mailing-notm...@fernseed.info wrote:
Hi guys, I assume this is old news, although I haven't seen anything
else mentioned on list since the chain Dirk started - there's a koji
build of 0.9 for rawhide, the source rpm of which contains a gmime
/releases/notmuch-0.10.1.tar.gz.sha1.asc
(signed by David Bremner)
What's new in notmuch 0.10.1
=
Bug-fix release.
Fix --help argument
Argument processing changes in 0.10 introduced a bug where notmuch
--help crashed while notmuch help worked fine
On Fri, 25 Nov 2011 11:54:51 +0100, Amadeusz Żołnowski aide...@aidecoe.name
wrote:
If symbol-test is built in symbol-hiding with hardcoded g++ invokation,
it's not so easy to pass $(srcdir) which is required to find notmuch.h
when srcdir and builddir are separate directories.
---
Sorry to do
On Thu, 17 Nov 2011 17:05:56 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
---
test/test-lib.sh |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
I pushed the first 3, but the 4th won't apply, even with git am -3
d
___
On Sat, 26 Nov 2011 22:14:20 +0100, Amadeusz Żołnowski aide...@aidecoe.name
wrote:
If symbol-test is built in symbol-hiding with hardcoded g++ invokation,
it's not so easy to pass $(srcdir) which is required to find notmuch.h
when srcdir and builddir are separate directories.
pushed,
d
On Sun, 27 Nov 2011 22:36:12 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
Changes:
v3 since v2:
* rebased the remaining patches on current master
These are all pushed to master now.
d
___
notmuch mailing list
As long promised, here is a test to compare the list of symbols
retrieved with objdump to those from notmuch.sym
I didn't verify whether this runs properly during out of tree builds.
___
notmuch mailing list
notmuch@notmuchmail.org
We assume that any symbol starting with notmuch_ in lib/*.o should be
exported, and that only those symbols should be exported.
---
test/symbol-hiding |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/test/symbol-hiding b/test/symbol-hiding
index 6d4e4ff..68f0d1b
On Sun, 27 Nov 2011 13:40:53 -0500, Tom Prince tom.pri...@ualberta.net wrote:
From: Thomas Schwinge tho...@schwinge.name
Asking xapian to sort the messages for us causes suboptimal IO patterns. This
would be useful, if we only wanted the first few results, but since we want
everything
This is in preparation for adding a third test to this file
---
test/symbol-hiding |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/test/symbol-hiding b/test/symbol-hiding
index f67b653..6d4e4ff 100755
--- a/test/symbol-hiding
+++ b/test/symbol-hiding
@@ -19,7 +19,9 @@
Note that the option does not do anything yet.
---
notmuch-dump.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/notmuch-dump.c b/notmuch-dump.c
index 8a8d6ec..2a6daef 100644
--- a/notmuch-dump.c
+++ b/notmuch-dump.c
@@ -43,10 +43,13 @@ notmuch_dump_command (unused
This is actually a bit of a tricky case because of the treating of the
first non-option as a filename. On the other hand, we don't do any
normal argument parsing yet.
---
notmuch-dump.c | 46 +++---
1 files changed, 31 insertions(+), 15 deletions(-)
diff
As we noticed when Jani kindly converted things to getopt_long, much
of the work in argument parsing in notmuch is due to the the key-value
style arguments like --format=(raw|json|text). In this intitial
attempt at factoring out some of the argument processing, we include
support for this kind of
On Tue, 29 Nov 2011 10:58:31 -0700, Chris Gray chrismg...@gmail.com wrote:
The process-lines function calls the notmuch binary. The location of
the binary may have been customized by the user, so it is better to
use the customized location rather than allowing the process-lines
function to
On Tue, 29 Nov 2011 02:41:03 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
This is a series of trivial but important fixes for the recently added
binary dependencies.
Pushed,
d
___
notmuch mailing list
notmuch@notmuchmail.org
From: David Bremner brem...@debian.org
Note that the new option does not control anything at the moment.
---
notmuch-dump.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/notmuch-dump.c b/notmuch-dump.c
index 9e0c91d..d0ab360 100644
--- a/notmuch-dump.c
+++ b/notmuch
From: David Bremner brem...@debian.org
The output file is handled via positional arguments. There are
currently no normal options.
---
notmuch-dump.c | 27 +++
1 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/notmuch-dump.c b/notmuch-dump.c
index 0475eb9
From: David Bremner brem...@debian.org
As we noticed when Jani kindly converted things to getopt_long, much
of the work in argument parsing in notmuch is due to the the key-value
style arguments like --format=(raw|json|text).
In this version I implement Austin Clements' suggestion of basing
On Thu, 24 Nov 2011 22:41:01 +0200, Tomi Ollila tomi.oll...@nixu.com wrote:
The notmuchmail/releases page used to have LATEST-notmuch-version
to link to the latest notmuch source tarball. This is confusing on
web page and on disk when the file has been downloaded. This change
looks a bit
I decided to start a new thread since the other one
id:1322808114-11854-1-git-send-email-da...@tethera.net was getting
pretty long, and there was no actual relevant discussion there.
I think these patches are getting close to ready.
One thing to discuss is the inclusion of single element
From: David Bremner brem...@debian.org
The output file is handled via positional arguments. There are
currently no normal options.
---
notmuch-dump.c | 32
1 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/notmuch-dump.c b/notmuch-dump.c
index
From: David Bremner brem...@debian.org
The switch on format_sel is slightly clunky, but it doesn't seem worth
special casing argument processing for function pointers, when I think
the function pointer approach will be modified/abandoned.
---
notmuch-search.c | 110
From: David Bremner brem...@debian.org
As we noticed when Jani kindly converted things to getopt_long, much
of the work in argument parsing in notmuch is due to the the key-value
style arguments like --format=(raw|json|text).
In this version I implement Austin Clements' suggestion of basing
From: David Bremner brem...@debian.org
The new argument handling is a bit more concise, and bit more
flexible. It allows the input file name to go before the --accumulate
option.
---
notmuch-restore.c | 38 --
1 files changed, 16 insertions(+), 22 deletions
From: David Bremner brem...@debian.org
The goal here is to have a simple way of making sure all of the
binaries needed to run tests are available.
---
test/Makefile.local |5 -
test/README |3 ++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/test
On Sun, 4 Dec 2011 15:35:39 -0200, Kazuo Teramoto kaz@gmail.com wrote:
Hi!
Following an alot bug report [1] I created a small python script that
causes a segmentation fault in notmuch:
#!/usr/bin/env python2
From: David Bremner brem...@debian.org
We want to make sure g_type_init is called before any GObject
functionality is used.
---
This seems to fix the segfault for me. Any other comments/experiences?
lib/database.cc |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/lib
From: David Bremner brem...@debian.org
We start modestly, with a (slightly modified) test case from Kazuo
Teramoto. Originally it just made sure the bindings didn't crash; here
we check that by comparing the output with that of notmuch search.
---
test/notmuch-test |1 +
test/python
From: David Bremner brem...@debian.org
We start modestly, with a (slightly modified) test case from Kazuo
Teramoto. Originally it just made sure the bindings didn't crash; here
we check that by comparing the output with that of notmuch search.
---
This version of the test is less ambitious
On Sun, 4 Dec 2011 15:35:14 -0400, David Bremner da...@tethera.net wrote:
From: David Bremner brem...@debian.org
We want to make sure g_type_init is called before any GObject
functionality is used.
---
This seems to fix the segfault for me. Any other comments/experiences?
I heard two
On Sun, 4 Dec 2011 11:58:49 -0400, David Bremner da...@tethera.net wrote:
From: David Bremner brem...@debian.org
The goal here is to have a simple way of making sure all of the
binaries needed to run tests are available.
Pushed to master
d
On Mon, 05 Dec 2011 13:39:32 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
The tar file of particular package (notmuch in this case) is named
as $(PACKAGE)-$(VERSION).tar.gz. Therefore the best way to remove
previous link to LATEST is to remove all files beginning with
LATEST-$(PACKAGE)- and
/releases/notmuch-0.10.2.tar.gz.sha1.asc
(signed by David Bremner)
What's new in notmuch 0.10.2
=
Bug-fix release.
Fix crash in python bindings.
The python bindings did not call g_type_init, which caused crashes
for some, but not all users
On Tue, 06 Dec 2011 22:41:23 +0200, Jani Nikula j...@nikula.org wrote:
We chatted about reserving notmuch-*.c to notmuch commands, but I guess
it was only after you sent these. I think it would make sense though.
renamed to command-line-arguments.[ch]. Hard luck for those of you on
8.3 file
From: David Bremner brem...@debian.org
The switch on format_sel is slightly clunky, but it doesn't seem worth
special casing argument processing for function pointers, when I think
the function pointer approach will be modified/abandoned.
---
notmuch-search.c | 109
From: David Bremner brem...@debian.org
As we noticed when Jani kindly converted things to getopt_long, much
of the work in argument parsing in notmuch is due to the the key-value
style arguments like --format=(raw|json|text).
The framework here provides positional arguments, simple switches
From: David Bremner brem...@debian.org
The output file is handled via positional arguments. There are
currently no normal options.
---
notmuch-dump.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/notmuch-dump.c b/notmuch-dump.c
index
From: David Bremner brem...@debian.org
The new argument handling is a bit more concise, and bit more
flexible. It allows the input file name to go before the --accumulate
option.
---
notmuch-restore.c | 37 +++--
1 files changed, 15 insertions(+), 22 deletions
So it turns out the completely untested NOTMUCH_OPT_STRING code was
(surpise!) buggy. I also fixed a few remaining formatting issues, added
a unit test, and some documentation (in command-line-arguements.h).
I also reordered option description struct so that the two mandatory
(in the sense of
From: David Bremner brem...@debian.org
The output file is handled via positional arguments. There are
currently no normal options.
---
notmuch-dump.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/notmuch-dump.c b/notmuch-dump.c
index
From: David Bremner brem...@debian.org
The new argument handling is a bit more concise, and bit more
flexible. It allows the input file name to go before the --accumulate
option.
---
notmuch-restore.c | 37 +++--
1 files changed, 15 insertions(+), 22 deletions
From: David Bremner brem...@debian.org
This was needed because no current notmuch code exercises the
NOTMUCH_OPT_STRING style arguments.
---
test/Makefile.local | 11 -
test/arg-test.c | 52 +
test/argument-parsing | 16
From: David Bremner brem...@debian.org
As we noticed when Jani kindly converted things to getopt_long, much
of the work in argument parsing in notmuch is due to the the key-value
style arguments like --format=(raw|json|text).
The framework here provides positional arguments, simple switches
On Wed, 07 Dec 2011 15:54:05 +0100, Rainer M Krug r.m.k...@gmail.com wrote:
Interesting. I assume, I have to do
./configure
make
make debian-snapshot
Just make debian-snapshot should work if you have the packages
dpkg-dev and fakeroot installed.
dpkg-buildpackage: warning: (Use -d flag to
On Wed, 14 Sep 2011 00:32:01 +0300, tomi.oll...@iki.fi wrote:
This patch set adds a configuration option 'database.exclude'; a list of
files/directories to be excluded when doing 'notmuch new' operation.
Hi All;
I could see idea of excluding spam and trash folders from indexing being
useful,
On Wed, 30 Nov 2011 01:19:51 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
Changes:
v4 since v3:
* Use $(()) instead of expr(1) for math.
pushed
d
___
notmuch mailing list
notmuch@notmuchmail.org
On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
Add optional props argument to `notmuch-show-get-header'. Use it to
get headers in `notmuch-show-insert-part-multipart/signed' and
`notmuch-show-insert-part-multipart/encrypted'.
Pushed this series.
d
On Sat, 23 Jul 2011 10:54:03 +0100, pazz patricktot...@googlemail.com wrote:
expect the date_relative field for thread entries
in notmuch search's json output
---
I pushed an amended version of this one (explaining why the date won't
change in the future), and the next patch as well.
d
Hi All;
As some of you know I have been making some effort to get a handle on
the patches to notmuch floating around using nmbug [1]. We are doing
pretty well keeping track of current patches, and I started working my
way back through things that looked like patches. Sometime around the
release
From: David Bremner brem...@debian.org
Installing w3m-el provides a nicer out of the box experience for
viewing html in notmuch, and the overhead is not too bad (about 5M
diskspace).
---
debian/control |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/debian/control b
On Thu, 08 Dec 2011 13:33:09 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
I am not sure recommending w3m-el is a good idea. It has very annoying
bugs with scrolling (C-n): at some point the cursor jumps back above,
i.e. it goes in a loop. I did not investigate the issue though.
On Wed, 7 Dec 2011 15:26:35 -0400, David Bremner da...@tethera.net wrote:
The framework here provides positional arguments, simple switches,
and --key=value style arguments that can take a value being an integer,
a string, or one of a set of keywords.
and I pushed v4 of this series.
d
On Sat, 10 Dec 2011 13:24:36 -0500, Austin Clements amdra...@mit.edu wrote:
What about something like
const char **
notmuch_config_get_user_other_email (notmuch_config_t *config,
size_t *length)
{
return _config_get_list (config, user, other_email,
I have pushed a branch jlog
git://pivot.cs.unb.ca/notmuch.git
This uses the jlog library (http://labs.omniti.com/labs/jlog)
to atomically log messages in pub-sub model.
On this branch you can enable logging of tagging operations by
notmuch config set log.subscribers 'name1;name2;name3'
On Wed, 7 Dec 2011 10:46:17 +0100, Thomas Jost schno...@schnouki.net wrote:
The new test_python() function makes writing Python tests a little easier:
- it sets the environment variables as needed
- it redirects stdout to the OUTPUT file (like test_emacs()).
pushed both, after rebasing.
From: David Bremner brem...@debian.org
Two new internal routines are created _config_get_list and
_config_set_list; the notmuch_config_get_* functions that deal with
lists are simply wrappers for these functions.
---
notmuch-config.c | 130
From: David Bremner brem...@debian.org
The character set is chosen to be suitable for pathnames, and the same
as that used by contrib/nmbug. The new encoded/decoded strings are
allocated using talloc.
---
This isn't urgent, but it is useful for a couple projects I have
brewing (nmbug compatible
On Fri, 9 Dec 2011 00:48:28 +0200, Jani Nikula j...@nikula.org wrote:
Hi all, this is v4 of the notmuch hooks patches. Changes:
* Fix WIFEXITED (id:8739cxzv30@nikula.org).
* Add tests.
v4 is pushed, thanks everyone.
d
___
notmuch mailing
On Sat, 10 Dec 2011 23:27:02 -0400, David Bremner da...@tethera.net wrote:
This uses the jlog library (http://labs.omniti.com/labs/jlog)
to atomically log messages in pub-sub model.
Some more explanations.
Part 1: pub-what?
=
What is pub-sub? Conceptually you can think
On Sun, 11 Dec 2011 21:56:36 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
-CLEAN := $(CLEAN) $(dir)/xutil.o $(dir)/error_util.o $(dir)/libutil.a
+CLEAN := $(CLEAN) $(libutil_modules) $(dir)/libutil.a
IMO this should be pushed as a separate patch (that does not need a
From: David Bremner brem...@debian.org
The idea is that $test_count could be used in tests to label
intermediate files. The output enabled by this patch (and --debug)
helps figure out which OUTPUT.nn file belongs to which test in case
several subtests write to OUTPUT.$test_count
From: David Bremner brem...@debian.org
The test binary hex-xcode can also be used to check for memory leaks.
---
test/.gitignore |1 +
test/Makefile.local |6 +++-
test/basic |2 +-
test/hex-escaping | 20 +
test/hex-xcode.c| 76
From: David Bremner brem...@debian.org
The first test is really to test our assumptions about the corpus,
namely that a certain set of message-id's is safe (i.e. doesn't change
under hex-escaping). We then check dump output as best we can without
functionality-to-come in notmuch-restore
Hi All;
There are some style/doc issues remaining, but because bugs in dump
and restore really suck, I thought I would ask for early feedback on
functionality. I'm particularly interested in how the new dump format
works for weird message-ids (spaces and so on). If you have public
messages with
From: David Bremner brem...@debian.org
The character set is chosen to be suitable for pathnames, and the same as that
used by contrib/nmbug
---
util/Makefile.local |2 +-
util/hex-escape.c | 150 +++
util/hex-escape.h | 15 +
3 files
From: David Bremner brem...@debian.org
These one need the completed functionality in notmuch-restore. Fairly
exotic tags are tested, but no weird message id's.
---
test/dump-restore | 33 +
1 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/test
From: David Bremner brem...@debian.org
sup is the old format, and remains the default.
Each line of the notmuch format is msg_id tag tag...tag where each
space seperated token is 'hex-encoded' to remove troubling characters.
In particular this format won't have the same problem with e.g. spaces
From: David Bremner brem...@debian.org
This is format is whitespace separated tokens, encoded by
util/hex-escape.c
---
notmuch-restore.c | 83
1 files changed, 64 insertions(+), 19 deletions(-)
diff --git a/notmuch-restore.c b/notmuch
On Tue, 13 Dec 2011 14:22:21 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
I've only been vaguely following this test count stuff, but I'm not
sure I understand what's the point of giving tests a number that is
ultimately mutable. Why not just label things by the test name,
On Tue, 13 Dec 2011 15:25:14 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
On Tue, 13 Dec 2011 19:18:16 -0400, David Bremner da...@tethera.net wrote:
We don't actually have test names, at least not ones directly suitable
for file names. I guess we could encode them
From: David Bremner brem...@debian.org
hex-escape: fix for handling of 8 bit chars
The low level problem was passing negative numbers to sprintf(s,%x);
we fix this and clarify the api for hex_(decode|encode) by making
encode go from (unsigned char *) (i.e. 8bit) to (char *) and decode
vise-versa
From: David Bremner brem...@debian.org
The problem is a use of signed chars in places where unsigned
chars (i.e. 0-255) should be used.
---
Well, I did mention more tests were needed ;). I failed to test 8 bit
(127) stuff and sure enough it was broken. This sets up some tests
to demonstrate
On Thu, 15 Dec 2011 00:36:38 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
I did not do a proper review. But I think the encoder and decoder
should accept and return the same type, either char* or unsigned char*.
The decision should be based on what type strings (that would be
On Sun, 11 Dec 2011 17:21:09 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
Debian tags have been using '/', instead of '-' as a separator.
pushed
d
___
notmuch mailing list
notmuch@notmuchmail.org
On Mon, 12 Dec 2011 22:50:04 +0200, Jani Nikula j...@nikula.org wrote:
Support nil value for notmuch-poll-script to run notmuch new instead of
an external script, and make this the new default. notmuch new is run
using the configured notmuch-command.
pushed.
d
201 - 300 of 10827 matches
Mail list logo
