Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

On Tue, 31 Jan 2012 08:31:26 -0800, Jameson Graef Rollins wrote: > On Tue, 31 Jan 2012 08:09:08 +0000, David Edmondson wrote: > > On Mon, 30 Jan 2012 09:47:34 -0800, Jameson Graef Rollins > > wrote: > > > One thing I've noticed, which isn't actually part of

[PATCH 0/5 v4] reworked crypto toggle, plus a few other toggles

I mangled the "in-reply-to" header, which should be 1327486729-18052-1-git-send-email-dme at dme.org (i.e. id:"1327486729-18052-1-git-send-email-dme at dme.org"). -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size:

[PATCH 5/5] emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'.

With an argument, record and reply the state of the buffer during `notmuch-show-refresh-view'. In this context, "state" is defined as: - the open/closed state of each message, - the current message. Traditional use of refresh with the = key does not retain the state. The recently introduced tog

[PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 789b6d9..28f2148 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1116,6 +1116,7 @@ Refreshes the current view, observing changes

[PATCH 3/5] emacs: Allow the indentation of content to be toggled.

Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH 2/5] emacs: Allow `notmuch-show-mode' to display only matching messages.

The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

[PATCH 1/5] emacs: Rework crypto switch toggle.

Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

[PATCH 0/5 v4] reworked crypto toggle, plus a few other toggles

v4: - Don't retain the state for '='. - If refreshing the view removes the previously current message from view, leave the cursor at (point-min). - Adjust the display after refreshing if the previously current message is found. David Edmondson (5): emacs: Rework crypt

[PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

On Tue, 31 Jan 2012 12:24:27 +0400, Dmitry Kurochkin wrote: > This is why I like big diff contexts... Can I set that in my .gitconfig? -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not availa

Re: [PATCH 3/5] emacs: Allow the indentation of content to be toggled.

On Tue, 31 Jan 2012 16:15:11 +, Mark Walters wrote: > Hi I have reviewed the patch series within the limits of my lisp > knowledge. Patch 1: is rather beyond my lisp so I won't comment on that > (and I have never tried crypto): Patches 2-5 look fine with one > bikeshed and one query for my o

[PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin wrote: > On Tue, 31 Jan 2012 08:01:54 +0000, David Edmondson wrote: > > When using the spacebar to scroll through a thread, hitting 'space' > > when the bottom of the last message is visible should take the cursor >

[PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

On Mon, 30 Jan 2012 09:47:34 -0800, Jameson Graef Rollins wrote: > One thing I've noticed, which isn't actually part of this patch, is that > the long-line truncation doesn't respect the indentation, which makes > things look strange. Which lines are getting wrapped in a way that you don't like?

[PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

When using the spacebar to scroll through a thread, hitting 'space' when the bottom of the last message is visible should take the cursor to the end of the buffer rather than immediately archiving the thread and moving to the next thread. --- emacs/notmuch-show.el |5 + 1 files changed, 5

[PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.

When archiving the last message in a thread (a), rather than just moving the pointer to the next thread in the parent search buffer, actually display the next thread. --- emacs/notmuch-show.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/n

[PATCH 0/2] adjust the new movement commands

After Jameson's recent work the precise behaviour of 'a' and ' ' in `notmuch-show-mode' changed slightly. Revert to something nearer the previous behaviour. David Edmondson (2): emacs: If archiving the last message in a thread, show the next thread. emacs:

Re: [RFC PATCH] emacs: make show view a/A/x/X key bindings more consistent

On Tue, 31 Jan 2012 17:03:55 +0200, Jani Nikula wrote: > 'a' = Archive current message, then move to next message, or show next > thread from search if at the last message in thread. > > 'A' = Archive each message in thread, then show next thread from > search. > > 'x' = Archive current message,

[PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'.

On Mon, 30 Jan 2012 20:19:23 +, Mark Walters wrote: > The first is that I currently sometimes use = (that is > notmuch-show-refresh-view) as a way to go back to the original state (ie > which messages are open and back to the first message) so I am not sure > the keep state version should com

[PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness.

On Mon, 30 Jan 2012 18:46:55 -0500, Austin Clements wrote: > >(message "End of search results." > > Should this instead be an `error'? It was an error in the past (until id:"1324370714-28545-1-git-send-email-dme at dme.org"), but I found it to be very annoying and switched it to use

Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

On Mon, 30 Jan 2012 21:25:19 -0800, Jameson Graef Rollins wrote: > On Mon, 30 Jan 2012 16:52:20 +0000, David Edmondson wrote: > > The blank line doesn't really change position, but is now considered > > to be part of the body rather than part of the headers. This means &g

Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.

On Tue, 31 Jan 2012 11:25:36 +0200, Tomi Ollila wrote: > I like David's alternative suggestion (in IRC) where cursor is left at > the end of buffer in case last message is archived with 'a'. Unless the cursor is already at the end of the buffer, in which case it would do the 'next thread' dance (

Re: [PATCH 0/5 v4] reworked crypto toggle, plus a few other toggles

I mangled the "in-reply-to" header, which should be 1327486729-18052-1-git-send-email-...@dme.org (i.e. id:"1327486729-18052-1-git-send-email-...@dme.org"). pgpgoxHbRi9Py.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org ht

[PATCH 5/5] emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'.

With an argument, record and reply the state of the buffer during `notmuch-show-refresh-view'. In this context, "state" is defined as: - the open/closed state of each message, - the current message. Traditional use of refresh with the = key does not retain the state. The recently introduced tog

[PATCH 1/5] emacs: Rework crypto switch toggle.

Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

[PATCH 3/5] emacs: Allow the indentation of content to be toggled.

Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH 2/5] emacs: Allow `notmuch-show-mode' to display only matching messages.

The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

[PATCH 0/5 v4] reworked crypto toggle, plus a few other toggles

v4: - Don't retain the state for '='. - If refreshing the view removes the previously current message from view, leave the cursor at (point-min). - Adjust the display after refreshing if the previously current message is found. David Edmondson (5): emacs: Rework crypt

[PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 789b6d9..28f2148 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1116,6 +1116,7 @@ Refreshes the current view, observing changes

Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

On Tue, 31 Jan 2012 12:24:27 +0400, Dmitry Kurochkin wrote: > This is why I like big diff contexts... Can I set that in my .gitconfig? pgpiZDCjOwESC.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.or

Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin wrote: > On Tue, 31 Jan 2012 08:01:54 +0000, David Edmondson wrote: > > When using the spacebar to scroll through a thread, hitting 'space' > > when the bottom of the last message is visible should take the cursor >

Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

On Mon, 30 Jan 2012 09:47:34 -0800, Jameson Graef Rollins wrote: > One thing I've noticed, which isn't actually part of this patch, is that > the long-line truncation doesn't respect the indentation, which makes > things look strange. Which lines are getting wrapped in a way that you don't like?

[PATCH 0/2] adjust the new movement commands

After Jameson's recent work the precise behaviour of 'a' and ' ' in `notmuch-show-mode' changed slightly. Revert to something nearer the previous behaviour. David Edmondson (2): emacs: If archiving the last message in a thread, show the next thread. emacs:

[PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

When using the spacebar to scroll through a thread, hitting 'space' when the bottom of the last message is visible should take the cursor to the end of the buffer rather than immediately archiving the thread and moving to the next thread. --- emacs/notmuch-show.el |5 + 1 files changed, 5

[PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.

When archiving the last message in a thread (a), rather than just moving the pointer to the next thread in the parent search buffer, actually display the next thread. --- emacs/notmuch-show.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/n

Re: [PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'.

On Mon, 30 Jan 2012 20:19:23 +, Mark Walters wrote: > The first is that I currently sometimes use = (that is > notmuch-show-refresh-view) as a way to go back to the original state (ie > which messages are open and back to the first message) so I am not sure > the keep state version should com

Re: [PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness.

On Mon, 30 Jan 2012 18:46:55 -0500, Austin Clements wrote: > >(message "End of search results." > > Should this instead be an `error'? It was an error in the past (until id:"1324370714-28545-1-git-send-email-...@dme.org"), but I found it to be very annoying and switched it to use `me

[PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

On Mon, 30 Jan 2012 19:33:10 +0200, Jani Nikula wrote: > > + (define-key map ">" 'toggle-truncate-lines) > > Okay, this is bikeshedding, but we have ? to pipe a message - wouldn't it > be appropriate to reserve > for saving a message to file? No, that's "o" for 'output'. :-) --

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

The blank line doesn't really change position, but is now considered to be part of the body rather than part of the headers. This means that it is visible when the body is visible rather than when the headers are visible. --- I'm interested in getting feedback on this. Unless you run with `notmuc

[PATCH 3/3] emacs: Allow the indentation of content to be toggled.

On Sun, 29 Jan 2012 22:30:42 +, Mark Walters wrote: > I really like the feature and would definitely use it. However, I have a > couple of niggles with the implementation. First, when toggled it seems > to redisplay so it jumps back to the first matching message regardless > of where you are

[PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'.

Record the state of the buffer during `notmuch-show-refresh-view'. In this context, "state" is defined as: - the open/closed state of each message, - the current message. --- emacs/notmuch-show.el | 41 + 1 files changed, 37 insertions(+), 4 deletions(-

[PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index a2c4daf..8b07adf 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1114,6 +1114,7 @@ Refreshes the current view, observing changes

[PATCH 3/5] emacs: Allow the indentation of content to be toggled.

Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH 2/5] emacs: Allow `notmuch-show-mode' to display only matching messages.

The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

[PATCH 1/5] emacs: Rework crypto switch toggle.

Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

[PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

v3: - Add a toggle for line truncation (>). - Retain the state of a show buffer across a call to refresh (which includes the various toggles here). David Edmondson (5): emacs: Rework crypto switch toggle. emacs: Allow `notmuch-show-mode' to display only matching messages. emac

[PATCH 2/2] emacs: new mua mailto: URI handler

On Sun, 29 Jan 2012 11:33:44 -0800, Jameson Graef Rollins wrote: > The new function 'notmuch-mua-mailto' provides an interactive handler > for rfc6068 "mailto:"; URIs. It attempts to implement the rfc6068 > specification: http://tools.ietf.org/html/rfc6068 How is this expected to be used? I know

[PATCH] emacs: More address cleaning.

Remove outer single-quotes from the mailbox part. Allow for multiple sets of nested single and double quotes. Add more tests. --- emacs/notmuch-show.el | 24 +--- test/emacs-address-cleaning.el |8 2 files changed, 25 insertions(+), 7 deletions(-) diff

[PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

Good fix, +1 (and for the test). -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL:

[PATCH 3/3 v2] emacs: Allow the indentation of content to be toggled.

Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH 2/3 v2] emacs: Allow `notmuch-show-mode' to display only matching messages.

The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

[PATCH 1/3 v2] emacs: Rework crypto switch toggle.

Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

[PATCH 0/3 v2] reworked crypto toggle, plus a couple of other toggles

- Improved default for `notmuch-show-process-crypto' that is less load order dependant. - Pass the _displayed_ depth of the thread to the body-insertion functions, allowing them to properly wrap when the content is not indented. David Edmondson (3): emacs: Rework crypto switch t

[PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

On Mon, 30 Jan 2012 09:37:17 +, David Edmondson wrote: > On Sun, 29 Jan 2012 12:06:57 -0800, Jameson Graef Rollins finestructure.net> wrote: > > > My inclination is to remove `notmuch-crypto-process-mime' altogether > > > (declared it an obsolete variable) and

[PATCH 0/2 v2] minor cleanup and improvements

Oops. That should be 'v3'. I need a bunch of automation to make posting patches simpler. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL:

[PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

f --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el index 880f96d..6653d97 100644 --- a/emacs/notmuch-print.el +++ b/emacs/notmuch-print.el @@ -19,6 +19,8 @@ ;; ;; Authors: David Edmondson +(require 'notmuch-lib) + (declare-function notmuch-show-get-prop "notmuch-show" (prop

[PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness.

There's no need to call `truncate-string-to-width' twice in this code path. --- emacs/notmuch.el | 22 ++ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 72f78ed..d4d6904 100644 --- a/emacs/notmuch.el +++ b/emacs/notm

[PATCH 0/2 v2] minor cleanup and improvements

Address the comments from Mark and Austin: - Don't assume that `subject' is a string, - Show [No Subject] in search output David Edmondson (2): emacs: Stop the `truncate-string-to-width' madness. emacs: Prefer '[No Subject]' to blank subjects. emac

Re: [PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

On Mon, 30 Jan 2012 19:33:10 +0200, Jani Nikula wrote: > > + (define-key map ">" 'toggle-truncate-lines) > > Okay, this is bikeshedding, but we have ¦ to pipe a message - wouldn't it > be appropriate to reserve > for saving a message to file? No, that's "o" for 'output'. :-) pgpYe8pEXEub

Bug: emacs 23.2 doesn't like ido-completing-read

On Sun, 29 Jan 2012 23:17:55 +, Mark Walters wrote: > I have been experimenting with notmuch-always-prompt-for-sender on my > debian stable setup (emacs 23.2.1) and it doesn't like > ido-completing-read. It goes to the minibuffer and then it seems to be > impossible to exit the minibuffer. >

[PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

On Sun, 29 Jan 2012 12:06:57 -0800, Jameson Graef Rollins wrote: > > My inclination is to remove `notmuch-crypto-process-mime' altogether > > (declared it an obsolete variable) and allow users to set a default > > for `notmuch-show-process-crypto' directly, but that is not done in > > this patchse

[PATCH 3/3] emacs: Allow the indentation of content to be toggled.

On Sun, 29 Jan 2012 22:30:42 +, Mark Walters wrote: > First, when toggled it seems to redisplay so it jumps back to the > first matching message regardless of where you are in the thread (and > closes messages you have opened). Yes, I agree that is annoying. Annoying enough to block the patc

[PATCH 2/2] test: remove explicit loading of elisp tests in emacs-address-cleaning

Obviously good, +1. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL:

[PATCH 1/2] test: auto load elisp tests file in test_emacs if available

Nice idea, +1. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL:

[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner wrote: > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula wrote: > > On Jan 28, 2012 2:41 PM, "David Bremner" wrote: > > > > Sometimes someone (Dmitry?) sent patches that separated a small functional > > change, and the big non-functional indenta

[PATCH 0/2] Add a fake 'Tags' header

On Sat, 28 Jan 2012 08:16:04 -0400, David Bremner wrote: > On Thu, 26 Jan 2012 18:16:27 +0000, David Edmondson wrote: > > From a discussion in #notmuch, add a fake 'Tags' header when > > displaying messages and ensure that it's kept up to date. > > Indeed

[PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness.

On Sat, 28 Jan 2012 00:09:58 -0500, Austin Clements wrote: > Quoth David Edmondson on Jan 25 at 1:48 pm: > > There's no need to call `truncate-string-to-width' twice in this code > > path. > > LGTM if what I point out below is okay. Technically this changes t

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

The blank line doesn't really change position, but is now considered to be part of the body rather than part of the headers. This means that it is visible when the body is visible rather than when the headers are visible. --- I'm interested in getting feedback on this. Unless you run with `notmuc

Re: [PATCH 3/3] emacs: Allow the indentation of content to be toggled.

On Sun, 29 Jan 2012 22:30:42 +, Mark Walters wrote: > I really like the feature and would definitely use it. However, I have a > couple of niggles with the implementation. First, when toggled it seems > to redisplay so it jumps back to the first matching message regardless > of where you are

[PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'.

Record the state of the buffer during `notmuch-show-refresh-view'. In this context, "state" is defined as: - the open/closed state of each message, - the current message. --- emacs/notmuch-show.el | 41 + 1 files changed, 37 insertions(+), 4 deletions(-

[PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index a2c4daf..8b07adf 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1114,6 +1114,7 @@ Refreshes the current view, observing changes

[PATCH 1/5] emacs: Rework crypto switch toggle.

Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

[PATCH 3/5] emacs: Allow the indentation of content to be toggled.

Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH 2/5] emacs: Allow `notmuch-show-mode' to display only matching messages.

The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

[PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

v3: - Add a toggle for line truncation (>). - Retain the state of a show buffer across a call to refresh (which includes the various toggles here). David Edmondson (5): emacs: Rework crypto switch toggle. emacs: Allow `notmuch-show-mode' to display only matching messages. emac

[PATCH v2 2/2] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

Looks good. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL:

[PATCH v2 1/2] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

Looks good. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL:

Re: [PATCH 2/2] emacs: new mua mailto: URI handler

On Sun, 29 Jan 2012 11:33:44 -0800, Jameson Graef Rollins wrote: > The new function 'notmuch-mua-mailto' provides an interactive handler > for rfc6068 "mailto:"; URIs. It attempts to implement the rfc6068 > specification: http://tools.ietf.org/html/rfc6068 How is this expected to be used? I kno

[PATCH] emacs: More address cleaning.

Remove outer single-quotes from the mailbox part. Allow for multiple sets of nested single and double quotes. Add more tests. --- emacs/notmuch-show.el | 24 +--- test/emacs-address-cleaning.el |8 2 files changed, 25 insertions(+), 7 deletions(-) diff

Re: [PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

Good fix, +1 (and for the test). pgpLc5RHv9w7L.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/3 v2] emacs: Rework crypto switch toggle.

Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

[PATCH 3/3 v2] emacs: Allow the indentation of content to be toggled.

Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH 0/3 v2] reworked crypto toggle, plus a couple of other toggles

- Improved default for `notmuch-show-process-crypto' that is less load order dependant. - Pass the _displayed_ depth of the thread to the body-insertion functions, allowing them to properly wrap when the content is not indented. David Edmondson (3): emacs: Rework crypto switch t

[PATCH 2/3 v2] emacs: Allow `notmuch-show-mode' to display only matching messages.

The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

On Mon, 30 Jan 2012 09:37:17 +, David Edmondson wrote: > On Sun, 29 Jan 2012 12:06:57 -0800, Jameson Graef Rollins > wrote: > > > My inclination is to remove `notmuch-crypto-process-mime' altogether > > > (declared it an obsolete variable) and allow users to set

Re: [PATCH 0/2 v2] minor cleanup and improvements

Oops. That should be 'v3'. I need a bunch of automation to make posting patches simpler. pgpkwFC77M8DY.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

f --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el index 880f96d..6653d97 100644 --- a/emacs/notmuch-print.el +++ b/emacs/notmuch-print.el @@ -19,6 +19,8 @@ ;; ;; Authors: David Edmondson +(require 'notmuch-lib) + (declare-function notmuch-show-get-prop "notmuch-show&qu

[PATCH 0/2 v2] minor cleanup and improvements

Address the comments from Mark and Austin: - Don't assume that `subject' is a string, - Show [No Subject] in search output David Edmondson (2): emacs: Stop the `truncate-string-to-width' madness. emacs: Prefer '[No Subject]' to blank subjects. emac

[PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness.

There's no need to call `truncate-string-to-width' twice in this code path. --- emacs/notmuch.el | 22 ++ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 72f78ed..d4d6904 100644 --- a/emacs/notmuch.el +++ b/emacs/notm

Re: Bug: emacs 23.2 doesn't like ido-completing-read

On Sun, 29 Jan 2012 23:17:55 +, Mark Walters wrote: > I have been experimenting with notmuch-always-prompt-for-sender on my > debian stable setup (emacs 23.2.1) and it doesn't like > ido-completing-read. It goes to the minibuffer and then it seems to be > impossible to exit the minibuffer. >

Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

On Sun, 29 Jan 2012 12:06:57 -0800, Jameson Graef Rollins wrote: > > My inclination is to remove `notmuch-crypto-process-mime' altogether > > (declared it an obsolete variable) and allow users to set a default > > for `notmuch-show-process-crypto' directly, but that is not done in > > this patchs

Re: [PATCH 3/3] emacs: Allow the indentation of content to be toggled.

On Sun, 29 Jan 2012 22:30:42 +, Mark Walters wrote: > First, when toggled it seems to redisplay so it jumps back to the > first matching message regardless of where you are in the thread (and > closes messages you have opened). Yes, I agree that is annoying. Annoying enough to block the patc

Re: [PATCH 2/2] test: remove explicit loading of elisp tests in emacs-address-cleaning

Obviously good, +1. pgpjsRiys36dp.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] test: auto load elisp tests file in test_emacs if available

Nice idea, +1. pgpzUuzxZvbki.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner wrote: > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula wrote: > > On Jan 28, 2012 2:41 PM, "David Bremner" wrote: > > > > Sometimes someone (Dmitry?) sent patches that separated a small functional > > change, and the big non-functional indenta

Re: [PATCH 0/2] Add a fake 'Tags' header

On Sat, 28 Jan 2012 08:16:04 -0400, David Bremner wrote: > On Thu, 26 Jan 2012 18:16:27 +0000, David Edmondson wrote: > > From a discussion in #notmuch, add a fake 'Tags' header when > > displaying messages and ensure that it's kept up to date. > > Indeed

Re: [PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness.

On Sat, 28 Jan 2012 00:09:58 -0500, Austin Clements wrote: > Quoth David Edmondson on Jan 25 at 1:48 pm: > > There's no need to call `truncate-string-to-width' twice in this code > > path. > > LGTM if what I point out below is okay. Technically this changes t

Re: [PATCH v2 2/2] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

Looks good. pgpDUJUXdYCy0.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2 1/2] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

Looks good. pgppJtTBflADK.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] test: remove ".sh" extension from the recently added Emacs tests

On Sat, 28 Jan 2012 08:47:39 +0400, Dmitry Kurochkin wrote: > All test files, except for the recently added Emacs tests, do not have > ".sh" extension. So remove it from the new test files for consistency. It's fine with me, though I'll point out that they have .sh because of id:"87k44r8s0a.fsf

Re: [PATCH] test: remove ".sh" extension from the recently added Emacs tests

On Sat, 28 Jan 2012 08:47:39 +0400, Dmitry Kurochkin wrote: > All test files, except for the recently added Emacs tests, do not have > ".sh" extension. So remove it from the new test files for consistency. It's fine with me, though I'll point out that they have .sh because of id:"87k44r8s0a

[PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects.

On Fri, 27 Jan 2012 13:31:27 +, Mark Walters wrote: > Oh one other question: I think a search result line in the emacs > interface just has a blank if a thread has no subject. Would it be > appropriate to change that to [No Subject] too? (I have no preference) Yes, makes sense. In the next v

<    4   5   6   7   8   9   10   11   12   13   >