[PATCH 3/4 v3] test: Add test for Original Message hiding at point-min.

2012-01-25 Thread David Edmondson
--- test/emacs-message-hiding.sh | 37 + test/notmuch-test|1 + 2 files changed, 38 insertions(+), 0 deletions(-) create mode 100755 test/emacs-message-hiding.sh diff --git a/test/emacs-message-hiding.sh b/test/emacs-message-hiding.sh new fil

Re: [PATCH 3/4 v2] test: Add test for Original Message hiding at point-min.

2012-01-25 Thread David Edmondson
I've applied changes in accordance with all of the feedback in this mail and the others, except for... On Wed, 25 Jan 2012 21:53:08 +0400, Dmitry Kurochkin wrote: > > + (let ((notmuch-show-insert-text/plain-hook > > '(notmuch-wash-excerpt-citations)) > > Do we have to override the default val

[PATCH 0/2] re-enable line wrapping and add some header bling

2012-01-26 Thread David Edmondson
By default, re-enable `visual-line-mode' in `notmuch-show-mode'. Do it via a hook so that purists (ahem) can turn it off. Add some more processing of headers to make them look nice. Do it via hooks so that unbelievers can turn it off. David Edmondson (2): emacs: Re-enable line w

[PATCH 1/2] emacs: Re-enable line wrapping in `notmuch-show-mode'.

2012-01-26 Thread David Edmondson
Turn on `visual-line-mode' via a hook, so that those who so choose can avoid it. --- emacs/notmuch-show.el |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index e6a5b31..effd2fd 100644 --- a/emacs/notmuch-show.el +++ b/em

[PATCH 2/2] emacs: Add more processing of displayed headers.

2012-01-26 Thread David Edmondson
Wrap headers to the width of the window and indent continuations. --- emacs/notmuch-show.el | 43 --- 1 files changed, 36 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index effd2fd..ad286d1 100644 --- a/emacs/no

Re: [PATCH] emacs: add completion to "tag all" operation ("*" binding)

2012-01-26 Thread David Edmondson
On Thu, 26 Jan 2012 05:47:07 +0400, Dmitry Kurochkin wrote: > > > + ;; Perform some validation > > > + (let ((words action)) > > > +(when (null words) (error "No operation given")) > > > +(while words > > > + (unless (string-match-p "^[-+][-+_.[:word:]]+$" (car words)) > > > + (err

Re: Emacs: Crypto: How to get automatic encryption?

2012-01-26 Thread David Edmondson
On Wed, 25 Jan 2012 09:45:01 -0800, Jameson Graef Rollins wrote: > On Wed, 25 Jan 2012 10:20:26 +0000, David Edmondson wrote: > > Isn't it still necessary to ensure that you have encryption keys > > appropriate to the recipient? > > I want to ensure that all

Re: [RFC] Re: [PATCH] emacs: Add `notmuch-show-stash-gmane' and `notmuch-show-stash-gmane-and-go'.

2012-01-26 Thread David Edmondson
In general, I like this. - I think that the stash function(s) should take an optional argument specifying the archive to use. That will make testing simpler and also allow people to produce preferred bindings more easily. - "Message archive: " feels better than "ML Archive: ", but I don't r

Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility

2012-01-26 Thread David Edmondson
On Thu, 26 Jan 2012 14:02:15 +0100, Pieter Praet wrote: > I may be missing something, but wouldn't both issues be solved by simply > pressing M-RET a second time? I've been using this for a little while > now, and IMO it makes navigating through long and diverging threads a lot > faster, much lik

[PATCH 0/2] Add a fake 'Tags' header

2012-01-26 Thread David Edmondson
>From a discussion in #notmuch, add a fake 'Tags' header when displaying messages and ensure that it's kept up to date. David Edmondson (2): emacs: Add a fake Tags: header during display. test: Update tests for new 'Tags' header. emacs/notmuch-show.el

[PATCH 1/2] emacs: Add a fake Tags: header during display.

2012-01-26 Thread David Edmondson
If `truncate-lines' is `nil' in `notmuch-show-mode' the tags can be lost from the right edge of the window. Create a fake 'Tags' header to display them with the other headers. Enable it by default by adding it to `notmuch-message-headers' and keep it up to date during tagging operations. --- emac

[PATCH 2/2] test: Update tests for new 'Tags' header.

2012-01-26 Thread David Edmondson
--- test/emacs |3 +++ .../notmuch-show-thread-maildir-storage|7 +++ ...hread-maildir-storage-with-fourfold-indentation |7 +++ ...show-thread-maildir-storage-without-indentation |7 +++ 4 files changed, 24 insertions

Re: [PATCH v5 0/2] emacs: add completion to "tag all" operation

2012-01-26 Thread David Edmondson
The series look good to me. pgpRUMqYWERAi.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 0/2] re-enable line wrapping and add some header bling

2012-01-26 Thread David Edmondson
On Thu, 26 Jan 2012 20:17:49 +0400, Dmitry Kurochkin wrote: > I did not review the code, but here is a general comment for both > patches (but especially for the first one). It would be nice to have a > more detailed documentation for hooks. Docstring like "Enable Visual > Line mode." for a fun

Re: [PATCH v4?] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

2012-01-27 Thread David Edmondson
Much nicer :-) On Fri, 27 Jan 2012 09:44:26 +0100, Pieter Praet wrote: > +(defcustom notmuch-show-stash-mlarchive-link-alist > + '(("Gmane" . "http://mid.gmane.org/";) > +("MARC" . "http://marc.info/?i=";) > +("Mail Archive, The" . "http://mail-archive.com/search?l=mid&q=";) > +;; FI

Re: [PATCH 0/3 v2] minor cleanup and improvements

2012-01-27 Thread David Edmondson
On Wed, 25 Jan 2012 13:48:31 +, David Edmondson wrote: > emacs: Stop the `truncate-string-to-width' madness. > emacs: Don't mark messages as "unsaved" when printing. > emacs: Prefer '[No Subject]' to blank subjects. Can I get reviewers for these

Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects.

2012-01-27 Thread David Edmondson
On Fri, 27 Jan 2012 10:23:07 +, Mark Walters wrote: > I am very much not a lisp expert Me neither, so please do continue to review stuff. > The patch 1/3 seems to set the show buffer line to *[No Subject]* where > it used to be just [No Subject]. (I have no preference: I just wasn't > sure i

Re: [PATCH] emacs: add default value to notmuch-search-line-faces

2012-01-27 Thread David Edmondson
On Fri, 27 Jan 2012 10:29:22 +, Mark Walters wrote: > I am not sure if this is the place Here or #notmuch. > to ask but is there a corresponding option for colouring the summary > line in notmuch-show depending on tags/flags? There's id:"1325006003-27152-1-git-send-email-...@dme.org", but

Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects.

2012-01-27 Thread David Edmondson
On Fri, 27 Jan 2012 13:31:27 +, Mark Walters wrote: > Oh one other question: I think a search result line in the emacs > interface just has a blank if a thread has no subject. Would it be > appropriate to change that to [No Subject] too? (I have no preference) Yes, makes sense. In the next v

Re: [PATCH] test: remove ".sh" extension from the recently added Emacs tests

2012-01-28 Thread David Edmondson
On Sat, 28 Jan 2012 08:47:39 +0400, Dmitry Kurochkin wrote: > All test files, except for the recently added Emacs tests, do not have > ".sh" extension. So remove it from the new test files for consistency. It's fine with me, though I'll point out that they have .sh because of id:"87k44r8s0a

Re: [PATCH v2 1/2] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

2012-01-30 Thread David Edmondson
Looks good. pgppJtTBflADK.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2 2/2] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

2012-01-30 Thread David Edmondson
Looks good. pgpDUJUXdYCy0.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness.

2012-01-30 Thread David Edmondson
On Sat, 28 Jan 2012 00:09:58 -0500, Austin Clements wrote: > Quoth David Edmondson on Jan 25 at 1:48 pm: > > There's no need to call `truncate-string-to-width' twice in this code > > path. > > LGTM if what I point out below is okay. Technically this changes t

Re: [PATCH 0/2] Add a fake 'Tags' header

2012-01-30 Thread David Edmondson
On Sat, 28 Jan 2012 08:16:04 -0400, David Bremner wrote: > On Thu, 26 Jan 2012 18:16:27 +0000, David Edmondson wrote: > > From a discussion in #notmuch, add a fake 'Tags' header when > > displaying messages and ensure that it's kept up to date. > > Indeed

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-30 Thread David Edmondson
On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner wrote: > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula wrote: > > On Jan 28, 2012 2:41 PM, "David Bremner" wrote: > > > > Sometimes someone (Dmitry?) sent patches that separated a small functional > > change, and the big non-functional indenta

Re: [PATCH 1/2] test: auto load elisp tests file in test_emacs if available

2012-01-30 Thread David Edmondson
Nice idea, +1. pgpzUuzxZvbki.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 2/2] test: remove explicit loading of elisp tests in emacs-address-cleaning

2012-01-30 Thread David Edmondson
Obviously good, +1. pgpjsRiys36dp.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 3/3] emacs: Allow the indentation of content to be toggled.

2012-01-30 Thread David Edmondson
On Sun, 29 Jan 2012 22:30:42 +, Mark Walters wrote: > First, when toggled it seems to redisplay so it jumps back to the > first matching message regardless of where you are in the thread (and > closes messages you have opened). Yes, I agree that is annoying. Annoying enough to block the patc

Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

2012-01-30 Thread David Edmondson
On Sun, 29 Jan 2012 12:06:57 -0800, Jameson Graef Rollins wrote: > > My inclination is to remove `notmuch-crypto-process-mime' altogether > > (declared it an obsolete variable) and allow users to set a default > > for `notmuch-show-process-crypto' directly, but that is not done in > > this patchs

Re: Bug: emacs 23.2 doesn't like ido-completing-read

2012-01-30 Thread David Edmondson
On Sun, 29 Jan 2012 23:17:55 +, Mark Walters wrote: > I have been experimenting with notmuch-always-prompt-for-sender on my > debian stable setup (emacs 23.2.1) and it doesn't like > ido-completing-read. It goes to the minibuffer and then it seems to be > impossible to exit the minibuffer. >

[PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness.

2012-01-30 Thread David Edmondson
There's no need to call `truncate-string-to-width' twice in this code path. --- emacs/notmuch.el | 22 ++ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 72f78ed..d4d6904 100644 --- a/emacs/notmuch.el +++ b/emacs/notm

[PATCH 0/2 v2] minor cleanup and improvements

2012-01-30 Thread David Edmondson
Address the comments from Mark and Austin: - Don't assume that `subject' is a string, - Show [No Subject] in search output David Edmondson (2): emacs: Stop the `truncate-string-to-width' madness. emacs: Prefer '[No Subject]' to blank subjects. emac

[PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-01-30 Thread David Edmondson
f --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el index 880f96d..6653d97 100644 --- a/emacs/notmuch-print.el +++ b/emacs/notmuch-print.el @@ -19,6 +19,8 @@ ;; ;; Authors: David Edmondson +(require 'notmuch-lib) + (declare-function notmuch-show-get-prop "notmuch-show&qu

Re: [PATCH 0/2 v2] minor cleanup and improvements

2012-01-30 Thread David Edmondson
Oops. That should be 'v3'. I need a bunch of automation to make posting patches simpler. pgpkwFC77M8DY.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

2012-01-30 Thread David Edmondson
On Mon, 30 Jan 2012 09:37:17 +, David Edmondson wrote: > On Sun, 29 Jan 2012 12:06:57 -0800, Jameson Graef Rollins > wrote: > > > My inclination is to remove `notmuch-crypto-process-mime' altogether > > > (declared it an obsolete variable) and allow users to set

[PATCH 2/3 v2] emacs: Allow `notmuch-show-mode' to display only matching messages.

2012-01-30 Thread David Edmondson
The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

[PATCH 0/3 v2] reworked crypto toggle, plus a couple of other toggles

2012-01-30 Thread David Edmondson
- Improved default for `notmuch-show-process-crypto' that is less load order dependant. - Pass the _displayed_ depth of the thread to the body-insertion functions, allowing them to properly wrap when the content is not indented. David Edmondson (3): emacs: Rework crypto switch t

[PATCH 3/3 v2] emacs: Allow the indentation of content to be toggled.

2012-01-30 Thread David Edmondson
Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH 1/3 v2] emacs: Rework crypto switch toggle.

2012-01-30 Thread David Edmondson
Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

Re: [PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

2012-01-30 Thread David Edmondson
Good fix, +1 (and for the test). pgpLc5RHv9w7L.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: More address cleaning.

2012-01-30 Thread David Edmondson
Remove outer single-quotes from the mailbox part. Allow for multiple sets of nested single and double quotes. Add more tests. --- emacs/notmuch-show.el | 24 +--- test/emacs-address-cleaning.el |8 2 files changed, 25 insertions(+), 7 deletions(-) diff

Re: [PATCH 2/2] emacs: new mua mailto: URI handler

2012-01-30 Thread David Edmondson
On Sun, 29 Jan 2012 11:33:44 -0800, Jameson Graef Rollins wrote: > The new function 'notmuch-mua-mailto' provides an interactive handler > for rfc6068 "mailto:"; URIs. It attempts to implement the rfc6068 > specification: http://tools.ietf.org/html/rfc6068 How is this expected to be used? I kno

[PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

2012-01-30 Thread David Edmondson
v3: - Add a toggle for line truncation (>). - Retain the state of a show buffer across a call to refresh (which includes the various toggles here). David Edmondson (5): emacs: Rework crypto switch toggle. emacs: Allow `notmuch-show-mode' to display only matching messages. emac

[PATCH 2/5] emacs: Allow `notmuch-show-mode' to display only matching messages.

2012-01-30 Thread David Edmondson
The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

[PATCH 3/5] emacs: Allow the indentation of content to be toggled.

2012-01-30 Thread David Edmondson
Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH 1/5] emacs: Rework crypto switch toggle.

2012-01-30 Thread David Edmondson
Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

[PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

2012-01-30 Thread David Edmondson
--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index a2c4daf..8b07adf 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1114,6 +1114,7 @@ Refreshes the current view, observing changes

[PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'.

2012-01-30 Thread David Edmondson
Record the state of the buffer during `notmuch-show-refresh-view'. In this context, "state" is defined as: - the open/closed state of each message, - the current message. --- emacs/notmuch-show.el | 41 + 1 files changed, 37 insertions(+), 4 deletions(-

Re: [PATCH 3/3] emacs: Allow the indentation of content to be toggled.

2012-01-30 Thread David Edmondson
On Sun, 29 Jan 2012 22:30:42 +, Mark Walters wrote: > I really like the feature and would definitely use it. However, I have a > couple of niggles with the implementation. First, when toggled it seems > to redisplay so it jumps back to the first matching message regardless > of where you are

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-30 Thread David Edmondson
The blank line doesn't really change position, but is now considered to be part of the body rather than part of the headers. This means that it is visible when the body is visible rather than when the headers are visible. --- I'm interested in getting feedback on this. Unless you run with `notmuc

Re: [PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

2012-01-30 Thread David Edmondson
On Mon, 30 Jan 2012 19:33:10 +0200, Jani Nikula wrote: > > + (define-key map ">" 'toggle-truncate-lines) > > Okay, this is bikeshedding, but we have ¦ to pipe a message - wouldn't it > be appropriate to reserve > for saving a message to file? No, that's "o" for 'output'. :-) pgpYe8pEXEub

Re: [PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness.

2012-01-30 Thread David Edmondson
On Mon, 30 Jan 2012 18:46:55 -0500, Austin Clements wrote: > >(message "End of search results." > > Should this instead be an `error'? It was an error in the past (until id:"1324370714-28545-1-git-send-email-...@dme.org"), but I found it to be very annoying and switched it to use `me

Re: [PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'.

2012-01-30 Thread David Edmondson
On Mon, 30 Jan 2012 20:19:23 +, Mark Walters wrote: > The first is that I currently sometimes use = (that is > notmuch-show-refresh-view) as a way to go back to the original state (ie > which messages are open and back to the first message) so I am not sure > the keep state version should com

[PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.

2012-01-31 Thread David Edmondson
When archiving the last message in a thread (a), rather than just moving the pointer to the next thread in the parent search buffer, actually display the next thread. --- emacs/notmuch-show.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/n

[PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

2012-01-31 Thread David Edmondson
When using the spacebar to scroll through a thread, hitting 'space' when the bottom of the last message is visible should take the cursor to the end of the buffer rather than immediately archiving the thread and moving to the next thread. --- emacs/notmuch-show.el |5 + 1 files changed, 5

[PATCH 0/2] adjust the new movement commands

2012-01-31 Thread David Edmondson
After Jameson's recent work the precise behaviour of 'a' and ' ' in `notmuch-show-mode' changed slightly. Revert to something nearer the previous behaviour. David Edmondson (2): emacs: If archiving the last message in a thread, show the next thread. emacs:

Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

2012-01-31 Thread David Edmondson
On Mon, 30 Jan 2012 09:47:34 -0800, Jameson Graef Rollins wrote: > One thing I've noticed, which isn't actually part of this patch, is that > the long-line truncation doesn't respect the indentation, which makes > things look strange. Which lines are getting wrapped in a way that you don't like?

Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

2012-01-31 Thread David Edmondson
On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin wrote: > On Tue, 31 Jan 2012 08:01:54 +0000, David Edmondson wrote: > > When using the spacebar to scroll through a thread, hitting 'space' > > when the bottom of the last message is visible should take the cursor >

Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

2012-01-31 Thread David Edmondson
On Tue, 31 Jan 2012 12:24:27 +0400, Dmitry Kurochkin wrote: > This is why I like big diff contexts... Can I set that in my .gitconfig? pgpiZDCjOwESC.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.or

[PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

2012-01-31 Thread David Edmondson
--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 789b6d9..28f2148 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1116,6 +1116,7 @@ Refreshes the current view, observing changes

[PATCH 0/5 v4] reworked crypto toggle, plus a few other toggles

2012-01-31 Thread David Edmondson
v4: - Don't retain the state for '='. - If refreshing the view removes the previously current message from view, leave the cursor at (point-min). - Adjust the display after refreshing if the previously current message is found. David Edmondson (5): emacs: Rework crypt

[PATCH 2/5] emacs: Allow `notmuch-show-mode' to display only matching messages.

2012-01-31 Thread David Edmondson
The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

[PATCH 3/5] emacs: Allow the indentation of content to be toggled.

2012-01-31 Thread David Edmondson
Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH 1/5] emacs: Rework crypto switch toggle.

2012-01-31 Thread David Edmondson
Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

[PATCH 5/5] emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'.

2012-01-31 Thread David Edmondson
With an argument, record and reply the state of the buffer during `notmuch-show-refresh-view'. In this context, "state" is defined as: - the open/closed state of each message, - the current message. Traditional use of refresh with the = key does not retain the state. The recently introduced tog

Re: [PATCH 0/5 v4] reworked crypto toggle, plus a few other toggles

2012-01-31 Thread David Edmondson
I mangled the "in-reply-to" header, which should be 1327486729-18052-1-git-send-email-...@dme.org (i.e. id:"1327486729-18052-1-git-send-email-...@dme.org"). pgpgoxHbRi9Py.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org ht

Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.

2012-01-31 Thread David Edmondson
On Tue, 31 Jan 2012 11:25:36 +0200, Tomi Ollila wrote: > I like David's alternative suggestion (in IRC) where cursor is left at > the end of buffer in case last message is archived with 'a'. Unless the cursor is already at the end of the buffer, in which case it would do the 'next thread' dance (

Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-31 Thread David Edmondson
On Mon, 30 Jan 2012 21:25:19 -0800, Jameson Graef Rollins wrote: > On Mon, 30 Jan 2012 16:52:20 +0000, David Edmondson wrote: > > The blank line doesn't really change position, but is now considered > > to be part of the body rather than part of the headers. This means &g

Re: [RFC PATCH] emacs: make show view a/A/x/X key bindings more consistent

2012-01-31 Thread David Edmondson
On Tue, 31 Jan 2012 17:03:55 +0200, Jani Nikula wrote: > 'a' = Archive current message, then move to next message, or show next > thread from search if at the last message in thread. > > 'A' = Archive each message in thread, then show next thread from > search. > > 'x' = Archive current message,

Re: [PATCH 3/5] emacs: Allow the indentation of content to be toggled.

2012-01-31 Thread David Edmondson
On Tue, 31 Jan 2012 16:15:11 +, Mark Walters wrote: > Hi I have reviewed the patch series within the limits of my lisp > knowledge. Patch 1: is rather beyond my lisp so I won't comment on that > (and I have never tried crypto): Patches 2-5 look fine with one > bikeshed and one query for my o

Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

2012-01-31 Thread David Edmondson
On Tue, 31 Jan 2012 08:31:26 -0800, Jameson Graef Rollins wrote: > On Tue, 31 Jan 2012 08:09:08 +0000, David Edmondson wrote: > > On Mon, 30 Jan 2012 09:47:34 -0800, Jameson Graef Rollins > > wrote: > > > One thing I've noticed, which isn't actually part of

Re: [PATCH] test: make test_expect_equal_file() arguments flexible

2012-02-01 Thread David Edmondson
+1. pgpjegpgs82Ip.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-02-01 Thread David Edmondson
On Wed, 1 Feb 2012 14:50:00 +0100, Pieter Praet wrote: > Less code, same results, without sacrificing readability. I didn't check the indentation, but the sense of the changes is good. pgpbqu0XSjTHQ.pgp Description: PGP signature ___ notmuch mailing

[PATCH v5 4/6] emacs: Add a binding (t) to toggle the truncation of long lines.

2012-02-02 Thread David Edmondson
--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index a07a44a..8d318c9 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1121,6 +1121,7 @@ Refreshes the current view, observing changes

[PATCH v5 3/6] emacs: Allow the indentation of content to be toggled.

2012-02-02 Thread David Edmondson
Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH v5 2/6] emacs: Allow `notmuch-show-mode' to display only matching messages.

2012-02-02 Thread David Edmondson
The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

[PATCH v5 0/6] reworked crypto toggle, plus a few other toggles

2012-02-02 Thread David Edmondson
v5: - more real buffer local variables in patch 1. - switch truncation toggle binding to 't'. - add patch 6 to check that the search buffer still exists when trying to select it. David Edmondson (6): emacs: Rework crypto switch toggle. emacs: Allow `notmuch-show-mode'

[PATCH v5 1/6] emacs: Rework crypto switch toggle.

2012-02-02 Thread David Edmondson
Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

[PATCH v5 6/6] emacs: Check that the parent buffer is alive before using it.

2012-02-02 Thread David Edmondson
--- emacs/notmuch-show.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 1b31166..895feb5 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1671,7 +1671,7 @@ added." (interactive "P") (let ((paren

[PATCH v5 5/6] emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'.

2012-02-02 Thread David Edmondson
With an argument, record and reply the state of the buffer during `notmuch-show-refresh-view'. In this context, "state" is defined as: - the open/closed state of each message, - the current message. Traditional use of refresh with the = key does not retain the state. The recently introduced tog

[PATCH v6 0/8] reworked crypto toggle, plus a few other toggles

2012-02-02 Thread David Edmondson
v6: - add `notmuch-show-only-matching-messages' to allow a user to choose that as the default behaviour. - allow a prefix argument to `notmuch-show' to invert the default value of `notmuch-show-only-matching-messages'. David Edmondson (8): emacs: Rework crypto switch toggle.

[PATCH v6 4/8] emacs: Add a binding (t) to toggle the truncation of long lines.

2012-02-02 Thread David Edmondson
--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index a07a44a..8d318c9 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1121,6 +1121,7 @@ Refreshes the current view, observing changes

[PATCH v6 1/8] emacs: Rework crypto switch toggle.

2012-02-02 Thread David Edmondson
Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

[PATCH v6 3/8] emacs: Allow the indentation of content to be toggled.

2012-02-02 Thread David Edmondson
Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH v6 2/8] emacs: Allow `notmuch-show-mode' to display only matching messages.

2012-02-02 Thread David Edmondson
The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

[PATCH v6 6/8] emacs: Check that the parent buffer is alive before using it.

2012-02-02 Thread David Edmondson
--- emacs/notmuch-show.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 1b31166..895feb5 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1671,7 +1671,7 @@ added." (interactive "P") (let ((paren

[PATCH v6 7/8] emacs: Add `notmuch-show-only-matching-messages'.

2012-02-02 Thread David Edmondson
Allow the user to choose that only matching messages are shown by default. --- emacs/notmuch-show.el |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 895feb5..ae7af02 100644 --- a/emacs/notmuch-show.el +++ b/emacs/n

[PATCH v6 5/8] emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'.

2012-02-02 Thread David Edmondson
With an argument, record and reply the state of the buffer during `notmuch-show-refresh-view'. In this context, "state" is defined as: - the open/closed state of each message, - the current message. Traditional use of refresh with the = key does not retain the state. The recently introduced tog

[PATCH v6 8/8] emacs: A prefix argument to `notmuch-show' should invert the matching message behaviour.

2012-02-02 Thread David Edmondson
Allow the user to open a thread with inverted `notmuch-show-only-matching-messages' behaviour using a prefix argument. --- emacs/notmuch-show.el |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index ae7af02..e9aa4e7 100644

Re: [PATCH] test: make test_expect_equal_file() arguments flexible

2012-02-02 Thread David Edmondson
On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins wrote: > If this is really a problem, I vote for 1. In general, I am not in > favor of making the test suite more complicated than it needs to be. After listening to the debate, I agree. The documentation should state that the order is '

Re: BiDi

2012-02-03 Thread David Edmondson
On Tue, 24 Jan 2012 20:08:14 +, Clint Adams wrote: > I just received an email in RTL script and it was rendered incorrectly > in the emacs interface. Does anyone know what to do about this? Clint, can you provide a sample message for me to work with? pgpXjnDL87II5.pgp Description: PGP sign

Re: mutt-like interface [was: Re: BiDi]

2012-02-03 Thread David Edmondson
On Thu, 02 Feb 2012 14:39:40 -0500, James Vasile wrote: > Is anybody interested in a more mutt-like single-email view with a > threaded index? No indenting, no waiting forever for long threads to > fontify, no wading through a long thread looking for the one email you > actually want. Various p

Re: [PATCH v2] emacs: add default value to notmuch-search-line-faces

2012-02-03 Thread David Edmondson
+1. pgpST9LyTvG5L.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v4 11/11] emacs: show: recognize the exclude flag.

2012-02-03 Thread David Edmondson
On Thu, 2 Feb 2012 17:43:39 +, Mark Walters wrote: > +(when (eq (point) (point-max)) "(when (eobp)" is more usual. > + (goto-char (point-min)) > + (notmuch-show-next-matching-message)) Otherwise the Emacs patch looks good. pgpVoJXXr3AmO.pgp Description: PGP signature _

Re: [PATCH v6 1/8] emacs: Rework crypto switch toggle.

2012-02-03 Thread David Edmondson
On Thu, 2 Feb 2012 11:23:46 +, David Edmondson wrote: > Re-work the existing crypto switch toggle to be based on a persistant > buffer-local variable. > > To allow this, modify `notmuch-show-refresh-view' to erase and re-draw > in the current buffer rather than killin

Re: For gmail how do you setup notmuch mail ?...

2012-02-04 Thread David Edmondson
On Sat, 4 Feb 2012 03:39:23 -0500, don warner saklad wrote: > a) For gmail how do you setup notmuch mail ?... > > b) Any workarounds? > > c) Any kludges? notmuch wants to be able to access your mail as individual files in the filesystem. That means you need a way to get the mail from Gmail ont

Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-05 Thread David Edmondson
On Sun, 05 Feb 2012 23:07:02 -0800, Jameson Graef Rollins wrote: > Sorry to be so late on this, but I'm not a big fan of this new feature. > I would prefer to always see the subject (or any other field for that > matter) as is. The Emacs UI always replaced blank subjects with '[No Subject]' in b

Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-06 Thread David Edmondson
On Mon, 06 Feb 2012 00:06:54 -0800, Jameson Graef Rollins wrote: > On Mon, 06 Feb 2012 07:47:38 +0000, David Edmondson wrote: > > On Sun, 05 Feb 2012 23:07:02 -0800, Jameson Graef Rollins > > wrote: > > > Sorry to be so late on this, but I'm not a big fan of th

[PATCH v7 2/8] emacs: Allow `notmuch-show-mode' to display only matching messages.

2012-02-06 Thread David Edmondson
The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

[PATCH v7 4/8] emacs: Add a binding (t) to toggle the truncation of long lines.

2012-02-06 Thread David Edmondson
--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 89663ee..db9292c 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1131,6 +1131,7 @@ Refreshes the current view, observing changes

<    1   2   3   4   5   6   7   8   9   10   >