[PATCH v3 7/9] test: Update the test output to accord with the reply changes

2014-05-12 Thread David Edmondson
Replying to a message with multiple parts will now typically include content from several parts (whereas previously only the first part was used). Update the expected output from the emacs reply tests accordingly. --- test/T310-emacs.sh | 32 1 file changed, 32 ins

[PATCH v3 9/9] test: Update the test output to accord with more reply changes

2014-05-12 Thread David Edmondson
When replying to complex messages, some part headers may be shown. Update the expected test output accordingly. --- test/T310-emacs.sh | 12 1 file changed, 12 insertions(+) diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh index 95bb67e..fa15e03 100755 --- a/test/T310-emacs.sh ++

Re: [PATCH 6/7] emacs: hello: add highlight newly arrived messages option

2014-05-12 Thread David Edmondson
On Sun, May 11 2014, Mark Walters wrote: > This adds a function that highlights searches which have newly arrived > messages (ones which arrived since the previous refresh of > notmuch-hello). It does that by getting a full list of matching > message ids and checking whether any new messages have a

Re: [PATCH 2/7] emacs: hello: allow saved search display functions

2014-05-12 Thread David Edmondson
On Sun, May 11 2014, Mark Walters wrote: > Extend the saved search plist to include a :display-function property > that can customise the display of the saved search. It can change the > count string displayed and the name string. Thus the user can > customise so that a particular search: > > does

Re: [PATCH v3 1/9] emacs/show: Re-arrange determination if a part header is necessary

2014-05-13 Thread David Edmondson
On Mon, May 12 2014, Mark Walters wrote: > On Mon, 12 May 2014, David Edmondson wrote: >> Move the determination of whether a part header is required to a >> distinct function. >> --- >> emacs/notmuch-show.el | 25 ++--- >> 1 file chang

Re: [PATCH v3 2/9] emacs/show: Allow the user to decide when part headers should be inserted

2014-05-13 Thread David Edmondson
On Mon, May 12 2014, Mark Walters wrote: > On Mon, 12 May 2014, David Edmondson wrote: >> Make the function that determines whether a part header should be >> inserted a user controlled, with some example functions. >> --- >> emacs/notmuch-show.el | 21 +

Re: [PATCH v3 0/9] emacs: Improve the cited message included in replies

2014-05-13 Thread David Edmondson
Firstly, I don't think that the code resulting from this patch series is beyond improvement - the intention was really only that it be better than the current implementation. On Mon, May 12 2014, Mark Walters wrote: > On Mon, 12 May 2014, David Edmondson wrote: >> emacs: Imp

Re: [PATCH v3 4/9] emacs/mua: Generate improved cited text for replies

2014-05-13 Thread David Edmondson
On Mon, May 12 2014, Mark Walters wrote: > On Mon, 12 May 2014, David Edmondson wrote: >> Use the message display code to generate message text to cite in >> replies. > > So this is the key change. I am trying to work out what the actual > changes are here: in your com

Re: [PATCH v2] Enable Travis-CI as a backup continuous integration service.

2014-05-14 Thread David Edmondson
On Wed, May 14 2014, Wael M. Nasreddine wrote: > You can access the dashboard at https://travis-ci.org/notmuch/notmuch > --- > .travis.yml | 12 > 1 file changed, 12 insertions(+) > create mode 100644 .travis.yml > > diff --git a/.travis.yml b/.travis.yml > new file mode 100644 > ind

Re: [PATCH v2] Enable Travis-CI as a backup continuous integration service.

2014-05-16 Thread David Edmondson
On Thu, May 15 2014, Wael Nasreddine wrote: > It is fragile, but unfortunately there's no way (As far as I know) > around this problem. Travis-CI is currently running Ubuntu Precise > (12.04) and they have plans to update to Trusty[0] but it's going to take > them some time. Please forgive my igno

Re: [PATCH v2] Enable Travis-CI as a backup continuous integration service.

2014-05-16 Thread David Edmondson
On Thu, May 15 2014, W. Trevor King wrote: > On Thu, May 15, 2014 at 10:40:06AM -0700, Wael Nasreddine wrote: >> David Edmondson writes: >> > I realise that you might answer "I will keep this up to date", but >> > we have to worry about what happens if y

[PATCH v1] emacs: `notmuch-search-find-stable-query-region' should never return an empty query.

2014-05-19 Thread David Edmondson
`notmuch-search-find-stable-query-region' is expected to examine the region between `beg' and `end' to generate a query that can be used to include all threads in that region. If the region contains no threads, it should throw an error rather than generating an empty query. --- Whilst logging call

Re: [PATCH v1] emacs: `notmuch-search-find-stable-query-region' should never return an empty query.

2014-05-20 Thread David Edmondson
On Mon, May 19 2014, Mark Walters wrote: > On Mon, 19 May 2014, David Edmondson wrote: >> `notmuch-search-find-stable-query-region' is expected to examine the >> region between `beg' and `end' to generate a query that can be used to >> include all threads in th

[PATCH v1] emacs: Add `notmuch-show-toggle-citation-visibility', bound to '>'

2014-05-20 Thread David Edmondson
Add a function and key-binding to toggle the collapsing of citations within the current message. --- emacs/notmuch-show.el | 17 + 1 file changed, 17 insertions(+) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 10fc872..e4b56c7 100644 --- a/emacs/notmuch-show.el

Re: [PATCH] emacs: make sure tagging on an empty query is harmless

2014-05-21 Thread David Edmondson
On Wed, May 21 2014, Mark Walters wrote: > Currently notmuch-tag throws a "wrong-type-argument stringp nil" if > passed a nil query-string. Catch this and provide a more useful error > message. This fixes a case in notmuch-tree (if you try to tag when at > the end of the buffer). > > Secondly, as p

Re: [PATCH v1] emacs: Add `notmuch-show-toggle-citation-visibility', bound to '>'

2014-05-22 Thread David Edmondson
On Thu, May 22 2014, Mark Walters wrote: > On Tue, 20 May 2014, David Edmondson wrote: >> Add a function and key-binding to toggle the collapsing of citations >> within the current message. > > Hi > > I like the idea. It seems a little odd to want to toggle the c

Re: emacs integration

2014-05-23 Thread David Edmondson
On Thu, May 22 2014, Gauthier Östervall wrote: > I just installed notmuch and could index from the command line. > I read from the Setup section of the "emacs tips" page ( > notmuch@notmuchmail.org ) that integrating to emacs is as simple as > (require 'notmuch). > > 1. First, I had a hard time to

Re: [PATCH v3] Enable Travis-CI as a backup continuous integration service.

2014-05-23 Thread David Edmondson
Thanks for taking on board the comments. This looks much better to me. > On 23 May 2014, at 06:51 pm, "Wael M. Nasreddine" > wrote: > > You can access the dashboard at https://travis-ci.org/notmuch/notmuch > --- > .travis.yml | 19 +++ > 1 file changed, 19 insertions(+) > create

[PATCH v1] emacs: Forwarded messages should not have modified buffers

2014-06-02 Thread David Edmondson
When the user begins forwarding a message, the resulting composition buffer should not be marked as modified, in order that it can immediately be killed without prompting. --- emacs/notmuch-mua.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch-mua.el b/emacs/no

Re: Deduplication ?

2014-06-02 Thread David Edmondson
On Mon, Jun 02 2014, Vladimir Marek wrote: > Hi, > > I want to import bigger chunk of archived messages into my notmuch > database. It's about 100k messages. The problem is, that I most probably > have quite a lot of those messages in the DB. Basically I would like to > add only those I don't have

Re: Deduplication ?

2014-06-02 Thread David Edmondson
On Mon, Jun 02 2014, Jani Nikula wrote: >>> One should also have some message content heuristics to determine that the >>> content is indeed duplicate and not something totally different (not that >>> we can see the different content anyway... but...) >> >> That would be nice. > > And quite hard.

[PATCH v1] emacs: Forwarded messages should not have modified buffers

2014-06-15 Thread David Edmondson
When the user begins forwarding a message, the resulting composition buffer should not be marked as modified, in order that it can immediately be killed without prompting. --- emacs/notmuch-mua.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch-mua.el b/emacs/notm

Re: [PATCH v1] emacs: Forwarded messages should not have modified buffers

2014-06-23 Thread David Edmondson
On 22 Jun 2014, at 11:44, David Bremner wrote: > Bah. Sometimes mail systems suck. I finally managed to apply this after > some effort. For future reference, it was still quoted printable and > (even more mysteriously) something mangled the indentation of the > context lines, moving them one spac

[PATCH v1 2/3] emacs: Add `notmuch-user-all-email'.

2014-09-05 Thread David Edmondson
`notmuch-user-all-email' returns a list of the user's primary and secondary email addresses. --- emacs/notmuch-lib.el | 4 1 file changed, 4 insertions(+) diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index 19269e3..685469c 100644 --- a/emacs/notmuch-lib.el +++ b/emacs/notmuch-lib

[PATCH v1 3/3] emacs: Add an address completer in elisp.

2014-09-05 Thread David Edmondson
Rather than relying on an external comment to provide address completion in composition mode, provide a solution purely in elisp. Update `notmuch-address-command' to allow it to specify an external command or a function, with the default remaining as an external command called "notmuch-addresses".

[PATCH v1 0/3] Address completion entirely in elisp.

2014-09-05 Thread David Edmondson
ich I was previously using) entirely in elisp, relying only on the `notmuch' command. David Edmondson (3): emacs: Allow query to exclude the entire thread and body. emacs: Add `notmuch-user-all-email'. emacs: Add an address completer in elisp. emacs/notmuch-

[PATCH v1 1/3] emacs: Allow query to exclude the entire thread and body.

2014-09-05 Thread David Edmondson
Callers to `notmuch-query-get-threads' can optionally choose not to receive either the entire thread and/or the body of messages. This is intended to reduce the amount of output in cases where one or both of these items is not useful. --- emacs/notmuch-query.el | 7 ++- 1 file changed, 6 inse

Re: [PATCH v1 0/3] Address completion entirely in elisp.

2014-09-05 Thread David Edmondson
On Fri, Sep 05 2014, Mark Walters wrote: > On Fri, 05 Sep 2014, David Edmondson wrote: >> Address completion entirely in elisp. >> >> I grew frustrated with having to use an external command to provide >> address completion, as they all had annoyances (up front sc

Re: [PATCH v3] Emacs: Add address completion mechanism implemented in elisp

2014-09-07 Thread David Edmondson
(filter-out > $(emacs_no_byte_compile),$(emacs_sources))) > > # Because of defmacro's and defsubst's, we have to account for load > # dependencies between Elisp files when byte compiling. Otherwise, > diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el &

Re: [Patch v2 0/2] emacs: show: mark messages read if seen in buffer

2014-09-08 Thread David Edmondson
I like the general approach. On Sat, Sep 06 2014, Mark Walters wrote: > There are two changes from v1. First patch 1 is new. Secondly I have > modified the defcustom for the second patch. It is slightly fiddly as > my function has a parameter the default function does not. The > defcustom in the p

Re: [PATCH v3] Emacs: Add address completion mechanism implemented in elisp

2014-09-08 Thread David Edmondson
On Mon, Sep 08 2014, Michal Sojka wrote: > On Mon, Sep 08 2014, David Edmondson wrote: >> On Mon, Aug 11 2014, Michal Sojka wrote: >>> Currently, notmuch has an address completion mechanism that requires >>> external command to provide completion candidates. This

Re: multiple machine tagging

2014-09-15 Thread David Edmondson
On Thu, May 20 2010, David Edmondson wrote: (Wow, was it really more than four years ago?) > What's the current state of the art in merging tags from multiple > machines? > > In my own case the contents of the mail store can be considered > identical on the different machine

Re: multiple machine tagging

2014-09-15 Thread David Edmondson
On Mon, Sep 15 2014, W. Trevor King wrote: > On Mon, Sep 15, 2014 at 02:49:16PM +0100, David Edmondson wrote: >> On Thu, May 20 2010, David Edmondson wrote: >> (Wow, was it really more than four years ago?) >> >> > What's the current state of the art in mergi

Re: [PATCH 4/4] nmbug: Add an 'init' command

2014-09-15 Thread David Edmondson
On Sun, Jul 06 2014, W. Trevor King wrote: > For folks that want to start versioning a new tag-space, instead of > cloning one that someone else has already started. I tried this patch, and it (appeared) to work for me. Given that the procedure for creating a new tag repository is arcane, could th

Re: [PATCH 4/4] nmbug: Add an 'init' command

2014-09-15 Thread David Edmondson
On Mon, Sep 15 2014, W. Trevor King wrote: > On Mon, Sep 15, 2014 at 05:13:50PM +0100, David Edmondson wrote: >> On Sun, Jul 06 2014, W. Trevor King wrote: >> > For folks that want to start versioning a new tag-space, instead >> > of cloning one that someone else ha

RFC: notmuch-cache.el: simple caching of MIME parts

2014-10-07 Thread David Edmondson
I've been using remote-notmuch over a 3G connection quite a lot recently. Dragging down the same MIME part more than once is annoying, so here is a very simple filesystem based cache of MIME parts for notmuch. It's integrated using defadvice for now, but a cleaner approach is obviously possible. N

Re: RFC: notmuch-cache.el: simple caching of MIME parts

2014-10-07 Thread David Edmondson
On Tue, Oct 07 2014, David Edmondson wrote: > I've been using remote-notmuch over a 3G connection quite a lot > recently. Dragging down the same MIME part more than once is annoying, > so here is a very simple filesystem based cache of MIME parts for > notmuch. It's integrat

[RFC][PATCH v1] emacs: Improve the behaviour of the 'q' binding.

2014-10-16 Thread David Edmondson
When a user hits 'q' in a notmuch buffer, kill the buffer only if there are no other windows currently showing it. --- This arose from a discussion in #notmuch. Please try it and see if you like the new behaviour. emacs/notmuch-lib.el | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

[PATCH v1] emacs: notmuch-jump.el should provide.

2014-10-21 Thread David Edmondson
To ease loading, notmuch-jump.el should provide 'notmuch-jump. --- emacs/notmuch-jump.el | 4 1 file changed, 4 insertions(+) diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el index 05ec57e..20e24b2 100644 --- a/emacs/notmuch-jump.el +++ b/emacs/notmuch-jump.el @@ -170,3 +170,7 @@ b

[PATCH v1 1/3] search: Seperately report matching and non-matching authors.

2014-10-24 Thread David Edmondson
In addition to the :authors attribute of each search result, include :authors_matched and :authors_non_matched attributes. Both attributes are always included. If there are no non-matching authors, the :authors_non_matched attribute is set to the empty string. --- lib/notmuch.h| 34 +++

[PATCH v1 0/3] Improve the display of matching/non-matching authors.

2014-10-24 Thread David Edmondson
is parsing incorrectly determines the matching and non-matching authors. Address this by adding explicit matching and non-matching authors attributes to the structured output formats. David Edmondson (3): search: Seperately report matching and non-matching authors. emacs: Improved display of ma

[PATCH v1 2/3] emacs: Improved display of matching/non-matching authors.

2014-10-24 Thread David Edmondson
Rather than splitting the :authors attribute, which is error prone, use the separate :authors_matched and :authors_non_matched attributes. This improves the display of authors should one of them include a pipe symbol (|) in their 'from' address. --- emacs/notmuch.el | 64 +

Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients}

2014-10-24 Thread David Edmondson
On Thu, Oct 23 2014, Mark Walters wrote: > Thinking about this some more how about printing the name and address as > a structured pair/map (at least for all cases except text/text0 output): > something like (in JSON) > [name: "John Doe" address: "john@example.com"] > > It seems wrong to me to

Re: [PATCH v1 1/3] search: Seperately report matching and non-matching authors.

2014-10-24 Thread David Edmondson
On Fri, Oct 24 2014, Mark Walters wrote: > What about having both authors_matched and authors_not_matched as lists > of authors (ie one string for each author)? That's a sensible idea. I will look into it. > Then emacs, for example, wouldn't try and parse the string back into > authors before spl

Re: [O] how to put into a journal info about the email sent

2014-10-24 Thread David Edmondson
On Fri, Oct 24 2014, Eric Abrahamsen wrote: > David Belohrad writes: > >> Dear All, >> >> i'm using org. And I'm using notmuch (that's why I address both mailing >> lists). Now, writing an email in everyday bussiness requires a >> non-significant time of your workhours. So I'd like to have this ev

[PATCH v2 1/3] search: Separately report matching and non-matching authors.

2014-10-24 Thread David Edmondson
In addition to the 'authors' attribute of each search result, include 'authors_matched' and 'authors_non_matched' attributes. Both attributes are always included and are formatted as a list of authors. If there are no matching authors, the 'authors_non_matched' attribute is set to the empty list. -

[PATCH v2 0/3] Improve the display of matching/non-matching authors.

2014-10-24 Thread David Edmondson
e possible (to improve the chosen break between visible and invisible), but a planned re-write of the `notmuch-search-result-format' code would render that irrelevant. David Edmondson (3): search: Separately report matching and non-matching authors. emacs: Improved display of matchi

[PATCH v2 3/3] test: Update tests for 'authors_matched' and authors_non_matched'.

2014-10-24 Thread David Edmondson
--- test/T160-json.sh| 9 + test/T170-sexp.sh| 4 ++-- test/T470-missing-headers.sh | 8 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/test/T160-json.sh b/test/T160-json.sh index c1cf649..0a8df18 100755 --- a/test/T160-json.sh +++ b/test/T

[PATCH v2 2/3] emacs: Improved display of matching/non-matching authors.

2014-10-24 Thread David Edmondson
Rather than splitting the :authors attribute, which is error prone, use the separate :authors_matched and :authors_non_matched attributes. This improves the display of authors should one of them include a pipe symbol (|) in their 'from' address. --- emacs/notmuch.el | 64 +

Re: [PATCH] cli: cast timeval fields to long for format

2014-10-28 Thread David Edmondson
On Tue, Oct 28 2014, Jani Nikula wrote: > This hides platform differences between struct timeval field types. Good for me. Tested on Debian Testing and OS X 10.10 (which previously emitted a compiler warning). > --- > notmuch-insert.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [O] how to put into a journal info about the email sent

2014-10-29 Thread David Edmondson
On Wed, Oct 29 2014, David Belohrad wrote: > - 'standard' behaviour is, that the email sent becomes read-only so with > 'q' keystroke I can bury the buffer with the email. However when I > have implemented this, I have noticed that when I 'confirm' the > template, I go back into the buffer 's

[PATCH v2] emacs: Improve the behaviour of the 'q' binding.

2014-10-29 Thread David Edmondson
When a user hits 'q' in a notmuch buffer, kill the buffer only if there are no other windows currently showing it. --- emacs/notmuch-lib.el | 13 + emacs/notmuch-show.el | 2 +- emacs/notmuch-tree.el | 2 +- emacs/notmuch.el | 4 ++-- 4 files changed, 13 insertions(+), 8 delet

[PATCH v2] emacs: Improve the behaviour of the 'q' binding.

2014-10-29 Thread David Edmondson
emacs: Improve the behaviour of the 'q' binding. When a user hits 'q' in a notmuch buffer, kill the buffer only if there are no other windows currently showing it. v2: - Change the name of `notmuch-kill-this-buffer' to be clearer. David Edmondson (1): emacs: Improv

"search --duplicate=2 --output=messages" is deranged

2014-10-29 Thread David Edmondson
Consider: : disaster-area; notmuch search --output=files id:87hbph5yww@aw.hh.sledj.net /home/dme/Maildir/mail/list/notmuch/xx01550 : disaster-area; notmuch search --duplicate=2 --output=files id:87hbph5yww@aw.hh.sledj.net : disaster-area; notmuch search --duplicate=2 --output=messages id

"search --path=directory/" is lame(-ish)

2014-10-29 Thread David Edmondson
Adding a terminal slash to a directory name when using --path causes the search to fail. Removing the terminal slash produces results. Given that many shells will add the terminal slash during completion, this is lame(-ish). ___ notmuch mailing list notm

Re: [PATCH] cli: notmuch search --duplicate=N is only supported with --output=files

2014-10-30 Thread David Edmondson
This works, in so much as it doesn't allow the deranged behaviour. Consequentially, --duplicate seems a bit useless. Unless I feed it a single id: as an argument (in which case I could use --output=files), I have to figure out which of the files output are duplicates of each other and which are fr

Re: "search --path=directory/" is lame(-ish)

2014-10-30 Thread David Edmondson
On Wed, Oct 29 2014, Jani Nikula wrote: > On Wed, 29 Oct 2014, David Edmondson wrote: >> Adding a terminal slash to a directory name when using --path causes the >> search to fail. Removing the terminal slash produces results. > > I think you mean path:, not --path. Yes,

Re: [PATCH] emacs: add stash support for git send-email command line

2014-10-30 Thread David Edmondson
On Wed, Oct 29 2014, Jani Nikula wrote: >>> +(defun notmuch-show-stash-git-send-email () >>> + "Copy From/To/Cc/Message-Id of current message to kill-ring in a form >>> suitable for pasting to git send-email command line." >>> + (interactive) >>> + (notmuch-common-do-stash >>> + (concat >>> +

[PATCH v1] emacs: Improved header display.

2014-10-30 Thread David Edmondson
Truncate the displayed headers to the window width. Show an ellipsis if the displayed header is truncated. Add a binding 'T' to toggle the truncation of headers. Add the not-displayed section of the header as a tooltip to the displayed section. --- emacs/notmuch-show.el | 54 ++

Re: [PATCH v1] emacs: Improved header display.

2014-10-31 Thread David Edmondson
On Thu, Oct 30 2014, Jani Nikula wrote: > On Thu, 30 Oct 2014, David Edmondson wrote: >> Truncate the displayed headers to the window width. Show an ellipsis >> if the displayed header is truncated. Add a binding 'T' to toggle the >> truncation of headers. Add t

Re: [PATCH] cli: add support for notmuch search --duplicate=N with --output=messages

2014-10-31 Thread David Edmondson
On Thu, Oct 30 2014, Jani Nikula wrote: > Print the message IDs of all messages matching the search terms that > have at least N files associated with them. Briefly tested as working. I commend this patch to the masters of push. Thanks Jani! > --- > doc/man1/notmuch-search.rst | 12

[PATCH v1 0/2] emacs: Improve notmuch-wash customisation.

2014-10-31 Thread David Edmondson
emacs: Improve notmuch-wash customisation. Minor updates to the customisation of notmuch-wash features. David Edmondson (2): emacs: More flexible washed faces. emacs: Washing should use more `defcustom'. emacs/notmuch-wash.el | 109 +++-

[PATCH v1 1/2] emacs: More flexible washed faces.

2014-10-31 Thread David Edmondson
The faces used when washing messages should be notmuch specific and inherit from the underlying emacs face rather than using it directly. This allows the washed face to be modified without requiring the modification of the underlying face. --- emacs/notmuch-wash.el | 21 +++-- 1 fi

[PATCH v1 2/2] emacs: Washing should use more `defcustom'.

2014-10-31 Thread David Edmondson
More of the washing variables should be available through the standard customisation interface. --- emacs/notmuch-wash.el | 88 +-- 1 file changed, 57 insertions(+), 31 deletions(-) diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el index 18

[RFC] [PATCH v1] emacs: More citation washing.

2014-10-31 Thread David Edmondson
Ensure that a citation is preceded and followed by a blank line, unless the preceding line looks like a citation leader. --- Washing changes are always a bit risky, as they are heuristic based. Testers for this (alleged) improvement welcome! emacs/notmuch-wash.el | 14 +- 1 file chan

[PATCH v1] NEWS: Improved `q` binding.

2014-10-31 Thread David Edmondson
--- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index 4718838..723bca0 100644 --- a/NEWS +++ b/NEWS @@ -16,6 +16,12 @@ Expanded default saved search settings The default saved searches now include several more common searches, as well as shortcut keys for `notm

Re: [Vagrant Cascadian] Bug#759646: notmuch-emacs: switching mode= to invalid value sends unencrypted mail

2014-11-12 Thread David Edmondson
On Tue, Sep 02 2014, Tomi Ollila wrote: > On Tue, Sep 02 2014, Daniel Kahn Gillmor wrote: > >> On 08/30/2014 03:37 AM, Jani Nikula wrote: >>> I'm inclined to think this is a bug in message-mode. >> >> I agree it's a bug in message-mode, not in notmuch itself. > > I think it might be here: > > htt

Re: Forwarding a mail, with a non-ASCII signature

2014-11-17 Thread David Edmondson
On Sun, Nov 16 2014, Lele Gaifax wrote: > Hi all, > > as you can see below, my signature contains some non-ASCII characters, > and it is stored as UTF-8 (I have `(prefer-coding-system 'utf-8)` in my > .emacs.el) in my home as ~/.signature. > > Recently I started using notmuch with Emacs as the main

Re: Forwarding a mail, with a non-ASCII signature

2014-11-17 Thread David Edmondson
On Sun, Nov 16 2014, Lele Gaifax wrote: > Hi all, > > as you can see below, my signature contains some non-ASCII characters, > and it is stored as UTF-8 (I have `(prefer-coding-system 'utf-8)` in my > .emacs.el) in my home as ~/.signature. > > Recently I started using notmuch with Emacs as the main

Re: Forwarding a mail, with a non-ASCII signature

2014-11-17 Thread David Edmondson
On Mon, Nov 17 2014, Lele Gaifax wrote: >> Could you try this patch please? >> >> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el >> index 6e03f1e..1592ca9 100644 >> --- a/emacs/notmuch-show.el >> +++ b/emacs/notmuch-show.el >> @@ -235,9 +235,9 @@ For example, if you wanted to remove an

[PATCH v1] emacs: `with-current-notmuch-show-message' should not leak `coding-system-for-read'

2014-11-17 Thread David Edmondson
`with-current-notmuch-show-message' applies a `no-conversion' coding system when reading a raw message from notmuch. That coding system should _not_ be applied when the body of the macro is evaluated, as it can cause file operations used during that evaluation to incorrectly apply the `no-conversio

Re: Forwarding a mail, with a non-ASCII signature

2014-11-17 Thread David Edmondson
On Mon, Nov 17 2014, David Edmondson wrote: >> >> Yes! This works great, with it the forward buffer contains the signature >> loaded with the correct encoding, and the sendmail succeeds without >> prompting about unreadable chars. > > That's good, thanks for

Re: [RFC][PATCH v1] emacs: Replace `notmuch-search-result-format' evaluation.

2014-11-25 Thread David Edmondson
On Tue, Nov 25 2014, David Bremner wrote: >> +A symbol corresponding to an attribute of the >> + thread (e.g. `:date_relative' or `:subject'). > > It'd be nice for the user to have a pointer here to figure out what > the possible attributes are. I don't believe that we currently document these any

[RFC][PATCH v2] emacs: Replace `notmuch-search-result-format' evaluation.

2014-11-25 Thread David Edmondson
Alternative implementation of code that interprets `notmuch-search-result-format' to insert the results of a search. --- Added some more documentation, as per bremner. emacs/notmuch.el | 300 +-- 1 file changed, 178 insertions(+), 122 deletions

Re: [PATCH] emacs: Added "is:" style completion to notmuch-read-query.

2014-11-28 Thread David Edmondson
On Sat, Nov 29 2014, Charles Celerier wrote: > The notmuch-search-terms man page states that "tag:" is equivalent > to "is:". Completion for "is:" style searches is now supported > in the Emacs interface. > > Signed-off-by: Charles Celerier > --- > emacs/notmuch.el | 8 +--- > 1 file changed,

Re: [PATCH v2] emacs: Added "is:" style completion to notmuch-read-query.

2014-11-30 Thread David Edmondson
On Sat, Nov 29 2014, Charles Celerier wrote: > The notmuch-search-terms man page states that "tag:" is equivalent > to "is:". Completion for "is:" style searches is now supported > in the Emacs interface. > > Signed-off-by: Charles Celerier > --- > emacs/notmuch.el | 11 +++ > 1 file chan

Re: [Vagrant Cascadian] Bug#759646: notmuch-emacs: switching mode= to invalid value sends unencrypted mail

2014-11-30 Thread David Edmondson
On Sat, Nov 29 2014, David Bremner wrote: > David Edmondson writes: > >> On Tue, Sep 02 2014, Tomi Ollila wrote: >>> On Tue, Sep 02 2014, Daniel Kahn Gillmor wrote: >>> >>>> On 08/30/2014 03:37 AM, Jani Nikula wrote: >>>>> I'm incli

Re: [Vagrant Cascadian] Bug#759646: notmuch-emacs: switching mode= to invalid value sends unencrypted mail

2014-11-30 Thread David Edmondson
On Mon, Dec 01 2014, David Bremner wrote: > David Edmondson writes: > >>> I'm a little torn what to do here. On the one hand the upstream change >>> fixes the bug as reported. On the other hand, if something corrupts the >>> #secure tag (e.g., by deleting a l

Re: Address completion in Emacs

2014-12-12 Thread David Edmondson
On Fri, Dec 12 2014, Lele Gaifax wrote: > Hi all, > > Yesterday I tweaked my Emacs configuration to use "ido-completing-read" > to select the right address in the minibuffer, and noticed what seems a > glitch in the related code. > > To accomplish the goal, I implemented my own selection function >

Re: Address completion in Emacs

2014-12-12 Thread David Edmondson
On Fri, Dec 12 2014, Lele Gaifax wrote: > David Edmondson writes: > >> On Fri, Dec 12 2014, Lele Gaifax wrote: >>> Wouldn't it be more "correct" to pass the unchanged `options' list and >>> the "real" `orig' text as `initial-input&#

columnar faces in search results

2014-12-16 Thread David Edmondson
Does anyone modify any of the following faces to control the display of search results? notmuch-search-date notmuch-search-count notmuch-search-subject notmuch-search-matching-authors notmuch-search-non-matching-authors (i.e. to get something like http://no

Re: [PATCH v2] emacs: add stash support for git send-email command line

2015-01-01 Thread David Edmondson
On Thu, Jan 01 2015, Jani Nikula wrote: > Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as > --in-reply-to, suitable for pasting to git send-email command line. > --- > emacs/notmuch-show.el | 38 ++ > 1 file changed, 38 insertions(+) > > diff

Re: [PATCH v3] emacs: add stash support for git send-email command line

2015-01-02 Thread David Edmondson
Looks good to me. On Fri, Jan 02 2015, Jani Nikula wrote: > Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as > --in-reply-to, suitable for pasting to git send-email command line. > --- > emacs/notmuch-show.el | 38 ++ > 1 file changed, 38 ins

Re: [PATCH v2 1/3] search: Separately report matching and non-matching authors.

2015-01-19 Thread David Edmondson
On Sun, Jan 18 2015, Mark Walters wrote: > On Fri, 24 Oct 2014, David Edmondson wrote: >> In addition to the 'authors' attribute of each search result, include >> 'authors_matched' and 'authors_non_matched' attributes. Both >> attributes

Re: [PATCH v2 2/3] emacs: Improved display of matching/non-matching authors.

2015-01-19 Thread David Edmondson
On Sun, Jan 18 2015, Mark Walters wrote: > On Fri, 24 Oct 2014, David Edmondson wrote: >> Rather than splitting the :authors attribute, which is error prone, >> use the separate :authors_matched and :authors_non_matched attributes. >> >> This improves the display of

Re: [PATCH] emacs: convert notmuch-address-harvester to use notmuch-address

2015-01-19 Thread David Edmondson
On Sat, Jan 17 2015, David Bremner wrote: > No attempt is made to optimize anything here, just drop in the > new command. > --- > In a few subjective tests, this seems quite a bit faster than > the version based on notmuch-show The changes look fine to me. > emacs/notmuch-address.el | 4 ++-- > 1

Re: [PATCH v3 8/9] emacs/mua: Insert part headers depending on the message

2015-01-20 Thread David Edmondson
On Mon, Jan 19 2015, Mark Walters wrote: > On Mon, 12 May 2014, David Edmondson wrote: >> Whether to insert part headers should depend on the details of the >> message being cited. > > Hi > > Overall I like this series and it does fix two annoying bugs (not bein

Re: [PATCH] emacs: show: allow user to hide some mime types by default.

2015-01-22 Thread David Edmondson
On Thu, Jan 22 2015, Mark Walters wrote: > This commit adds a customize variable that allows the user to choose > to hide some mime types by default. They can still choose to view the > part by toggling the part button. > > One use is for hiding all text/html parts. This would mean that some > expl

Re: [PATCH] Add a defcustom for whether to block remote images by default.

2015-01-28 Thread David Edmondson
A defcustom for `notmuch-show-text/html-blocked-images', which is used to set `shr-blocked-images', would be more usable. It can default to "." to achieve the same result. On Thu, Jan 29 2015, Jinwoo Lee wrote: > --- > emacs/notmuch-show.el | 15 +++ > 1 file changed, 11 insertions(+)

Re: privacy problem: text/html parts pull in network resources

2015-01-30 Thread David Edmondson
On Thu, Jan 29 2015, Daniel Kahn Gillmor wrote: > On Wed 2015-01-28 18:57:25 -0500, Jinwoo Lee wrote: >> Do you mind if I add a boolean defcustom, which determines whether to >> block remote images? Its default value will be T (block), but people >> who want to see remote images can customize it.

Re: [PATCH] emacs: Add a defcustom that specifies regexp for blocked remote images.

2015-02-01 Thread David Edmondson
On Thu, Jan 29 2015, Jinwoo Lee wrote: > It's default value is ".", meaning all remote images will be blocked > by default. > > --- > This time setting gnus-blocked-images from the correct place. Looks good - it is better than the code currently in the repository, even if it doesn’t address every

Re: bug report: Emacs notmuch-mode fails attachments with spaces

2015-02-10 Thread David Edmondson
On Tue, Feb 10 2015, Nils Dagsson Moskopp wrote: > Tomi Ollila writes: > >> On Mon, Feb 09 2015, Nils Dagsson Moskopp >> wrote: >> >>> Dear notmuch developers, >>> >>> >>> I use notmuch-mode for GNU Emacs for managing my email. >>> >>> I think I have found a bug in notmuch-mode: If I do “.-v” on

using the fringe to indicate good signatures

2015-08-20 Thread David Edmondson
After listening to bremner, dkg et al. from Heidelberg, I threw together a quick patch to see how we might indicate signature validity in the fringe. The intention is to prompt more discussion - this code is not ready to ship. The patch is attached. The result looks something like: http://dme.

Re: how to make return follow hyperlink?

2015-08-27 Thread David Edmondson
On Wed, Aug 26 2015, Peter Salazar wrote: > How do I make it so that hitting RET on a hyperlink follows it? Is there a > setting analogous to org-return-follows-link? I often have links in > incoming emails, and I'd like to be able to open them in my browser with > one keystroke. Having that bind

Re: using the fringe to indicate good signatures

2015-09-07 Thread David Edmondson
On Mon, Sep 07 2015, Daniel Kahn Gillmor wrote: > On Thu 2015-08-20 09:12:26 -0400, David Edmondson wrote: >> After listening to bremner, dkg et al. from Heidelberg, I threw together >> a quick patch to see how we might indicate signature validity in the >> fringe. The intent

Re: using the fringe to indicate good signatures

2015-09-08 Thread David Edmondson
On Tue, Sep 08 2015, Daniel Kahn Gillmor wrote: >> More seriously, we could use the indentation space for a similar >> indicator, which would allow us some room at an appropriate depth for >> each message (but not each part (in the default configuration)). > > hm, but couldn't the indentation spac

Re: file-error "not a regular file"

2015-12-29 Thread David Edmondson
On Tue, Dec 29 2015, Peter Salazar wrote: > send-message-without-bullets simply turns off org-bullets-mode before doing > message-send, since org-bullets-mode seemed to be interfering with > org-mime-htmlize. > > (defun send-message-without-bullets () > (interactive) > (remove-hook 'org-mode-h

[RFC][PATCH v1] Allow content preference based on message content.

2016-01-15 Thread David Edmondson
ntouch.co.uk, in which case discourage text/plain (which for this sender is always another copy of the HTML content, as HTML). David Edmondson (1): emacs: Allow part preferences to depend on message content. emacs/notmuch-lib.el | 39 +++ emacs/notmuch-mua.el

[PATCH v1] emacs: Allow part preferences to depend on message content.

2016-01-15 Thread David Edmondson
Currently the preference for which sub-part of a multipart/alternative part is shown is global. Allow to the user to override the settings on a per-message basis by providing two new options: - the ability to call a function that has access to the message to return the discouraged type list,

Re: [PATCH v1] emacs: Allow part preferences to depend on message content.

2016-01-19 Thread David Edmondson
On Tue, Jan 19 2016, Aaron Ecay wrote: > This code is not compatible with lexical binding in emacs >= 24, which I > assume notmuch will eventually want to adopt. What’s so bad about > writing a function? I would be fine with that - I was just exploring alternatives. __

<    1   2   3   4   5   6   7   8   9   10   >