[PATCH v9 0/2] emacs: User-defined sections in notmuch-hello

Hi all. I have finished reviewing the user-defined sections v8 series at last. I found only few minor issues, some of which are fixed by this v9 series and others can be fixed later or ignored (e.g. renaming notmuch-hello-insert-* functions to notmuch-hello-section-* or something more

[PATCH v10 0/2] emacs: User-defined sections in notmuch-hello

Found a small bug... Changes: v10: * explicitly return nil from `notmuch-hello-insert-recent-searches', otherwise `indent-rigidly' returns a marker pointing to non-existing buffer and breaks final-target-pos handling in `notmuch-hello' v9: * correctly merge

[PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

From: Daniel Schoepe daniel.scho...@googlemail.com This patch makes the notmuch-hello screen fully customizable by allowing the user to add and remove arbitrary sections. It also provides some convenience functions for constructing sections, e.g. showing the unread message count for each tag.

[PATCH v10 2/2] emacs: Tests for user-defined sections

From: Daniel Schoepe daniel.scho...@googlemail.com A new file was added for notmuch-hello tests. --- test/emacs-hello | 47 test/emacs.expected-output/notmuch-hello |3 +- .../notmuch-hello-new-section |

[PATCH v2] emacs: Fix display of highlighted line in notmuch-search

On Thu, 16 Feb 2012 00:18:31 +0100, Michal Sojka wrote: > On Wed, 15 Feb 2012, Dmitry Kurochkin wrote: > > Hi Michal. > > > > On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka > os.inf.tu-dresden.de> wrote: > > > When notmuch-search-line-faces is us

[PATCH v9 0/2] emacs: User-defined sections in notmuch-hello

Hi all. I have finished reviewing the user-defined sections v8 series at last. I found only few minor issues, some of which are fixed by this v9 series and others can be fixed later or ignored (e.g. renaming notmuch-hello-insert-* functions to notmuch-hello-section-* or something more

[PATCH v9 1/2] emacs: User-defined sections in notmuch-hello

From: Daniel Schoepe daniel.scho...@googlemail.com This patch makes the notmuch-hello screen fully customizable by allowing the user to add and remove arbitrary sections. It also provides some convenience functions for constructing sections, e.g. showing the unread message count for each tag.

[PATCH v9 2/2] emacs: Tests for user-defined sections

From: Daniel Schoepe daniel.scho...@googlemail.com A new file was added for notmuch-hello tests. --- test/emacs-hello | 47 test/emacs.expected-output/notmuch-hello |3 +- .../notmuch-hello-new-section |

[PATCH v2] emacs: Fix display of highlighted line in notmuch-search

Hi Michal. On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka wrote: > When notmuch-search-line-faces is used to set background color in search > results, the highlight of the current line is not always displayed > correctly. This patch fixes that by increasing the priority property of > the

[PATCH 1/2] test: remove "Generate some messages" test from raw

Hi all. Are there any objections to these changes? Otherwise, I would ask David to push it as "minor, boring and trivial" changes. Regards, Dmitry

[PATCH] emacs: Add the option of counting threads in notmuch-hello

Hello. Can we delay this patch until user-defined sections are pushed? I know I promised to review it long ago. But I still did not manage to finish it yet. I hope I can do it in the beginning of the next week. Regards, Dmitry

Re: [PATCH] emacs: Add the option of counting threads in notmuch-hello

Hello. Can we delay this patch until user-defined sections are pushed? I know I promised to review it long ago. But I still did not manage to finish it yet. I hope I can do it in the beginning of the next week. Regards, Dmitry ___ notmuch mailing

Re: [PATCH 1/2] test: remove Generate some messages test from raw

Hi all. Are there any objections to these changes? Otherwise, I would ask David to push it as minor, boring and trivial changes. Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2] emacs: Fix display of highlighted line in notmuch-search

Hi Michal. On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka so...@os.inf.tu-dresden.de wrote: When notmuch-search-line-faces is used to set background color in search results, the highlight of the current line is not always displayed correctly. This patch fixes that by increasing the priority

Re: [PATCH v2] emacs: Fix display of highlighted line in notmuch-search

On Thu, 16 Feb 2012 00:18:31 +0100, Michal Sojka so...@os.inf.tu-dresden.de wrote: On Wed, 15 Feb 2012, Dmitry Kurochkin wrote: Hi Michal. On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka so...@os.inf.tu-dresden.de wrote: When notmuch-search-line-faces is used to set background

[PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

On Mon, 13 Feb 2012 10:29:26 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Feb 13 at 3:09 pm: > > The notmuch-show view refresh function (`notmuch-show-refresh-view', > > bound to "=") accepts an optional RETAIN-STATE argument. The patch > > allows to

[PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

The notmuch-show view refresh function (`notmuch-show-refresh-view', bound to "=") accepts an optional RETAIN-STATE argument. The patch allows to set this argument interactively by using "C-u =". --- emacs/notmuch-show.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility

Hi Pieter. On Wed, 25 Jan 2012 06:25:39 +0100, Pieter Praet wrote: > * emacs/notmuch-show.el (notmuch-show-open-or-close-all): > Rename to `notmuch-show-toggle-all-messages', and make it toggle > visibility of all messages based on the visibility of the current > message, instead of

Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility

Hi Pieter. On Wed, 25 Jan 2012 06:25:39 +0100, Pieter Praet pie...@praet.org wrote: * emacs/notmuch-show.el (notmuch-show-open-or-close-all): Rename to `notmuch-show-toggle-all-messages', and make it toggle visibility of all messages based on the visibility of the current message,

Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

On Mon, 13 Feb 2012 10:29:26 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Feb 13 at 3:09 pm: The notmuch-show view refresh function (`notmuch-show-refresh-view', bound to =) accepts an optional RETAIN-STATE argument. The patch allows to set this argument

[PATCH v4 2/4] reply: Add a JSON reply format.

Hi Adam. On Thu, 9 Feb 2012 21:27:29 -0700, Adam Wolfe Gordon <awg+notmuch at xvx.ca> wrote: > Hi Dmitry, > > On Thu, Feb 9, 2012 at 00:22, Dmitry Kurochkin > wrote: > >> Reply now enforces that only one message is returned, as the semantics > >> of reply

Re: [PATCH v4 2/4] reply: Add a JSON reply format.

Hi Adam. On Thu, 9 Feb 2012 21:27:29 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: Hi Dmitry, On Thu, Feb 9, 2012 at 00:22, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Reply now enforces that only one message is returned, as the semantics of replying to multiple messages

[PATCH v4 2/4] reply: Add a JSON reply format.

Hi Adam. On Wed, 8 Feb 2012 17:21:54 -0700, Adam Wolfe Gordon wrote: > This new JSON format for replies includes headers generated for a > reply message as well as the headers of the original message. Using > this data, a client can intelligently create a reply. For

[PATCH v4] emacs: Call "notmuch tag" once when applying tag changes to a thread.

On Wed, 8 Feb 2012 16:43:15 +, David Edmondson wrote: > Optimize thread tagging by combining all the tagging operations to a > single "notmuch tag" call. > > For threads in the order of tens or a hundred inbox tagged messages, > this gives a noticeable speedup. On two different machines,

[PATCH] emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions

Recent changes in notmuch-show tagging introduced some code duplication. The patch cleanups and simplifies `notmuch-show-archive-thread' function by using `notmuch-show-tag-all', no longer used function are removed. After the change, `notmuch-show-archive-thread' function becomes symmetric with

Re: [PATCH v4] emacs: Call notmuch tag once when applying tag changes to a thread.

On Wed, 8 Feb 2012 16:43:15 +, David Edmondson d...@dme.org wrote: Optimize thread tagging by combining all the tagging operations to a single notmuch tag call. For threads in the order of tens or a hundred inbox tagged messages, this gives a noticeable speedup. On two different

Re: [PATCH v4 2/4] reply: Add a JSON reply format.

Hi Adam. On Wed, 8 Feb 2012 17:21:54 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: This new JSON format for replies includes headers generated for a reply message as well as the headers of the original message. Using this data, a client can intelligently create a reply. For example,

[PATCH] Free the results of scandir()

On Tue, 7 Feb 2012 05:05:03 -0500, Ethan Glasser-Camp wrote: > From: Ethan Glasser-Camp > > scandir() returns "strings allocated via malloc(3)" which are then > "collected in array namelist which is allocated via > malloc(3)". Currently we just free the array namelist. Instead, free > all the

[PATCH v2] Free the results of scandir()

Hi Ethan. On Tue, 7 Feb 2012 01:50:05 -0500, Ethan Glasser-Camp wrote: > From: Ethan Glasser-Camp > > scandir() returns "strings allocated via malloc(3)" which are then > "collected in array namelist which is allocated via > malloc(3)". Currently we just free the array namelist. Instead,

Re: [PATCH v2] Free the results of scandir()

Hi Ethan. On Tue, 7 Feb 2012 01:50:05 -0500, Ethan Glasser-Camp gla...@cs.rpi.edu wrote: From: Ethan Glasser-Camp et...@betacantrips.com scandir() returns strings allocated via malloc(3) which are then collected in array namelist which is allocated via malloc(3). Currently we just free

Re: [PATCH] Free the results of scandir()

On Tue, 7 Feb 2012 05:05:03 -0500, Ethan Glasser-Camp gla...@cs.rpi.edu wrote: From: Ethan Glasser-Camp et...@betacantrips.com scandir() returns strings allocated via malloc(3) which are then collected in array namelist which is allocated via malloc(3). Currently we just free the array

[PATCH v3 2/5] reply: Add a JSON reply format.

On Sun, 5 Feb 2012 12:42:12 -0700, Adam Wolfe Gordon wrote: > Thanks for the review. The style nits are things I missed in my > previous cleanup, so thanks for pointing them out. I should probably > run uncrustify and see if it complains about anything else. > > The other

[PATCH] tag: remove unused attribute from notmuch_tag_command() arguments

On Sat, 04 Feb 2012 07:37:45 -0500, David Bremner wrote: > On Sat, 28 Jan 2012 12:02:33 +0400, Dmitry Kurochkin gmail.com> wrote: > > Argc and argv arguments are used in notmuch_tag_command() function. > > So unused attribute is not appropriate for them. > > pushed,

[PATCH v2 0/2] Rewrite text show format

On Sat, 4 Feb 2012 16:24:24 -0500, Austin Clements wrote: > v2 > > * Remove unnecessary braces (id:87lioooj7m.fsf at gmail.com) > > * Trivial rebase against master > Based on the change log and IRC discussion, I think this series does not need another round of reviews. So it looks like

[PATCH v5 12/12] NEWS: document Emacs UI tagging operations changes

--- NEWS | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 5c5b645..f449fba 100644 --- a/NEWS +++ b/NEWS @@ -39,6 +39,24 @@ Reply to sender and search modes, 'r' has been bound to reply to sender, replacing reply to all, which now

[PATCH v5 11/12] emacs: s/tags/tag-changes/ for arguments of tagging functions

This makes the argument names more consistent and clear. The following functions changed: `notmuch-tag', `notmuch-search-tag-thread', `notmuch-search-tag-region' and `notmuch-search-tag-all'. --- emacs/notmuch.el | 33 + 1 files changed, 17 insertions(+), 16

[PATCH v5 10/12] emacs: accept empty tag list in `notmuch-tag'

Since `notmuch-tag' is a non-interactive function and hence is meant to be invoked programmatically, it should accept zero tags. Also, the tagging operations (bound to "*", "+", "-") would accept empty input without an error. --- emacs/notmuch.el | 10 +- 1 files changed, 5

[PATCH v5 09/12] emacs: relax tag syntax check in `notmuch-tag' function

The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with "::". Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not

[PATCH v5 08/12] emacs: separate history for operations which accept single and multiple tags

Some tag-related operations accept a single tag without prefix (`notmuch-select-tag-with-completion'), others accept multiple tags prefixed with '+' or '-' (`notmuch-read-tag-changes'). Before the change, both functions used a single default minibuffer history. This is inconvenient because you

[PATCH v5 07/12] emacs: add "*" binding for notmuch-show view

The patch adds `notmuch-show-tag-all' function bound to "*" in notmuch-show view. The function is similar to the `notmuch-search-tag-all' function for the notmuch-search view: it changes tags for all messages in the current thread. --- emacs/notmuch-show.el | 35

[PATCH v5 06/12] emacs: rename `notmuch-search-operate-all' to `notmuch-search-tag-all'

`Notmuch-search-tag-all' is more clear and consistent with other tagging function names. --- emacs/notmuch.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 1b472dd..1f351a5 100644 --- a/emacs/notmuch.el +++

[PATCH v5 04/12] emacs: make "+" and "-" tagging operations in notmuch-show more flexible

Before the change, "+" and "-" tagging operations in notmuch-show view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function, which allows to enter multiple tags with "+" and "-" prefixes. So after the change, "+" and "-" bindings in

[PATCH v5 03/12] emacs: make "+" and "-" tagging operations in notmuch-search more flexible

Before the change, "+" and "-" tagging operations in notmuch-search view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function (renamed `notmuch-select-tags-with-completion'), which allows to enter multiple tags with "+" and "-" prefixes. So

[PATCH v5 02/12] emacs: remove text properties from `notmuch-search-get-tags' result

--- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 19206db..5980fea 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -571,7 +571,7 @@ the messages that were tagged" (let ((beg (+ (point) 1)))

[PATCH v5 01/12] emacs: move tag format validation to `notmuch-tag' function

Before the change, tag format validation was done in `notmuch-search-operate-all' function only. The patch moves it down to `notmuch-tag', so that all users of that function get input validation. --- emacs/notmuch.el | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v5 00/12] emacs: more flexible and consistent tagging operations

Changes: v4: * rebased on master, no conflicts so no need for another review v4: * rebased on master after Jameson's archiving changes v3: * merged 3 `notmuch-show-tag-all'-related patches into one * add patch to clean up tagging function argument names * fix other comments from Austin's

[PATCH 1/2] test: auto load elisp tests file in test_emacs if available

Hi David. I think this is a pretty simple change. And there is one +1 for it. So I am going to remove the needs-review tag, please add it back if you disagree. Regards, Dmitry

[Patch v2 0/4] Control selection of From: header when replying

Hi Mark. I am not sure I like this solution. My concerns are: * New option looks too complex, too specific. * There are more aspects of notmuch reply behavior which users would like to change (e.g. which part to quote). If we add an option for each, we complicate both nomtuch show UI and

Re: [PATCH v2 0/2] Rewrite text show format

On Sat, 4 Feb 2012 16:24:24 -0500, Austin Clements amdra...@mit.edu wrote: v2 * Remove unnecessary braces (id:87lioooj7m@gmail.com) * Trivial rebase against master Based on the change log and IRC discussion, I think this series does not need another round of reviews. So it looks

Re: [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments

On Sat, 04 Feb 2012 07:37:45 -0500, David Bremner da...@tethera.net wrote: On Sat, 28 Jan 2012 12:02:33 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Argc and argv arguments are used in notmuch_tag_command() function. So unused attribute is not appropriate for them. pushed

Re: [PATCH v3 2/5] reply: Add a JSON reply format.

On Sun, 5 Feb 2012 12:42:12 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: Thanks for the review. The style nits are things I missed in my previous cleanup, so thanks for pointing them out. I should probably run uncrustify and see if it complains about anything else. The other points are

[PATCH v2 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

`Notmuch-wash-region-to-button' is the function that creates hidden regions with buttons for signatures, citations and original messages. Before the change, it did not work correctly if the to-be-hidden region started at the beginning of a message: the visibility toggle button was hidden as well.

[PATCH v2 1/2] test: add test for hiding Original Message region at beginning of a message

The test is currently broken and will be fixed by a subsequent patch. The patch adds a new file for tests of Emacs notmuch-show view. Based on patch by David Edmondson [1]. [1] id:"1327562380-12894-4-git-send-email-dme at dme.org" --- test/emacs-show | 28

[PATCH v2 0/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

Changes since v1: * rebase on the current master, just one trivial conflict so no need for another round of review Regards, Dmitry

[PATCH 0/2] Bug and potential fix: forwarded messages

On Fri, 3 Feb 2012 23:01:23 -0700, Adam Wolfe Gordon wrote: > Oh, and I just noticed that Dmitry has already fixed this, probably in > a better way [1] (though I maintain that there still may be a problem > with the approach in general). I clearly haven't been following

Re: [Patch v2 0/4] Control selection of From: header when replying

Hi Mark. I am not sure I like this solution. My concerns are: * New option looks too complex, too specific. * There are more aspects of notmuch reply behavior which users would like to change (e.g. which part to quote). If we add an option for each, we complicate both nomtuch show UI and

Re: [PATCH 1/2] test: auto load elisp tests file in test_emacs if available

Hi David. I think this is a pretty simple change. And there is one +1 for it. So I am going to remove the needs-review tag, please add it back if you disagree. Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH v5 00/12] emacs: more flexible and consistent tagging operations

Changes: v4: * rebased on master, no conflicts so no need for another review v4: * rebased on master after Jameson's archiving changes v3: * merged 3 `notmuch-show-tag-all'-related patches into one * add patch to clean up tagging function argument names * fix other comments from Austin's

[PATCH v5 01/12] emacs: move tag format validation to `notmuch-tag' function

Before the change, tag format validation was done in `notmuch-search-operate-all' function only. The patch moves it down to `notmuch-tag', so that all users of that function get input validation. --- emacs/notmuch.el | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v5 04/12] emacs: make + and - tagging operations in notmuch-show more flexible

Before the change, + and - tagging operations in notmuch-show view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function, which allows to enter multiple tags with + and - prefixes. So after the change, + and - bindings in notmuch-show view

[PATCH v5 03/12] emacs: make + and - tagging operations in notmuch-search more flexible

Before the change, + and - tagging operations in notmuch-search view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function (renamed `notmuch-select-tags-with-completion'), which allows to enter multiple tags with + and - prefixes. So after

[PATCH v5 05/12] test: fix emacs tests after tagging operations changes

After the recent tagging operations changes, functions bound to + and - in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly. --- test/emacs | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-)

[PATCH v5 06/12] emacs: rename `notmuch-search-operate-all' to `notmuch-search-tag-all'

`Notmuch-search-tag-all' is more clear and consistent with other tagging function names. --- emacs/notmuch.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 1b472dd..1f351a5 100644 --- a/emacs/notmuch.el +++

[PATCH v5 08/12] emacs: separate history for operations which accept single and multiple tags

Some tag-related operations accept a single tag without prefix (`notmuch-select-tag-with-completion'), others accept multiple tags prefixed with '+' or '-' (`notmuch-read-tag-changes'). Before the change, both functions used a single default minibuffer history. This is inconvenient because you

[PATCH v5 09/12] emacs: relax tag syntax check in `notmuch-tag' function

The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with ::. Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not

[PATCH v5 10/12] emacs: accept empty tag list in `notmuch-tag'

Since `notmuch-tag' is a non-interactive function and hence is meant to be invoked programmatically, it should accept zero tags. Also, the tagging operations (bound to *, +, -) would accept empty input without an error. --- emacs/notmuch.el | 10 +- 1 files changed, 5 insertions(+), 5

[PATCH v5 11/12] emacs: s/tags/tag-changes/ for arguments of tagging functions

This makes the argument names more consistent and clear. The following functions changed: `notmuch-tag', `notmuch-search-tag-thread', `notmuch-search-tag-region' and `notmuch-search-tag-all'. --- emacs/notmuch.el | 33 + 1 files changed, 17 insertions(+), 16

[PATCH v5 12/12] NEWS: document Emacs UI tagging operations changes

--- NEWS | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 5c5b645..f449fba 100644 --- a/NEWS +++ b/NEWS @@ -39,6 +39,24 @@ Reply to sender and search modes, 'r' has been bound to reply to sender, replacing reply to all, which now

[PATCH 1/2] test: add check for filename argument for test_expect_equal_file

On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins wrote: > Hey, Dmitry. I'm so sorry I sent my last email on your original patch > before I saw this new series. I do now like your original proposal > better, since it shows the diff based the names the caller provides, > which I now

[PATCH] test: replace occurrences of $PWD with vars that are more stable

On Fri, 03 Feb 2012 11:20:58 +0100, Pieter Praet wrote: > On Thu, 02 Feb 2012 03:09:39 +0400, Dmitry Kurochkin gmail.com> wrote: > > [...] > > I would prefer to put the whole second argument inside the quotes, not > > just the variable. > > [...] > >

[PATCH 1/2] test: add check for filename argument for test_expect_equal_file

Hi Jameson. On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins wrote: > Hey, Dmitry. I'm so sorry I sent my last email on your original patch > before I saw this new series. No problems. > I do now like your original proposal > better, since it shows the diff based the names the

Re: [PATCH 0/2] Bug and potential fix: forwarded messages

On Fri, 3 Feb 2012 23:01:23 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: Oh, and I just noticed that Dmitry has already fixed this, probably in a better way [1] (though I maintain that there still may be a problem with the approach in general). I clearly haven't been following the list

[PATCH v2 0/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

Changes since v1: * rebase on the current master, just one trivial conflict so no need for another round of review Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2 1/2] test: add test for hiding Original Message region at beginning of a message

The test is currently broken and will be fixed by a subsequent patch. The patch adds a new file for tests of Emacs notmuch-show view. Based on patch by David Edmondson [1]. [1] id:1327562380-12894-4-git-send-email-...@dme.org --- test/emacs-show | 28

[PATCH v2 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

`Notmuch-wash-region-to-button' is the function that creates hidden regions with buttons for signatures, citations and original messages. Before the change, it did not work correctly if the to-be-hidden region started at the beginning of a message: the visibility toggle button was hidden as well.

[PATCH] test: make test_expect_equal_file() arguments flexible

On Thu, 02 Feb 2012 03:42:29 +0400, Dmitry Kurochkin wrote: > Hi Jameson. > > On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins finestructure.net> wrote: > > On Wed, 01 Feb 2012 14:37:53 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > On Wed, 01 Feb

[PATCH 2/2] test: fix order and format of test_expect_equal_file arguments

The patch fixes tests which were broken by the new test_expect_equal_file() argument check. Some tests have correct filename format, but wrong argument order. Others require files to be renamed. --- test/crypto | 10 +- test/dump-restore| 10 +- test/hooks

[PATCH 1/2] test: add check for filename argument for test_expect_equal_file

Test_expect_equal_file() function treats the first argument as "actual output file" and the second argument as "expected output file". When the test fails, the files are copied for later inspection. The first files is copied to "$testname.output" and the second file to "$testname.expected". The

[PATCH 0/2] test_expect_equal_file arguments check

Hi all. This is my second attempt to solve the test_expect_equal_file() argument issue, based on Tomi's idea [1]. The first attempt and the following discussion can be found here [2]. Regards, Dmitry [1] id:"m28vknaq5l.fsf at guru.guru-group.fi" [2]

[PATCH] test: make test_expect_equal_file() arguments flexible

Hi Jameson. On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins wrote: > On Wed, 01 Feb 2012 14:37:53 +0400, Dmitry Kurochkin gmail.com> wrote: > > On Wed, 01 Feb 2012 12:18:08 +0200, Tomi Ollila > > wrote: > > > > > > There are at least these opt

[PATCH v4] test: emacs: add test for `notmuch-search-operate-all'

Hi Pieter. On Wed, 01 Feb 2012 21:32:32 +0100, Pieter Praet wrote: > On Wed, 01 Feb 2012 18:06:05 +0400, Dmitry Kurochkin gmail.com> wrote: > > On Wed, 01 Feb 2012 14:44:48 +0100, Pieter Praet > > wrote: > > > On Mon, 30 Jan 2012 12:13:48 +0400, Dmitry Kuro

[PATCH] test: replace occurrences of $PWD with vars that are more stable

On Wed, 1 Feb 2012 21:37:21 +0100, Pieter Praet wrote: > Thanks to Dmitry Kurochkin > for pointing this out: id:"87d39ymyb4.fsf at gmail.com" > --- Looks good to me. Minor comments below. > test/emacs |2 +- > test/new |6 +++--- > 2 files changed,

Re: [PATCH v4] test: emacs: add test for `notmuch-search-operate-all'

Hi Pieter. On Wed, 01 Feb 2012 21:32:32 +0100, Pieter Praet pie...@praet.org wrote: On Wed, 01 Feb 2012 18:06:05 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Wed, 01 Feb 2012 14:44:48 +0100, Pieter Praet pie...@praet.org wrote: On Mon, 30 Jan 2012 12:13:48 +0400, Dmitry

Re: [PATCH] test: make test_expect_equal_file() arguments flexible

Hi Jameson. On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Wed, 01 Feb 2012 14:37:53 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Wed, 01 Feb 2012 12:18:08 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: There are at least

[PATCH 0/2] test_expect_equal_file arguments check

Hi all. This is my second attempt to solve the test_expect_equal_file() argument issue, based on Tomi's idea [1]. The first attempt and the following discussion can be found here [2]. Regards, Dmitry [1] id:m28vknaq5l@guru.guru-group.fi [2]

[PATCH 1/2] test: add check for expected filename argument for test_expect_equal_file

Test_expect_equal_file() function treats the first argument as actual output file and the second argument as expected output file. When the test fails, the files are copied for later inspection. The first files is copied to $testname.output and the second file to $testname.expected. The

[PATCH 2/2] test: fix order and format of test_expect_equal_file arguments

The patch fixes tests which were broken by the new test_expect_equal_file() argument check. Some tests have correct filename format, but wrong argument order. Others require files to be renamed. --- test/crypto | 10 +- test/dump-restore| 10 +- test/hooks

Re: [PATCH] test: make test_expect_equal_file() arguments flexible

On Thu, 02 Feb 2012 03:42:29 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi Jameson. On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Wed, 01 Feb 2012 14:37:53 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote

Re: [PATCH 1/2] test: add check for expected filename argument for test_expect_equal_file

Hi Jameson. On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Hey, Dmitry. I'm so sorry I sent my last email on your original patch before I saw this new series. No problems. I do now like your original proposal better, since it shows the diff

[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

On Wed, 01 Feb 2012 14:46:19 +0100, Pieter Praet wrote: > On Mon, 30 Jan 2012 09:23:40 +, David Edmondson wrote: > > On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner > > wrote: > > > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula > > > wrote: > > > > On Jan 28, 2012 2:41 PM, "David

emacs: quote MML tags in replies

On Wed, 01 Feb 2012 14:51:37 +0100, Pieter Praet wrote: > On Wed, 1 Feb 2012 06:49:39 +0400, Dmitry Kurochkin gmail.com> wrote: > > Hi Aaron. > > > > Thanks for your work! I took the liberty to do some cleanups for your > > patch. Below is a detailed lis

[PATCH v4] test: emacs: add test for `notmuch-search-operate-all'

On Wed, 01 Feb 2012 14:44:48 +0100, Pieter Praet wrote: > On Mon, 30 Jan 2012 12:13:48 +0400, Dmitry Kurochkin gmail.com> wrote: > > Hi Pieter. > > > > On Mon, 30 Jan 2012 08:45:50 +0100, Pieter Praet > > wrote: > > > `notmuch-search-operate-al

[PATCH] test: make test_expect_equal_file() arguments flexible

On Wed, 01 Feb 2012 12:18:08 +0200, Tomi Ollila wrote: > > There are at least these options here > > 1) go through all ~100 places where test_expect_equal_file is used >and fix the call order: quick look tells that the offending uses >are in dump-restore, hooks, search-limiting and

[PATCH] test: make test_expect_equal_file() arguments flexible

On Wed, 01 Feb 2012 10:55:50 +0200, Tomi Ollila wrote: > On Wed, 01 Feb 2012 00:47:30 -0800, Jameson Graef Rollins finestructure.net> wrote: > > On Wed, 1 Feb 2012 11:19:54 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > The down side of this approach is that

[PATCH] test: make test_expect_equal_file() arguments flexible

Before the change, test_expect_equal_file() function treated the first argument as "actual output file" and the second argument as "expected output file". When the test fails, the files are copied for later inspection. The first files was copied to "$testname.output" and the second file to

[PATCH v3 2/2] emacs: quote MML tags in replies

From: Aaron Ecay Emacs message-mode uses certain text strings to indicate how to attach files to outgoing mail. If these are present in the text of an email, and a user is tricked into replying to the message, the user?s files could be exposed. --- NEWS |

[PATCH v3 1/2] test: add tests for quoting of MML tags in replies

From: Aaron Ecay The test is broken at this time; the next commit will introduce a fix. --- test/emacs| 12 test/emacs.expected-output/quote-mml-in-reply |7 +++ 2 files changed, 19 insertions(+), 0 deletions(-)

emacs: quote MML tags in replies

Hi Aaron. Thanks for your work! I took the liberty to do some cleanups for your patch. Below is a detailed list of changes. Hope this helps. Changes since v2: * change patch names to be consistent with others: - s/emacs:/test:/ for the test patch - lower case the first word after colon

[RFC PATCH v2] emacs: make show view a/A/x/X key bindings more consistent

On Tue, 31 Jan 2012 19:29:06 +0200, Jani Nikula wrote: > Modify the show view key bindings as follows to make them more > consistent: > > 'a' = Archive current message, then move to next message, or show next > thread from search if at the last message in thread. > > 'A' = Archive each message

Re: [PATCH v4] test: emacs: add test for `notmuch-search-operate-all'

On Wed, 01 Feb 2012 14:44:48 +0100, Pieter Praet pie...@praet.org wrote: On Mon, 30 Jan 2012 12:13:48 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi Pieter. On Mon, 30 Jan 2012 08:45:50 +0100, Pieter Praet pie...@praet.org wrote: `notmuch-search-operate-all' (bound

<    1   2   3   4   5   6   7   8   9   10   >