Re: emacs: quote MML tags in replies

On Wed, 01 Feb 2012 14:51:37 +0100, Pieter Praet pie...@praet.org wrote: On Wed, 1 Feb 2012 06:49:39 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi Aaron. Thanks for your work! I took the liberty to do some cleanups for your patch. Below is a detailed list of changes

Re: [PATCH] emacs: globally replace non-branching (if COND (progn ... with (when ...

On Wed, 01 Feb 2012 14:46:19 +0100, Pieter Praet pie...@praet.org wrote: On Mon, 30 Jan 2012 09:23:40 +, David Edmondson d...@dme.org wrote: On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner da...@tethera.net wrote: On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula j...@nikula.org wrote:

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

On Mon, 30 Jan 2012 16:52:20 +, David Edmondson wrote: > The blank line doesn't really change position, but is now considered > to be part of the body rather than part of the headers. This means > that it is visible when the body is visible rather than when the > headers are visible. > --- >

[PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

On Tue, 31 Jan 2012 08:36:27 +, David Edmondson wrote: > On Tue, 31 Jan 2012 12:24:27 +0400, Dmitry Kurochkin gmail.com> wrote: > > This is why I like big diff contexts... > > Can I set that in my .gitconfig? Unfortunately, I did not find a way to do that, except f

[PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

On Tue, 31 Jan 2012 08:22:20 +, David Edmondson wrote: > On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin gmail.com> wrote: > > On Tue, 31 Jan 2012 08:01:54 +, David Edmondson wrote: > > > When using the spacebar to scroll through a thread, hitting 'space'

[PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

On Tue, 31 Jan 2012 08:01:54 +, David Edmondson wrote: > When using the spacebar to scroll through a thread, hitting 'space' > when the bottom of the last message is visible should take the cursor > to the end of the buffer rather than immediately archiving the thread > and moving to the next

[PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.

On Tue, 31 Jan 2012 08:01:53 +, David Edmondson wrote: > When archiving the last message in a thread (a), rather than just > moving the pointer to the next thread in the parent search buffer, > actually display the next thread. > --- +1 Regards, Dmitry > emacs/notmuch-show.el |2 +-

[PATCH v4 12/12] NEWS: document Emacs UI tagging operations changes

--- NEWS | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 2acdce5..7506d68 100644 --- a/NEWS +++ b/NEWS @@ -39,6 +39,24 @@ Reply to sender and search modes, 'r' has been bound to reply to sender, replacing reply to all, which now

[PATCH v4 11/12] emacs: s/tags/tag-changes/ for arguments of tagging functions

This makes the argument names more consistent and clear. The following functions changed: `notmuch-tag', `notmuch-search-tag-thread', `notmuch-search-tag-region' and `notmuch-search-tag-all'. --- emacs/notmuch.el | 33 + 1 files changed, 17 insertions(+), 16

[PATCH v4 10/12] emacs: accept empty tag list in `notmuch-tag'

Since `notmuch-tag' is a non-interactive function and hence is meant to be invoked programmatically, it should accept zero tags. Also, the tagging operations (bound to "*", "+", "-") would accept empty input without an error. --- emacs/notmuch.el | 10 +- 1 files changed, 5

[PATCH v4 09/12] emacs: relax tag syntax check in `notmuch-tag' function

The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with "::". Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not

[PATCH v4 07/12] emacs: add "*" binding for notmuch-show view

The patch adds `notmuch-show-tag-all' function bound to "*" in notmuch-show view. The function is similar to the `notmuch-search-tag-all' function for the notmuch-search view: it changes tags for all messages in the current thread. --- emacs/notmuch-show.el | 35

[PATCH v4 05/12] test: fix emacs tests after tagging operations changes

After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly. --- test/emacs | 20 ++-- 1 files changed, 10 insertions(+), 10

[PATCH v4 03/12] emacs: make "+" and "-" tagging operations in notmuch-search more flexible

Before the change, "+" and "-" tagging operations in notmuch-search view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function (renamed `notmuch-select-tags-with-completion'), which allows to enter multiple tags with "+" and "-" prefixes. So

[PATCH v4 02/12] emacs: remove text properties from `notmuch-search-get-tags' result

--- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 84d7d0a..ff46617 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -577,7 +577,7 @@ the messages that were tagged" (let ((beg (+ (point) 1)))

[PATCH v4 01/12] emacs: move tag format validation to `notmuch-tag' function

Before the change, tag format validation was done in `notmuch-search-operate-all' function only. The patch moves it down to `notmuch-tag', so that all users of that function get input validation. --- emacs/notmuch.el | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v4 00/12] emacs: more flexible and consistent tagging operations

Changes: v4: * rebased on master after Jameson's archiving changes v3: * merged 3 `notmuch-show-tag-all'-related patches into one * add patch to clean up tagging function argument names * fix other comments from Austin's reviews [5,6] v2: * add patch to remove "No tags given" error from

[PATCH 1/3] lib: Don't delete uninitialized pointers

Hi Austin. All 3 patches look good to me. Regards, Dmitry

[PATCH 2/2] show: Simplify new text formatter code

On Thu, 26 Jan 2012 01:55:26 -0500, Austin Clements wrote: > This makes the text formatter take advantage of the new code > structure. The previously duplicated header logic is now unified, > several things that we used to compute repeatedly across different > callbacks are now computed once,

[PATCH 1/2] show: Convert text format to the new self-recursive style

On Thu, 26 Jan 2012 01:55:25 -0500, Austin Clements wrote: > This is all code movement and a smidgen of glue. This moves the > existing text formatter code into one self-recursive function, but > doesn't change any of the logic. The next patch will actually take > advantage of what the new

[PATCH 2/2] test: use subtest name for generated message subject by default

Before the change, messages generated by generate_message() used "Test message #N" for default subject where N is the generated messages counter. Since message subject is commonly present in expected results, there is a chance of breaking other tests when a new generate_message() call is added.

[PATCH 1/2] test: remove "Generate some messages" test from raw

Before the change, the first subtest in raw format tests just generated messages and checked that they are added successfully. This is not really a raw format test, it is creating of environment required for other subtests to run. The patch removes the first subtest from raw and replaces it with

Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.

On Tue, 31 Jan 2012 08:01:53 +, David Edmondson d...@dme.org wrote: When archiving the last message in a thread (a), rather than just moving the pointer to the next thread in the parent search buffer, actually display the next thread. --- +1 Regards, Dmitry emacs/notmuch-show.el |

Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

On Tue, 31 Jan 2012 08:22:20 +, David Edmondson d...@dme.org wrote: On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Tue, 31 Jan 2012 08:01:54 +, David Edmondson d...@dme.org wrote: When using the spacebar to scroll through a thread, hitting

Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.

On Tue, 31 Jan 2012 10:43:10 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Tue, 31 Jan 2012 08:01:53 +, David Edmondson d...@dme.org wrote: When archiving the last message in a thread (a), rather than just moving the pointer to the next thread in the parent search buffer, actually

Re: [RFC PATCH v2] emacs: make show view a/A/x/X key bindings more consistent

On Tue, 31 Jan 2012 19:29:06 +0200, Jani Nikula j...@nikula.org wrote: Modify the show view key bindings as follows to make them more consistent: 'a' = Archive current message, then move to next message, or show next thread from search if at the last message in thread. 'A' = Archive each

emacs: quote MML tags in replies

Hi Aaron. Thanks for your work! I took the liberty to do some cleanups for your patch. Below is a detailed list of changes. Hope this helps. Changes since v2: * change patch names to be consistent with others: - s/emacs:/test:/ for the test patch - lower case the first word after colon

[PATCH v3 1/2] test: add tests for quoting of MML tags in replies

From: Aaron Ecay aarone...@gmail.com The test is broken at this time; the next commit will introduce a fix. --- test/emacs| 12 test/emacs.expected-output/quote-mml-in-reply |7 +++ 2 files changed, 19 insertions(+), 0 deletions(-)

[PATCH v3 2/2] emacs: quote MML tags in replies

From: Aaron Ecay aarone...@gmail.com Emacs message-mode uses certain text strings to indicate how to attach files to outgoing mail. If these are present in the text of an email, and a user is tricked into replying to the message, the user’s files could be exposed. --- NEWS |

[PATCH] test: make test_expect_equal_file() arguments flexible

Before the change, test_expect_equal_file() function treated the first argument as actual output file and the second argument as expected output file. When the test fails, the files are copied for later inspection. The first files was copied to $testname.output and the second file to

[PATCH] lib: update notmuch_tags_get examle to reflect api change

Hi Allan. I did not look at the patch, but there is a typo in the patch title: s/examle/example/. Regards, Dmitry

[PATCH 0/4 v3] more care when hiding regions with buttons

Hi David. Here is my attempt to fix the issue in a cleaner way: id:"1327926286-16680-1-git-send-email-dmitry.kurochkin at gmail.com" Regards, Dmitry

[PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

`Notmuch-wash-region-to-button' is the function that creates hidden regions with buttons for signatures, citations and original messages. Before the change, it did not work correctly if the to-be-hidden region started at the beginning of a message: the visibility toggle button was hidden as well.

[PATCH 1/2] test: add test for hiding Original Message region at beginning of a message

The test is currently broken and will be fixed by a subsequent patch. The patch adds a new file for tests of Emacs notmuch-show view. Based on patch by David Edmondson [1]. [1] id:"1327562380-12894-4-git-send-email-dme at dme.org" --- test/emacs-show | 28

[PATCH 0/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

This patch series is an attempt to fix the issue found by David [1] in a cleaner way. Regards, Dmitry [1] id:"1327503908-17226-1-git-send-email-dme at dme.org"

[PATCH v4] test: emacs: add test for `notmuch-search-operate-all'

Hi Pieter. On Mon, 30 Jan 2012 08:45:50 +0100, Pieter Praet wrote: > `notmuch-search-operate-all' (bound to "*") adds and removes tags > to/from all messages which match the query used to populate the > current search buffer. > > --- > > Rebased to current master. > > Previous versions

[PATCH v3 12/12] NEWS: document Emacs UI tagging operations changes

--- NEWS | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 2acdce5..7506d68 100644 --- a/NEWS +++ b/NEWS @@ -39,6 +39,24 @@ Reply to sender and search modes, 'r' has been bound to reply to sender, replacing reply to all, which now

[PATCH v3 11/12] emacs: s/tags/tag-changes/ for arguments of tagging functions

This makes the argument names more consistent and clear. The following functions changed: `notmuch-tag', `notmuch-search-tag-thread', `notmuch-search-tag-region' and `notmuch-search-tag-all'. --- emacs/notmuch.el | 33 + 1 files changed, 17 insertions(+), 16

[PATCH v3 10/12] emacs: accept empty tag list in `notmuch-tag'

Since `notmuch-tag' is a non-interactive function and hence is meant to be invoked programmatically, it should accept zero tags. Also, the tagging operations (bound to "*", "+", "-") would accept empty input without an error. --- emacs/notmuch.el | 10 +- 1 files changed, 5

[PATCH v3 09/12] emacs: relax tag syntax check in `notmuch-tag' function

The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with "::". Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not

[PATCH v3 08/12] emacs: separate history for operations which accept single and multiple tags

Some tag-related operations accept a single tag without prefix (`notmuch-select-tag-with-completion'), others accept multiple tags prefixed with '+' or '-' (`notmuch-read-tag-changes'). Before the change, both functions used a single default minibuffer history. This is inconvenient because you

[PATCH v3 07/12] emacs: add "*" binding for notmuch-show view

The patch adds `notmuch-show-tag-all' function bound to "*" in notmuch-show view. The function is similar to the `notmuch-search-tag-all' function for the notmuch-search view: it changes tags for all messages in the current thread. --- emacs/notmuch-show.el | 35

[PATCH v3 06/12] emacs: rename `notmuch-search-operate-all' to `notmuch-search-tag-all'

`Notmuch-search-tag-all' is more clear and consistent with other tagging function names. --- emacs/notmuch.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index ce8bef6..7d06109 100644 --- a/emacs/notmuch.el +++

[PATCH v3 05/12] test: fix emacs tests after tagging operations changes

After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly. --- test/emacs | 20 ++-- 1 files changed, 10 insertions(+), 10

[PATCH v3 04/12] emacs: make "+" and "-" tagging operations in notmuch-show more flexible

Before the change, "+" and "-" tagging operations in notmuch-show view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function, which allows to enter multiple tags with "+" and "-" prefixes. So after the change, "+" and "-" bindings in

[PATCH v3 03/12] emacs: make "+" and "-" tagging operations in notmuch-search more flexible

Before the change, "+" and "-" tagging operations in notmuch-search view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function (renamed `notmuch-select-tags-with-completion'), which allows to enter multiple tags with "+" and "-" prefixes. So

[PATCH v3 02/12] emacs: remove text properties from `notmuch-search-get-tags' result

--- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 84d7d0a..ff46617 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -577,7 +577,7 @@ the messages that were tagged" (let ((beg (+ (point) 1)))

[PATCH v3 01/12] emacs: move tag format validation to `notmuch-tag' function

Before the change, tag format validation was done in `notmuch-search-operate-all' function only. The patch moves it down to `notmuch-tag', so that all users of that function get input validation. --- emacs/notmuch.el | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

emacs: more flexible and consistent tagging operations

Changes: v3: * merged 3 `notmuch-show-tag-all'-related patches into one * add patch to clean up tagging function argument names * fix other comments from Austin's reviews [5,6] v2: * add patch to remove "No tags given" error from `notmuch-tag' as suggested by Austin in [1] * split patch 3

[PATCH v2 10/13] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

On Sun, 29 Jan 2012 23:57:09 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > > Before the change, `notmuch-show-operate-all' used thread id for > > notmuch-show-tag-all? > ouch > > "notmuch tag" search. This could result

[PATCH v2 13/13] NEWS: document Emacs UI tagging operations changes

On Mon, 30 Jan 2012 00:04:02 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > > --- > > NEWS | 18 ++ > > 1 files changed, 18 insertions(+), 0 deletions(-) > > > > diff --git a/NEWS b/NEWS > > index

[PATCH v2 03/13] emacs: make "+" and "-" tagging operations in notmuch-search more robust

On Sun, 29 Jan 2012 23:48:06 -0500, Austin Clements wrote: > Looking good. Just a few small points below. > > Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > > Before the change, "+" and "-" tagging operations in notmuch-search > > view accepted onl

[PATCH v2 13/13] NEWS: document Emacs UI tagging operations changes

--- NEWS | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 2acdce5..dc3acc4 100644 --- a/NEWS +++ b/NEWS @@ -39,6 +39,24 @@ Reply to sender and search modes, 'r' has been bound to reply to sender, replacing reply to all, which now

[PATCH v2 12/13] emacs: accept empty tag list in `notmuch-tag'

Since `notmuch-tag' is a non-interactive function and hence is meant to be invoked programmatically, it should accept zero tags. Also, the tagging operations (bound to "*", "+", "-") would accept empty input without an error. --- emacs/notmuch.el | 10 +- 1 files changed, 5

[PATCH v2 11/13] emacs: code cleanup in `notmuch-show-operate-all', no functional changes

Use `notmuch-show-mapc' function instead of a custom `loop'. --- emacs/notmuch-show.el | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index b115a8f..69381ac 100644 --- a/emacs/notmuch-show.el +++

[PATCH v2 10/13] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

Before the change, `notmuch-show-operate-all' used thread id for "notmuch tag" search. This could result in tagging unexpected messages that were added to the thread after the notmuch-show buffer was created. The patch changes `notmuch-show-operate-all' to use ids of shown messages to fix this.

[PATCH v2 09/13] emacs: relax tag syntax check in `notmuch-tag' function

The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with "::". Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not

[PATCH v2 08/13] emacs: separate history for operations which accept single and multiple tags

Some tag-related operations accept a single tag without prefix (`notmuch-select-tag-with-completion'), others accept multiple tags prefixed with '+' or '-' (`notmuch-read-tag-changes'). Before the change, both functions used a single default minibuffer history. This is inconvenient because you

[PATCH v2 07/13] emacs: add "*" binding for notmuch-show view

The patch adds `notmuch-show-tag-all' function bound to "*" in notmuch-show view. The function is similar to the `notmuch-search-tag-all' function for the notmuch-search view: it changes tags for all messages in the current thread. --- emacs/notmuch-show.el | 15 +++ 1 files

[PATCH v2 06/13] emacs: rename `notmuch-search-operate-all' to `notmuch-search-tag-all'

`Notmuch-search-tag-all' is more clear and consistent with other tagging function names. --- emacs/notmuch.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 90b594c..90627dc 100644 --- a/emacs/notmuch.el +++

[PATCH v2 05/13] test: fix emacs tests after tagging operations changes

After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly. --- test/emacs | 20 ++-- 1 files changed, 10 insertions(+), 10

[PATCH v2 04/13] emacs: make "+" and "-" tagging operations in notmuch-show more robust

Before the change, "+" and "-" tagging operations in notmuch-show view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function, which allows to enter multiple tags with "+" and "-" prefixes. So after the change, "+" and "-" bindings in

[PATCH v2 03/13] emacs: make "+" and "-" tagging operations in notmuch-search more robust

Before the change, "+" and "-" tagging operations in notmuch-search view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function (renamed `notmuch-select-tags-with-completion'), which allows to enter multiple tags with "+" and "-" prefixes. So

[PATCH v2 02/13] emacs: remove text properties from `notmuch-search-get-tags' result

--- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 84d7d0a..ff46617 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -577,7 +577,7 @@ the messages that were tagged" (let ((beg (+ (point) 1)))

[PATCH v2 01/13] emacs: move tag format validation to `notmuch-tag' function

Before the change, tag format validation was done in `notmuch-search-operate-all' function only. The patch moves it down to `notmuch-tag', so that all users of that function get input validation. --- emacs/notmuch.el | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v2 00/13] emacs: more robust and consistent tagging operations

Changes in v2: * add patch to remove "No tags given" error from `notmuch-tag' as suggested by Austin in [1] * split patch 3 in two (search and show) for easier review * add patch with NEWS entry * rename `notmuch-{search,show}-operate-all' to `notmuch-{search,show}-tag-all' * fix other

[PATCH 8/6] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

EOn Sun, 29 Jan 2012 18:11:20 -0500, Austin Clements wrote: > Eighth in the increasingly inaccurately named six patch series... > > Quoth Dmitry Kurochkin on Jan 28 at 9:59 am: > > Before the change, `notmuch-show-operate-all' used thread id for > > "notmuch tag&q

[PATCH 6/6] emacs: separate history for operations which accept single and multiple tags

On Sun, 29 Jan 2012 18:02:29 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > > Some tag-related operations accept a single tag without prefix > > (`notmuch-select-tag-with-completion'), others accept multiple tags > > prefixed with '+' or '-'

[PATCH 3/6] emacs: make "+" and "-" tagging operations more robust

Hi Austin. The below changes will be send as v2 soon. On Sun, 29 Jan 2012 17:57:10 -0500, Austin Clements wrote: > I'm looking forward to having this. I think it'll streamline tagging > operations. > > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > > Before the change, &

[PATCH 1/6] emacs: move tag format validation to `notmuch-tag' function

On Sun, 29 Jan 2012 18:16:50 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 30 at 2:54 am: > > Hi Austin. > > > > On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements > > wrote: > > > One philosophical nit below, but not enough to hol

[PATCH 4/6] test: fix emacs tests after tagging operations changes

On Sun, 29 Jan 2012 17:58:41 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > > After the recent tagging operations changes, functions bound to "+" > > and "-" in notmuch-search and notmuch-show views always read input >

[PATCH 1/6] emacs: move tag format validation to `notmuch-tag' function

Hi Austin. On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements wrote: > One philosophical nit below, but not enough to hold this up. > > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > > Before the change, tag format validation was done in > > `notmuch-search-opera

[PATCH 1/2] test: add test for hiding Original Message region at beginning of a message

The test is currently broken and will be fixed by a subsequent patch. The patch adds a new file for tests of Emacs notmuch-show view. Based on patch by David Edmondson [1]. [1] id:1327562380-12894-4-git-send-email-...@dme.org --- test/emacs-show | 28

[PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

`Notmuch-wash-region-to-button' is the function that creates hidden regions with buttons for signatures, citations and original messages. Before the change, it did not work correctly if the to-be-hidden region started at the beginning of a message: the visibility toggle button was hidden as well.

Re: [PATCH 0/4 v3] more care when hiding regions with buttons

Hi David. Here is my attempt to fix the issue in a cleaner way: id:1327926286-16680-1-git-send-email-dmitry.kuroch...@gmail.com Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] test: remove Generate some messages test from raw

Before the change, the first subtest in raw format tests just generated messages and checked that they are added successfully. This is not really a raw format test, it is creating of environment required for other subtests to run. The patch removes the first subtest from raw and replaces it with

[PATCH 2/2] test: use subtest name for generated message subject by default

Before the change, messages generated by generate_message() used Test message #N for default subject where N is the generated messages counter. Since message subject is commonly present in expected results, there is a chance of breaking other tests when a new generate_message() call is added.

[PATCH v4 02/12] emacs: remove text properties from `notmuch-search-get-tags' result

--- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 84d7d0a..ff46617 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -577,7 +577,7 @@ the messages that were tagged (let ((beg (+ (point) 1)))

[PATCH v4 07/12] emacs: add * binding for notmuch-show view

The patch adds `notmuch-show-tag-all' function bound to * in notmuch-show view. The function is similar to the `notmuch-search-tag-all' function for the notmuch-search view: it changes tags for all messages in the current thread. --- emacs/notmuch-show.el | 35

[PATCH 2/2] test: remove explicit loading of elisp tests in emacs-address-cleaning

It is no longer needed, since elisp tests files are auto loaded now. --- test/emacs-address-cleaning |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/test/emacs-address-cleaning b/test/emacs-address-cleaning index 51018fe..6ddde5c 100755 ---

[PATCH 1/2] test: auto load elisp tests file in test_emacs if available

This allows us to simplify shell part of tests written in elisp. --- test/test-lib.sh |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 8158328..0174e93 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -943,6 +943,12 @@

[PATCH v7 2/2] emacs: Tests for user-defined sections

Hi Daniel. On Sat, 28 Jan 2012 22:30:57 +0100, Daniel Schoepe wrote: > Hi Dmitry, > > On Tue, 24 Jan 2012 03:07, Dmitry Kurochkin > wrote: > > There are some trailing whitespaces in the tests. > > those are also produced by the various notmuch-hello functions, and ar

Re: [PATCH 4/6] test: fix emacs tests after tagging operations changes

On Sun, 29 Jan 2012 17:58:41 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: After the recent tagging operations changes, functions bound to + and - in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros

Re: [PATCH 1/6] emacs: move tag format validation to `notmuch-tag' function

On Sun, 29 Jan 2012 18:16:50 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Jan 30 at 2:54 am: Hi Austin. On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements amdra...@mit.edu wrote: One philosophical nit below, but not enough to hold this up. Quoth

Re: [PATCH 3/6] emacs: make + and - tagging operations more robust

Hi Austin. The below changes will be send as v2 soon. On Sun, 29 Jan 2012 17:57:10 -0500, Austin Clements amdra...@mit.edu wrote: I'm looking forward to having this. I think it'll streamline tagging operations. Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: Before the change

Re: [PATCH 6/6] emacs: separate history for operations which accept single and multiple tags

On Sun, 29 Jan 2012 18:02:29 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: Some tag-related operations accept a single tag without prefix (`notmuch-select-tag-with-completion'), others accept multiple tags prefixed with '+' or '-' (`notmuch

Re: [PATCH 8/6] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

EOn Sun, 29 Jan 2012 18:11:20 -0500, Austin Clements amdra...@mit.edu wrote: Eighth in the increasingly inaccurately named six patch series... Quoth Dmitry Kurochkin on Jan 28 at 9:59 am: Before the change, `notmuch-show-operate-all' used thread id for notmuch tag search. This could

[PATCH v2 00/13] emacs: more robust and consistent tagging operations

Changes in v2: * add patch to remove No tags given error from `notmuch-tag' as suggested by Austin in [1] * split patch 3 in two (search and show) for easier review * add patch with NEWS entry * rename `notmuch-{search,show}-operate-all' to `notmuch-{search,show}-tag-all' * fix other

[PATCH v2 02/13] emacs: remove text properties from `notmuch-search-get-tags' result

--- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 84d7d0a..ff46617 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -577,7 +577,7 @@ the messages that were tagged (let ((beg (+ (point) 1)))

[PATCH v2 05/13] test: fix emacs tests after tagging operations changes

After the recent tagging operations changes, functions bound to + and - in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly. --- test/emacs | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-)

[PATCH v2 07/13] emacs: add * binding for notmuch-show view

The patch adds `notmuch-show-tag-all' function bound to * in notmuch-show view. The function is similar to the `notmuch-search-tag-all' function for the notmuch-search view: it changes tags for all messages in the current thread. --- emacs/notmuch-show.el | 15 +++ 1 files changed,

[PATCH v2 09/13] emacs: relax tag syntax check in `notmuch-tag' function

The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with ::. Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not

[PATCH v2 10/13] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

Before the change, `notmuch-show-operate-all' used thread id for notmuch tag search. This could result in tagging unexpected messages that were added to the thread after the notmuch-show buffer was created. The patch changes `notmuch-show-operate-all' to use ids of shown messages to fix this.

[PATCH v2 12/13] emacs: accept empty tag list in `notmuch-tag'

Since `notmuch-tag' is a non-interactive function and hence is meant to be invoked programmatically, it should accept zero tags. Also, the tagging operations (bound to *, +, -) would accept empty input without an error. --- emacs/notmuch.el | 10 +- 1 files changed, 5 insertions(+), 5

Re: [PATCH v2 13/13] NEWS: document Emacs UI tagging operations changes

On Mon, 30 Jan 2012 00:04:02 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: --- NEWS | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 2acdce5..dc3acc4 100644 --- a/NEWS +++ b

[PATCH v3 04/12] emacs: make + and - tagging operations in notmuch-show more flexible

Before the change, + and - tagging operations in notmuch-show view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function, which allows to enter multiple tags with + and - prefixes. So after the change, + and - bindings in notmuch-show view

[PATCH 3/6] emacs: make "+" and "-" tagging operations more robust

ed" characters. This series does not aim to resolve them and not make it worse. Also see Jani's reply to another patch in the series. Regards, Dmitry [1] id:"CAB+hUn834oJ+XGx-YyYSGxSnzrBYCMvcu4Vd73ws28qTS2riuA at mail.gmail.com" > On Fri, Jan 27, 2012 at 21:41, Dmitry Kurochkin

[PATCH 7/6] emacs: relax tag syntax check in `notmuch-tag' function

On Sat, 28 Jan 2012 10:56:21 +0200, Jani Nikula wrote: > On Jan 28, 2012 7:06 AM, "Dmitry Kurochkin" > wrote: > > > > The tag syntax check in `notmuch-tag' function was too strict and did > > not allow nmbug tags with "::". Since the check is don

[PATCH 8/6] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

of scope of this patch series. Currently, neither notmuch-search region tagging code nor the proposed patch try to solve the issue. If and when a proper solution is found, we should implement it for both (or probably more) cases (provided this patch gets accepted). Regards, Dmitry >

[PATCH] tag: remove unused attribute from notmuch_tag_command() arguments

Argc and argv arguments are used in notmuch_tag_command() function. So unused attribute is not appropriate for them. --- notmuch-tag.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/notmuch-tag.c b/notmuch-tag.c index 44fd61f..36b9b09 100644 --- a/notmuch-tag.c +++

<    1   2   3   4   5   6   7   8   9   10   >