[PATCH v2 3/3] cli: conform to same conditional build style as elsewhere in notmuch-show

2013-03-30 Thread Jani Nikula
Conform to the same style for #ifdef GMIME_ATLEAST_26 conditional builds as elsewhere. There are no functional changes. --- notmuch-show.c | 46 ++ 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index c

[PATCH v2 2/3] cli: mime node: abstract decryption and signature verification

2013-03-30 Thread Jani Nikula
The code filled with #ifdef GMIME_ATLEAST_26 is difficult to read. Abstract the decryption and signature verification into functions, with separate implementations for GMime 2.4 and 2.6, to clarify the code. There should be no functional changes. --- mime-node.c | 218 +++

Re: [PATCH v2 3/6] cli: add --batch option to notmuch count

2013-03-30 Thread Jani Nikula
On Tue, 26 Mar 2013, Jani Nikula wrote: > On Thu, 21 Mar 2013, Jameson Graef Rollins wrote: >> On Sat, Mar 09 2013, Jani Nikula wrote: >>> Add support for reading queries from stdin, one per line, and writing >>> results to stdin, one per line. >> >>

[PATCH v2 0/3] cli: mail-followup-to support

2013-03-30 Thread Jani Nikula
Jani. [1] id:5eaa3acc22ee5513bdce5ab931b7a79ade880e06.1362254104.git.j...@nikula.org [2] id:20130303120745.GA4884@hili.localdomain Jani Nikula (3): cli: config: remove unnecessary braces from if blocks cli: add reply.honor_followup_to configuration option cli: support Mail-Followup-To: in notmuch reply notmuch-client.h |7 +++ n

[PATCH v2 1/3] cli: config: remove unnecessary braces from if blocks

2013-03-30 Thread Jani Nikula
Cosmetic change to drop unnecessary braces that don't even conform to the prevailing coding style. --- notmuch-config.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/notmuch-config.c b/notmuch-config.c index 48312e3..66a1cdf 100644 --- a/notmuch-config.c +++ b

[PATCH v2 2/3] cli: add reply.honor_followup_to configuration option

2013-03-30 Thread Jani Nikula
The reply.honor_followup_to configuration option determines whether notmuch reply takes into account the Mail-Followup-To: header in incoming messages. --- notmuch-client.h |7 +++ notmuch-config.c | 43 +++ 2 files changed, 50 insertions(+) diff

[PATCH v2 3/3] cli: support Mail-Followup-To: in notmuch reply

2013-03-30 Thread Jani Nikula
Use Mail-Followup-To header to determine recipients according to http://cr.yp.to/proto/replyto.html if configured and present in the message being replied to. --- notmuch-reply.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/notmuch-reply.c b/notm

[PATCH v3 0/6] batch count for notmuch-hello speedup

2013-03-31 Thread Jani Nikula
This is v3 of id:cover.1362841844.git.j...@nikula.org, with the commit messages of patches 1/6 and 3/6 fixed. No other changes. Thanks to Jameson and Tomi for review, and of course Mark for the elisp part. BR, Jani. Jani Nikula (5): cli: remove useless talloc_strdup cli: extract count

[PATCH v3 1/6] cli: remove useless talloc_strdup

2013-03-31 Thread Jani Nikula
If the condition holds, query_string_from_args() has already returned a talloc allocated empty string. There's no need to duplicate that. --- notmuch-count.c |4 1 file changed, 4 deletions(-) diff --git a/notmuch-count.c b/notmuch-count.c index 390794f..c2f1b7d 100644 --- a/notmuch-coun

[PATCH v3 2/6] cli: extract count printing to a separate function in notmuch count

2013-03-31 Thread Jani Nikula
Make count printing on a query string reusable. No functional changes. --- notmuch-count.c | 59 +-- 1 file changed, 36 insertions(+), 23 deletions(-) diff --git a/notmuch-count.c b/notmuch-count.c index c2f1b7d..630f036 100644 --- a/notmuch-c

[PATCH v3 3/6] cli: add --batch option to notmuch count

2013-03-31 Thread Jani Nikula
Add support for reading queries from stdin, one per line, and writing results to stdout, one per line. This will bring considerable performance improvements when utilized in Emacs notmuch-hello, especially so when running remote notmuch. --- notmuch-count.c | 52

[PATCH v3 4/6] man: document notmuch count --batch and --input options

2013-03-31 Thread Jani Nikula
--- man/man1/notmuch-count.1 | 20 1 file changed, 20 insertions(+) diff --git a/man/man1/notmuch-count.1 b/man/man1/notmuch-count.1 index 86a67fe..7fc4378 100644 --- a/man/man1/notmuch-count.1 +++ b/man/man1/notmuch-count.1 @@ -46,6 +46,26 @@ Output the number of matching

[PATCH v3 5/6] test: notmuch count --batch and --input options

2013-03-31 Thread Jani Nikula
--- test/count | 46 ++ 1 file changed, 46 insertions(+) diff --git a/test/count b/test/count index 879b114..05713fd 100755 --- a/test/count +++ b/test/count @@ -38,4 +38,50 @@ test_expect_equal \ "0" \ "`notmuch count --output=threads from:

[PATCH v3 6/6] emacs: hello: use batch count

2013-03-31 Thread Jani Nikula
From: Mark Walters This modifies notmuch hello to use the new count --batch functionality. It should give exactly the same results as before but under many conditions it should be much faster. In particular it is much faster for remote use. The code is a little ugly as it has to do some working

Re: [PATCH v4 01/12] tag-util: move out 'tag' command-line checks

2013-03-31 Thread Jani Nikula
On Thu, 24 Jan 2013, Peter Wang wrote: > parse_tag_command_line checked for two error conditions which are > specific to the 'tag' command. It can be reused for the forthcoming > notmuch 'insert' command if we move the checks out, into notmuch-tag.c. FYI, this patch no longer applies to master.

[PATCH 0/3] nmbug-status: add support for querying the search views

2013-04-01 Thread Jani Nikula
These should be helpful in a devel script that I've been hacking. It's surprisingly painful to try to read json from shell scripts. Cheers, Jani. Jani Nikula (3): nmbug-status: simplify config file read from nmbug git nmbug-status: add support for querying the search views nm

[PATCH 2/3] nmbug-status: add support for querying the search views

2013-04-01 Thread Jani Nikula
Make it easy for scripts to read the views and corresponding searches. --- devel/nmbug/nmbug-status | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status index 0283013..d83ca2d 100755 --- a/devel/nmbug/nmbug-stat

[PATCH 1/3] nmbug-status: simplify config file read from nmbug git

2013-04-01 Thread Jani Nikula
This should be functionally the same as before. --- devel/nmbug/nmbug-status | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status index d08ca08..0283013 100755 --- a/devel/nmbug/nmbug-status +++ b/devel/nmbug/nmbug-stat

[PATCH 3/3] nmbug-status: only import notmuch when needed

2013-04-01 Thread Jani Nikula
Make it possible to use the script to query search views without notmuch python bindings installed. --- devel/nmbug/nmbug-status |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status index d83ca2d..775f8ec 100755 --- a/devel/n

Re: [PATCH 1/3] nmbug-status: simplify config file read from nmbug git

2013-04-01 Thread Jani Nikula
On Mon, 01 Apr 2013, David Bremner wrote: > Jani Nikula writes: > >> This should be functionally the same as before. >> --- > > Except that if a local config branch does not exist (but the remote one > does) the old complicated version works, while the new one doe

Re: [PATCH v4 06/12] test: add tests for insert

2013-04-01 Thread Jani Nikula
On Sat, 30 Mar 2013, Peter Wang wrote: > On Fri, 29 Mar 2013 19:59:56 -0400, David Bremner wrote: >> >> It took longer than I thought (of course) but I finally finished looking >> at the first 6 patches. >> >> I already mentioned a minor man page issue in a seperate message. >> >> I took a se

[PATCH] cli: mime node: fix compiler warning when building against gmime 2.4

2013-04-06 Thread Jani Nikula
commit d487ef9e58bcd193118f19f771d5ef3984616be5 Author: Jani Nikula Date: Sat Mar 30 15:53:16 2013 +0200 cli: mime node: abstract decryption and signature verification introduced a compiler warning, reported by Mark Walters, when building against gmime 2.4: mime-node.c:224:9: warning

[PATCH 0/3] config: follow symlinks when saving

2013-04-07 Thread Jani Nikula
This is v4 of [1], adding tests (and some semi-related TODO file updates). The actual code is the same as before. This makes my symlink based dotfiles setup happy. BR, Jani. [1] id:1362320310-10930-1-git-send-email-j...@nikula.org Jani Nikula (3): test: add some config file tests cli

[PATCH 2/3] cli: config: do not overwrite symlinks when saving config file

2013-04-07 Thread Jani Nikula
Use realpath to canonicalize the config path before writing. Previously 'notmuch setup' and 'notmuch config set' overwrote the config file even if it was a symbolic link. --- notmuch-config.c | 24 test/config |1 - 2 files changed, 20 insertions(+), 5 deletion

[PATCH 1/3] test: add some config file tests

2013-04-07 Thread Jani Nikula
Test the --config=FILE option, and add a broken test for writing config file through a symbolic link. --- test/config | 24 1 file changed, 24 insertions(+) diff --git a/test/config b/test/config index cfa1f32..344eced 100755 --- a/test/config +++ b/test/config @@ -57,4

[PATCH 3/3] TODO: remove some completed todo items from the list

2013-04-07 Thread Jani Nikula
Bash completion has been rewritten. Configuration file saves follow symlinks. There is --config=FILE top level option to specify configuration file. --- devel/TODO | 14 -- 1 file changed, 14 deletions(-) diff --git a/devel/TODO b/devel/TODO index e4f36c2..f63385d 100644 --- a/devel

Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

2013-04-08 Thread Jani Nikula
On Mon, 08 Apr 2013, Tomi Ollila wrote: > The most tolerable way is to send new patch series w/ these 2 patches > that apply cleanly on top of current master (661dcf87aeb70) so that the > things that David needs to do are just to run `git am` and `make test`. I'd say just squash the two together.

Re: Compiling fails

2013-04-18 Thread Jani Nikula
On Thu, 18 Apr 2013, David Bremner wrote: > Simonas Kazlauskas writes: > >> Of course `#pragma GCC` has to mean something and might be a reason why >> compiling with `CXX=clang++` fails. > > Yep. clang is not currently supported. I'm not sure how difficult it > would be to get working. Works for

Re: remove unused tags from the database / emacs ui?

2013-04-24 Thread Jani Nikula
On Wed, 24 Apr 2013, ingo wrote: > I have some tags which were created by afew tests, or just misspelling tags. > These tags are now unused, but seem to still be in the database, or cached > in the emacs ui, because I get these tags as possibilities in "add tags" > list. Apparently you still have

Re: [PATCH] don't store temporary value returned from c_str()

2013-04-27 Thread Jani Nikula
On Sat, 20 Apr 2013, vladimir.ma...@oracle.com wrote: > From: Vladimir Marek > > This is causing problems when compiled by Oracle Studio. Memory pointed > by (const char*)term was already changed once talloc_strdup was called. > > Signed-off-by: Vladimir Marek > --- > lib/message.cc |9 -

Re: [PATCH v5 03/12] cli: add insert command

2013-04-27 Thread Jani Nikula
On Wed, 03 Apr 2013, Peter Wang wrote: > The notmuch insert command reads a message from standard input, > writes it to a Maildir folder, and then incorporates the message into > the notmuch database. Essentially it moves the functionality of > notmuch-deliver into notmuch. > > Though it could be

Re: [PATCH v5 04/12] man: document 'insert' command

2013-04-27 Thread Jani Nikula
On Wed, 03 Apr 2013, Peter Wang wrote: > Add initial documentation for notmuch insert command. Of all commands, this man page begs more discussion about the failure modes and exit status. BR, Jani. > --- > man/Makefile.local| 1 + > man/man1/notmuch-insert.1 | 38

Re: [PATCH v5 07/12] insert: add --folder option

2013-04-27 Thread Jani Nikula
On Wed, 03 Apr 2013, Peter Wang wrote: > Allow the new message to be inserted into a folder within the Maildir > hierarchy instead of the top-level folder. > --- > notmuch-insert.c | 47 +-- > 1 file changed, 45 insertions(+), 2 deletions(-) > > diff --

[PATCH] emacs: add kernel.org mail archive redirector

2013-05-02 Thread Jani Nikula
See http://lkml.kernel.org/ --- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index face2a0..423dd58 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -157,6 +157,7 @@ indentation." '(

Re: [PATCH] lib/message.cc: stale pointer bug (v3)

2013-05-02 Thread Jani Nikula
LGTM On Thu, 02 May 2013, vladimir.ma...@oracle.com wrote: > From: Vladimir Marek > > Xapian::TermIterator::operator* returns std::string which is destroyed > as soon as (*i).c_str() finishes. The remembered pointer 'term' then > references invalid memory. > > Signed-off-by: Vladimir Marek > --

[PATCH REBASE] emacs: add show view bindings to move to previous/next thread

2013-05-02 Thread Jani Nikula
We have most of the plumbing in place, add the bindings M-n and M-p. --- emacs/notmuch-show.el | 24 1 file changed, 24 insertions(+) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index face2a0..7f6ea65 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch

Re: [PATCH 01/24] lib/message.cc: stale pointer bug

2013-05-02 Thread Jani Nikula
On Thu, 02 May 2013, Tomi Ollila wrote: > On Thu, May 02 2013, Vladimir Marek wrote: > >>> > int prefix_len = strlen (prefix); >>> > -const char *term = NULL; >>> > +std::string term; >>> > char *value; >>> > >>> > i.skip_to (prefix); >>> > >>> > -if (i != end) >>>

Re: [PATCH 0/2] Enhancements to notmuch-hello search history

2013-05-04 Thread Jani Nikula
On Fri, 03 May 2013, Servilio Afre Puentes wrote: > Two patches that enhance the notmuch-hello search history UI. Though > minor I find them very helpful. Both seem to work as advertised; I did not look at the code much. A minor bikeshed is that I think y-or-n-p would suffice in patch 1/2. BR, J

Re: [PATCH 1/2] test: add tests for the handling of References and In-Reply-To headers

2013-05-04 Thread Jani Nikula
On Wed, 06 Mar 2013, Aaron Ecay wrote: > These tests are known_broken, the following commit fixes them. > --- > > Thanks to David and Tomi for pointing out test_expect_equal_json. In > the process of implementing that, I discovered > notmuch_json_show_sanitize, which I had also not been using. T

Re: [PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-05-04 Thread Jani Nikula
LGTM On Wed, 06 Mar 2013, Aaron Ecay wrote: > Presently, the code which finds the parent of a message as it is being > added to the database assumes that the first Message-ID-like substring > of the In-Reply-To header is the parent Message ID. Some mail clients, > however, put stuff other than

Re: [PATCH 0/2] Enhancements to notmuch-hello search history

2013-05-05 Thread Jani Nikula
On Sun, 05 May 2013, Tomi Ollila wrote: > I agree with Jani that y-or-n-p would suffice for clearing all > recent searches (but yes-or-no-p is not so bad as I originally thought > as C-g can be used to stop processing (typoing 'no' is too easy ;/). > > If we could use "undo" feature to restore la

[PATCH 1/2] test: add basic test for notmuch setup

2013-05-05 Thread Jani Nikula
And annotate with test_subtest_known_broken. Hooray. --- test/notmuch-test |1 + test/setup| 28 2 files changed, 29 insertions(+) create mode 100755 test/setup diff --git a/test/notmuch-test b/test/notmuch-test index ca9c3dc..27a144e 100755 --- a/test/

[PATCH 2/2] cli: config: fix config file save when the file does not exist

2013-05-05 Thread Jani Nikula
The use of realpath(3) in commit 58ed67992d0ec1fa505026105218fa449f7980b0 Author: Jani Nikula Date: Sun Apr 7 20:15:03 2013 +0300 cli: config: do not overwrite symlinks when saving config file broke config file save when the file does not exist, which results in 'notmuch setup&#x

Re: [CLI] bug in notmuch setup

2013-05-05 Thread Jani Nikula
On Mon, 06 May 2013, Patrick Totzke wrote: > As mentioned on IRC earlier, current master seems to have an issue > with `notmuch setup`, which fails to write ~/.notmuch-config if not > already present. Hi Patrick, thanks for the report. This is fixed by id:9971e27c7c3fe569765bbca0f21de128ad1e4fac.

Re: Solaris support - missing or incompatible functions

2013-05-12 Thread Jani Nikula
On Mon, 06 May 2013, vladimir.ma...@oracle.com wrote: > I can't run the notmuch 'make test' on Solaris (too old bash) and on linux the > results are > > 421/525 tests passed. > 25 tests failed. > 79 tests skipped. > > but they are the same without my changes too ... The series LGTM, except I didn'

Re: Solaris support - missing or incompatible functions

2013-05-12 Thread Jani Nikula
On Sun, 12 May 2013, Vladimir Marek wrote: > I didn't pay too much attention to the test output as it's broken on > linux too :) It shouldn't be. All tests pass for me, and we're pretty strict about maintaining that. There may be some prerequisites to running tests that you're missing, and the t

Re: [PATCH 0/3] Allow widen reply

2013-05-12 Thread Jani Nikula
Hi Mark - On Sat, 11 May 2013, Mark Walters wrote: > This is an initial draft of a patch to allow the emacs frontend to > "widen" the reply: i.e., change the headers to reply-to-all after a > reply-to-sender has been started. I didn't look at the patches very much, but I like the idea, a lot. T

[PATCH 0/6] cli: better tooling support for duplicate messages

2013-05-13 Thread Jani Nikula
BR, Jani. Jani Nikula (6): cli: add --duplicate=N option to notmuch search test: test notmuch search --duplicate=N man: document notmuch search --duplicate=N cli: add --output=files option to notmuch count test: test notmuch count --output=files man: document notmuch count --output=f

[PATCH 1/6] cli: add --duplicate=N option to notmuch search

2013-05-13 Thread Jani Nikula
Effective with --output=files, output the Nth filename associated with each message matching the query (N is 0-based). If N is equal to or greater than the number of files associated with the message, don't print anything. --- notmuch-search.c | 18 -- 1 file changed, 12 insertio

[PATCH 2/6] test: test notmuch search --duplicate=N

2013-05-13 Thread Jani Nikula
--- test/search-output | 65 1 file changed, 65 insertions(+) diff --git a/test/search-output b/test/search-output index c2a87eb..3268833 100755 --- a/test/search-output +++ b/test/search-output @@ -239,6 +239,64 @@ MAIL_DIR/cur/01:2, EOF t

[PATCH 3/6] man: document notmuch search --duplicate=N

2013-05-13 Thread Jani Nikula
--- man/man1/notmuch-search.1 | 11 +++ 1 file changed, 11 insertions(+) diff --git a/man/man1/notmuch-search.1 b/man/man1/notmuch-search.1 index da2f1dd..d2a582d 100644 --- a/man/man1/notmuch-search.1 +++ b/man/man1/notmuch-search.1 @@ -154,6 +154,17 @@ but the "match count" is the num

[PATCH 5/6] test: test notmuch count --output=files

2013-05-13 Thread Jani Nikula
--- test/count | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/count b/test/count index 05713fd..da86c8c 100755 --- a/test/count +++ b/test/count @@ -28,6 +28,16 @@ test_expect_equal \ "$((`notmuch search '*' | wc -l`))" \ "`notmuch count --output=threads '*'`" +

[PATCH 4/6] cli: add --output=files option to notmuch count

2013-05-13 Thread Jani Nikula
Add support for querying the total number of files associated with the messages matching the search. This is mostly useful with an id: query for a single message. --- notmuch-count.c | 37 + 1 file changed, 37 insertions(+) diff --git a/notmuch-count.c b/notm

[PATCH 6/6] man: document notmuch count --output=files

2013-05-13 Thread Jani Nikula
--- man/man1/notmuch-count.1 | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/man/man1/notmuch-count.1 b/man/man1/notmuch-count.1 index 7fc4378..60af631 100644 --- a/man/man1/notmuch-count.1 +++ b/man/man1/notmuch-count.1 @@ -23,7 +23,7 @@ Supported options for incl

[PATCH] build: fix out-of-tree builds

2013-05-15 Thread Jani Nikula
Support for out-of-tree builds was added in commit 3e4a9d60a9419621b08c647a306843d76c47c2cb Author: Carl Worth Date: Wed Mar 9 15:02:42 2011 -0800 build: Add support for non-source-directory builds. and broken in commit 7beeb8c88a014ecbc53d8241f10683b3c4c16228 Author: David Bremner Date:

Re: [PATCH] build: fix out-of-tree builds

2013-05-15 Thread Jani Nikula
On Wed, 15 May 2013, David Bremner wrote: > Jani Nikula writes: >> # List all subdirectories here. Each contains its own Makefile.local >> -subdirs := compat completion emacs lib man parse-time-string >> -subdirs += performance-test util test >> +subdirs = compat com

Re: how the date query works?

2013-05-20 Thread Jani Nikula
On Mon, 20 May 2013, David Belohrad wrote: > When I open in emacs search, and I type 'date:today', some output > appears, but not the one I would expect. The date: search expects a Xapian range expression, which requires ".." to be present in the query. For example, date:today..today from beginni

Re: [PATCH 2/4] test: added --stderr=FILE tests

2013-05-24 Thread Jani Nikula
On Thu, 23 May 2013, Tomi Ollila wrote: > --stderr=FILE tests were added to test/help-test as it is the one > doing most global option testing. Also, it was simplest to test > this new option using `notmuch help` command. > --- > > In the future this file (help-test) could be renamed and used in >

Re: [PATCH 2/4] test: added --stderr=FILE tests

2013-05-25 Thread Jani Nikula
On Fri, 24 May 2013, Jani Nikula wrote: > On Thu, 23 May 2013, Tomi Ollila wrote: >> --stderr=FILE tests were added to test/help-test as it is the one >> doing most global option testing. Also, it was simplest to test >> this new option using `notmuch help` command. >&

[PATCH] cli: remove unused argument descriptions

2013-05-25 Thread Jani Nikula
Clean up leftovers from help system rework. These are no longer needed. They are easy to resurrect and update if a need later arises. --- notmuch.c | 13 - 1 file changed, 13 deletions(-) diff --git a/notmuch.c b/notmuch.c index f51a84f..267ce3d 100644 --- a/notmuch.c +++ b/notmuch.

[PATCH v2] build: fix out-of-tree builds

2013-05-25 Thread Jani Nikula
Support for out-of-tree builds was added in commit 3e4a9d60a9419621b08c647a306843d76c47c2cb Author: Carl Worth Date: Wed Mar 9 15:02:42 2011 -0800 build: Add support for non-source-directory builds. and broken in commit 7beeb8c88a014ecbc53d8241f10683b3c4c16228 Author: David Bremner Date:

[PATCH 1/2] emacs: add show view bindings to move to previous/next thread

2013-05-25 Thread Jani Nikula
We have most of the plumbing in place, add the bindings M-n and M-p. --- v2: reduce duplication by adding PREVIOUS argument to notmuch-show-next-thread instead of adding a separate function for moving to previous thread (Mark) --- emacs/notmuch-show.el | 28

[PATCH 2/2] TODO: keybindings for next/previous thread done

2013-05-25 Thread Jani Nikula
--- devel/TODO |2 -- 1 file changed, 2 deletions(-) diff --git a/devel/TODO b/devel/TODO index f63385d..844555e 100644 --- a/devel/TODO +++ b/devel/TODO @@ -34,8 +34,6 @@ current message/thread and make searches not return deleted messages by default, (unless the user asks explicitly for d

Re: [PATCH 1/2] emacs: add show view bindings to move to previous/next thread

2013-05-25 Thread Jani Nikula
On Sat, 25 May 2013, Mark Walters wrote: > Did you want this to not exit back to the search results if you do M-p > on the first result? I attach a version below that does exit back (so > M-p and M-n behave the same. Oh, that was just pure fail from my part. Sorry about that, Mark, and thanks so

[PATCH] NEWS: a bunch of cli news since 0.15

2013-05-26 Thread Jani Nikula
--- NEWS | 31 +++ 1 file changed, 31 insertions(+) diff --git a/NEWS b/NEWS index 8545913..a7f2ec6 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,37 @@ Notmuch 0.16 (2013-MM-DD) Command-Line Interface -- +Decrypting commands explicitly expect a gpg-

[PATCH] NEWS: key bindings for next/previous thread

2013-06-02 Thread Jani Nikula
--- NEWS |5 + 1 file changed, 5 insertions(+) diff --git a/NEWS b/NEWS index 9237e5a..6f09cdb 100644 --- a/NEWS +++ b/NEWS @@ -99,6 +99,11 @@ No Emacs 22 support period of time. After being incomplete for roughly 2 years the code in question was now removed from this release. +Ke

Re: [RFC PATCH] revert: Removed top level --stderr= option

2013-06-03 Thread Jani Nikula
On Fri, 31 May 2013, Tomi Ollila wrote: > While looked good on paper, its attempted use caused confusion, complexity, > and potential for information leak when passed through wrapper scripts. > For slimmer code and to lessen demand for maintenance/support the set of > commits which added top level

Re: New notmuch vim plugin pushed to master

2013-06-03 Thread Jani Nikula
On Mon, 03 Jun 2013, Felipe Contreras wrote: > The old plugin has been deprecated and moving to contrib. The new > plugin has much better support and should replace it for all intents > and purposes. Felipe, even though I don't personally use it, I'm glad you're working on the vim plugin. The old

[PATCH] emacs: update search sort order help to match code

2013-06-03 Thread Jani Nikula
--- emacs/notmuch-lib.el |7 ++- emacs/notmuch.el | 13 ++--- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index 28f78e0..c43d5a9 100644 --- a/emacs/notmuch-lib.el +++ b/emacs/notmuch-lib.el @@ -68,7 +68,12 @@

Re: cli: add --include-html option to notmuch show

2013-08-24 Thread Jani Nikula
On Sun, 18 Aug 2013, Tomi Ollila wrote: > Now, if we have --include-html should it be like that or > --include-html=(true|false). Currently we have both cases, adding > --verify, --decrypt, --create-folder, --batch, -no-hooks to the > set... I cannot get a clear opinion (without wast^H^H^H^H spen

Re: [Bug] Force creating of Mail/sent on sending?

2013-08-24 Thread Jani Nikula
On Sat, 24 Aug 2013, Bastien wrote: > My configuration is here: http://bzg.fr/emacs.html (browse down to the > notmuch section, click on it.) Your configuration seems, well, non-trivial. > If I require 'notmuch, then sending from Gnus asks me whether I want > to create Mail/sent -- I don't want

Re: [PATCH] emacs: bugfix notmuch-mua-reply when signature is present

2013-08-26 Thread Jani Nikula
On Mon, 19 Aug 2013, Tomi Ollila wrote: > On Fri, Aug 09 2013, Tomi Ollila wrote: > >> On Thu, Aug 08 2013, Geoffrey Ferrari >> wrote: >> >>> From: "Geoffrey H. Ferrari" >>> >>> When composing a reply, notmuch-mua-reply tries to be smart and cite >>> the original message by inserting it before

Re: Feature proposal: OUTPUT_AUTHOR format

2013-08-26 Thread Jani Nikula
On Aug 27, 2013 3:27 AM, "David Bremner" wrote: > > Johannes Kulick writes: > > > An authors output format would not add redundant information to a mail, would be > > relatively easy to implement and I would find a people centric view - which > > doesn't interfere with any other concept of notmuc

[PATCH v2] emacs: insert quotable parts in reply as they are displayed in show view

2013-08-27 Thread Jani Nikula
In reply, insert quotable parts using notmuch-show-insert-bodypart instead of calling notmuch-mm-display-part-inline directly to render the quoted parts as they are rendered in show view. The notable change is that replies to text/calendar parts quote the pretty printed output of icalendar-import-

[PATCH 1/2] emacs: simplify point placement for inserting message body on reply

2013-08-28 Thread Jani Nikula
The backwards regexp was most likely just old cruft. Simply put the point at the beginning of message body. It's guaranteed to be before the signature. --- emacs/notmuch-mua.el |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.e

[PATCH 0/2] emacs: simplify and cleanup notmuch-mua-reply

2013-08-28 Thread Jani Nikula
This is an alternative to [1]. I tried to dig through history, and I couldn't find a decent reason for having the backwards regexp in place. BR, Jani. [1] id:1375961732-14327-1-git-send-email-geoffrey.ferr...@oriel.oxon.org Jani Nikula (2): emacs: simplify point placement for inse

[PATCH 2/2] emacs: slightly cleanup the reply code

2013-08-28 Thread Jani Nikula
Since the starting point for the original message can now be found with the simple (message-goto-body), there's no need to save point. Drop the extra let block. No functional changes. --- emacs/notmuch-mua.el | 35 +-- 1 file changed, 17 insertions(+), 18 deletion

Re: [PATCH] emacs: bugfix notmuch-mua-reply when signature is present

2013-08-28 Thread Jani Nikula
On Wed, 28 Aug 2013, Tomi Ollila wrote: > On Wed, Aug 28 2013, Tomi Ollila wrote: > >> On Thu, Aug 08 2013, Geoffrey Ferrari >> wrote: >> >>> From: "Geoffrey H. Ferrari" >>> >>> When composing a reply, notmuch-mua-reply tries to be smart and cite >>> the original message by inserting it before

Re: [PATCH] emacs: bugfix notmuch-mua-reply when signature is present

2013-08-28 Thread Jani Nikula
On Wed, 28 Aug 2013, Jani Nikula wrote: > -- > whoaaa > > asdfasfd And this is me toying with the signature that I don't usually have... oops. :) Cheers, Jani. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org

[PATCH v2] emacs: insert quotable parts in reply as they are displayed in show view

2013-08-29 Thread Jani Nikula
In reply, insert quotable parts using notmuch-show-insert-bodypart instead of calling notmuch-mm-display-part-inline directly to render the quoted parts as they are rendered in show view. The notable change is that replies to text/calendar parts quote the pretty printed output of icalendar-import-

[RFC PATCH 1/2] cli: add support for global options that get passed to sub-commands

2013-08-31 Thread Jani Nikula
This allows sub-commands to have access to global options. --- notmuch-client.h | 21 + notmuch-config.c | 29 + notmuch.c| 10 ++ 3 files changed, 60 insertions(+) diff --git a/notmuch-client.h b/notmuch-client.h index afb0ddf

[RFC PATCH 2/2] cli: use global verbose, debug, and no-hooks options in notmuch new

2013-08-31 Thread Jani Nikula
Deprecate the old notmuch new options, but keep them around for a transitional period, overriding the top level options. --- notmuch-new.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/notmuch-new.c b/notmuch-new.c index faa33f1..d425103 100

Re: [PATCH] man/Makefile.local: allow out-of-tree 'make install'.

2013-09-01 Thread Jani Nikula
On Sun, 04 Aug 2013, Rory Yorke wrote: > I see the gzipped man files end up in the source tree; I guess ideally > they'd be in the build tree? Yes; the main point of out-of-tree builds and installs is not to touch the source tree. While I don't have a fix to offer to solve the problem, I'm afraid

Re: [PATCH 1/3] database: Add notmuch_database_compact_close

2013-09-01 Thread Jani Nikula
On Sat, 24 Aug 2013, Ben Gamari wrote: > This function uses Xapian's Compactor machinery to compact the notmuch > database. The compacted database is built in a temporary directory and > later moved into place while the original uncompacted database is > preserved. > > Signed-off-by: Ben Gamari >

[PATCH] emacs: insert quotable parts in reply as they are displayed in show view

2013-09-01 Thread Jani Nikula
In reply, insert quotable parts using notmuch-show-insert-bodypart instead of calling notmuch-mm-display-part-inline directly to render the quoted parts as they are rendered in show view. We use a temp buffer to not leak text properties from the show renderer into the reply. This way we also don't

Re: [PATCH 0/3] Adding non-maildir tags does not move message from new to cur

2013-09-02 Thread Jani Nikula
On Wed, 19 Dec 2012, Michal Sojka wrote: > patches in this series should supersede the patches in > id:1316039001-32602-5-git-send-email-l.rill...@av7.net. They address > the comments from Jani Nikula and add tests for the behavior that was > unintentionally changed by the previous ve

[PATCH 2/2] test: improve insert test reliability by checking message-id instead of count

2013-09-02 Thread Jani Nikula
There isn't a reported issue this would fix. Spotted by reading the test. --- test/insert | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/insert b/test/insert index 9b448e5..550b413 100755 --- a/test/insert +++ b/test/insert @@ -68,14 +68,14 @@ test_expect_equ

[PATCH 1/2] test: add more maildir flag syncing related tests to insert

2013-09-02 Thread Jani Nikula
Specifically test maildir flag syncing with insert. --- These are additional tests on top of David's fix. --- test/insert | 36 1 file changed, 36 insertions(+) diff --git a/test/insert b/test/insert index 1718120..9b448e5 100755 --- a/test/insert +++ b/test

Re: [PATCH] test: update insert tests for new maildir synchronization rules

2013-09-02 Thread Jani Nikula
On Tue, 03 Sep 2013, da...@tethera.net wrote: > From: David Bremner > > As of id:1355952747-27350-4-git-send-email-sojk...@fel.cvut.cz > we are more conservative about moving messages from ./new to ./cur. > This updates the insert tests to match > --- > > Hopefully this makes sense, and is not jus

Re: [PATCH 1/2] test: add more maildir flag syncing related tests to insert

2013-09-03 Thread Jani Nikula
On Tue, 03 Sep 2013, David Bremner wrote: > Jani Nikula writes: >> >> +test_begin_subtest "Insert message with default tags stays in new/" >> +gen_insert_msg >> +notmuch insert < "$gen_msg_filename" >> +output=$(notmuch search --out

Re: [PATCH 1/1] emacs: fix notmuch-mua-reply point placement when signature involved

2013-09-05 Thread Jani Nikula
On Wed, 04 Sep 2013, "Tomi.Ollila" wrote: > From: Tomi Ollila > > When composing a reply, notmuch-mua-reply attempts to cite the > the original message by inserting it before the user signature, if > one is present. The existing method used to search the signature > separator backward from the e

Re: [PATCH 1/1] emacs: fix notmuch-mua-reply point placement when signature involved

2013-09-05 Thread Jani Nikula
On Thu, 05 Sep 2013, Tomi Ollila wrote: > On Thu, Sep 05 2013, Jani Nikula wrote: > >> On Wed, 04 Sep 2013, "Tomi.Ollila" wrote: >>> From: Tomi Ollila >>> >>> When composing a reply, notmuch-mua-reply attempts to cite the >>> the orig

[PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init()

2013-09-10 Thread Jani Nikula
As explained by Jeffrey Stedfast, the author of GMime, quoted in [1]: > Passing the GMIME_ENABLE_RFC2047_WORKAROUNDS flag to g_mime_init() > *should* solve the decoding problem mentioned in the thread. This > flag should be safe to pass into g_mime_init() without any bad side > effects and my unit

[PATCH v2 2/2] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init()

2013-09-11 Thread Jani Nikula
As explained by Jeffrey Stedfast, the author of GMime, quoted in [1]: > Passing the GMIME_ENABLE_RFC2047_WORKAROUNDS flag to g_mime_init() > *should* solve the decoding problem mentioned in the thread. This > flag should be safe to pass into g_mime_init() without any bad side > effects and my unit

[PATCH v2 1/2] test: add known broken tests for known broken RFC 2047 encodings

2013-09-11 Thread Jani Nikula
Some common broken RFC 2047 encodings that we currently let gmime parse strictly. We could tell gmime to be forgiving in what it accepts as RFC 2047 encoding, making these tests pass. --- test/encoding | 18 ++ 1 file changed, 18 insertions(+) diff --git a/test/encoding b/test/enc

Re: [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init()

2013-09-11 Thread Jani Nikula
On Wed, 11 Sep 2013, Austin Clements wrote: > LGTM in principle, though I'd like to see a test of some of the > malformed RFC 2047 that this lets us decode. Is there a summary > somewhere of exactly what these workarounds enable? Not that I know of; looking into gmime source it's mostly about en

Re: [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init() a test

2013-09-11 Thread Jani Nikula
On Wed, 11 Sep 2013, Daniel Kahn Gillmor wrote: > On 09/10/2013 06:35 PM, Austin Clements wrote: > >> I haven't looked at exactly what workarounds this enables, but if it's >> what I'm guessing (RFC 2047 escapes in the middle of RFC 2822 text >> tokens), are there really subject lines that this wi

Re: UTF-8 in mail headers (namely FROM) sent by bugzilla

2013-10-05 Thread Jani Nikula
On Tue, 23 Jul 2013, Franz Fellner wrote: > Hi, > > I have a problem with notmuch-vim (now: git master from 10 min. ago) (also > with alot and ner, not with 'notmuch show' or notmuch-emacs). UTF-8-encoded > From: (at least) does not show Umlauts but a weird encoded-string. > Example: > "Thomas L

Re: Emacs: how to remove "unread" tag while reading emails

2013-10-06 Thread Jani Nikula
On Sat, 05 Oct 2013, Austin Clements wrote: > One of the problems with the current approach, which most of these > options share, is that there's no feedback. For example, when I enter > a thread, I have no idea if the first message was unread or not. Agreed. And this gets repeated for navigatin

Re: [PATCH 07/11] emacs: Use notmuch tag --batch for large tag queries

2013-10-09 Thread Jani Nikula
On Tue, 08 Oct 2013, Austin Clements wrote: > (Unfortunately, it's difficult to first demonstrate this problem with > a known-broken test because modern Linux kernels have argument length > limits in the megabytes, which makes Emacs really slow!) > --- > emacs/notmuch-lib.el | 8 > emac

<    2   3   4   5   6   7   8   9   10   11   >