Also do so for some 'if' forms that lack an ELSE part.
Even go as far as using 'and' and 'not' instead of 'unless'.
---
emacs/coolj.el | 12 +++---
emacs/notmuch-address.el | 72 ++--
emacs/notmuch-crypto.el | 2 +-
emacs/notmuch-draft.el
---
NEWS | 2 +-
bindings/python-cffi/notmuch2/__init__.py | 2 +-
bindings/python-cffi/notmuch2/_base.py | 6 +++---
bindings/python-cffi/notmuch2/_database.py | 8
bindings/python-cffi/notmuch2/_message.py | 4 ++--
Fix it to consistently match the style we have configured in
".dir-locals.el".
---
test/test-lib.sh | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 90e26639..a4058660 100644
--- a/test/test-lib.sh
---
emacs/notmuch-address.el | 8 ++--
emacs/notmuch-compat.el | 6 +--
emacs/notmuch-hello.el | 8 ++--
emacs/notmuch-jump.el| 54 ++---
emacs/notmuch-lib.el | 10 ++--
emacs/notmuch-mua.el | 24 +-
emacs/notmuch-query.el | 4 +-
---
emacs/notmuch-company.el | 36 +++--
emacs/notmuch-compat.el | 15 ++
emacs/notmuch-crypto.el | 2 +-
emacs/notmuch-lib.el | 2 --
emacs/notmuch-maildir-fcc.el | 39 ++--
emacs/notmuch-print.el
- The first sentence should fit on the first line in full. This is
even the case when that causes the line to get a bit long. If it
gets very long, then it should be made shorter.
- Even even the second sentence would fit on the first line, if it
just provides some details, then it
---
emacs/make-deps.el | 3 ++-
emacs/notmuch-lib.el| 8 +++-
emacs/notmuch-parser.el | 9 +++--
emacs/notmuch-show.el | 18 +++---
emacs/rstdoc.el | 9 -
test/test-lib.el| 31 +++
6 files changed, 34
Use `makefile-gmake-mode' instead of `makefile-mode' because the
former also highlights ifdef et al. while the latter does not.
"./Makefile.global" and one "Makefile.local" failed to specify any
major mode at all but doing so is necessary because Emacs does not
automatically figure out that these
---
emacs/notmuch-tag.el | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
index e71de041..1cef17e1 100644
--- a/emacs/notmuch-tag.el
+++ b/emacs/notmuch-tag.el
@@ -32,9 +32,10 @@ (require 'crm)
(require 'notmuch-lib)
The first commit didn't do what the commit message claimed, as pointed
out by David. I have fixed that, and also a second issue that I have
missed because I still had some parts of 'mml-sec.el' commented out
when testing the fixes to the tests... it was a long day.
Jonas Bernoulli (3
Starting with Emacs 27 undeclared variables in evaluated interactive
code uses lexical scope. This includes code passed with '--eval' as
we do in the Emacs tests, which also happen to assume dynamic scope.
This can affect variables defined by libraries that we use. We let-
bind such variables
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 1c8705ec..8f3ebec0 100644
--- a/.gitignore
+++ b/.gitignore
@@ -17,3 +17,4 @@ tags
/.stamps
*.stamp
/bindings/python-cffi/build/
+/sphinx.config
--
2.26.0
Since Emacs 27 'mml-secure-epg-sign' errors out if we don't opt-in to
signing as the sender using 'mml-secure-openpgp-sign-with-sender'.
---
test/test-lib.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 8c331b88..31c858d1 100644
Sean Whitton writes:
> On Sun 26 Jul 2020 at 06:58PM +02, Jonas Bernoulli wrote:
>
>> Also do so for some 'if' forms that lack an ELSE part.
>> Even go as far as using 'and' and 'not' instead of 'unless'.
>
> I don't follow "when the return value matters"
Starting with Emacs 27 undeclared variables in evaluated interactive
code uses lexical scope. This includes code passed with '--eval' as
we do in the Emacs tests, which also happen to assume dynamic scope.
- This can affect variables defined by libraries that we use. We
let-bind such
The goal of this abstraction was to save space. But that failed as
the result actually was that four trivial lines got replace with 15
fairly complicated lines. The opposite of what it was supposed to
do.
Also it made it harder to come up with the fix in the previous commit;
simply grepping for
This reroll explains why the variable's default value is -100.
It also adds an additional commit, which removes a misguided
abstraction that is related to those very same variables.
Jonas Bernoulli (4):
gitignore: Ignore generated sphinx.config
test: Deal with Emacs 27 switching to lexical
Since Emacs 27 'mml-secure-epg-sign' errors out if we don't opt-in to
signing as the sender using 'mml-secure-openpgp-sign-with-sender'.
---
test/test-lib.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 8c331b88..31c858d1 100644
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 1c8705ec..8f3ebec0 100644
--- a/.gitignore
+++ b/.gitignore
@@ -17,3 +17,4 @@ tags
/.stamps
*.stamp
/bindings/python-cffi/build/
+/sphinx.config
--
2.26.0
Tomi Ollila writes:
> On Sun, Jul 26 2020, Jonas Bernoulli wrote:
>> ;; Outer single and double quotes, which might be nested.
>> (cl-loop with start-of-loop
>> - do (setq start-of-loop p-name)
>> -
>> + do (setq start-of-l
Tomi Ollila writes:
> On Sun, Jul 26 2020, Jonas Bernoulli wrote:
>
>> ---
>> .gitignore | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 1c8705ec..8f3ebec0 100644
>> --- a/.gitignore
>> +
Tomi Ollila writes:
> On Sun, Jul 26 2020, Jonas Bernoulli wrote:
>> (defun notmuch-maildir-add-file-style-fcc-header (subdir)
>> @@ -249,9 +250,8 @@ (defun notmuch-maildir-fcc-with-notmuch-insert
>> (fcc-header create)
>>;; typo, or just the user want
Sean Whitton writes:
> Hello,
>
> On Mon 27 Jul 2020 at 12:02AM +02, Jonas Bernoulli wrote:
>
>> Sean Whitton writes:
>>
>>> On Sun 26 Jul 2020 at 06:58PM +02, Jonas Bernoulli wrote:
>>>
>>>> Also do so for some 'if' form
Teemu Likonen writes:
> Emacs face definition forms are either
>
> ((DISPLAY . PLIST)
> (DISPLAY . PLIST))
>
> or
>
> ((DISPLAY PLIST) ;For backward compatibility.
> (DISPLAY PLIST))
>
> Commit a2388bc56e55da5d5695816818274f8a84b0ed92 (2020-08-08) follows
> neither of the
Tomi Ollila writes:
> Note that messages
>
> 20210110140112.25930-11-jo...@bernoul.li and
> 20210110140112.25930-12-jo...@bernoul.li
>
> have base64 -encoded content, with CRLF line endings
> so those don't apply as is, but CR's from the encoded
> content must be deleted.
Do you know why git
David Bremner writes:
> Apologies for the delay, I missed the second review.
No problem, I probably should just have pinged after a week or so.
Will do that next time. Sorry for being slow to respond myself!
By the way, you seem to have missed some more patch series of mine:
-
Commonly `set' is only used if there is no way around it;
i.e. when the variable cannot be known until runtime.
---
emacs/notmuch-tree.el | 2 +-
emacs/notmuch.el | 14 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-tree.el
ssary"
these bindings are is somewhat subjective.
Cheers,
Jonas
PS: Don't worry. I do NOT have another large patch series waiting
after this. Future changes should be more focused or even come
in the form of independent extensions.
Jonas Bernoulli (32):
emacs: use se
We no longer support Emacs releases before version 25.1.
Also adjust the sentinels which only had to deal with
an error file when using an older Emacs release was used.
---
emacs/notmuch-lib.el | 64
1 file changed, 17 insertions(+), 47 deletions(-)
These functions are used as action/notify functions. That dictates
the appropriate function signatures but even though these functions
are not used for anything else they use incompatible signatures,
forcing the callers to use lambda expressions to deal with these
incompatibilities.
Fix that by
In practice this probably does not make a difference or we would
have heard about it many times, but better be safe than sorry.
Process sentinels are called not only when the process has finished
but also on other state changes.
---
emacs/notmuch-lib.el | 7 ---
1 file changed, 4
The buffer of the error process is accessible using `process-buffer'.
We still have to store the error-buffer in the non-error process
because for that process `process-buffer' obviously returns its own
buffer.
---
emacs/notmuch-lib.el | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
This is complex enough to warrant a dedicated widget type,
which will make future improvements less messy to implement.
---
emacs/notmuch-hello.el | 92 +-
1 file changed, 45 insertions(+), 47 deletions(-)
diff --git a/emacs/notmuch-hello.el
When running "notmuch" we use its full path but when displaying the
command to the user we show just its name for readability reasons.
Avoid passing around both representations because it is very easy
to get the name from the path.
Notmuch itself uses the involved functions just for "notmuch" but
Doing so causes many new compile warnings. Some of these warnings
concern genuine changes in behavior that have to be addressed right
away.
Many other warnings are due to unused variables. Nothing has changed
here, except that the byte-compiler can now detect these pre-existing
and harmless
The previous commit switched to lexical-binding but without dealing
with the new warnings about unused lexical arguments and variables.
This commit deals with most of them, in most cases by either removing
leftover bindings that are actually unnecessary, or by marking certain
arguments as "known
`format-alist' is a global variable and the byte-compiler is unhappy
when a lexical function argument shadows a global (dynamic) binding.
---
emacs/notmuch-tag.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
index
That's what we usually do. Also do not declare variable
`diff-file-header-re' because it is defined in `diff-mode.el',
which we always require.
---
emacs/notmuch-wash.el | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el
index
This is how we do it in other libraries.
---
emacs/notmuch-mua.el | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 2d0b7169..74ffd8f2 100644
--- a/emacs/notmuch-mua.el
+++
`notmuch-show-insert-part-text/plain' calls
`notmuch-show-insert-text/plain-hook' with two arguments
MSG and DEPTH. Currently all hook functions ignore MSG but
third-party functions may not. One hook function uses DEPTH.
---
emacs/notmuch-wash.el | 8
1 file changed, 4 insertions(+), 4
This function had a few issues.
- Neither its name nor the old comment before it is called made it
clear what it does.
- It took one argument but didn't do anything with it.
- It's doc-string made a few claims, which are untrue and generally
focused on details instead of that its purpose is.
---
emacs/notmuch-lib.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 76387779..21fa2582 100644
--- a/emacs/notmuch-lib.el
+++ b/emacs/notmuch-lib.el
@@ -956,7 +956,8 @@ (defun notmuch-start-notmuch-sentinel (proc event)
---
emacs/notmuch-lib.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 21fa2582..06ca8cdc 100644
--- a/emacs/notmuch-lib.el
+++ b/emacs/notmuch-lib.el
@@ -917,7 +917,8 @@ (defun notmuch-start-notmuch (name buffer sentinel
Unfortunately that means we have to explicitly require subr-x, which
arguably should always be loaded without packages having to require
it, but the Emacs developers decided otherwise. Loading it explicitly
most likely comes without any additional cost because almost certainly
some other packages
---
emacs/notmuch-draft.el | 12 ++-
emacs/notmuch-maildir-fcc.el | 21 +-
emacs/notmuch-mua.el | 9
emacs/notmuch-tag.el | 41 ++--
emacs/notmuch-tree.el| 10 -
emacs/notmuch.el |
When called from code, then this function returns non-nil when the
message at point is a matched message. However it does nothing at all
to present that information to the user when it called interactively.
It is therefore safe to conclude that nobody is using this as a
command.
---
`outline-minor-mode' treats comments that begin with three or more
semicolons as headings. That makes it very convenient to navigate
code and to show/hide parts of a file.
Elips libraries typically have four top-level sections, e.g.:
;;; notmuch.el --- run notmuch within emacs...
;;;
---
emacs/notmuch.el | 41 -
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 0fb9874b..24b930bf 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -70,6 +70,8 @@ (eval-when-compile (require
---
emacs/notmuch-address.el | 22 --
emacs/notmuch-hello.el | 24 ---
emacs/notmuch-jump.el| 4 +-
emacs/notmuch-lib.el | 26 +--
emacs/notmuch-maildir-fcc.el | 61 +++---
emacs/notmuch-mua.el | 28 ++--
The value is the only possible value, it is only used in one
place, and using a global variable serves no purpose but to
make things more complicated.
---
emacs/notmuch.el | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index
The "help-echo" can potentially contain an unintended %-spec
so we have to make sure it would not be treated as such.
---
emacs/notmuch-crypto.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
index 50a3de46..db7cb75d 100644
No longer use the function `notmuch-search-get-query', which does
nothing but return the value of that variable. That function was
added in [1: f47eeac0] for use in `notmuch-read-query' along-side
related `notmuch-show-get-query' and `notmuch-tree-get-query' but
using it here makes little sense.
Define these variables as automatically buffer-local, meaning that
they always become buffer-local when set unless explicitly told
otherwise using `setq-default' or when using the Custom interface.
Previously they were declared, which keeps the byte-compiler quiet but
is not actually the same as
To some extend this is a personal preference, but the preference is
strongly dependent on whether one is used to a language that makes it
necessary to use variables like this.
This makes it perfectly clear that we are first getting and then using
a "foo":
(use-foo (get-foo))
Sure this has to
---
emacs/notmuch-wash.el | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el
index 36041904..4fbb4e12 100644
--- a/emacs/notmuch-wash.el
+++ b/emacs/notmuch-wash.el
@@ -200,7 +200,7 @@ (defun notmuch-wash-button-label
---
emacs/notmuch-message.el | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el
index 9dc8d056..abeff53a 100644
--- a/emacs/notmuch-message.el
+++ b/emacs/notmuch-message.el
@@ -62,9 +62,8 @@ (defvar-local
---
emacs/notmuch-address.el | 5 ++---
emacs/notmuch-hello.el | 4 +---
emacs/notmuch-lib.el | 6 +++---
3 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el
index 2f0ec9b3..1f22e377 100644
--- a/emacs/notmuch-address.el
+++
Also improve the doc-string.
---
emacs/notmuch-message.el | 14 +++---
emacs/notmuch-mua.el | 12 ++--
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el
index f0e9ffcc..9dc8d056 100644
---
We shouldn't force `ido-completion-read' on users who do not otherwise
use Ido. Unfortunately simply turning on `ido-mode' does not change
every `completing-read' into a `ido-completing-read', instead it only
changes file and buffer completion.
I do realize that existing Ido users will initially
This reverts commit f9fbd1ee3bfd679175d88af403752d87a730349f.
Emacs provides a mechanism for avoiding wiping out buffer-local
variables: marking them as "permanent local", which essentially
means "don't wip out the local value when enabling major-mode".
(put 'the-variable 'permanent-local t)
I did it again; looked at some code and cleaned it up along the way.
Cheers,
Jonas
Jonas Bernoulli (27):
emacs: silence byte-compiler
emacs: define notmuch-message-mode-map explicitly
emacs: add doc-string to notmuch-tree-mode-map
emacs: don't fset keymaps
emacs: remove
Key bindings should not be defined at the top-level but inside
a `defvar' form. Doing it at the top-level makes it harder to
reliably customize key bindings.
---
emacs/notmuch-mua.el | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/emacs/notmuch-mua.el
Notmuch requires at least Emacs version 25.
The `return-action' argument was added prior to Emacs 24.1
in 25ca2e61403f97b5a023164f2924d5f8aca2492a.
---
emacs/notmuch-mua.el | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
Previously it was defined in "notmuch-hello.el" and its name contained
"hello" solely because it replaced an anonymous function that was
mistakenly only bound in `notmuch-hello-mode-map'. But it makes more
sense to bind it in all notmuch modes and even if we did not change
that aspect it still
---
emacs/notmuch-address.el | 6 +++---
emacs/notmuch-crypto.el | 4 ++--
emacs/notmuch-mua.el | 7 ---
3 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el
index 561cc140..04353522 100644
--- a/emacs/notmuch-address.el
+++
Notmuch requires at least version 25 of Emacs now.
Adjust comments that previously referenced version 24 specifically,
even though they also apply to later releases. Remove documentation
and code that no longer applies.
- `mm-shr' no longer references `gnus-inhibit-images'.
---
This fixes a regression introduced in [1: 7e20d264]. If the argument
RETURN-ACTION was non-nil then we should pass along the value of that
argument. Instead we passed along the constant symbol `return-action'.
1: 7e20d26480553f57d53bd9ec28cae163c1ac91e3
emacs: Fix mail composition under
---
emacs/notmuch-tree.el | 5 +
1 file changed, 5 insertions(+)
diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index f342f85a..7b1e34ca 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -42,6 +42,11 @@ (declare-function notmuch-read-query "notmuch" (prompt))
---
emacs/notmuch-draft.el | 6 +++---
emacs/notmuch-maildir-fcc.el | 10 +-
emacs/notmuch-mua.el | 6 +++---
emacs/notmuch-show.el| 2 +-
emacs/notmuch-tag.el | 2 +-
5 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/emacs/notmuch-draft.el
---
emacs/notmuch-address.el | 31 ++
emacs/notmuch-hello.el | 28 +
emacs/notmuch-lib.el | 38 +
emacs/notmuch-mua.el | 10 ++---
emacs/notmuch-tag.el | 2 +-
emacs/notmuch.el | 88
6 files
It is available since Emacs 24.3 and we require at least Emacs 25.
---
emacs/coolj.el | 4 +---
emacs/notmuch-company.el | 4 ++--
emacs/notmuch-draft.el | 3 +--
emacs/notmuch-lib.el | 8 ++--
emacs/notmuch-show.el| 18 ++
emacs/notmuch-tree.el| 27
Emacs doc-strings use neither markdown nor lisp symbol quoting.
---
emacs/notmuch-address.el | 2 +-
emacs/notmuch-draft.el | 8
emacs/notmuch-hello.el | 4 ++--
emacs/notmuch-maildir-fcc.el | 2 +-
emacs/notmuch-tag.el | 20 ++--
---
emacs/notmuch-hello.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 69d0ad64..003bec33 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -282,7 +282,7 @@ (defcustom notmuch-hello-refresh-hook nil
We could just have switched to using `cl-remove-if-not' instead,
but the two uses of the *remove-if-not function are pretty strange
to begin with so we refactor to not use any such function at all.
---
emacs/notmuch-hello.el | 43 --
emacs/notmuch-lib.el
One should never bind unnamed commands in keymaps because doing that
makes it needlessly hard for users to change these bindings.
Replace such anonymous bindings with named commands that are generated
using macros and some boilerplate. Using macros is better than using a
simple loop because that
It is available since Emacs 24.3 and we require at least Emacs 25.
It makes the variable buffer-local if it isn't always buffer-local
anyway.
---
emacs/notmuch-company.el | 3 +--
emacs/notmuch-parser.el | 5 ++---
emacs/notmuch.el | 2 +-
3 files changed, 4 insertions(+), 6 deletions(-)
This trivial helper function actually made things slightly
*less* readable by adding an unnecessary indirection.
---
emacs/notmuch-lib.el | 8 ++--
emacs/notmuch-show.el | 16
2 files changed, 10 insertions(+), 14 deletions(-)
diff --git a/emacs/notmuch-lib.el
Commonly `set' is only used if there is no way around it;
i.e. when the variable cannot be known until runtime.
---
emacs/notmuch-tree.el | 2 +-
emacs/notmuch.el | 14 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-tree.el
We stopped using it in [1: 0e671478].
1: 0e671478c6f37018973392f049979da5e1a8ff99
emacs: replace use of notmuch-address-message-insinuate
---
emacs/notmuch-address.el | 19 ---
1 file changed, 19 deletions(-)
diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el
Since [1: f8bdba37] no key is bound to this command and it is
redundant because the behavior of `push-command' is identical
when called as a command.
1: f8bdba37d3f4c877e05e17b5b1c7d2d512106538
emacs: tree: remove binding for pressing button in message pane
---
emacs/notmuch-tree.el | 8
Inline a simplified version of `notmuch-documentation-first-line'
into its only caller. The new code snippet differs from the
removed function in that it returns nil instead of the empty string
for symbols that have no function documentation. That value is
ultimately used as an argument to
It has been deprecated for a decade and it's time to let go.
---
emacs/notmuch-hello.el | 5 -
1 file changed, 5 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index bc07c29c..f5d9e0ec 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -987,11
These keymaps are never invoked as commands
so the function definitions serve no purpose.
---
emacs/notmuch-show.el | 1 -
emacs/notmuch-tree.el | 1 -
emacs/notmuch.el | 1 -
3 files changed, 3 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index b08ceb97..ec22fd94
---
emacs/notmuch-crypto.el | 3 +--
emacs/notmuch-hello.el | 3 +--
emacs/notmuch-mua.el| 11 ---
3 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
index 276c9859..4fab215a 100644
--- a/emacs/notmuch-crypto.el
+++
The first sentence should fit on the first line. It is okay if
the first sentence/line does not contain all the information that
the rest of the doc-string covers.
---
emacs/notmuch-show.el | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-show.el
---
emacs/notmuch-tree.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index 7b1e34ca..ea6a5cf3 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -359,7 +359,8 @@ (defvar notmuch-tree-mode-map
(define-key
Use `string-trim', which exists since Emacs 24.4.
---
emacs/notmuch-hello.el | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index bb60a890..b67a5e19 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@
---
emacs/notmuch-mua.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 49bad00d..9d08c2c9 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -62,8 +62,8 @@ (defcustom notmuch-mua-compose-in 'current-window
Sebastian Fischmeister writes:
> For some time already I experience a slowdown of the emacs notmuch
> interface over time.
Please check if my recent patch in
id:20201108174929.1227-1-jo...@bernoul.li fixes that.
Cheers,
Jonas
___
notmuch
William Casarin writes:
> LGTM, I have a similar patch here: id:20200908171536.20679-1-j...@jb55.com
So if I understood correctly the problem with that was that you were
unable to run the tests and therefore couldn't confirm that you fixed
the issue or even that there was an issue in the first
David Edmondson writes:
> On Sunday, 2020-11-08 at 20:02:57 +01, Jonas Bernoulli wrote:
>
> With a suggested rewording below...
>
> Reviewed-by: David Edmondson
>
>> ---
>> emacs/notmuch-crypto.el | 3 +--
>> emacs/notmuch-hello.el | 3 +--
>> emac
We could just have switched to using `cl-remove-if-not' instead,
but the two uses of the *remove-if-not function are pretty strange
to begin with so we refactor to not use any such function at all.
---
emacs/notmuch-hello.el | 43 --
emacs/notmuch-lib.el
---
emacs/notmuch-hello.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 69d0ad64..003bec33 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -282,7 +282,7 @@ (defcustom notmuch-hello-refresh-hook nil
This fixes a regression introduced in [1: 7e20d264]. If the argument
RETURN-ACTION was non-nil then we should pass along the value of that
argument. Instead we passed along the constant symbol `return-action'.
1: 7e20d26480553f57d53bd9ec28cae163c1ac91e3
emacs: Fix mail composition under
Use `string-trim', which exists since Emacs 24.4.
---
emacs/notmuch-hello.el | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index bb60a890..b67a5e19 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@
Notmuch requires at least Emacs version 25.
The `return-action' argument was added prior to Emacs 24.1
in 25ca2e61403f97b5a023164f2924d5f8aca2492a.
---
emacs/notmuch-mua.el | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
Notmuch requires at least version 25 of Emacs now.
Adjust comments that previously referenced version 24 specifically,
even though they also apply to later releases. Remove documentation
and code that no longer applies.
- `mm-shr' no longer references `gnus-inhibit-images'.
---
---
emacs/notmuch-mua.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 49bad00d..9d08c2c9 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -62,8 +62,8 @@ (defcustom notmuch-mua-compose-in 'current-window
The first sentence should fit on the first line. It is okay if
the first sentence/line does not contain all the information that
the rest of the doc-string covers.
---
emacs/notmuch-show.el | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-show.el
This remove the first four commits, which have already been
applied to master. It also makes requested minor changes
to the three marked commits.
Jonas Bernoulli (23):
emacs: remove redundant notmuch-hello-trim
emacs: fix old bug in notmuch-mua-mail
emacs: remove kludge for Emacs 23 from
101 - 200 of 284 matches
Mail list logo