Re: [PATCH v2 06/10] cli: Introduce "notmuch address" command

2014-11-05 Thread Mark Walters
On Tue, 04 Nov 2014, Michal Sojka wrote: > On Tue, Nov 04 2014, Mark Walters wrote: >> On Mon, 03 Nov 2014, Michal Sojka wrote: >>> This moves address-related functionality from search command to the >>> new address command. The implementation shares almost all cod

[PATCH v2 00/10] "notmuch address" command

2014-11-04 Thread Mark Walters
On Mon, 03 Nov 2014, Michal Sojka wrote: > Hi all, > > this is v2 of "notmuch address" patchset. It obsoletes [1]. > > Don't be scared by the number of patches. Most of them are trivial > refactoring. Patches 1-4 refactor the code so that "notmuch search" > command is easier to split. Patch 5 is

[RFC PATCH 0/2] cli: split 'notmuch address' from 'notmuch search'

2014-11-04 Thread Mark Walters
On Sat, 01 Nov 2014, Jani Nikula wrote: > On Sat, 01 Nov 2014, Michal Sojka wrote: >> On Sat, Nov 01 2014, Jani Nikula wrote: >>> On Fri, 31 Oct 2014, Michal Sojka wrote: This option allows to configure the criterion for duplicate address filtering. Without this option, all unique com

[PATCH v2 09/10] cli: address: Add --output=count

2014-11-04 Thread Mark Walters
On Mon, 03 Nov 2014, Michal Sojka wrote: > This output prints how many times was each address encountered during > search. > --- > completion/notmuch-completion.bash | 2 +- > completion/notmuch-completion.zsh | 2 +- > doc/man1/notmuch-address.rst | 7 ++ > notmuch-search.c

[PATCH v2 07/10] cli: search: Convert --output to keyword argument

2014-11-04 Thread Mark Walters
> Hi > > On Mon, 03 Nov 2014, Michal Sojka wrote: >> Now, when address related outputs are in a separate command, it makes >> no sense to combine multiple --output options in search command line. >> Using switch statement to handle different outputs is more readable >> than a series of if stateme

[PATCH v2 06/10] cli: Introduce "notmuch address" command

2014-11-04 Thread Mark Walters
On Mon, 03 Nov 2014, Michal Sojka wrote: > This moves address-related functionality from search command to the > new address command. The implementation shares almost all code and > some command line options. > > Options --offset and --limit were intentionally not included in the > address command

[PATCH v2 07/10] cli: search: Convert --output to keyword argument

2014-11-04 Thread Mark Walters
Hi On Mon, 03 Nov 2014, Michal Sojka wrote: > Now, when address related outputs are in a separate command, it makes > no sense to combine multiple --output options in search command line. > Using switch statement to handle different outputs is more readable > than a series of if statements. I a

Re: [PATCH v2 00/10] "notmuch address" command

2014-11-04 Thread Mark Walters
On Mon, 03 Nov 2014, Michal Sojka wrote: > Hi all, > > this is v2 of "notmuch address" patchset. It obsoletes [1]. > > Don't be scared by the number of patches. Most of them are trivial > refactoring. Patches 1-4 refactor the code so that "notmuch search" > command is easier to split. Patch 5 is

Re: [RFC PATCH 0/2] cli: split 'notmuch address' from 'notmuch search'

2014-11-04 Thread Mark Walters
On Sat, 01 Nov 2014, Jani Nikula wrote: > On Sat, 01 Nov 2014, Michal Sojka wrote: >> On Sat, Nov 01 2014, Jani Nikula wrote: >>> On Fri, 31 Oct 2014, Michal Sojka wrote: This option allows to configure the criterion for duplicate address filtering. Without this option, all unique com

Re: [PATCH v2 09/10] cli: address: Add --output=count

2014-11-04 Thread Mark Walters
On Mon, 03 Nov 2014, Michal Sojka wrote: > This output prints how many times was each address encountered during > search. > --- > completion/notmuch-completion.bash | 2 +- > completion/notmuch-completion.zsh | 2 +- > doc/man1/notmuch-address.rst | 7 ++ > notmuch-search.c

Re: [PATCH v2 07/10] cli: search: Convert --output to keyword argument

2014-11-04 Thread Mark Walters
> Hi > > On Mon, 03 Nov 2014, Michal Sojka wrote: >> Now, when address related outputs are in a separate command, it makes >> no sense to combine multiple --output options in search command line. >> Using switch statement to handle different outputs is more readable >> than a series of if stateme

Re: [PATCH v2 06/10] cli: Introduce "notmuch address" command

2014-11-04 Thread Mark Walters
On Mon, 03 Nov 2014, Michal Sojka wrote: > This moves address-related functionality from search command to the > new address command. The implementation shares almost all code and > some command line options. > > Options --offset and --limit were intentionally not included in the > address command

Re: [PATCH v2 07/10] cli: search: Convert --output to keyword argument

2014-11-04 Thread Mark Walters
Hi On Mon, 03 Nov 2014, Michal Sojka wrote: > Now, when address related outputs are in a separate command, it makes > no sense to combine multiple --output options in search command line. > Using switch statement to handle different outputs is more readable > than a series of if statements. I a

[PATCH v6 6/7] cli: search: Add --output=count

2014-11-02 Thread Mark Walters
Hi On Sun, 02 Nov 2014, Michal Sojka wrote: > On Sat, Nov 01 2014, Mark Walters wrote: >> On Fri, 31 Oct 2014, Michal Sojka wrote: >>> This output can be used with --output=recipients or --output=sender >>> and in addition to the addresses, it prints how many

Re: [PATCH v6 6/7] cli: search: Add --output=count

2014-11-02 Thread Mark Walters
Hi On Sun, 02 Nov 2014, Michal Sojka wrote: > On Sat, Nov 01 2014, Mark Walters wrote: >> On Fri, 31 Oct 2014, Michal Sojka wrote: >>> This output can be used with --output=recipients or --output=sender >>> and in addition to the addresses, it prints how many

[PATCH v6 6/7] cli: search: Add --output=count

2014-11-01 Thread Mark Walters
On Fri, 31 Oct 2014, Michal Sojka wrote: > This output can be used with --output=recipients or --output=sender > and in addition to the addresses, it prints how many times was each > address encountered during search. Hi I have a couple comments on this patch. > --- > completion/notmuch-compl

[PATCH v6 0/7] notmuch search --output=sender/recipients

2014-11-01 Thread Mark Walters
full diff below): > > - Added quoting of name parts if that is necessary (pointed out by > Mark Walters). Structured formats contain both full address > (possibly with quoted name) and unquoted individual fields. > - Fixed bug in --output=count --filter-by=*fold (reported by Jess

Re: [PATCH v6 6/7] cli: search: Add --output=count

2014-10-31 Thread Mark Walters
On Fri, 31 Oct 2014, Michal Sojka wrote: > This output can be used with --output=recipients or --output=sender > and in addition to the addresses, it prints how many times was each > address encountered during search. Hi I have a couple comments on this patch. > --- > completion/notmuch-compl

[PATCH v5 0/7] notmuch search --output=sender/recipients

2014-10-31 Thread Mark Walters
On Fri, 31 Oct 2014, Tomi Ollila wrote: > On Fri, Oct 31 2014, Michal Sojka wrote: > >> On Fri, Oct 31 2014, Mark Walters wrote: >>> My only query is in the text output: should the name part be printed as >>> a quoted string. For example currently I get a line of

[PATCH v5 0/7] notmuch search --output=sender/recipients

2014-10-31 Thread Mark Walters
Hi On Fri, 31 Oct 2014, Michal Sojka wrote: > On Fri, Oct 31 2014, Mark Walters wrote: >> My only query is in the text output: should the name part be printed as >> a quoted string. For example currently I get a line of the form >> >> Bloggs, Fred > > Good poi

[PATCH v5 0/7] notmuch search --output=sender/recipients

2014-10-31 Thread Mark Walters
Hi I attach a patch which does the quoting for real names but I don't know if we want it: it changes (example taken from the test suite) Fran?ois Boulogne to =?iso-8859-1?q?Fran=E7ois?= Boulogne (which is what was in the original email) Plausibly the best thing is just to leave the series as

Re: [PATCH v5 0/7] notmuch search --output=sender/recipients

2014-10-31 Thread Mark Walters
On Fri, 31 Oct 2014, Tomi Ollila wrote: > On Fri, Oct 31 2014, Michal Sojka wrote: > >> On Fri, Oct 31 2014, Mark Walters wrote: >>> My only query is in the text output: should the name part be printed as >>> a quoted string. For example currently I get a line of

Re: [PATCH v5 0/7] notmuch search --output=sender/recipients

2014-10-31 Thread Mark Walters
Hi On Fri, 31 Oct 2014, Michal Sojka wrote: > On Fri, Oct 31 2014, Mark Walters wrote: >> My only query is in the text output: should the name part be printed as >> a quoted string. For example currently I get a line of the form >> >> Bloggs, Fred > > Good poi

[PATCH v5 0/7] notmuch search --output=sender/recipients

2014-10-31 Thread Mark Walters
On Thu, 30 Oct 2014, Michal Sojka wrote: > Hi all, > > this is v5 of the search --output=address series. It obsoletes v4 > (id:1414421455-3037-1-git-send-email-sojkam1 at fel.cvut.cz). > > I addresses comments from Mark and Tomi. Based on the comments to v4 > and earlier versions, patches 1-4 shou

Re: [PATCH v5 0/7] notmuch search --output=sender/recipients

2014-10-31 Thread Mark Walters
es as is, so the text output is readable and parseable in the common cases. Anyway the patch is attached if anyone wants to experiment. Best wishes Mark >From 53b1ced2d6a9fbbba93448325f795e6b99faa240 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Fri, 31 Oct 2014 10:11:40 + Subject

Re: [PATCH v5 0/7] notmuch search --output=sender/recipients

2014-10-31 Thread Mark Walters
On Thu, 30 Oct 2014, Michal Sojka wrote: > Hi all, > > this is v5 of the search --output=address series. It obsoletes v4 > (id:1414421455-3037-1-git-send-email-sojk...@fel.cvut.cz). > > I addresses comments from Mark and Tomi. Based on the comments to v4 > and earlier versions, patches 1-4 should

[PATCH v4 5/6] cli: search: Add configurable way to filter out duplicate addresses

2014-10-30 Thread Mark Walters
On Thu, 30 Oct 2014, Tomi Ollila wrote: > On Thu, Oct 30 2014, Mark Walters wrote: > >> On Mon, 27 Oct 2014, Michal Sojka wrote: >>> This adds an algorithm to filter out duplicate addresses from address >>> outputs (sender, receivers). The algorithm can be c

[PATCH v4 5/6] cli: search: Add configurable way to filter out duplicate addresses

2014-10-30 Thread Mark Walters
On Mon, 27 Oct 2014, Michal Sojka wrote: > This adds an algorithm to filter out duplicate addresses from address > outputs (sender, receivers). The algorithm can be configured with > --filter-by command line option. > > The code here is an extended version of a patch from Jani Nikula. Hi As thi

[PATCH v4 4/6] cli: search: Add --output={sender,recipients}

2014-10-30 Thread Mark Walters
On Mon, 27 Oct 2014, Michal Sojka wrote: > The new outputs allow printing senders, recipients or both of matching > messages. To print both, the user can use --output=sender and > --output=recipients simultaneously. > > Currently, the same address can appear multiple times in the output. The > nex

[PATCH v4 1/6] cli: search: Refactor passing of command line options

2014-10-30 Thread Mark Walters
Hi On Mon, 27 Oct 2014, Michal Sojka wrote: > Many functions that implement the search command need to access command > line options. Instead of passing each option in a separate variable, put > them in a structure and pass only this structure. > > This will become handy in the following patches

Re: [PATCH v4 5/6] cli: search: Add configurable way to filter out duplicate addresses

2014-10-30 Thread Mark Walters
On Thu, 30 Oct 2014, Tomi Ollila wrote: > On Thu, Oct 30 2014, Mark Walters wrote: > >> On Mon, 27 Oct 2014, Michal Sojka wrote: >>> This adds an algorithm to filter out duplicate addresses from address >>> outputs (sender, receivers). The algorithm can be c

Re: [PATCH v4 5/6] cli: search: Add configurable way to filter out duplicate addresses

2014-10-30 Thread Mark Walters
On Mon, 27 Oct 2014, Michal Sojka wrote: > This adds an algorithm to filter out duplicate addresses from address > outputs (sender, receivers). The algorithm can be configured with > --filter-by command line option. > > The code here is an extended version of a patch from Jani Nikula. Hi As thi

Re: [PATCH v4 4/6] cli: search: Add --output={sender,recipients}

2014-10-30 Thread Mark Walters
On Mon, 27 Oct 2014, Michal Sojka wrote: > The new outputs allow printing senders, recipients or both of matching > messages. To print both, the user can use --output=sender and > --output=recipients simultaneously. > > Currently, the same address can appear multiple times in the output. The > nex

Re: [PATCH v4 1/6] cli: search: Refactor passing of command line options

2014-10-30 Thread Mark Walters
Hi On Mon, 27 Oct 2014, Michal Sojka wrote: > Many functions that implement the search command need to access command > line options. Instead of passing each option in a separate variable, put > them in a structure and pass only this structure. > > This will become handy in the following patches

[PATCH] Avoid empty thread names if possible.

2014-10-29 Thread Mark Walters
Hi On Wed, 29 Oct 2014, Jesse Rosenthal wrote: > [I'm not sure why the below reply did not go to the list. Later replies > did, so I assume there must have been so problem in the sending. Mark, > apologies if you get this twice.] > > Hi, > > Thanks for taking a look

[PATCH] Avoid empty thread names if possible.

2014-10-29 Thread Mark Walters
Hi On Tue, 07 Oct 2014, Jesse Rosenthal wrote: > Currently the thread is named based on either the oldest or newest > matching message (depending on the search order). If this message has > an empty subject, though, the thread will show up with an empty > subject in the search results. (See the

Re: [PATCH] Avoid empty thread names if possible.

2014-10-29 Thread Mark Walters
Hi On Wed, 29 Oct 2014, Jesse Rosenthal wrote: > [I'm not sure why the below reply did not go to the list. Later replies > did, so I assume there must have been so problem in the sending. Mark, > apologies if you get this twice.] > > Hi, > > Thanks for taking a look

Re: [PATCH] Avoid empty thread names if possible.

2014-10-29 Thread Mark Walters
Hi On Tue, 07 Oct 2014, Jesse Rosenthal wrote: > Currently the thread is named based on either the oldest or newest > matching message (depending on the search order). If this message has > an empty subject, though, the thread will show up with an empty > subject in the search results. (See the

[PATCH v1 1/3] search: Seperately report matching and non-matching authors.

2014-10-24 Thread Mark Walters
Hi I definitely like the idea: some comments below. On Fri, 24 Oct 2014, David Edmondson wrote: > In addition to the :authors attribute of each search result, include > :authors_matched and :authors_non_matched attributes. Both attributes > are always included. If there are no non-matching auth

Re: [PATCH v1 1/3] search: Seperately report matching and non-matching authors.

2014-10-24 Thread Mark Walters
Hi I definitely like the idea: some comments below. On Fri, 24 Oct 2014, David Edmondson wrote: > In addition to the :authors attribute of each search result, include > :authors_matched and :authors_non_matched attributes. Both attributes > are always included. If there are no non-matching auth

[PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients}

2014-10-23 Thread Mark Walters
On Sun, 12 Oct 2014, Michal Sojka wrote: > The new outputs allow printing senders, recipients or both of matching > messages. The --output option is converted from "keyword" argument to > "flags" argument, which means that the user can use --output=sender and > --output=recipients simultaneously,

Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients}

2014-10-23 Thread Mark Walters
On Sun, 12 Oct 2014, Michal Sojka wrote: > The new outputs allow printing senders, recipients or both of matching > messages. The --output option is converted from "keyword" argument to > "flags" argument, which means that the user can use --output=sender and > --output=recipients simultaneously,

[PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients}

2014-10-22 Thread Mark Walters
On Sun, 12 Oct 2014, Michal Sojka wrote: > The new outputs allow printing senders, recipients or both of matching > messages. The --output option is converted from "keyword" argument to > "flags" argument, which means that the user can use --output=sender and > --output=recipients simultaneously,

[PATCH v3 1/4] cli: Refactor option passing in the search command

2014-10-22 Thread Mark Walters
On Sun, 12 Oct 2014, Michal Sojka wrote: > Many functions that implement the search command need to access command > line options. Instead of passing each option in a separate variable, put > them in a structure and pass only this structure. > > This will become handy in the following patches. Hi

Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients}

2014-10-22 Thread Mark Walters
On Sun, 12 Oct 2014, Michal Sojka wrote: > The new outputs allow printing senders, recipients or both of matching > messages. The --output option is converted from "keyword" argument to > "flags" argument, which means that the user can use --output=sender and > --output=recipients simultaneously,

Re: [PATCH v3 1/4] cli: Refactor option passing in the search command

2014-10-22 Thread Mark Walters
On Sun, 12 Oct 2014, Michal Sojka wrote: > Many functions that implement the search command need to access command > line options. Instead of passing each option in a separate variable, put > them in a structure and pass only this structure. > > This will become handy in the following patches. Hi

[PATCH 00/12] Add ghost messages and fix thread linking

2014-10-22 Thread Mark Walters
On Tue, 07 Oct 2014, Austin Clements wrote: > This is v2 of the > id:1412345958-8278-1-git-send-email-aclements at csail.mit.edu. This > adds some comments and clarifies some code as suggested by David. > Patch 6 is new in v2 and adds some bit-twiddling macros for clarity > and robustness in lat

[PATCH v2 12/12] lib: Remove unnecessary thread linking steps when using ghost messages

2014-10-22 Thread Mark Walters
On Tue, 07 Oct 2014, Austin Clements wrote: > From: Austin Clements > > Previously, it was necessary to link new messages to children to work > around some (though not all) problems with the old metadata-based > approach to stored thread IDs. With ghost messages, this is no longer > necessary, s

[PATCH v2 08/12] lib: Implement ghost-based thread linking

2014-10-22 Thread Mark Walters
merging updated only the thread IDs of message > documents, not thread IDs stored in user metadata. As originally > diagnosed by Mark Walters [1] and as demonstrated by the broken > T260-thread-order test, this can cause notmuch to fail to link > messages even though they're in

[PATCH v2 07/12] lib: Internal support for querying and creating ghost messages

2014-10-22 Thread Mark Walters
Hi I am slowly working my way through this series: only two trivial queries so far. On Tue, 07 Oct 2014, Austin Clements wrote: > From: Austin Clements > > This updates the message abstraction to support ghost messages: it > adds a message flag that distinguishes regular messages from ghost >

Re: [PATCH 00/12] Add ghost messages and fix thread linking

2014-10-21 Thread Mark Walters
On Tue, 07 Oct 2014, Austin Clements wrote: > This is v2 of the > id:1412345958-8278-1-git-send-email-acleme...@csail.mit.edu. This > adds some comments and clarifies some code as suggested by David. > Patch 6 is new in v2 and adds some bit-twiddling macros for clarity > and robustness in later

Re: [PATCH v2 12/12] lib: Remove unnecessary thread linking steps when using ghost messages

2014-10-21 Thread Mark Walters
On Tue, 07 Oct 2014, Austin Clements wrote: > From: Austin Clements > > Previously, it was necessary to link new messages to children to work > around some (though not all) problems with the old metadata-based > approach to stored thread IDs. With ghost messages, this is no longer > necessary, s

Re: [PATCH v2 08/12] lib: Implement ghost-based thread linking

2014-10-21 Thread Mark Walters
merging updated only the thread IDs of message > documents, not thread IDs stored in user metadata. As originally > diagnosed by Mark Walters [1] and as demonstrated by the broken > T260-thread-order test, this can cause notmuch to fail to link > messages even though they're in

Re: [PATCH v2 07/12] lib: Internal support for querying and creating ghost messages

2014-10-21 Thread Mark Walters
Hi I am slowly working my way through this series: only two trivial queries so far. On Tue, 07 Oct 2014, Austin Clements wrote: > From: Austin Clements > > This updates the message abstraction to support ghost messages: it > adds a message flag that distinguishes regular messages from ghost >

[PATCH v3] Emacs: Add address completion mechanism implemented in elisp

2014-09-08 Thread Mark Walters
On Mon, 08 Sep 2014, David Edmondson wrote: > On Mon, Aug 11 2014, Michal Sojka wrote: >> Currently, notmuch has an address completion mechanism that requires >> external command to provide completion candidates. This patch adds a >> completion mechanism inspired by https://github.com/tjim/nevermo

Re: [PATCH v3] Emacs: Add address completion mechanism implemented in elisp

2014-09-08 Thread Mark Walters
On Mon, 08 Sep 2014, David Edmondson wrote: > On Mon, Aug 11 2014, Michal Sojka wrote: >> Currently, notmuch has an address completion mechanism that requires >> external command to provide completion candidates. This patch adds a >> completion mechanism inspired by https://github.com/tjim/nevermo

[PATCH] cli: add --output=address-{from, to, all} to notmuch search

2014-09-06 Thread Mark Walters
On Sat, 06 Sep 2014, Jani Nikula wrote: > address-from prints reply-to or from, address-to prints to, cc, and > bcc, and address-all prints all of them. This looks good to me. Obviously needs the new commit message. I think we should think about the deduplication possibilities but that can be

[Patch v2 2/2] emacs: show: mark messages unread if seen in buffer

2014-09-06 Thread Mark Walters
This adds a function that marks messages unread if they are "seen" that is a user configurable amount of them has been visible in the buffer. --- emacs/notmuch-show.el | 74 - 1 file changed, 73 insertions(+), 1 deletion(-) diff --git a/emacs/notm

[Patch v2 1/2] emacs: show: document the mark unread defcustom function

2014-09-06 Thread Mark Walters
--- emacs/notmuch-show.el |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 7549fbb..5695d95 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -224,7 +224,13 @@ For example, if you wanted to remove an \

[Patch v2 0/2] emacs: show: mark messages read if seen in buffer

2014-09-06 Thread Mark Walters
user selects this option so it is low risk). If people would prefer not to include it then I can just post the relevant code to the wiki and people can add it to their .emacs file if they want this function. Best wishes Mark Mark Walters (2): emacs: show: document the mark unread defcustom fun

[PATCH 2/3] cli: add --output=address-{from, to, all} to notmuch search

2014-09-06 Thread Mark Walters
On Sat, 06 Sep 2014, Jani Nikula wrote: > address-from prints reply-to or from, address-to prints to, cc, and > bcc, and address-all prints all of them. Hi I like these: thanks a lot for doing this. Just one quick comment before I do an actual review: > --- > notmuch-search.c | 113 > ++

Re: [PATCH] cli: add --output=address-{from, to, all} to notmuch search

2014-09-06 Thread Mark Walters
On Sat, 06 Sep 2014, Jani Nikula wrote: > address-from prints reply-to or from, address-to prints to, cc, and > bcc, and address-all prints all of them. This looks good to me. Obviously needs the new commit message. I think we should think about the deduplication possibilities but that can be

[Patch v2 2/2] emacs: show: mark messages unread if seen in buffer

2014-09-06 Thread Mark Walters
This adds a function that marks messages unread if they are "seen" that is a user configurable amount of them has been visible in the buffer. --- emacs/notmuch-show.el | 74 - 1 file changed, 73 insertions(+), 1 deletion(-) diff --git a/emacs/notm

[Patch v2 1/2] emacs: show: document the mark unread defcustom function

2014-09-06 Thread Mark Walters
--- emacs/notmuch-show.el |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 7549fbb..5695d95 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -224,7 +224,13 @@ For example, if you wanted to remove an \

[Patch v2 0/2] emacs: show: mark messages read if seen in buffer

2014-09-06 Thread Mark Walters
user selects this option so it is low risk). If people would prefer not to include it then I can just post the relevant code to the wiki and people can add it to their .emacs file if they want this function. Best wishes Mark Mark Walters (2): emacs: show: document the mark unread defcustom fun

Re: [PATCH 2/3] cli: add --output=address-{from, to, all} to notmuch search

2014-09-06 Thread Mark Walters
On Sat, 06 Sep 2014, Jani Nikula wrote: > address-from prints reply-to or from, address-to prints to, cc, and > bcc, and address-all prints all of them. Hi I like these: thanks a lot for doing this. Just one quick comment before I do an actual review: > --- > notmuch-search.c | 113 > ++

[PATCH v1 0/3] Address completion entirely in elisp.

2014-09-05 Thread Mark Walters
Hi On Fri, 05 Sep 2014, David Edmondson wrote: > Address completion entirely in elisp. > > I grew frustrated with having to use an external command to provide > address completion, as they all had annoyances (up front scanning, > requiring python bindings, etc.). This is an attempt to provide >

Re: [PATCH v1 0/3] Address completion entirely in elisp.

2014-09-05 Thread Mark Walters
Hi On Fri, 05 Sep 2014, David Edmondson wrote: > Address completion entirely in elisp. > > I grew frustrated with having to use an external command to provide > address completion, as they all had annoyances (up front scanning, > requiring python bindings, etc.). This is an attempt to provide >

[PATCH] emacs: jump: fix compile warning on emacs 23

2014-09-04 Thread Mark Walters
notmuch-jump uses window-body-width which is not defined in emacs 23. To get around this it does (unless (fboundp 'window-body-width) ;; Compatibility for Emacs pre-24 (defalias 'window-body-width 'window-width)) This makes sure window-body-width is defined and all should be well. But it seem

[PATCH] emacs: jump: fix compile warning on emacs 23

2014-09-04 Thread Mark Walters
notmuch-jump uses window-body-width which is not defined in emacs 23. To get around this it does (unless (fboundp 'window-body-width) ;; Compatibility for Emacs pre-24 (defalias 'window-body-width 'window-width)) This makes sure window-body-width is defined and all should be well. But it seem

sending email using different server for different 'From:' field

2014-09-03 Thread Mark Walters
Hi On Wed, 03 Sep 2014, David Belohrad wrote: > oukej. this seems to be exactly what I'm looking for. Is there a way how > to 'cycle' in notmuch different From: fields? I'd need to setup like 3 > addresses, each of them with different signatures and be able to easily > switch between them Y

Re: sending email using different server for different 'From:' field

2014-09-03 Thread Mark Walters
Hi On Wed, 03 Sep 2014, David Belohrad wrote: > oukej. this seems to be exactly what I'm looking for. Is there a way how > to 'cycle' in notmuch different From: fields? I'd need to setup like 3 > addresses, each of them with different signatures and be able to easily > switch between them Y

[PATCH v2] emacs: jump: sort-order bugfix

2014-09-02 Thread Mark Walters
default-value needs its argument to be quoted. Slightly strangely default-value of 't or nil is 't or nil respectively so the code (default-value notmuch-search-oldest-first) just gives the current value of notmuch-search-oldest-first rather than intended default-value of this variable. The sym

[PATCH] emacs: jump: sort-order bugfix

2014-09-02 Thread Mark Walters
default-value needs its argument to be quoted. --- Slightly strangely default-value of 't or nil is 't or nil respectively so the code didn't give an error but just did the wrong thing. Thanks to Jani for finding the bug. Best wishes Mark emacs/notmuch-jump.el |2 +- 1 file changed, 1 ins

[PATCH v2] emacs: jump: sort-order bugfix

2014-09-02 Thread Mark Walters
default-value needs its argument to be quoted. Slightly strangely default-value of 't or nil is 't or nil respectively so the code (default-value notmuch-search-oldest-first) just gives the current value of notmuch-search-oldest-first rather than intended default-value of this variable. The sym

[PATCH] lib: Fix endless upgrade problem

2014-09-02 Thread Mark Walters
On Tue, 02 Sep 2014, Tomi Ollila wrote: > On Tue, Sep 02 2014, Austin Clements wrote: > >> 48db8c8 introduced a disagreement between when >> notmuch_database_needs_upgrade returned TRUE and when >> notmuch_database_upgrade actually performed an upgrade. As a result, >> if a database had a versi

[PATCH] emacs: jump: sort-order bugfix

2014-09-02 Thread Mark Walters
default-value needs its argument to be quoted. --- Slightly strangely default-value of 't or nil is 't or nil respectively so the code didn't give an error but just did the wrong thing. Thanks to Jani for finding the bug. Best wishes Mark emacs/notmuch-jump.el |2 +- 1 file changed, 1 ins

Re: [PATCH] lib: Fix endless upgrade problem

2014-09-01 Thread Mark Walters
On Tue, 02 Sep 2014, Tomi Ollila wrote: > On Tue, Sep 02 2014, Austin Clements wrote: > >> 48db8c8 introduced a disagreement between when >> notmuch_database_needs_upgrade returned TRUE and when >> notmuch_database_upgrade actually performed an upgrade. As a result, >> if a database had a versi

[PATCH 05/14] lib: Database version 3: Introduce fine-grained "features"

2014-07-27 Thread Mark Walters
On Sun, 27 Jul 2014, Austin Clements wrote: > Previously, our database schema was versioned by a single number. > Each database schema change had to occur "atomically" in Notmuch's > development history: before some commit, Notmuch used version N, after > that commit, it used version N+1. Hence,

[PATCH 08/14] lib: Simplify upgrade code using a transaction

2014-07-27 Thread Mark Walters
Hi On Sun, 27 Jul 2014, Austin Clements wrote: > Previously, the upgrade was organized as two passes -- an upgrade > pass, and a separate cleanup pass -- so the database was always in a > valid state. This change substantially simplifies this code by > performing the upgrade in a transaction an

[PATCH 04/14] new: Don't report version after upgrade

2014-07-27 Thread Mark Walters
On Sun, 27 Jul 2014, Austin Clements wrote: > The version number has always been pretty meaningless to the user and > it's about to become even more meaningless with the introduction of > "features". Hopefully, the database will remain on version 3 for some > time to come; however, the introducti

[PATCH 07/14] test: Tests for future version and unknown feature handling

2014-07-27 Thread Mark Walters
On Sun, 27 Jul 2014, Austin Clements wrote: > --- > test/T530-upgrade.sh | 46 ++ > 1 file changed, 46 insertions(+) Hi Just a quick comment on this patch so far. After this patch I got lots of test failures in the second (old) part of T530-upgrade b

Re: [PATCH 05/14] lib: Database version 3: Introduce fine-grained "features"

2014-07-27 Thread Mark Walters
On Sun, 27 Jul 2014, Austin Clements wrote: > Previously, our database schema was versioned by a single number. > Each database schema change had to occur "atomically" in Notmuch's > development history: before some commit, Notmuch used version N, after > that commit, it used version N+1. Hence,

Re: [PATCH 08/14] lib: Simplify upgrade code using a transaction

2014-07-27 Thread Mark Walters
Hi On Sun, 27 Jul 2014, Austin Clements wrote: > Previously, the upgrade was organized as two passes -- an upgrade > pass, and a separate cleanup pass -- so the database was always in a > valid state. This change substantially simplifies this code by > performing the upgrade in a transaction an

Re: [PATCH 04/14] new: Don't report version after upgrade

2014-07-27 Thread Mark Walters
On Sun, 27 Jul 2014, Austin Clements wrote: > The version number has always been pretty meaningless to the user and > it's about to become even more meaningless with the introduction of > "features". Hopefully, the database will remain on version 3 for some > time to come; however, the introducti

Re: [PATCH 07/14] test: Tests for future version and unknown feature handling

2014-07-27 Thread Mark Walters
On Sun, 27 Jul 2014, Austin Clements wrote: > --- > test/T530-upgrade.sh | 46 ++ > 1 file changed, 46 insertions(+) Hi Just a quick comment on this patch so far. After this patch I got lots of test failures in the second (old) part of T530-upgrade b

[PATCH] emacs: show: make return value of notmuch-show-get-prop explicit

2014-07-16 Thread Mark Walters
This makes the fact the notmuch-show-get-prop returns nil if the major mode is neither show not tree explicit. --- This is a followup to the patch and review comment at id:874myhabi0.fsf at maritornes.cs.unb.ca Best wishes Mark emacs/notmuch-show.el |3 ++- 1 file changed, 2 insertions(+),

[PATCH] emacs: show: mark messages unread if seen in buffer

2014-07-16 Thread Mark Walters
This adds a function that marks messages unread if they are "seen" that is a user configurable amount of them has been visible in the buffer. --- This adds my preferred mark unread function as an option: see id:1399650320-1382-1-git-send-email-markwalters1009 at gmail.com for a previous version. T

[PATCH] emacs: show: make return value of notmuch-show-get-prop explicit

2014-07-16 Thread Mark Walters
This makes the fact the notmuch-show-get-prop returns nil if the major mode is neither show not tree explicit. --- This is a followup to the patch and review comment at id:874myhabi0@maritornes.cs.unb.ca Best wishes Mark emacs/notmuch-show.el |3 ++- 1 file changed, 2 insertions(+), 1

[PATCH] emacs: show: mark messages unread if seen in buffer

2014-07-16 Thread Mark Walters
This adds a function that marks messages unread if they are "seen" that is a user configurable amount of them has been visible in the buffer. --- This adds my preferred mark unread function as an option: see id:1399650320-1382-1-git-send-email-markwalters1...@gmail.com for a previous version. This

[PATCH] dump: make dump take Xapian write lock

2014-07-16 Thread Mark Walters
On Tue, 15 Jul 2014, David Bremner wrote: > Mark Walters writes: > >> >> Discussion with Olly on irc indicates that this is currently the best >> solution: in xapian trunk there may be better possibilities using >> snapshots but they need to make it to a release

Re: [PATCH] dump: make dump take Xapian write lock

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, David Bremner wrote: > Mark Walters writes: > >> >> Discussion with Olly on irc indicates that this is currently the best >> solution: in xapian trunk there may be better possibilities using >> snapshots but they need to make it to a release

[PATCH v2 0/2] emacs: Shortcut keys to saved searches

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, Austin Clements wrote: > This is version 2 of > id:1405353735-26244-1-git-send-email-amdragon at mit.edu and addresses > Mark's comments in id:87egxnd4aq.fsf at qmul.ac.uk. > > The diff from v1 is below. This version gets a +1 from me. I would have a slight preference for ma

Re: [PATCH v2 0/2] emacs: Shortcut keys to saved searches

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, Austin Clements wrote: > This is version 2 of > id:1405353735-26244-1-git-send-email-amdra...@mit.edu and addresses > Mark's comments in id:87egxnd4aq@qmul.ac.uk. > > The diff from v1 is below. This version gets a +1 from me. I would have a slight preference for making t

[PATCH] emacs: tree/show remove duplicate function

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, David Bremner wrote: > Mark Walters writes: >> + (cond ((eq major-mode 'notmuch-show-mode) >> + (notmuch-show-get-message-properties)) >> + ((eq major-mode 'notmuch-tree-mode) >> +

[PATCH 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, Austin Clements wrote: > Quoth Mark Walters on Jul 14 at 10:22 pm: >> >> On Mon, 14 Jul 2014, Austin Clements wrote: >> > This introduces notmuch-jump, which is like a user-friendly, >> > user-configurable global prefix map for saved se

Re: [PATCH] emacs: tree/show remove duplicate function

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, David Bremner wrote: > Mark Walters writes: >> + (cond ((eq major-mode 'notmuch-show-mode) >> + (notmuch-show-get-message-properties)) >> + ((eq major-mode 'notmuch-tree-mode) >> +

Re: [PATCH 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, Austin Clements wrote: > Quoth Mark Walters on Jul 14 at 10:22 pm: >> >> On Mon, 14 Jul 2014, Austin Clements wrote: >> > This introduces notmuch-jump, which is like a user-friendly, >> > user-configurable global prefix map for saved se

[PATCH 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches

2014-07-14 Thread Mark Walters
nk it's better than my suggestion. > This code is a combination of work from myself (originally, > "notmuch-go"), David Edmondson, and modifications from Mark Walters. > --- > emacs/Makefile.local | 3 +- > emacs/notmuch-hello.el | 2 + > emacs/notmuch-jump.e

Re: [PATCH 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches

2014-07-14 Thread Mark Walters
nk it's better than my suggestion. > This code is a combination of work from myself (originally, > "notmuch-go"), David Edmondson, and modifications from Mark Walters. > --- > emacs/Makefile.local | 3 +- > emacs/notmuch-hello.el | 2 + > emacs/notmuch-jump.e

<    1   2   3   4   5   6   7   8   9   10   >