On Sat, 14 Jan 2012 21:40:23 -0400, David Bremner da...@tethera.net wrote:
From: David Bremner brem...@debian.org
This binary creates a torture test dump file for the new dump
format.
---
test/Makefile.local |4 ++
test/basic |2 +-
test/random-dump.c | 144
On Thu, 19 Jan 2012 10:46:54 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca
wrote:
This new JSON format for replies includes headers generated for a reply
message as well as the headers and all text parts of the original message.
Using this data, a client can intelligently create a reply. For
On Thu, 19 Jan 2012 10:46:56 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca
wrote:
Using the new JSON reply format allows emacs to quote HTML
parts nicely by using mm-display-part to turn them into displayable
text, then quoting them. This is very useful for users who
regularly receive HTML-only
On Sun, 05 Feb 2012 11:50:12 +, Mark Walters markwalters1...@gmail.com
wrote:
On Thu, 19 Jan 2012 10:46:54 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca
wrote:
This new JSON format for replies includes headers generated for a reply
message as well as the headers and all text parts
On Sun, 05 Feb 2012 10:58:04 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
Hi Mark.
I am not sure I like this solution. My concerns are:
* New option looks too complex, too specific.
* There are more aspects of notmuch reply behavior which users would
like to change
On Mon, 6 Feb 2012 21:57:20 +0200, Jani Nikula j...@nikula.org wrote:
Hi all,
v2 addressing Austin's comments in id:20120206041205.gp10...@mit.edu.
Separate the bool cleanup into a new patch, cleaning up notmuch reply
while at it. No functional changes since v1.
For reviewing
Hi
Here is the latest version of this patch set. I think I have fixed most
of the problems raised in review but there are some remaining issues
detailed below.
I know this patch set needs rebasing on top of Jani's notmuch-show
command line parsing patch: should I do that now or wait for
Hi
I looked at this and think its ok except for one trivial (but
significant) rebase error.
Best wishes
Mark
On Tue, 7 Feb 2012 08:46:16 +, David Edmondson d...@dme.org wrote:
Except for where invisibility is involved, replace the use of overlays
in `notmuch-show-mode' with text
On Mon, 6 Feb 2012 15:39:07 +, David Edmondson d...@dme.org wrote:
Add a regexp, `notmuch-show-part-headers-hidden' and if the
content-type of a part matches, don't show the part header.
---
emacs/notmuch-show.el | 43 ---
1 files changed, 28
On Mon, 6 Feb 2012 15:39:08 +, David Edmondson d...@dme.org wrote:
Previously this logic applied only to text/plain. Allow it for other
text/* parts as well.
What is the reason for treating the first part differently?
Personally, I would prefer to keep it as now since pressing v on the
On Sun, 12 Feb 2012 09:24:09 +, Mark Walters markwalters1...@gmail.com
wrote:
On Mon, 6 Feb 2012 15:39:08 +, David Edmondson d...@dme.org wrote:
Previously this logic applied only to text/plain. Allow it for other
text/* parts as well.
What is the reason for treating the first
Hello
On irc recently dme posted a patch notmuch-pick.el which provided a
threaded message view in the emacs interface. I have added substantially
to it and made some cli changes to support it better. See
http://kanelephant.com/screen.png for a screenshot.
It seems to be working well (although
---
notmuch-client.h |9 +-
notmuch-show.c | 90 --
2 files changed, 88 insertions(+), 11 deletions(-)
diff --git a/notmuch-client.h b/notmuch-client.h
index 60828aa..b4dc7bf 100644
--- a/notmuch-client.h
+++ b/notmuch-client.h
@@
---
emacs/Makefile.local |3 ++-
emacs/notmuch-hello.el | 10 ++
emacs/notmuch-query.el |4 +++-
emacs/notmuch-show.el | 19 +++
emacs/notmuch.el |8
5 files changed, 38 insertions(+), 6 deletions(-)
diff --git a/emacs/Makefile.local
---
emacs/notmuch-pick.el | 570 +
1 files changed, 570 insertions(+), 0 deletions(-)
create mode 100644 emacs/notmuch-pick.el
diff --git a/emacs/notmuch-pick.el b/emacs/notmuch-pick.el
new file mode 100644
index 000..4c91d7c
--- /dev/null
On Sun, 12 Feb 2012 15:47:18 +0100, Daniel Schoepe dan...@schoepe.org wrote:
---
emacs/notmuch-pick.el | 21 ++---
1 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-pick.el b/emacs/notmuch-pick.el
index 4c91d7c..2bf1ae4 100644
---
matched messages
highlight color both configurable and have a sensible default.
These are in the notmuch-pick subgroup of the customize menus.
Best wishes
Mark
Mark Walters (3):
cli: notmuch-show changes to support pick
emacs: changes to other files to support notmuch-pick
emacs: add notmuch
---
notmuch-client.h |9 +-
notmuch-show.c | 90 --
2 files changed, 88 insertions(+), 11 deletions(-)
diff --git a/notmuch-client.h b/notmuch-client.h
index 60828aa..b4dc7bf 100644
--- a/notmuch-client.h
+++ b/notmuch-client.h
@@
---
emacs/Makefile.local |3 ++-
emacs/notmuch-hello.el | 10 ++
emacs/notmuch-lib.el |4
emacs/notmuch-query.el |4 +++-
emacs/notmuch-show.el | 25 ++---
emacs/notmuch.el |8
6 files changed, 49 insertions(+), 5
---
emacs/notmuch-pick.el | 585 +
1 files changed, 585 insertions(+), 0 deletions(-)
create mode 100644 emacs/notmuch-pick.el
diff --git a/emacs/notmuch-pick.el b/emacs/notmuch-pick.el
new file mode 100644
index 000..46eb720
--- /dev/null
On Sun, 12 Feb 2012 12:39:13 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
On Sun, 12 Feb 2012 18:49:36 +, Mark Walters markwalters1...@gmail.com
wrote:
Here is a rebased version of the notmuch-pick patch set
id:87d39k1gvi@qmul.ac.uk. It now applies directly
This patch adds the following features to notmuch-show.c
a --headers-only option which just outputs the headers of a message
(i.e. it omits the bodies). This is not strictly needed by
notmuch-pick.el but it gives a speed-up of at least a factor of a two;
moreover it reduces the memory usage of
This patch adds
entries to notmuch-pick to notmuch-hello.el notmuch.el and
notmuch-show.el.
the option to view the current search in pick mode (from either
notmuch-show.el or notmuch.el)
a defcustom group for notmuch-pick.
make notmuch-show (the main function) return the buffer it uses. This
.
I also found one stale change which I removed.
Best wishes
Mark
Mark Walters (11):
cli: add --headers_only option to notmuch-show.c
cli: add sort options to notmuch-show.c
cli: add --thread= option to notmuch-show
emacs: add entry to notmuch-pick from
This option just outputs the headers of a message
(i.e. it omits the bodies).
This is used by notmuch-pick.el (although not needed) because it gives a
speed-up of at least a factor of a two; moreover it reduces the memory
usage in emacs hugely.
---
notmuch-client.h |1 +
notmuch-show.c |
The possible values are --thread=none|entire|match.
`entire' is exactly the existing option --entire-thread.
`match' is exactly the existing case when --entire-thread is not specified.
`none' is a new option to return just the matching messages with no
threading information at all.
The `none'
Add an entry to notmuch-pick from notmuch-hello and bind it to 'z'.
---
emacs/notmuch-hello.el | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index d17a30f..6d28a7e 100644
--- a/emacs/notmuch-hello.el
+++
Add an extra parameter to notmuch-query-get-threads (in
notmuch-query.el) so that callers can pass in extra parameters to
control the sort order, the --headers-only option, and threading etc.
---
emacs/notmuch-query.el |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git
Allow a parameter to notmuch-show to just show the matching
messages. This is very similar to
notmuch-show-elide-non-matching-messages but since it calls
notmuch-show.c with the --thread=none parameter it does not keep any
threading information.
In particular the sort order is different: the
This adds the main notmuch-pick.el file itself
---
emacs/Makefile.local |3 +-
emacs/notmuch-pick.el | 585 +
2 files changed, 587 insertions(+), 1 deletions(-)
create mode 100644 emacs/notmuch-pick.el
diff --git a/emacs/Makefile.local
On Mon, 13 Feb 2012 14:35:31 +0530, Aneesh Kumar K.V
aneesh.ku...@linux.vnet.ibm.com wrote:
On Sun, 12 Feb 2012 18:49:36 +, Mark Walters markwalters1...@gmail.com
wrote:
Here is a rebased version of the notmuch-pick patch set
id:87d39k1gvi@qmul.ac.uk. It now applies directly
This option turns off the exclusion so all matching messages are
returned. We do not need to add this to notmuch-show as that does not
(yet) exclude.
---
notmuch-count.c | 17 +++--
notmuch-search.c | 17 +++--
2 files changed, 22 insertions(+), 12 deletions(-)
diff
---
man/man1/notmuch-count.1 |7 +++
man/man1/notmuch-search.1 |7 +++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/man/man1/notmuch-count.1 b/man/man1/notmuch-count.1
index 25fe329..413b405 100644
--- a/man/man1/notmuch-count.1
+++ b/man/man1/notmuch-count.1
The tests test the new --no-exclude option to search and count.
There were no existing tests for the exclude behaviour for count so
added these too.
---
test/count | 21 +
test/search |5 +
2 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/test/count
Add a flag NOTMUCH_MESSAGE_FLAG_EXCLUDED which is set by
notmuch_query_search_messages for excluded messages. Also add an
option omit_excluded_messages to the search that we do not want the
excludes at all.
This exclude flag will be added to notmuch_query_search threads in the
next patch.
---
Slightly refactor the exclude code to give the callers access to the
exclude query itself. There should be no functional change.
---
lib/query.cc | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/lib/query.cc b/lib/query.cc
index
This adds the excludes to notmuch-show.c. We do not exclude when only
a single message (or part) is requested. notmuch-show will output the
exclude information when either text or json format is requested. As
this changes the output from notmuch-show it breaks many tests (in a
trivial and expected
---
man/man1/notmuch-show.1 |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/man/man1/notmuch-show.1 b/man/man1/notmuch-show.1
index b2301d8..f743a53 100644
--- a/man/man1/notmuch-show.1
+++ b/man/man1/notmuch-show.1
@@ -128,6 +128,13 @@ multipart/encrypted part will
Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to
notmuch_query_search_threads. Implemented by inspecting the tags
directly in _notmuch_thread_create/_thread_add_message rather than as
a Xapian query for speed reasons.
Note notmuch_thread_get_matched_messages now returns the number of
non-excluded
In all cases of notmuch count/search/show where the results returned
cannot reflect the exclude flag return just the matched not-excluded
results. If the caller wishes to have all the matched results (i.e.,
including the excluded ones) they should call with the
--no-exclude option.
The relevant
notmuch show outputs the exclude flag so many tests using notmuch
show failed. This commit adds excluded:0 or excluded: false to
the expected outputs. After this commit there should be no failing
tests.
---
test/crypto|9 -
test/encoding |2 +-
test/json |
Show mode will recognize the exclude flag by not opening excluding
messages by default, and will start at the first matching non-excluded
message. If there are no matching non-excluded messages it will go to
the first matching (necessarily excluded) message.
---
emacs/notmuch-show.el | 19
On Tue, 14 Feb 2012 10:21:14 -0500, Austin Clements amdra...@mit.edu wrote:
Quoth Mark Walters on Feb 14 at 12:28 pm:
Finally, if notmuch-pick were able to do work asynchronously (as
notmuch-search does now) then I think all the speed concerns would go
away. However, I am not sure how to do
On Wed, 15 Feb 2012 19:14:19 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
On Wed, 15 Feb 2012 09:23:31 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca
wrote:
On Wed, Feb 15, 2012 at 08:52, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
Can we delay this patch until user-defined sections
On Wed, 15 Feb 2012 09:46:56 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
On Wed, 15 Feb 2012 09:03:28 +, Mark Walters markwalters1...@gmail.com
wrote:
The current implementation of exclude-tags does not use excludes in
notmuch-show.c (and thus not in notmuch-show.el
On Wed, 15 Feb 2012 14:16:16 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
On Wed, 15 Feb 2012 21:11:15 +, Mark Walters markwalters1...@gmail.com
wrote:
I think the difficulty is that there are lots of annoying corner cases,
but if there is a simpler solution
On Wed, 15 Feb 2012 17:01:53 -0500, Ethan Glasser-Camp gla...@cs.rpi.edu
wrote:
Hi guys,
I'm submitting as RFC this patch series, which introduces the idea of
a mailstore, a class that defines how to access mail, instead of
currently assuming it's always some Maildir-ish hierarchy that
On Sun, 19 Feb 2012 08:33:00 +0100, Michal Sojka sojk...@fel.cvut.cz wrote:
On Sun, 19 Feb 2012, Jani Nikula wrote:
On Feb 19, 2012 12:44 AM, Michal Sojka sojk...@fel.cvut.cz wrote:
After recent rework of a/A/x/X key bindings, the important paragraph in
documentation of
at a time and the speed increase
will be needed there.
Best wishes
Mark
Mark Walters (2):
emacs/cli: remove entire-thread default from show: JSON
emacs: make elide messages use notmuch-show for omitting messages.
emacs/notmuch-show.el | 15 +--
notmuch-show.c|1 -
2
Previously notmuch-show.c defaulted to --entire-thread when
format=json. Make the default just the matching messages, but make
the single emacs caller add --entire-thread to the arguments supplied
so the end result should be unchanged.
---
emacs/notmuch-show.el |7 ---
notmuch-show.c
Previously the elide messages code got the entire-thread from
notmuch-show.c and then threw away all non-matching messages. This
version calls notmuch-show.c without the --entire-thread flag so
it never receives the non-matching messages in the first place.
This makes it substantially faster.
---
On Thu, 23 Feb 2012 14:45:57 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca
wrote:
Hi Mark,
On Thu, Feb 23, 2012 at 14:41, Mark Walters markwalters1...@gmail.com wrote:
Previously notmuch-show.c defaulted to --entire-thread when
format=json. Make the default just the matching messages
On Thu, 23 Feb 2012 17:10:15 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
RFC/Idea for improving some selections made (in notmuch or elsewhere)
In the hope that this will be useful, and to get some improvement advice.
I've found it somewhat difficult to use completing-read (i also tried ido-)
that the messages do not get marked excluded.
Make notmuch.el drop results with no matching non-excluded
messages.
The diff from v5 is at the end of this cover letter.
Best wishes
Mark
Mark Walters (13):
cli: add --no-exclude option to count and search.
cli: Add --no-exclude
In all cases of notmuch count/search/show where the results returned
cannot reflect the exclude flag return just the matched not-excluded
results. If the caller wishes to have all the matched results (i.e.,
including the excluded ones) they should call with the
--no-exclude option.
The relevant
Slightly refactor the exclude code to give the callers access to the
exclude query itself. There should be no functional change.
---
lib/query.cc | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/lib/query.cc b/lib/query.cc
index
Show mode will recognize the exclude flag by not opening excluding
messages by default, and will start at the first matching non-excluded
message. If there are no matching non-excluded messages it will go to
the first matching (necessarily excluded) message.
---
emacs/notmuch-show.el | 19
Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to
notmuch_query_search_threads. Implemented by inspecting the tags
directly in _notmuch_thread_create/_thread_add_message rather than as
a Xapian query for speed reasons.
Note notmuch_thread_get_matched_messages now returns the number of
non-excluded
---
man/man1/notmuch-show.1 |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/man/man1/notmuch-show.1 b/man/man1/notmuch-show.1
index b2301d8..8383a05 100644
--- a/man/man1/notmuch-show.1
+++ b/man/man1/notmuch-show.1
@@ -128,6 +128,13 @@ multipart/encrypted part will
This is a small change to make notmuch.el ignore excluded matches. In
the future it could do something better like add a button for
rerunning the search with the excludes (particularly if nothing
matches with the excludes) or having them invisible and allowing the
visibility to be toggled.
It is
Add a flag NOTMUCH_MESSAGE_FLAG_EXCLUDED which is set by
notmuch_query_search_messages for excluded messages. Also add an
option omit_excluded_messages to the search that we do not want the
excludes at all.
This exclude flag will be added to notmuch_query_search threads in the
next patch.
---
This option turns off the exclusion so all matching messages are
returned. We do not need to add this to notmuch-show as that does not
(yet) exclude.
---
notmuch-count.c | 17 +++--
notmuch-search.c | 17 +++--
2 files changed, 22 insertions(+), 12 deletions(-)
diff
The tests test the new --no-exclude option to search and count.
There were no existing tests for the exclude behaviour for count so
added these too.
---
test/count | 21 +
test/search |5 +
2 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/test/count
On Sat, 25 Feb 2012 10:27:02 -0400, David Bremner da...@tethera.net wrote:
I would like to start a freeze (i.e. merge master to release) for 0.12
within the next week, say March 1 for an easy to remember date.
If you have suggestions for things that should really go in, feel free
to follow
8324bc91e43d04e4c2813fa2a714766bcd057256 Mon Sep 17 00:00:00 2001
From: Mark Walters markwalters1...@gmail.com
Date: Sun, 29 Jan 2012 16:32:55 +
Subject: [PATCH] emacs: show: recognize the exclude flag.
Show mode will recognize the exclude flag by not opening excluding
messages by default, and will start at the first matching
On Sat, 21 Jan 2012 09:09:58 -0400, David Bremner da...@tethera.net wrote:
On Fri, 20 Jan 2012 09:44:06 +, Mark Walters markwalters1...@gmail.com
wrote:
Define a keymap for attachment buttons to allow multiple actions.
Define 3 possible actions:
save attachment: exactly
This disables the addition of search_exclude_tags in notmuch-setup and
notmuch-config.
---
notmuch-config.c |3 +--
notmuch-setup.c | 19 +--
2 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/notmuch-config.c b/notmuch-config.c
index e9b2750..61fda3e 100644
---
man/man1/notmuch-config.1 |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/man/man1/notmuch-config.1 b/man/man1/notmuch-config.1
index 0260eb7..36e09f4 100644
--- a/man/man1/notmuch-config.1
+++ b/man/man1/notmuch-config.1
@@ -85,14 +85,6 @@ directory hierarchy.
---
NEWS | 18 --
1 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/NEWS b/NEWS
index b2bec04..5fa8043 100644
--- a/NEWS
+++ b/NEWS
@@ -11,24 +11,6 @@ Reply to sender
to all. The feature is available through the new command line option
---
notmuch-count.c |8 +---
notmuch-search.c |8 +---
2 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/notmuch-count.c b/notmuch-count.c
index 63459fb..f86cb40 100644
--- a/notmuch-count.c
+++ b/notmuch-count.c
@@ -35,9 +35,6 @@ notmuch_count_command (void *ctx,
---
test/search |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/test/search b/test/search
index 414be35..c55522b 100755
--- a/test/search
+++ b/test/search
@@ -130,6 +130,7 @@ output=$(notmuch search bödý | notmuch_search_sanitize)
test_expect_equal $output thread:XXX
On Sat, 18 Feb 2012 23:12:29 +0100, Michal Sojka sojk...@fel.cvut.cz wrote:
The result is that hello screen shows much faster when some sections are
hidden.
---
emacs/notmuch-hello.el | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git
JSON show
rewrite.
Best wishes
Mark
Mark Walters (13):
cli: add --no-exclude option to count and search.
cli: Add --no-exclude to the man pages for search and count
test: add tests for new cli --no-exclude option
lib: Rearrange the exclude code in query.cc
lib: Make
This option turns off the exclusion so all matching messages are
returned. We do not need to add this to notmuch-show as that does not
(yet) exclude.
---
notmuch-count.c | 17 +++--
notmuch-search.c | 17 +++--
2 files changed, 22 insertions(+), 12 deletions(-)
diff
The tests test the new --no-exclude option to search and count.
There were no existing tests for the exclude behaviour for count so
added these too.
---
test/count | 21 +
test/search |5 +
2 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/test/count
Add a flag NOTMUCH_MESSAGE_FLAG_EXCLUDED which is set by
notmuch_query_search_messages for excluded messages. Also add an
option omit_excluded_messages to the search that we do not want the
excludes at all.
This exclude flag will be added to notmuch_query_search threads in the
next patch.
---
Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to
notmuch_query_search_threads. Implemented by inspecting the tags
directly in _notmuch_thread_create/_thread_add_message rather than as
a Xapian query for speed reasons.
Note notmuch_thread_get_matched_messages now returns the number of
non-excluded
notmuch-search.c now returns all matching threads even if it the
match is a search.tag_excluded message (but with a mark indicating
this). Update the test to reflect this.
---
test/search |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/test/search b/test/search
index
---
man/man1/notmuch-show.1 |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/man/man1/notmuch-show.1 b/man/man1/notmuch-show.1
index 4c5db94..d75d971 100644
--- a/man/man1/notmuch-show.1
+++ b/man/man1/notmuch-show.1
@@ -128,6 +128,13 @@ multipart/encrypted part will
In all cases of notmuch count/search/show where the results returned
cannot reflect the exclude flag return just the matched not-excluded
results. If the caller wishes to have all the matched results (i.e.,
including the excluded ones) they should call with the
--no-exclude option.
The relevant
Show mode will recognize the exclude flag by not opening excluding
messages by default, and will start at the first matching non-excluded
message. If there are no matching non-excluded messages it will go to
the first matching (necessarily excluded) message.
---
emacs/notmuch-show.el | 36
notmuch show outputs the exclude flag so many tests using notmuch
show failed. This commit adds excluded:0 or excluded: false to
the expected outputs. After this commit there should be no failing
tests.
---
test/crypto|9 -
test/encoding |2 +-
test/json |
This is a small change to make notmuch.el ignore excluded matches. In
the future it could do something better like add a button for
rerunning the search with the excludes (particularly if nothing
matches with the excludes) or having them invisible and allowing the
visibility to be toggled.
---
On Thu, 1 Mar 2012 22:30:32 +, Mark Walters markwalters1...@gmail.com
wrote:
This is essentially the same as
id:1330157204-26094-1-git-send-email-markwalters1...@gmail.com but
has been rebased against master. The changes are to patch 12/13 for
notmuch-show.el (which was posted
On Thu, 1 Mar 2012 22:30:32 +, Mark Walters markwalters1...@gmail.com
wrote:
This is essentially the same as
id:1330157204-26094-1-git-send-email-markwalters1...@gmail.com but
has been rebased against master. The changes are to patch 12/13 for
notmuch-show.el (which was posted
On Sat, 03 Mar 2012 03:42:44 +, Mark Walters markwalters1...@gmail.com
wrote:
On Thu, 1 Mar 2012 22:30:32 +, Mark Walters markwalters1...@gmail.com
wrote:
This is essentially the same as
id:1330157204-26094-1-git-send-email-markwalters1...@gmail.com but
has been rebased against
. This series just changes the names and defaults fed to the
existing logic.
The only slightly complicated part is the notmuch-show.c patch as it
has to decide quite what to do in lots of cases. See
id:87d38t26wp@qmul.ac.uk for reasons for the precise choices
made.
Best wishes
Mark
Mark Walters
Rename the function notmuch_query_set_omit_excluded_messages to
notmuch_query_set_with_excluded_messages and negate its meaning. Note
the suite will not compile currently as the callers of
notmuch_query_set_omit_excluded_messages have not been updated yet.
---
lib/notmuch.h | 12 +++-
Rename the option --no-exclude to --with-excluded. Note that this
could be implemented by setting
notmuch_query_set_with_excluded_messages but it is simpler not to set
the exclude tags in the first place (the two methods give identical
output).
---
man/man1/notmuch-count.1 |4 ++--
This commit replaces the --no-exclude option with a --with-excluded
option. The output is identical in all cases except output-summary. In
this case they output exactly the same thread lines. They differ in
that with the new option the match count (i.e., the x in [x/n] in the
output) is the number
This moves show to the --with-excluded naming scheme. When this is set
show returns all threads that match including those that only match in
an excluded message.
When this flag is not set the behaviour depends on whether
--entire-threads is set. If it is not set then show only returns the
Show has to set --with-excluded to deal with cases where it is asked
to show a single excluded message. It use JSON so it can easily pass
the exclude information to the user.
---
emacs/notmuch-show.el |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git
On Sat, 3 Mar 2012 23:55:24 +0200, Jani Nikula j...@nikula.org wrote:
Move hello section customization to notmuch-hello group and printing
customization to notmuch-show group from the top level customization
group.
Hi
This is an clear improvement but I wonder about the positioning of these
On Sun, 4 Mar 2012 10:25:38 +0200, Jani Nikula j...@nikula.org wrote:
The reply MML quoting added in commit ae438cc unintentionally MML
quotes also the signature/encryption MML tags added via
message-setup-hook, causing the reply not to be signed/encrypted.
MML quote just the original
Hi
There was a comment on irc about the needs review queue on nmbug status
being large. I think there may be several patches on there that have
been superseded or otherwise made obsolete. This makes choosing what to
review harder.
My guess is that it is very much easier for the author to know
the caller to disable --entire-thread (with --entire-thread=0) when
format=json.
Best wishes
Mark
Mark Walters (2):
cli: Parsing. Add option NOTMUCH_OPT_INT_OR_BOOLEAN
cli: make --entire-thread option notmuch-show.c INT_OR_BOOLEAN
command-line-arguments.c | 29
Allow the option NOTMUCH_OPT_INT_OR_BOOLEAN for command line parsing
which accepts --verbose=3 and --verbose with the latter setting
verbose to 1. It also allows --verbose=0 so (with a little caller
support) user can turn off boolean options.
This means that extra options can be added to the
Make the --entire-thread option notmuch-show.c
NOTMUCH_OPT_INT_OR_BOOLEAN. In particular this means a caller can turn
off entire-thread (by specifying --entire-thread=0) when format=json.
(This was not previously possible.)
---
notmuch-show.c | 10 --
1 files changed, 8 insertions(+), 2
Hi
On Fri, 09 Mar 2012 02:48:35 +0200, Jani Nikula j...@nikula.org wrote:
On Thu, 8 Mar 2012 22:15:42 +, Mark Walters markwalters1...@gmail.com
wrote:
The first patch adds a new command line parsing option
NOTMUCH_OPT_INT_OR_BOOLEAN for command line parsing which accepts
--verbose
and this one are
quite similar: the key difference is that this version abuses a
notmuch_bool_t by setting it to -1 (to indicate that the parser has
not set this option). This makes the code simpler but is definitely an
abuse. I will discuss this further in replies to Jani's series.
Best wishes
Mark
Mark
101 - 200 of 2963 matches
Mail list logo
