Pick adds some keybindings to keymaps for other modes (for entry to
pick). These quoted the keymaps which appears to be unnecessary and to
rely on the fact that these keymaps have the same entry in the
function cell as the value cell (perhaps for historical reasons?)
Remove these quotes.
---
cont
I have looked at this but haven't fully worked out what is going on.
Tomi found (on irc) that putting a (select-active-regions nil) to line
212 of notmuch-mua.el solves the problem.
My testing shows that putting a (let ((select-active-regions nil))
around the lines 224-227 in notmuch-mua.el also
We would like to bind prefix-arg RET in search view to "pick show this
thread" (i.e. notmuch-pick-from-search-thread). It is not easy to do
this cleanly from contrib so I have been using M-RET instead.
Temporarily remove this functionality in preparation for entering
mainline and binding to prefix
o pick) to
hello buttons and other search entry points. (I think this is a good
reason to make the change from M- to prefix-arg as it is much easier
to link the prefix-arg into button actions).
Best wishes
Mark
Mark Walters (2):
contrib: pick: move M-RET to prefix-arg RET
contrib: pick: remove
In pick the user has the option of showing the selected message in a
subpane (the message pane) or in the full frame. This is customisable
using the variable notmuch-pick-show-out. At the moment RET is bound
to the default option and M-RET the other option. This is
messy and involves tricks to make
notmuch-show looks at the prefix argument directly (ie via
current-prefix-arg) rather than using some form of the interactive
command. Thus we need to unset current-prefix-arg before calling notmuch-show.
---
I was just doing final tests for pick to mainline when I discovered
the following bug. The
Currently notmuch-show looks at the prefix-arg directly via
current-prefix-arg. This changes it to use the interactive
specification.
---
This alternative patch would avoid the problem described in
id:1380718788-18165-1-git-send-email-markwalters1...@gmail.com It
changes notmuch-show to use more s
Hello
I agree that the unread tag does not work well. There are some instances
which I would class as plain bugs (notmuch-show-next-message which is
bound to N marks the new message read even if it is collapsed) and
other instances where it is not clear what the correct behaviour should
be.
I ha
ld bundle together all read marking
> into a single action that would make sense to undo ("Thread marked as
> read [C-/ to undo]").
>
> Both options are highly predictable and easy to understand. They
> don't lose information about which messages were unread when you
> ente
This whole series looks good to me. If you are rolling another version
for any reason I have one trivial comment
On Sun, 06 Oct 2013, Austin Clements wrote:
> Traditionally, function documentation strings are intended primarily
> for programmers, rather than users. They're written from the
> pe
Hello
This looks good to me +1
Best wishes
Mark
On Mon, 07 Oct 2013, Austin Clements wrote:
> ---
> emacs/notmuch.el | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index e559472..c47c6b5 100644
> --- a/emacs/notmuch.
On Mon, 07 Oct 2013, Austin Clements wrote:
> Previously, the CLI would print a deprecation warning if a client
> requested any format version other than the current one. However, if
> we add fields that are backwards-compatible, but want clients to be
> able to depend on, we need to bump the ver
On Mon, 07 Oct 2013, Austin Clements wrote:
> (Unfortunately, it's difficult to first demonstrate this problem with
> a known-broken test because modern Linux kernels have argument length
> limits in the megabytes, which makes Emacs really slow!)
> ---
> emacs/notmuch-lib.el | 8
> emac
Hello
It's great that this might finally get done. But there is one problem
currently.
If you open a large search buffer and then do *- it will die as the
tagging routine runs notmuch search to find a completion-list for the
tag. (it runs notmuch search --output=tags )
We could just return all
On Mon, 07 Oct 2013, Austin Clements wrote:
> These queries will match exactly the set of messages currently in the
> thread, even if more messages later arrive. Two queries are provided:
> one for matched messages and one for unmatched messages.
>
> This can be used to fix race conditions with
On Mon, 07 Oct 2013, Austin Clements wrote:
> These tests check that both thread-local and global search tagging
> operations are race-free. They are currently known-broken because
> they aren't race-free.
> ---
> test/emacs | 26 ++
> 1 file changed, 26 insertions(+)
>
On Wed, 09 Oct 2013, Jani Nikula wrote:
> On Tue, 08 Oct 2013, Austin Clements wrote:
>> (Unfortunately, it's difficult to first demonstrate this problem with
>> a known-broken test because modern Linux kernels have argument length
>> limits in the megabytes, which makes Emacs really slow!)
>> -
On Mon, 07 Oct 2013, Austin Clements wrote:
> I was hacking on undo support for notmuch-emacs and sort of
> accidentally wrote this instead. This series fixes a set of
> well-known races where tagging from search-mode unexpectedly affects
> messages that arrived after the search was performed (a
current-prefix-arg directly.
One test needs to be changed to the new behaviour.
Best wishes
Mark
Mark Walters (2):
emacs: show: use interactive instead of current-prefix-arg
test: emacs-show: fix use of prefix-arg
emacs/notmuch-show.el | 12 +++-
emacs/notmuch.el |5
Currently notmuch-show looks at the prefix-arg directly via
current-prefix-arg. This changes it to use the interactive
specification.
---
emacs/notmuch-show.el | 12 +++-
emacs/notmuch.el |5 +++--
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/emacs/notmuch-sho
The test for elide-toggle functionality set the prefix arg
directly. Now that show uses the interactive specification just set
the argument directly.
---
test/emacs-show |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/test/emacs-show b/test/emacs-show
index ae70053..fb23
elsewhere in the future.
Since most of the diff is indentation I include a word-diff below
(which is why there is a cover letter and single patch).
Best wishes
Mark
Mark Walters (1):
emacs: don't show duplicate keys in help.
emacs/notmuch.el |
Previously notmuch-help would show two entries for keys in a parent
keymap that were over-ridden in the local keymap. This keeps track of
which keys have been seen and thus avoids these spurious duplicate
entries.
---
emacs/notmuch.el | 45 -
1 files
One test (reply to encrypted message in the crypto test) recently
started failing on some systems. The failure I saw were two extra
lines of the form
<87d2nbc5xg.fsf@host.i-did-not-set--mail-host-address--so-tickle-me>
The test pipes the output through
grep -v -e '^In-Reply-To:' -e '^References:'
On Sun, 13 Oct 2013, Austin Clements wrote:
> Code looks good. Two minor comments below.
That's great.
>
> Quoth Mark Walters on Oct 09 at 9:01 pm:
>> Currently notmuch-show looks at the prefix-arg directly via
>> current-prefix-arg. This changes it to use the in
Currently notmuch-show looks at the prefix-arg directly via
current-prefix-arg. This changes it to use the interactive
specification.
One test (for elide-toggle functionality) set the prefix arg
directly. Update this test to set the new argument directly.
---
This is version 2 of the patches at
i
Remove some unneeded nil arguments in notmuch-show calls.
---
This is really a patch on top of
id:1381649952-23122-1-git-send-email-markwalters1...@gmail.com as
passing three nil optional arguments out of four seems untidy. Since
these arguments are superfluous in any case just remove them.
cont
Hi
I have looked at the whole series and broadly it looks good. However, I
don't know this code so this is not a full review. I do have a few
comments: some of these may be plain wrong in which case my apologies!
On Wed, 16 Oct 2013, Jani Nikula wrote:
> This is in preparation of switching to
On Wed, 16 Oct 2013, Jani Nikula wrote:
> This is in preparation of switching to gmime header parsing. Accept
> "for" and "by" preceded by tabs in the received header. This is a bit
> flaky, but so is the whole guessing code.
I am happy with the change but I think a little more explanation of the
---
emacs/Makefile.local |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/emacs/Makefile.local b/emacs/Makefile.local
index a910aff..0b3099f 100644
--- a/emacs/Makefile.local
+++ b/emacs/Makefile.local
@@ -7,6 +7,7 @@ emacs_sources := \
$(dir)/notmuch.el \
$
d:1381498794-17000-1-git-send-email-markwalters1...@gmail.com as
well: without the key bindings that pick overrides show up twice in
help.
Best wishes
Mark
Mark Walters (5):
emacs: move pick from contrib into mainline
emacs: add pick to the Makefile
test: move the pick tests to the main test d
Since pick is now part of mainline we do not need to notify the user
that it has been loaded.
---
emacs/notmuch-pick.el |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-pick.el b/emacs/notmuch-pick.el
index a492214..9e73179 100644
--- a/emacs/notmuch-pick.el
+
---
test/notmuch-test |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/test/notmuch-test b/test/notmuch-test
index aa28bb0..71198da 100755
--- a/test/notmuch-test
+++ b/test/notmuch-test
@@ -62,6 +62,7 @@ TESTS="
emacs-address-cleaning
emacs-hello
emacs-show
+ ema
This looks good to me +1. It makes the code clearer and nicer to read as
well as giving a better user experience, and it is makes fixing the long
standing tagging races simpler.
I have a couple of docstring comments:
In patch 2 perhaps notmuch-tag-completions could have a docstring.
In Patch 4
Hi
On Wed, 23 Oct 2013, Austin Clements wrote:
> Quoth Mark Walters on Oct 22 at 10:43 pm:
>> This looks good to me +1. It makes the code clearer and nicer to read as
>> well as giving a better user experience, and it is makes fixing the long
>> standing tagging races sim
In might of id:20131023154404.ge20...@mit.edu I am now happy with this
series. LGTM +1
Best wishes
Mark
On Wed, 23 Oct 2013, Austin Clements wrote:
> This is v2 of id:1382471457-26056-1-git-send-email-amdra...@mit.edu.
> It improves some documentation strings, fixes one bug, and elimintes
>
Tested and LGTM +1
Best wishes
Mark
On Thu, 24 Oct 2013, Austin Clements wrote:
> Previously, when a user fully completed a tag operation, they had to
> press space to begin entering another tag operation. This is
> different from, say, shell file name completion, which typically
> inserts a
On Thu, 24 Oct 2013, Austin Clements wrote:
> This is v2 of id:1381185201-25197-1-git-send-email-amdra...@mit.edu.
> It fixes several comments from Mark and Jani. This has been rebased
> on top of the tag completion changes, so doing * from a large search
> buffer will no longer crash. Hence,
> One thing to think about: do we want to keep the name "pick"? If not
> then now is the last sensible time to change it. I don't have any
> better suggestion however.
There have been some suggestions on irc and I give some pros and cons
keep the name pick
tree/treeview
navigation vie
A standard way to unset a key binding is local-unset-key which is equivalent to
(define-key (current-local-map) key nil)
Currently notmuch-help gives an error and fails if a user has done this.
To fix this we check for a nil binding before adding a help line.
---
emacs/notmuch.el | 25
be trivial.
Mark Walters (4):
emacs: help: check for nil key binding
emacs: help: remove duplicate bindings
emacs: help: remap support
contrib: pick: use remap for the over-ridden global bindings
contrib/notmuch-pick/notmuch-pick.el |8 ++--
emacs/notmuch.el
If the user (or a mode) overrides a keybinding from the common keymap
in one of the modes then both help lines appear in the help screen
even though only one of the is applicable.
Fix this by checking if we already have that key binding. We do this
by constructing an list of (key . docstring) pair
If a user or mode uses remap to rebind a keybinding then it appears in
the help as a line New function docstring. Special
case these remapping lines so that we print the actual binding.
---
emacs/notmuch.el | 21 ++---
1 files changed, 14 insertions(+), 7 deletions(-)
diff --gi
Following a suggestion by Austin in id:20130915153642.gy1...@mit.edu
we use remap for the over-riding bindings in pick. This means that if
the user modifies the global keymap these modifications will happen in
the pick versions of them too.
[Pick overrides these to do things like close the message
; rather than just "tree"
in docstrings etc.)
For any users this will mean they need to update their require
'notmuch-pick to require 'notmuch-tree.
Best wishes
Mark
Mark Walters (4):
contrib: pick: move lisp names from pick to tree
pick: Change the test names and print
Also fixup run-tests.sh
---
contrib/notmuch-pick/run-tests.sh|2 +-
contrib/notmuch-pick/test/emacs-pick | 210 --
contrib/notmuch-pick/test/emacs-tree | 210 ++
3 files changed, 211 insertions(+), 211 deletions(-)
delete m
Change from the pick name to the tree name
---
contrib/notmuch-pick/test/emacs-pick | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/contrib/notmuch-pick/test/emacs-pick
b/contrib/notmuch-pick/test/emacs-pick
index fae6e9e..2cc3edc 100755
--- a
Please ignore this version. There were stale files around in my git tree
which meant it misses the actual key pick->tree move but all still
worked (and all tests passed)!
I will resend once I have tested on a fresh clone
Best wishes
Mark
On Sat, 26 Oct 2013, Mark Walters wrote:
> Afte
Change from the pick name to the tree name
---
contrib/notmuch-pick/test/emacs-pick | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/contrib/notmuch-pick/test/emacs-pick
b/contrib/notmuch-pick/test/emacs-pick
index fae6e9e..2cc3edc 100755
--- a
clone, and the
actual move of the notmuch-pick.el file itself to notmuch-tree.el is
also included.
Best wishes
Mark
Mark Walters (4):
contrib: pick: move lisp names from pick to tree
pick: Change the test names and print out for pick tests
pick: rename test outputs from pick to tree
pick
Also fixup run-tests.sh
---
contrib/notmuch-pick/run-tests.sh|2 +-
contrib/notmuch-pick/test/emacs-pick | 210 --
contrib/notmuch-pick/test/emacs-tree | 210 ++
3 files changed, 211 insertions(+), 211 deletions(-)
delete m
---
emacs/Makefile.local |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/emacs/Makefile.local b/emacs/Makefile.local
index a910aff..92467a3 100644
--- a/emacs/Makefile.local
+++ b/emacs/Makefile.local
@@ -7,6 +7,7 @@ emacs_sources := \
$(dir)/notmuch.el \
$
There are some crufty declare-functions and requires in notmuch-tree:
since it requires notmuch.el itself this all works but in preparation
for the move to mainline tidy this up.
---
contrib/notmuch-pick/notmuch-tree.el | 13 -
1 files changed, 4 insertions(+), 9 deletions(-)
diff -
Now the test is in mainline we can remove the check that emacs exists.
---
test/emacs-tree |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/test/emacs-tree b/test/emacs-tree
index 05ce85d..4e3b624 100755
--- a/test/emacs-tree
+++ b/test/emacs-tree
@@ -6,13 +6,6 @@ tes
Now tree is autoloaded we don't need to "require it" in the test.
---
test/emacs-tree |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/test/emacs-tree b/test/emacs-tree
index 4e3b624..4bdfddd 100755
--- a/test/emacs-tree
+++ b/test/emacs-tree
@@ -9,7 +9,6 @@ add_email_
Move a couple of the search mode specifc caller helpers for tree from
tree into notmuch.el.
---
emacs/notmuch-tree.el | 18 --
emacs/notmuch.el | 14 ++
2 files changed, 14 insertions(+), 18 deletions(-)
diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.
We want to autoload notmuch-tree.el so include it as a require in
notmuch.el. To avoid circular dependency we need to move one
keybinding from notmuch-tree.el to notmuch.el: it makes sense for it
to be defined there anyway.
Since tree is now autoloaded there is no need to print a message when
it i
Move the keybinding and show specific helper from tree.el to show.el
---
emacs/notmuch-show.el | 10 ++
emacs/notmuch-tree.el | 12 +---
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 9e8b9c0..f00273a 100644
Add the main entry "z" to notmuch-tree to the common keymap.
---
emacs/notmuch-lib.el |1 +
emacs/notmuch-tree.el |1 -
2 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index e7c5c97..921ed20 100644
--- a/emacs/notmuch-lib.el
+++ b
-email-markwalters1...@gmail.com but
rebasing either way would be easy.
Best wishes
Mark
Mark Walters (11):
emacs: move notmuch-help to lib
emacs: tree: remove unneeded declarations
emacs: move notmuch-tree from contrib to mainline
emacs: add tree to the makefile
test: move emacs-tre
notmuch-help is in notmuch.el not notmuch-lib.el and this is
incovenient for the way pick/tree uses it. I think lib makes more
sense anyway so move it there.
---
emacs/notmuch-lib.el | 87 ++
emacs/notmuch.el | 87
Hi
Thanks for the review
On Wed, 30 Oct 2013, Tomi Ollila wrote:
> On Wed, Oct 30 2013, Mark Walters wrote:
>
>> This is a more complete version of the move of pick/tree to
>> mainline. The previous version was at
>> id:1382257699-29860-1-git-send-email-markwalter
Add the main entry "z" to notmuch-tree to the common keymap.
---
emacs/notmuch-lib.el |1 +
emacs/notmuch-tree.el |1 -
2 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index e7c5c97..921ed20 100644
--- a/emacs/notmuch-lib.el
+++ b
Move a couple of the search mode specifc caller helpers for tree from
tree into notmuch.el.
---
emacs/notmuch-tree.el | 18 --
emacs/notmuch.el | 14 ++
2 files changed, 14 insertions(+), 18 deletions(-)
diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.
Now tree is included by default we don't need to "require it" in the
test.
---
test/emacs-tree |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/test/emacs-tree b/test/emacs-tree
index 4e3b624..4bdfddd 100755
--- a/test/emacs-tree
+++ b/test/emacs-tree
@@ -9,7 +9,6 @@ a
This just fixes the commit message in patches 7 and 8 to not say
autoload as that means something different.
Best wishes
Mark
Mark Walters (5):
emacs: minimal change to load notmuch-tree by default
test: tree: remove require from tests
emacs: move search based tree functions to notmuch.el
Move the keybinding and show specific helper from tree.el to show.el
---
emacs/notmuch-show.el | 10 ++
emacs/notmuch-tree.el | 12 +---
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 9e8b9c0..f00273a 100644
We want to load notmuch-tree when notmuch is loaded, so include it as
a require in notmuch.el. To avoid circular dependency we need to move
one keybinding from notmuch-tree.el to notmuch.el: it makes sense for
it to be defined there anyway.
Since tree is now loaded by default there is no need to p
remaps are a rather unusual keymap consisting of "first key" 'remap
and then "second-key" the remapped-function. Thus we do the
documentation for it separately.
---
emacs/notmuch-lib.el | 25 ++---
1 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-
Following a suggestion by Austin in id:20130915153642.gy1...@mit.edu
we use remap for the over-riding bindings in pick. This means that if
the user modifies the global keymap these modifications will happen in
the tree-view versions of them too.
[tree-view overrides these to do things like close t
A standard way to unset a key binding is local-unset-key which is equivalent to
(define-key (current-local-map) key nil)
Currently notmuch-help gives an error and fails if a user has done this.
To fix this we only add a help line if the binding is non-nil.
---
emacs/notmuch-lib.el |2 +-
1
If the user (or a mode) overrides a keybinding from the common keymap
in one of the modes then both help lines appear in the help screen
even though only one of the is applicable.
Fix this by checking if we already have that key binding. We do this
by constructing an list of (key . docstring) pair
The actual documentation function notmuch-describe-keymap was getting
rather complicated so split out the code for a single key into its own
function notmuch-describe-key.
---
emacs/notmuch-lib.el | 42 +-
1 files changed, 25 insertions(+), 17 deletions(-)
27;s query about passing down the base keymap
for the remapping.
Best wishes
Mark
Mark Walters (5):
emacs: help: check for nil key binding
emacs: help: remove duplicate bindings
emacs: help: split out notmuch-describe-key as a function
emacs: help: add a special function to deal with rema
The actual documentation function notmuch-describe-keymap was getting
rather complicated so split out the code for a single key into its own
function notmuch-describe-key.
---
emacs/notmuch-lib.el | 42 +-
1 files changed, 25 insertions(+), 17 deletions(-)
A standard way to unset a key binding is local-unset-key which is equivalent to
(define-key (current-local-map) key nil)
Currently notmuch-help gives an error and fails if a user has done this.
To fix this we only add a help line if the binding is non-nil.
---
emacs/notmuch-lib.el |2 +-
1
If the user (or a mode) overrides a keybinding from the common keymap
in one of the modes then both help lines appear in the help screen
even though only one of them is applicable.
Fix this by checking if we already have that key binding. We do this
by constructing an list of (key . docstring) pai
To support key remapping in emacs help we need to know the base keymap
when looking at the remapping. keep track of this while we recurse
down the sub-keymaps in help.
---
emacs/notmuch-lib.el |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-lib.el b/emac
Following a suggestion by Austin in id:20130915153642.gy1...@mit.edu
we use remap for the over-riding bindings in pick. This means that if
the user modifies the global keymap these modifications will happen in
the tree-view versions of them too.
[tree-view overrides these to do things like close t
Add an argument to notmuch-help for the mode to display help for.
This aids testing of the base-keymap case in remapping in emacs help.
It is only intended for testing, ie not for master (but it does no harm)
---
emacs/notmuch-lib.el |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
remaps are a rather unusual keymap consisting of "first key" 'remap
and then "second-key" the remapped-function. Thus we do the
documentation for it separately.
---
emacs/notmuch-lib.el | 22 --
1 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-lib
+(desc-alist (notmuch-describe-keymap keymap ua-keys keymap))
(desc-list (mapcar (lambda (arg) (concat (car arg) "\t" (cdr
arg))) desc-alist))
(desc (mapconcat #'identity desc-list "\n")))
(setq doc (replace-match desc 1 1 doc))
Hi
David found a bug in the this remap/help series. He has a global
keybinding of "C-c s" for notmuch-search and this causes help in
tree-mode to hang.
I have mostly diagnosed this: the problem comes that all the construct
help routines are inside a string-match/replace-match pair. Somewhere
in t
esc (mapconcat #'identity desc-list "\n")))
-desc
+ (desc-list (mapcar (lambda (arg) (concat (car arg) "\t"
(cdr arg))) desc-alist)))
+(mapconcat #'identity desc-list "\n")))))
(setq doc (replace-match desc 1 1 doc)))
Following a suggestion by Austin in id:20130915153642.gy1...@mit.edu
we use remap for the over-riding bindings in pick. This means that if
the user modifies the global keymap these modifications will happen in
the tree-view versions of them too.
[tree-view overrides these to do things like close t
If the user (or a mode) overrides a keybinding from the common keymap
in one of the modes then both help lines appear in the help screen
even though only one of them is applicable.
Fix this by checking if we already have that key binding. We do this
by constructing an list of (key . docstring) pai
To support key remapping in emacs help we need to know the base keymap
when looking at the remapping. keep track of this while we recurse
down the sub-keymaps in help.
---
emacs/notmuch-lib.el |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-lib.el b/emac
The actual documentation function notmuch-describe-keymap was getting
rather complicated so split out the code for a single key into its own
function notmuch-describe-key.
---
emacs/notmuch-lib.el | 42 +-
1 files changed, 25 insertions(+), 17 deletions(-)
A standard way to unset a key binding is local-unset-key which is equivalent to
(define-key (current-local-map) key nil)
Currently notmuch-help gives an error and fails if a user has done this.
To fix this we only add a help line if the binding is non-nil.
---
emacs/notmuch-lib.el |2 +-
1
remaps are a rather unusual keymap consisting of "first key" 'remap
and then "second-key" the remapped-function. Thus we do the
documentation for it separately.
---
emacs/notmuch-lib.el | 22 --
1 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-lib
The routines that construct the help page in notmuch-lib rely on
match-data being preserved across some fairly complicated code. This
is currently valid but will not be when this series is finished. Thus
place everything between the string-match and replace-match inside a
save-match-data.
---
emac
In emacs 24.3+ the stdout/stderr from externally displaying an
attachment gets inserted into the show buffer. This is caused by
changes in mm-display-external in mm-decode.el.
Ideally, we would put this output in the notmuch errors buffer but the
handler is called asynchronously so we don't know w
---
This is news for notmuch-tree. I am not sure if it is appropriate to
have this big a section but I didn't see anywhere else obvious to put
the information.
I am also not certain about what markup to be using for NEWS so that
is just a best guess.
Best wishes
Mark
NEWS | 30
---
Remove all the notmuch-pick contrib directory. Everything relevant is
in mainline.
Best wishes
Mark
contrib/notmuch-pick/README | 43 --
contrib/notmuch-pick/TODO | 29 ---
contrib/notmuch-pick/run-tests.sh | 46 ---
Added function notmuch-subkeymap-help to describe keybindings of a
subkeymap (eg after . or c in notmuch-search and notmuch-show).
---
This a reimplementation of Tomi's patch at
id:1377346540-7094-1-git-send-email-tomi.oll...@iki.fi but the help
screen shows docstrings rather than function names.
---
Update following Tomi's suggestions.
Best wishes
Mark
NEWS | 32
1 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/NEWS b/NEWS
index 9434af9..d0d5300 100644
--- a/NEWS
+++ b/NEWS
@@ -33,6 +33,38 @@ Improved `notmuch new` performance for uncha
In current emacs (24.3) select-active-regions is set to t by
default. The reply insertion code sets the region to the quoted
message to make it easy to delete (kill-region or C-w). These two
things combine to put the quoted message in the primary selection.
This is not what the user wanted and is
On Sun, 17 Nov 2013, Tomi Ollila wrote:
> On Sun, Nov 17 2013, Jameson Graef Rollins wrote:
>
>> On Sun, Nov 17 2013, Mark Walters wrote:
>>> In current emacs (24.3) select-active-regions is set to t by
>>> default. The reply insertion code sets the region to the
In emacs 24.3+ the stdout/stderr from externally displaying an
attachment gets inserted into the show buffer. This is caused by
changes in mm-display-external in mm-decode.el.
Ideally, we would put this output in the notmuch errors buffer but the
handler is called asynchronously so we don't know w
The decisions of when to mark messages read in notmuch-show has caused
confusion/irritation (several discussions on irc and the mailing list
eg the thread starting at id:87hadi0xse.fsf@boo.workgroup). This is an
attempt to get some logic that people are happier with.
Some examples of the current p
901 - 1000 of 3168 matches
Mail list logo
