[PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests

2011-11-01 Thread Pieter Praet
On Tue, 01 Nov 2011 20:57:59 +0100, Pieter Praet wrote: > On Mon, 3 Oct 2011 18:47:18 +0200, Thomas Jost > wrote: > [...] > - @ "Verify that sent messages are saved/searchable (via FCC)": > > This doesn't need an EMACS prereq. > [...] My mistake,

[PATCH 03/13] test: add 'Emacs' prereq to dependent 'crypto' tests

2011-11-01 Thread Pieter Praet
On Tue, 01 Nov 2011 20:56:17 +0100, Pieter Praet wrote: > On Mon, 3 Oct 2011 18:47:17 +0200, Thomas Jost > wrote: > [...] > > Also, you appear to have given *every* test the EMACS+GPG prereq, > while only the ones using `emacs_deliver_message' require EMACS. > > [...]

[PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests

2011-11-02 Thread Pieter Praet
On Tue, 01 Nov 2011 14:17:51 -0700, Jameson Graef Rollins wrote: > On Tue, 1 Nov 2011 20:49:11 +0100, Pieter Praet wrote: > > -test_expect_success 'emacs delivery of signed message' \ > > +test_expect_success GPG 'emacs delivery of signed message' \ > > Hi, Pieter and Th

set test prereqs (Emacs, GDB, GPG) v4

2011-11-02 Thread Pieter Praet
On Tue, 1 Nov 2011 22:20:25 +0200, Ali Polatel wrote: > On Tue, Nov 01, 2011 at 08:49:10PM +0100, Pieter Praet wrote: > >Rebased to current master. > > > >Previous version: > > id:"1307016220-17509-1-git-send-email-pieter at praet.org" > > > >

[PATCH] Repeatability when copying a whole directory into a new one.

2011-11-03 Thread Pieter Praet
On Mon, 31 Oct 2011 23:59:49 -0300, David Bremner wrote: > On Fri, 30 Sep 2011 01:26:46 +0200, Thomas Schwinge > wrote: > > This new test currently fails -- but it shouldn't. > > --- > > > > Hi! > > > > I found this while manually copying directories and running notmuch new. > > > > Am I

[PATCH] test: use dtach(1) instead of screen(1) in emacs tests.

2011-11-11 Thread Pieter Praet
On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins wrote: > From: Tomi Ollila > > dtach is lighter than screen and is not setuid/setgid program so > TMPDIR does not get reset by dynamic loader when executed. > `dtach' may be lighter than `screen', but contrary to my expectations, it

[PATCH] test: json show format of message with inline attachment with filename

2011-11-11 Thread Pieter Praet
On Fri, 1 Jul 2011 06:03:50 +0400, Dmitry Kurochkin wrote: > The patch adds a test to check that json show format includes > filenames for attachments with inline disposition. > --- > > Carl, I owe you this test case for my patch that added filenames > for inline attachments :) > > Regards, >

[PATCH] Do not query on notmuch-search exit

2011-11-11 Thread Pieter Praet
On Sat, 08 Oct 2011 20:46:44 -0700, Jameson Graef Rollins wrote: > On Sat, 27 Aug 2011 14:38:26 +0200, Michal Sojka > wrote: > > Emacs 23.2 queries by default about killing existing processes. This > > is annoying when one wants to interrupt long search with 'q' key. > > Disable this behavior

[PATCH] Store "from" and "subject" headers in the database.

2011-11-11 Thread Pieter Praet
On Sun, 6 Nov 2011 12:17:36 -0500, Austin Clements wrote: > This is a rebase and cleanup of Istvan Marko's patch from > id:m3pqnj2j7a.fsf at zsu.kismala.com > Fantastic performance improvement Austin! This should be merged in ASAP. BTW, compacting the db from time to time also has a

[PATCH] Store "from" and "subject" headers in the database.

2011-11-11 Thread Pieter Praet
On Fri, 11 Nov 2011 02:33:38 +0100, Pieter Praet wrote: > On Sun, 6 Nov 2011 12:17:36 -0500, Austin Clements > wrote: > > This is a rebase and cleanup of Istvan Marko's patch from > > id:m3pqnj2j7a.fsf at zsu.kismala.com > > > > Fantastic

[PATCH] emacs: Use a single buffer invisibility spec to fix quadratic search cost.

2011-11-11 Thread Pieter Praet
On Thu, 10 Nov 2011 14:22:30 -0500, servilio wrote: > On 10 November 2011 08:33, Sebastian Spaeth wrote: > > On Tue, ?8 Nov 2011 21:55:28 -0500, Austin Clements > > wrote: > >> ?emacs/notmuch.el | ? 11 +++ > >> ?1 files changed, 3 insertions(+), 8 deletions(-) > > > > > > Tested and

[PATCH] emacs: Use a single buffer invisibility spec to fix quadratic search cost.

2011-11-15 Thread Pieter Praet
On Thu, 10 Nov 2011 23:53:41 -0500, Austin Clements wrote: > Quoth Pieter Praet on Nov 11 at 4:04 am: > > On Thu, 10 Nov 2011 14:22:30 -0500, servilio wrote: > > > On 10 November 2011 08:33, Sebastian Spaeth > > > wrote: > > > > On Tue, ?8 N

[PATCH] test: use dtach(1) instead of screen(1) in emacs tests.

2011-11-15 Thread Pieter Praet
On Fri, 11 Nov 2011 10:09:17 +0200, Tomi Ollila wrote: > On Fri, 11 Nov 2011 01:17:37 +0100, Pieter Praet wrote: > > On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins > finestructure.net> wrote: > > > From: Tomi Ollila > > > > > > dtach is li

[PATCH] add `tag:' prefix to `--output=tags' results

2011-11-16 Thread Pieter Praet
On Sun, 13 Nov 2011 16:14:35 +0200, Jani Nikula wrote: > On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner > wrote: > > On Thu, 30 Jun 2011 10:20:29 +0200, Pieter Praet > > wrote: > > > Alter `do_search_tags()' to prepend each result with `tag:', >

[PATCH 00/13] Test prereqs and screen-based Emacs tests

2011-11-16 Thread Pieter Praet
On Sun, 13 Nov 2011 13:46:30 -0400, David Bremner wrote: > On Tue, 01 Nov 2011 20:54:49 +0100, Pieter Praet wrote: > > > > I'll be commenting on these modified commits where needed, and have > > re-submitted my original series (rebased to current master) in a new > >

[PATCH 6/6] emacs: make `notmuch-search-operate-all' operate on threads, not messages

2011-11-16 Thread Pieter Praet
On Sat, 12 Nov 2011 11:35:02 -0500, Austin Clements wrote: > Quoth David Bremner on Nov 12 at 11:13 am: > > On Sun, 10 Jul 2011 17:55:35 +0200, Pieter Praet > > wrote: > > > In order to be consistent with `notmuch-search-{add,remove}-tag' > > > ("+&qu

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

2011-11-16 Thread Pieter Praet
No further explanation needed. --- NEWS | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/NEWS b/NEWS index 6c064da..daec4ad 100644 --- a/NEWS +++ b/NEWS @@ -130,7 +130,7 @@ Ruby bindings changes - - Wrap new library functions

[PATCH 0/6] Rebase of Pieter's "set test prereqs"

2011-11-16 Thread Pieter Praet
n instead of > "which", > as suggested in [3]. > > Tested with and without dtach. A previous version of this series was also > without emacs/gpg in a chroot, but not this one :) > > [1] id:"874ny4fcdz.fsf at praet.org" > [2] id:"1317660447

[PATCH] emacs: Use a single buffer invisibility spec to fix quadratic search cost.

2011-11-16 Thread Pieter Praet
On Tue, 15 Nov 2011 12:17:59 -0500, servilio wrote: > Hi, > > Given that this change is about display of search results, I have the > suspicion that the following two factors might be more relevant: > > - size of the Emacs frame: bigger would mean more threads to show > > - composition of the

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

2011-11-16 Thread Pieter Praet
On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila wrote: > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet wrote: > > No further explanation needed. > > --- > > NEWS | 14 +++--- > > 1 files changed, 7 insertions(+), 7 deletions(-) > > The 'No fu

[PATCH] emacs: breakout notmuch-show-advance functionality from notmuch-show-advance-and-archive

2011-11-16 Thread Pieter Praet
fer, and displays the next > +thread from the search from which this thread was originally > +shown." > + (interactive) > + (if (notmuch-show-advance) > + (notmuch-show-archive-thread))) > > (defun notmuch-show-rewind () > "Backup through the thread, (revers

Winter is coming [upcoming release 0.10]

2011-11-17 Thread Pieter Praet
On Wed, 16 Nov 2011 18:17:46 -0400, David Bremner wrote: > On Wed, 16 Nov 2011 21:37:48 +0100, Pieter Praet wrote: > > Thanks David, awesome job! > > > > > > You're very welcome. I hope you still feel that way when you see how I > amended your commits ;).

0.11 is frozen, please update NEWS

2012-01-12 Thread Pieter Praet
On Sun, 25 Dec 2011 15:55:43 -0400, David Bremner wrote: > > Well, it's -19C outside, so guess that is appropriate. > > I have merged master to release in preparation for release. There should > only be additions to NEWS or fixes for serious bugs for branch release > until 0.11 is out the door.

[PATCH] emacs: breakout notmuch-show-advance functionality from notmuch-show-advance-and-archive

2012-01-12 Thread Pieter Praet
On Wed, 16 Nov 2011 23:47:53 +0100, Pieter Praet wrote: > On Sun, 13 Nov 2011 13:16:48 -0800, Jameson Graef Rollins finestructure.net> wrote: > > This patch breaks out much of the functionality of > > notmuch-show-advance-and-archive into a new function: > > notmuch

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

2012-01-12 Thread Pieter Praet
On Thu, 17 Nov 2011 08:21:59 +0200, Jani Nikula wrote: > On Nov 16, 2011 11:39 PM, "Pieter Praet" wrote: > > > > On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila > wrote: > > > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet > wrot

[PATCH 0/6] Rebase of Pieter's "set test prereqs"

2012-01-12 Thread Pieter Praet
On Thu, 17 Nov 2011 11:14:11 +0100, Thomas Jost wrote: > On Wed, 16 Nov 2011 21:50:17 +0100, Pieter Praet wrote: > > On Wed, 16 Nov 2011 15:33:49 +0100, Thomas Jost > > wrote: > > > Hello list, > > > > > > This is another rebased version of Pieter's

[PATCH] Output unmodified Content-Type header value for JSON format.

2012-01-12 Thread Pieter Praet
On Tue, 22 Nov 2011 22:40:21 -0500, Austin Clements wrote: > Quoth Jameson Graef Rollins on Nov 20 at 12:10 pm: > > The open question seems to be how we handle the content encoding > > parameters. My argument is that those should either be used by notmuch > > to properly encode the content for

[PATCH v2] Output unmodified Content-Type header value for JSON format.

2012-01-12 Thread Pieter Praet
On Sun, 20 Nov 2011 22:35:42 +0400, Dmitry Kurochkin wrote: > On Sat, 19 Nov 2011 08:59:29 -0400, David Bremner > wrote: > > On Sat, 19 Nov 2011 08:18:41 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > Before the change, notmuch used g_mime_content_type_to_string(3) > > > function to output

[PATCH v2] emacs: logically group def{custom,face}s

2012-01-12 Thread Pieter Praet
To allow for expansion whilst keeping everything tidy and organized, move all defcustom/defface variables to the following subgroups, defined in notmuch-lib.el: - Hello - Search - Show - Send - Crypto - Hooks - Appearance - External Commands As an added benefit, defcustom keyword args are now

[PATCH v3 00/7] test: (hopefully) better test prerequisites

2012-01-12 Thread Pieter Praet
On Sun, 27 Nov 2011 22:36:12 +0400, Dmitry Kurochkin wrote: > Changes: > > v3 since v2: > > * rebased the remaining patches on current master > > v2 since v1: > > * Add test_require_external_prereq function to explicitly check for > external dependencies, use it in test_emacs. > > *

[PATCH] test: don't bail out of `run_emacs' too early when missing prereqs

2012-01-12 Thread Pieter Praet
When running the Emacs tests in verbose mode, only the first missing prereq is reported because the `run_emacs' function is short-circuited early: #+begin_example emacs: Testing emacs interface missing prerequisites: [0] emacs(1) skipping test: [0] Basic notmuch-hello view in

Code Style Bikeshed 1/n: Break before Brace or Brace before Break?

2012-01-12 Thread Pieter Praet
On Sun, 18 Dec 2011 20:18:03 +0400, Dmitry Kurochkin wrote: > On Sun, 18 Dec 2011 18:12:51 +0200, Tomi Ollila wrote: > > On Sun, 18 Dec 2011 19:50:52 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > +1 for the former. > > > > +1 > > > > > How about indenting with spaces+tabs vs indenting

RFC: use the XDG Base Directory Specification for configuration data

2012-01-12 Thread Pieter Praet
On Wed, 21 Dec 2011 11:35:37 -0800, Jameson Graef Rollins wrote: > On Wed, 21 Dec 2011 07:44:16 -0400, David Bremner > wrote: > [SNIP] > > > On my machine all of the programs (except nottoomuch ;) ) that use > > ~/.config are gui based, and a bunch of them store binary blobs (or not > > plain

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2012-01-12 Thread Pieter Praet
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins wrote: > Since message-ids necessarily match just a single message, there's no > reason to do a search for the id before viewing the actual message; > the search just becomes an extra screen to click through. Clicking on > an id: links

[PATCH 1/3] emacs: s/buttonise/buttonize/g

2012-01-12 Thread Pieter Praet
"Worldwide, -ize endings prevail in scientific writing and are commonly used by many international organizations, such as the ISO and the WHO. The European Union switched from -ize to -ise some years ago in its English language publications, and this resulted in the coexistence of the -ize

[PATCH 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists

2012-01-12 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-found-target-p): new predicate function that uses notmuch(1) 'count' to see if a query turns up any results. * emacs/notmuch-show.el (notmuch-show-if-found): new function that only shows a message/thread if present in the database and otherwise returns an

[PATCH 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state

2012-01-12 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-buttonized-link-present), * emacs/notmuch-show.el (notmuch-show-buttonized-link-present-and-unread), * emacs/notmuch-show.el (notmuch-show-buttonized-link-missing): new faces for buttonized id: links. * emacs/notmuch-show.el (notmuch-show-found-target-p):

revised patch for gmime init, with test.

2012-01-12 Thread Pieter Praet
On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner wrote: > It turns out that our existing (trivial) python test is enough to > catch this bug, but the corpus needs to be augmented. This > augmentation is a bit intrusive so I'm thinking of cherry-picking only > the actual fix to the release

[PATCH] cli: factor out config handling code to get/set lists.

2012-01-12 Thread Pieter Praet
On Mon, 12 Dec 2011 14:26:21 -0400, David Bremner wrote: > On Sun, 11 Dec 2011 20:41:53 +0400, Dmitry Kurochkin gmail.com> wrote: > > Hi David. > > > > On Sun, 11 Dec 2011 12:07:51 -0400, David Bremner > > wrote: > > > From: David Bremner > > > > > > Two new internal routines are created

[PATCH] test: cli: getting/setting/removing config values

2012-01-12 Thread Pieter Praet
Should have come before commit 1df71b55 --- test/config | 88 + test/notmuch-test |1 + 2 files changed, 89 insertions(+), 0 deletions(-) create mode 100755 test/config diff --git a/test/config b/test/config new file mode 100755

[PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script

2012-01-12 Thread Pieter Praet
On Mon, 12 Dec 2011 22:50:04 +0200, Jani Nikula wrote: > Support nil value for notmuch-poll-script to run "notmuch new" instead of > an external script, and make this the new default. "notmuch new" is run > using the configured notmuch-command. > > This allows taking better advantage of the

[PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

2012-01-12 Thread Pieter Praet
Less code, same results, without sacrificing readability. --- emacs/notmuch-address.el |6 +++--- emacs/notmuch-hello.el | 20 ++-- emacs/notmuch-show.el| 12 ++-- emacs/notmuch.el |8 4 files changed, 23 insertions(+), 23 deletions(-)

revised patch for gmime init, with test.

2012-01-14 Thread Pieter Praet
On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner wrote: > On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet wrote: > > On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner > > wrote: > > > with differing hashes), this has the potential of causing confusion > > and

revised patch for gmime init, with test.

2012-01-14 Thread Pieter Praet
On Fri, 13 Jan 2012 05:05:35 -0400, David Bremner wrote: > On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner > wrote: > > On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet > > wrote: > > > On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner > > > wro

[PATCH] test: cli: getting/setting/removing config values

2012-01-14 Thread Pieter Praet
On Thu, 12 Jan 2012 23:42:04 -0400, David Bremner wrote: > On Thu, 12 Jan 2012 18:30:01 +0100, Pieter Praet wrote: > > Should have come before commit 1df71b55 > > This doesn't seem like an especially helpful commit > message. Editorializing is ok, I guess, but m

[PATCH] test: cli: getting/setting/removing config values

2012-01-14 Thread Pieter Praet
Full test coverage for getting, setting and removing options in notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config). --- Please *do* take note of the FIXME in the last test! test/config | 88 + test/notmuch-test |1

[PATCH v2] Output unmodified Content-Type header value for JSON format.

2012-01-14 Thread Pieter Praet
On Thu, 12 Jan 2012 23:16:29 -0400, David Bremner wrote: > On Thu, 12 Jan 2012 18:08:08 +0100, Pieter Praet wrote: > > > > - The previous point is a bit of a counterargument to this, but in > > > > I couls separate it. I made is a single patch to avoid having a >

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

2012-01-14 Thread Pieter Praet
On Thu, 12 Jan 2012 23:11:35 -0400, David Bremner wrote: > On Thu, 12 Jan 2012 18:06:14 +0100, Pieter Praet wrote: > > That would indeed have been the most sensible thing to do. > > > > Could someone (who -unlike me- has already submitted his/her public SSH > >

[PATCH v2] emacs: logically group def{custom,face}s

2012-01-14 Thread Pieter Praet
On Thu, 12 Jan 2012 23:31:34 -0400, David Bremner wrote: > On Thu, 12 Jan 2012 18:12:16 +0100, Pieter Praet wrote: > > To allow for expansion whilst keeping everything tidy and organized, > > move all defcustom/defface variables to the following subgroups, > > defi

[PATCH] emacs: logically group def{custom,face}s

2012-01-14 Thread Pieter Praet
To allow for expansion whilst keeping everything tidy and organized, move all defcustom/defface variables to the following subgroups, defined in notmuch-lib.el: - Hello - Search - Show - Send - Crypto - Hooks - External Commands - Appearance As an added benefit, defcustom keyword args are now

[PATCH v2] emacs: logically group def{custom,face}s

2012-01-14 Thread Pieter Praet
On Fri, 13 Jan 2012 16:15:59 +, David Edmondson wrote: > On Thu, 12 Jan 2012 23:31:34 -0400, David Bremner > wrote: > > On Thu, 12 Jan 2012 18:12:16 +0100, Pieter Praet > > wrote: > > > To allow for expansion whilst keeping everything tidy and organized, >

[PATCH] test: don't bail out of `run_emacs' too early when missing prereqs

2012-01-14 Thread Pieter Praet
On Thu, 12 Jan 2012 21:34:29 +0400, Dmitry Kurochkin wrote: > On Thu, 12 Jan 2012 18:16:59 +0100, Pieter Praet wrote: > > When running the Emacs tests in verbose mode, only the first missing > > prereq is reported because the `run_emacs' function is short-circ

[PATCH] test: don't bail out of `run_emacs' too early when missing prereqs

2012-01-14 Thread Pieter Praet
When running the Emacs tests in verbose mode, only the first missing prereq is reported because the `run_emacs' function is short-circuited early: #+begin_example emacs: Testing emacs interface missing prerequisites: [0] emacs(1) skipping test: [0] Basic notmuch-hello view in

[PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

2012-01-14 Thread Pieter Praet
On Fri, 13 Jan 2012 08:23:55 +, David Edmondson wrote: > On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet wrote: > > Less code, same results, without sacrificing readability. > > +1, but why not replace non-branching `if' with `when' as well? I was planning to do that w

[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-14 Thread Pieter Praet
Less code, same results, without sacrificing readability. --- emacs/notmuch-show.el | 20 +--- emacs/notmuch-wash.el | 47 +++ emacs/notmuch.el | 28 +--- 3 files changed, 45 insertions(+), 50

[PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

2012-01-14 Thread Pieter Praet
On Fri, 13 Jan 2012 16:06:17 +, David Edmondson wrote: > On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet wrote: > > Less code, same results, without sacrificing readability. > > Does this change correctly re-indent the line following the if/unless? It does... Or so I thou

[PATCH] Output unmodified Content-Type header value for JSON format.

2012-01-14 Thread Pieter Praet
On Thu, 12 Jan 2012 12:28:40 -0500, Austin Clements wrote: > Quoth Pieter Praet on Jan 12 at 6:07 pm: > > On Tue, 22 Nov 2011 22:40:21 -0500, Austin Clements > > wrote: > > > Quoth Jameson Graef Rollins on Nov 20 at 12:10 pm: > > > > The open question s

[PATCH v2] emacs: Cycle through notmuch buffers rather than jumping to the last.

2012-01-14 Thread Pieter Praet
return buffer)) > + > +(if first > + ;; If the first one we found is any other than the starting > + ;; buffer, switch to it. > + (unless (eq first start) > + (switch-to-buffer first)) >(notmuch > > (setq mail-user-agent 'notmuch-user-agent) &g

[PATCH v2] emacs: Cycle through notmuch buffers rather than jumping to the last.

2012-01-14 Thread Pieter Praet
On Tue, 10 Jan 2012 22:15:02 +0200, Jani Nikula wrote: > I don't feel qualified to review, Allow me to disagree: your feeling and reality appear to be disjoint ATM :) Peace -- Pieter

[PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

2012-01-14 Thread Pieter Praet
On Sat, 14 Jan 2012 10:14:57 +0100, Pieter Praet wrote: > On Fri, 13 Jan 2012 08:23:55 +, David Edmondson wrote: > > On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet > > wrote: > > > Less code, same results, without sacrificing readability. > > > > +

[PATCH] emacs: breakout notmuch-show-advance functionality from notmuch-show-advance-and-archive

2012-01-16 Thread Pieter Praet
On Thu, 12 Jan 2012 18:04:10 +0100, Pieter Praet wrote: > On Wed, 16 Nov 2011 23:47:53 +0100, Pieter Praet wrote: > > On Sun, 13 Nov 2011 13:16:48 -0800, Jameson Graef Rollins > finestructure.net> wrote: > > > This patch breaks out much of the functionality of &g

[PATCH] test: cli: getting/setting/removing config values

2012-01-16 Thread Pieter Praet
On Sat, 14 Jan 2012 08:16:30 -0400, David Bremner wrote: > On Sat, 14 Jan 2012 09:57:56 +0100, Pieter Praet wrote: > > Full test coverage for getting, setting and removing options in > > notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config). > > >

[PATCH] emacs: logically group def{custom,face}s

2012-01-16 Thread Pieter Praet
On Sat, 14 Jan 2012 13:08:28 -0500, Austin Clements wrote: > Quoth Pieter Praet on Jan 14 at 10:04 am: > > To allow for expansion whilst keeping everything tidy and organized, > > move all defcustom/defface variables to the following subgroups, > > defined in notmuch-lib

[PATCH v4] emacs: logically group def{custom,face}s

2012-01-16 Thread Pieter Praet
To allow for expansion whilst keeping everything tidy and organized, move all defcustom/defface variables to the following subgroups, defined in notmuch-lib.el: - Hello - Search - Show - Send - Crypto - Hooks - External Commands - Appearance As an added benefit, defcustom keyword args are now

[PATCH] test: don't bail out of `run_emacs' too early when missing prereqs

2012-01-16 Thread Pieter Praet
On Sun, 15 Jan 2012 17:56:37 +0400, Dmitry Kurochkin wrote: > On Sat, 14 Jan 2012 10:07:41 +0100, Pieter Praet wrote: > > On Thu, 12 Jan 2012 21:34:29 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > On Thu, 12 Jan 2012 18:16:59 +0100, Pieter Praet > > > wrot

[PATCH] [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-16 Thread Pieter Praet
CLisp'ier version of `notmuch-cycle-notmuch-buffers', merged into `notmuch', eliminating the need to hog yet another keybind. FYI: causes 2 compile warnings due to requiring the cl package at runtime. --- emacs/notmuch.el | 34 -- 1 files changed, 8

[PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

2012-01-16 Thread Pieter Praet
Less code, same results, without sacrificing readability. --- v2: Fixed indentation oversight @ `notmuch-hello-insert-tags'. emacs/notmuch-address.el |6 +++--- emacs/notmuch-hello.el | 22 +++--- emacs/notmuch-show.el| 12 ++-- emacs/notmuch.el |

[PATCH] add `tag:' prefix to `--output=tags' results

2012-01-16 Thread Pieter Praet
On Mon, 16 Jan 2012 10:56:03 +, David Edmondson wrote: > Given the discussion that followed this patch I'd like to mark it as > 'obsolete'. > > Any objections? None whatsoever :) Peace -- Pieter

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread Pieter Praet
On Tue, 27 Dec 2011 16:47:14 +, David Edmondson wrote: > The tags were coloured using text properties. Unfortunately that text > (the header line) also has an overlay, which overrides the text > properties. There's not point in applying text properties that will > never be seen. > --- >

[PATCH] [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-16 Thread Pieter Praet
On Mon, 16 Jan 2012 11:06:25 +, David Edmondson wrote: > On Mon, 16 Jan 2012 11:42:31 +0100, Pieter Praet wrote: > > CLisp'ier version of `notmuch-cycle-notmuch-buffers', merged into `notmuch', > > eliminating the need to hog yet another keybind. > > The lisp-ier-

[PATCH] [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-16 Thread Pieter Praet
On Mon, 16 Jan 2012 12:28:06 +0100, Pieter Praet wrote: > On Mon, 16 Jan 2012 11:06:25 +, David Edmondson wrote: > > On Mon, 16 Jan 2012 11:42:31 +0100, Pieter Praet > > wrote: > > > CLisp'ier version of `notmuch-cycle-notmuch-buffers', merged into > >

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread Pieter Praet
On Mon, 16 Jan 2012 11:22:27 +, David Edmondson wrote: > On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet wrote: > > Alas, those text properties actually *were* effective (and I liked them :) > > Well, not in emacs 24. My reading of the source was that overlays were >

[PATCH] [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-16 Thread Pieter Praet
On Mon, 16 Jan 2012 11:47:03 +, David Edmondson wrote: > On Mon, 16 Jan 2012 12:28:06 +0100, Pieter Praet wrote: > > Perhaps we could use `ido-completion-help', like Org-mode does with > > `org-iswitchb' ? OTOH, that would require an extra [RET]. Bah... > >

[PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-16 Thread Pieter Praet
Make `notmuch-cycle-notmuch-buffers' more Lispy and merge into `notmuch', eliminating the need to hog yet another keybind. --- emacs/notmuch.el | 40 ++-- 1 files changed, 14 insertions(+), 26 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el

[PATCH] test: cli: getting/setting/removing config values

2012-01-16 Thread Pieter Praet
On Mon, 16 Jan 2012 07:37:13 -0400, David Bremner wrote: > On Mon, 16 Jan 2012 11:31:11 +0100, Pieter Praet wrote: > > > > Hmmm, `dnsdomainname' returns "(none)" here; Does it work for you? > > > > Running `domainname' instead seems to do the right thing

[PATCH 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists

2012-01-16 Thread Pieter Praet
On Mon, 16 Jan 2012 11:43:25 +, David Edmondson wrote: > On Thu, 12 Jan 2012 18:23:44 +0100, Pieter Praet wrote: > > + (make-text-button string-start string-end > > 'action `(lambda (arg) > > - (notmuch-show ,(match

[PATCH v2] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists

2012-01-16 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-found-target-p): new predicate function that uses notmuch(1) 'count' to see if a query turns up any results. * emacs/notmuch-show.el (notmuch-show-if-found): new function that only shows a message/thread if present in the database and otherwise returns an

[PATCH 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state

2012-01-16 Thread Pieter Praet
On Mon, 16 Jan 2012 11:45:13 +, David Edmondson wrote: > On Thu, 12 Jan 2012 18:23:45 +0100, Pieter Praet wrote: > > + 'face (cond > > + ((notmuch-show-found-target-p message-id t) > > + > > 'n

[PATCH 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state

2012-01-16 Thread Pieter Praet
On Mon, 16 Jan 2012 11:45:13 +, David Edmondson wrote: > On Thu, 12 Jan 2012 18:23:45 +0100, Pieter Praet wrote: > > + 'face (cond > > + ((notmuch-show-found-target-p message-id t) > > + > > 'n

[PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state

2012-01-16 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-buttonized-link-colors): new defcustom, allows toggling colorization of buttonized links. * emacs/notmuch-show.el (notmuch-show-buttonized-link-present), * emacs/notmuch-show.el (notmuch-show-buttonized-link-present-and-unread), * emacs/notmuch-show.el

[PATCH v4] emacs: logically group def{custom,face}s

2012-01-18 Thread Pieter Praet
On Mon, 16 Jan 2012 14:16:22 -0500, Austin Clements wrote: > LGTM. > > Quoth Pieter Praet on Jan 16 at 11:38 am: > > - Add `notmuch-send' to the `message' group, as per Austin's > > recommendation [1]. > > This is actually the reverse of what I was suggesting (

[PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Pieter Praet
On Mon, 16 Jan 2012 17:03:44 +, David Edmondson wrote: > On Mon, 16 Jan 2012 17:46:55 +0100, Pieter Praet wrote: > > Make `notmuch-cycle-notmuch-buffers' more Lispy and merge into `notmuch', > > eliminating the need to hog yet another keybind. > ... > > diff --git a/

[RFC] [PATCH v3] emacs: rewrite `notmuch-cycle-notmuch-buffers'

2012-01-18 Thread Pieter Praet
Get rid of the compile-time `cl' requirement for this particular function. --- emacs/notmuch.el | 40 ++-- 1 files changed, 22 insertions(+), 18 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index ef4dcc7..2426c0a 100644 ---

[PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Pieter Praet
On Mon, 16 Jan 2012 23:10:27 +0200, Jani Nikula wrote: > On Mon, 16 Jan 2012 17:46:55 +0100, Pieter Praet wrote: > > Make `notmuch-cycle-notmuch-buffers' more Lispy and merge into `notmuch', > > eliminating the need to hog yet another keybind. > > What does "mer

[PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Pieter Praet
On Wed, 18 Jan 2012 10:13:35 +, David Edmondson wrote: > On Wed, 18 Jan 2012 11:03:09 +0100, Pieter Praet wrote: > > > [...] What's wrong with '(loop ... collect ...)'? > > > > Nothing at all. I was fixing my own patch [1] without resorting to > > requiri

[PATCH] test: always report missing prereqs, independent of `--verbose' option

2012-01-18 Thread Pieter Praet
When tests are skipped due to missing prereqs, those prereqs are only displayed when running with the `--verbose' option. This is essential information when troubleshooting, so always send to stdout. --- test/test-lib.sh |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 3/3 v3] emacs: colorize buttonized 'id:' links depending on the target message's state

2012-01-18 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-buttonized-link-colors): - new defcustom, allows toggling colorization of buttonized links. (notmuch-show-buttonized-link-available), (notmuch-show-buttonized-link-available-and-unread), (notmuch-show-buttonized-link-missing): - new faces for

[PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Pieter Praet
On Wed, 18 Jan 2012 13:15:55 +0100, Pieter Praet > > wrote: > > > On Wed, 18 Jan 2012 10:13:35 +, David Edmondson > > > wrote: > > > > On Wed, 18 Jan 2012 11:03:09 +0100, Pieter Praet > > > > wrote: > > > > > > [...] Wh

[PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers.

2012-01-18 Thread Pieter Praet
On Mon, 16 Jan 2012 14:13:22 +, David Edmondson wrote: > Enable the truncation of lines in `notmuch-show-mode' to avoid visual > noise caused by the wrapping of the header lines. > > Don't enable `visual-line-mode' because it disables line truncation. > > The benefits of `visual-line-mode'

[PATCH v2] emacs: add invisible dot instead of space at the end of notmuch-hello search box

2012-01-18 Thread Pieter Praet
On Tue, 17 Jan 2012 19:55:34 +0400, Dmitry Kurochkin wrote: > This makes `show-trailing-whitespace' happy, i.e. it does not mark the > whole search box line as trailing spaces. > > Since the dot is invisible, this change makes no visible difference > for `notmuch-hello'. > --- >

[PATCH] emacs: invert relation between 'notmuch-send and 'message customization groups

2012-01-19 Thread Pieter Praet
'message contains options relevant to 'notmuch-send, not the other way around. Thanks to Austin for suggesting `custom-add-to-group'. id:"20120118184408.GD16740 at mit.edu" --- emacs/notmuch-lib.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-19 Thread Pieter Praet
On Wed, 18 Jan 2012 17:18:48 -0500, Aaron Ecay wrote: > On Wed, 18 Jan 2012 14:48:02 +0100, Pieter Praet wrote: > > My original intent of conserving a key(chord) [1] (which in > > retrospect was a fairly pointless exercise in and of itself > > [2,3]) seems to have in

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Pieter Praet
Nice feature! I won't be using it myself, but I can imagine it being *very* useful for those who still feel the need to "delete" email :). Nitpicking: - All other config-related functions and args include the section title in their name [1], so for the sake of consistency, we might want to

[PATCH 1/4] search: rename auto_exclude_tags to {search, }exclude_tags

2012-01-19 Thread Pieter Praet
All other config-related functions and args include the section title in their name, so for the sake of consistency, mirror that. Also, the "auto"matic part is a given, so that was dropped. --- notmuch-client.h |4 ++-- notmuch-config.c | 32

[PATCH 2/4] test: only exclude "deleted" messages from search if explicitly configured

2012-01-19 Thread Pieter Praet
If the 'search.exclude_tags' option is missing from the config file, its value is automatically set to "deleted;spam;". Taking PoLS/DWIM into account, this should probably only happen during setup. --- test/search |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git

[PATCH 4/4] setup: prompt user for search.exclude_tags value

2012-01-19 Thread Pieter Praet
Allow users to customize the search.exclude_tags option during setup. --- notmuch-setup.c | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/notmuch-setup.c b/notmuch-setup.c index c3ea937..44d4aaa 100644 --- a/notmuch-setup.c +++

[PATCH v4] emacs: logically group def{custom,face}s

2012-01-19 Thread Pieter Praet
On Thu, 19 Jan 2012 13:14:25 -0400, David Bremner wrote: > On Mon, 16 Jan 2012 11:38:33 +0100, Pieter Praet wrote: > > To allow for expansion whilst keeping everything tidy and organized, > > move all defcustom/defface variables to the following subgroups, > > defi

[PATCH 1/4] search: rename auto_exclude_tags to {search, }exclude_tags

2012-01-19 Thread Pieter Praet
On Thu, 19 Jan 2012 14:41:15 -0500, Austin Clements wrote: > Quoth Pieter Praet on Jan 19 at 8:19 pm: > > All other config-related functions and args include the section > > title in their name, so for the sake of consistency, mirror that. > > > > Also, the &quo

[PATCH] config: Better formatting for search section comment

2012-01-19 Thread Pieter Praet
On Wed, 18 Jan 2012 15:56:45 -0500, Austin Clements wrote: > Since "auto_exclude_tags" is long and its description is multi-line, > start the description on the next line and indent it consistently. > --- > notmuch-config.c |7 --- > 1 files changed, 4 insertions(+), 3 deletions(-) > >

[PATCH 4/4] setup: prompt user for search.exclude_tags value

2012-01-19 Thread Pieter Praet
On Thu, 19 Jan 2012 14:44:37 -0500, Austin Clements wrote: > Quoth Pieter Praet on Jan 19 at 8:19 pm: > > Allow users to customize the search.exclude_tags option during setup. > > > > --- > > notmuch-setup.c | 36 > > 1 f

<    1   2   3   4   5   6   7   >