Re: [PATCH v2] emacs: Cycle through notmuch buffers rather than jumping to the last.

2012-01-16 Thread David Edmondson
On Sun, 15 Jan 2012 22:01:05 -0500, Austin Clements wrote: > Quoth David Edmondson on Jan 15 at 11:55 am: > > On Sat, 14 Jan 2012 10:29:31 +0100, Pieter Praet wrote: > > > Might I ask, to what key(chord) have you bound this ? Due to its > > > usefulness, I'm incl

Re: [PATCH] Output unmodified Content-Type header value for JSON format.

2012-01-16 Thread David Edmondson
On Sun, 15 Jan 2012 12:58:40 -0500, Austin Clements wrote: > Yes. I was mostly reiterating the IRC discussion for Pieter. Since > this discussion, I've stabilized on the pre-fetching notion I described > in id:"20120115003617.gh1...@mit.edu", Will read when I get there. > though I do think we

Re: [PATCH 2/2] notmuch-dev: Update the master branch when requested.

2012-01-16 Thread David Edmondson
On Fri, 13 Jan 2012 22:03:17 +0100, Xavier Maillard wrote: > Have you planned to cook something about this in notmuch wiki ? > That sounds like something I could use to test patches more easily than > I do currently. I'll do so. > Note: I am totally a dummy when I have to use git :/ Me too, hen

Re: [PATCH v2 3/3] search: Support automatic tag exclusions

2012-01-16 Thread David Edmondson
On Sat, 14 Jan 2012 15:40:26 -0800, Jameson Graef Rollins wrote: > This patch looks fine. Philosophical UI discussion to follow: > > On Fri, 13 Jan 2012 18:07:04 -0500, Austin Clements wrote: > > +if (notmuch_config_get_auto_exclude_tags (config, &tmp) == NULL) { > > + const char *tags[]

Re: [PATCH 0/1] emacs: allow viewing as well saving individual attachments

2012-01-16 Thread David Edmondson
On Sun, 15 Jan 2012 12:16:35 +, Mark Walters wrote: > Mark Walters (1): > Make buttons for attachments allow viewing as well as saving > > emacs/notmuch-show.el | 81 ++-- > 1 files changed, 64 insertions(+), 17 deletions(-) Nice changes. p

Re: [PATCH 1/3] emacs/*.el: changed one-char comment prefix '; ' to two: '; ; '

2012-01-16 Thread David Edmondson
+2 for the whole set :-) pgpKfrznllmVK.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] add `tag:' prefix to `--output=tags' results

2012-01-16 Thread David Edmondson
Given the discussion that followed this patch I'd like to mark it as 'obsolete'. Any objections? pgpusAEJtQy7A.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v6 0/2] emacs: User-defined sections in notmuch-hello

2012-01-16 Thread David Edmondson
Daniel, there was a bunch of feedback from Dmitry about the patch and a couple of other comments. Do you plan to produce a new version? It would be good to get this applied - it allows us to address various comments that have been made about unifying the different search mechanisms and looks gene

Re: [PATCH v4] emacs: logically group def{custom,face}s

2012-01-16 Thread David Edmondson
Nice work. +1 for me. pgpDMWsazb79Y.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 11:42:31 +0100, Pieter Praet wrote: > CLisp'ier version of `notmuch-cycle-notmuch-buffers', merged into `notmuch', > eliminating the need to hog yet another keybind. The lisp-ier-ness changes are good. I'm less sure about the functional change. Sometimes I want to go back to

Re: [PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 11:56:40 +0100, Pieter Praet wrote: > Less code, same results, without sacrificing readability. +1. pgpCDwvNS4sYk.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listin

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet wrote: > Alas, those text properties actually *were* effective (and I liked them :) Well, not in emacs 24. My reading of the source was that overlays were intended to stomp on text properties, but that could have been wrong. Do they look correct w

Re: [PATCH] emacs: Improved printing support.

2012-01-16 Thread David Edmondson
On Tue, 3 Jan 2012 14:12:26 +, David Edmondson wrote: > Add various functions to print notmuch messages and tie them together > with a simple frontend. No keybinding is currently made to encourage > paper saving. Could someone review my lisp please? bremner suggested that

Re: [PATCH] emacs-hello: Do not calculate the count of the messages in

2012-01-16 Thread David Edmondson
On Thu, 13 Oct 2011 16:09:23 +0200, Michal Sojka wrote: > On Mon, 10 Oct 2011, Daniel Schoepe wrote: > > Fixed that and rebased against master. > > Hi Daniel, > > I've an improvement for your patches. Recently, I decided to speed up > notmuch hello startup times and I found that hiding a section

Re: [PATCH 1/4] emacs: unify search mechanisms

2012-01-16 Thread David Edmondson
On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin wrote: > Before the change, there were two ways to do search in Emacs UI: > search widget in notmuch-hello buffer and `notmuch-search' > function bound to "s". Internally, notmuch-hello search widget > uses `notmuch-search' function. But it u

Re: [PATCH] test: cli: getting/setting/removing config values

2012-01-16 Thread David Bremner
On Mon, 16 Jan 2012 11:31:11 +0100, Pieter Praet wrote: > > Hmmm, `dnsdomainname' returns "(none)" here; Does it work for you? > > Running `domainname' instead seems to do the right thing though... > I make no claims to have "correctly" configured this machine on my home network, but here it

Re: [PATCH 1/3] emacs: s/buttonise/buttonize/g

2012-01-16 Thread David Edmondson
On Thu, 12 Jan 2012 18:23:43 +0100, Pieter Praet wrote: > "Worldwide, -ize endings prevail in scientific writing and are commonly > used by many international organizations, such as the ISO and the > WHO. The European Union switched from -ize to -ise some years ago in its > English language public

Re: [PATCH 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists

2012-01-16 Thread David Edmondson
On Thu, 12 Jan 2012 18:23:44 +0100, Pieter Praet wrote: > + (make-text-button string-start string-end > 'action `(lambda (arg) > -(notmuch-show ,(match-string-no-properties > 0))) > +(notmuch-show-if-found

Re: [PATCH 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state

2012-01-16 Thread David Edmondson
On Thu, 12 Jan 2012 18:23:45 +0100, Pieter Praet wrote: > + 'face (cond > +((notmuch-show-found-target-p message-id t) > + > 'notmuch-show-buttonized-link-present-and-unread) > +((notmuch-show-

Re: [PATCH] [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 12:28:06 +0100, Pieter Praet wrote: > Perhaps we could use `ido-completion-help', like Org-mode does with > `org-iswitchb' ? OTOH, that would require an extra [RET]. Bah... I'm a no-ido person. > > Hmm, yes, that seems reasonable. > > > > > FYI: causes 2 compile warnings d

Re: [PATCH 1/4] emacs: unify search mechanisms

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 15:39:14 +0400, Dmitry Kurochkin wrote: > > Dmitry, if Daniel re-submits his patches to allow the construction of > > `notmuch-hello' buffers to be configured, it seems that this patchset > > would become unnecessary. Is that correct? > > Right. We will just need to fix the

Re: The overloading of show (was Re: [PATCH] Output unmodified Content-Type header value for JSON format.)

2012-01-16 Thread David Edmondson
On Sat, 14 Jan 2012 19:36:17 -0500, Austin Clements wrote: > ...there are several levels of structure here: > > 1. Threads (query results) > 2. Thread structure > 3. Message structure (MIME) > 4. Part content > > Currently, search returns 1; show --format=json returns 2, 3, and > sometimes 4 (bu

[PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers.

2012-01-16 Thread David Edmondson
Enable the truncation of lines in `notmuch-show-mode' to avoid visual noise caused by the wrapping of the header lines. Don't enable `visual-line-mode' because it disables line truncation. The benefits of `visual-line-mode' were that it wrapped long lines in received messages. With `notmuch-wash-

Re: [PATCH] debian: add a recommends for w3m-el or w3m-el-snapshot to notmuch-emacs

2012-01-16 Thread David Edmondson
On Wed, 7 Dec 2011 22:13:06 -0400, David Bremner wrote: > From: David Bremner > > Installing w3m-el provides a nicer out of the box experience for > viewing html in notmuch, and the overhead is not too bad (about 5M > diskspace). Given the discussion, should th

Re: [PATCH] debian: add a recommends for w3m-el or w3m-el-snapshot to notmuch-emacs

2012-01-16 Thread David Bremner
On Mon, 16 Jan 2012 15:50:45 +, David Edmondson wrote: > On Wed, 7 Dec 2011 22:13:06 -0400, David Bremner wrote: > > From: David Bremner > > > > Installing w3m-el provides a nicer out of the box experience for > > viewing html in notmuch, and the overhe

[PATCH 1/2] test: Add "test_expect_emacs_t" to assist with emacs testing.

2012-01-16 Thread David Edmondson
"test_expect_emacs_t" expects a single argument. If this is `t' then the test passes. Otherwise the argument provides the details of the test failure to be reported. --- For use in the following set of tests and later for other emacs related tests. test/test-lib.sh | 20 1

[PATCH 2/2] test: Add tests for `notmuch-show-test-clean-address'.

2012-01-16 Thread David Edmondson
/emacs/notmuch-test.el new file mode 100644 index 000..d6cf318 --- /dev/null +++ b/emacs/notmuch-test.el @@ -0,0 +1,87 @@ +;; notmuch-test.el --- testing the emacs interface +;; +;; Copyright © David Edmondson +;; +;; This file is part of Notmuch. +;; +;; Notmuch is free software: you can

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 17:46:55 +0100, Pieter Praet wrote: > Make `notmuch-cycle-notmuch-buffers' more Lispy and merge into `notmuch', > eliminating the need to hog yet another keybind. ... > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > index ef4dcc7..539b3a0 100644 > --- a/emacs/notmuch.el > +

Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state

2012-01-16 Thread David Edmondson
Nice. +1. pgp4Zu6XzBoRq.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists

2012-01-16 Thread David Edmondson
+1. pgpXMtwxK7O41.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] emacs: Avoid `mail-header-parse-address' in `notmuch-show-clean-address'.

2012-01-16 Thread David Edmondson
`mail-header-parse-address' expects un-decoded mailbox parts, which is not what we have at this point. Replace it with simple string deconstruction. --- Fix the failing test in the previous set. emacs/notmuch-show.el | 48 +++- 1 files changed, 35 in

[PATCH 2/2] emacs: Another special case for `notmuch-show-clean-address'.

2012-01-16 Thread David Edmondson
Remove backslashes. --- Including a new test case. emacs/notmuch-show.el | 14 +- emacs/notmuch-test.el |6 -- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 02819f3..6b9d1b8 100644 --- a/emacs/notmuch-sho

Re: [PATCH 1/2] test: Add "test_expect_emacs_t" to assist with emacs testing.

2012-01-16 Thread David Edmondson
I asked for feedback on the approach of implementing tests in .el[1] and got only positive feedback (well, only one bit of feedback at all). Here are some simpler tests implemented using this approach, trying to address the concerns about seeing what failed. The test output is now something like:

Re: [PATCH 2/2] test: Add tests for `notmuch-show-test-clean-address'.

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 21:41:09 +0400, Dmitry Kurochkin wrote: > On Mon, 16 Jan 2012 16:47:33 +0000, David Edmondson wrote: > > --- > > > > Add three tests. The third one currently fails. > > > > I do not like that we add testing code to emacs/ folder. My >

Re: [PATCH 1/2] test: Add "test_expect_emacs_t" to assist with emacs testing.

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 21:50:22 +0400, Dmitry Kurochkin wrote: > Isn't this function the same as something like "test_expect_equal $x > t"? Yes, except that it differs in how it reports differences. > IMO the function seems too complex for what it does (and basically that > is "compare $x with t")

Re: [PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 22:06:15 +0400, Dmitry Kurochkin wrote: > Hello. > > Since this patches got in, I have yet to send a single email to the > address(es) I intend to :( I am really used to the bindings and this > change is a pain. From IRC discussion, it seems like I am not alone > here. > >

Re: [PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions

2012-01-16 Thread David Bremner
On Mon, 16 Jan 2012 22:06:15 +0400, Dmitry Kurochkin wrote: > > If others like it, how about reverting to the old bindings until the new > ones are implemented? > Flip-flopping the bindings will just cause more confusion, in my opinion. It is easy (and documented in the wiki) to customize the

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread David Bremner
On Mon, 16 Jan 2012 15:51:30 -0500, Aaron Ecay wrote: > On Mon, 16 Jan 2012 11:22:27 +0000, David Edmondson wrote: > > On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet wrote: > > > Alas, those text properties actually *were* effective (and I liked them :) > > >

Re: Partial words on notmuch search?

2012-01-16 Thread David Bremner
On Mon, 16 Jan 2012 22:21:03 +0200, Andrei Popescu wrot> > $ notmuch count 'Debian' > 65888 > $ notmuch count '*ebian' > 3 > $ notmuch count '?ebian' > 3 > $ notmuch count 'ebian' > 3 > $ notmuch count '0ebian' You have to delve into the mysteries of xapian query parsing unfortunately. The sho

Re: [PATCH v3 0/2] Automatic tag-based exclusion

2012-01-16 Thread David Bremner
On Sat, 14 Jan 2012 19:17:32 -0500, Austin Clements wrote: > This fixes the symbol visibility warning Jamie pointed out. Third time the charm. pushed. Please (somebody) consider writing NEWS and man page updates. d ___ notmuch mailing list notmuch@n

Re: [PATCH 1/2] test: add known broken test for reply from address in named group list

2012-01-16 Thread David Bremner
On Sat, 14 Jan 2012 23:49:49 +0200, Jani Nikula wrote: > If a message was received to the user's address that was in a named > group list, notmuch reply does not use that address for picking the > from address. Pushed. d ___ notmuch mailing list notmuc

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 18:21:24 -0400, David Bremner wrote: > I'm leaning to revert this patch. Any opposition? Please revert it and I'll investigate further. pgp2sWrScOERx.pgp Description: PGP signature ___ notmuch mailing list notmuch@no

Re: [PATCH v2 4/4] emacs: Use the new JSON reply format.

2012-01-17 Thread David Edmondson
Much nicer now that it uses the mm stuff. On Mon, 16 Jan 2012 11:13:23 -0700, Adam Wolfe Gordon wrote: > +(defun find-parts (parts type) Sorry for being a nuisance - this needs a name that indicates that it relates to notmuch. How about `notmuch-parts-filter-by-type'? > + "Return a list of me

Re: how about message-citation-line-format (was: Re: [PATCH v2 5/4] emacs: Add customization for the first line of quotes.)

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 08:17:49 +0100, Gregor Zattler wrote: > Hi Adam, notmuch developers, > * Adam Wolfe Gordon [16. Jan. 2012]: > > Add a customization option, notmuch-mua-reply-quoth, which controls > > the first line of the reply body (typically, "On %date%, %from% wrote:"). > > This allows use

Re: [PATCH v2 3/3] search: Support automatic tag exclusions

2012-01-17 Thread David Edmondson
On Mon, 16 Jan 2012 15:16:24 -0700, Jeremy Nickurak wrote: > On Mon, Jan 16, 2012 at 12:28, Austin Clements wrote: > >> Having "deleted" and "spam" as default settings in the configuration > >> file might be more reasonable. > > If I read correctly: > > 1) If no exclude options are in the confi

Re: [PATCH] emacs: Improved printing support.

2012-01-17 Thread David Edmondson
On Mon, 16 Jan 2012 16:27:06 -0500, Aaron Ecay wrote: > > +;; > > The above is just a stray comment line, right? I tend to use them as spacers, but, sure. > > +(defun notmuch-show-with-message-as-text (fn) > > + "Apply function `fn' to a text representation of the current > > +message." > > I

Re: Emacs: Crypto: How to get automatic encryption?

2012-01-17 Thread David Edmondson
On Mon, 16 Jan 2012 23:48:30 -0500, Antoine Beaupré wrote: > Jumping in here, I have modified the previously posted code here to > provide me with a more complete solution. This looks good. I'll switch over to using it. > Code is attached. Obviously, those function names would change if they >

Re: [PATCH] NEWS: consistent 2-space indentation

2012-01-17 Thread David Bremner
On Tue, 17 Jan 2012 13:00:15 +0200, Tomi Ollila wrote: > In NEWS file, indentation for item descriptions is generally 2 spaces > but in a few cases there were 3 or 4 (4 caused different markdown > handling) space indentations. Indentation in those lines are brought > to consistent 2-space indentat

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-17 Thread David Bremner
On Tue, 17 Jan 2012 07:22:42 +, David Edmondson wrote: > On Mon, 16 Jan 2012 18:21:24 -0400, David Bremner wrote: > > I'm leaning to revert this patch. Any opposition? > > Please revert it and I'll investigate further. Reverted. d __

[PATCH] Start devel directory for developer tools and documentation.

2012-01-17 Thread David Bremner
From: David Bremner We had a lot of back and forth about the name of this directory, but nothing very conclusive. In the end, I just chose "devel" just to move on. --- RELEASING => devel/RELEASING |0 TODO => devel/TODO |0 2 files changed, 0 insertions

[PATCH 1/4] test: Add `test_emacs_expect_t'.

2012-01-17 Thread David Edmondson
Add a new test function to allow simpler testing of emacs functionality. `test_emacs_expect_t' takes two arguments: - the name of the test, - some lisp to evaluate. The test passes if the lisp returns `t', otherwise it fails and the output is reported to the tester. --- test/emacs-test-funct

[PATCH 3/4] emacs: Avoid `mail-header-parse-address' in `notmuch-show-clean-address'.

2012-01-17 Thread David Edmondson
`mail-header-parse-address' expects un-decoded mailbox parts, which is not what we have at this point. Replace it with simple string deconstruction. --- emacs/notmuch-show.el | 48 +++- 1 files changed, 35 insertions(+), 13 deletions(-) diff --git a/e

emacs based tests, version 3

2012-01-17 Thread David Edmondson
Taking Dmitry's suggestions on board. The end result does indeed feel better, thanks! [PATCH 1/4] test: Add `test_emacs_expect_t'. [PATCH 2/4] test: Add address cleaning tests. [PATCH 3/4] emacs: Avoid `mail-header-parse-address' in [PATCH 4/4] emacs: Another special case for _

[PATCH 4/4] emacs: Another special case for `notmuch-show-clean-address'.

2012-01-17 Thread David Edmondson
Remove backslashes. --- emacs/notmuch-show.el| 14 +- test/address-cleaning.el |6 -- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 8b2fbb3..90c9c05 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuc

[PATCH 2/4] test: Add address cleaning tests.

2012-01-17 Thread David Edmondson
Including some more test framework in test-lib.el. --- test/address-cleaning.el | 29 + test/address-cleaning.sh | 11 +++ test/notmuch-test|1 + test/test-lib.el | 29 + 4 files changed, 70 insertions(+), 0

Re: [PATCH 2/4] test: Add address cleaning tests.

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 17:11:58 +0400, Dmitry Kurochkin wrote: > Since test/ directory is used for all kind of tests not just Emacs > UI-specific, so I think address-cleaning.* files should be > emacs-address-cleaning. Okay. pgpjWFrQsKV9M.pgp Description: PGP signature ___

Re: [PATCH 1/4] test: Add `test_emacs_expect_t'.

2012-01-17 Thread David Edmondson
(And one for the list...) On Tue, 17 Jan 2012 17:09:35 +0400, Dmitry Kurochkin wrote: > -1 > > This is not what I suggested. I do not like the approach when a single > function is used to both declare a subtest and test for result (as > opposed to test_begin_subtest). The fact that it is poss

[PATCH 1/3] test: Don't return the result of checking for running emacs to the tester.

2012-01-17 Thread David Edmondson
--- test/test-lib.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index d1fbc05..7c9ce24 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -926,7 +926,7 @@ test_emacs () { --eval '(orphan-watchdo

[PATCH 3/3] test: Add address cleaning tests.

2012-01-17 Thread David Edmondson
Including some more test framework in test-lib.el. --- notmuch-test-address-cleaning-3 currently fails, in order that you can see the output format in that case. test/emacs-address-cleaning.el | 29 + test/emacs-address-cleaning.sh | 12 test/notmuch-

[PATCH 2/3] test: Add `test_emacs_expect_t'.

2012-01-17 Thread David Edmondson
Add a new test function to allow simpler testing of emacs functionality. `test_emacs_expect_t' takes one argument - a list expression to evaluate. The test passes if the expression returns `t', otherwise it fails and the output is reported to the tester. --- Re-worked as Dmitry suggested. test/

Re: [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 17:24:45 +0400, Dmitry Kurochkin wrote: > This makes `show-trailing-whitespace' happy, i.e. it does not mark the > whole search box line as trailing spaces. Why should `whitespace-mode' be active in `notmuch-hello' buffers? pgpEE8lecgUob.pgp Description: PGP signature _

Re: [PATCH 1/2] emacs: add invisible dot instead of space at the end of notmuch-hello search box

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 18:13:26 +0400, Dmitry Kurochkin wrote: > On Tue, 17 Jan 2012 14:08:58 +0000, David Edmondson wrote: > > On Tue, 17 Jan 2012 17:24:45 +0400, Dmitry Kurochkin > > wrote: > > > This makes `show-trailing-whitespace' happy, i.e. it does not mark th

Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 18:26:41 +0400, Dmitry Kurochkin wrote: > Sorry, I still do not understand why we can not implement > test_emacs_expect_t() like: > > result=${test_emacs $@} > test_expect_equal $result t > > Can you please explain? In the failure case test_expect_equal does: test_fa

Re: [PATCH 1/3] test: Don't return the result of checking for running emacs to the tester.

2012-01-17 Thread David Edmondson
(And for the list...) On Tue, 17 Jan 2012 18:20:04 +0400, Dmitry Kurochkin wrote: > Can you please elaborate why this is needed? This code: # wait until the emacs server is up until test_emacs '()' 2>/dev/null; do sleep 1

Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 18:49:36 +0400, Dmitry Kurochkin wrote: > > + # We cannot call 'test_emacs' in a subshell, because > > + # the setting of EMACS_SERVER would not persist > > + # throughout a sequence of tests, so we use a > > + # temporary file. > > +

Re: Emacs: Crypto: How to get automatic encryption?

2012-01-17 Thread David Edmondson
>(if (and force (re-search-forward "<#secure [> >]*>\n" nil t)) > (replace-match "" nil nil)) >;; If we can encrypt, do so, else just sign. >(if (or force (not (re-search-forward "<#secure [> >]*>\n" nil t))) Is this second test for `force' necessary? If `force' is

Re: [PATCH v2] emacs: add invisible dot instead of space at the end of notmuch-hello search box

2012-01-17 Thread David Edmondson
+1. pgpAZYyk0EXbW.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] fix .gitignore for gzipped man pages

2012-01-17 Thread David Bremner
On Tue, 17 Jan 2012 20:16:03 +0200, Jani Nikula wrote: > --- > .gitignore |1 - > man/.gitignore |2 ++ pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] Start devel directory for developer tools and documentation.

2012-01-17 Thread David Bremner
On Tue, 17 Jan 2012 08:47:51 -0400, David Bremner wrote: > From: David Bremner > pushed. I need to find time to look at the uncrustify config again before I push that. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchma

Re: [PATCH v2 4/5] emacs: Use the new JSON reply format.

2012-01-17 Thread David Edmondson
On Tue, 17 Jan 2012 15:53:37 -0700, Adam Wolfe Gordon wrote: > +(defun notmuch-parts-filter-by-type (parts type) > + "Return a list of message parts with the given type" > + (let (result) > +(dolist (part (append parts nil) result) > + (if (string= (cdr (assq 'content-type part)) type)

[PATCH] emacs: Improved printing support.

2012-01-18 Thread David Edmondson
-0,0 +1,85 @@ +;; notmuch-print.el --- printing messages from notmuch. +;; +;; Copyright © David Edmondson +;; +;; This file is part of Notmuch. +;; +;; Notmuch is free software: you can redistribute it and/or modify it +;; under the terms of the GNU General Public License as published by +;; the Free So

Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-18 Thread David Edmondson
Very happy with the overall ideas. On Tue, 17 Jan 2012 10:05:26 -0800, Jameson Graef Rollins wrote: > -(defun notmuch-show-archive-thread-internal (show-next) > - ;; Remove the tag from the current set of messages. > +(defun notmuch-show-tag-thread-internal (tag &optional remove) > + ;; Add ta

Re: [PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread

2012-01-18 Thread David Edmondson
+1. pgpiBtWVmyHt6.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 3/6] emacs: add message archiving functions

2012-01-18 Thread David Edmondson
+1. pgpmQNrG3IoQL.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-18 Thread David Edmondson
On Tue, 17 Jan 2012 10:05:29 -0800, Jameson Graef Rollins wrote: > -(defun notmuch-show-next-open-message () > +(defun notmuch-show-next-open-message (&optional pop-at-end) >"Show the next message." >(interactive) > - (let (r) > + (let ((r) > + (parent-buffer notmuch-show-parent-buf

Re: [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving

2012-01-18 Thread David Edmondson
+1. pgpxIDMWtKOaN.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-18 Thread David Edmondson
On Tue, 17 Jan 2012 12:17:54 -0800, Jameson Graef Rollins wrote: > On Tue, 17 Jan 2012 15:10:40 -0500, Aaron Ecay wrote: > > This should be a docstring instead of a comment. (This applies equally > > to the old version) > > We're not currently in the habit of adding doc strings for > non-i

Re: on deleting messages

2012-01-18 Thread David Edmondson
Add the bindings. Provide documentation that makes it clear that they just add tags and never delete anything. pgp3b1CEVBlBs.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer

2012-01-18 Thread David Edmondson
Looks fine. pgpvjhm6aqI2W.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 2/3] emacs: use a single history for all searches

2012-01-18 Thread David Edmondson
On Tue, 17 Jan 2012 23:34:09 +0400, Dmitry Kurochkin wrote: > There are two ways to do search in Emacs UI: search widget in > notmuch-hello buffer and `notmuch-search' function bound to "s". > Before the change, these search mechanisms used different history > lists. The patch makes notmuch-hell

Re: [PATCH 3/3] emacs: bind "s" to `notmuch-hello-search' in notmuch-hello buffer

2012-01-18 Thread David Edmondson
+1. pgpZyJWo7ibRf.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2 3/3] search: Support automatic tag exclusions

2012-01-18 Thread David Edmondson
On Tue, 17 Jan 2012 15:32:11 -0500, Austin Clements wrote: > Quoth David Edmondson on Jan 17 at 9:08 am: > > On Mon, 16 Jan 2012 15:16:24 -0700, Jeremy Nickurak > > wrote: > > > On Mon, Jan 16, 2012 at 12:28, Austin Clements wrote: > > > >> Having &quo

Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 00:47:11 -0800, Jameson Graef Rollins wrote: > > > (while (and (setq r (notmuch-show-goto-message-next)) > > > (not (notmuch-show-message-visible-p > > > (if r > > > (progn > > > (notmuch-show-mark-read) > > > (notmuch-show-message-adjust)) >

Re: [PATCH v2 3/3] search: Support automatic tag exclusions

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 00:52:09 -0800, Jameson Graef Rollins wrote: > On Wed, 18 Jan 2012 08:38:23 +0000, David Edmondson wrote: > > Something must create the initial configuration file if none exists. I'd > > be okay with that code adding 'deleted' and 'spam&

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 11:03:09 +0100, Pieter Praet wrote: > > [...] What's wrong with '(loop ... collect ...)'? > > Nothing at all. I was fixing my own patch [1] without resorting to > requiring the `cl' package at runtime :) Would be nice if we could > get rid of the compile-time dependency as w

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 13:15:55 +0100, Pieter Praet wrote: > On Wed, 18 Jan 2012 10:13:35 +0000, David Edmondson wrote: > > On Wed, 18 Jan 2012 11:03:09 +0100, Pieter Praet wrote: > > > > [...] What's wrong with '(loop ... collect ...)'? > > > > &

compressing header lines - quick prototype

2012-01-18 Thread David Edmondson
Here's something that I was playing with this morning. It's not finished, but has some nasty corners, so I'd like to solicit opinion on whether it's worth finishing. When faced with a long thread where most of the messages are closed, it might be convenient to hide large stretches of closed header

RFC: tag macros

2012-01-18 Thread David Bremner
Hi All; Here is a very early stage proposal to provide tagging macros for notmuch show mode. The idea is that user defines a mapping from single key to a sequence of tagging operations. It might be nice if there as some kind of pop-up menu, or at least a prompt, but I didn't do that so far. T

Re: RFC: tag macros

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 10:45:06 -0400, David Bremner wrote: > Here is a very early stage proposal to provide tagging macros for > notmuch show mode. Nice idea. Please make it work on regions as well. pgp9jDOp95V8d.pgp Description: PGP sig

Re: [PATCH v2 4/5] emacs: Use the new JSON reply format.

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 09:32:34 -0700, Adam Wolfe Gordon wrote: > Using the new JSON reply format allows emacs to quote HTML > parts nicely by using mm-display-part to turn them into displayable > text, then quoting them. This is very useful for users who > regularly receive HTML-only email. > > Th

[PATCH] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread David Edmondson
The `mm-inlinable-p' and `mm-inlined-p' functions work better if they have access to the data of the relevant part, so load that content before calling either function. This fixes the display of attached image/jpeg parts, for example. --- I dropped this on the floor after discussing it in #notmuc

Re: [PATCH] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 17:33:13 +, David Edmondson wrote: > + ;; Nonsense required to have the new gnus `shr' HTML > + ;; display code work. > + (let ((gnus-inhibit-images nil)) > + (makunbound 'gnus-summary-buffer) ; Blech. > +

[PATCH v2] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread David Edmondson
The `mm-inlinable-p' and `mm-inlined-p' functions work better if they have access to the data of the relevant part, so load that content before calling either function. This fixes the display of attached image/jpeg parts, for example. --- Removed the cruft that crept into the previous patch. em

Re: [PATCH 2/3] emacs: use a single history for all searches

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 21:57:27 +0400, Dmitry Kurochkin wrote: > > The test output updates included here should be with the previous patch, > > shouldn't they? > > Indeed. Would send v2. That's not necessary for me. > > Should user-typed queries be trimmed? > > IMO that would not hurt. But we

Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 22:04:36 +0400, Dmitry Kurochkin wrote: > On Wed, 18 Jan 2012 17:39:31 +0000, David Edmondson wrote: > > The `mm-inlinable-p' and `mm-inlined-p' functions work better if they > > have access to the data of the relevant part, so load that content

Re: RFC: tag macros

2012-01-18 Thread David Bremner
On Wed, 18 Jan 2012 13:33:04 -0500, Austin Clements wrote: > Quoth David Bremner on Jan 18 at 10:45 am: > What about simply providing an API that takes a bunch of tag > operations and applies them to the current thread/message/region? My main motivation here is (as you can probably see

Re: RFC: tag macros

2012-01-18 Thread David Bremner
On Wed, 18 Jan 2012 10:50:50 -0800, Jameson Graef Rollins wrote: > > I've been wanting to put together a wiki page that lists all the useful > functions and has examples of how to put them together into useful > functions. > If we're going to go the way of providing a toolkit/api for uses to m

Re: RFC: tag macros

2012-01-18 Thread David Bremner
On Wed, 18 Jan 2012 18:15:37 -0800, Jameson Graef Rollins wrote: > > Can't we just use the emacs build-in documentation? > If you mean docstrings, that is only per function/variable. Which is better than nothing, but not very good for getting an overview of what is going on. Otherwise, info

Re: [PATCH 2/2] Silence buildbot warnings about unused results

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 19:40:11 -0500, Austin Clements wrote: > +/* See handle_sigint in notmuch-new.c for the justification for > + * ignoring write's result. */ > +IGNORE_RESULT (write (2, msg, sizeof(msg)-1)); Just include the comment in both places. Someone will work over the code in

Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 23:00:15 +0400, Dmitry Kurochkin wrote: > > That would allow a sane default (("image/*" "text/*") perhaps), but also > > allow more to be added to that list (or some to be removed), either by > > code that detected the (in)ability to render it or the user. > > Perhaps there i

<    1   2   3   4   5   6   7   8   9   10   >