Re: [PATCH] WIP: sort top level messages in thread

[Amin Bandali]

Hi Gregor, David,

> The patch applied cleanly on top of the others (which I use
> regularly with no problems) and fixed the threading order problem
> in the two test cases I send you.  Other RT-emails are also
> ordered nicely now.
>
> Thanks for this patch, I'll also use it regularly.

Seconded.  Thanks for your work on the patch, David.  It seems to
nicely order my RT tickets too, including the very first message
in each thread.

I'll continue using the patch and will report back if I run into
any issues.

-amin
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 13/15] lib: add _notmuch_message_id_parse_strict

[Amin Bandali]

This patch in the series appears to be corrupt:

--8<---cut here---start->8---
Applying: lib: add _notmuch_message_id_parse_strict
/home/amin/.emacs.d/.git/modules/notmuch/rebase-apply/patch:132: trailing 
whitespace.
<1530507300.raoomurnbf.astr...@strange.none>
error: corrupt patch at line 160
Patch failed at 0013 lib: add _notmuch_message_id_parse_strict
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
--8<---cut here---end--->8---

Seems to be due to a linebreak in the middle of a message id in a
test file, whereby the line doesn't begin with a +.

-amin
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Re: [BUG] Custom headers in `notmuch-message-headers` are broken

[Amin Bandali]

I got bitten by this today.

I only had a brief look at the format_headers_sprinter function
in notmuch-show.c.  Would you, David, or anyone else be able to
point out if the following makes sense, for generalizing
format_headers_sprinter to handle any arbitrary headers?

I saw this bit near the bottom of that function:

--8<---cut here---start->8---
if (reply) {
sp->map_key (sp, "In-reply-to");
sp->string (sp, g_mime_object_get_header (GMIME_OBJECT (message), 
"In-reply-to"));

sp->map_key (sp, "References");
sp->string (sp, g_mime_object_get_header (GMIME_OBJECT (message), 
"References"));
}
--8<---cut here---end--->8---

So I had a look at GMimeObject's docs on GNOME.org [0], and saw
g_mime_object_get_header_list, which returns a GMimeHeaderList*
list of headers [1], which seems to be what we're looking for.

From there, we'd walk over 0..(g_mime_header_list_get_count-1)
indices and use g_mime_header_list_get_header_at to get each
header, and pass it to g_mime_header_get_name to get the name
which we'll pass to sp->map_key and also use to get its value
from g_mime_object_get_header.

Does that make sense?

[0]: https://developer.gnome.org/gmime/stable/GMimeObject.html
[1]: https://developer.gnome.org/gmime/stable/GMimeHeaderList.html

-amin
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Re: bug: wrong order of messages in notmuch-show

[Amin Bandali]

For what it's worth, I've also noticed a similar behaviour for
some threads on some of the lists.gnu.org lists lately.

-amin
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch