notmuch.readthedocs.org

2014-11-18 Thread Ben Gamari
Justus Winter <4winter at informatik.uni-hamburg.de> writes: > Hey Sebastian, > > Quoting Sebastian Spaeth (2014-11-18 09:44:15) >> Let me know if I should be deleting the site. Or hand it over, or >> something :-). > > If I remember correctly, you handed notmuch.rtfd.org over to me. Or > you

Re: notmuch.readthedocs.org

2014-11-18 Thread Ben Gamari
Justus Winter 4win...@informatik.uni-hamburg.de writes: Hey Sebastian, Quoting Sebastian Spaeth (2014-11-18 09:44:15) Let me know if I should be deleting the site. Or hand it over, or something :-). If I remember correctly, you handed notmuch.rtfd.org over to me. Or you deleted the

notmuch.readthedocs.org

2014-11-17 Thread Ben Gamari
Justus Winter <4winter at informatik.uni-hamburg.de> writes: > Quoting David Bremner (2014-11-16 21:23:21) >> I'm not an admin of the readthedocs project. I guess Justus is? >> The seperate project approach seems good enough to me too. Justus >> (assuming you are an admin), how about adding Ben

Re: notmuch.readthedocs.org

2014-11-17 Thread Ben Gamari
Justus Winter 4win...@informatik.uni-hamburg.de writes: Quoting David Bremner (2014-11-16 21:23:21) I'm not an admin of the readthedocs project. I guess Justus is? The seperate project approach seems good enough to me too. Justus (assuming you are an admin), how about adding Ben so he fix

notmuch.readthedocs.org

2014-11-16 Thread Ben Gamari
David Bremner writes: > It seems that this site has bitrotted. I hit the build button and it > now builds the CLI docs instead of the python bindings. I assume since > Sebastian has moved on from maintaining the bindings he's also not > intersted in maintaining this site. If someone would like

notmuch.readthedocs.org

2014-11-16 Thread Ben Gamari
David Bremner writes: > It seems that this site has bitrotted. I hit the build button and it > now builds the CLI docs instead of the python bindings. I assume since > Sebastian has moved on from maintaining the bindings he's also not > intersted in maintaining this site. If someone would like

Re: notmuch.readthedocs.org

2014-11-16 Thread Ben Gamari
David Bremner da...@tethera.net writes: It seems that this site has bitrotted. I hit the build button and it now builds the CLI docs instead of the python bindings. I assume since Sebastian has moved on from maintaining the bindings he's also not intersted in maintaining this site. If

Re: notmuch.readthedocs.org

2014-11-16 Thread Ben Gamari
David Bremner da...@tethera.net writes: It seems that this site has bitrotted. I hit the build button and it now builds the CLI docs instead of the python bindings. I assume since Sebastian has moved on from maintaining the bindings he's also not intersted in maintaining this site. If

[PATCH] Add NEWS entry for notmuch-compact

2013-11-20 Thread Ben Gamari
Signed-off-by: Ben Gamari --- NEWS | 8 1 file changed, 8 insertions(+) diff --git a/NEWS b/NEWS index dbbbe9f..314d518 100644 --- a/NEWS +++ b/NEWS @@ -30,6 +30,14 @@ Improved `notmuch new` performance for unchanged folders RFC 2047-encodes the headers, making the output a valid

[PATCH] notmuch compact support (v4)

2013-11-20 Thread Ben Gamari
Does this look sufficient? Thanks, - Ben

Re: [PATCH] notmuch compact support (v4)

2013-11-20 Thread Ben Gamari
Does this look sufficient? Thanks, - Ben ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] Add NEWS entry for notmuch-compact

2013-11-20 Thread Ben Gamari
Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- NEWS | 8 1 file changed, 8 insertions(+) diff --git a/NEWS b/NEWS index dbbbe9f..314d518 100644 --- a/NEWS +++ b/NEWS @@ -30,6 +30,14 @@ Improved `notmuch new` performance for unchanged folders RFC 2047-encodes the headers, making

[PATCH v2 00/11] compactor changes v2

2013-11-05 Thread Ben Gamari
Tomi Ollila writes: > On Tue, Nov 05 2013, David Bremner wrote: > >> Jani Nikula writes: >> >>> Hi all, this is v2 of [1], incorporating compact related patches from >>> David, some changes from David's review, some new patches, man page >>> update, test update. >>> >>> Cheers, >>> Jani. >> >>

[PATCH v2 00/11] compactor changes v2

2013-11-05 Thread Ben Gamari
Jani Nikula writes: > Hi all, this is v2 of [1], incorporating compact related patches from > David, some changes from David's review, some new patches, man page > update, test update. > Alas, more silly oversights on my part. Thanks for catching these! No objections from my side. Given that

Re: [PATCH v2 00/11] compactor changes v2

2013-11-05 Thread Ben Gamari
Jani Nikula j...@nikula.org writes: Hi all, this is v2 of [1], incorporating compact related patches from David, some changes from David's review, some new patches, man page update, test update. Alas, more silly oversights on my part. Thanks for catching these! No objections from my side.

Re: [PATCH v2 00/11] compactor changes v2

2013-11-05 Thread Ben Gamari
Tomi Ollila tomi.oll...@iki.fi writes: On Tue, Nov 05 2013, David Bremner da...@tethera.net wrote: Jani Nikula j...@nikula.org writes: Hi all, this is v2 of [1], incorporating compact related patches from David, some changes from David's review, some new patches, man page update, test

[PATCH 4/4] database: Handle error while deleting uncompacted database

2013-11-04 Thread Ben Gamari
David Bremner writes: > Ben Gamari writes: > >> We never checked to ensure that the rmtree() of the old database >> succeeded. >> > > Is there some reason these patches (and the existing compact code in the > lib) is using fprintf and not the status callback

Re: [PATCH 4/4] database: Handle error while deleting uncompacted database

2013-11-04 Thread Ben Gamari
David Bremner da...@tethera.net writes: Ben Gamari bgamari.f...@gmail.com writes: We never checked to ensure that the rmtree() of the old database succeeded. Is there some reason these patches (and the existing compact code in the lib) is using fprintf and not the status callback function

[PATCH 1/4] test: Add compact test

2013-10-31 Thread Ben Gamari
Signed-off-by: Ben Gamari --- test/compact | 32 test/notmuch-test | 1 + 2 files changed, 33 insertions(+) create mode 100755 test/compact diff --git a/test/compact b/test/compact new file mode 100755 index 000..5bb5cea --- /dev/null +++ b/test

[PATCH 1/4] test: Add compact test

2013-10-31 Thread Ben Gamari
Tomi Ollila writes: > On Tue, Oct 29 2013, Ben Gamari wrote: > >> Signed-off-by: Ben Gamari >> --- > > Patches 2, 3 & 4 Looks OK To Me. Thanks. A few comments on this patch > inline: > Thanks again for the review! >> test/compact | 35

[PATCH 1/4] test: Add compact test

2013-10-30 Thread Ben Gamari
Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- test/compact | 32 test/notmuch-test | 1 + 2 files changed, 33 insertions(+) create mode 100755 test/compact diff --git a/test/compact b/test/compact new file mode 100755 index 000..5bb5cea --- /dev

Re: [PATCH 1/4] test: Add compact test

2013-10-30 Thread Ben Gamari
Tomi Ollila tomi.oll...@iki.fi writes: On Tue, Oct 29 2013, Ben Gamari bgamari.f...@gmail.com wrote: Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- Patches 2, 3 4 Looks OK To Me. Thanks. A few comments on this patch inline: Thanks again for the review! test/compact | 35

[PATCH 4/4] database: Handle error while deleting uncompacted database

2013-10-28 Thread Ben Gamari
We never checked to ensure that the rmtree() of the old database succeeded. Signed-off-by: Ben Gamari --- lib/database.cc | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 34753ab..bfc5dac 100644 --- a/lib/database.cc

[PATCH 3/4] compact: Provide user with more error feedback

2013-10-28 Thread Ben Gamari
Provide instructions on what to do when we couldn't move the compacted database into place. Signed-off-by: Ben Gamari --- lib/database.cc | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 57c2292..34753ab 100644

[PATCH 2/4] compact: Give user more feedback on failure renaming

2013-10-28 Thread Ben Gamari
Provide the user with instructions after we fail to move the old un-compacted database out of the way. Signed-off-by: Ben Gamari --- lib/database.cc | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 06f1c0a..57c2292 100644

[PATCH 1/4] test: Add compact test

2013-10-28 Thread Ben Gamari
Signed-off-by: Ben Gamari --- test/compact | 35 +++ test/notmuch-test | 1 + 2 files changed, 36 insertions(+) create mode 100755 test/compact diff --git a/test/compact b/test/compact new file mode 100755 index 000..54e85ab --- /dev/null +++ b/test

[PATCH 3/3] compact: Provide user with more error feedback

2013-10-28 Thread Ben Gamari
Tomi Ollila writes: > On Sun, Oct 27 2013, Ben Gamari wrote: > >> Provide instructions on what to do when we couldn't move the compacted >> database into place. >> >> Signed-off-by: Ben Gamari >> --- >> lib/database.cc | 18 +- >&g

Re: [PATCH 3/3] compact: Provide user with more error feedback

2013-10-28 Thread Ben Gamari
Tomi Ollila tomi.oll...@iki.fi writes: On Sun, Oct 27 2013, Ben Gamari bgamari.f...@gmail.com wrote: Provide instructions on what to do when we couldn't move the compacted database into place. Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- lib/database.cc | 18

[PATCH 2/4] compact: Give user more feedback on failure renaming

2013-10-28 Thread Ben Gamari
Provide the user with instructions after we fail to move the old un-compacted database out of the way. Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- lib/database.cc | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 06f1c0a

[PATCH 4/4] database: Handle error while deleting uncompacted database

2013-10-28 Thread Ben Gamari
We never checked to ensure that the rmtree() of the old database succeeded. Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- lib/database.cc | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 34753ab..bfc5dac 100644

[PATCH 3/4] compact: Provide user with more error feedback

2013-10-28 Thread Ben Gamari
Provide instructions on what to do when we couldn't move the compacted database into place. Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- lib/database.cc | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index

[PATCH 1/4] test: Add compact test

2013-10-28 Thread Ben Gamari
Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- test/compact | 35 +++ test/notmuch-test | 1 + 2 files changed, 36 insertions(+) create mode 100755 test/compact diff --git a/test/compact b/test/compact new file mode 100755 index 000..54e85ab

[PATCH 3/3] compact: Provide user with more error feedback

2013-10-27 Thread Ben Gamari
Provide instructions on what to do when we couldn't move the compacted database into place. Signed-off-by: Ben Gamari --- lib/database.cc | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 57c2292..6f9fed1 100644

[PATCH 2/3] compact: Give user more feedback on failure renaming

2013-10-27 Thread Ben Gamari
Provide the user with instructions after we fail to move the old un-compacted database out of the way. Signed-off-by: Ben Gamari --- lib/database.cc | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 06f1c0a..57c2292 100644

[PATCH 1/3] test: Add compact test

2013-10-27 Thread Ben Gamari
Signed-off-by: Ben Gamari --- test/compact | 35 +++ test/notmuch-test | 1 + 2 files changed, 36 insertions(+) create mode 100755 test/compact diff --git a/test/compact b/test/compact new file mode 100755 index 000..54e85ab --- /dev/null +++ b/test

[PATCH] Compact tests and error handling

2013-10-27 Thread Ben Gamari
David Bremner writes: > Ben Gamari writes: > >> Here are a few patches adding a test case and some more user feedback on >> rename failure during compaction. >> > > Hi Ben; > > I'd like to include this series in the next release, freezing on > Nov. 8. Wil

[PATCH 2/3] compact: Give user more feedback on failure renaming

2013-10-27 Thread Ben Gamari
Provide the user with instructions after we fail to move the old un-compacted database out of the way. Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- lib/database.cc | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 06f1c0a

[PATCH 1/3] test: Add compact test

2013-10-27 Thread Ben Gamari
Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- test/compact | 35 +++ test/notmuch-test | 1 + 2 files changed, 36 insertions(+) create mode 100755 test/compact diff --git a/test/compact b/test/compact new file mode 100755 index 000..54e85ab

Re: [PATCH] Compact tests and error handling

2013-10-27 Thread Ben Gamari
David Bremner da...@tethera.net writes: Ben Gamari bgamari.f...@gmail.com writes: Here are a few patches adding a test case and some more user feedback on rename failure during compaction. Hi Ben; I'd like to include this series in the next release, freezing on Nov. 8. Will you have

[PATCH 3/3] compact: Provide user with more error feedback

2013-10-14 Thread Ben Gamari
Provide instructions on what to do when we couldn't move the compacted database into place. Signed-off-by: Ben Gamari --- lib/database.cc | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 57c2292..6f9fed1 100644

[PATCH 2/3] compact: Give user more feedback on failure renaming

2013-10-14 Thread Ben Gamari
Provide the user with instructions after we fail to move the old un-compacted database out of the way. Signed-off-by: Ben Gamari --- lib/database.cc | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 06f1c0a..57c2292 100644

[PATCH 1/3] test: Add compact test

2013-10-14 Thread Ben Gamari
Signed-off-by: Ben Gamari --- test/compact | 35 +++ test/notmuch-test | 1 + 2 files changed, 36 insertions(+) create mode 100755 test/compact diff --git a/test/compact b/test/compact new file mode 100755 index 000..54e85ab --- /dev/null +++ b/test

[PATCH] Compact tests and error handling

2013-10-14 Thread Ben Gamari
Here are a few patches adding a test case and some more user feedback on rename failure during compaction. Cheers, - Ben

[PATCH 1/3] test: Add compact test

2013-10-14 Thread Ben Gamari
Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- test/compact | 35 +++ test/notmuch-test | 1 + 2 files changed, 36 insertions(+) create mode 100755 test/compact diff --git a/test/compact b/test/compact new file mode 100755 index 000..54e85ab

[PATCH 2/3] compact: Give user more feedback on failure renaming

2013-10-14 Thread Ben Gamari
Provide the user with instructions after we fail to move the old un-compacted database out of the way. Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- lib/database.cc | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 06f1c0a

[PATCH] Compact tests and error handling

2013-10-14 Thread Ben Gamari
Here are a few patches adding a test case and some more user feedback on rename failure during compaction. Cheers, - Ben ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 3/3] compact: Provide user with more error feedback

2013-10-14 Thread Ben Gamari
Provide instructions on what to do when we couldn't move the compacted database into place. Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- lib/database.cc | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 57c2292

Re: [PATCH] notmuch compact support (v4)

2013-10-10 Thread Ben Gamari
David Bremner da...@tethera.net writes: Ben Gamari bgamari.f...@gmail.com writes: Here is yet another iteration of my notmuch compact patchset. It has been rebased on top of master and the interface reworked as suggested by Jani. Sorry, first version of this reply didn't go to the list

[PATCH 3/3] notmuch-compact: Add man page

2013-10-02 Thread Ben Gamari
Signed-off-by: Ben Gamari --- man/Makefile.local | 1 + man/man1/notmuch-compact.1 | 36 2 files changed, 37 insertions(+) create mode 100644 man/man1/notmuch-compact.1 diff --git a/man/Makefile.local b/man/Makefile.local index 216aaa0..57910b7

[PATCH 1/3] database: Add notmuch_database_compact_close

2013-10-02 Thread Ben Gamari
This function uses Xapian's Compactor machinery to compact the notmuch database. The compacted database is built in a temporary directory and later moved into place while the original uncompacted database is preserved. Signed-off-by: Ben Gamari --- configure | 27 -- lib

[PATCH] notmuch compact support (v4)

2013-10-02 Thread Ben Gamari
Here is yet another iteration of my "notmuch compact" patchset. It has been rebased on top of master and the interface reworked as suggested by Jani. Cheers, - Ben

[PATCH] notmuch compact support (v4)

2013-10-02 Thread Ben Gamari
Here is yet another iteration of my notmuch compact patchset. It has been rebased on top of master and the interface reworked as suggested by Jani. Cheers, - Ben ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH 3/3] notmuch-compact: Add man page

2013-10-02 Thread Ben Gamari
Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- man/Makefile.local | 1 + man/man1/notmuch-compact.1 | 36 2 files changed, 37 insertions(+) create mode 100644 man/man1/notmuch-compact.1 diff --git a/man/Makefile.local b/man/Makefile.local

[PATCH 2/3] notmuch-compact: Initial commit of CLI

2013-10-02 Thread Ben Gamari
Introduce the user command exposing the new compaction facility. Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- Makefile.local| 1 + notmuch-client.h | 3 +++ notmuch-compact.c | 56 +++ notmuch.c | 2 ++ 4 files changed

[PATCH 1/3] database: Add notmuch_database_compact_close

2013-09-03 Thread Ben Gamari
Jani Nikula writes: > On Sat, 24 Aug 2013, Ben Gamari wrote: >> This function uses Xapian's Compactor machinery to compact the notmuch >> database. The compacted database is built in a temporary directory and >> later moved into place while the original uncompacted dat

Re: [PATCH 1/3] database: Add notmuch_database_compact_close

2013-09-03 Thread Ben Gamari
Jani Nikula j...@nikula.org writes: On Sat, 24 Aug 2013, Ben Gamari bgamari.f...@gmail.com wrote: This function uses Xapian's Compactor machinery to compact the notmuch database. The compacted database is built in a temporary directory and later moved into place while the original uncompacted

[PATCH 3/3] notmuch-compact: Add man page

2013-08-23 Thread Ben Gamari
Signed-off-by: Ben Gamari --- man/Makefile.local | 1 + man/man1/notmuch-compact.1 | 33 + 2 files changed, 34 insertions(+) create mode 100644 man/man1/notmuch-compact.1 diff --git a/man/Makefile.local b/man/Makefile.local index 216aaa0..57910b7 100644

[PATCH 2/3] notmuch-compact: Initial commit

2013-08-23 Thread Ben Gamari
Introduce the user command exposing the new compaction facility. Signed-off-by: Ben Gamari --- Makefile.local| 1 + notmuch-client.h | 6 ++ notmuch-compact.c | 43 +++ notmuch.c | 2 ++ 4 files changed, 52 insertions(+) create mode

[PATCH 1/3] database: Add notmuch_database_compact_close

2013-08-23 Thread Ben Gamari
This function uses Xapian's Compactor machinery to compact the notmuch database. The compacted database is built in a temporary directory and later moved into place while the original uncompacted database is preserved. Signed-off-by: Ben Gamari --- configure | 27 +++-- lib

No subject

2013-08-23 Thread Ben Gamari
From: Ben Gamari <bgamari.f...@gmail.com> Subject: [PATCH] notmuch compact support (v3) In-Reply-To: Here is the latest (and hopefully last) iteration of my patchset introducing a compact command. The set has been rebased on top of master, a manpage has been added, and error handling ha

[Olivier Berger] Bug#720543: notmuch: Please provide a script allowing to compact the xapian base

2013-08-23 Thread Ben Gamari
Olivier Berger said: > I think it would be great to provide a script allowing to do some > maintenance on the xapian DB to improve performance, as explained in > http://notmuchmail.org/performance/ (Compact your database). A few months^H^H^H nearly a year ago I had a patch[1] adding a `notmuch

Re: [Olivier Berger] Bug#720543: notmuch: Please provide a script allowing to compact the xapian base

2013-08-23 Thread Ben Gamari
Olivier Berger said: I think it would be great to provide a script allowing to do some maintenance on the xapian DB to improve performance, as explained in http://notmuchmail.org/performance/ (Compact your database). A few months^H^H^H nearly a year ago I had a patch[1] adding a `notmuch

[no subject]

2013-08-23 Thread Ben Gamari
From: Ben Gamari bgamari.f...@gmail.com Subject: [PATCH] notmuch compact support (v3) In-Reply-To: Here is the latest (and hopefully last) iteration of my patchset introducing a compact command. The set has been rebased on top of master, a manpage has been added, and error handling has been

[PATCH 3/3] notmuch-compact: Add man page

2013-08-23 Thread Ben Gamari
Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- man/Makefile.local | 1 + man/man1/notmuch-compact.1 | 33 + 2 files changed, 34 insertions(+) create mode 100644 man/man1/notmuch-compact.1 diff --git a/man/Makefile.local b/man/Makefile.local index

[PATCH 1/3] database: Add notmuch_database_compact_close

2013-08-23 Thread Ben Gamari
This function uses Xapian's Compactor machinery to compact the notmuch database. The compacted database is built in a temporary directory and later moved into place while the original uncompacted database is preserved. Signed-off-by: Ben Gamari bgamari.f...@gmail.com --- configure | 27

[ANNOUNCE] notmuch-web 0.1.0

2013-03-03 Thread Ben Gamari
John Lenz writes: > I have been recently working on a web interface to notmuch. The past two > weeks, I have used it as my only email client and since the trial period > was a great success (I had no major issues or problems and never had to > revert to another client), I have decided to

Re: [ANNOUNCE] notmuch-web 0.1.0

2013-03-03 Thread Ben Gamari
John Lenz l...@math.uic.edu writes: I have been recently working on a web interface to notmuch. The past two weeks, I have used it as my only email client and since the trial period was a great success (I had no major issues or problems and never had to revert to another client), I have

[PATCH 3/3] Add notmuch compact command

2012-10-17 Thread Ben Gamari
--- Makefile.local|1 + notmuch-client.h |3 +++ notmuch-compact.c | 43 +++ notmuch.c |3 +++ 4 files changed, 50 insertions(+) create mode 100644 notmuch-compact.c diff --git a/Makefile.local b/Makefile.local index

[PATCH 2/3] Produce status messages during compacting

2012-10-17 Thread Ben Gamari
--- lib/database.cc | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 6e83a61..49aa36d 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -780,11 +780,24 @@ notmuch_database_close (notmuch_database_t *notmuch)

[PATCH 1/3] Add notmuch_database_close_compact

2012-10-17 Thread Ben Gamari
--- configure | 21 - lib/database.cc | 54 ++ lib/notmuch.h | 14 ++ 3 files changed, 88 insertions(+), 1 deletion(-) diff --git a/configure b/configure index acb90a8..6551b13 100755 ---

[PATCH] notmuch compact support

2012-10-17 Thread Ben Gamari
Here is a new spin of my patchset introduced in late August (id:"1345476704-17091-1-git-send-email-bgamari.foss at gmail.com") adding a compact command to libnotmuch and the command line frontend. I believe the concerns raised in August have been addressed, but correct me if I'm wrong. Cheers,

[PATCH] notmuch compact support

2012-10-17 Thread Ben Gamari
Here is a new spin of my patchset introduced in late August (id:1345476704-17091-1-git-send-email-bgamari.f...@gmail.com) adding a compact command to libnotmuch and the command line frontend. I believe the concerns raised in August have been addressed, but correct me if I'm wrong. Cheers, - Ben

[PATCH 3/3] Add notmuch compact command

2012-10-17 Thread Ben Gamari
--- Makefile.local|1 + notmuch-client.h |3 +++ notmuch-compact.c | 43 +++ notmuch.c |3 +++ 4 files changed, 50 insertions(+) create mode 100644 notmuch-compact.c diff --git a/Makefile.local b/Makefile.local index

[PATCH 2/3] Produce status messages during compacting

2012-10-17 Thread Ben Gamari
--- lib/database.cc | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 6e83a61..49aa36d 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -780,11 +780,24 @@ notmuch_database_close (notmuch_database_t *notmuch)

[PATCH 1/3] Add notmuch_database_close_compact

2012-08-21 Thread Ben Gamari
Tomi Ollila writes: > On Mon, Aug 20 2012, Ben Gamari wrote: > >> --- >> configure | 25 - >> lib/database.cc | 54 >> ++ >> lib/notmuch.h | 14 ++ >

[PATCH RFC?] Compactification support

2012-08-21 Thread Ben Gamari
Jani Nikula writes: > On Mon, 20 Aug 2012, Ben Gamari wrote: >> Here is a small patchset adding support for database compaction when >> supported by Xapian. Here I add a function which both compacts and >> closes the database. > > What are the benefits of this co

[PATCH 3/3] Add notmuch compact command

2012-08-20 Thread Ben Gamari
--- Makefile.local|1 + notmuch-client.h |3 +++ notmuch-compact.c | 43 +++ notmuch.c |3 +++ 4 files changed, 50 insertions(+) create mode 100644 notmuch-compact.c diff --git a/Makefile.local b/Makefile.local index

[PATCH 2/3] Produce status messages during compacting

2012-08-20 Thread Ben Gamari
--- lib/database.cc | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 6e83a61..49aa36d 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -780,11 +780,24 @@ notmuch_database_close (notmuch_database_t *notmuch)

[PATCH 1/3] Add notmuch_database_close_compact

2012-08-20 Thread Ben Gamari
--- configure | 25 - lib/database.cc | 54 ++ lib/notmuch.h | 14 ++ 3 files changed, 92 insertions(+), 1 deletion(-) diff --git a/configure b/configure index dc0dba4..370fedd 100755 ---

[PATCH RFC?] Compactification support

2012-08-20 Thread Ben Gamari
Here is a small patchset adding support for database compaction when supported by Xapian. Here I add a function which both compacts and closes the database. This is due to it being not entirely clear whether one is allowed to compact the database while it is being held open for read/write.

[PATCH RFC?] Compactification support

2012-08-20 Thread Ben Gamari
Here is a small patchset adding support for database compaction when supported by Xapian. Here I add a function which both compacts and closes the database. This is due to it being not entirely clear whether one is allowed to compact the database while it is being held open for read/write.

[PATCH 2/3] Produce status messages during compacting

2012-08-20 Thread Ben Gamari
--- lib/database.cc | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 6e83a61..49aa36d 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -780,11 +780,24 @@ notmuch_database_close (notmuch_database_t *notmuch)

[PATCH 1/3] Add notmuch_database_close_compact

2012-08-20 Thread Ben Gamari
--- configure | 25 - lib/database.cc | 54 ++ lib/notmuch.h | 14 ++ 3 files changed, 92 insertions(+), 1 deletion(-) diff --git a/configure b/configure index dc0dba4..370fedd 100755 ---

[PATCH 3/3] Add notmuch compact command

2012-08-20 Thread Ben Gamari
--- Makefile.local|1 + notmuch-client.h |3 +++ notmuch-compact.c | 43 +++ notmuch.c |3 +++ 4 files changed, 50 insertions(+) create mode 100644 notmuch-compact.c diff --git a/Makefile.local b/Makefile.local index

Segmentation fault in notmuch search --format=json

2012-08-07 Thread Ben Gamari
It seems some messages trigger a segmentation fault in `do_search_threads()`. It appears the problem occurs (at least) when `authors` is NULL. Program received signal SIGSEGV, Segmentation fault. 0x00415aa3 in json_string (sp=0x646c70, val=0x0) at sprinter-json.c:121 121

Segmentation fault in notmuch search --format=json

2012-08-06 Thread Ben Gamari
It seems some messages trigger a segmentation fault in `do_search_threads()`. It appears the problem occurs (at least) when `authors` is NULL. Program received signal SIGSEGV, Segmentation fault. 0x00415aa3 in json_string (sp=0x646c70, val=0x0) at sprinter-json.c:121 121

Ubuntu messaging menu integration

2012-05-29 Thread Ben Gamari
Hey all, I recently dusted off a little hack I've been sitting on for quite a while integrating notmuch into Ubuntu's messaging menu[1]. The code is now on Github[2] in case someone finds it useful. Pull requests are of course welcome. Cheers, - Ben [1] https://wiki.ubuntu.com/MessagingMenu

Ubuntu messaging menu integration

2012-05-29 Thread Ben Gamari
Hey all, I recently dusted off a little hack I've been sitting on for quite a while integrating notmuch into Ubuntu's messaging menu[1]. The code is now on Github[2] in case someone finds it useful. Pull requests are of course welcome. Cheers, - Ben [1] https://wiki.ubuntu.com/MessagingMenu

Rethinking *_destroy()

2011-09-19 Thread Ben Gamari
On Mon, 19 Sep 2011 16:22:39 -0400, Ben Gamari wrote: > I can see at least two ways of doing this, > > 1) Acknowledging that we use talloc and allowing users to use > talloc_ref and talloc_unlink directly > > 2) Wrapping talloc by adding a *_ref() and *_unref() t

Re: Rethinking *_destroy()

2011-09-19 Thread Ben Gamari
On Mon, 19 Sep 2011 16:22:39 -0400, Ben Gamari bgamari.f...@gmail.com wrote: I can see at least two ways of doing this, 1) Acknowledging that we use talloc and allowing users to use talloc_ref and talloc_unlink directly 2) Wrapping talloc by adding a *_ref() and *_unref() to each

Memory management practices

2011-09-11 Thread Ben Gamari
Sorry I've been so quiet on this recently. I've been a little under the weather. On Fri, 9 Sep 2011 13:53:28 -0400, Austin Clements wrote: > Ah, the *Python* objects don't care, but the underlying C objects do. > Suppose the Query were finalized first. Python calls Query.__del__, > which calls

Re: Memory management practices

2011-09-11 Thread Ben Gamari
Sorry I've been so quiet on this recently. I've been a little under the weather. On Fri, 9 Sep 2011 13:53:28 -0400, Austin Clements amdra...@mit.edu wrote: Ah, the *Python* objects don't care, but the underlying C objects do. Suppose the Query were finalized first. Python calls Query.__del__,

Memory management practices

2011-09-07 Thread Ben Gamari
On Mon, 29 Aug 2011 16:30:57 -0400, Ben Gamari wrote: > [SNIP] > > In general, it seems to me that memory management in notmuch bindings is > a little bit harder than it needs to me due to the decision not to > talloc_ref parent objects when a new child object is crea

Memory management practices

2011-08-29 Thread Ben Gamari
, 29 Aug 2011 20:30:10 +0200, Bertram Felgenhauer wrote: > Dear Ben, > > Ben Gamari wrote: > > After looking into this issue in a bit more depth, I'm even more > > confused. In fact, I would not be surprised if I have stumbled into a > > bug in the GC. > [..

Bug in GC's ordering of ForeignPtr finalization?

2011-08-29 Thread Ben Gamari
On Sun, 28 Aug 2011 22:26:05 -0500, Antoine Latter wrote: > One problem you might be running in to is that the optimization passes > can notice that a function isn't using all of its arguments, and then > it won't pass them. These even applies if the arguments are bound > together in a record

Memory management practices

2011-08-29 Thread Ben Gamari
, 29 Aug 2011 20:30:10 +0200, Bertram Felgenhauer bertram.felgenha...@googlemail.com wrote: Dear Ben, Ben Gamari wrote: After looking into this issue in a bit more depth, I'm even more confused. In fact, I would not be surprised if I have stumbled into a bug in the GC

Bug in GC's ordering of ForeignPtr finalization?

2011-08-28 Thread Ben Gamari
On Tue, 16 Aug 2011 12:32:13 -0400, Ben Gamari wrote: > It seems that the notmuch-haskell bindings (version 0.2.2 built against > notmuch from git master; passes notmuch-test) aren't dealing with memory > management properly. In particular, the attached test code[1] causes > tal

Bug in GC's ordering of ForeignPtr finalization?

2011-08-28 Thread Ben Gamari
On Tue, 16 Aug 2011 12:32:13 -0400, Ben Gamari bgamari.f...@gmail.com wrote: It seems that the notmuch-haskell bindings (version 0.2.2 built against notmuch from git master; passes notmuch-test) aren't dealing with memory management properly. In particular, the attached test code[1] causes

Memory management issue in notmuch-haskell bindings

2011-08-16 Thread Ben Gamari
It seems that the notmuch-haskell bindings (version 0.2.2 built against notmuch from git master; passes notmuch-test) aren't dealing with memory management properly. In particular, the attached test code[1] causes talloc to abort. Unfortunately, while the issue is consistently reproducible, it

Notmuch scripts

2011-06-28 Thread Ben Gamari
On Tue, 28 Jun 2011 10:36:59 +0200, Pieter Praet wrote: > On Mon, 27 Jun 2011 21:31:26 -0400, Ben Gamari > wrote: > > [SNIP] It > > would be nice, however, if the emacs interface supported hiding tags > > matching certain patterns (say /\..+/). > > This shoul

  1   2   3   >