On Mon 2023-09-25 11:54:07 +0300, Teemu Likonen wrote:
> Some person on debian-user mailing list seems to be sending messages
> with fixed Message-ID field: the same ID in different messages. In
> Notmuch it is creating trouble because it connects unrelated threads to
> one. The person has
Hey notmuch folks--
When using notmuch-emacs, and looking at a text/html part, i sometimes
want to know where a given link is pointing to without clicking on it --
e.g. to open it in an alternate browser.
it appears that by positioning the point somewhere within the link and
doing "M-x
Just a nudge on this patch:
any chance we can have it applied in the notmuch tree?
--dkg
On Fri 2022-11-11 05:16:31 -0500, Daniel Kahn Gillmor wrote:
> On Wed 2022-11-02 18:02:00 -0300, David Bremner wrote:
>> Daniel Kahn Gillmor writes:
>>
>>> GnuPG upstream has su
Hey notmuch folks--
when i launch emacs these days i see the following in my *Warnings*
buffer:
Warning (comp): notmuch-hello.el:719:22: Warning: docstring wider than 80
characters Disable showing Disable logging
Warning (comp): notmuch-hello.el:855:8: Warning: docstring wider than 80
On Wed 2022-11-02 18:02:00 -0300, David Bremner wrote:
> Daniel Kahn Gillmor writes:
>
>> GnuPG upstream has supported pkg-config since gpgme version 1.13 and
>> gpg-error 1.33, and now prefers the use of pkg-config by default,
>> instead of relying on gpg-error
On Wed 2022-11-09 12:58:18 -0800, Jameson Graef Rollins wrote:
> Personally I think it would make sense to have % cycle through
> duplicates, with some indicator of which duplicate we're currently on.
> I wouldn't even bother with the suggested prefixed behavior if we just
> had the cycle
On Wed 2022-11-09 09:53:26 -0500, Daniel Kahn Gillmor wrote:
> The functionality here, switching between duplicates in the emacs
> frontend, is great. I needed to use it today, because i had two copies
> of an e-mail message, one with a valid signature and one with a damaged
> signatu
On Fri 2022-07-01 18:45:39 -0300, David Bremner wrote:
> This obsoletes the WIP series [1]. Compared to that series, this one
> includes somewhat improved documentation, better error handling, and
> implements the --duplicate argument for notmuch-reply, and uses it in
> the emacs front end.
>
>
1.18.0, upstream does not
ship gpgme-config if gpg-error-config is also not present.
Both of these versions of upstream libraries are in debian unstable
now. To the extent that notmuch is dependent on GnuPG, it should
follow GnuPG upstream's lead.
Signed-off-by: Daniel Kahn Gillmor
---
configure
I believe this is "v2" of Justus's earlier patch
id:20220909161354.715326-1-jus...@sequoia-pgp.org, even though the
subject line doesn't say "v2" in it:
On Thu 2022-09-22 10:46:06 +0200, Justus Winter wrote:
> This replaces the old OpenPGPv4 key that is used in the test suite
> with a more modern
On Sun 2022-09-11 23:50:18 +0200, Justus Winter wrote:
> Tomi Ollila writes:
>
>> On Fri, Sep 09 2022, Justus Winter wrote:
>>
>>> ---
>>> test/T350-crypto.sh | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh
>>> index
This series looks good to me. i've tested it and there are no failures,
and there's nothing i can see that's obviously missing from it. Thanks
for the thorough fix, Justus!
A few notes about the change (none of them even close to being
blockers):
- i note that signature creation timestamps had
I'm running the test suite on notmuch master
(8eabd6388ecb7bea8246a9ba6943a0432d23406e), and i see the following
report:
```
All 1758 tests behaved as expected (12 expected failures).
-1 tests skipped.
All tests in 2 files skipped.
```
-1 tests skipped is pretty strange!
I haven't tracked it
Thanks, Michael--
This LGTM.
It is more narrowly-targeted at permitting this specific variation than
Bremner's earlier version of the patch (and it doesn't have any tests
marked BROKEN), which is nice.
It might be marginally cleaner to swap out the LEFT_ANGLE RIGHT_ANGLE
variables for a single
On Mon 2022-04-11 10:44:47 +0200, Michael J Gruber wrote:
> Just so that others don't have to be wondering, too: notmuch does not embed
> gmime sources and does not reuse them. (It would be very wrong to do so.)
> notmuch has a file `_check_gmime_cert.c` which is used for configure checks
> and
Thanks, Bremner!
This series looks reasonable to me. nice clever hack to reuse the
gmime embedded .c source for the test.
a bit of a tweak below:
On Sat 2022-04-09 09:34:53 -0300, David Bremner wrote:
> + printf "Checking for GMime new email format... "
> + if ${CC} -DCHECK_EMAIL
g based on the bare e-mail address and assert a build-dep on
gmime 3.2.8 (see attached), but that seems a little bit extreme, since
gmime only released 3.2.9 recently (and 3.2.8 never made it out the door
via any formal channels, if i understand the history correctly).
I'll see whether i can make a better fi
On Mon 2022-01-24 14:02:33 +0100, Justus Winter wrote:
> na...@mailbox.org writes:
>
>> I have been using Notmuch with Emacs for a couple of days and it has
>> been working great, except for when I open mails from a certain sender
>> with S/MIME signed messages, Emacs will freeze up for about 4
On Fri 2021-08-06 09:35:52 +0200, Ralph Seichter wrote:
> Oh my... Are "+1" replies not sufficient anymore for some people, or is
> this a means of allowing the authors to claim having created an RFC, no
> matter how useless it is? ;-)
fwiw, i think this is a little bit ridiculous too. ☺
But in
Hi notmuch folks--
RFC 9078 is an experimental draft "Reaction: Indicating Summary Reaction
to a Message":
https://www.rfc-editor.org/rfc/rfc9078.html
In short form, this lets you "thumbs up" an e-mail message without
sending a longer reply.
Basically, it formalizes a way to respond to an
On Sat 2021-06-26 13:41:44 -0300, David Bremner wrote:
> From: Daniel Kahn Gillmor
>
> Most concrete verification steps are likely only taken on the e-mail
> address in the first place, and e-mail addresses render more
> intelligibly than arbitrary User IDs in the first place.
On Mon 2021-06-07 13:07:12 +0100, David Edmondson wrote:
> Could this not be something like:
>
> (when (or email userid)
> (setq label (concat "Good signature by: " (or email userid)))
> ...
> )
>
> ?
Sounds reasonable to me. If you want to offer a revised patch for this,
i'd definitely
On Thu 2021-05-27 20:11:13 +0300, Tomi Ollila wrote:
> On Thu, May 27 2021, Daniel Kahn Gillmor wrote:
>> +Keymaps are no longer fset, which means they need to be referred to in
>> +define-key directly (without quotes). If your ~/.emacs has a
>
> In our docs it would be bette
See list discussion in thread starting with
id:87h7ip2baq@fifthhorseman.net for more details.
Signed-off-by: Daniel Kahn Gillmor
---
NEWS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS b/NEWS
index c0ae6afe..c3ca1085 100644
--- a/NEWS
+++ b/NEWS
@@ -101,6 +101,13 @@ Removed
On Wed 2021-05-26 23:34:47 -0400, Kyle Meyer wrote:
> Daniel Kahn Gillmor writes:
>
>> I worry that this is due to one of the two following commits but my
>> elisp-foo is weak enough that i don't know what the right next steps are:
>
> It's due to the second commit, 05a
I just tried to upgrade notmuch to the head of development. my ~/.emacs
contains a stanza for a shortcut for dealing with junk mail, which has
given me no problems at all for notmuch 0.31.4-1:
-
;; notmuch junk handling
(defun dkg-notmuch-show-handle-junk ()
"Mark the message as spam,
Most concrete verification steps are likely only taken on the e-mail
address in the first place, and e-mail addresses render more
intelligibly than arbitrary User IDs in the first place.
Signed-off-by: Daniel Kahn Gillmor
---
emacs/notmuch-crypto.el | 15 ++-
1 file changed, 10
eady thinks it knows what the e-mail address is.
See id:878s41ax6t@fifthhorseman.net for more motivation and discussion.
Signed-off-by: Daniel Kahn Gillmor
---
devel/schemata | 1 +
notmuch-show.c | 5 +
test/T350-crypto.sh| 6 --
Hi folks--
id:e4a7efe92433f7c3e5dedeac0ea4efc003020296.ca...@ericsson.com from the
IETF LAMPS WG mailing list can be found at
https://mailarchive.ietf.org/arch/msg/quic/FpbJTLXsoFLSNr--LgxCOC6IssY.
when rendering it, notmuch-emacs shows:
[ Good signature by:
Hi David, all--
On Sun 2021-02-21 15:21:30 +, David Edmondson wrote:
> I started looking at how to add autocrypt support based on
> https://git.sr.ht/~zge/autocrypt.
Thanks for this work, i'm glad to see the interest in autocrypt!
I tend to think that the autocrypt handling belongs in
contributor" but I think this is a safe way to encourage people to use
python3 when they're developing notmuch.
We already have python3 explicitly elsewhere in the codebase for
developers (in nmbug).
Signed-off-by: Daniel Kahn Gillmor
---
bindings/python/setup.py | 2 +-
test/json_check_nodes
On Mon 2021-01-04 22:07:49 +0100, Jonas Bernoulli wrote:
> There are other places in the elisp code where the `:content-type' is
> assumed to be a string, so fixing it just here doesn't cut it. To fix
> it for everyone, "notmuch show..." should probably take care of falling
> back to some sane
On Sun 2021-01-03 09:48:56 +0200, Teemu Likonen wrote:
> But yes, it would be nice to filter headers like "Received", maybe
> "DKIM-Signature" and various unofficial headers starting with "X-".
Right, my current value of message-forward-ignored-headers is:
("^Content-Transfer-Encoding:"
Hi Jonas--
Thanks for the followup! i got the backtrace.
On Sat 2021-01-02 10:47:44 +0100, Jonas Bernoulli wrote:
>> notmuch-show--register-cids: Wrong type argument:
>> char-or-string-p, nil
>
> With only that information my guess is that
> (plist-get part :content-type)
> returns
notmuch has no tcl code, and doxygen upstream is deprecating/removing
tcl support anyway:
https://github.com/doxygen/doxygen/commit/48a7afc0caf69857a42b0fe1963db3440cb4000f
---
doc/doxygen.cfg | 1 -
1 file changed, 1 deletion(-)
diff --git a/doc/doxygen.cfg b/doc/doxygen.cfg
index
Hi Teemu--
On Wed 2020-12-30 12:46:02 +0200, Teemu Likonen wrote:
> I don't know any automatic way to remove headers from an email message
> that is stored as a MIME part.
The straightforward way seems to be to parse/interpret the message with
our knowledge of rfc5322, identify the headers to be
On Thu 2020-01-16 15:20:49 -0500, Daniel Kahn Gillmor wrote:
> On Wed 2020-01-08 10:25:50 -0500, Daniel Kahn Gillmor wrote:
>> Thanks for the pointer! it looks like
>> message-forward-{ignored,included}-headers should do (roughly) what i
>> want. I'll try them out.
&g
On Fri 2020-07-03 19:58:23 -0300, David Bremner wrote:
> The bikeshed must be blue! Uh, I mean what about narrowish screens (80
> columns or so) and or deeply indented threads?
You mean what should happen to messages with headers that are much
longer, like:
To: David Bremner , Kevin Foley ,
On Thu 2020-07-02 18:02:34 -0400, Kevin Foley wrote:
> Daniel Kahn Gillmor writes:
>> and it could take three values:
>>
>> - nil (default), shows the Date: header as received
>> - t, shows the timestamp from the Date: header in local time,
>>with the as-re
On Wed 2020-06-24 21:44:01 +1000, Peter Wang wrote:
> On Mon, 22 Jun 2020 12:22:50 +0200 Lukasz Stelmach
> wrote:
>> It was <2020-06-20 sob 12:53>, when Reto wrote:
>> > On Fri, Jun 19, 2020 at 12:40:49PM +0200, Łukasz Stelmach wrote:
>> >> Having "setup" in the set requires entering three
This proposed notmuch-show-local-dates feature is a nice one. It
renders the Date header in a format that is likely to be more useful to
the viewer. I certainly find this more useful than having to do the
TZ conversions in my head.
But, setting this to t hides the sender's TZ from the viewer --
Hi Bremner, all--
On Mon 2020-06-29 22:14:07 -0300, David Bremner wrote:
> I know that some of you are not C++ fans, but at the moment this is
> the cleanest fix I can think of to uncaught xapian exceptions causing
> calls to the library to die. Floris reminded me of this recently with
> the
On Thu 2020-07-02 10:36:34 +0300, Tomer B wrote:
> Hi, I tried searching but the mailing list is huge..
You might try searching at the new mailing list interface:
https://nmbug.notmuchmail.org/nmweb/ -- put your search terms in the
"terms" box!
> I'm a newbie and impressed by notmuch. I want
On Thu 2020-07-02 10:01:07 -0300, David Bremner wrote:
> Tomi Ollila writes:
>
>> On Fri, Jun 26 2020, David Bremner wrote:
>>
>>> Fedora still has an old gmime-devel which is 2.6.x. This is no longer
>>> supported by notmuch.
>>> ---
>>> INSTALL | 2 +-
>>> configure | 2 +-
>>> 2 files
If https://dev.gnupg.org/T3464 is unresolved in the version of gpgme
we are testing against, then we should know about it, because it
affects the behavior of notmuch.
Signed-off-by: Daniel Kahn Gillmor
---
configure | 78 ++-
1 file changed
We make use of the just-introduced configure test.
Signed-off-by: Daniel Kahn Gillmor
---
test/T357-index-decryption.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/test/T357-index-decryption.sh b/test/T357-index-decryption.sh
index 1ac2836a..1ed5f28c 100755
--- a/test/T357-index
fy a signature, which is what we see here.
--dkg
From ae4d7761a15b82eb98b0bcc72af2ae2e8973e1f9 Mon Sep 17 00:00:00 2001
From: Daniel Kahn Gillmor
Date: Wed, 29 May 2019 17:56:01 -0400
Subject: [GPGME PATCH] gpg: Avoid error diagnostics with
--override-session-key when verifying
* src/engine-gpg.c (gpg_decrypt): o
Hi folks--
David Bremner, Carl Worth, and i did some maintenance work today. We
hope that what we did was to successfully move the notmuch mailing list
to a mailman3 instance.
Please let us know if you have any problems with it (such as not
receiving this message, ha ha).
(feel free to send
Hi all--
I see over on github that alot is trying to port to the notmuch2
bindings, and having a few problems with it:
https://github.com/pazz/alot/pull/1511
alot is an important consumer of the notmuch python bindings, and it
would be really great to see them successfully transition to the
Signed-off-by: Daniel Kahn Gillmor
---
NEWS | 35 +++
1 file changed, 35 insertions(+)
diff --git a/NEWS b/NEWS
index 14db7f6f..1921127f 100644
--- a/NEWS
+++ b/NEWS
@@ -1,6 +1,41 @@
Notmuch 0.30 (2020-06-01)
=
+S/MIME
On Tue 2020-05-26 13:06:02 -0400, Daniel Kahn Gillmor wrote:
> ---
> test/test-lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 792b1cb9..78a90862 100644
> --- a/test/test-lib.sh
> +++ b/test/
On Sat 2020-05-23 21:52:18 +0200, Floris Bruynooghe wrote:
> modified test/T391-python-cffi.sh
> @@ -8,7 +8,7 @@ fi
>
>
> test_begin_subtest "python cffi tests"
> -pytest_dir=$NOTMUCH_SRCDIR/bindings/python-cffi/build/stage
> +pytest_dir=$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage
>
---
test/test-lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 792b1cb9..78a90862 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -1081,7 +1081,7 @@ test_python() {
}
test_ruby() {
-MAIL_DIR=$MAIL_DIR
When building out-of-tree, the documentation (both manpages and info
files) are incomplete, but they do not explicitly fail. build logs
follow from doing "mkdir build && ../configure && make".
If there's a way to make these warnings into hard failures, i think that
would be good -- we don't want
On Sun 2020-05-24 20:59:29 +0300, Tomi Ollila wrote:
> On Thu, May 21 2020, Daniel Kahn Gillmor wrote:
>
>> In out-of-tree builds, $TEST_DIRECTORY doesn't contain
>> json_check_nodes.py. This caused 27 tests to fail in such an
>> environment.
>
> are you shure the
On Thu 2020-05-21 21:03:59 -0400, Daniel Kahn Gillmor wrote:
> This is a simple hack to enable out-of-tree builds, a concern raised
> by Tomi in id:m24kzjib9a@guru.guru-group.fi
>
> This change at least enables "make check" to complete without error,
> but I'm sure it
On Fri 2020-05-22 19:58:19 +0100, Mark Walters wrote:
> As far as I can see the split-window-sensibly version splits the
> window into two equal parts, whereas the split-window-vertically
> version (deliberately) makes the message pane bigger than the thread
> pane.
I find this argument
Hey folks--
I just did a bit of testing and cleanup for out-of-tree builds (see the
minor patches that should have landed on the list in the last hour or
two).
For me, "make check" in an out-of-tree build works fine now, with the
exception of T391-python-cffi.sh and T395-ruby.sh.
I'm afraid i
In out-of-tree builds, $TEST_DIRECTORY doesn't contain
json_check_nodes.py. This caused 27 tests to fail in such an
environment.
Signed-off-by: Daniel Kahn Gillmor
---
test/test-lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index
On Mon 2019-11-04 23:26:25 +0200, Tomi Ollila wrote:
> how bad does out-of-tree build break with this -- do we need to do
> the same as with ruby bindings (copy sources -- do we still do so)? or does
> python provide better alternative..?
I've just posted
by: Daniel Kahn Gillmor
---
configure | 8
1 file changed, 8 insertions(+)
diff --git a/configure b/configure
index 37368bda..f0472e8e 100755
--- a/configure
+++ b/configure
@@ -70,6 +70,14 @@ if [ "$srcdir" != "." ]; then
mkdir bindings/ruby
cp -a "$sr
On Fri 2020-05-22 00:57:14 +0300, Tomi Ollila wrote:
> We've accumulated quite a bit of mess during these years to the test
> system, which makes it harder to do larger adjustments (and not (yet)
> mentioning even larger refactorings...).
The last significant refactoring was probably when
uld fail early, during ./configure.
To break out these specific User ID checks from other checks, i had to
split some tests into two parts, and reuse $output across the two
subtests.
Signed-off-by: Daniel Kahn Gillmor
---
configure | 83 +-
t
Thanks for the review, and for the poke about out-of-tree builds on IRC,
Bremner. Another revision is coming in a minute. Notes below…
On Thu 2020-05-21 20:29:05 -0300, David Bremner wrote:
> I find these long lines with !! in the middle pretty surprising. Is
> there some reason for this style?
On Sat 2020-05-02 20:11:09 -0400, Radu Butoi wrote:
> This uses the standard Emacs function `split-window-sensibly` to split a
> window horizontally or vertically depending on space when opening a
> message in tree view. By default, split-width-threshold is 160 columns
> (and -height- is nil), so
On Wed 2020-05-13 20:00:24 +1000, Tom Fitzhenry wrote:
> notmuch-expr allows you to write notmuch search queries in sexp style like:
>
> (notmuch-expr
> '(and
> (to "emacs-devel")
> "info manual"
> (or
> (not (is "spam"))
> (is "important"
>
> which will generate the
On Mon 2020-05-04 00:21:36 +0300, Tomi Ollila wrote:
> Fixed emacs docstrings to be consistent. No functional change.
>
> - removed some (accidental) indentation
> - removed some trailing newlines
> - added trailing periods where missing (some exclusions)
This all looks good to me, except for the
On Mon 2020-05-04 09:25:59 +0200, Gregor Zattler wrote:
> * Keegan Carruthers-Smith [2020-05-03; 22:37]:
>> notmuch tag -waiting -- tag:waiting and 'thread:{tag:new}'
>
> but this removes the waiting tag if there is some response
> to some message in the thread, not necessary to the message
>
On Thu 2020-05-21 00:16:48 +0300, Tomi Ollila wrote:
> (just tested this latest works)
Thanks for looking into this, Tomi!
Do you have a patch to propose?
--dkg
signature.asc
Description: PGP signature
___
notmuch mailing list
On Tue 2020-05-12 20:14:07 -0300, David Bremner wrote:
> Daniel Kahn Gillmor writes:
>>
>> Clearly, that FIXED should come *after* the "T356-protected-headers:"
>> separator.
>>
>
> Can you reproduce this without running the tests in parallel?
Yep:
Unwrap a PKCS#7 SignedData part unconditionally when the cli is
traversing the MIME tree, and return it as a "child" of what would
otherwise be a leaf in the tree.
Unfortunately, this also breaks the JSON output. We will fix that
next.
Signed-off-by: Daniel Kahn Gillmor
---
m
This revision of the PKCS#7 S/MIME handling series is based on (and
very similar to) the series sent on the thread starting at
id:20200430201328.725651-1-...@fifthhorseman.net
However, it is rebased after more gracefully handling the subtle
errors in X.509 certificate validity when built against
w.
Signed-off-by: Daniel Kahn Gillmor
---
lib/index.cc | 57 ++
test/T355-smime.sh | 2 --
2 files changed, 57 insertions(+), 2 deletions(-)
diff --git a/lib/index.cc b/lib/index.cc
index 158ba5cf..bbf13dc5 100644
--- a/lib/index.cc
+++ b/li
We don't handle them correctly yet, but we can at least mark them as
being encrypted.
Signed-off-by: Daniel Kahn Gillmor
---
lib/index.cc | 4
test/T355-smime.sh | 1 -
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/index.cc b/lib/index.cc
index bbf13dc5..f029b334
-onepart-signed@protected-headers.example.
Signed-off-by: Daniel Kahn Gillmor
---
notmuch-show.c | 11 ++-
test/T355-smime.sh | 6 +++---
test/T356-protected-headers.sh | 3 +--
3 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/notmuch-show.c b
When composing a reply, no one wants to see this line in the proposed
message:
Non-text part: application/pkcs7-mime
So we hide it, the same way we hide PGP/MIME cruft.
Signed-off-by: Daniel Kahn Gillmor
---
notmuch-reply.c| 5 +++--
test/T355-smime.sh | 1 -
2 files changed, 3
, but that will happen in the following changes.
Signed-off-by: Daniel Kahn Gillmor
---
util/crypto.c | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/util/crypto.c b/util/crypto.c
index fbd5f011..c09f467b 100644
--- a/util/crypto.c
+++ b/util
.
Signed-off-by: Daniel Kahn Gillmor
---
lib/index.cc | 8
mime-node.c | 3 +--
util/crypto.c | 6 +++---
util/crypto.h | 2 +-
4 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/lib/index.cc b/lib/index.cc
index f029b334..da9a3abe 100644
--- a/lib/index.cc
+++ b/lib/index.cc
Signed-off-by: Daniel Kahn Gillmor
---
mime-node.c| 6 ++
test/T355-smime.sh | 2 --
test/T356-protected-headers.sh | 6 +++---
3 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/mime-node.c b/mime-node.c
index c2ee858d..f552e03a 100644
--- a/mime-no
uld fail early, during ./configure.
To break out these specific User ID checks from other checks, i had to
split some tests into two parts, and reuse $output across the two
subtests.
Signed-off-by: Daniel Kahn Gillmor
---
configure | 79 ++
t
On Sat 2020-05-09 08:47:10 -0300, David Bremner wrote:
> I'm confused about where to apply 2/2. If I apply it on top of (updated)
> master, it causes test failures. If I apply after the rest of the
> patches in this thread then presumably there is some interval where the
> build is broken (if only
I'm debugging/diagnosing/trying to clean up some "FIXED" known-broken
tests right now.
Sometimes, depending on circumstances i can't predict (race
conditions?), I see funny output like:
~~~
Use "make V=1" to see the details for passing and known broken tests.
INFO: using 2m timeout for tests
We already report the minimum version for Glib, zlib, and Xapian
development libraries. For consistency, report it for GMime as well.
Signed-off-by: Daniel Kahn Gillmor
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 92e5bd1b
On Sat 2020-05-09 08:47:10 -0300, David Bremner wrote:
> I'm confused about where to apply 2/2. If I apply it on top of (updated)
> master, it causes test failures. If I apply after the rest of the
> patches in this thread then presumably there is some interval where the
> build is broken (if only
-lib.sh so that they do not
get clobbered when used outside test-lib.
We also move the local variable declarations to beginning of each
function, to avoid weird gotchas with local variable declarations as
described in https://tldp.org/LDP/abs/html/localvar.html.
Signed-off-by: Daniel Kahn Gillmor
---
On Thu 2020-05-07 10:31:38 +0300, Tomi Ollila wrote:
> Good stuff
>
> robustness comment IMO:
>
> There is slight difference when writing
>
> local foo=`false`
>
> and
>
> local foo; foo=`false`
>
>
> former does not "fail"; latter does,
thanks for pointing this out. On IRC, jindraj
On Thu 2020-05-07 16:40:26 -0700, Carl Worth wrote:
> On Thu, May 07 2020, Daniel Kahn Gillmor wrote:
>> +separator. Except for boolean options (wihch would be ambiguous), a
>
> Misspelling of "which". And while I'm here, strictly speaking Boolean is
> generally capita
of the manual.
Signed-off-by: Daniel Kahn Gillmor
---
doc/man1/notmuch.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/man1/notmuch.rst b/doc/man1/notmuch.rst
index d2cd8da5..3dcc646c 100644
--- a/doc/man1/notmuch.rst
+++ b/doc/man1/notmuch.rst
@@ -128,9 +128,9 @@ OPTION
uld fail early, during ./configure.
To break out these specific User ID checks from other checks, i had to
split some tests into two parts, and reuse $output across the two
subtests.
Signed-off-by: Daniel Kahn Gillmor
---
configure | 79 ++
t
-lib.sh so that they do not
get clobbered when used outside test-lib.
Signed-off-by: Daniel Kahn Gillmor
---
test/test-lib.sh | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 5c8eab7c..e8fea
Hi Tomi--
On Sat 2020-05-02 00:15:57 +0300, Tomi Ollila wrote:
> I did not see anything suspicious in code, but
>
> I got these test failures:
>
> in ubuntu 19.10 native environment, and
>
> in debian 10 (podman) container running in fedora 31 system
>
>
> T355-smime: Testing S/MIME signature
, but that will happen in the following changes.
Signed-off-by: Daniel Kahn Gillmor
---
util/crypto.c | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/util/crypto.c b/util/crypto.c
index fbd5f011..c09f467b 100644
--- a/util/crypto.c
+++ b/util
Unwrap a PKCS#7 SignedData part unconditionally when the cli is
traversing the MIME tree, and return it as a "child" of what would
otherwise be a leaf in the tree.
Unfortunately, this also breaks the JSON output. We will fix that
next.
Signed-off-by: Daniel Kahn Gillmor
---
m
.
Signed-off-by: Daniel Kahn Gillmor
---
lib/index.cc | 8
mime-node.c | 3 +--
util/crypto.c | 6 +++---
util/crypto.h | 2 +-
4 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/lib/index.cc b/lib/index.cc
index f029b334..da9a3abe 100644
--- a/lib/index.cc
+++ b/lib/index.cc
We don't handle them correctly yet, but we can at least mark them as
being encrypted.
Signed-off-by: Daniel Kahn Gillmor
---
lib/index.cc | 4
test/T355-smime.sh | 1 -
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/index.cc b/lib/index.cc
index bbf13dc5..f029b334
-onepart-signed@protected-headers.example.
Signed-off-by: Daniel Kahn Gillmor
---
notmuch-show.c | 11 ++-
test/T355-smime.sh | 2 --
test/T356-protected-headers.sh | 1 -
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/notmuch-show.c b/notmuch
Signed-off-by: Daniel Kahn Gillmor
---
lib/index.cc | 5 +++--
test/T355-smime.sh | 2 --
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/index.cc b/lib/index.cc
index da9a3abe..826aa341 100644
--- a/lib/index.cc
+++ b/lib/index.cc
@@ -656,8 +656,9 @@ _index_pkcs7_part
This series applies after the "Add tests for S/MIME PKCS#7 messages"
series, which was introduced in
id:20200428185723.660184-1-...@fifthhorseman.net
With this series applied, notmuch handles standard PKCS#7 S/MIME
messages (using GnuPG's gpgsm as a backend, as mediated by GMime's use
of GPGME)
w.
Signed-off-by: Daniel Kahn Gillmor
---
lib/index.cc | 57 ++
test/T355-smime.sh | 2 --
2 files changed, 57 insertions(+), 2 deletions(-)
diff --git a/lib/index.cc b/lib/index.cc
index 158ba5cf..bbf13dc5 100644
--- a/lib/index.cc
+++ b/li
When composing a reply, no one wants to see this line in the proposed
message:
Non-text part: application/pkcs7-mime
So we hide it, the same way we hide PGP/MIME cruft.
Signed-off-by: Daniel Kahn Gillmor
---
notmuch-reply.c| 5 +++--
test/T355-smime.sh | 1 -
2 files changed, 3
1 - 100 of 1501 matches
Mail list logo
