fix bash autoconfiguration

2019-01-16 Thread David Bremner
Testing by people running with /bin/sh = bash welcome. The bug shows up as a shebang of /bin/sh in /usr/bin/notmuch-emacs-mua ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 2/2] Debian: use new variable to force bash location

2019-01-16 Thread David Bremner
This should no longer be needed on the official debian autobuilders, but it might help others with merged /usr build environments. --- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index c8ecb1ac..d056edb6 100755 --- a/debian/rules

[PATCH 1/2] configure: don't use special variable BASH

2019-01-16 Thread David Bremner
bash, in it's wisdom, sets that variable when invoked as /bin/sh, but then doesn't act as bash, at least not to the degree we need to run scripts. --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index b2200be0..ea22587b 100755 ---

Re: [PATCH v3 1/4] emacs: Asynchronous retrieval of GPG keys

2019-01-14 Thread David Bremner
David Edmondson writes: > Rather than blocking emacs while gpg does its' thing, by default run > key retrieval asynchronously, possibly updating the display of the > message on successful completion. > --- > emacs/notmuch-crypto.el | 85 +++-- > 1 file

Re: Pointer ownership

2018-12-21 Thread David Bremner
Dirk Van Haerenborgh writes: > Thanks. > > For the most part, that's what I ended up with, but the thread 'stealing' a > message will be quite hard to implement in Rust, I guess. > When using notmuch_query_search_messages, I was assuming the resulting > individual messages to be owned by the

Re: [PATCH v1 1/3] notmuch: Include the format parameter of text/plain parts

2018-12-21 Thread David Bremner
David Edmondson writes: > During formatted output, if a content type of a text/plain part > has a "format" paramter, include it in the output. > --- > notmuch-show.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/notmuch-show.c b/notmuch-show.c > index

Re: [PATCH] doc: make man pages depend on emacs docstrings

2018-12-21 Thread David Bremner
David Bremner writes: > This is nonsensical on the face of it, but is needed (for now) because > the notmuch-emacs page is unconditionally included in index.rst. pushed to master. d ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH] doc: make man pages depend on emacs docstrings

2018-12-20 Thread David Bremner
This is nonsensical on the face of it, but is needed (for now) because the notmuch-emacs page is unconditionally included in index.rst. --- doc/Makefile.local | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/Makefile.local b/doc/Makefile.local index eec9c228..f53b3702

Re: Pointer ownership

2018-12-20 Thread David Bremner
Dirk Van Haerenborgh writes: > For instance, when iterating messages from a thread: Can one still use a > notmuch_message_t* when the thread is destroyed? > Are the individual > messages 'owned' by the thread, or only by the query? Same question for > 'replies'. > > Could someone please shed

Re: [emacs] message list view

2018-12-12 Thread David Bremner
Mark Walters writes: > I haven't tried Bremner's suggestion of just not passing > entire-thread; it would give a slightly odd ordering of the messages > (all matching messages by thread, and in thread order) rather than > just date order. > I hadn't realized that --no-entire-thread still

Re: [emacs] message list view

2018-12-11 Thread David Bremner
David Edmondson writes: > On Tuesday, 2018-12-11 at 11:20:55 -04, David Bremner wrote: > >> Discussion on #notmuch the other day led me to wonder how useful a >> "message list" view would be. Essentially this would display a single >> line summary for in

[emacs] message list view

2018-12-11 Thread David Bremner
Discussion on #notmuch the other day led me to wonder how useful a "message list" view would be. Essentially this would display a single line summary for individual messages matching a query and allow e.g. tagging operations or "opening" the message to get a more complete view. I'm not sure if

Re: [PATCH 01/11] emacs: initial version of rstdoc.el

2018-12-09 Thread David Bremner
David Bremner writes: > David Bremner writes: > >> This small library is intended to support batch extraction of Emacs >> Lisp docstrings from source files. Clients will need to include (or >> replace) rstdoc.rsti. > > Heads up: > > I've marked this seri

Re: [PATCH 01/11] emacs: initial version of rstdoc.el

2018-12-08 Thread David Bremner
David Bremner writes: > This small library is intended to support batch extraction of Emacs > Lisp docstrings from source files. Clients will need to include (or > replace) rstdoc.rsti. Heads up: I've marked this series as ready to merge. Any objections should come

Re: [PATCH v1 1/1] reply: Include sender as recipient if they were the original recipient

2018-12-07 Thread David Bremner
David Edmondson writes: > When generating a reply message, if the user was the originator and > only recipient of the original message, include the user as a > recipient of the reply. pushed to master d ___ notmuch mailing list

Re: [PATCH] emacs: filter tag completions by current query

2018-12-06 Thread David Bremner
William Casarin writes: > When filtering by tags in notmuch-search-filter-by-tag, only return tags > related to the current query. > > Before, it was returning all tags. There's no reason to refine the > current query with tags that don't exist in the current result set. > > Signed-off-by:

Re: duplicates on notmuch search not working

2018-12-04 Thread David Bremner
Jeff Templon writes: > From the command line: > > $ notmuch search --output=files > id:pine.lnx.4.40.0112181809230.6149-100...@lxplus047.cern.ch > /Users/templon/Maildir/Zar/VMMail/wp2/cur/1528204696.11.mbox:2,S > /Users/templon/Maildir/Zar/VMdb/cur/1528291801.80.mbox:2,S >

Re: Notmuch tags when OfflineIMAP creates a new folder with the same messages

2018-11-27 Thread David Bremner
"Jorge" writes: > Hi. I work at Dataprev (a Brazilian state-owned federal IT company), > and here we use an email implementation called Expresso 3.0. I access > it via OfflineIMAP 7.2.1 on Debian buster. Recently I have gained > access to a shared folder hierarchy called "demandas.dica" (with

Re: [PATCH 2/2] cli: notmuch show support for --include-html with --format=text

2018-11-24 Thread David Bremner
Tomi Ollila writes: > On Wed, Oct 31 2018, ma...@kakoune.org wrote: > >> From: Maxime Coste > > To me these changes looks simple and trivial enough to be merged > (if these works, but code LGTM) > pushed to master d ___ notmuch mailing list

Re: [FEATURE] Purge ignored messages from index

2018-11-23 Thread David Bremner
Markus Weimar writes: > On Thu, 2018-11-22 16:49:56 -0400, David Bremner wrote: >> Notmuch new works very hard to not visit files that haven't >> changed. Changing this would have a big negative performance impact, afaik. > > I see. I thought it might be possible to purg

Re: [FEATURE] Purge ignored messages from index

2018-11-22 Thread David Bremner
Markus Weimar writes: > Thanks for your reply! I only installed notmuch today, so please take this > into account when considering my thoughts. > > On Thu, 2018-11-22 13:33:06 -0400, David Bremner wrote: >> My first instinct would be to leave new as is, but change reindex t

Re: [FEATURE] Purge ignored messages from index

2018-11-22 Thread David Bremner
Jeremy Nickurak writes: > Don't they need to be in the index in order to match the ignore condition, > which then allows them to be excluded from usual activities? new.ignore is not about searching. It is about indexing. A similar, but different feature for searching is search.exclude_tags d

Re: [FEATURE] Purge ignored messages from index

2018-11-22 Thread David Bremner
Markus Weimar writes: > Indexed but subsequently ignored messages remain indexed. I suggest to purge > them from the index as if the files were removed. > > Example: > > * Create index including spam directory > * Add spam directory to ignore list > * Neither ´new´ nor ´reindex 'folder:spam'´

Re: [PATCH 2/2] cli: notmuch show support for --include-html with --format=text

2018-11-19 Thread David Bremner
ma...@kakoune.org writes: > Hello > > Any progress on merging those patches ? > > Is there anything I should do ? > I think it's waiting for review on our side now. Unfortunately I'm personally very busy with $DAYJOB atm. d ___ notmuch mailing list

Re: segfault using python bindings

2018-11-18 Thread David Bremner
Dirk Van Haerenborgh writes: > This is not a typo. I deliberately duplicated that bit. > The second time it runs that loop, it will always segfault, unless you > omit the first 'notmuch_message_destroy' call. > > Given your example, I suspect the Python3 bindings to do something very > similar.

Draft of indexing user defined headers

2018-11-17 Thread David Bremner
This is an early draft, it definitely needs polishing. Feedback on the general design welcome. Notice that users will need to reindex manually after changing the set of indexed headers. ___ notmuch mailing list notmuch@notmuchmail.org

[RFC patch 3/5] lib: setup user headers in query parser

2018-11-17 Thread David Bremner
These tests will need to be updated if the Xapian query print/debug format changes. --- lib/database.cc | 40 test/T720-user-header.sh | 21 + 2 files changed, 61 insertions(+) diff --git a/lib/database.cc b/lib/database.cc

[RFC patch 4/5] WIP: store user prefixes

2018-11-17 Thread David Bremner
Maybe this should be unified into one prefix table? --- lib/database-private.h | 8 lib/database.cc| 32 +++- lib/notmuch-private.h | 4 lib/thread.cc | 2 -- 4 files changed, 31 insertions(+), 15 deletions(-) diff --git

[RFC patch 5/5] WIP: index user headers

2018-11-17 Thread David Bremner
--- lib/database.cc | 37 + lib/index.cc | 34 ++ lib/message.cc | 5 - lib/notmuch-private.h| 4 test/T720-user-header.sh | 17 + 5 files changed, 88 insertions(+), 9

[RFC patch 1/5] cli/config: refactor _stored_in_db

2018-11-17 Thread David Bremner
This will make it easier to add other prefixes that are stored in the database, compared to special casing each one as "query." was. --- notmuch-config.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/notmuch-config.c b/notmuch-config.c index

[RFC patch 2/5] cli/config: support user header index config

2018-11-17 Thread David Bremner
We don't do anything with this configuration information information yet, but nonetheless add a couple of regression tests to make sure we don't break standard functionality when we do use the configuration information. --- notmuch-config.c | 1 + test/T720-user-header.sh | 38

Re: segfault using python bindings

2018-11-16 Thread David Bremner
Floris Bruynooghe writes: >> As I mentioned last time this was discussed, the python bindings are >> currently more or less a core part of notmuch as both the test >> suite and developement need them. > > Sure, I think pypi publishing is orthogonal to this however. Either or > both versions of

Re: segfault using python bindings

2018-11-16 Thread David Bremner
Brian May writes: > Floris Bruynooghe writes: > >> I've since wondered if just getting them standalone on pypi is perhaps a >> useful service in the mean time as it's relatively little effort. And >> if there eventually is a desire again to get them merged in some way >> that could still be

Re: segfault using python bindings

2018-11-16 Thread David Bremner
Floris Bruynooghe writes: > > These are at https://github.com/flub/notmuch/tree/cffi/bindings/python-cffi > > I'm not really convinced of the way forward last time it was discussed > on how to get them merged into notmuch itself so have failed to put in > the not insignificant effort. > > I've

Re: notcoal, filters not made from (char)coal / initial tagging system

2018-11-12 Thread David Bremner
Kim ALLAMANDOLA writes: > The only part I do not like too much is the choice of json instead of > something, *for me*, less ugly to write/read, less error-prone and more > flexible like simple plain guile (GNU embeddable, lightweight scheme > I don't know the context of this statement, but

Re: finding file by size

2018-11-12 Thread David Bremner
Mark Janes writes: > > Thanks for this, I will use your command for my current needs. Even if > notmuch supported a more elegant feature, I would still need to somehow > locate and remove the messages from my maildir. I can see how the > separation between the xapian database and the maildir

Re: segfault using python bindings

2018-11-11 Thread David Bremner
David Čepelík writes: > Hello Notmuch devs, > > I'm facing an issue trying to use the Python bindings. This trivial > piece of code segfaults: > > import notmuch I don't remember the details [1], but there are known conflicts between recent versions of python3 and the way the notmuch python

Re: [PATCH] cli: Support --include-html and --body=false for --format=text

2018-10-28 Thread David Bremner
ma...@kakoune.org writes: > On 2018-10-26 05:55, Jani Nikula wrote: >> It's debatable whether parsing the --format=text output correctly is >> convenient or not. Particularly for notmuch show I think the text >> format >> output is basically legacy, and I don't think we're all that fond of >>

Re: Mail to self

2018-10-27 Thread David Bremner
Leo Gaspard writes: > Hello, > > I'm looking for a way to have notmuch consider, when it finds both an > unread and a read mail with the same Message-Id (eg. sending a mail to > self from a phone), that the mail is unread (because I'd rather have too > many mails unread than miss important mail,

Re: [PATCH 02/11] emacs: require notmuch-lib from notmuch-wash.el

2018-10-21 Thread David Bremner
David Bremner writes: > This is needed so that notmuch-wash.el is loadable by itself; in > particular for the docstring processing. pushed patches 2 and 3 d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/li

Re: [PATCH] Avoid spurious gcc warning in debugger.c

2018-10-21 Thread David Bremner
Daniel Kahn Gillmor writes: > Without this patch, gcc 8.2.0-7 complains: > > debugger.c: In function ‘debugger_is_active’: > debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter > aliases with argument 1 [-Wrestrict] > if (readlink (buf, buf, sizeof (buf)) != -1 &&

Re: [PATCH] index: explicitly follow GObject conventions

2018-10-21 Thread David Bremner
Daniel Kahn Gillmor writes: > Use explicit labels for GTypeInfo member initializers, rather than > relying on comments and ordering. This is both easier to read, and > harder to screw up. This also makes it clear that we're mis-casting > GObject class initializers for gcc. > > Without this

Re: Proposed New sort API

2018-10-21 Thread David Bremner
William Casarin writes: > David Bremner writes: > >> William Casarin writes: >> >>> Another thought I had that I wanted to throw out there for >>> consideration. It would be nice to be able to sort by "popular" threads, >>> aka

Re: [PATCH 1/2] WIP: groundwork for new sorting API

2018-10-20 Thread David Bremner
William Casarin writes: > > > I'm adding a few new keys (from, subject, etc). I don't want to > duplicate them in the old notmuch_sort_t enum, I assume to move to the > new API there should be something like this as well? It's been a while since I was thinking about this, but I suspect my

Re: Proposed New sort API

2018-10-20 Thread David Bremner
William Casarin writes: > David Bremner writes: > >> I started looking at William's sorting patches [1], but the >> proliferation of sorting options bugged me a bit. I decided to sketch >> out a new more flexible API. >> >> In the new API, there is is a sor

Re: another question : date-limit address completion (or somesuch)?

2018-10-18 Thread David Bremner
Jeff Templon writes: > Hi, > > Thanks btw for all the answers to the questions. > > I use the tab completion on the To, CC etc fields and like it. However, > I have email going back to the nineties, and notmuch TAB completion > considers all those addresses to be candidates. It means in many

Re: tell me how to do this (mass tagging of messages)

2018-10-17 Thread David Bremner
David Edmondson writes: > On Wednesday, 2018-10-17 at 13:39:10 +02, Jeff Templon wrote: >> Right. Poor example. I guess the better question is, in a screen full >> of threads matching a particular query, how do I do a mass action on >> only those messages that match the query and not on the

Re: Tag duplicate messages with notmuch insert

2018-10-15 Thread David Bremner
David Bremner writes: > Thomas Schneider writes: > >> From notmuch-insert(1): >> >>> If the new message is a duplicate of an existing message in the >>> database (it has same Message-ID), it will be added to the maildir >>> folder and notmu

Re: Tag duplicate messages with notmuch insert

2018-10-15 Thread David Bremner
Thomas Schneider writes: > From notmuch-insert(1): > >> If the new message is a duplicate of an existing message in the >> database (it has same Message-ID), it will be added to the maildir >> folder and notmuch database, but the tags will not be changed. > > It might however be desired to apply

notmuch release 0.28 now availableSubject:

2018-10-12 Thread David Bremner
https://notmuchmail.org/releases/notmuch-0.28.tar.gz.sha256.asc (signed by David Bremner) What's new in notmuch 0.28 = General --- Improve threading The threading algorithm has been updated to consider all references, not just the heuristically chosen parent (e.g

Re: [PATCH] NEWS: NEWS for 0.28

2018-10-12 Thread David Bremner
David Edmondson writes: > On Friday, 2018-10-12 at 08:39:11 -03, David Bremner wrote: > >> + Add a real sentinal process to clean up stderr buffer. > > “sentinel”. > Thanks, fixed in git. Also mislabeled -> mislabelled

[PATCH] NEWS: NEWS for 0.28

2018-10-12 Thread David Bremner
This is based on my subjective assessment of what is user/packager facing and important from the output of 'git shortlog' --- I squashed all the news patches together since there were no other contributions. I will release with these notes pretty soon, so please send any fixes ASAP. NEWS | 59

Re: tell me how to do this right (mail sent to lists)

2018-10-10 Thread David Bremner
Jeff Templon writes: > > if the first message file encountered for that messageID is the one in > Sent, it does not have a ListID field and hence does not get the list > tags applied. The second message file (the one sent via the mailing > list) DOES have a ListID field, but notmuch "already

Re: tell me how to do this right (mail sent to lists)

2018-10-10 Thread David Bremner
Jeff Templon writes: > Carl Worth writes: > >> I guess the question I have is: What has given you the idea that afew is >> tagging one message but not the other? > > Well, this: > > medina:~> notmuch search --output=files id:m25zyb89im@simeto.nikhef.nl >

Re: [PATCH RFC] index: add body: search query term

2018-10-10 Thread David Bremner
William Casarin writes: > > lib/database.cc | 3 +++ > lib/index.cc| 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/database.cc b/lib/database.cc > index 9cf8062c..0b085b21 100644 > --- a/lib/database.cc > +++ b/lib/database.cc > @@ -297,6 +297,9 @@ prefix_t

Re: [BUG] Can't search for some square brackets in From:

2018-10-08 Thread David Bremner
Justin Humm writes: > Hello, > > I struggle with searching the From field of mails, that have square brackets > in it. The first instance of that problem I found is > > From: =?UTF-8?Q?Shedhalle_T=c3=bcbingen_[Festival]?= > > In this case, on 0.27 I'm unable to find any mail with > >

Re: [PATCH v1 2/2] emacs: Update integration with third party packages.

2018-10-08 Thread David Bremner
David Edmondson writes: > `mm-inline-text-html-with-images' was removed from mm-decode.el in > 2016 and replaced with `mm-html-inhibit-images'. > > `gnus-select-frame-set-input-focus' was removed from gnus-util.el in > 2016 and existed only for XEmacs compatibility. pushed to master d

Re: [PATCH] test: git should ignore message-id-parse

2018-10-08 Thread David Bremner
Daniel Kahn Gillmor writes: > b31e44c678bf3bfe81bcc5f159e627551f12700f introduced message-id-parse > as a new binary created by the test suite. It shows up as sometihng > additional to git, but git ought to know to ignore it. pushed to master, with one spelling fix. d

Re: [PATCH] Avoid spurious gcc warning in debugger.c

2018-10-08 Thread David Bremner
Daniel Kahn Gillmor writes: > Without this patch, gcc 8.2.0-7 complains: > > debugger.c: In function ‘debugger_is_active’: > debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter > aliases with argument 1 [-Wrestrict] > if (readlink (buf, buf, sizeof (buf)) != -1 &&

Re: [PATCH] emacs: filter tag completions by current query

2018-10-08 Thread David Bremner
David Edmondson writes: > On Monday, 2018-10-08 at 15:14:50 +02, Jeff Templon wrote: > >> Hi, >> >> David Edmondson writes: >> >>> On Monday, 2018-10-08 at 14:46:25 +02, Jeff Templon wrote: >>> hi guys, a question from a newbie - where are all these things documented? The

[PATCH 4/4] NEWS: note zsh completion rewrite

2018-10-08 Thread David Bremner
--- NEWS | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS b/NEWS index ea86c7a7..76fdf2ce 100644 --- a/NEWS +++ b/NEWS @@ -32,6 +32,11 @@ Call `notmuch-mua-send-hook` hooks when sending a message This hook was documented, but not functional for a very long time. +Completion

[PATCH 1/4] NEWS: emacs news for 0.28

2018-10-08 Thread David Bremner
This is all dme's work. --- NEWS | 9 + 1 file changed, 9 insertions(+) diff --git a/NEWS b/NEWS index fbfea956..40e9defe 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,15 @@ in the database). The heuristic for choosing a parent message has also been updated to again consider the

Remaining NEWS for 0.28

2018-10-08 Thread David Bremner
Please speak up soon if you'd prefer to describe your contribution differently. [PATCH 1/4] NEWS: emacs news for 0.28 [PATCH 2/4] NEWS: note Sebastian's windows-1252 fix [PATCH 3/4] NEWS: note database path change [PATCH 4/4] NEWS: note zsh completion rewrite

[PATCH 2/4] NEWS: note Sebastian's windows-1252 fix

2018-10-08 Thread David Bremner
--- NEWS | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/NEWS b/NEWS index 40e9defe..9c25a6ca 100644 --- a/NEWS +++ b/NEWS @@ -4,11 +4,15 @@ Notmuch 0.28 (UNRELEASED) General --- -The threading algorithm has been updated to consider all references, -not

[PATCH 3/4] NEWS: note database path change

2018-10-08 Thread David Bremner
--- NEWS | 9 + 1 file changed, 9 insertions(+) diff --git a/NEWS b/NEWS index 9c25a6ca..ea86c7a7 100644 --- a/NEWS +++ b/NEWS @@ -14,6 +14,15 @@ Improve threading Handle mislabeled Windows-1252 parts. +Command Line Interface +-- + +Support relative database

[PATCH] NEWS: my changes for 0.28

2018-10-05 Thread David Bremner
I think this is all of the user (or package maintainer) visible stuff. --- NEWS | 23 +++ 1 file changed, 23 insertions(+) diff --git a/NEWS b/NEWS index d6875dcc..fbfea956 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,29 @@ Notmuch 0.28 (UNRELEASED) =

Re: plans for 0.28

2018-10-03 Thread David Bremner
David Bremner writes: > Hi Gang; > > I'd like to feature freeze 0.28 sometime in the next two weeks. I'd > mainly like to include > - the threading fixes I (re)-posted recently > - dkg's protected headers stuff > > Suggestions for other things to include (probably n

Re: [PATCH 1/2] completion: more complete completion for zsh.

2018-10-02 Thread David Bremner
Vincent Breitmoser writes: > This adds completion files for zsh that cover most of notmuch's cli. > > The files in completion/zsh are formatted so that they can be found by > zsh's completion system if put $fpath. They are also registered to the > notmuch-* pattern, so they can be called

Re: [PATCH v2 3/4] emacs: Add notmuch-crypto-gpg-program and use it

2018-10-01 Thread David Bremner
David Edmondson writes: > On Sunday, 2018-09-30 at 08:34:29 -03, David Bremner wrote: > >> David Edmondson writes: >> >>> Allow the user to specify the gpg program to use when retriving keys, >>> etc., defaulting to the value of `epg-gpg-program'. &

Re: [PATCH v2 1/4] emacs: Asynchronous retrieval of GPG keys

2018-10-01 Thread David Bremner
David Edmondson writes: > The condition is conservative because the refresh redraws the whole > buffer. If it just updated the button directly (which I've been fiddling > with, but don't have working well yet) then we might relax the > condition. > > Where would we document the behaviour? In

Re: xapian parser bug?

2018-09-30 Thread David Bremner
Olly Betts writes: > On Sun, Sep 30, 2018 at 09:05:25AM -0300, David Bremner wrote: >> if (str.find (' ') != std::string::npos) >> query_str = '"' + str + '"'; >> else >> query_str = str; >> >&

Re: xapian parser bug?

2018-09-30 Thread David Bremner
David Bremner writes: > Olly Betts writes: > >> >> FWIW, I also couldn't reproduce this (I tried with quest and 1.4.7): >> >> $ quest -psubject:S -fdefault,boolean_any_case 'subject:"and"' >> Parsed Query: Query(Sand@1) >> > > Ah,

[PATCH 2/2] lib: use phrase search for anything not ending in '*'

2018-09-30 Thread David Bremner
Anything that does not look like a wildcard should be safe to quote. This should fix the problem searching for xapian keywords. --- lib/regexp-fields.cc | 2 +- test/T650-regexp-query.sh | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/regexp-fields.cc

[PATCH 1/2] test: add two known broken tests searching for xapian keywords

2018-09-30 Thread David Bremner
Thanks to plujon for pointing out this problem on IRC. The underlying issue is that the quotes are stripped before the field processors get the query string, and the heuristic for putting them back is not quite right. --- test/T650-regexp-query.sh | 13 + 1 file changed, 13

Re: xapian parser bug?

2018-09-30 Thread David Bremner
Olly Betts writes: > > FWIW, I also couldn't reproduce this (I tried with quest and 1.4.7): > > $ quest -psubject:S -fdefault,boolean_any_case 'subject:"and"' > Parsed Query: Query(Sand@1) > Ah, OK, it must have something to do with the way that notmuch is using field processors. And I see now

Re: [PATCH v2 2/4] emacs: Minor refactoring of crypto code

2018-09-30 Thread David Bremner
David Edmondson writes: > - (setq help-msg (concat "Click to retrieve key ID " keyid " from > keyserver and redisplay." > + (setq label (concat "Unknown key ID " keyid " or unsupported > algorithm") > + button-action 'notmuch-crypto-sigstatus-error-callback > +

Re: [PATCH v2 3/4] emacs: Add notmuch-crypto-gpg-program and use it

2018-09-30 Thread David Bremner
David Edmondson writes: > Allow the user to specify the gpg program to use when retriving keys, > etc., defaulting to the value of `epg-gpg-program'. typo in retriving. More interestingly, would you mind documenting the use case in the commit message? I'm unclear on a couple points - why one

Re: [PATCH v2 1/4] emacs: Asynchronous retrieval of GPG keys

2018-09-29 Thread David Bremner
David Edmondson writes: > +(defun notmuch-crypto--async-key-sentinel (process event) > + "When the user asks for a GPG key to be retrieved > +asynchronously, handle completion of that task." > + (let ((status (process-status process)) > + (exit-status (process-exit-status process)) > +

Re: [PATCH v1 2/2] emacs: Call `notmuch-mua-send-hook' hooks when sending a message

2018-09-29 Thread David Bremner
David Bremner writes: > David Bremner writes: > >> >> This looks plausible to me, and of course the test passes. I did wonder >> if this means that people actually using notmuch-user-agent would run >> the hook twice now? > > After a certain amount of re-re

xapian parser bug?

2018-09-29 Thread David Bremner
Today we noticed that keywords can't be searched as prefixed terms. Or that's what it looks like anyway. I tested and, or, and not. ╰─% NOTMUCH_DEBUG_QUERY=y notmuch search 'subject:"and"' Query string is: subject:"and" notmuch search: A Xapian exception occurred A Xapian exception occurred

Re: [PATCH v1 2/2] emacs: Call `notmuch-mua-send-hook' hooks when sending a message

2018-09-28 Thread David Bremner
David Bremner writes: > > This looks plausible to me, and of course the test passes. I did wonder > if this means that people actually using notmuch-user-agent would run > the hook twice now? After a certain amount of re-reading the docstring of define-mail-user-agent, an

Re: unused/total message counts in hello screen?

2018-09-28 Thread David Bremner
Jeff Templon writes: > Hi > > My first post here. It seems i can do what the subject line asks but I > am not quite there in terms of seeing it (not an elisp guy). > [snip] > where the first number (before the slash) is the number of unread > messages under that tag. An alternative would be if

Re: [PATCH v1 2/2] emacs: Call `notmuch-mua-send-hook' hooks when sending a message

2018-09-26 Thread David Bremner
$David Edmondson writes: > Previously any hook functions attached to `notmuch-mua-send-hook' were > ignored. > --- > emacs/notmuch-mua.el | 1 + > test/T310-emacs.sh | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el > index

Re: [PATCH v1 1/2] test: Check that `notmuch-mua-send-hook' is called on sending a message

2018-09-26 Thread David Bremner
David Edmondson writes: > --- > test/T310-emacs.sh | 26 ++ > 1 file changed, 26 insertions(+) I get kind of odd output from this failing test PASS Term escaping BROKEN Sending a message calls the send message hooks --- T310-emacs.70.EXPECTED

Re: [PATCH v2 1/2] emacs: Optionally check for missing attachments in outgoing messages

2018-09-23 Thread David Bremner
David Edmondson writes: > Query the user if the message text indicates that an attachment is > expected but no MML referencing an attachment is found. > > This is not enabled by default - see the documentation for > `notmuch-mua-attachment-check'. > --- > emacs/notmuch-mua.el | 37

[PATCH] try regexp searching for completion

2018-09-20 Thread David Bremner
--- Can you try this alternative to caching, and see if the performance is acceptable for you? I think it should be faster than your original implementation (and also work better with multiple word f...@beep.boop prefixes). For me this is performs much nicer than the "read all the addresses"

Re: [PATCH] python: fix unchecked None access in get_property

2018-09-19 Thread David Bremner
Vincent Breitmoser writes: > --- > bindings/python/notmuch/message.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) pushed to master, thanks for the fix, d ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH 4/6] contrib/notmuch-mutt: add install target

2018-09-18 Thread David Bremner
Tomi Ollila writes: > On Sun, Sep 16 2018, David Bremner wrote: > >> The main goal here is to be able to install the notmuch-mutt script >> with an absolute shebang. I have tried to make the notmuch-mut > > Series looks pretty good to me... mut mut should probably be m

Re: [PATCH 1/2] completion: more complete completion for zsh.

2018-09-17 Thread David Bremner
Vincent Breitmoser writes: > Ah, that's a bit annoying. > > What we could do is just stupidly load all addresses and work from there? On > my > machine, `notmuch address --deduplicate=address --output=address '*'` takes > 0.25 > seconds for a result set of 5500 addresses. > Here it's 1.9s for

Re: [PATCH 1/2] completion: more complete completion for zsh.

2018-09-17 Thread David Bremner
Vincent Breitmoser writes: > --- /dev/null > +++ b/completion/zsh/_email-notmuch > @@ -0,0 +1,9 @@ > +#autoload > + > +local expl > +local -a notmuch_addr > + > +notmuch_addr=( ${(f)"$(notmuch address --deduplicate=address > --output=address -- $PREFIX'*')"} ) > + > +_description notmuch-addr

[PATCH 5/6] debian: bump compat level to 11

2018-09-16 Thread David Bremner
The immediate motivation is to have dh_installman look in debian/tmp --- debian/compat | 3 ++- debian/control | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/debian/compat b/debian/compat index f599e28b..9f1d48ef 100644 --- a/debian/compat +++ b/debian/compat @@ -1 +1,2

[PATCH 6/6] debian: update notmuch-mutt packaging to use install target

2018-09-16 Thread David Bremner
--- debian/notmuch-mutt.install | 4 ++-- debian/notmuch-mutt.manpages | 2 +- debian/notmuch.install | 4 ++-- debian/notmuch.manpages | 18 ++ debian/rules | 1 + 5 files changed, 24 insertions(+), 5 deletions(-) create mode 100644

[PATCH 3/6] configure: absolute path of perl

2018-09-16 Thread David Bremner
This can be used to set shebang lines during install. --- configure | 19 +++ 1 file changed, 19 insertions(+) diff --git a/configure b/configure index 20961763..b2200be0 100755 --- a/configure +++ b/configure @@ -54,6 +54,7 @@ fi # Set several defaults (optionally specified by

[PATCH 4/6] contrib/notmuch-mutt: add install target

2018-09-16 Thread David Bremner
The main goal here is to be able to install the notmuch-mutt script with an absolute shebang. I have tried to make the notmuch-mut Makefile use configure information from notmuch if available, but make suitable guesses if not. --- contrib/notmuch-mutt/Makefile | 13 + 1 file changed,

[PATCH 2/6] build: install notmuch-emacs-mua with absolute shebang

2018-09-16 Thread David Bremner
Follow distro-centric rules to reduce the chance of surprising behaviour due to PATH changes --- emacs/Makefile.local | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/emacs/Makefile.local b/emacs/Makefile.local index 1b3ef584..5e4ae1bd 100644 --- a/emacs/Makefile.local +++

v2: Install notmuch-emacs-mua and notmuch-mutt with absolute shebangs

2018-09-16 Thread David Bremner
This obsoletes the WIP series at id:20180909154003.8801-1-da...@tethera.net There's unfortunately a bit more changes necessary to take advantage of the configure calculated information than I anticipated, but nothing very complicated. ___

[PATCH 1/6] configure: absolute path of bash

2018-09-16 Thread David Bremner
This can be used to set shebang lines during install. --- configure | 19 +++ 1 file changed, 19 insertions(+) diff --git a/configure b/configure index ab7e1610..20961763 100755 --- a/configure +++ b/configure @@ -53,6 +53,7 @@ fi # Set several defaults (optionally specified

Re: Updated zsh completion patches

2018-09-16 Thread David Bremner
Vincent Breitmoser writes: > Hey David, > >> I do have one problem with the completion of tags. It seems the >> treatment of tags with :: in them is not consistent. > > Thanks for the hint. I didn't expect :: to be special so I didn't test that > case. I'll check it out later today or possibly

Re: [PATCH] Fix Makefile.local for install notmuch zsh completions

2018-09-16 Thread David Bremner
Chris Coutinho writes: > Thanks for the patch Vincent! > > The Makefile.local should also be updated to successfully install > notmuch using this patch. Hah, our patches passed in the mail! ___ notmuch mailing list notmuch@notmuchmail.org

Updated zsh completion patches

2018-09-16 Thread David Bremner
Hi Vincent; Thanks for this patch, it's definitely a big improvement. I had to make some small adjustments to the install recipes to accomodate the renaming / removal of notmuch-completion.zsh. A revised version of your patch with that squashed in follows. I also added a patch to install the

  1   2   3   4   5   6   7   8   9   10   >