[ANN] notmuch-labeler: Improves notmuch way of displaying labels

2012-10-24 Thread Dmitry Kurochkin
Hi Damien. Damien Cassou writes: > Hi, > > On Fri, Oct 12, 2012 at 7:07 PM, David Bremner wrote: >> It seeems like a nice UI enchancement, and people would not have to use >> it if they didn't like it, so in principle I guess we should work >> towards integrating it into notmuch upstream. > >

Re: [ANN] notmuch-labeler: Improves notmuch way of displaying labels

2012-10-24 Thread Dmitry Kurochkin
Hi Damien. Damien Cassou damien.cas...@gmail.com writes: Hi, On Fri, Oct 12, 2012 at 7:07 PM, David Bremner da...@tethera.net wrote: It seeems like a nice UI enchancement, and people would not have to use it if they didn't like it, so in principle I guess we should work towards integrating

[PATCH 2/3] test: Add a test for HTML email with inline images

2012-10-03 Thread Dmitry Kurochkin
Austin Clements writes: > Quoth Dmitry Kurochkin on Oct 03 at 1:35 pm: >> Hi Austin. >> >> Austin Clements writes: >> >> > Currently this test passes in Emacs 23 but fails in Emacs 24 (at least >> > on some Linux distributions). >> >&g

[PATCH 2/3] test: Add a test for HTML email with inline images

2012-10-03 Thread Dmitry Kurochkin
Hi Austin. Austin Clements writes: > Currently this test passes in Emacs 23 but fails in Emacs 24 (at least > on some Linux distributions). The test fails for me on Emacs 23.4.1 (Debian unstable): FAIL Rendering HTML mail with images --- emacs.51.OUTPUT 2012-10-03

Re: [PATCH 2/3] test: Add a test for HTML email with inline images

2012-10-03 Thread Dmitry Kurochkin
Hi Austin. Austin Clements amdra...@mit.edu writes: Currently this test passes in Emacs 23 but fails in Emacs 24 (at least on some Linux distributions). The test fails for me on Emacs 23.4.1 (Debian unstable): FAIL Rendering HTML mail with images --- emacs.51.OUTPUT 2012-10-03

Re: [PATCH 2/3] test: Add a test for HTML email with inline images

2012-10-03 Thread Dmitry Kurochkin
Austin Clements amdra...@mit.edu writes: Quoth Dmitry Kurochkin on Oct 03 at 1:35 pm: Hi Austin. Austin Clements amdra...@mit.edu writes: Currently this test passes in Emacs 23 but fails in Emacs 24 (at least on some Linux distributions). The test fails for me on Emacs 23.4.1

[PATCH] Add notmuch-remove-duplicates.py script to contrib.

2012-09-05 Thread Dmitry Kurochkin
Michal Nazarewicz writes: >>> On Tue, Sep 04 2012, Dmitry Kurochkin wrote: >>>> +class MailComparator: >>>> +"""Checks if mail files are duplicates.""" >>>> +def __init__(self, filename): >>>>

[PATCH] Add notmuch-remove-duplicates.py script to contrib.

2012-09-05 Thread Dmitry Kurochkin
Hi Michal. Michal Nazarewicz writes: > On Tue, Sep 04 2012, Dmitry Kurochkin wrote: >> The script removes duplicate message files. It takes no options. >> >> Files are assumed duplicates if their content is the same except for >> ignored headers. Currently, the only

[PATCH] Add notmuch-remove-duplicates.py script to contrib.

2012-09-04 Thread Dmitry Kurochkin
The script removes duplicate message files. It takes no options. Files are assumed duplicates if their content is the same except for ignored headers. Currently, the only ignored header is Received:. --- contrib/notmuch-remove-duplicates.py | 95 ++ 1 file

[PATCH] cli: notmuch-show with framing newlines between threads in JSON.

2012-06-30 Thread Dmitry Kurochkin
Hi Mark. Mark Walters writes: > Add newlines between complete threads to make asynchronous parsing > of the JSON easier. > --- > > notmuch-pick uses the JSON output of notmuch show but, in many cases, > for many threads. This can take quite a long time when displaying a > large number of

Re: [PATCH] cli: notmuch-show with framing newlines between threads in JSON.

2012-06-30 Thread Dmitry Kurochkin
Hi Mark. Mark Walters markwalters1...@gmail.com writes: Add newlines between complete threads to make asynchronous parsing of the JSON easier. --- notmuch-pick uses the JSON output of notmuch show but, in many cases, for many threads. This can take quite a long time when displaying a

FreeBSD Support Patches

2012-05-26 Thread Dmitry Kurochkin
Mike Kelly writes: > On Fri, May 25, 2012 at 10:15 AM, Dmitry Kurochkin > wrote: >> Why do we need to explicitly declare Emacs dependency for tests? ?There >> should be no need for it. ?We have "implicit" dependencies which are >> declared once (see test_declar

FreeBSD Support Patches

2012-05-25 Thread Dmitry Kurochkin
Hi Mike. Mike Kelly writes: > Hi, > > These patches add some changes necessary for a clean build on FreeBSD, > and for most of the tests to pass. > > Also mixed in are a few patches to disable emacs tests when you don't > have emacs, along with tests that depend upon emacs. I could split those

[PATCH] test: remove "Testing" from test description in emacs-hello and emacs-show

2012-05-25 Thread Dmitry Kurochkin
"Testing" is printed by test/test-lib.sh, so having "Testing" in test description results in duplicate "Testing" in console output. --- test/emacs-hello |2 +- test/emacs-show |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/emacs-hello b/test/emacs-hello index

[PATCH] test: remove Testing from test description in emacs-hello and emacs-show

2012-05-25 Thread Dmitry Kurochkin
Testing is printed by test/test-lib.sh, so having Testing in test description results in duplicate Testing in console output. --- test/emacs-hello |2 +- test/emacs-show |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/emacs-hello b/test/emacs-hello index

Re: FreeBSD Support Patches

2012-05-25 Thread Dmitry Kurochkin
Hi Mike. Mike Kelly pi...@pioto.org writes: Hi, These patches add some changes necessary for a clean build on FreeBSD, and for most of the tests to pass. Also mixed in are a few patches to disable emacs tests when you don't have emacs, along with tests that depend upon emacs. I could

Re: FreeBSD Support Patches

2012-05-25 Thread Dmitry Kurochkin
Mike Kelly pi...@pioto.org writes: On Fri, May 25, 2012 at 10:15 AM, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Why do we need to explicitly declare Emacs dependency for tests?  There should be no need for it.  We have implicit dependencies which are declared once (see

[PATCH 1/2] test: add Emacs notmuch-hello tests for custom tags and queries section.

2012-05-05 Thread Dmitry Kurochkin
The tests use default values from customization widgets to make sure that these customization widgets work (at least on basic level). The custom queries section test is currently broken. --- test/emacs-hello| 15 +++

[PATCH 1/2] test: add Emacs notmuch-hello tests for custom tags and queries section.

2012-05-05 Thread Dmitry Kurochkin
The tests use default values from customization widgets to make sure that these customization widgets work (at least on basic level). The custom queries section test is currently broken. --- test/emacs-hello| 15 +++

[PATCH 2/2] emacs: fix custom queries section customization widget in notmuch-hello

2012-05-05 Thread Dmitry Kurochkin
The customization widget referred to a non-existing function `notmuch-hello-insert-query-list'. The patch changes it to the correct one - `notmuch-hello-insert-searches'. The relevant test is fixed now. --- emacs/notmuch-hello.el |2 +- test/emacs-hello |1 - 2 files changed, 1

[PATCH v2 1/3] Add 'compose' command

2012-04-18 Thread Dmitry Kurochkin
Tomi Ollila writes: > On Wed, Apr 18 2012, Felipe Contreras wrote: > >> On Wed, Apr 18, 2012 at 5:20 PM, Jani Nikula wrote: >>> On Wed, 18 Apr 2012 16:34:30 +0300, Felipe Contreras >> gmail.com> wrote: On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula wrote: > Running "notmuch

[PATCH v2 1/3] Add 'compose' command

2012-04-18 Thread Dmitry Kurochkin
Felipe Contreras writes: > On Wed, Apr 18, 2012 at 4:43 PM, Dmitry Kurochkin > wrote: >> Hi Felipe. >> >> Felipe Contreras writes: >> >>> On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula wrote: >>> >>>> Running "notmuch compo

[PATCH v2 1/3] Add 'compose' command

2012-04-18 Thread Dmitry Kurochkin
Hi Felipe. Felipe Contreras writes: > On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula wrote: > >> Running "notmuch compose" more than once within a second would result in >> identical message ids for the messages, which is not a good idea. That's >> not likely in interactive use, but the notmuch

Re: [PATCH v2 1/3] Add 'compose' command

2012-04-18 Thread Dmitry Kurochkin
Hi Felipe. Felipe Contreras felipe.contre...@gmail.com writes: On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula j...@nikula.org wrote: Running notmuch compose more than once within a second would result in identical message ids for the messages, which is not a good idea. That's not likely in

Re: [PATCH v2 1/3] Add 'compose' command

2012-04-18 Thread Dmitry Kurochkin
Felipe Contreras felipe.contre...@gmail.com writes: On Wed, Apr 18, 2012 at 4:43 PM, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi Felipe. Felipe Contreras felipe.contre...@gmail.com writes: On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula j...@nikula.org wrote: Running notmuch

Re: [PATCH v2 1/3] Add 'compose' command

2012-04-18 Thread Dmitry Kurochkin
Tomi Ollila tomi.oll...@iki.fi writes: On Wed, Apr 18 2012, Felipe Contreras felipe.contre...@gmail.com wrote: On Wed, Apr 18, 2012 at 5:20 PM, Jani Nikula j...@nikula.org wrote: On Wed, 18 Apr 2012 16:34:30 +0300, Felipe Contreras felipe.contre...@gmail.com wrote: On Wed, Apr 18, 2012 at

[RFC PATCH 3/4] emacs: add notmuch hello refresh hook to display message count change

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula writes: > On Tue, 17 Apr 2012 13:13:15 +0400, Dmitry Kurochkin gmail.com> wrote: >> Jani Nikula writes: >> >> > Add a notmuch hello refresh hook to display a message about change in >> > message count in the database since the notmuch-hello buf

[RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula writes: > On Tue, 17 Apr 2012 13:06:13 +0400, Dmitry Kurochkin gmail.com> wrote: >> Can you please give some explanaition why is this needed? Would this >> change break custom hooks that do not expect any arguments? > > For patch 3/4. We don't want to disp

[RFC PATCH 4/4] emacs: add notmuch hello refresh hook to place point in a widget

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula writes: > Add support for putting point to a widget after refresh through a > hook. This approximates the old behaviour. I may be wrong, but this looks to me like a hack that cannot work well. See my first reply in the thread for ideas on how to better implement this functionality.

[RFC PATCH 3/4] emacs: add notmuch hello refresh hook to display message count change

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula writes: > Add a notmuch hello refresh hook to display a message about change in > message count in the database since the notmuch-hello buffer was last > refreshed manually (no-display is nil). I like this idea. But IMO we should avoid another call to notmuch count. Notmuch-hello

[RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-04-17 Thread Dmitry Kurochkin
Can you please give some explanaition why is this needed? Would this change break custom hooks that do not expect any arguments? Regards, Dmitry Jani Nikula writes: > --- > emacs/notmuch-hello.el |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git

[RFC PATCH 1/4] emacs: simplify point placement in notmuch-hello

2012-04-17 Thread Dmitry Kurochkin
Hi Jani. Jani Nikula writes: > notmuch-hello (called also through notmuch-hello-update, bound to '=' > by default) tries to find the widget under or following point before > refresh, and put the point back to the widget afterwards. The code has > gotten a bit complicated, and has at least the

Re: [RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-04-17 Thread Dmitry Kurochkin
Can you please give some explanaition why is this needed? Would this change break custom hooks that do not expect any arguments? Regards, Dmitry Jani Nikula j...@nikula.org writes: --- emacs/notmuch-hello.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [RFC PATCH 3/4] emacs: add notmuch hello refresh hook to display message count change

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula j...@nikula.org writes: Add a notmuch hello refresh hook to display a message about change in message count in the database since the notmuch-hello buffer was last refreshed manually (no-display is nil). I like this idea. But IMO we should avoid another call to notmuch count.

Re: [RFC PATCH 4/4] emacs: add notmuch hello refresh hook to place point in a widget

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula j...@nikula.org writes: Add support for putting point to a widget after refresh through a hook. This approximates the old behaviour. I may be wrong, but this looks to me like a hack that cannot work well. See my first reply in the thread for ideas on how to better implement this

Re: [RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula j...@nikula.org writes: On Tue, 17 Apr 2012 13:06:13 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Can you please give some explanaition why is this needed? Would this change break custom hooks that do not expect any arguments? For patch 3/4. We don't want

Re: [RFC PATCH 3/4] emacs: add notmuch hello refresh hook to display message count change

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula j...@nikula.org writes: On Tue, 17 Apr 2012 13:13:15 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Jani Nikula j...@nikula.org writes: Add a notmuch hello refresh hook to display a message about change in message count in the database since the notmuch-hello

[PATCH] emacs: get rid of trailing spaces in notmuch-hello view

2012-04-09 Thread Dmitry Kurochkin
David Bremner writes: > Dmitry Kurochkin writes: > >> I am going to remove needs-review tag from this one since there seems to >> be no one interested in reviewing it. The patch itself may not be >> trivial, but it is pretty simple and does not make any critical

[PATCH] emacs: get rid of trailing spaces in notmuch-hello view

2012-04-09 Thread Dmitry Kurochkin
Hi all. I am going to remove needs-review tag from this one since there seems to be no one interested in reviewing it. The patch itself may not be trivial, but it is pretty simple and does not make any critical changes. So I believe it is safe to push it. If there are any issues with the patch

Re: [PATCH] emacs: get rid of trailing spaces in notmuch-hello view

2012-04-09 Thread Dmitry Kurochkin
Hi all. I am going to remove needs-review tag from this one since there seems to be no one interested in reviewing it. The patch itself may not be trivial, but it is pretty simple and does not make any critical changes. So I believe it is safe to push it. If there are any issues with the patch

Re: [PATCH] emacs: get rid of trailing spaces in notmuch-hello view

2012-04-09 Thread Dmitry Kurochkin
David Bremner da...@tethera.net writes: Dmitry Kurochkin dmitry.kuroch...@gmail.com writes: I am going to remove needs-review tag from this one since there seems to be no one interested in reviewing it. The patch itself may not be trivial, but it is pretty simple and does not make any

[PATCH 3/6] emacs: modify notmuch-search-tag to not prompt if tags provided as argument

2012-04-02 Thread Dmitry Kurochkin
Jameson Graef Rollins writes: > If the argument is a full string or a list, the function will assume > this is a tag string or list and will not prompt the user. If the > argument is nil or the exact strings "-" or "+" then the user will be > prompted. > > The function doc is updated

[PATCH 2/6] emacs: have tag-completion return all tags for nil input

2012-04-02 Thread Dmitry Kurochkin
Jameson Graef Rollins writes: > Previously the function would fail if the initial input was nil. Now > it will return a list of all tags, which obviously makes much more > sense. > --- > emacs/notmuch.el |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git

Re: [PATCH 2/6] emacs: have tag-completion return all tags for nil input

2012-04-02 Thread Dmitry Kurochkin
Jameson Graef Rollins jroll...@finestructure.net writes: Previously the function would fail if the initial input was nil. Now it will return a list of all tags, which obviously makes much more sense. --- emacs/notmuch.el |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

Re: [PATCH 3/6] emacs: modify notmuch-search-tag to not prompt if tags provided as argument

2012-04-02 Thread Dmitry Kurochkin
Jameson Graef Rollins jroll...@finestructure.net writes: If the argument is a full string or a list, the function will assume this is a tag string or list and will not prompt the user. If the argument is nil or the exact strings - or + then the user will be prompted. The function doc is

[PATCH 1/2] test: add broken test for long names in Emacs notmuch-hello view

2012-03-31 Thread Dmitry Kurochkin
Hi all. It has been a while since these patches were posted. They are pretty simple, just a single line (and a single char) is changed in actual code. So I am going to remove the needs-review tag. Regards, Dmitry

Re: [PATCH 1/2] test: add broken test for long names in Emacs notmuch-hello view

2012-03-30 Thread Dmitry Kurochkin
Hi all. It has been a while since these patches were posted. They are pretty simple, just a single line (and a single char) is changed in actual code. So I am going to remove the needs-review tag. Regards, Dmitry ___ notmuch mailing list

[BUG/PATCH 2/2] emacs: Fix replying from alternate addresses

2012-03-26 Thread Dmitry Kurochkin
Adam Wolfe Gordon writes: > The bug was that notmuch-mua-mail used `mail-header` to check whether > it was passed a "From" header. The implementation of `mail-header` > must try to compare symbols instead of strings when looking for > headers, as it was returning nil when a

[BUG/PATCH 1/2] test: Tests for reply from alternate addresses in emacs

2012-03-26 Thread Dmitry Kurochkin
Adam Wolfe Gordon writes: > Since the recent reply changes were pushed, there has been a bug that > causes emacs to always reply from the primary address, even if the > JSON or default CLI reply output uses an alternate address. > > This adds two tests to the emacs test

Re: [BUG/PATCH 1/2] test: Tests for reply from alternate addresses in emacs

2012-03-26 Thread Dmitry Kurochkin
Adam Wolfe Gordon awg+notm...@xvx.ca writes: Since the recent reply changes were pushed, there has been a bug that causes emacs to always reply from the primary address, even if the JSON or default CLI reply output uses an alternate address. This adds two tests to the emacs test library based

Re: [BUG/PATCH 2/2] emacs: Fix replying from alternate addresses

2012-03-26 Thread Dmitry Kurochkin
Adam Wolfe Gordon awg+notm...@xvx.ca writes: The bug was that notmuch-mua-mail used `mail-header` to check whether it was passed a From header. The implementation of `mail-header` must try to compare symbols instead of strings when looking for headers, as it was returning nil when a From

[PATCH] emacs: get rid of trailing spaces in notmuch-hello view

2012-03-10 Thread Dmitry Kurochkin
This patch removes trailing spaces in notmuch-hello view. A side effect of this change is that tag/query buttons no longer include a space at the end. This means that pressing RET when the point is at the first character after the tag/query button no longer works (note that this is the standard

[PATCH v2 2/2] test: use subtest name for generated message subject by default

2012-03-10 Thread Dmitry Kurochkin
Before the change, messages generated by generate_message() used "Test message #N" for default subject where N is the generated messages counter. Since message subject is commonly present in expected results, there is a chance of breaking other tests when a new generate_message() call is added.

[PATCH v2 1/2] test: remove "Generate some messages" test from raw

2012-03-10 Thread Dmitry Kurochkin
Before the change, the first subtest in raw format tests just generated messages and checked that they are added successfully. This is not really a raw format test, it is creating of environment required for other subtests to run. The patch removes the first subtest from raw and replaces it with

[PATCH v2 0/2] test: use subtest name for generated message subject

2012-03-10 Thread Dmitry Kurochkin
Changes in v2: * rebase on master Regards, Dmitry

[PATCH 2/2] emacs: fix off-by-one error in notmuch-hello column alignment

2012-03-09 Thread Dmitry Kurochkin
Expected results for few tests are fixed, the relevant test is unmarked broken. --- emacs/notmuch-hello.el |2 +- test/emacs-hello |1 - .../notmuch-hello-new-section |2 +-

[PATCH 1/2] test: add broken test for long names in Emacs notmuch-hello view

2012-03-09 Thread Dmitry Kurochkin
Currently, the column alignment in Emacs notmuch-hello is broken for tags/queries with long names. --- test/emacs-hello |9 + .../emacs.expected-output/notmuch-hello-long-names | 18 ++ 2 files changed, 27 insertions(+), 0

[PATCH v2 0/2] test: use subtest name for generated message subject

2012-03-09 Thread Dmitry Kurochkin
Changes in v2: * rebase on master Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2 2/2] test: use subtest name for generated message subject by default

2012-03-09 Thread Dmitry Kurochkin
Before the change, messages generated by generate_message() used Test message #N for default subject where N is the generated messages counter. Since message subject is commonly present in expected results, there is a chance of breaking other tests when a new generate_message() call is added.

[PATCH] emacs: get rid of trailing spaces in notmuch-hello view

2012-03-09 Thread Dmitry Kurochkin
This patch removes trailing spaces in notmuch-hello view. A side effect of this change is that tag/query buttons no longer include a space at the end. This means that pressing RET when the point is at the first character after the tag/query button no longer works (note that this is the standard

[PATCH 1/2] test: add broken test for long names in Emacs notmuch-hello view

2012-03-08 Thread Dmitry Kurochkin
Currently, the column alignment in Emacs notmuch-hello is broken for tags/queries with long names. --- test/emacs-hello |9 + .../emacs.expected-output/notmuch-hello-long-names | 18 ++ 2 files changed, 27 insertions(+), 0

[PATCH 2/2] emacs: fix off-by-one error in notmuch-hello column alignment

2012-03-08 Thread Dmitry Kurochkin
Expected results for few tests are fixed, the relevant test is unmarked broken. --- emacs/notmuch-hello.el |2 +- test/emacs-hello |1 - .../notmuch-hello-new-section |2 +-

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-06 Thread Dmitry Kurochkin
On Mon, 5 Mar 2012 22:55:54 +0200, Jani Nikula wrote: > On Mar 5, 2012 5:43 PM, "Dmitry Kurochkin" > wrote: > > > > On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe > wrote: > > > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin < > dmitry.kur

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Dmitry Kurochkin
On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe wrote: > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin gmail.com> wrote: > > On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe > > wrote: > > > notmuch-saved-search-sort-function might destructively modify i

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Dmitry Kurochkin
On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe wrote: > notmuch-saved-search-sort-function might destructively modify its > input (`sort' does that, for instance), so it should not be given > notmuch-saved-searches directly. > --- -1 I think we should require

[PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections

2012-03-05 Thread Dmitry Kurochkin
Hi Michal. On Sat, 18 Feb 2012 23:12:29 +0100, Michal Sojka wrote: > The result is that hello screen shows much faster when some sections are > hidden. > --- The patch looks good to me. Please do not send new patches as replies to other patch threads. It makes it difficult to track,

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Dmitry Kurochkin
On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe dan...@schoepe.org wrote: On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe dan...@schoepe.org wrote: notmuch-saved-search-sort-function might

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Dmitry Kurochkin
On Mon, 5 Mar 2012 22:55:54 +0200, Jani Nikula j...@nikula.org wrote: On Mar 5, 2012 5:43 PM, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe dan...@schoepe.org wrote: On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin

Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections

2012-03-04 Thread Dmitry Kurochkin
Hi Michal. On Sat, 18 Feb 2012 23:12:29 +0100, Michal Sojka sojk...@fel.cvut.cz wrote: The result is that hello screen shows much faster when some sections are hidden. --- The patch looks good to me. Please do not send new patches as replies to other patch threads. It makes it difficult to

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-04 Thread Dmitry Kurochkin
On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe dan...@schoepe.org wrote: notmuch-saved-search-sort-function might destructively modify its input (`sort' does that, for instance), so it should not be given notmuch-saved-searches directly. --- -1 I think we should require

[PATCH 1/2] test: remove "Generate some messages" test from raw

2012-03-02 Thread Dmitry Kurochkin
Hi David. On Wed, 15 Feb 2012 22:33:51 +0400, Dmitry Kurochkin wrote: > Hi all. > > Are there any objections to these changes? > > Otherwise, I would ask David to push it as "minor, boring and trivial" > changes. > Since there are no objections, I re

[PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

2012-03-01 Thread Dmitry Kurochkin
Hi Michal. On Thu, 01 Mar 2012 15:57:32 +0100, Michal Sojka wrote: > On Thu, 01 Mar 2012, David Bremner wrote: > > > > Pushed, finally. Thanks for both of your hard work on this. > > Hi, > > is anybody willing to review > id:"1329603149-6047-1-git-send-email-sojkam1 at fel.cvut.cz"? I plan

Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

2012-03-01 Thread Dmitry Kurochkin
Hi Michal. On Thu, 01 Mar 2012 15:57:32 +0100, Michal Sojka sojk...@fel.cvut.cz wrote: On Thu, 01 Mar 2012, David Bremner wrote: Pushed, finally. Thanks for both of your hard work on this. Hi, is anybody willing to review id:1329603149-6047-1-git-send-email-sojk...@fel.cvut.cz? I

Re: [PATCH 1/2] test: remove Generate some messages test from raw

2012-03-01 Thread Dmitry Kurochkin
Hi David. On Wed, 15 Feb 2012 22:33:51 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi all. Are there any objections to these changes? Otherwise, I would ask David to push it as minor, boring and trivial changes. Since there are no objections, I removed the needs-review

[PATCH 6/6] emacs: `notmuch-show-tag-all' sans prefix arg only tags open messages

2012-02-24 Thread Dmitry Kurochkin
On Fri, 24 Feb 2012 00:09:14 +0100, Pieter Praet wrote: > * emacs/notmuch-show.el > > (notmuch-show-get-messages-ids): > New optional argument ONLY-OPEN. If non-nil, only return > Message-Id's for messages which are currently visible. > > (notmuch-show-tag-all): > New optional

[PATCH 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

2012-02-24 Thread Dmitry Kurochkin
On Fri, 24 Feb 2012 00:09:13 +0100, Pieter Praet wrote: > * emacs/notmuch-show.el > > (notmuch-show-get-messages-ids): > If provided with optional arg SEPARATOR, return a string consisting > of all Message-Id's, separated by SEPARATOR. Also improve original > docstring wrt default

[PATCH 4/6] emacs: add predicate arg to `notmuch-show-mapc'

2012-02-24 Thread Dmitry Kurochkin
On Fri, 24 Feb 2012 00:09:12 +0100, Pieter Praet wrote: > * emacs/notmuch-show.el > > (notmuch-show-mapc): > Only call FUNCTION if new argument PREDICATE is satisfied. > Also correct original docstring: 's/thread/buffer/'. > > (notmuch-show-get-messages-ids): > Update wrt

[PATCH 1/6] test: emacs: new tests "notmuch-show: {add, remove} multiple tags {to, from} single message"

2012-02-24 Thread Dmitry Kurochkin
On Fri, 24 Feb 2012 00:09:09 +0100, Pieter Praet wrote: > * test/emacs: > > - Rename subtests "{Add,Remove} tag from notmuch-show view" to > "notmuch-show: {add,remove} single tag {to,from} single message" > to be consistent with the following tests. > > - New subtest "notmuch-show:

[PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-24 Thread Dmitry Kurochkin
On Fri, 24 Feb 2012 14:30:29 +0400, Dmitry Kurochkin wrote: > On Fri, 24 Feb 2012 00:07:27 +0100, Pieter Praet wrote: > > On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner > > wrote: > > > On Sun, 5 Feb 2012 11:13:41 +0400, Dmitry Kurochkin > > gma

[PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-24 Thread Dmitry Kurochkin
On Fri, 24 Feb 2012 00:07:27 +0100, Pieter Praet wrote: > On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner > wrote: > > On Sun, 5 Feb 2012 11:13:41 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > Changes: > > > > > > v4: > > &g

Re: [PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-24 Thread Dmitry Kurochkin
On Fri, 24 Feb 2012 00:07:27 +0100, Pieter Praet pie...@praet.org wrote: On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner da...@tethera.net wrote: On Sun, 5 Feb 2012 11:13:41 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Changes: v4: * rebased on master

Re: [PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-24 Thread Dmitry Kurochkin
On Fri, 24 Feb 2012 14:30:29 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Fri, 24 Feb 2012 00:07:27 +0100, Pieter Praet pie...@praet.org wrote: On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner da...@tethera.net wrote: On Sun, 5 Feb 2012 11:13:41 +0400, Dmitry Kurochkin

Re: [PATCH 1/6] test: emacs: new tests notmuch-show: {add, remove} multiple tags {to, from} single message

2012-02-24 Thread Dmitry Kurochkin
On Fri, 24 Feb 2012 00:09:09 +0100, Pieter Praet pie...@praet.org wrote: * test/emacs: - Rename subtests {Add,Remove} tag from notmuch-show view to notmuch-show: {add,remove} single tag {to,from} single message to be consistent with the following tests. - New subtest

Re: [PATCH 4/6] emacs: add predicate arg to `notmuch-show-mapc'

2012-02-24 Thread Dmitry Kurochkin
On Fri, 24 Feb 2012 00:09:12 +0100, Pieter Praet pie...@praet.org wrote: * emacs/notmuch-show.el (notmuch-show-mapc): Only call FUNCTION if new argument PREDICATE is satisfied. Also correct original docstring: 's/thread/buffer/'. (notmuch-show-get-messages-ids): Update

Re: [PATCH 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

2012-02-24 Thread Dmitry Kurochkin
On Fri, 24 Feb 2012 00:09:13 +0100, Pieter Praet pie...@praet.org wrote: * emacs/notmuch-show.el (notmuch-show-get-messages-ids): If provided with optional arg SEPARATOR, return a string consisting of all Message-Id's, separated by SEPARATOR. Also improve original docstring

Re: [PATCH 6/6] emacs: `notmuch-show-tag-all' sans prefix arg only tags open messages

2012-02-24 Thread Dmitry Kurochkin
On Fri, 24 Feb 2012 00:09:14 +0100, Pieter Praet pie...@praet.org wrote: * emacs/notmuch-show.el (notmuch-show-get-messages-ids): New optional argument ONLY-OPEN. If non-nil, only return Message-Id's for messages which are currently visible. (notmuch-show-tag-all): New

[PATCH v2 2/4] test: emacs: new test "notmuch-search: replying to a thread (sending)"

2012-02-20 Thread Dmitry Kurochkin
On Sun, 19 Feb 2012 21:38:26 +0100, Pieter Praet wrote: > As pointed out in the previous commit, the test for replying from > within Emacs didn't actually submit the reply. This one does. > --- > test/emacs | 41 + > 1 files changed, 41 insertions(+), 0

[PATCH v2 4/4] test: emacs: new test "notmuch-search: change tags of all matching messages"

2012-02-20 Thread Dmitry Kurochkin
On Sun, 19 Feb 2012 21:38:28 +0100, Pieter Praet wrote: > `notmuch-search-tag-all' (bound to "*") adds and removes tags > to/from all messages which match the query used to populate the > current search buffer. LGTM. But since you will need to send a new version to address Tomi's comments

[PATCH v2 3/4] test: emacs: new test "notmuch-search: when reply is sent, parent message should be tagged 'replied'"

2012-02-20 Thread Dmitry Kurochkin
On Sun, 19 Feb 2012 21:38:27 +0100, Pieter Praet wrote: > When a message is replied to, it should be tagged `replied'. > --- > test/emacs |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/test/emacs b/test/emacs > index 0f4f42b..b0fb760 100755 > --- a/test/emacs

[PATCH v2 1/4] test: emacs: rename subtest "Reply within emacs"

2012-02-20 Thread Dmitry Kurochkin
On Sun, 19 Feb 2012 21:38:25 +0100, Pieter Praet wrote: > Rename subtest "Reply within emacs" to "notmuch-search: replying to a > thread (composing)" as its title is misleading: it populates a reply > buffer but doesn't submit it. > --- LGTM Regards, Dmitry > test/emacs |2 +- > 1 files

Re: [PATCH v2 1/4] test: emacs: rename subtest Reply within emacs

2012-02-20 Thread Dmitry Kurochkin
On Sun, 19 Feb 2012 21:38:25 +0100, Pieter Praet pie...@praet.org wrote: Rename subtest Reply within emacs to notmuch-search: replying to a thread (composing) as its title is misleading: it populates a reply buffer but doesn't submit it. --- LGTM Regards, Dmitry test/emacs |2 +- 1

Re: [PATCH v2 3/4] test: emacs: new test notmuch-search: when reply is sent, parent message should be tagged 'replied'

2012-02-20 Thread Dmitry Kurochkin
On Sun, 19 Feb 2012 21:38:27 +0100, Pieter Praet pie...@praet.org wrote: When a message is replied to, it should be tagged `replied'. --- test/emacs |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 0f4f42b..b0fb760 100755 ---

Re: [PATCH v2 4/4] test: emacs: new test notmuch-search: change tags of all matching messages

2012-02-20 Thread Dmitry Kurochkin
On Sun, 19 Feb 2012 21:38:28 +0100, Pieter Praet pie...@praet.org wrote: `notmuch-search-tag-all' (bound to *) adds and removes tags to/from all messages which match the query used to populate the current search buffer. LGTM. But since you will need to send a new version to address Tomi's

Re: [PATCH v2 2/4] test: emacs: new test notmuch-search: replying to a thread (sending)

2012-02-20 Thread Dmitry Kurochkin
On Sun, 19 Feb 2012 21:38:26 +0100, Pieter Praet pie...@praet.org wrote: As pointed out in the previous commit, the test for replying from within Emacs didn't actually submit the reply. This one does. --- test/emacs | 41 + 1 files changed, 41

[PATCH 0/3] Make notmuch-show-refresh-view retain state by default

2012-02-19 Thread Dmitry Kurochkin
On Sun, 19 Feb 2012 01:22:10 -0500, Austin Clements wrote: > Based on the thread at id:"20120213152858.GO27039 at mit.edu" it seems > like people want show refresh to retain message state by default (I > certainly do), rather than reset it by default. As a nice bonus, this > fixes a broken test.

Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by default

2012-02-19 Thread Dmitry Kurochkin
On Sun, 19 Feb 2012 01:22:10 -0500, Austin Clements amdra...@mit.edu wrote: Based on the thread at id:20120213152858.go27...@mit.edu it seems like people want show refresh to retain message state by default (I certainly do), rather than reset it by default. As a nice bonus, this fixes a

Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by default

2012-02-19 Thread Dmitry Kurochkin
On Sun, 19 Feb 2012 12:25:41 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Tomi Ollila on Feb 19 at 11:43 am: On Sun, 19 Feb 2012 01:22:10 -0500, Austin Clements amdra...@mit.edu wrote: Based on the thread at id:20120213152858.go27...@mit.edu it seems like people want show

[PATCH v10 2/2] emacs: Tests for user-defined sections

2012-02-17 Thread Dmitry Kurochkin
From: Daniel Schoepe A new file was added for notmuch-hello tests. --- test/emacs-hello | 47 test/emacs.expected-output/notmuch-hello |3 +- .../notmuch-hello-new-section

[PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

2012-02-17 Thread Dmitry Kurochkin
From: Daniel Schoepe This patch makes the notmuch-hello screen fully customizable by allowing the user to add and remove arbitrary sections. It also provides some convenience functions for constructing sections, e.g. showing the unread message count for each tag.

[PATCH v10 0/2] emacs: User-defined sections in notmuch-hello

2012-02-17 Thread Dmitry Kurochkin
Found a small bug... Changes: v10: * explicitly return nil from `notmuch-hello-insert-recent-searches', otherwise `indent-rigidly' returns a marker pointing to non-existing buffer and breaks final-target-pos handling in `notmuch-hello' v9: * correctly merge

  1   2   3   4   5   6   7   8   9   10   >