On disk tag storage format

2013-10-07 Thread Ethan Glasser-Camp
Ethan Glasser-Camp writes: > I've modified the script so that it would run by mangling filenames, > which is irreversible (the original tried to encode/decode filenames > reversibly). Then I got a little carried away, adding --verbose and > --dry-run options as well as removing a cou

Re: On disk tag storage format

2013-10-06 Thread Ethan Glasser-Camp
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes: I've modified the script so that it would run by mangling filenames, which is irreversible (the original tried to encode/decode filenames reversibly). Then I got a little carried away, adding --verbose and --dry-run options as well

On disk tag storage format

2013-10-04 Thread Ethan Glasser-Camp
David Bremner writes: > It's still a prototype, and there is not much error checking, and there > are certain issues not dealt with at all (the ones I thought about are > commented). Hi everyone, I'm very interested in running notmuch on all my laptops and having my mail and its tags be

Re: On disk tag storage format

2013-10-04 Thread Ethan Glasser-Camp
David Bremner da...@tethera.net writes: It's still a prototype, and there is not much error checking, and there are certain issues not dealt with at all (the ones I thought about are commented). Hi everyone, I'm very interested in running notmuch on all my laptops and having my mail and its

Notmuch scripts (again), now with more usenet

2012-11-18 Thread Ethan Glasser-Camp
Jan Pobrislo writes: > Hi! I was having some hardware issues and had to migrate the site. It should > be all up again and ready for inclusion. > > Added stuff from last time: > * source function & actions for zaw (https://github.com/zsh-users/zaw) > * LICENSE (CC0) Hi! Sorry for the delay, real

[PATCH v2] emacs: display tags in notmuch-show with links

2012-11-18 Thread Ethan Glasser-Camp
Damien Cassou writes: > This patch obsoletes > id:1352565719-12397-1-git-send-email-damien.cassou at gmail.com > > [PATCH 1/4] emacs: Add a thread's tags to emacs header-line > [PATCH 2/4] emacs: Make tags in header-line clickable > [PATCH 3/4] emacs: Make tags that appear in `notmuch-show'

Add new dump/restore format and batch tagging.

2012-11-18 Thread Ethan Glasser-Camp
Ethan Glasser-Camp writes: > - Patch 4 still has a subject line that ends in a period. I don't think > this is mandatory for everyone but some people consider it best > practice. Best practice, of course, would be to remove the period at the end of the subject line. Patch 12 als

Add new dump/restore format and batch tagging.

2012-11-18 Thread Ethan Glasser-Camp
david at tethera.net writes: > which was revied by Tomi and Ethan. I think I implemented their > suggestions. Actually, I don't think you implemented all of mine. - Patch 4 still has a subject line that ends in a period. I don't think this is mandatory for everyone but some people consider it

[PATCH 2/2] emacs: less guessing of character set in messages

2012-11-18 Thread Ethan Glasser-Camp
Tomi Ollila writes: > The macro with-current-notmuch-show-message executes command > `notmuch show --format=raw id:...` which just outputs the contents > of the mail file verbatim (into temporary buffer). In case e.g. utf-8 > locale is used the temporary buffer has buffer-file-coding-system as >

[BUG] Saving attachments containing UTF-8 chars

2012-11-18 Thread Ethan Glasser-Camp
Ethan Glasser-Camp writes: > Writing this buffer using C-x C-w encodes it correctly too. So I think > this is an emacs MIME problem. We call mm-save-part, which calls > mm-save-part-to-file, which calls mm-with-unibyte-buffer. Hmm.. > > Indeed, it seems that inserting this charac

[BUG] Saving attachments containing UTF-8 chars

2012-11-18 Thread Ethan Glasser-Camp
Tomi Ollila writes: > I can verify this bug: I copied 'rawmail' to my mail store and attempted > to 'w' the attacment and got the same result (after notmuch new). > > The saving code first does > notmuch show --format=raw id:"508953E6.70006 at gmail.com" > which decodes OK on command line, and

Re: [BUG] Saving attachments containing UTF-8 chars

2012-11-18 Thread Ethan Glasser-Camp
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes: Writing this buffer using C-x C-w encodes it correctly too. So I think this is an emacs MIME problem. We call mm-save-part, which calls mm-save-part-to-file, which calls mm-with-unibyte-buffer. Hmm.. Indeed, it seems that inserting

Re: Add new dump/restore format and batch tagging.

2012-11-18 Thread Ethan Glasser-Camp
da...@tethera.net writes: which was revied by Tomi and Ethan. I think I implemented their suggestions. Actually, I don't think you implemented all of mine. - Patch 4 still has a subject line that ends in a period. I don't think this is mandatory for everyone but some people consider it best

Re: Add new dump/restore format and batch tagging.

2012-11-18 Thread Ethan Glasser-Camp
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes: - Patch 4 still has a subject line that ends in a period. I don't think this is mandatory for everyone but some people consider it best practice. Best practice, of course, would be to remove the period at the end of the subject line

Re: [PATCH v2] emacs: display tags in notmuch-show with links

2012-11-18 Thread Ethan Glasser-Camp
Damien Cassou damien.cas...@gmail.com writes: This patch obsoletes id:1352565719-12397-1-git-send-email-damien.cas...@gmail.com [PATCH 1/4] emacs: Add a thread's tags to emacs header-line [PATCH 2/4] emacs: Make tags in header-line clickable [PATCH 3/4] emacs: Make tags that appear in

Re: Notmuch scripts (again), now with more usenet

2012-11-18 Thread Ethan Glasser-Camp
Jan Pobrislo c...@webprojekty.cz writes: Hi! I was having some hardware issues and had to migrate the site. It should be all up again and ready for inclusion. Added stuff from last time: * source function actions for zaw (https://github.com/zsh-users/zaw) * LICENSE (CC0) Hi! Sorry for the

[PATCH 2/2] test: add nontrivial test for restore --accumulate.

2012-11-17 Thread Ethan Glasser-Camp
david at tethera.net writes: > From: David Bremner > > It seems we have never tested the case that restore --accumulate > actually adds tags. I noticed this when I started optimizing and no > tests failed. > > The bracketing with "restore --input=dump.expected" are to make sure > we start in a

Re: [PATCH 2/2] test: add nontrivial test for restore --accumulate.

2012-11-17 Thread Ethan Glasser-Camp
da...@tethera.net writes: From: David Bremner brem...@debian.org It seems we have never tested the case that restore --accumulate actually adds tags. I noticed this when I started optimizing and no tests failed. The bracketing with restore --input=dump.expected are to make sure we start

Re: [BUG] Saving attachments containing UTF-8 chars

2012-11-17 Thread Ethan Glasser-Camp
Tomi Ollila tomi.oll...@iki.fi writes: I can verify this bug: I copied 'rawmail' to my mail store and attempted to 'w' the attacment and got the same result (after notmuch new). The saving code first does notmuch show --format=raw id:508953e6.70...@gmail.com which decodes OK on command

[PATCH] test: add nontrivial test for restore --accumulate.

2012-11-16 Thread Ethan Glasser-Camp
david at tethera.net writes: > From: David Bremner > > It seems we have never tested the case that restore --accumulate > actually adds tags. I noticed this when I started optimizing and no > tests failed. > > I also had to modify the next test. Perhaps a seperate patch could > make these tests

Re: [PATCH] test: add nontrivial test for restore --accumulate.

2012-11-16 Thread Ethan Glasser-Camp
da...@tethera.net writes: From: David Bremner brem...@debian.org It seems we have never tested the case that restore --accumulate actually adds tags. I noticed this when I started optimizing and no tests failed. I also had to modify the next test. Perhaps a seperate patch could make these

[PATCH v2] test: Fix HTML rendering test

2012-11-13 Thread Ethan Glasser-Camp
Austin Clements writes: > The test designed to exercise Emacs' rendering of HTML emails > containing images inadvertently assumed w3m was available under Emacs > 23. The real point of this test was to check that Emacs 24's shr > renderer didn't crash when given img tags, so use shr if it's >

[PATCH v2 0/3] Better id: link buttonization

2012-11-13 Thread Ethan Glasser-Camp
Austin Clements writes: > This is v2 of id:"1351650561-7331-1-git-send-email-amdragon at mit.edu". > This makes Jani's suggested additions to the regexp and adds support > for RFC 2392 mid: links, as suggested by Sascha. This series looks fine to me. Ethan

[PATCH v2] emacs: display tags in notmuch-show with links

2012-11-13 Thread Ethan Glasser-Camp
Damien Cassou writes: > +(defun notmuch-tagger-present-tags (tags headerline) > + "Return a property list which nicely presents all TAGS. > + > +If HEADERLINE is non-nil the returned list will be ready for > +inclusion in the buffer's header-line. HEADERLINE must be nil in > +all other cases."

emacs: Handling external dependencies

2012-11-13 Thread Ethan Glasser-Camp
Damien Cassou writes: > 4) distribute the dependency with the rest of notmuch (in a separate > "fallback-libs/" directory) and load it only when requiring the > library with the standard load-path does not work. Jonas Bernoulli > gave me a way to do that: > > , > | (or (require 'THE-LIB nil

Re: emacs: Handling external dependencies

2012-11-13 Thread Ethan Glasser-Camp
Damien Cassou damien.cas...@gmail.com writes: 4) distribute the dependency with the rest of notmuch (in a separate fallback-libs/ directory) and load it only when requiring the library with the standard load-path does not work. Jonas Bernoulli gave me a way to do that: , | (or (require

Re: [PATCH v2] emacs: display tags in notmuch-show with links

2012-11-13 Thread Ethan Glasser-Camp
Damien Cassou damien.cas...@gmail.com writes: +(defun notmuch-tagger-present-tags (tags optional headerline) + Return a property list which nicely presents all TAGS. + +If HEADERLINE is non-nil the returned list will be ready for +inclusion in the buffer's header-line. HEADERLINE must be

Re: [PATCH v2 0/3] Better id: link buttonization

2012-11-13 Thread Ethan Glasser-Camp
Austin Clements amdra...@mit.edu writes: This is v2 of id:1351650561-7331-1-git-send-email-amdra...@mit.edu. This makes Jani's suggested additions to the regexp and adds support for RFC 2392 mid: links, as suggested by Sascha. This series looks fine to me. Ethan

Re: [PATCH v2] test: Fix HTML rendering test

2012-11-13 Thread Ethan Glasser-Camp
Austin Clements amdra...@mit.edu writes: The test designed to exercise Emacs' rendering of HTML emails containing images inadvertently assumed w3m was available under Emacs 23. The real point of this test was to check that Emacs 24's shr renderer didn't crash when given img tags, so use shr

[PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to know

2012-11-05 Thread Ethan Glasser-Camp
Tomi Ollila writes: > Added FILE, notmuch_show_params_t and sprinter_t to be > types when uncrustifying sources. This affect spacing > when uncrustify is deciding for type declaration instead > of binary multiplication operation. This looks good to me. If you had plenty of time and no more

[PATCH] fix notmuch_database_open call in addrlookup

2012-11-05 Thread Ethan Glasser-Camp
James Vasile writes: > What's the best way to submit changes to addrlookup? Right now, it is > out of date vs the latest libnotmuch. The addrlookup repo is vala code > but the wiki [1] points to a generated c file [2]. > > [1]

[PATCH v2 0/2] include Reply-To headers in json output

2012-11-05 Thread Ethan Glasser-Camp
Peter Wang writes: > This obsoletes the series 1340508470-16606-1-git-send-email-novalazy at > gmail.com > Only json output is affected now. > > Peter Wang (2): > show: include Reply-To header in json output > test: add test for showing Reply-To headers LGTM. Removed needs-review, added

Re: [PATCH v2 0/2] include Reply-To headers in json output

2012-11-05 Thread Ethan Glasser-Camp
Peter Wang noval...@gmail.com writes: This obsoletes the series 1340508470-16606-1-git-send-email-noval...@gmail.com Only json output is affected now. Peter Wang (2): show: include Reply-To header in json output test: add test for showing Reply-To headers LGTM. Removed needs-review,

Re: [PATCH] fix notmuch_database_open call in addrlookup

2012-11-05 Thread Ethan Glasser-Camp
James Vasile ja...@hackervisions.org writes: What's the best way to submit changes to addrlookup? Right now, it is out of date vs the latest libnotmuch. The addrlookup repo is vala code but the wiki [1] points to a generated c file [2]. [1]

Re: [PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to know

2012-11-05 Thread Ethan Glasser-Camp
Tomi Ollila tomi.oll...@iki.fi writes: Added FILE, notmuch_show_params_t and sprinter_t to be types when uncrustifying sources. This affect spacing when uncrustify is deciding for type declaration instead of binary multiplication operation. This looks good to me. If you had plenty of time

[PATCH (draft) 1/2] emacs: allow the user to toggle the visibility of multipart/alternative parts

2012-10-27 Thread Ethan Glasser-Camp
Mark Walters writes: > This patch adds a keybinding to the buttons in the notmuch-show emacs > buffer to allow the user to toggle the visibility of each part of a > message in the show buffer. This is particularly useful for > multipart/alternative parts where the parts are not really >

[PATCH 1/3] contrib: add notmuch-pick.el file itself

2012-10-27 Thread Ethan Glasser-Camp
Mark Walters writes: > +(defvar notmuch-pick-json-parser nil > + "Incremental JSON parser for the search process filter.") > + > +(defun notmuch-pick-process-filter (proc string) > + "Process and filter the output of \"notmuch show\" (for pick)" > + (let ((results-buf (process-buffer proc)) >

[PATCH 1/3] emacs: Introduce generic boolean term escaping function

2012-10-27 Thread Ethan Glasser-Camp
Tomi Ollila writes: > These 3 patches LGTM. Me too. But I wouldn't be averse to some tests :) Ethan

[PATCH 1/2] tag: Disallow adding malformed tags to messages

2012-10-27 Thread Ethan Glasser-Camp
Tomi Ollila writes: > LGTM (NEWS too) Yep! Removing needs-review. Ethan

Re: [PATCH 1/3] emacs: Introduce generic boolean term escaping function

2012-10-27 Thread Ethan Glasser-Camp
Tomi Ollila tomi.oll...@iki.fi writes: These 3 patches LGTM. Me too. But I wouldn't be averse to some tests :) Ethan ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] contrib: add notmuch-pick.el file itself

2012-10-27 Thread Ethan Glasser-Camp
Mark Walters markwalters1...@gmail.com writes: +(defvar notmuch-pick-json-parser nil + Incremental JSON parser for the search process filter.) + +(defun notmuch-pick-process-filter (proc string) + Process and filter the output of \notmuch show\ (for pick) + (let ((results-buf

Re: [PATCH (draft) 1/2] emacs: allow the user to toggle the visibility of multipart/alternative parts

2012-10-27 Thread Ethan Glasser-Camp
Mark Walters markwalters1...@gmail.com writes: This patch adds a keybinding to the buttons in the notmuch-show emacs buffer to allow the user to toggle the visibility of each part of a message in the show buffer. This is particularly useful for multipart/alternative parts where the parts are

Re: [PATCH 1/2] tag: Disallow adding malformed tags to messages

2012-10-26 Thread Ethan Glasser-Camp
Tomi Ollila tomi.oll...@iki.fi writes: LGTM (NEWS too) Yep! Removing needs-review. Ethan ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] Support OpenBSD

2012-10-25 Thread Ethan Glasser-Camp
Austin Clements writes: > OpenBSD's build flags are identical to FreeBSD, except that libraries > need to be explicitly linked against libc. No code changes are > necessary. > > From: Cody Cutler > --- OK, looks fine. Ethan

[PATCH] test: Fix HTML rendering test

2012-10-25 Thread Ethan Glasser-Camp
Austin Clements writes: > Quoth Ethan Glasser-Camp on Oct 24 at 9:59 pm: >> Austin Clements writes: > > Emacs seems to have as many ways to convert HTML to text as there are > people trying to run this test. What's the value of > mm-text-html-renderer for you in Emacs 24?

Re: [PATCH] test: Fix HTML rendering test

2012-10-25 Thread Ethan Glasser-Camp
Austin Clements amdra...@mit.edu writes: Quoth Ethan Glasser-Camp on Oct 24 at 9:59 pm: Austin Clements amdra...@mit.edu writes: Emacs seems to have as many ways to convert HTML to text as there are people trying to run this test. What's the value of mm-text-html-renderer for you in Emacs

Re: [PATCH] Support OpenBSD

2012-10-25 Thread Ethan Glasser-Camp
Austin Clements amdra...@mit.edu writes: OpenBSD's build flags are identical to FreeBSD, except that libraries need to be explicitly linked against libc. No code changes are necessary. From: Cody Cutler ccut...@csail.mit.edu --- OK, looks fine. Ethan

[PATCH] test: Fix HTML rendering test

2012-10-24 Thread Ethan Glasser-Camp
Austin Clements writes: > The test designed to exercise Emacs' rendering of HTML emails > containing images inadvertently assumed w3m was available under Emacs > 23. The real point of this test was to exercise Emacs 24's shr > renderer, so if shr isn't available, we now fall back to html2text,

Re: [PATCH] test: Fix HTML rendering test

2012-10-24 Thread Ethan Glasser-Camp
Austin Clements amdra...@mit.edu writes: The test designed to exercise Emacs' rendering of HTML emails containing images inadvertently assumed w3m was available under Emacs 23. The real point of this test was to exercise Emacs 24's shr renderer, so if shr isn't available, we now fall back to

[PATCH v3 2/3] emacs: Rename incremental JSON internal variables.

2012-10-23 Thread Ethan Glasser-Camp
Mark Walters writes: > This patch just renames the internal variables for the JSON parser now > it is no longer specific to search mode. It also fixes up the white > space after the previous patch. There should be no functional changes. This series looks very good to me. I still have a couple

Re: [PATCH v3 2/3] emacs: Rename incremental JSON internal variables.

2012-10-23 Thread Ethan Glasser-Camp
Mark Walters markwalters1...@gmail.com writes: This patch just renames the internal variables for the JSON parser now it is no longer specific to search mode. It also fixes up the white space after the previous patch. There should be no functional changes. This series looks very good to me. I

[PATCH] test: new: Fix intermittent test failures with --debug

2012-10-21 Thread Ethan Glasser-Camp
are the same. Fix the failures by sorting the output of notmuch --debug and comparing this to a hand-sorted version of its output. Signed-off-by: Ethan Glasser-Camp --- test/new | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/new b/test/new index cc2af72..587aa11

[PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-10-21 Thread Ethan Glasser-Camp
Peter Wang writes: > Does it help if you add a "sleep 1" before the second generate_message > call, i.e. on line 35? It turns out that this test failure is sporadic (perhaps due to the fact that I'm running on tmpfs) and exists even before this series. Doing "sleep 1" makes it go away, but that

[PATCH v3] test: conform to content length, encoding fields

2012-10-21 Thread Ethan Glasser-Camp
Peter Wang writes: > Update tests to expect content-length and content-transfer-encoding > fields in show --format=json output, for leaf parts with omitted body > content. OK, this whole series looks good to me. Ethan

Re: [PATCH v3] test: conform to content length, encoding fields

2012-10-21 Thread Ethan Glasser-Camp
Peter Wang noval...@gmail.com writes: Update tests to expect content-length and content-transfer-encoding fields in show --format=json output, for leaf parts with omitted body content. OK, this whole series looks good to me. Ethan ___ notmuch

Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-10-21 Thread Ethan Glasser-Camp
Peter Wang noval...@gmail.com writes: Does it help if you add a sleep 1 before the second generate_message call, i.e. on line 35? It turns out that this test failure is sporadic (perhaps due to the fact that I'm running on tmpfs) and exists even before this series. Doing sleep 1 makes it go

[PATCH] test: new: Fix intermittent test failures with --debug

2012-10-21 Thread Ethan Glasser-Camp
are the same. Fix the failures by sorting the output of notmuch --debug and comparing this to a hand-sorted version of its output. Signed-off-by: Ethan Glasser-Camp et...@betacantrips.com --- test/new | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/new b/test/new

[PATCH] lib: fix warnings when building with clang

2012-10-20 Thread Ethan Glasser-Camp
Jani Nikula writes: > Building notmuch with CC=clang and CXX=clang++ produces the warnings: > > CC -O2 lib/tags.o > lib/tags.c:43:5: warning: expression result unused [-Wunused-value] > talloc_steal (tags, list); > ^ > /usr/include/talloc.h:345:143: note: expanded

[PATCH V3 1/2] test/smtp-dummy: add --background option and functionality

2012-10-20 Thread Ethan Glasser-Camp
Tomi Ollila writes: > From: Tomi Ollila > > When shell executes background process using '&' the scheduling of > that new process is arbitrary. It could be that smtp-dummy doesn't > get execution time to listen() it's server socket until some other > process attempts to connect() to it. The

[PATCHv3] notmuch-show: include Bcc header in json output

2012-10-20 Thread Ethan Glasser-Camp
Michal Nazarewicz writes: > From: Michal Nazarewicz > > With this change, emacs users can use notmuch-message-headers > variable to configure notmuch-show display Bcc header. > --- This patch looks pretty straightforward and has seen a certain amount of review so I'm taking off needs-review.

[PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t

2012-10-20 Thread Ethan Glasser-Camp
Jani Nikula writes: > On Wed, 17 Oct 2012, Adrien Bustany wrote: >> The code of the patches in unchanged, but the formatting issues are now >> hopefully fixed. > > Hi Adrien, please check at what version flush and reopen have been > introduced to xapian. If they are new-ish (I don't know,

random corpus generator, v3

2012-10-20 Thread Ethan Glasser-Camp
david at tethera.net writes: > This obsoletes the series at: > > id:"134431-4301-1-git-send-email-bremner at debian.org" > > Changes since v2: > > - clean up new test-binaries and objects > > - remove the "set -o pipefail" leftover from debugging. Possibly this > makes sense as a

Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t

2012-10-20 Thread Ethan Glasser-Camp
Jani Nikula j...@nikula.org writes: On Wed, 17 Oct 2012, Adrien Bustany adr...@bustany.org wrote: The code of the patches in unchanged, but the formatting issues are now hopefully fixed. Hi Adrien, please check at what version flush and reopen have been introduced to xapian. If they are

Re: [PATCHv3] notmuch-show: include Bcc header in json output

2012-10-20 Thread Ethan Glasser-Camp
Michal Nazarewicz m...@google.com writes: From: Michal Nazarewicz min...@mina86.com With this change, emacs users can use notmuch-message-headers variable to configure notmuch-show display Bcc header. --- This patch looks pretty straightforward and has seen a certain amount of review so I'm

Re: [PATCH V3 1/2] test/smtp-dummy: add --background option and functionality

2012-10-20 Thread Ethan Glasser-Camp
Tomi Ollila tomi.oll...@iki.fi writes: From: Tomi Ollila t...@iki.fi When shell executes background process using '' the scheduling of that new process is arbitrary. It could be that smtp-dummy doesn't get execution time to listen() it's server socket until some other process attempts to

[PATCH 1/2] test: add emacs show mode test for toggling display of multipart/alternative

2012-10-19 Thread Ethan Glasser-Camp
Jameson Graef Rollins writes: > +diff OUTPUT.{text,html} >OUTPUT.diff > +cat +7,9c7,10 > +< [ text/html (not shown) ] > +< [ text/plain ] > +< This is the text/plain part of a multipart/alternative. > +--- > +> [ text/html ] > +> This is the text/html part of a

[PATCH v2 3/3] test: conform to content length, encoding fields

2012-10-19 Thread Ethan Glasser-Camp
Peter Wang writes: > Update tests to expect content-length and content-transfer-encoding > fields in show --format=json output, for leaf parts with omitted body > content. These three patches all look fine to me, except for the following problem. > diff --git a/test/json b/test/json > index

[PATCH 1/4] show: indicate length of omitted body content (json)

2012-10-19 Thread Ethan Glasser-Camp
Peter Wang writes: > If a leaf part's body content is omitted, return the content length in > --format=json output. This information may be used by the consumer, > e.g. to decide whether to download a large attachment over a slow link. It looks like this patch series was thoroughly reviewed

[PATCH v2 (Draft)] emacs: split async json parser into utility function

2012-10-19 Thread Ethan Glasser-Camp
Mark Walters writes: > Split out the json parser into a utility function. > --- > > Most of this patch is code movement: but I don't see how to arrange the > patch to show that. Hi! This looks like a straightforward patch and if it will make notmuch-pick more efficient, I'm in favor. I tagged

[PATCH] emacs: functions to import sender or recipient into BBDB

2012-10-19 Thread Ethan Glasser-Camp
Daniel Bergey writes: > From a show buffer, bbdb/notmuch-snarf-from imports the sender into > bbdb. bbdb/notmuch-snarf-to attempts to import all recipients. BBDB > displays a buffer with each contact; C-g displays the next contact, or > returns to the notmuch-show buffer. > > This is my first

[PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-10-19 Thread Ethan Glasser-Camp
Ethan Glasser-Camp writes: > It looks like you have better wording for patch 4/8 so I'd like to see > you resend it. > > I'm marking patches 3, 4, and 7 as moreinfo. Please resubmit! It turns out that patch 4 already has a v2 in the thread, but I didn't see it due to some kind

[PATCH v2] emacs: add function to toggle display of all multipart/alternative parts

2012-10-19 Thread Ethan Glasser-Camp
Mark Walters writes: > Some messages are sent as multipart/alternative but the alternatives > contain different information. This allows the user to cycle which > part to view. By default this is bound to 'W'. > --- > > This version at least uses the notmuch escaping for message-id which > makes

[PATCH] Add NEWS item for multipart/alternative toggle

2012-10-19 Thread Ethan Glasser-Camp
Users who relied on notmuch-show-all-multipart/alternative-parts might need to know that it is now buffer-local. Signed-off-by: Ethan Glasser-Camp --- Hi! I'm trying to figure out the status of this patch series, which seems to have fallen through the cracks. It looks like Jani's solution exists

[PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-10-19 Thread Ethan Glasser-Camp
Peter Wang writes: > Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can > cover all four values of search --exclude in the cli. This series looks good to me. It's a nice clean up and a nice new feature. Patches all apply. However, I'm getting test failures like: FAIL Search,

[PATCH 3/7] go: Allow notmuch objects to be garbage collected

2012-10-19 Thread Ethan Glasser-Camp
Adrien Bustany writes: > This makes notmuch appropriately free the underlying notmuch C objects > when garbage collecting their Go wrappers. To make sure we don't break > the underlying links between objects (for example, a notmuch_messages_t > being GC'ed before a notmuch_message_t belonging to

Notmuch scripts (again), now with more usenet

2012-10-19 Thread Ethan Glasser-Camp
ccx at webprojekty.cz writes: > Hello, for quite some time my set of scripts just lied in my repo and > waited for polish before release. So tonight I finally managed to update > the docs, remove old stuff, rewrite some unfortunate things etc. > > One notable addition is slrn2maildir script which

[PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t

2012-10-19 Thread Ethan Glasser-Camp
Adrien Bustany writes: > The code of the patches in unchanged, but the formatting issues are now > hopefully fixed. These look fine to me, and they're pretty trivial. Ethan

[PATCH] Add NEWS item for multipart/alternative toggle

2012-10-19 Thread Ethan Glasser-Camp
Users who relied on notmuch-show-all-multipart/alternative-parts might need to know that it is now buffer-local. Signed-off-by: Ethan Glasser-Camp et...@betacantrips.com --- Hi! I'm trying to figure out the status of this patch series, which seems to have fallen through the cracks. It looks like

Re: [PATCH v2] emacs: add function to toggle display of all multipart/alternative parts

2012-10-19 Thread Ethan Glasser-Camp
Mark Walters markwalters1...@gmail.com writes: Some messages are sent as multipart/alternative but the alternatives contain different information. This allows the user to cycle which part to view. By default this is bound to 'W'. --- This version at least uses the notmuch escaping for

Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-10-19 Thread Ethan Glasser-Camp
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes: It looks like you have better wording for patch 4/8 so I'd like to see you resend it. I'm marking patches 3, 4, and 7 as moreinfo. Please resubmit! It turns out that patch 4 already has a v2 in the thread, but I didn't see it due

Re: [PATCH] emacs: functions to import sender or recipient into BBDB

2012-10-19 Thread Ethan Glasser-Camp
Daniel Bergey ber...@alum.mit.edu writes: From a show buffer, bbdb/notmuch-snarf-from imports the sender into bbdb. bbdb/notmuch-snarf-to attempts to import all recipients. BBDB displays a buffer with each contact; C-g displays the next contact, or returns to the notmuch-show buffer. This

Re: [PATCH v2 (Draft)] emacs: split async json parser into utility function

2012-10-19 Thread Ethan Glasser-Camp
Mark Walters markwalters1...@gmail.com writes: Split out the json parser into a utility function. --- Most of this patch is code movement: but I don't see how to arrange the patch to show that. Hi! This looks like a straightforward patch and if it will make notmuch-pick more efficient, I'm

Re: [PATCH 1/4] show: indicate length of omitted body content (json)

2012-10-19 Thread Ethan Glasser-Camp
Peter Wang noval...@gmail.com writes: If a leaf part's body content is omitted, return the content length in --format=json output. This information may be used by the consumer, e.g. to decide whether to download a large attachment over a slow link. It looks like this patch series was

Re: [PATCH v2 3/3] test: conform to content length, encoding fields

2012-10-19 Thread Ethan Glasser-Camp
Peter Wang noval...@gmail.com writes: Update tests to expect content-length and content-transfer-encoding fields in show --format=json output, for leaf parts with omitted body content. These three patches all look fine to me, except for the following problem. diff --git a/test/json

Re: [PATCH 1/2] test: add emacs show mode test for toggling display of multipart/alternative

2012-10-19 Thread Ethan Glasser-Camp
Jameson Graef Rollins jroll...@finestructure.net writes: +diff OUTPUT.{text,html} OUTPUT.diff +cat EOF EXPECTED.diff +7,9c7,10 + [ text/html (not shown) ] + [ text/plain ] + This is the text/plain part of a multipart/alternative. +--- + [ text/html ] + This is the text/html part of a

Re: random corpus generator, v3

2012-10-19 Thread Ethan Glasser-Camp
da...@tethera.net writes: This obsoletes the series at: id:134431-4301-1-git-send-email-brem...@debian.org Changes since v2: - clean up new test-binaries and objects - remove the set -o pipefail leftover from debugging. Possibly this makes sense as a global setting, but in a

Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t

2012-10-18 Thread Ethan Glasser-Camp
Adrien Bustany adr...@bustany.org writes: The code of the patches in unchanged, but the formatting issues are now hopefully fixed. These look fine to me, and they're pretty trivial. Ethan ___ notmuch mailing list notmuch@notmuchmail.org

Re: Notmuch scripts (again), now with more usenet

2012-10-18 Thread Ethan Glasser-Camp
c...@webprojekty.cz writes: Hello, for quite some time my set of scripts just lied in my repo and waited for polish before release. So tonight I finally managed to update the docs, remove old stuff, rewrite some unfortunate things etc. One notable addition is slrn2maildir script which can

Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-10-18 Thread Ethan Glasser-Camp
Peter Wang noval...@gmail.com writes: Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can cover all four values of search --exclude in the cli. This series looks good to me. It's a nice clean up and a nice new feature. Patches all apply. However, I'm getting test failures like:

[PATCH] test: Move tests from emacs to emacs-show

2012-10-17 Thread Ethan Glasser-Camp
otmuch-show'" Signed-off-by: Ethan Glasser-Camp --- I screwed up with git commit --amend or something on the last patch, so David Bremner suggested that I take advantage of the situation to write this patch, which does something useful as a side effect. test/emacs

[PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'

2012-10-17 Thread Ethan Glasser-Camp
Ethan Glasser-Camp writes: > This patch, and its predecessors, all look great to me. But a note: many of the first lines in your commit messages ("{show, hide} message headers") contain tabs. I hate tabs. Is this intentional? I have noticed it on other patches you've sen

[PATCH 1/3] test: emacs: toggle eliding of non-matching messages in `notmuch-show'

2012-10-17 Thread Ethan Glasser-Camp
From: Pieter Praet <pie...@praet.org> See commits 44a544ed, 866ce8b1, 668b66ec. Signed-off-by: Ethan Glasser-Camp --- I am embarrassed to admit I didn't try to apply these patches before I removed the needs-review tag. This one didn't apply. Here's the trivial fix. The tests are still

[PATCH 1/2] Add notmuch_database_flush method

2012-10-17 Thread Ethan Glasser-Camp
Adrien Bustany writes: > This method explicitly flushes the pending modifications to disk. It is > useful if your program has various threads, each with a read only DB and > one writer thread with a read/write DB. In that case, you most likely > want the writer to sync the changes to disk so

Re: [PATCH 1/2] Add notmuch_database_flush method

2012-10-17 Thread Ethan Glasser-Camp
Adrien Bustany adr...@bustany.org writes: This method explicitly flushes the pending modifications to disk. It is useful if your program has various threads, each with a read only DB and one writer thread with a read/write DB. In that case, you most likely want the writer to sync the changes

[PATCH 1/3] test: emacs: toggle eliding of non-matching messages in `notmuch-show'

2012-10-17 Thread Ethan Glasser-Camp
From: Pieter Praet pie...@praet.org See commits 44a544ed, 866ce8b1, 668b66ec. Signed-off-by: Ethan Glasser-Camp et...@betacantrips.com --- I am embarrassed to admit I didn't try to apply these patches before I removed the needs-review tag. This one didn't apply. Here's the trivial fix. The tests

Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'

2012-10-17 Thread Ethan Glasser-Camp
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes: This patch, and its predecessors, all look great to me. But a note: many of the first lines in your commit messages ({show, hide} message headers) contain tabs. I hate tabs. Is this intentional? I have noticed it on other patches you've

[PATCH] test: Move tests from emacs to emacs-show

2012-10-17 Thread Ethan Glasser-Camp
: test: emacs: toggle processing of cryptographic MIME parts in `notmuch-show'. See commit 19ec74c5. - 5ea1dbe test: emacs: toggle eliding of non-matching messages in `notmuch-show' - 345faab test: emacs: toggle thread content indentation in `notmuch-show' Signed-off-by: Ethan Glasser-Camp

[PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

2012-10-16 Thread Ethan Glasser-Camp
Mark Walters writes: > I like the use of separator rather than hard-wiring " or ". My personal > preference would be to make that change but keep the two functions > separate (my "C"ness makes me like functions that have clear return > types!) But I am happy with the change too. I agree with

[PATCH v2 4/6] emacs: add optional predicate arg to `notmuch-show-mapc'

2012-10-15 Thread Ethan Glasser-Camp
Mark Walters writes: > The original function feels a little fragile to me as to what happens if > predicate or function move point. Eg what happens if function collapses > the message: where does point go, and so where does > notmuch-show-goto-message-next go. Is this just my naivete as a lisp >

[PATCH v2 4/6] emacs: add optional predicate arg to `notmuch-show-mapc'

2012-10-15 Thread Ethan Glasser-Camp
Pieter Praet writes: > * emacs/notmuch-show.el (notmuch-show-mapc): > > If provided with optional argument PREDICATE, only call > FUNCTION if calling PREDICATE returns non-nil. > > Also correct original docstring: 's/thread/buffer/'. > --- This patch was marked stale, but isn't. >

  1   2   3   >