[PATCH] configure: Fix syntax error (spaces in assignment).

2010-04-15 Thread Gregor Hoffleit
Before and after the assignment operator, no spaces are allowed. I don't know if there are any /bin/sh which allow spaces, but at least in bash, csh and zsh, the former code was no valid assigment. --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure

[PATCH] configure: Fix syntax error (spaces in assignment).

2010-04-15 Thread Gregor Hoffleit
Before and after the assignment operator, no spaces are allowed. I don't know if there are any /bin/sh which allow spaces, but at least in bash, csh and zsh, the former code was no valid assigment. --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure

[PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-13 Thread Gregor Hoffleit
The test suite doesn't yet cover --format=json output nor UTF-8 in subject or body. This patch starts with test cases for 'search --format=json' and 'show --format=json'. Furthermore, it has test cases for a search for a UTF-8 string in a mail body for a UTF-8 string in a mail subject. Finally,

[PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-13 Thread Gregor Hoffleit
The test suite doesn't yet cover --format=json output nor UTF-8 in subject or body. This patch starts with test cases for 'search --format=json' and 'show --format=json'. Furthermore, it has test cases for a search for a UTF-8 string in a mail body for a UTF-8 string in a mail subject. Finally,

[notmuch] [PATCH] format_part_json: part_content->data is not null terminated

2010-04-01 Thread Gregor Hoffleit
t->len); +content_data[part_content->len] = 0; Should I submit a fixed patch? Mea culpa, Gregor * David Edmondson [Do Apr 01 13:50:54 +0200 2010] > On Thu, 01 Apr 2010 08:40:37 -0300, David Bremner > wrote: > > On Thu, 04 Mar 2010 11:49:48 +0100, Gre

Re: [notmuch] [PATCH] format_part_json: part_content-data is not null terminated

2010-04-01 Thread Gregor Hoffleit
); +content_data[part_content-len] = 0; Should I submit a fixed patch? Mea culpa, Gregor * David Edmondson d...@dme.org [Do Apr 01 13:50:54 +0200 2010] On Thu, 01 Apr 2010 08:40:37 -0300, David Bremner da...@tethera.net wrote: On Thu, 04 Mar 2010 11:49:48 +0100, Gregor Hoffleit gre...@hoffleit.de

[notmuch] [PATCH] json_quote_str should handle non-ASCII characters

2010-03-04 Thread Gregor Hoffleit
* Sebastian Spaeth [Do M?r 04 14:57:27 +0100 2010] > On 2010-03-04, Sebastian Spaeth wrote: > > The current code in json_quote_str() only accepts strict printable ASCII > > code points (i.e. 32-127), all other code points are dropped from the > > JSON output. > > That would explain why my web

[notmuch] [PATCH] format_part_json: part_content->data is not null terminated

2010-03-04 Thread Gregor Hoffleit
In format_part_json, part_content->data is not a null terminated string. Instead, we have to use part_content->len. --- notmuch-show.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 1a1d601..4b755e9 100644 --- a/notmuch-show.c

[notmuch] [PATCH] json_quote_str should handle non-ASCII characters

2010-03-04 Thread Gregor Hoffleit
The current code in json_quote_str() only accepts strict printable ASCII code points (i.e. 32-127), all other code points are dropped from the JSON output. This patch accepts code points 32-255. json_quote_str() should handle non-ASCII characters. --- json.c |4 ++-- 1 files changed, 2

Re: [notmuch] [PATCH] json_quote_str should handle non-ASCII characters

2010-03-04 Thread Gregor Hoffleit
* Sebastian Spaeth sebast...@sspaeth.de [Do Mär 04 14:57:27 +0100 2010] On 2010-03-04, Sebastian Spaeth wrote: The current code in json_quote_str() only accepts strict printable ASCII code points (i.e. 32-127), all other code points are dropped from the JSON output. That would explain

[notmuch] Notmuch's search view sucks

2009-12-03 Thread Gregor Hoffleit
ve the polishing into the client (Yeah! Python to the rescue! ;-). But then, 'notmuch search' would need to return some raw representation of the date field as well. Any comment? Any other thoughts about this? Regards, Gregor Hoffleit