Tomi Ollila writes:
>but the bbdb-* looks a bit too generic (goes deep into bbdb "namespace"
>in a file not part of bbdb -package)
Good point. Stuff in notmuch should have a consistent prefix. Prefixes
are Emacs' module system, after all :-). (It could be `notmuch-bbdb-*'
or whatever, of
Tomi Ollila tomi.oll...@iki.fi writes:
but the bbdb-* looks a bit too generic (goes deep into bbdb namespace
in a file not part of bbdb -package)
Good point. Stuff in notmuch should have a consistent prefix. Prefixes
are Emacs' module system, after all :-). (It could be `notmuch-bbdb-*'
or
Sebastian Lipp writes:
>> I think it's good to include an initial value (even an invalid
>> placeholder one, if the real initialization has not happened yet), and a
>> doc string. C-h f defvar RET will say more about how to do that.
>
>I hope I got that right now. (I've got no real clue of Lisp
Sebastian Lipp writes:
>Karl Fogel
>> In general, supplying a log message with the patch with avoid such
>> confusion. If there is some prose expressing what the change is
>> supposed to to, and giving any historical context (such as the mailing
>> list thr
Sebastian Lipp ba...@riseup.net writes:
I think it's good to include an initial value (even an invalid
placeholder one, if the real initialization has not happened yet), and a
doc string. C-h f defvar RET will say more about how to do that.
I hope I got that right now. (I've got no real clue
Sebastian Lipp writes:
>No, it happened by intention because what is "original" to you is not
>part of my freshly cloned notmuch. So I thought good practise is to
>construct *one* patch that brings the already fixed feature to the
>notmuch codebase to keep it clean.
>
>If you like better, my next
Sebastian Lipp ba...@riseup.net writes:
No, it happened by intention because what is original to you is not
part of my freshly cloned notmuch. So I thought good practise is to
construct *one* patch that brings the already fixed feature to the
notmuch codebase to keep it clean.
If you like better,
Sebastian Lipp ba...@riseup.net writes:
Tomi Ollila tomi.oll...@iki.fi writes:
On Tue, Apr 09 2013, David Bremner wrote:
There seems to be a few warnings:
In notmuch-bbdb/snarf-from:
notmuch-address.el:116:26:Warning: reference to free variable
`bbdb-get-addresses-headers'
In
Sebastian Lipp writes:
>Tomi Ollila writes:
>> On Tue, Apr 09 2013, David Bremner wrote:
>>> There seems to be a few warnings:
>>>
>>> In notmuch-bbdb/snarf-from:
>>> notmuch-address.el:116:26:Warning: reference to free variable
>>> `bbdb-get-addresses-headers'
>>>
>>> In
David Bremner da...@tethera.net writes:
Karl Fogel kfo...@red-bean.com writes:
This patch fixes a trivial missing-paren problem in notmuch-address.el
(and reindents the following defun accordingly). I'm not subscribed
to this list, so please keep me CC'd on any followups.
Dear Karl;
Thanks
David Bremner writes:
>Karl Fogel writes:
>> This patch fixes a trivial missing-paren problem in notmuch-address.el
>> (and reindents the following defun accordingly). I'm not subscribed
>> to this list, so please keep me CC'd on any followups.
>
>Dear Karl;
>
&
This patch fixes a trivial missing-paren problem in notmuch-address.el
(and reindents the following defun accordingly). I'm not subscribed
to this list, so please keep me CC'd on any followups.
Best,
-Karl
From 4c74ad313f608f0834961c63c70d1f811ef103b7 Mon Sep 17 00:00:00 2001
From: Karl Fogel
This patch fixes a trivial missing-paren problem in notmuch-address.el
(and reindents the following defun accordingly). I'm not subscribed
to this list, so please keep me CC'd on any followups.
Best,
-Karl
-- next part --
A non-text attachment was scrubbed...
Name:
13 matches
Mail list logo
