[PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

2012-03-07 Thread Pieter Praet
On Thu, 01 Mar 2012 08:36:33 -0400, David Bremner wrote: > > Pushed, finally. Thanks for both of your hard work on this. > 625 lines changed (425 added, 200 removed), in a *single* commit ? It's a useful bit of functionality which definitely deserves to be included, and I do recognize and

plans for 0.12

2012-03-07 Thread Pieter Praet
On Thu, 01 Mar 2012 18:43:50 -0400, David Bremner wrote: > On Thu, 01 Mar 2012 22:21:29 +0100, Pieter Praet wrote: > > > > Some of the features added/refactored post-0.11.1 don't have any > > test coverage yet. Should they, before wrapping up 0.12 ? > > (not

[PATCH v4] test: emacs: new test "notmuch-search: change tags of all matching messages"

2012-03-07 Thread Pieter Praet
* test/emacs-search: - New subtest "notmuch-search: change tags of all matching messages": `notmuch-search-tag-all' (bound to "*") adds and removes tags to/from all messages which match the query used to populate the current search buffer. --- Moved to a separate file to prevent a

[PATCH v4] test: emacs: new test notmuch-search: change tags of all matching messages

2012-03-07 Thread Pieter Praet
* test/emacs-search: - New subtest notmuch-search: change tags of all matching messages: `notmuch-search-tag-all' (bound to *) adds and removes tags to/from all messages which match the query used to populate the current search buffer. --- Moved to a separate file to prevent a

[PATCH] NEWS: add entry for `notmuch-show-stash-mlarchive-link{, -and-go}'

2012-03-01 Thread Pieter Praet
--- NEWS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 8fb2f24..a739914 100644 --- a/NEWS +++ b/NEWS @@ -80,6 +80,12 @@ Attachment buttons can be used to view or save attachments. button 1 saves the attachment but this is customisable (option

plans for 0.12

2012-03-01 Thread Pieter Praet
On Sat, 25 Feb 2012 10:27:02 -0400, David Bremner wrote: > > I would like to start a freeze (i.e. merge master to release) for 0.12 > within the next week, say March 1 for an easy to remember date. > > If you have suggestions for things that "should really go in", feel free > to follow up. The

[PATCH] emacs: Mention race condition safety in user visible documentation

2012-03-01 Thread Pieter Praet
On Wed, 29 Feb 2012 22:49:46 -0400, David Bremner wrote: > On Tue, 21 Feb 2012 10:15:08 +0100, Michal Sojka > wrote: > > -- >8 -- > > Subject: [PATCH] emacs: Clarify description of thread manipulating functions > > > > It is not clear whether the term "thread" refers to the thread in the > >

[PATCH v6 1/3] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

2012-03-01 Thread Pieter Praet
On Wed, 29 Feb 2012 08:19:34 -0400, David Bremner wrote: > On Tue, 28 Feb 2012 19:40:04 +0100, Pieter Praet wrote: > > > > Though I couldn't help but notice (it's a curse...) that patch #3 > > seems to have gained an extra space in its commit message subject: > > >

Re: [PATCH v6 1/3] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

2012-03-01 Thread Pieter Praet
On Wed, 29 Feb 2012 08:19:34 -0400, David Bremner da...@tethera.net wrote: On Tue, 28 Feb 2012 19:40:04 +0100, Pieter Praet pie...@praet.org wrote: Though I couldn't help but notice (it's a curse...) that patch #3 seems to have gained an extra space in its commit message subject

Re: [PATCH] emacs: Mention race condition safety in user visible documentation

2012-03-01 Thread Pieter Praet
On Wed, 29 Feb 2012 22:49:46 -0400, David Bremner da...@tethera.net wrote: On Tue, 21 Feb 2012 10:15:08 +0100, Michal Sojka sojk...@fel.cvut.cz wrote: -- 8 -- Subject: [PATCH] emacs: Clarify description of thread manipulating functions It is not clear whether the term thread refers to

Re: plans for 0.12

2012-03-01 Thread Pieter Praet
On Sat, 25 Feb 2012 10:27:02 -0400, David Bremner da...@tethera.net wrote: I would like to start a freeze (i.e. merge master to release) for 0.12 within the next week, say March 1 for an easy to remember date. If you have suggestions for things that should really go in, feel free to follow

[PATCH] NEWS: add entry for `notmuch-show-stash-mlarchive-link{, -and-go}'

2012-03-01 Thread Pieter Praet
--- NEWS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 8fb2f24..a739914 100644 --- a/NEWS +++ b/NEWS @@ -80,6 +80,12 @@ Attachment buttons can be used to view or save attachments. button 1 saves the attachment but this is customisable (option

[PATCH] doc: minor corrections in notmuch-config.1

2012-02-28 Thread Pieter Praet
On Tue, 28 Feb 2012 21:33:24 +0200, Jani Nikula wrote: > On Tue, 28 Feb 2012 19:42:03 +0100, Pieter Praet wrote: > > * man/man1/notmuch-config.1 > > > > - SYNOPSIS: > > Remove spaces in 'section.item' arg, and indicate that > > `notmuch config

[PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-28 Thread Pieter Praet
On Mon, 27 Feb 2012 16:50:53 +0200, Tomi Ollila wrote: > On Sat, 25 Feb 2012 12:20:31 -0400, David Bremner > wrote: > > On Fri, 24 Feb 2012 00:07:27 +0100, Pieter Praet > > wrote: > > > On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner > > > wrote: > &

[PATCH] man: document the notmuch configuration settings in notmuch-config(1)

2012-02-28 Thread Pieter Praet
On Sun, 26 Feb 2012 00:23:41 +0200, Jani Nikula wrote: > At the risk of duplication between the man page and the configuration > file generated by default, document the notmuch configuration options > in the notmuch config man page. > > Existing users of notmuch should not be expected to

[PATCH] doc: minor corrections in notmuch-config.1

2012-02-28 Thread Pieter Praet
* man/man1/notmuch-config.1 - SYNOPSIS: Remove spaces in 'section.item' arg, and indicate that `notmuch config set' accepts multiple value args. - DESCRIPTION: Correct config option to exclude tags from search results. ('search.exclude_tags' instead of 'search.exclude') Also

[PATCH v6 1/3] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

2012-02-28 Thread Pieter Praet
On Sat, 25 Feb 2012 10:40:25 -0400, David Bremner wrote: > On Sun, 19 Feb 2012 21:50:25 +0100, Pieter Praet wrote: > > * emacs/notmuch-show.el > > > > (notmuch-show-get-message-id): > > Add optional arg BARE. When non-nil, return a Message-Id without >

[PATCH] emacs: Mention race condition safety in user visible documentation

2012-02-28 Thread Pieter Praet
On Sat, 18 Feb 2012 23:44:18 +0100, Michal Sojka wrote: > After recent rework of a/A/x/X key bindings, the important paragraph in > documentation of `notmuch-show-archive-thread' stayed hidden from users, > because no key is bound to this function. > > This patch copies the important paragraph

Re: [PATCH v6 1/3] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

2012-02-28 Thread Pieter Praet
On Sat, 25 Feb 2012 10:40:25 -0400, David Bremner da...@tethera.net wrote: On Sun, 19 Feb 2012 21:50:25 +0100, Pieter Praet pie...@praet.org wrote: * emacs/notmuch-show.el (notmuch-show-get-message-id): Add optional arg BARE. When non-nil, return a Message-Id without quotes

[PATCH] doc: minor corrections in notmuch-config.1

2012-02-28 Thread Pieter Praet
* man/man1/notmuch-config.1 - SYNOPSIS: Remove spaces in 'section.item' arg, and indicate that `notmuch config set' accepts multiple value args. - DESCRIPTION: Correct config option to exclude tags from search results. ('search.exclude_tags' instead of 'search.exclude') Also

Re: [PATCH] man: document the notmuch configuration settings in notmuch-config(1)

2012-02-28 Thread Pieter Praet
On Sun, 26 Feb 2012 00:23:41 +0200, Jani Nikula j...@nikula.org wrote: At the risk of duplication between the man page and the configuration file generated by default, document the notmuch configuration options in the notmuch config man page. Existing users of notmuch should not be expected

Re: [PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-28 Thread Pieter Praet
On Mon, 27 Feb 2012 16:50:53 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Sat, 25 Feb 2012 12:20:31 -0400, David Bremner da...@tethera.net wrote: On Fri, 24 Feb 2012 00:07:27 +0100, Pieter Praet pie...@praet.org wrote: On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner da...@tethera.net

Re: [PATCH] doc: minor corrections in notmuch-config.1

2012-02-28 Thread Pieter Praet
On Tue, 28 Feb 2012 21:33:24 +0200, Jani Nikula j...@nikula.org wrote: On Tue, 28 Feb 2012 19:42:03 +0100, Pieter Praet pie...@praet.org wrote: * man/man1/notmuch-config.1 - SYNOPSIS: Remove spaces in 'section.item' arg, and indicate that `notmuch config set' accepts multiple

[PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-25 Thread Pieter Praet
On Fri, 24 Feb 2012 23:38:20 +0100, Pieter Praet wrote: > [...] > Same here. In v2 [1], '*' tags all and 'C-u *' tags only open. > > One can always swap the keybindings if so inclined. > Did I really say that? There's only a single keybinding, so swap it with *what* ?!? Itself

[PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 14:33:35 +0400, Dmitry Kurochkin wrote: > On Fri, 24 Feb 2012 14:30:29 +0400, Dmitry Kurochkin gmail.com> wrote: > > On Fri, 24 Feb 2012 00:07:27 +0100, Pieter Praet > > wrote: > > > On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner > >

[PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 14:30:29 +0400, Dmitry Kurochkin wrote: > On Fri, 24 Feb 2012 00:07:27 +0100, Pieter Praet wrote: > > On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner > > wrote: > > > On Sun, 5 Feb 2012 11:13:41 +0400, Dmitry Kurochkin > > gma

[PATCH 6/6] emacs: `notmuch-show-tag-all' sans prefix arg only tags open messages

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 14:47:30 +0400, Dmitry Kurochkin wrote: > On Fri, 24 Feb 2012 00:09:14 +0100, Pieter Praet wrote: > > * emacs/notmuch-show.el > > > > (notmuch-show-get-messages-ids): > > New optional argument ONLY-OPEN. If non-nil, only return > >

[PATCH 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 14:42:53 +0400, Dmitry Kurochkin wrote: > On Fri, 24 Feb 2012 00:09:13 +0100, Pieter Praet wrote: > > * emacs/notmuch-show.el > > > > (notmuch-show-get-messages-ids): > > If provided with optional arg SEPARATOR, return a string consisting

[PATCH 4/6] emacs: add predicate arg to `notmuch-show-mapc'

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 14:39:41 +0400, Dmitry Kurochkin wrote: > On Fri, 24 Feb 2012 00:09:12 +0100, Pieter Praet wrote: > > * emacs/notmuch-show.el > > > > (notmuch-show-mapc): > > Only call FUNCTION if new argument PREDICATE is satisfied. > > Also corr

[PATCH 1/6] test: emacs: new tests "notmuch-show: {add, remove} multiple tags {to, from} single message"

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 14:35:22 +0400, Dmitry Kurochkin wrote: > On Fri, 24 Feb 2012 00:09:09 +0100, Pieter Praet wrote: > > * test/emacs: > > > > - Rename subtests "{Add,Remove} tag from notmuch-show view" to > > "notmuch-show: {add,r

[PATCH v2 6/6] emacs: `notmuch-show-tag-all' with prefix arg only tags open messages

2012-02-24 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-get-messages-ids): If provided with optional argument PREDICATE, only return Message-Id's of messages for which PREDICATE returns non-nil. (notmuch-show-tag-all): New argument ONLY-OPEN (set to `current-prefix-arg' if running

[PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

2012-02-24 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-get-messages-ids): If provided with optional arg SEPARATOR, return a string consisting of all Message-Id's, separated by SEPARATOR. Also improve original docstring wrt default return value. (notmuch-show-get-messages-ids-search):

[PATCH v2 4/6] emacs: add optional predicate arg to `notmuch-show-mapc'

2012-02-24 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-mapc): If provided with optional argument PREDICATE, only call FUNCTION if calling PREDICATE returns non-nil. Also correct original docstring: 's/thread/buffer/'. --- emacs/notmuch-show.el | 14 ++ 1 files changed, 10 insertions(+), 4

[PATCH v2 3/6] test: emacs: `notmuch-show-tag-all' with prefix arg should only tag open messages

2012-02-24 Thread Pieter Praet
* test/emacs: - New subtest "notmuch-show: change tags of open messages in current buffer": When called with a prefix arg, `notmuch-show-tag-all' ("*") should only change the tags of *open* messages. Currently broken, fix follows later. --- test/emacs | 16 1 files

[PATCH v2 2/6] test: emacs: new test "notmuch-show: change tags of all messages in current buffer"

2012-02-24 Thread Pieter Praet
* test/emacs: New subtest "notmuch-show: change tags of all messages in current buffer": `notmuch-show-tag-all' ("*") changes tags of *all* messages in current buffer. --- test/emacs | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/test/emacs

[PATCH v2 1/6] test: emacs: new tests "notmuch-show: {add, remove} multiple tags {to, from} single message"

2012-02-24 Thread Pieter Praet
* test/emacs: - Rename subtests "{Add,Remove} tag from notmuch-show view" to "notmuch-show: {add,remove} single tag {to,from} single message" to be consistent with the following tests. - New subtest "notmuch-show: add multiple tags to single message": `notmuch-show-add-tag' ("+")

[PATCH v2 0/6] `notmuch-show-tag-all' with prefix arg only tags open messages

2012-02-24 Thread Pieter Praet
Addresses Dmitry's comments [1,2,3], save for the ones that aren't directly related to this series [4,5] and will be dealt with later. Also made `notmuch-show-tag-all's ONLY-OPEN arg non-optional. Otherwise it would cause issues when running non-interactively. Peace -- Pieter [1]

[PATCH 6/6] emacs: `notmuch-show-tag-all' sans prefix arg only tags open messages

2012-02-24 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-get-messages-ids): New optional argument ONLY-OPEN. If non-nil, only return Message-Id's for messages which are currently visible. (notmuch-show-tag-all): New optional argument IGNORE-VISIBILITY, of which the inverse is passed as

[PATCH 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

2012-02-24 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-get-messages-ids): If provided with optional arg SEPARATOR, return a string consisting of all Message-Id's, separated by SEPARATOR. Also improve original docstring wrt default return value. (notmuch-show-get-messages-ids-search):

[PATCH 4/6] emacs: add predicate arg to `notmuch-show-mapc'

2012-02-24 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-mapc): Only call FUNCTION if new argument PREDICATE is satisfied. Also correct original docstring: 's/thread/buffer/'. (notmuch-show-get-messages-ids): Update wrt changes to `notmuch-show-mapc'. (notmuch-show-tag-all): Update wrt

[PATCH 3/6] test: emacs: `notmuch-show-tag-all' sans prefix arg should only tag open messages

2012-02-24 Thread Pieter Praet
* test/emacs: - Alter subtest "notmuch-show: change tags of all messages in current buffer": Pass a prefix arg to `notmuch-show-tag-all' ("*"). - New subtest "notmuch-show: change tags of open messages in current buffer": When called *without* a prefix arg, `notmuch-show-tag-all'

[PATCH 2/6] test: emacs: new test "notmuch-show: change tags of all messages in current buffer"

2012-02-24 Thread Pieter Praet
* test/emacs: New subtest "notmuch-show: change tags of all messages in current buffer": `notmuch-show-tag-all' ("*") changes tags of *all* messages in current buffer. --- test/emacs | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/test/emacs

[PATCH 1/6] test: emacs: new tests "notmuch-show: {add, remove} multiple tags {to, from} single message"

2012-02-24 Thread Pieter Praet
* test/emacs: - Rename subtests "{Add,Remove} tag from notmuch-show view" to "notmuch-show: {add,remove} single tag {to,from} single message" to be consistent with the following tests. - New subtest "notmuch-show: add multiple tags to single message": `notmuch-show-add-tag' ("+")

[PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-24 Thread Pieter Praet
On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner wrote: > On Sun, 5 Feb 2012 11:13:41 +0400, Dmitry Kurochkin gmail.com> wrote: > > Changes: > > > > v4: > > > > * rebased on master, no conflicts so no need for another review > > > > I pushed this series. > > Maybe this was discussed

[PATCH v2 0/6] `notmuch-show-tag-all' with prefix arg only tags open messages

2012-02-24 Thread Pieter Praet
Addresses Dmitry's comments [1,2,3], save for the ones that aren't directly related to this series [4,5] and will be dealt with later. Also made `notmuch-show-tag-all's ONLY-OPEN arg non-optional. Otherwise it would cause issues when running non-interactively. Peace -- Pieter [1]

[PATCH v2 2/6] test: emacs: new test notmuch-show: change tags of all messages in current buffer

2012-02-24 Thread Pieter Praet
* test/emacs: New subtest notmuch-show: change tags of all messages in current buffer: `notmuch-show-tag-all' (*) changes tags of *all* messages in current buffer. --- test/emacs | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs

[PATCH v2 3/6] test: emacs: `notmuch-show-tag-all' with prefix arg should only tag open messages

2012-02-24 Thread Pieter Praet
* test/emacs: - New subtest notmuch-show: change tags of open messages in current buffer: When called with a prefix arg, `notmuch-show-tag-all' (*) should only change the tags of *open* messages. Currently broken, fix follows later. --- test/emacs | 16 1 files

[PATCH v2 4/6] emacs: add optional predicate arg to `notmuch-show-mapc'

2012-02-24 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-mapc): If provided with optional argument PREDICATE, only call FUNCTION if calling PREDICATE returns non-nil. Also correct original docstring: 's/thread/buffer/'. --- emacs/notmuch-show.el | 14 ++ 1 files changed, 10 insertions(+), 4

[PATCH v2 6/6] emacs: `notmuch-show-tag-all' with prefix arg only tags open messages

2012-02-24 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-get-messages-ids): If provided with optional argument PREDICATE, only return Message-Id's of messages for which PREDICATE returns non-nil. (notmuch-show-tag-all): New argument ONLY-OPEN (set to `current-prefix-arg' if running

[PATCH v2 1/6] test: emacs: new tests notmuch-show: {add, remove} multiple tags {to, from} single message

2012-02-24 Thread Pieter Praet
* test/emacs: - Rename subtests {Add,Remove} tag from notmuch-show view to notmuch-show: {add,remove} single tag {to,from} single message to be consistent with the following tests. - New subtest notmuch-show: add multiple tags to single message: `notmuch-show-add-tag' (+) can add

Re: [PATCH 1/6] test: emacs: new tests notmuch-show: {add, remove} multiple tags {to, from} single message

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 14:35:22 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Fri, 24 Feb 2012 00:09:09 +0100, Pieter Praet pie...@praet.org wrote: * test/emacs: - Rename subtests {Add,Remove} tag from notmuch-show view to notmuch-show: {add,remove} single tag {to,from

Re: [PATCH 4/6] emacs: add predicate arg to `notmuch-show-mapc'

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 14:39:41 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Fri, 24 Feb 2012 00:09:12 +0100, Pieter Praet pie...@praet.org wrote: * emacs/notmuch-show.el (notmuch-show-mapc): Only call FUNCTION if new argument PREDICATE is satisfied. Also

Re: [PATCH 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 14:42:53 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Fri, 24 Feb 2012 00:09:13 +0100, Pieter Praet pie...@praet.org wrote: * emacs/notmuch-show.el (notmuch-show-get-messages-ids): If provided with optional arg SEPARATOR, return a string

Re: [PATCH 6/6] emacs: `notmuch-show-tag-all' sans prefix arg only tags open messages

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 14:47:30 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Fri, 24 Feb 2012 00:09:14 +0100, Pieter Praet pie...@praet.org wrote: * emacs/notmuch-show.el (notmuch-show-get-messages-ids): New optional argument ONLY-OPEN. If non-nil, only return

Re: [PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 14:30:29 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Fri, 24 Feb 2012 00:07:27 +0100, Pieter Praet pie...@praet.org wrote: On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner da...@tethera.net wrote: On Sun, 5 Feb 2012 11:13:41 +0400, Dmitry Kurochkin

Re: [PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 14:33:35 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Fri, 24 Feb 2012 14:30:29 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Fri, 24 Feb 2012 00:07:27 +0100, Pieter Praet pie...@praet.org wrote: On Wed, 08 Feb 2012 11:58:32 -0400, David

Re: [PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-24 Thread Pieter Praet
On Fri, 24 Feb 2012 23:38:20 +0100, Pieter Praet pie...@praet.org wrote: [...] Same here. In v2 [1], '*' tags all and 'C-u *' tags only open. One can always swap the keybindings if so inclined. Did I really say that? There's only a single keybinding, so swap it with *what* ?!? Itself

Re: [PATCH v5 00/12] emacs: more flexible and consistent tagging operations

2012-02-23 Thread Pieter Praet
On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner da...@tethera.net wrote: On Sun, 5 Feb 2012 11:13:41 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Changes: v4: * rebased on master, no conflicts so no need for another review I pushed this series. Maybe this

[PATCH 1/6] test: emacs: new tests notmuch-show: {add, remove} multiple tags {to, from} single message

2012-02-23 Thread Pieter Praet
* test/emacs: - Rename subtests {Add,Remove} tag from notmuch-show view to notmuch-show: {add,remove} single tag {to,from} single message to be consistent with the following tests. - New subtest notmuch-show: add multiple tags to single message: `notmuch-show-add-tag' (+) can add

[PATCH 2/6] test: emacs: new test notmuch-show: change tags of all messages in current buffer

2012-02-23 Thread Pieter Praet
* test/emacs: New subtest notmuch-show: change tags of all messages in current buffer: `notmuch-show-tag-all' (*) changes tags of *all* messages in current buffer. --- test/emacs | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs

[PATCH 3/6] test: emacs: `notmuch-show-tag-all' sans prefix arg should only tag open messages

2012-02-23 Thread Pieter Praet
* test/emacs: - Alter subtest notmuch-show: change tags of all messages in current buffer: Pass a prefix arg to `notmuch-show-tag-all' (*). - New subtest notmuch-show: change tags of open messages in current buffer: When called *without* a prefix arg, `notmuch-show-tag-all' (*)

[PATCH 6/6] emacs: `notmuch-show-tag-all' sans prefix arg only tags open messages

2012-02-23 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-get-messages-ids): New optional argument ONLY-OPEN. If non-nil, only return Message-Id's for messages which are currently visible. (notmuch-show-tag-all): New optional argument IGNORE-VISIBILITY, of which the inverse is passed as

[PATCH] emacs: correct `notmuch-search-mode's docstring wrt `notmuch-search-tag-all'

2012-02-22 Thread Pieter Praet
* emacs/notmuch.el (notmuch-search-mode): `notmuch-search-tag-all' currently uses the current query string instead of `notmuch-search-find-thread-id-region-search', which might cause a race condition. --- emacs/notmuch.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff

[PATCH] emacs: Mention race condition safety in user visible documentation

2012-02-22 Thread Pieter Praet
On Tue, 21 Feb 2012 10:15:08 +0100, Michal Sojka wrote: > [...] > OK, at least one supporter here :) The updated patch follows: > > -- >8 -- > Subject: [PATCH] emacs: Clarify description of thread manipulating functions > > It is not clear whether the term "thread" refers to the thread in the >

[PATCH v3 0/3] Fix refreshing with state and make it the default

2012-02-22 Thread Pieter Praet
On Tue, 21 Feb 2012 10:42:30 -0500, Austin Clements wrote: > Third time's the charm. This fixes show refresh to not mark anything > read when keeping state while refreshing and makes it the default. > LGTM. Peace -- Pieter

[PATCH v3] test: emacs: new test "notmuch-search: change tags of all matching messages"

2012-02-22 Thread Pieter Praet
`notmuch-search-tag-all' (bound to "*") adds and removes tags to/from all messages which match the query used to populate the current search buffer. --- test/emacs | 38 ++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a/test/emacs

[PATCH v2 4/4] test: emacs: new test "notmuch-search: change tags of all matching messages"

2012-02-22 Thread Pieter Praet
On Mon, 20 Feb 2012 16:25:05 +0400, Dmitry Kurochkin wrote: > On Sun, 19 Feb 2012 21:38:28 +0100, Pieter Praet wrote: > > `notmuch-search-tag-all' (bound to "*") adds and removes tags > > to/from all messages which match the query used to populate the > > c

[PATCH v2 4/4] test: emacs: new test "notmuch-search: change tags of all matching messages"

2012-02-22 Thread Pieter Praet
On Sun, 19 Feb 2012 23:08:30 +0200, Tomi Ollila wrote: > On Sun, 19 Feb 2012 21:38:28 +0100, Pieter Praet wrote: > > `notmuch-search-tag-all' (bound to "*") adds and removes tags > > to/from all messages which match the query used to populate the > > current s

[PATCH v2 3/4] test: emacs: new test "notmuch-search: when reply is sent, parent message should be tagged 'replied'"

2012-02-22 Thread Pieter Praet
On Mon, 20 Feb 2012 16:20:28 +0400, Dmitry Kurochkin wrote: > On Sun, 19 Feb 2012 21:38:27 +0100, Pieter Praet wrote: > > When a message is replied to, it should be tagged `replied'. > > --- > > test/emacs |5 + > > 1 files changed, 5 insertions(+), 0 delet

[PATCH v2 2/4] test: emacs: new test "notmuch-search: replying to a thread (sending)"

2012-02-22 Thread Pieter Praet
On Mon, 20 Feb 2012 16:44:32 +0400, Dmitry Kurochkin wrote: > On Sun, 19 Feb 2012 21:38:26 +0100, Pieter Praet wrote: > > As pointed out in the previous commit, the test for replying from > > within Emacs didn't actually submit the reply. This one does. > > --- &

[PATCH v2 2/4] test: emacs: new test "notmuch-search: replying to a thread (sending)"

2012-02-22 Thread Pieter Praet
On Sun, 19 Feb 2012 23:04:38 +0200, Tomi Ollila wrote: > On Sun, 19 Feb 2012 21:38:26 +0100, Pieter Praet wrote: > > As pointed out in the previous commit, the test for replying from > > within Emacs didn't actually submit the reply. This one does. > > --- &

[PATCH v2 7/7] emacs: `notmuch-show-toggle-visibility-messages' with prefix arg filters by tag

2012-02-22 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-toggle-visibility-messages): When provided with a prefix arg, prompt the user for a tag. Show all messages that have it and hide those that don't. --- emacs/notmuch-show.el | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff

[PATCH v2 6/7] emacs: make `notmuch-show-toggle-visibility-messages' live up to its new name

2012-02-22 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-toggle-visibility-messages): Toggle visibility of all messages in current thread based on visibility of the current message, instead of setting visibility based on whether or not a prefix arg was supplied. Also move current buffer line to the 2nd

[PATCH v2 5/7] emacs: rename `notmuch-show-open-or-close-all' to `notmuch-show-toggle-visibility-messages'

2012-02-22 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-open-or-close-all): Rename to `notmuch-show-toggle-visibility-messages'. (notmuch-show-mode-map): Update "M-RET" binding wrt renamed `notmuch-show-open-or-close-all'. * test/emacs: Update subtests wrt renamed `notmuch-show-open-or-close-all':

[PATCH v2 4/7] emacs: rename `notmuch-show-toggle-message' to `notmuch-show-toggle-visibility-message'

2012-02-22 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-toggle-message): Rename to `notmuch-show-toggle-visibility-message'. (notmuch-show-mode-map): Update "RET" binding wrt renamed `notmuch-show-toggle-message'. * test/emacs: Update subtests wrt renamed `notmuch-show-toggle-message': - "Hiding

[PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'

2012-02-22 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-toggle-headers): Rename to `notmuch-show-toggle-visibility-headers'. (notmuch-show-mode-map): Update "h" binding wrt renamed `notmuch-show-toggle-headers'. (notmuch-message-headers): Update docstring wrt renamed

[PATCH v2 2/7] test: emacs: new tests "notmuch-show: {, un}collapse all messages in thread"

2012-02-22 Thread Pieter Praet
* test/emacs: - New subtest "notmuch-show: collapse all messages in thread": `notmuch-show-open-or-close-all' with prefix arg ("C-u M-RET") collapses all messages in thread. - New subtest "notmuch-show: uncollapse all messages in thread": `notmuch-show-open-or-close-all' without

[PATCH v2 1/7] test: emacs: new tests "notmuch-show: {show, hide} message headers"

2012-02-22 Thread Pieter Praet
* test/emacs: - New subtest "notmuch-show: show message headers": Setting `notmuch-message-headers-visible' to t causes all headers defined in `notmuch-message-headers' to be shown. - New subtest "notmuch-show: hide message headers": Setting `notmuch-message-headers-visible' to

[PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility

2012-02-22 Thread Pieter Praet
On Mon, 13 Feb 2012 14:51:17 +0400, Dmitry Kurochkin wrote: > Hi Pieter. > > On Wed, 25 Jan 2012 06:25:39 +0100, Pieter Praet wrote: > > * emacs/notmuch-show.el (notmuch-show-open-or-close-all): > > Rename to `notmuch-show-toggle-all-messages', and make it toggle &g

Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility

2012-02-22 Thread Pieter Praet
On Mon, 13 Feb 2012 14:51:17 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi Pieter. On Wed, 25 Jan 2012 06:25:39 +0100, Pieter Praet pie...@praet.org wrote: * emacs/notmuch-show.el (notmuch-show-open-or-close-all): Rename to `notmuch-show-toggle-all-messages', and make

[PATCH v2 2/7] test: emacs: new tests notmuch-show: {, un}collapse all messages in thread

2012-02-22 Thread Pieter Praet
* test/emacs: - New subtest notmuch-show: collapse all messages in thread: `notmuch-show-open-or-close-all' with prefix arg (C-u M-RET) collapses all messages in thread. - New subtest notmuch-show: uncollapse all messages in thread: `notmuch-show-open-or-close-all' without prefix

[PATCH v2 1/7] test: emacs: new tests notmuch-show: {show, hide} message headers

2012-02-22 Thread Pieter Praet
* test/emacs: - New subtest notmuch-show: show message headers: Setting `notmuch-message-headers-visible' to t causes all headers defined in `notmuch-message-headers' to be shown. - New subtest notmuch-show: hide message headers: Setting `notmuch-message-headers-visible' to nil

[PATCH v2 4/7] emacs: rename `notmuch-show-toggle-message' to `notmuch-show-toggle-visibility-message'

2012-02-22 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-toggle-message): Rename to `notmuch-show-toggle-visibility-message'. (notmuch-show-mode-map): Update RET binding wrt renamed `notmuch-show-toggle-message'. * test/emacs: Update subtests wrt renamed `notmuch-show-toggle-message': - Hiding

[PATCH v2 7/7] emacs: `notmuch-show-toggle-visibility-messages' with prefix arg filters by tag

2012-02-22 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-toggle-visibility-messages): When provided with a prefix arg, prompt the user for a tag. Show all messages that have it and hide those that don't. --- emacs/notmuch-show.el | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff

[PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'

2012-02-22 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-toggle-headers): Rename to `notmuch-show-toggle-visibility-headers'. (notmuch-show-mode-map): Update h binding wrt renamed `notmuch-show-toggle-headers'. (notmuch-message-headers): Update docstring wrt renamed

Re: [PATCH v2 2/4] test: emacs: new test notmuch-search: replying to a thread (sending)

2012-02-22 Thread Pieter Praet
On Sun, 19 Feb 2012 23:04:38 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Sun, 19 Feb 2012 21:38:26 +0100, Pieter Praet pie...@praet.org wrote: As pointed out in the previous commit, the test for replying from within Emacs didn't actually submit the reply. This one does. --- test

Re: [PATCH v2 2/4] test: emacs: new test notmuch-search: replying to a thread (sending)

2012-02-22 Thread Pieter Praet
On Mon, 20 Feb 2012 16:44:32 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Sun, 19 Feb 2012 21:38:26 +0100, Pieter Praet pie...@praet.org wrote: As pointed out in the previous commit, the test for replying from within Emacs didn't actually submit the reply. This one does

Re: [PATCH v2 4/4] test: emacs: new test notmuch-search: change tags of all matching messages

2012-02-22 Thread Pieter Praet
On Sun, 19 Feb 2012 23:08:30 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Sun, 19 Feb 2012 21:38:28 +0100, Pieter Praet pie...@praet.org wrote: `notmuch-search-tag-all' (bound to *) adds and removes tags to/from all messages which match the query used to populate the current search

[PATCH v3] test: emacs: new test notmuch-search: change tags of all matching messages

2012-02-22 Thread Pieter Praet
`notmuch-search-tag-all' (bound to *) adds and removes tags to/from all messages which match the query used to populate the current search buffer. --- test/emacs | 38 ++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs

Re: [PATCH] emacs: Mention race condition safety in user visible documentation

2012-02-22 Thread Pieter Praet
On Tue, 21 Feb 2012 10:15:08 +0100, Michal Sojka sojk...@fel.cvut.cz wrote: [...] OK, at least one supporter here :) The updated patch follows: -- 8 -- Subject: [PATCH] emacs: Clarify description of thread manipulating functions It is not clear whether the term thread refers to the thread

[PATCH] emacs: correct `notmuch-search-mode's docstring wrt `notmuch-search-tag-all'

2012-02-22 Thread Pieter Praet
* emacs/notmuch.el (notmuch-search-mode): `notmuch-search-tag-all' currently uses the current query string instead of `notmuch-search-find-thread-id-region-search', which might cause a race condition. --- emacs/notmuch.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff

[PATCH 3/3] test: emacs: toggle thread content indentation in `notmuch-show'

2012-02-19 Thread Pieter Praet
See commit c205e8ff. --- test/emacs |9 ++ .../notmuch-show-indent-thread-content-off | 79 2 files changed, 88 insertions(+), 0 deletions(-) create mode 100644

[PATCH 2/3] test: emacs: toggle eliding of non-matching messages in `notmuch-show'

2012-02-19 Thread Pieter Praet
See commits 44a544ed, 866ce8b1, 668b66ec. --- test/emacs | 38 ++ .../notmuch-show-elide-non-matching-messages-off | 79 .../notmuch-show-elide-non-matching-messages-on| 75 +++ 3 files changed, 192

[PATCH 1/3] test: emacs: toggle processing of cryptographic MIME parts in `notmuch-show'

2012-02-19 Thread Pieter Praet
See commit 19ec74c5. --- test/emacs | 20 .../notmuch-show-process-crypto-mime-parts-off | 31 +++ .../notmuch-show-process-crypto-mime-parts-on | 32 3 files changed, 83 insertions(+), 0

[PATCH v8 0/8] reworked crypto toggle, plus a few other toggles

2012-02-19 Thread Pieter Praet
Great work! Here's some tests. Peace

[PATCH] STYLE: Initial draft of coding style document

2012-02-19 Thread Pieter Praet
On Sun, 12 Feb 2012 21:42:49 -0400, David Bremner wrote: > On Sun, 5 Feb 2012 23:42:05 -0500, Austin Clements > wrote: > > > > Any indentation style this difficult to explain can't be a good idea. > > How about, > > > > * Indent is 4 spaces with mixed tab/spaces and a tab width of 8. > >

[PATCH 7/6] emacs: relax tag syntax check in `notmuch-tag' function

2012-02-19 Thread Pieter Praet
On Sat, 28 Jan 2012 10:56:21 +0200, Jani Nikula wrote: > On Jan 28, 2012 7:06 AM, "Dmitry Kurochkin" > wrote: > > > > The tag syntax check in `notmuch-tag' function was too strict and did > > not allow nmbug tags with "::". Since the check is done for all > > tagging operations in Emacs UI,

[PATCH v6 3/3] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

2012-02-19 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-stash-mlarchive-link-alist): New defcustom of type `alist' (key = name, value = URI), containing Mailing List Archive URI's for searching by Message-Id. (notmuch-show-stash-mlarchive-link-default): New defcustom, default MLA to use when

[PATCH v6 2/3] test: emacs: expand subtest "Stashing in notmuch-show" wrt stashing Mailing List Archive URIs

2012-02-19 Thread Pieter Praet
`notmuch-show-stash-mlarchive-link' stashes a URI pointing to the current message at one of the MLAs configured in `notmuch-show-stash-mlarchive-link-alist'. Marked as "broken": fixed in next commit. --- test/emacs |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git

[PATCH v6 1/3] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

2012-02-19 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-get-message-id): Add optional arg BARE. When non-nil, return a Message-Id without quotes and prefix, thus obviating the need to strip them off again in various places. (notmuch-show-stash-message-id-stripped): Update wrt changes in

  1   2   3   4   5   6   7   >