[PATCH] emacs: fix notmuch-show-update-tags to support duplicate files

2022-09-22 Thread Tomi Ollila
With duplicate files, the headerlines of messages in notmuch-show buffer contains (initially) 1/n at the end of line. Update the regexp used to search and replace tag changes to match the current line -- drop unnecessary capturing of the (tags), but capture the duplicates indicator. Update the

[PATCH] emacs: add notmuch-search-edit-search and notmuch-tree-edit-search

2022-09-18 Thread Tomi Ollila
...and bind these to "E" in their respective keymaps. Expected to be called interactively, then using read-from-minibuffer with current search string as initial contents for editing. (Noninteractive use makes little sense, but is supported.) With this one can expand (as an opposite to limit)

Re: [PATCH 1/2] test: compute expected keyid from fingerprint

2022-09-16 Thread Tomi Ollila
On Mon, Sep 12 2022, Daniel Kahn Gillmor wrote: > On Sun 2022-09-11 23:50:18 +0200, Justus Winter wrote: >> Tomi Ollila writes: >> >>> On Fri, Sep 09 2022, Justus Winter wrote: >>> >>>> --- >>>> test/T350-crypto.sh | 2 +- >>>>

Re: "-1 tests skipped"

2022-09-16 Thread Tomi Ollila
On Sun, Sep 11 2022, Daniel Kahn Gillmor wrote: > I'm running the test suite on notmuch master > (8eabd6388ecb7bea8246a9ba6943a0432d23406e), and i see the following > report: > > ``` > All 1758 tests behaved as expected (12 expected failures). > -1 tests skipped. > All tests in 2 files skipped. >

Re: [PATCH 1/2] test: compute expected keyid from fingerprint

2022-09-11 Thread Tomi Ollila
On Fri, Sep 09 2022, Justus Winter wrote: > --- > test/T350-crypto.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh > index 3c6626b4..721cbfdd 100755 > --- a/test/T350-crypto.sh > +++ b/test/T350-crypto.sh > @@ -467,7 +467,7 @@

Re: [PATCH] emacs/show: use read-shell-command instead of read-string

2022-08-31 Thread Tomi Ollila
On Tue, Aug 30 2022, Antoine Beaupré wrote: > This enables auto-completion of commands, something which plain > read-string does not do. It's otherwise a drop-in > replacement. According to `C-h f`, read-shell-command was introduced > in Emacs 23.1 or earlier. LGTM. Tomi > --- >

Re: [PATCH] emacs: new notmuch-tree-process-exit-functions

2022-08-21 Thread Tomi Ollila
On Sun, Aug 21 2022, j...@gnu.org wrote: > Hook run when the tree insertion process finishes its job. > > -- LGTM. I (also would have chosen this name instead of the *sentinel* one) Tomi > This patch supersedes , but > changing the new variable name. > > Right now, it can be used for silly

Re: [PATCH] emacs: new notmuch-tree-process-hook

2022-08-16 Thread Tomi Ollila
On Tue, Aug 16 2022, j...@gnu.org wrote: > Hook run when the tree insertion process finishes its job. > > -- > > Right now, it can be used for silly things like removing or changing > the the "End of search." hardcoded message in the tree buffer. But > also for more sophisticated things like

Re: [PATCH] test: increase cffi timeout

2022-08-15 Thread Tomi Ollila
On Sun, Aug 14 2022, michaeljgruber wrote: > From: Michael J Gruber > > By default, the test suite uses 2min for other tests and 5s for cffi > tests. Sporadically, this leads to test failures caused by the timeout > on slower or loaded test infrastructure (as seen on ppc64le in Fedora's >

Re: Embed elisp.py from flycheck, use it in notmuch-emacs doc

2022-08-10 Thread Tomi Ollila
On Sun, Jul 31 2022, David Bremner wrote: > After finding myself spending a while trying to re-create one of the > features [0] of the el sphinx domain used in flycheck, I decided to try > just converting the docs to use that sphinx extension. > > As I remarked in 2018 [1], there doesn't seem to

Re: [PATCH 2/2] emacs/show: restrict inlined mimetypes on refresh.

2022-08-10 Thread Tomi Ollila
On Mon, Aug 01 2022, David Bremner wrote: > This fixes the bug reported by Al [1]. Essentially apply the same fix > as [2] in a different place. > > [1]: id:877d41nmr1@gmail.com > [2]: 90a7c1af368a527700dcde9b0dcbd760afc7bd92 LGTM. Tomi > --- > emacs/notmuch-show.el | 1 + >

Re: [PATCH 6/9] test: Add test cases for new exclude option

2022-08-08 Thread Tomi Ollila
On Sun, Aug 07 2022, Mohsin Kaleem wrote: > --- > test/T461-emacs-search-exclude.sh | 99 +++ > .../notmuch-search-tag-inbox-with-excluded| 25 + > .../notmuch-search-tag-inbox-without-excluded | 21 > .../notmuch-tree-tag-inbox-with-excluded | 53

Re: Create tags from folders

2022-08-08 Thread Tomi Ollila
On Sun, Aug 07 2022, Notmuch mailinglist wrote: > Hello, > > I've managed to get mbsync, notmuch and neomutt all setup. But its now time > for fine tuning and tinkering. > My email is from Protonmail and I use sieve filters to organise my mail as > needed into folders. > Mbsync creates a folder

[PATCH] notmuch.c: add missing trailing newlines in two error messages

2022-07-31 Thread Tomi Ollila
Removed duplicate error check (and the message) in 3rd case where the same error message (w/o trailing newline) was present. In case of test/T040-setup.sh, command substitution deletes trailing newlines, so related test there cannot be changed (and therefore could not notice this user experience

Re: [PATCH v2] CLI/git: opportunistically use bindings to check for known messages

2022-07-16 Thread Tomi Ollila
On Fri, Jul 15 2022, David Bremner wrote: > If the bindings are installed, use them to avoid one exec of notmuch > search per message. tnx. continues to work for me where I have symlink to nmbug in ~/bin/. some time in the future i'll investigate whether i get python3 path/to/nmbug.zip ...

quoting: (was: Re: bug#56442: gnus-search-run-search: Hits notmuch command line length limits)

2022-07-09 Thread Tomi Ollila
On Sat, Jul 09 2022, Eric Abrahamsen wrote: > > Huh, I tried this a couple months ago with a more complicated query, > like: > > thread:{from:bob or from:jane} > > and I remember notmuch barking at me about spaces or the "or" or > something -- anyway I got the impression that it couldn't accept >

Re: [PATCH 4/4] CLI/git: replace calls to notmuch-search with database access

2022-07-07 Thread Tomi Ollila
On Sun, Jul 03 2022, David Bremner wrote: > This introduces a dependency on the (new) python bindings, but since > it also yields a 4x performance improvement on the large performance > corpus, I think it is worth it. > --- > debian/control | 1 + > notmuch-git.py | 18 +- >

Re: [PATCH 2/4] perf-test: add tests for notmuch-git

2022-07-05 Thread Tomi Ollila
On Sun, Jul 03 2022, David Bremner wrote: > The main focus of these initial tests is the (currently unacceptably > slow) checkout performance. > --- > performance-test/T07-git.sh | 23 +++ > 1 file changed, 23 insertions(+) > create mode 100755 performance-test/T07-git.sh >

Re: [PATCH] doc/emacs: add notmuch-show-empty-saved-searches to manual

2022-07-05 Thread Tomi Ollila
On Fri, Jul 01 2022, David Bremner wrote: > Answering a user question, I had to dig for this variable, but I think > it is a reasonably common customization wish, particularly for users > with custom count-functions. pretty trivial. i trust it works as expected (at least no extra whitespace ;)

Re: [PATCH] CLI/git: replace most mentions of nmbug

2022-07-05 Thread Tomi Ollila
On Mon, Jul 04 2022, David Bremner wrote: > Particularly in help messages, nmbug is confusing for users who may > have never heard of it. Good Progress! LGTM! Tomi > --- > notmuch-git.py | 40 > 1 file changed, 20 insertions(+), 20 deletions(-) > >

Re: [PATCH] emacs: mark notmuch-query.el as obsolete

2022-07-03 Thread Tomi Ollila
On Tue, Jun 28 2022, David Bremner wrote: > The only functionality actually used by notmuch is the base function > notmuch-query-get-threads; the other functions in this file have > nothing to do with that (single) use. Move that function into > notmuch-lib.el and rename to reflect use.

Re: [PATCH v2 1/1] emacs: notmuch-show-header-line: allow format strings and functions

2022-05-18 Thread Tomi Ollila
On Tue, May 17 2022, Jose A. Ortega Ruiz wrote: > On Tue, May 17 2022, Tomi Ollila wrote: > > [...] > >> Otherwise it looks good to me (took a bit to match cond CLAUSES...) > > perhaps it'd be bit clearer if i factor it out in a separate function > that just does th

Re: [PATCH v2 1/1] emacs: notmuch-show-header-line: allow format strings and functions

2022-05-17 Thread Tomi Ollila
On Mon, May 16 2022, j...@gnu.org wrote: > If a string value is assigned to notmuch-show-header-line, it's used > as a format string to be passed passed to format-spec with `%s` > substituted by the message's subject. If a function is given, it's > called with the subject as argument, and its

Re: [PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread

2022-05-03 Thread Tomi Ollila
On Mon, May 02 2022, Leo Okawa Ericson wrote: > --- > emacs/notmuch.el | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > index c9cf80dc..c1ddb06b 100644 > --- a/emacs/notmuch.el > +++ b/emacs/notmuch.el > @@ -525,13

Re: [PATCH] doc/sexp-queries: escape @ in non-verbatim text

2022-04-29 Thread Tomi Ollila
On Thu, Apr 28 2022, David Bremner wrote: > This prevents sphinx-doc from creating spurious mailto: links. Thanks > to Jakub Wilk for telling me about the fix. looks trivial to me > --- > doc/man7/notmuch-sexp-queries.rst | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > >

Re: [PATCH 1/1] emacs: Make notmuch-show-next-thread return nil on failure

2022-04-29 Thread Tomi Ollila
On Thu, Apr 28 2022, Leo wrote: > From: Leo Okawa Ericson > > Having notmuch-show-next-thread return non-nil on success and nil on > failure makes it easier for users to interact with notmuch via elisp. > --- > emacs/notmuch.el | 17 + > 1 file changed, 9 insertions(+), 8

Re: [PATCH] configure: avoid warning with -Wall

2022-04-19 Thread Tomi Ollila
On Mon, Apr 18 2022, michaeljgruber wrote: > From: Michael J Gruber > > 7228fe68 ("configure: restructure gmime cert validity checker code", > 2022-04-09) restructured generated C code to repurpose it later on. This > put usage of `validity` within an `#if`, resulting in an "unused > warning" if

Re: mailto: in Firefox and notmuch-emacs-mua

2022-04-18 Thread Tomi Ollila
On Fri, Apr 15 2022, talin nicholas wrote: > When opening a mailto: link, Firefox defaults to notmuch-emacs-mua, > which is what I want, minus that it spawns a new Emacs instance (which > hangs) rather than opening an *unsent mail* buffer in my existing > daemon. I copied the .desktop file from

Re: emacs: notmuch-address-command 'as-is throws error (was: [PATCH] emacs: Add more front ends for address completion)

2022-02-22 Thread Tomi Ollila
On Mon, Feb 21 2022, Alexander Adolf wrote: > Alexander Adolf writes: > >> [...] >> Hence, from my personal point of view, moving _all_ completion to go >> through completion-at-point-functions seems the only reasonable way >> forward. >> >> That would remove any special cases for when company

[PATCH v3] removed use of 'echo -n' (and echo -n -e ...)

2022-02-20 Thread Tomi Ollila
In most cases used printf %s ... instead. echo -n > file lines to create empty / truncate files were changed to : > file lines, like done in in test-lib-emacs.sh And one echo -n " " replaced with use of sed "s/^/ /" in next line. --- Replaces v2 id:20220220210111.17653-1-tomi.oll...@iki.fi

[PATCH v2] removed use of 'echo -n' (and echo -n -e ...)

2022-02-20 Thread Tomi Ollila
In most cases used printf %s ... instead. echo -n > file lines to create empty / truncate files were changed to : > file lines, like done in in test-lib-emacs.sh And one echo -n " " replaced with use of sed 's/^/ /' in next line. --- Replaces id:20220220205230.17446-1-tomi.oll...@iki.fi

[PATCH 1/5] removed use of 'echo -n' (and echo -n -e ...)

2022-02-20 Thread Tomi Ollila
In most cases used printf %s ... instead. echo -n > file lines to create empty / truncate files were changed to : > file lines, like done in in test-lib-emacs.sh And one echo -n " " just merged to echo in previous line. --- Most of the changes went to release-checks.sh -- the one I've mostly

Re: [PATCH 2/4] test: due not pass T380.1 for the wrong reasons

2022-02-19 Thread Tomi Ollila
On Sat, Feb 12 2022, David Bremner wrote: > Michael J Gruber writes: > > >> When analysing this, I was confused by the way >> test_require_external_prereq works and the "if" in T380 (as opposed to how >> test_require_external_prereq is used in other tests). Over at git.git, >> we have test setup

Re: [PATCH 4/4] CLI/insert: escape envelope from

2022-02-19 Thread Tomi Ollila
On Sun, Feb 13 2022, David Bremner wrote: > The idea is to do as little parsing and modification of the delivered > message as possible. Luckily the position of the "envelope header" > lets us escape it by replacing the first 5 characters of the stream > with a regular header name (with ':'). >

Re: [PATCH] test: allow to use --full-sync

2022-02-16 Thread Tomi Ollila
On Wed, Feb 16 2022, Tomi Ollila wrote: > > I'd not merge this NOTMUCH_NEW_OPTIONS=--full-scan ;D too eagerly > ... I'd like we really knew the reason (which is then written in > commit message) I seem I did not get my message above (or why the ;D is there) expressed clear enough

Re: [PATCH] test: allow to use --full-sync

2022-02-16 Thread Tomi Ollila
On Wed, Feb 16 2022, Michael J. Gruber wrote: > David Bremner venit, vidit, dixit 2022-02-16 14:04:17: >> Michael J Gruber writes: >> >> > Some build infrastructure appears to habe problems with mtime/stat, >> >> have > > Huh, this looks as if my mother tongue slipped in, while it's just key >

Re: [PATCH] emacs: escape quote in notmuch-search-result-format docstring

2022-02-16 Thread Tomi Ollila
On Wed, Feb 16 2022, David Bremner wrote: LGTM, now I remeber this syntax... Tomi > Prevent Emacs' mangling of quotes, which breaks the code sample. > --- > emacs/notmuch.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > index

Re: [BUG] Bad quote in help

2022-02-16 Thread Tomi Ollila
On Wed, Feb 16 2022, Rudolf Adamkovič wrote: > Repro steps: > > 1. C-h v > 2. notmuch-search-result-format > 3. RET > > See: > > For example: > (setq notmuch-search-result-format > ’(("authors" . "%-40s") > ("subject" . "%s"))) > > The quote ’ needs changed to ',

Re: Test suite timing issues?

2022-02-14 Thread Tomi Ollila
On Mon, Feb 14 2022, David Bremner wrote: > Tomi Ollila writes: > >> >> Looked notmuch-new.c -- time_t (seconds since epoch) is used as timestamp >> comparisons (which would indicate the subsecond resolution most fs' provide >> is not used)... >> >> ...

Re: Test suite timing issues?

2022-02-14 Thread Tomi Ollila
On Mon, Feb 14 2022, David Bremner wrote: > Tomi Ollila writes: > >> >> Looked notmuch-new.c -- time_t (seconds since epoch) is used as timestamp >> comparisons (which would indicate the subsecond resolution most fs' provide >> is not used)... >> >> ...

Re: [PATCH v2] nmbug: write tags out to a temporary file, not 'nmbug.index'

2022-02-13 Thread Tomi Ollila
On Sun, Feb 13 2022, Sean Whitton wrote: > Hello, > > On Sun 13 Feb 2022 at 09:54am -07, Sean Whitton wrote: > >> If more than nmbug process is running at once, then each will try to >> read and write the same file. The particular failure I've seen is >> that the process which finishes first

Re: Test suite timing issues?

2022-02-13 Thread Tomi Ollila
On Sun, Feb 13 2022, Tomi Ollila wrote: > On Sat, Feb 12 2022, David Bremner wrote: > >> Tomi Ollila writes: >> >>> >>> Does such a change hide "buggy" functionality ? >> >> We mostly don't use add_message, call notmuch new via NOTMUCH_

Re: [PATCH] nmbug: write tags out to a temporary file, not 'nmbug.index'

2022-02-13 Thread Tomi Ollila
On Sun, Feb 13 2022, Sean Whitton wrote: > If more than nmbug process is running at once, then each will try to > read and write the same file. The particular failure I've seen is > that the process which finishes first deletes nmbug.index, and then > the other process dies with a

Re: Test suite timing issues?

2022-02-12 Thread Tomi Ollila
On Sat, Feb 12 2022, David Bremner wrote: > Tomi Ollila writes: > >> >> Does such a change hide "buggy" functionality ? > > We mostly don't use add_message, call notmuch new via NOTMUCH_NEW in > T050-new.sh. So I think it would mostly not hide bugs in notmuc

Re: [Utkarsh Singh] Re: [PATCH] emacs: Add more front ends for address completion

2022-02-12 Thread Tomi Ollila
On Fri, Feb 11 2022, Utkarsh Singh wrote: > On 2022-02-10, 19:37 +0200, Tomi Ollila wrote: > >> >> When doing in notmuch repo, one can execute ./devel/try-emacs-mua -Q >> >> ... which probably uses the same package database (under $HOME) as any >> oth

Re: Test suite timing issues?

2022-02-12 Thread Tomi Ollila
On Sat, Feb 12 2022, David Bremner wrote: > Tomi Ollila writes: > >> On Sat, Feb 12 2022, Michael J. Gruber wrote: >> >> Only thing that came into mind are directory timestamps... if directory >> (m)time is same as before notmuch will not scan it fo

Re: Test suite timing issues?

2022-02-12 Thread Tomi Ollila
On Sat, Feb 12 2022, Michael J. Gruber wrote: > David Bremner venit, vidit, dixit 2022-02-12 01:03:00: >> Michael J Gruber writes: >> >> > Hi there, >> > >> > I'm trying to package notmuch for Redhat's enterprise linux and clones >> > (EPEL, extra packages for enterprise linux). >> > >> > This

Re: Python binding SIGABRT/SIGSEGV

2022-02-11 Thread Tomi Ollila
On Fri, Feb 11 2022, Michael J. Gruber wrote: > Austin Lund venit, vidit, dixit 2022-02-10 23:21:58: >> On Thu, Feb 10, 2022 at 01:12:47PM +0100, Michael J Gruber wrote: >> > Austin Lund venit, vidit, dixit 2022-02-10 06:56:12: >> > > I'm clearly doing this python code wrong by not using the

Re: [Utkarsh Singh] Re: [PATCH] emacs: Add more front ends for address completion

2022-02-10 Thread Tomi Ollila
On Thu, Feb 10 2022, Utkarsh Singh wrote: > Start of forwarded message > From: Utkarsh Singh > To: Tomi Ollila > Subject: Re: [PATCH] emacs: Add more front ends for address completion > Date: Thu, 10 Feb 2022 08:58:49 +0530 > > He

Re: [PATCH 4/4] test: set up the outcount file for T380.1

2022-02-10 Thread Tomi Ollila
On Thu, Feb 10 2022, Michael J. Gruber wrote: > Tomi Ollila venit, vidit, dixit 2022-02-09 21:50:35: >> On Wed, Feb 09 2022, Michael J. Gruber wrote: >> >> > If gdb is present but for some reason `atomicity.py` fails to write to >> > the output file then the test

Re: [PATCH] emacs: Add more front ends for address completion

2022-02-09 Thread Tomi Ollila
On Tue, Feb 08 2022, Utkarsh Singh wrote: > Hello maintainers, > > Emacs Lisp Package Archive (ELPA) now includes a package called 'corfu', > according to its documentation: > > Corfu enhances the default completion in region function with a > completion overlay. The current

Re: [PATCH 4/4] test: set up the outcount file for T380.1

2022-02-09 Thread Tomi Ollila
On Wed, Feb 09 2022, Michael J. Gruber wrote: > If gdb is present but for some reason `atomicity.py` fails to write to > the output file then the test fails with some ugly bash errors in the > wrong places (because the outcount variable is empty). > > Therefore, set up the outcount file with `0`

Re: [PATCH 3/4] test: reword T380.2 to be clearer

2022-02-09 Thread Tomi Ollila
On Wed, Feb 09 2022, Michael J. Gruber wrote: > T380.2 gives a test description which depends on the actual test output, > rather than the expected outcome or actual test which is performed. > > So, when the test fails due missing abort points, the test describes > itself as `detected 0>10 abort

Re: [PATCH 2/4] test: due not pass T380.1 for the wrong reasons

2022-02-09 Thread Tomi Ollila
On Wed, Feb 09 2022, Michael J. Gruber wrote: > If gdb is missing then some files are never written to so that the > comparisons of non-existing files succeeds for the wrong reason, > claiming that `notmch new` is idempotent when it was in fact never run. > > Catch this and (for lack of a better

Re: [PATCH 1/4] test: correct comparison order in T380

2022-02-09 Thread Tomi Ollila
On Wed, Feb 09 2022, Michael J. Gruber wrote: > Specifying test comparisons as "expected actual" gives a better readable > diff since the "-" indicates missing, "+" additional items compared to > the expectations. > > Signed-off-by: Michael J Gruber > --- > test/T380-atomicity.sh | 2 +- > 1

[PATCH] NEWS: emacs/notmuch-logo.svg is there in 0.35

2022-01-31 Thread Tomi Ollila
--- NEWS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS b/NEWS index bc2a80de..d03d0a33 100644 --- a/NEWS +++ b/NEWS @@ -44,6 +44,9 @@ Use `--excludes=false` when generating the 'All tags' section. Use cached copy of message body for `Fcc`, avoiding variant bodies for signed and/or

Re: [PATCH] NEWS: my changes for 0.35

2022-01-31 Thread Tomi Ollila
On Sun, Jan 30 2022, David Bremner wrote: I don't know about content, but style looks good ;D Pushing now would help when forthcoming NEWS changes pour in... Tomi > --- > NEWS | 68 > 1 file changed, 68 insertions(+) > > diff --git

Re: [PATCH 2/4] test: define test_expect_equal_message_body

2022-01-20 Thread Tomi Ollila
On Thu, Jan 20 2022, David Bremner wrote: > This is a relatively simple sed invocation, but rather than write a > comment everywhere, give it a descriptive name. > --- > test/test-lib.sh | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/test/test-lib.sh b/test/test-lib.sh

Re: [PATCH] test/emacs: known broken test for matching fcc and sent message

2022-01-20 Thread Tomi Ollila
On Wed, Jan 19 2022, David Bremner wrote: > David Bremner writes: > >> Based on the method outlined by Daniel Kahn Gilmour in >> id:87k1zm225v@fifthhorseman.net. With a delay of 0.2 seconds the >> test becomes flaky on my machine. With a 1 second delay it fails >> consistently for more than

Re: [PATCH] CLI: print extra headers only for non-replies

2022-01-19 Thread Tomi Ollila
On Tue, Jan 18 2022, David Bremner wrote: > If in the future we decide to output extra headers for replies, this > should be controlled by a separate configuration option. > --- > notmuch-show.c | 3 ++- > test/T310-emacs.sh | 1 - > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH v4] emacs: customizable names for search buffers

2022-01-16 Thread Tomi Ollila
On Fri, Jan 14 2022, Jose A. Ortega Ruiz wrote: > on second thought, i think we could perhaps just go for the simpler > "%t", which would allow inserting the type anywhere, even in the middle > of a word... i think a problem here is that "word" or "symbol" (which is > what my suggestion used)

Re: [PATCH v2] emacs/notmuch-tag.el: add xmlns attribute to svg icons

2022-01-14 Thread Tomi Ollila
On Fri, Jan 14 2022, LdBeth wrote: > emacs-mac that compiled with OS X system API for image display > support cannot correctly render svg without xmlns parameter [1]. LGTM. Tomi > > [1]: id:tencent_127aa231767438ac66fee4ddb4bbf51df...@qq.com > --- > emacs/notmuch-tag.el | 6 +++--- > 1 file

Re: [PATCH] emacs/notmuch-tag.el: add xmlns attribute to svg icons

2022-01-13 Thread Tomi Ollila
On Thu, Jan 13 2022, LdBeth wrote: > emacs-mac that compiled with OS X system API instead of imagemagick > cannot render svg without xmlns correctly [1]. Referecing Imagemagick in this commit message may be incorrect, otherwise content looks good. In case of Emacs 26, when imagemagick is used

Re: notmuch-emacs: svg icon cannot be rendered by emacs-mac

2022-01-13 Thread Tomi Ollila
On Wed, Jan 12 2022, LdBeth wrote: > The svg icons included in notmuch-emacs cannot be correctly rendered > by emacs-mac (https://bitbucket.org/mituharu/emacs-mac/src/master/), > > The empty SVG created by `svg-image' function from svg.el has XML > attribute `xmlns' like: > > "

Re: [PATCH v4] emacs: customizable names for search buffers

2022-01-12 Thread Tomi Ollila
On Mon, Jan 10 2022, j...@gnu.org wrote: > Customizable names for buffers presenting search results, via two > custom variables (notmuch-search-buffer-name-format and > notmuch-saved-search-buffer-name-format), defaulting to values > currently used for plain searches and including too tree and >

FYI: emacs / notmuch-search-edit-search

2022-01-12 Thread Tomi Ollila
Hi all I've had this for a while in .emacs.d/notmuch-config.el --- (defun notmuch-search-edit-search () "Edit current search" (interactive) (notmuch-search (read-from-minibuffer "Edit search: " notmuch-search-query-string) notmuch-search-oldest-first))

Re: [PATCH] configure: Ignore more options that Fedora spec macros expect

2022-01-11 Thread Tomi Ollila
On Tue, Jan 11 2022, michaeljgruber wrote: > From: Michael J Gruber > > Signed-off-by: Michael J Gruber > --- LGTM. Tomi > This allows the Fedora packager to use the standard Fedora packaging > macros rather than a hand-tailored configure call. > > [Sorry for resend, my mails don't seem to

Re: [PATCH 1/3] build: move LDFLAGS after notmuch libraries.

2021-12-29 Thread Tomi Ollila
On Fri, Dec 24 2021, David Bremner wrote: > In [1] Ryan Schmidt reported a problem on macports [2] with notmuch > finding an existing installed version of libnotmuch during the build > when the user specified LDFLAGS including the libnotmuch install > directory. > > This change should prevent

Re: [PATCH] configure: calculate NOTMUCH_BUILDDIR, write to Makefile.config

2021-12-29 Thread Tomi Ollila
On Wed, Dec 22 2021, David Bremner wrote: > This will correct the current use of an undefined variable when > setting LD_LIBRARY_PATH in doc/Makefile.local > > It is tempting to try to replace the use of test/export-dirs.sh, but > this is not as simple as it looks, as NOTMUCH_BUILDDIR is used to

Re: [PATCH 2/2] lib/open: do not consider .notmuch alone as an existing database.

2021-12-29 Thread Tomi Ollila
On Sat, Dec 25 2021, David Bremner wrote: > It makes perfect sense for users to want to pre-create .notmuch, > e.g. to install hooks, so we should handle the case of a .notmuch > directory without an actual xapian database more gracefully. Series LGTM. Tomi > --- > lib/open.cc |

Re: [PATCH] emacs: update coolj-line-prefix-regexp to make space optional

2021-12-29 Thread Tomi Ollila
On Sat, Dec 25 2021, David Bremner wrote: > Jani reported that lines prefixed with '>' (as opposed to '> ') are > not highlighted properly [1]. David E responded with a updated regex > [2]. This change implements David E's suggestion. > > [1]: id:87a8b5pcky@nikula.org > [2]:

Re: [PATCH] test: test folder renames

2021-12-26 Thread Tomi Ollila
On Sun, Dec 26 2021, David Bremner wrote: > From: Jani Nikula > > In [1] Mark Walters reported a problem with messages being removed > from the database when the parent directory was renamed. Jani Nikula > proposed [2] these tests but observed With that 'From:' line commit message starts to

Re: [PATCH] doc: add dep. on stamp file for rebuilding gzipped man pages.

2021-12-25 Thread Tomi Ollila
On Fri, Dec 24 2021, David Bremner wrote: > In [1] Daniel observed that the gzipped man pages were only being > rebuild every second time when building with `make -j4'. This may be > caused by a race condition between sphinx-build rebuilding the roff > files and the recipe to gzip them. This

[PATCH v3] emacs: add notmuch-logo.svg and use it in emacs mua on graphic displays

2021-12-21 Thread Tomi Ollila
emacs/notmuch-logo.svg is handcrafted scalable vector graphics version of the notmuch logo. Emacs on graphic displays render this image four times in size compared to the emacs/notmuch-logo.png, and the image is much sharper. The rendered image size, 100x100 pixels, fits reasonably well with

Re: Fix order of -I and -L flags

2021-12-20 Thread Tomi Ollila
On Fri, Dec 17 2021, David Bremner wrote: > Ryan Schmidt writes: > >> The notmuch build system puts -I and -L flags in the wrong order. >> >> Specifically, -I flags the user might specify in the CPPFLAGS >> environment variable appear before the -I flags for the project's own >> directories,

Re: [PATCH v2] emacs: add notmuch-logo.svg and use it in emacs mua on graphic displays

2021-12-16 Thread Tomi Ollila
On Thu, Dec 16 2021, David Bremner wrote: > Tomi Ollila writes: > >> emacs/notmuch-logo.svg is handcrafted scalable vector graphics version >> of the notmuch logo. >> >> Emacs on graphic displays render this image four times in size compared >> to the e

[PATCH v2] emacs: add notmuch-logo.svg and use it in emacs mua on graphic displays

2021-12-14 Thread Tomi Ollila
emacs/notmuch-logo.svg is handcrafted scalable vector graphics version of the notmuch logo. Emacs on graphic displays render this image four times in size compared to the emacs/notmuch-logo.png, and the image is much sharper. The rendered image size, 100x110 pixels, fits reasonably well with

[PATCH 1/6] configure: have bash_absolute and perl_absolute always defined

2021-12-07 Thread Tomi Ollila
Since set -u is used, without bash or perl, configure would fail. This has gone unnoticed as (almost) everyone always had both bash and perl installed (and in $PATH). Thanks to FreeBSD ports this bug became visible; this change is verbatim copy of `patch-configure` in FreeBSD ports tree. ---

Re: [PATCH] test/emacs: mark one test as fixed in newer emacs.

2021-12-06 Thread Tomi Ollila
On Sun, Dec 05 2021, David Bremner wrote: > The remaining problem in this test is fixed upstream in Emacs > 28. While most people are using earlier versions of emacs, the test > still provides some documentation of a known bug. > --- > test/T450-emacs-show.sh | 4 +++- > 1 file changed, 3

Re: [PATCH v2] emacs: drop C-tab binding in hello mode, document .

2021-11-03 Thread Tomi Ollila
On Sat, Oct 30 2021, David Bremner wrote: > The binding has always been there, but the docs were > apparently mistakenly changed to say [1] > > Revert to in the documentation. > > The commit also drops the C- binding, since it seems redundant > and it interferes with tab-bar-mode. > > [1]:

Re: [PATCH 4/4] python-cffi: switch to notmuch_database_{open,create}_with_config

2021-11-03 Thread Tomi Ollila
On Tue, Nov 02 2021, David Bremner wrote: > Floris Bruynooghe writes: > >> On Sat 30 Oct 2021 at 13:22 -0300, David Bremner wrote: >>> + >>> +.. deprecated:: 0.35 >>> + Use the ``cfg_path`` parameter instead. >> >> Do you mean the ``config`` parameter to :meth:`__init__` or >>

[RFC PATCH] emacs: add notmuch-logo.svg

2021-11-01 Thread Tomi Ollila
handcrafted scalable vector graphics version of the notmuch logo for sharper image --- Loads in emacs, on my screen letter was white on white background (emacs dark background) so hints how to make it look better on dark mode emacs (i.e. white lines instead of black) and how to have transparent

Re: [PATCH] rename built_with.sexpr_query to built_with.sexp_queries

2021-11-01 Thread Tomi Ollila
On Sat, Oct 30 2021, David Bremner wrote: > It is confusing to use two different names (sexp vs sexpr) when > compared with the command line option --query=sexp and (furthermore) > singular vs plural when compared with the man page title. like wrote before -- fine by me... Tomi > --- >

Re: [PATCH 4/4] python-cffi: switch to notmuch_database_{open,create}_with_config

2021-10-31 Thread Tomi Ollila
On Sat, Oct 30 2021, David Bremner wrote: > Since release 0.32, libnotmuch provides searching for database and > configuration paths. This commit changes the python module notmuch2 to > use those facilities. > > This fixes the bug reported in [1], along with a couple of the > deprecation warnings

Re: [PATCH] emacs: don't add space to tag completion candidates.

2021-10-31 Thread Tomi Ollila
On Sat, Oct 30 2021, David Bremner wrote: > "inwit" writes: > >> Works as expected under selectrum! Thanks! >> >> > > right, I guess the question is how annoying it is for users of standard > emacs completion. I generally enter one tag at a time, so it won't > really affect me. I recall doing

Re: [RFC PATCH] python-cffi out-of-tree build

2021-10-31 Thread Tomi Ollila
On Sun, Oct 31 2021, David Bremner wrote: > Tomi Ollila writes: > >> setup.py and _build.py to refer some other files based on directory >> where setup.py is located (os.path.dirname(sys.argv[0]). >> >> Dropped bindings/python-cffi/version.txt and refer ../../versi

Re: [PATCH] NEWS: fix typo in 0.34 news.

2021-10-27 Thread Tomi Ollila
On Wed, Oct 27 2021, David Bremner wrote: > David Bremner writes: > >> Thanks to jrm on IRC for finding the typo. > > Applied to release and master. > > It (belatedly) occurs to me that it's a bit confusing to that the > built_with option is sexpr_query, while the man page is >

Re: [PATCH] test/libconfig: use 'export' when restoring NOTMUCH_CONFIG

2021-10-27 Thread Tomi Ollila
On Wed, Oct 27 2021, David Bremner wrote: > This is required when NOTMUCH_CONFIG has been unset, and is harmless > otherwise. LGTM. Tested w/ the following than the commit message is correct: (works the same way w/ dash, bash and zsh) --8<8<8<8<-- export FOO FOO=1 sh -c 'echo

Re: [PATCH 2/2] test/new: replace use of gdb in vanishing file test

2021-10-25 Thread Tomi Ollila
On Sun, Oct 24 2021, David Bremner wrote: > Because the file to be removed has a predictable name, we can hard > code it in the generated shim. I am not sure about the message above -- the file name is as predictable as it was before -- and the shim code is created dynamically, with same amout

Re: [PATCH 1/2] test/count: replace use of gdb with a LD_PRELOAD shim

2021-10-25 Thread Tomi Ollila
On Sun, Oct 24 2021, David Bremner wrote: > There is a certain amount of boilerplate to pass the call on the > original function, so abstract it out as a C preprocessor macro, plus > some extra includes in notmuch-test.h Looks like good progress -- some comments... > --- > test/T060-count.sh

Re: Emacs notmuch extracts text attachments as if they had Windows (CRLF) encoding

2021-10-14 Thread Tomi Ollila
On Wed, Oct 13 2021, Martin Jambor wrote: > Hi, > > I have stumbled upon strange behavior of emacs-notmuch. When I extract > (some?) plain text attachments into files using notmuch-show-save-part > (by pressing ".s"), the file they end up in has Windows encoding of line > ends (CRLF) even though

Re: [RFC 2/5] lib: remove enum names from typedefs

2021-10-13 Thread Tomi Ollila
On Wed, Oct 13 2021, David Bremner wrote: > Jani Nikula writes: > >> Given the named enum typedef: >> >> typedef enum _name_t { ... } name_t; >> >> Hawkmoth uses _name_t as the name for documentation. Typedef the >> anonymous enum: >> >> typedef enum { ... } name_t; >> >> instead to use

Re: [RFC 1/5] doc: replace doxygen with hawkmoth sphinx extension for api docs

2021-10-13 Thread Tomi Ollila
Interesting stuff... On Tue, Oct 12 2021, Jani Nikula wrote: > Hawkmoth is a Sphinx extension for incorporating documentation > comments from C source to Sphinx. For Notmuch API documentation needs, > Doxygen is overkill, and Hawkmoth also directly integrates with > Sphinx. // stuff deleted //

Re: [PATCH] configure: whitespace cleanup

2021-10-10 Thread Tomi Ollila
On Sat, Oct 09 2021, David Bremner wrote: > In order to make it easier to keep the whitespace consistent in the > configure script, use the same style defined in devel/STYLE for > C/C++. > > Specifically, a line should begin with zero or more tabs followed > by fewer than eight spaces. > >

Re: [PATCH v2] devel: script for checking a commit (series)

2021-10-10 Thread Tomi Ollila
On Sun, Oct 10 2021, David Bremner wrote: > 'check-notmuch-commit' is an updated version of a script I have been > using (although not always as consistently as I should) before sending > patches to the list. > > Although it requires a bit more tooling, encouraging people to use >

Re: [PATCH] configure: check explicitely for python dev (include) files

2021-10-08 Thread Tomi Ollila
On Thu, Oct 07 2021, David Bremner wrote: > As discussed at [1] we have received reports that the implicit check > using cffi.FFI().verify() is not reliable in all environments. Since > we already use pkg-config, and the python dev package should include a > .pc file [2], add an extra check using

Re: configure checks for python3-notmuch2 module

2021-10-06 Thread Tomi Ollila
On Wed, Oct 06 2021, Tomi Ollila wrote: > > So, on Fedora 34, without python3-devel installed > > $ python3 -c 'import cffi,setuptools; cffi.FFI().verify()' > __pycache__/_cffi__xd915627fxd88346ae.c:2:10: fatal error: Python.h: No > such file or directory

Re: configure checks for python3-notmuch2 module

2021-10-06 Thread Tomi Ollila
On Wed, Oct 06 2021, David Bremner wrote: > Tomi Ollila writes: > >> >> Have to check how all this behaves on Fedora 34 machine when I >> have access to one (currently away from such machines and from >> power grid also (laptop battery power, which I have to pr

Re: [PATCH] test/T355-smime: Use key as exported by gpgsm

2021-09-28 Thread Tomi Ollila
On Mon, Sep 27 2021, David Bremner wrote: > As reported in id:87h7pxiek3@tethera.net, the previous version of > the test is flaky. There is some so-far undebugged interaction between > openssl and gpgsm that causes the keys to fail to import. As a > potential workaround, use the key as

Re: performance in emacs displaying a huge thread

2021-09-22 Thread Tomi Ollila
On Wed, Sep 22 2021, Alan Schmitt wrote: > On 2021-09-21 21:27, Tomi Ollila writes: > >> I'd be interested to know if changing max-lisp-eval-depth to a larger value >> made difference. >> >> e.g (set max-lisp-eval-depth 1600) > > Thank you for the sugg

  1   2   3   4   5   6   7   8   9   10   >