[PATCH] configure: Check if emacs >= 25 (instead of >= 24) is available

2020-08-11 Thread Tomi Ollila
"The minimum supported major version of GNU Emacs is now 25.1." 25.1 is the first "released" version of Emacs 25. --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index a357eb91..40e8b255 100755 --- a/configure +++ b/configure @@ -829,8

Re: [PATCH v3 00/34] A great number of cosmetic changes

2020-08-09 Thread Tomi Ollila
On Sun, Aug 09 2020, David Bremner wrote: > Jonas Bernoulli writes: >> >> Jonas Bernoulli (34): >> emacs: Shorten long lines >> emacs: Remove excess empty lines > > > These patches (and Đoàn Trần Công Danh's that I just applied by hand) > both seem to have problem with base64 encoded patches

Re: [PATCH v3 00/34] A great number of cosmetic changes

2020-08-09 Thread Tomi Ollila
On Sat, Aug 08 2020, Jonas Bernoulli wrote: > David Bremner writes: > >> Tomi Ollila writes: > >>> So we have 3 options: >>> >>> 1) apply this patch and now drop support for emacs 24 >>> >>> 2) apply this patch and somehow infor e

Re: [PATCH v2] configure: check for pytest with python -m pytest

2020-08-07 Thread Tomi Ollila
On Mon, Aug 03 2020, Đoàn Trần Công Danh wrote: > On different distro, pytest is suffixed with different patterns. > > On the other hand, `python3-pytest' could be invoked correctly, > via `python3 -m pytest', the latter is used by our tests, now. > > Switch to `$python -m pytest` to fix address

Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate

2020-08-07 Thread Tomi Ollila
On Thu, Aug 06 2020, Jonas Bernoulli wrote: > David Bremner writes: >> "cl-incf is a Lisp macro in ‘aquamacs-tools.el’." >> >> What the actual heck? > > Indeed. Did you follow the link to the definition to figure out what's > going on? > > Ah... I found this:

Re: [PATCH 1/2] test: drop NOTMUCH_DEFAULT_XAPIAN_BACKEND from T360-symbol-test

2020-07-31 Thread Tomi Ollila
On Wed, Jul 29 2020, David Bremner wrote: > Inspired by the suggestion of > > id:20200727154108.16269-3-congdan...@gmail.com > > to drop the configuration test for the default backend. This version > is hopefully robust against backend changes. > --- > test/T360-symbol-hiding.sh | 4

Re: [PATCH 00/23] A create number of cosmetic changes

2020-07-30 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > Hello, > > Please forgive me for this wall of unsolicited cleanup; I blame it > on a mild form of ocd. I made most of these changes a few months > ago when I was splitting the libraries into `outline-minor-mode' > compatible sections. To do so I had

Re: [PATCH 03/23] emacs: Fix indentation

2020-07-30 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > --- > emacs/coolj.el | 16 ++--- > emacs/notmuch-address.el | 18 +++--- > emacs/notmuch-compat.el| 86 - > emacs/notmuch-draft.el | 18 +++--- > emacs/notmuch-hello.el | 24

[PATCH] notmuch-mutt: replace shell pipeline with internal pipe processing

2020-07-27 Thread Tomi Ollila
The shell pipeline used to symlink files based in search results to "cache" directory for mutt(1) to use was prone to portability problems (due to /bin/sh differences). The replacement executes `notmuch search` without intermediate shell (so shell_quote was removed in this case), reads the

Re: [PATCH 1/3] gitignore: Ignore generated sphinx.config

2020-07-27 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 1c8705ec..8f3ebec0 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -17,3 +17,4 @@ tags > /.stamps > *.stamp > /bindings/python-cffi/build/

Re: [PATCH 02/23] emacs: Remove excess empty lines

2020-07-27 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > Most people who write lots of lisp tend to only sparsely use empty > "separator" lines within forms. In lisp they feel unnecessary and > since most files stick to this convention we get a bit confused > when there are extra empty lines. It feels

Re: [PATCH 01/23] emacs: Shorten long lines

2020-07-27 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > --- > emacs/coolj.el | 2 +- > emacs/notmuch-address.el | 38 +++-- > emacs/notmuch-company.el | 17 -- > emacs/notmuch-crypto.el | 16 +++--- > emacs/notmuch-draft.el | 12 ++-- >

Re: [PATCH] T355: specify hash algorithm explicitly

2020-07-27 Thread Tomi Ollila
On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote: > On some systems (notably, the one shipped with LibreSSL), > default fingerprint digest algorithm is SHA256. > > On other systems, users can change default digest algorithm by changing > default_md in /etc/ssl/default_md. > > Let's ask openssl to

Re: [PATCH] configure: account for various name of pytest-3

2020-07-27 Thread Tomi Ollila
On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote: > On different distro, pytest is suffixed with different patterns. > Try to account for them, now. > > Signed-off-by: Đoàn Trần Công Danh > --- > configure | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH] configure: detect version by compiler for build

2020-07-27 Thread Tomi Ollila
On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote: > We'll need to run the compiled binary to report our current version. > > With the same code base, we should have the same version information > regardless of compiler and architecture. > > Let's use the compiler for building architecture to build

Re: simplify handling of writable database modes

2020-07-27 Thread Tomi Ollila
On Sun, Jul 26 2020, David Bremner wrote: > As the last commit message mentions, it is a bit hard to be sure one > is using static_cast correctly, so this series eliminates > the use of static_cast for Xapian database objects. > > As a bonus, it deletes more code than it adds. > > Based on a

Re: [Kevin McCarthy] Bug#966100: notmuch-mutt: symlinking now fails for indexed mailboxes with a space in the name

2020-07-23 Thread Tomi Ollila
On Thu, Jul 23 2020, David Bremner wrote: > From: Kevin McCarthy > Subject: Bug#966100: notmuch-mutt: symlinking now fails for indexed mailboxes > with a space in the name > To: Debian Bug Tracking System > Date: Wed, 22 Jul 2020 19:06:27 -0700 > > Package: notmuch-mutt > Version: 0.30-1 >

Re: [PATCH 1/2] doc: replace use of environment variables with a generated config

2020-07-17 Thread Tomi Ollila
On Tue, Jul 14 2020, Floris Bruynooghe wrote: > On Sat 11 Jul 2020 at 10:20 -0300, David Bremner wrote: > >> I don't love the use of exec, but it is getting unwieldy to pass > > It's already a config file written in Python which is a terrible sin. > So no need to apologise, I think it makes sense

Re: [PATCH] doc: make gzipped man pages reproducible

2020-07-11 Thread Tomi Ollila
On Sat, Jul 11 2020, Jonas Witschel wrote: > gzip includes the name of the uncompressed file and its modification > timestamp into the compressed archive. The latter makes it hard to > reproduce the generated files bit for bit at a later time, so omit this > information from the archive using the

Re: [PATCH 1/2] doc: replace use of environment variables with a generated config

2020-07-11 Thread Tomi Ollila
On Sat, Jul 11 2020, David Bremner wrote: > I don't love the use of exec, but it is getting unwieldy to pass > configuration options on the sphinx-build command line, and I > anticipate further use of conditionals. Perhaps less "opinions" in commit message. (and as I think I don't comment 2/2,

Re: [PATCH] emacs: Add notmuch-show-local-dates option

2020-07-04 Thread Tomi Ollila
On Fri, Jul 03 2020, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> But if the sender is in TZ=Europe/Berlin, i would see: >> >> Date: Fri, 03 Jul 2020 13:22:36 -0400 [Fri, 03 Jul 2020 19:22:36 +0200] >> >> (Note that RFC 5322 Date format shows the hour offset, but not the >> actual

Re: [PATCH] doc: update name of gmime package to install

2020-07-01 Thread Tomi Ollila
On Fri, Jun 26 2020, David Bremner wrote: > Fedora still has an old gmime-devel which is 2.6.x. This is no longer > supported by notmuch. > --- > INSTALL | 2 +- > configure | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/INSTALL b/INSTALL > index f1236e71..3f11c2b7

[PATCH] Makefile.global: drop -std=gnu99. C11 (or later) compiler required

2020-06-24 Thread Tomi Ollila
Since October 2018 building notmuch has actually required compiler that knows C11. Also this -std=gnu99 was not used in code compiled by configure, so in theory this could have caused problems... ...but no related reports have been sent, perhaps ever. Both gcc and clang has been shipping

Re: [PATCH 1/2] configure: detect 64 bit time_t

2020-06-24 Thread Tomi Ollila
On Wed, Jun 24 2020, David Bremner wrote: > Certain tests involving timestamps > 32bits cannot pass with the > current libnotmuch API. We will avoid this isssue for now by disabling s/isssue/issue/ > those tests on "old" architectures with 32bit time_t. > --- > configure | 33

Re: [PATCH] completion: remove "setup" from the list of possible completions

2020-06-23 Thread Tomi Ollila
On Sat, Jun 20 2020, Ralph Seichter wrote: > * Tomi Ollila: > >> imo.the completions should primarily provide convenience to the >> interactive user, to see all possible options (also those >> seldomly.used) one can use help and namual pages... > > "Can use&quo

Re: [PATCH] completion: remove "setup" from the list of possible completions

2020-06-20 Thread Tomi Ollila
On Sat, Jun 20 2020, reto@labrat.space wrote: > On Fri, Jun 19, 2020 at 12:40:49PM +0200, Łukasz Stelmach wrote: >> Having "setup" in the set requires entering three instad of two characters >> for "search". Since "setup" is rearly used it makes little sense to have >> it in the set and cripple

Re: Feature freeze for notmuch 0.30: June 1

2020-06-17 Thread Tomi Ollila
On Wed, Jun 17 2020, Tomi Ollila wrote: > On Wed, Jun 17 2020, Dan Čermák wrote: > >> >> I have tried updating the package in openSUSE Tumbleweed to 0.30~rc2 but >> running the tests results in the following failures: >> --8<---cut here-

Re: Feature freeze for notmuch 0.30: June 1

2020-06-17 Thread Tomi Ollila
On Wed, Jun 17 2020, Dan Čermák wrote: > > I have tried updating the package in openSUSE Tumbleweed to 0.30~rc2 but > running the tests results in the following failures: > --8<---cut here---start->8--- > T357-index-decryption: Testing indexing decrypted mail >

Re: [PATCH] Update tox.ini for python3.8 and fix pypy3.6

2020-06-15 Thread Tomi Ollila
On Mon, Jun 15 2020, David Bremner wrote: > Floris Bruynooghe writes: > >> [testenv] >> deps = >> @@ -14,3 +14,6 @@ commands = pytest --cov={envsitepackagesdir}/notmuch2 >> {posargs} >> >> [testenv:pypy35] >> basepython = pypy3.5 >> + >> +[testenv:pypy36] >> +basepython = pypy3.6 > > I'm

Re: [PATCH 1/2] python/notmuch2: do not destroy messages owned by a query

2020-06-10 Thread Tomi Ollila
Hi Anton, On Thu, May 21 2020, Anton Khirnov wrote: > ping Great (an important) stuff in this series ! ...just that... Floris did good review on your changes the next day. What I remember was there (looked 30 mins ago) - style: somewhat important (I press more there). Easy to get better,

[PATCH v2] configure: use cffi.FFI().verify() to test buildability of CFFI bindings

2020-06-09 Thread Tomi Ollila
Checking existence of pyconfig.h to determine whether CFFI-based notmuch bindings are buildable is not enough; for example Fedora 32 ships pyconfig.h in python3-libs package, but python3-devel is required to be installed for the bindings to build. Executing cffi.FFI().verify() is pretty close to

Re: [PATCH] NEWS: The minimum supported version of Xapian is now 1.4.0

2020-06-08 Thread Tomi Ollila
On Sun, Jun 07 2020, David Bremner wrote: > Tomi Ollila writes: >> >> +Dependencies >> + >> + >> +Support for Xapian 1.2 is removed. The minimum supported version of >> +Xapian is now 1.4

[PATCH] configure: use cffi.FFI().verify() to test buildability of CFFI bindings

2020-06-08 Thread Tomi Ollila
Checking existence of pyconfig.h to determine whether CFFI-based notmuch bindings are buildable is not enough; for example Fedora 32 ships pyconfig.h in python3-libs package, but python3-devel is required to be installed for the bindings to build. Executing cffi.FFI().verify() is pretty close to

[PATCH] NEWS: The minimum supported version of Xapian is now 1.4.0

2020-06-07 Thread Tomi Ollila
--- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index 1921127fe02c..a16689cae04a 100644 --- a/NEWS +++ b/NEWS @@ -36,6 +36,12 @@ Introduce new CFFI-based python bindings in the python module named "notmuch2". Officially deprecate (but still support) the older

[PATCH] configure: require python 3.5 for CFFI-based notmuch bindings

2020-06-05 Thread Tomi Ollila
Also tell users what the consequences of a "No" answer is when python version is less than 3.5, cffi or setuptools is missing, or no pytest >= 3.0 is available. --- configure | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure b/configure index

Re: [PATCH] devel: script to calculate a list of authors.

2020-06-05 Thread Tomi Ollila
On Fri, Jun 05 2020, David Bremner wrote: > As an initial heuristic, report anyone with at least 15 lines of code > in the current source tree. Test corpora are excluded, although > probabably this doesn't change much about the list of authors > produced. > --- > devel/author-scan.sh | 11

Re: [PATCH] tweaks to NEWS suggest by Tomi

2020-06-05 Thread Tomi Ollila
On Fri, Jun 05 2020, David Bremner wrote: > See id:m27dwp40sx@guru.guru-group.fi LGTM. Tomi > --- > this is on top of Tomi's NEWS patch re Xapian > NEWS | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/NEWS b/NEWS > index a16689ca..556172bb 100644 >

[PATCH] NEWS: The minimum supported version of Xapian is now 1.4.0

2020-06-04 Thread Tomi Ollila
--- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index 1921127fe02c..a16689cae04a 100644 --- a/NEWS +++ b/NEWS @@ -36,6 +36,12 @@ Introduce new CFFI-based python bindings in the python module named "notmuch2". Officially deprecate (but still support) the older

Re: [RFC] devel: script to calculate a list of authors.

2020-06-03 Thread Tomi Ollila
On Wed, Jun 03 2020, David Bremner wrote: > As an initial heuristic, report anyone with at least 15 lines of code > in the current source tree. Test corpora are excluded, although > probabably this doesn't change much about the list of authors > produced. > --- > > I realized both AUTHORS and

Re: [PATCH] add NEWS for 0.30

2020-06-02 Thread Tomi Ollila
post-push comments =D On Mon, Jun 01 2020, Daniel Kahn Gillmor wrote: > Signed-off-by: Daniel Kahn Gillmor > --- > NEWS | 35 +++ > 1 file changed, 35 insertions(+) > > diff --git a/NEWS b/NEWS > index 14db7f6f..1921127f 100644 > --- a/NEWS > +++ b/NEWS > @@

[PATCH] doc: field processor support now always included, adjust manual pages

2020-06-02 Thread Tomi Ollila
The features that require field processor support, are now just documented w/o mentioning **Xapian Field Processors**' is needed for those. Replaced "compact" and "field_processor" with "retry_lock" in build_with config option, as it is currently the only one that is optionally excluded. The

[PATCH] configure: check existence of python3 setuptools and dev package

2020-05-31 Thread Tomi Ollila
The notmuch2 CFFI-based Python interface is not buildable unless python3 dev package and python3 setuptools are installed. Check that these exist in configure (and disable notmuch2 bindings build if not) so that build of these bindings don't fail when make(1) is executed. --- configure | 16

Re: [PATCH] emacs/tree: add notmuch-tree-filter

2020-05-31 Thread Tomi Ollila
On Sat, Apr 25 2020, William Casarin wrote: > This implements the notmuch-tree version of notmuch-show-filter-thread > and binds it to the L key. No reasoning in commit message why 'L' is chosen... Tomi > > Signed-off-by: William Casarin > --- > emacs/notmuch-tree.el | 9 + > 1 file

Re: [PATCH] doc: fix for out-of-tree builds of notmuch-emacs docs

2020-05-31 Thread Tomi Ollila
On Sun, May 31 2020, David Bremner wrote: > The sphinx-doc include directive does not have the ability to include > files from the build tree, so we replace the include with reading the > files in conf.py. The non-trivial downside of this is that the emacs > docstrings are now defined for every

Re: Python 3.x bindings support which versions, exactly?

2020-05-25 Thread Tomi Ollila
On Mon, May 25 2020, Floris Bruynooghe wrote: > In tox.ini the earliest version is 3.5 and if memory serves me right > there's a reasonably good reason for that. I think the notmuch2 > bindings use some features not yet present in 3.4. But anything >= 3.5 > should be supported and if not a bug.

Re: [PATCH v3 3/3] emacs: Use `dolist' instead of `mapcar' for side-effects

2020-05-24 Thread Tomi Ollila
On Sat, Apr 25 2020, Jonas Bernoulli wrote: > As recommended by the byte-compiler. I don't know about v3 2/3, but this, v3 3/3 looks good to me. Tomi > --- > test/emacs-attachment-warnings.el | 23 +++ > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff --git

[PATCH] emacs docstrings: consistent indentation, newlines, periods

2020-05-24 Thread Tomi Ollila
Fixed emacs docstrings to be consistent. No functional change. - removed some (accidental) indentation - removed some trailing newlines - added trailing periods where missing (some exclusions) --- V2 of id:"20200503212136.11070-1-tomi.oll...@iki.fi" changes to v1: - trailing periods removed

Re: [PATCH] tests: fix test_json_nodes() in out-of-tree builds

2020-05-24 Thread Tomi Ollila
On Thu, May 21 2020, Daniel Kahn Gillmor wrote: > In out-of-tree builds, $TEST_DIRECTORY doesn't contain > json_check_nodes.py. This caused 27 tests to fail in such an > environment. are you shure the run_emacs.sh change in id:"20200423212643.864-1-tomi.oll...@iki.fi" is not needed ? =D

Re: [PATCH] emacs docstrings: consistent indentation, newlines, periods

2020-05-21 Thread Tomi Ollila
On Thu, May 21 2020, Daniel Kahn Gillmor wrote: > On Mon 2020-05-04 00:21:36 +0300, Tomi Ollila wrote: >> Fixed emacs docstrings to be consistent. No functional change. >> >> - removed some (accidental) indentation >> - removed some trailing newlines >> - add

Re: test suite: FIXED messages are misordered with tests

2020-05-21 Thread Tomi Ollila
On Thu, May 21 2020, Daniel Kahn Gillmor wrote: > On Thu 2020-05-21 00:16:48 +0300, Tomi Ollila wrote: >> (just tested this latest works) > > Thanks for looking into this, Tomi! > > Do you have a patch to propose? Looked a bit (now). Somewhat complicated to make perfect (

Re: test suite: FIXED messages are misordered with tests

2020-05-20 Thread Tomi Ollila
On Thu, May 21 2020, Tomi Ollila wrote: > > the message that prints FIXED, does not execute print_test_description > but the ones that do BROKEN or FAIL does (did not fully check but yes). > > And: > > print_test_description () > { > test -z "$test_

Re: test suite: FIXED messages are misordered with tests

2020-05-20 Thread Tomi Ollila
On Tue, May 12 2020, Daniel Kahn Gillmor wrote: > I'm debugging/diagnosing/trying to clean up some "FIXED" known-broken > tests right now. > > Sometimes, depending on circumstances i can't predict (race > conditions?), I see funny output like: > > ~~~ > Use "make V=1" to see the details for

Re: feature request: parameters for reply templates

2020-05-13 Thread Tomi Ollila
get nice, clean, useable and maintainable solution. Tomi > > JV > > > Tomi Ollila writes: > >> >> Did you have spec in mind ? =D >> ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: feature request: parameters for reply templates

2020-05-12 Thread Tomi Ollila
On Tue, May 12 2020, Jörg Volbers wrote: >> My gut reaction is that doing more formatting in notmuch reply >> is probably a mistake; it's hard enough to get two users to >> agree on these kind of customizations, never mind two different >> MUAs. Probably what we need to do is make sure the

Re: [PATCH 1/2 v2] test-lib: mark function variables as local

2020-05-09 Thread Tomi Ollila
On Fri, May 08 2020, Daniel Kahn Gillmor wrote: > Several functions in test/test-lib.sh used variable names that are > also used outside of those functions (e.g. $output and $expected are > used in many of the test scripts), but they are not expected to > communicate via those variables. > > We

Re: [PATCH 2/2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7

2020-05-07 Thread Tomi Ollila
On Wed, May 06 2020, Daniel Kahn Gillmor wrote: > When checking cryptographic signatures, Notmuch relies on GMime to > tell it whether the certificate that signs a message has a valid User > ID or not. > > If the User ID is not valid, then notmuch does not report the signer's > User ID to the

Re: [PATCH 1/2] test-lib: mark function variables as local

2020-05-07 Thread Tomi Ollila
On Wed, May 06 2020, Daniel Kahn Gillmor wrote: > Several functions in test/test-lib.sh used variable names that are > also used outside of those functions (e.g. $output and $expected are > used in many of the test scripts), but they are not expected to > communicate via those variables. > > We

Re: Handle PKCS#7 S/MIME messages

2020-05-05 Thread Tomi Ollila
On Mon, May 04 2020, Daniel Kahn Gillmor wrote: > Hi Tomi-- > > On Sat 2020-05-02 00:15:57 +0300, Tomi Ollila wrote: >> I did not see anything suspicious in code, but >> >> I got these test failures: >> >> in ubuntu 19.10 native environment, and >&g

Re: [PATCH 1/2] test: known broken test for reindex tag preservation

2020-05-04 Thread Tomi Ollila
On Mon, May 04 2020, David Bremner wrote: > In id:1588595993-ner-8.651@TPL520 Franz Fellner reported that tags > starting with 'attachment' are removed by 'notmuch reindex'. This is > probably related to the use of STRNCMP_LITERAL in Haa, I looked this briefly but failed to see it is

[PATCH] emacs docstrings: consistent indentation, newlines, periods

2020-05-03 Thread Tomi Ollila
Fixed emacs docstrings to be consistent. No functional change. - removed some (accidental) indentation - removed some trailing newlines - added trailing periods where missing (some exclusions) --- emacs/notmuch-address.el | 21 - emacs/notmuch-draft.el | 8 ++--

Re: Handle PKCS#7 S/MIME messages

2020-05-01 Thread Tomi Ollila
On Thu, Apr 30 2020, Daniel Kahn Gillmor wrote: > This series applies after the "Add tests for S/MIME PKCS#7 messages" > series, which was introduced in > id:20200428185723.660184-1-...@fifthhorseman.net > > With this series applied, notmuch handles standard PKCS#7 S/MIME > messages (using

Re: [PATCH 15/15] tests: disable CRL checks from gpgsm

2020-04-29 Thread Tomi Ollila
On Tue, Apr 28 2020, Daniel Kahn Gillmor wrote: > GPGME has a strange failure mode when it is in offline mode, and/or > when certificates don't have any CRLs: in particular, it refuses to > accept the validity of any certificate other than a "root" cert. > > This can be worked around by setting

Re: [PATCH 08/15] tests/smime: include secret key material for Bob

2020-04-29 Thread Tomi Ollila
On Tue, Apr 28 2020, Daniel Kahn Gillmor wrote: > This is taken from the same Internet Draft that test/smime/ca.crt > comes from. See that draft for more details. > https://www.ietf.org/id/draft-dkg-lamps-samples-02.html#name-pkcs12-object-for-bob > > We don't use it yet, but it will be used to

Re: [PATCH 07/15] test: Allow tests to have both gpg and gpgsm active at once

2020-04-29 Thread Tomi Ollila
On Tue, Apr 28 2020, Daniel Kahn Gillmor wrote: > Without this fix, we couldn't run both add_gnupg_home and > add_gpgsm_home in the same test script. > > Signed-off-by: Daniel Kahn Gillmor > --- > test/test-lib.sh | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: Inconsistencies in handling command flags: `--flag=value` different than `--flag value`

2020-04-29 Thread Tomi Ollila
On Tue, Apr 28 2020, Daniel Kahn Gillmor wrote: > > One final way we could normalize everything and make it less > idiosyncratic, with shorter, simpler man pages: deprecate and then drop > the --booloption/--no-booloption mechanisms, requiring --booloption=true > or --booloption=false instead.

Re: Inconsistencies in handling command flags: `--flag=value` different than `--flag value`

2020-04-27 Thread Tomi Ollila
On Mon, Apr 27 2020, Daniel Kahn Gillmor wrote: > On Mon 2020-04-27 14:53:07 -0300, David Bremner wrote: >> Quoting notmuch(1) >> >>OPTION SYNTAX >>All options accepting an argument can be used with '=' >>or ':' as a separator. For the cases where it's not ambiguous >>

Re: [PATCH] util/zlib-extra: de-inline gzerror_str

2020-04-27 Thread Tomi Ollila
On Mon, Apr 27 2020, David Bremner wrote: > It turns out the behaviour of inline functions in C header files is > not a good idea, and can cause linking problems if the compiler > decides not to inline them. In principle this is solvable by using a > "static inline" declaration, but this

Re: test_emacs_expect_t does ignore Emacs as prerequisite

2020-04-26 Thread Tomi Ollila
On Fri, Apr 24 2020, David Bremner wrote: > Milton Vandersloot writes: >> >> [PATCH] Let test_emacs_expect_t respect missing external prerequisites >> >> test_emacs_expect_t did not test for missing prerequisites (even though >> it called test_emacs which does it). Fix that by testing for

[PATCH] test/test-lib.sh: fix two out of tree test issues

2020-04-23 Thread Tomi Ollila
json_check_nodes.py exists in source tree, not in out of tree build tree. Added -B to the execution so source tree is not "polluted" by a .pyc file when json_check_nodes.py is executed. When creating run_emacs.sh make it load .elc files from out of tree build tree, not from source tree if such

[PATCH] configure: disable features that do not work out of tree

2020-04-23 Thread Tomi Ollila
When doing out of tree build, - sphinx-build cannot collect source files from source code directory and generated files from build directory. - python3-cffi did not work, did not investigate further. In order to get at least something done out of tree, these features are disabled when doing

Re: Database path discovery in bindings

2020-04-22 Thread Tomi Ollila
On Sun, Apr 19 2020, Kirill Elagin wrote: > Hello, > > Notmuch contains a bit of logic for “normalising” the database path: it can > be relative to $HOME and fallsback to $MAILDIR or $HOME/mail. However, this > logic is implemented in `notmuch_config_open` and is not available through > bindings.

[PATCH v2] build: drop support for xapian versions less than 1.4

2020-04-21 Thread Tomi Ollila
Xapian 1.4 is over 3 years old now (1.4.0 released 2016-06-24), and 1.2 has been deprecated in Notmuch version 0.27 (2018-06-13). Xapian 1.4 supports compaction, field processors and retry locking; conditionals checking compaction and field processors were removed but user may want to disable

Re: [PATCH] test: sort the output of the "prefix" test in T610-message-property

2020-04-20 Thread Tomi Ollila
{ print }' unsorted_OUTPUT > OUTPUT > +rm unsorted_OUTPUT > cat <<'EOF' >EXPECTED > == stdout == > alice > -- > 2.26.1 > --- > a better version of the previous patch I sent with head/tail replaced by an > awk > script by Tom

Re: [PATCH] test: sort the output of the "prefix" test in T610-message-property as needed

2020-04-18 Thread Tomi Ollila
On Fri, Apr 17 2020, Olivier Taïbi wrote: > the "prefix" test in T610-message-property extracts values from a > (key,value) map where multiple entries can have the same key, and the > entries are sorted by key, but not by value. The test incorrectly > assumes that the values will be sorted as

Re: timezone in notmuch

2020-04-15 Thread Tomi Ollila
On Tue, Apr 14 2020, di...@santanas.co.za wrote: > Greetings :) > > In notmuch-show-mode, some emails have a date like this: Date: Thu, 09 > Apr 2020 14:34:42 + while others like this Date: Sun, 12 Apr 2020 > 21:04:01 +0200 > > Is this something I can change in notmuch to always show the

Re: [PATCH] emacs doc: replace `...' with `...` in emacs docstrings for rst

2020-04-13 Thread Tomi Ollila
On Mon, Apr 13 2020, Tomi Ollila wrote: > Previously ' without preceding \ was replaced with `, to make emacs > document content structure `...' to work with reStructuredText. The change is good, but comment message crap. While trying to make rstdoc.el to load elisp code so that in docs

Re: [PATCH] zlib-related bugs

2020-04-13 Thread Tomi Ollila
On Fri, Apr 10 2020, Olivier Taïbi wrote: > the following diff addresses 3 zlib-related bugs in notmuch. > 3) in gz_getline(), if gz_error sets its second argument to Z_STREAM_END >then there was no error (only EOF). Unfortunately the zlib manual is >not very clear on the meaning of

Re: [PATCH 4/6] cli/dump: define GZPRINTF macro and use it in place of gzprintf

2020-04-13 Thread Tomi Ollila
On Mon, Apr 13 2020, David Bremner wrote: > This will at least catch errors, and can be replaced with more > sophisticated error handling where appropriate. > --- > notmuch-client.h | 4 > notmuch-dump.c | 24 > 2 files changed, 16 insertions(+), 12 deletions(-)

[PATCH] emacs doc: replace `...' with `...` in emacs docstrings for rst

2020-04-13 Thread Tomi Ollila
Previously ' without preceding \ was replaced with `, to make emacs document content structure `...' to work with reStructuredText. But there are also single uses of ' in parts of the extracted docstrings, so better "restrict" the matching content to `[^']+'. Dropped checking preceding \ before

Re: [PATCH 3/5] cli/dump: define GZPRINTF macro and use it in place of gzprintf

2020-04-13 Thread Tomi Ollila
On Sun, Apr 12 2020, David Bremner wrote: > This will at least catch errors, and can be replaced with more > sophisticated error handling where appropriate. > --- > notmuch-client.h | 3 +++ > notmuch-dump.c | 24 > 2 files changed, 15 insertions(+), 12 deletions(-) >

Re: [PATCH] test: add known_broken test for dumping large stored queries

2020-04-13 Thread Tomi Ollila
On Sun, Apr 12 2020, David Bremner wrote: > 'qsx' reported a bug on #notmuch with notmuch-dump and large stored > queries. This test will pass (on my machine) if the value of `repeat' > is made smaller. > --- > test/T240-dump-restore.sh | 13 + > 1 file changed, 13 insertions(+) > >

Re: notmuch-mode: Emails with PDF attachments incorrectly tagged as text/plain expose a few issues

2020-04-06 Thread Tomi Ollila
On Mon, Apr 06 2020, David Bremner wrote: > Leo Gaspard writes: > >> David Bremner writes: >> >>> Leo Gaspard writes: >>> Hello, I have recently started conversing with someone whose email client incorrectly tags PDF attachments as text/plain. >>> >>> Hi Leo; >>> >>>

Re: [PATCH 2/2] mime-node: Clean up unwrapped MIME parts correctly.

2020-03-20 Thread Tomi Ollila
On Thu, Mar 19 2020, Daniel Kahn Gillmor wrote: > Avoid a memory leak in the notmuch command line. > > gmime_multipart_encrypted_decrypt returns a GMimeObject marked by > GMime as "transfer full", so we are supposed to clean up after it. > > When parsing a message, notmuch would leak one

Re: [PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify

2020-03-18 Thread Tomi Ollila
On Wed, Mar 18 2020, Daniel Kahn Gillmor wrote: > GMIME_ENCRYPT_NONE and GMIME_VERIFY_NONE have the same value, but they > are different enumerated types. So in C, this is a cosmetic change, > but it is technically correct if we only had stricter typing. Change consistent with '@@ node_verify',

Re: [PATCH] Make notmuch-mutt script more portable

2020-03-16 Thread Tomi Ollila
On Mon, Mar 16 2020, Greg Anders wrote: > The -D flag to install (used in the Makefile) is GNU-specific and does > not work on BSD distributions (i.e. macOS). Likewise with the xargs -r > flag. These changes use portable alternatives to these flags while > preserving the exact behavior. Looks

Re: [PATCH] nmbug: explicitly prefer python3

2020-03-12 Thread Tomi Ollila
On Thu, Mar 12 2020, Daniel Kahn Gillmor wrote: > Two years later, I'd like to re-propose this patch that moves nmbug to > python3. > > I have read what PEP 394 says (thanks for the pointer, Trevor!) but in > practice (a) i do not see debian pointing /usr/bin/python to python3 any > time in the

Re: T050-new and T060-count fail if gdb prints a warning

2020-03-10 Thread Tomi Ollila
On Tue, Mar 10 2020, Dan Čermák wrote: > Hi list, > > I have encountered a test failure caused by the T050-new and T060-count > tests in the latest openSUSE-Tumbleweed rebuild with Python 3.8 instead > of Python 3.7. Both tests die with: > > --8<---cut

Re: [PATCH 6/6] notmuch-hello/jump: allow saved searches to specify unthreaded mode

2020-02-27 Thread Tomi Ollila
On Thu, Feb 27 2020, Mark Walters wrote: > Saved searches in notmuch-hello and notmuch-jump can specify whether > to use search mode or tree mode. This adds an option for them to > specify unthreaded mode. LGTM. Tomi > --- > emacs/notmuch-hello.el | 29 +++-- >

Re: [PATCH 5/6] Add a U binding to switch to unthreaded from other views

2020-02-27 Thread Tomi Ollila
On Thu, Feb 27 2020, Mark Walters wrote: > We have shortcuts S and Z to let the user switch to Search view and > Tree view with the current search. Add U to let the user switch to > unthreaded view from the current search, and ensure that S and Z > switch from unthreaded to search and tree veiew

Re: [PATCH 4/6] Unthreaded mode: allow user to choose different `show out' than tree

2020-02-27 Thread Tomi Ollila
On Thu, Feb 27 2020, Mark Walters wrote: > Tree mode allows the user to choose whether to use the split screen > displaying just the current message or a full screen displaying the > entire thread. As unthreaded mode is quite different in use the user > may want a different customisation for this

Re: [PATCH 3/6] Unthreaded mode: allow different result format

2020-02-27 Thread Tomi Ollila
On Thu, Feb 27 2020, Mark Walters wrote: > It is likely that the user will want a different line format for > unthreaded mode from tree mode; in particular the thread structure > graphics are unnecessary in unthreaded mode. > > Add a new customisable variable and set it to something sensible.

Re: [PATCH 2/6] Introduce unthreaded mode

2020-02-27 Thread Tomi Ollila
On Thu, Feb 27 2020, Mark Walters wrote: > This commit introduces a new 'unthreaded' search mode where each > matching message is shown on a separate line. It shares almost all of > its code with tree view. Subsequent commits will allow it to diverge > slightly in appearance. Could have just

Re: [PATCH 1/6] notmuch-show.c: add an option for messages to be returned unthreaded

2020-02-27 Thread Tomi Ollila
On Thu, Feb 27 2020, Mark Walters wrote: > This adds a --unthreaded option to notmuch show to tell it to return > the matching messages in an unthreaded order (so just by date). > > To make it easier for users, in particular for notmuch-tree.el, we > output each message with the same "nesting" as

[PATCH] build: drop support for xapian versions less than 1.4

2020-02-22 Thread Tomi Ollila
Xapian 1.4 is over 3 years old now (1.4.0 released 2016-06-24), and 1.2 has been deprecated in Notmuch version 0.27 (2018-06-13). Xapian 1.4 supports compaction, field processors and retry locking; conditionals checking compaction and field processors were removed but user may want to disable

Re: [PATCH] Drop deprecated/unused crypto.gpg_path

2020-02-18 Thread Tomi Ollila
On Tue, Feb 18 2020, Daniel Kahn Gillmor wrote: > crypto.gpg_path was only used when we built against gmime versions > before 3.0. Since we now depend on gmime 3.0.3 or later, it is > meaningless. > > The removal of the field from the _notmuch_config struct would be an > ABI change if that

Re: [PATCH 2/2] doc: add a hint about field processor support availability

2020-01-12 Thread Tomi Ollila
On Sat, Jan 11 2020, Jani Nikula wrote: > In most cases the documentation and the notmuch binary will be built > on the same machine and the same dependencies. Hint at the field > processor support availability in the man page based on the > documentation build host. I have to still grasp the

Re: [RFC PATCH] build: add meson build system

2020-01-12 Thread Tomi Ollila
On Sun, Jan 12 2020, Jani Nikula wrote: > On Sun, 12 Jan 2020, David Bremner wrote: >> Jani Nikula writes: >> >>> This is a draft patch adding basic configure, build and test support >>> for the binaries. Everything else is left out for now. It would be a >>> considerable amount of work to

Re: [PATCH 2/2] legacy-display: drop tests that try to match headers in a Legacy Display part

2019-12-28 Thread Tomi Ollila
On Mon, Dec 23 2019, Daniel Kahn Gillmor wrote: > These tests were an attempt to establish that the content of the > "Legacy Display" part is the same as the actual protected headers of > the message. But this is more conservative than we need to be. > >

Re: message.el and browse-url.el interaction [was: Re: BUG: notmuch-emacs-mua wrong signing MML placement]

2019-12-12 Thread Tomi Ollila
On Fri, Dec 13 2019, Tomi Ollila wrote: > On Thu, Dec 12 2019, David Edmondson wrote: > >> On Wednesday, 2019-12-11 at 13:55:16 -05, Robbie Harwood wrote: >> >>> My emacs config contains `(add-hook 'message-setup-hook >>> 'mml-secure-sign-pgpmime)` as re

Re: compacting the notmuch database through systemd

2019-12-12 Thread Tomi Ollila
On Sun, Dec 08 2019, David Bremner wrote: > Jorge P. de Morais Neto writes: > >> Em [2019-12-06 sex 14:41:22-0500], Daniel Kahn Gillmor escreveu: >> >>> As for the variations, i'm kind of of a mind that people who deviate >>> from the defaults should need to maintain their own deviance

  1   2   3   4   5   6   7   8   9   10   >