Re: [PATCH 04/27] emacs: don't fset keymaps

2020-11-11 Thread William Casarin
rs.") > -(fset 'notmuch-search-mode-map notmuch-search-mode-map) > > (defvar notmuch-search-stash-map >(let ((map (make-sparse-keymap))) > -- > 2.29.1 I believe this makes sense. Looks like they were first introduced in early versions of the code... Reviewed-by: William Casarin Tested-by: William Casarin ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH 02/27] emacs: define notmuch-message-mode-map explicitly

2020-11-11 Thread William Casarin
uch-mua-send-and-exit) > -(define-key notmuch-message-mode-map (kbd "C-c C-s") #'notmuch-mua-send) > -(define-key notmuch-message-mode-map (kbd "C-c C-p") > #'notmuch-draft-postpone) > -(define-key notmuch-message-mode-map (kbd "C-x C-s") #'n

Re: [PATCH 01/27] emacs: silence byte-compiler

2020-11-11 Thread William Casarin
Jonas Bernoulli writes: > William Casarin writes: >> LGTM, I have a similar patch here: id:20200908171536.20679-1-j...@jb55.com > > So if I understood correctly the problem with that was that you were > unable to run the tests and therefore couldn't confirm that you fixed &

Re: [PATCH 01/27] emacs: silence byte-compiler

2020-11-08 Thread William Casarin
gt; (defvar notmuch-search-query-string) LGTM, I have a similar patch here: id:20200908171536.20679-1-j...@jb55.com Reviewed-by: William Casarin ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

[PATCH] emacs/tree: declare notmuch-search functions

2020-09-08 Thread William Casarin
enable moving to next thread in search results") Reported-by: Danilo G. Baio Signed-off-by: William Casarin --- Hey there, "Danilo G. Baio" writes: > Hi William. > > I'm updating notmuch on FreeBS

Re: [PATCH 2/5] NEWS: mention exception handling changes

2020-08-23 Thread William Casarin
David Bremner writes: > --- > NEWS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/NEWS b/NEWS > index c1f09b18..e6392e81 100644 > --- a/NEWS > +++ b/NEWS > @@ -16,6 +16,14 @@ files to a maildir for mutt to access is replaced with > internal perl > processing. This search

Re: [PATCH] NEWS: add news entry for tree navigation changes

2020-08-23 Thread William Casarin
David Bremner writes: > William Casarin writes: > >> Signed-off-by: William Casarin >> --- >> NEWS | 2 ++ >> 1 file changed, 2 insertions(+) >> > > Applied to master and release, with a tiny wording change. > > I realized when looking at thi

[PATCH] NEWS: add news entry for tree navigation changes

2020-08-22 Thread William Casarin
Signed-off-by: William Casarin --- NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS b/NEWS index b25bfaa3..9e635ab6 100644 --- a/NEWS +++ b/NEWS @@ -6,6 +6,8 @@ Emacs The minimum supported major version of GNU Emacs is now 25.1. +Support for moving between threads after

[PATCH v2 2/3] emacs/tree: enable moving to next thread in search results

2020-08-11 Thread William Casarin
when using the M-Enter, M-n and M-p bindings. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 40 +--- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index 29f64851..bf500b60 100644

[PATCH v2 3/3] emacs/tree: add notmuch-tree-archive-thread-then-next

2020-08-11 Thread William Casarin
Now that notmuch-tree-next-thread acts more like its notmuch-show counterpart, let's update the binding to move to the next thread after archiving. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch

[PATCH v2 1/3] emacs/tree: introduce notmuch-tree-parent-buffer variable

2020-08-11 Thread William Casarin
This variable will be used in a similar fashion to notmuch-show-parent-buffer. It will be used to navigate between threads from the parent search buffer. Signed-off-by: William Casarin --- This is a rebased version of id:20200423234715.6633-1-j...@jb55.com on top of Jonas' emacs cleanups

Re: [PATCH] emacs/tree: add notmuch-tree-filter

2020-05-31 Thread William Casarin
Tomi Ollila writes: > On Sat, Apr 25 2020, William Casarin wrote: > >> This implements the notmuch-tree version of notmuch-show-filter-thread >> and binds it to the L key. > > No reasoning in commit message why 'L' is chosen... oh right this should probably be `l`. I

[PATCH] emacs/tree: add notmuch-tree-filter

2020-04-25 Thread William Casarin
This implements the notmuch-tree version of notmuch-show-filter-thread and binds it to the L key. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 9 + 1 file changed, 9 insertions(+) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index e5c23de2..8f7738d7 100644

Re: [PATCH 2/3] emacs/tree: enable moving to next thread in search results

2020-04-23 Thread William Casarin
William Casarin writes: > This introduces a new function called > notmuch-tree-next-thread-from-search which is analogous to > notmuch-show-next-thread. It will switch to the next or previous > thread from the parent search results. > > We rename notmuch-tree-{prev,next

[PATCH 2/3] emacs/tree: enable moving to next thread in search results

2020-04-23 Thread William Casarin
when using the M-Enter, M-n and M-p bindings. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index f38fef98..dcd335e5 100644 --- a/emacs

[PATCH 3/3] emacs/tree: add notmuch-tree-archive-thread-then-next

2020-04-23 Thread William Casarin
Now that notmuch-tree-next-thread acts more like its notmuch-show counterpart, let's update the binding to move to the next thread after archiving. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch

[PATCH 1/3] emacs/tree: introduce notmuch-tree-parent-buffer variable

2020-04-23 Thread William Casarin
This variable will be used in a similar fashion to notmuch-show-parent-buffer. It will be used to navigate between threads from the parent search buffer. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 7 ++- emacs/notmuch.el | 4 +++- 2 files changed, 9 insertions(+), 2

[PATCH] emacs/tree: add notmuch-tree-quit-all

2020-04-23 Thread William Casarin
This is a simple binding in notmuch-tree-mode that closes both the message buffer and thread buffer at the same time. This is a common action after entering a thread from search with M-Enter. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 5 + 1 file changed, 5 insertions

[PATCH] emacs: Use `cl-lib' instead of deprecated `cl'

2020-04-16 Thread William Casarin
From: Jonas Bernoulli Starting with Emacs 27 the old `cl' implementation is finally considered obsolete. Previously its use was strongly discouraged at run-time but one was still allowed to use it at compile-time. For the most part the transition is very simple and boils down to adding the

Re: [PATCH 1/7] emacs/tree: return true if a thread was found in next-thread

2020-04-04 Thread William Casarin
William Casarin writes: > This will allow us to pop back to parent buffers when there are no > more threads to jump to. > > Signed-off-by: William Casarin > --- > > This is as rebased version of id:20191228150124.20630-1-j...@jb55.com > as requested in id:87v9mg3gut

[PATCH v4 4/7] emacs/tree: add kill-both prefix argument to notmuch-tree-quit

2020-04-04 Thread William Casarin
This allows us to close both windows at the same time. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index e6a6e67f..b405e9e3 100644 --- a/emacs/notmuch-tree.el

[PATCH v4 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2020-04-04 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-message-than-next-or-exit. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index

[PATCH v4 7/7] emacs/tree: add x/X bindings

2020-04-04 Thread William Casarin
Add x and X binds to notmuch-tree for functionally that we have in notmuch-show. The notmuch-tree-quit binding is somewhat redundant, since it is handled by notmuch-bury-or-kill-this-buffer which is bound to q. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 3 ++- 1 file changed, 2

[PATCH v4 3/7] emacs/tree: add notmuch-tree-matching-message

2020-04-04 Thread William Casarin
This functions removes some duplicate logic between notmuch-tree-{next,prev}-matching-message We do this because we will be adding some additional logic similar to the notmuch-show-next-open-message function, and it will help if this logic is all in one place. Signed-off-by: William Casarin

[PATCH v4 6/7] emacs/tree: add notmuch-tree-archive-thread-then-exit

2020-04-04 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-thread-then-exit Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 ++ 1 file changed, 6 insertions(+) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index 02bdd1ee..470cd517 100644 --- a/emacs/notmuch-tree.el

[PATCH v4 2/7] emacs/tree: add notmuch-tree-goto-matching-message

2020-04-04 Thread William Casarin
This function captures some common logic when jumping to matching messages in notmuch-tree mode. We also add a new return value (t or nil), that indicates if there was a next matching message in the thread to show. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 18

[PATCH v4 1/7] emacs/tree: return true if a thread was found in next-thread

2020-04-04 Thread William Casarin
This will allow us to pop back to parent buffers when there are no more threads to jump to. Signed-off-by: William Casarin --- This is just a rebased version of v3 id:20191228150124.20630-1-j...@jb55.com as requested in id:87v9mg3gut@tethera.net emacs/notmuch-tree.el | 5 - 1 file

[PATCH 2/7] emacs/tree: add notmuch-tree-goto-matching-message

2020-04-04 Thread William Casarin
This function captures some common logic when jumping to matching messages in notmuch-tree mode. We also add a new return value (t or nil), that indicates if there was a next matching message in the thread to show. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 18

[PATCH 3/7] emacs/tree: add notmuch-tree-matching-message

2020-04-04 Thread William Casarin
This functions removes some duplicate logic between notmuch-tree-{next,prev}-matching-message We do this because we will be adding some additional logic similar to the notmuch-show-next-open-message function, and it will help if this logic is all in one place. Signed-off-by: William Casarin

[PATCH 1/7] emacs/tree: return true if a thread was found in next-thread

2020-04-04 Thread William Casarin
This will allow us to pop back to parent buffers when there are no more threads to jump to. Signed-off-by: William Casarin --- This is as rebased version of id:20191228150124.20630-1-j...@jb55.com as requested in id:87v9mg3gut@tethera.net emacs/notmuch-tree.el | 5 - 1 file changed

[PATCH 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2020-04-04 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-message-than-next-or-exit. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index

[PATCH 4/7] emacs/tree: add kill-both prefix argument to notmuch-tree-quit

2020-04-04 Thread William Casarin
This allows us to close both windows at the same time. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index e6a6e67f..b405e9e3 100644 --- a/emacs/notmuch-tree.el

Re: [PATCH v3 0/7] Port notmuch-show's x/X bindings to notmuch-tree

2020-03-23 Thread William Casarin
Hey there, David Edmondson writes: > On Friday, 2020-02-21 at 09:06:46 -08, William Casarin wrote: > >> Daniel Kahn Gillmor writes: >> >>> On Sat 2019-12-28 10:01:17 -0500, William Casarin wrote: >>>> These patches bring notmuch-tree more in line with t

Re: [PATCH v3 0/7] Port notmuch-show's x/X bindings to notmuch-tree

2020-02-21 Thread William Casarin
Daniel Kahn Gillmor writes: > On Sat 2019-12-28 10:01:17 -0500, William Casarin wrote: >> These patches bring notmuch-tree more in line with the user experience >> of notmuch-show by adding the x/X bindings. > > It looks like this series has been reviewed by dme, and is

[PATCH v3 6/7] emacs/tree: add notmuch-tree-archive-thread-then-exit

2019-12-28 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-thread-then-exit Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 ++ 1 file changed, 6 insertions(+) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index cdf68ed4..e9c0433c 100644 --- a/emacs/notmuch-tree.el

[PATCH v3 7/7] emacs/tree: add x/X bindings

2019-12-28 Thread William Casarin
Add x and X binds to notmuch-tree for functionally that we have in notmuch-show. The notmuch-tree-quit binding is somewhat redundant, since it is handled by notmuch-bury-or-kill-this-buffer which is bound to q. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 3 ++- 1 file changed, 2

[PATCH v3 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2019-12-28 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-message-than-next-or-exit. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index

[PATCH v3 3/7] emacs/tree: add notmuch-tree-matching-message

2019-12-28 Thread William Casarin
This functions removes some duplicate logic between notmuch-tree-{next,prev}-matching-message We do this because we will be adding some additional logic similar to the notmuch-show-next-open-message function, and it will help if this logic is all in one place. Signed-off-by: William Casarin

[PATCH v3 2/7] emacs/tree: add notmuch-tree-goto-matching-message

2019-12-28 Thread William Casarin
This function captures some common logic when jumping to matching messages in notmuch-tree mode. We also add a new return value (t or nil), that indicates if there was a next matching message in the thread to show. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 18

[PATCH v3 4/7] emacs/tree: add kill-both prefix argument to notmuch-tree-quit

2019-12-28 Thread William Casarin
This allows us to close both windows at the same time. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index 25d84f45..f66219c5 100644 --- a/emacs/notmuch-tree.el

[PATCH v3 0/7] Port notmuch-show's x/X bindings to notmuch-tree

2019-12-28 Thread William Casarin
.@jb55.com since it has already been upstreamed v2: id:20191128161401.28844-1-j...@jb55.com - fix a bug when moving between open messages - include M-RET keybinding patch from id:20191113225752.26502-1-j...@jb55.com v1: id:20191117222929.1064-1-j...@jb55.com William Casarin (7): emacs/tr

[PATCH v3 1/7] emacs/tree: return true if a thread was found in next-thread

2019-12-28 Thread William Casarin
This will allow us to pop back to parent buffers when there are no more threads to jump to. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index c00315e8..d262ba26

Re: Handle PKCS#7 signedData (S/MIME single-part clearsigned)

2019-12-09 Thread William Casarin
Hey Daniel, Daniel Kahn Gillmor writes: > Several of the patches should be simple to read and uncontroversial (I > hope!), and I welcome/encourage merging of those patches to reduce the > length of the remaining series. I did a quick skim and it looks ok, although I'm not super familiar with

Re: [PATCH v2 0/8] Port notmuch-show's x/X bindings to notmuch-tree

2019-12-04 Thread William Casarin
Teemu Likonen writes: > William Casarin [2019-11-28T08:13:53-08] wrote: > >> These patches bring notmuch-tree more in line with the user experience >> of notmuch-show by adding the x/X bindings. >> >> v2: >> - fix a bug when moving between open messages &

Re: [PATCH v2 2/8] emacs/tree: add notmuch-tree-goto-matching-message

2019-12-04 Thread William Casarin
David Edmondson writes: > On Thursday, 2019-11-28 at 08:13:55 -08, William Casarin wrote: > >> This function captures some common logic when jumping to matching >> messages in notmuch-tree mode. >> >> We also add a new return value (t or nil), that indicates i

Re: [PATCH v2 1/8] emacs/tree: return true if a thread was found in next-thread

2019-12-04 Thread William Casarin
David Edmondson writes: > On Thursday, 2019-11-28 at 08:13:54 -08, William Casarin wrote: > >> This will allow us to pop back to parent buffers when there are no >> more threads to jump to. >> >> Signed-off-by: William Casarin >> --- >> emacs/notmuch-

[PATCH v2 6/8] emacs/tree: add notmuch-tree-archive-thread-then-exit

2019-11-28 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-thread-then-exit Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 ++ 1 file changed, 6 insertions(+) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index 8e596459..40838487 100644 --- a/emacs/notmuch-tree.el

[PATCH v2 8/8] emacs: bind M-RET to notmuch-tree-from-search-thread

2019-11-28 Thread William Casarin
This is an unbound function that is quite useful. It opens a selected thread in notmuch-tree from the current search query. Signed-off-by: William Casarin --- emacs/notmuch.el | 1 + 1 file changed, 1 insertion(+) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 773d1206..0d68d123 100644

[PATCH v2 5/8] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2019-11-28 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-message-than-next-or-exit. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index

[PATCH v2 7/8] emacs/tree: add x/X bindings

2019-11-28 Thread William Casarin
Add x and X binds to notmuch-tree for functionally that we have in notmuch-show. The notmuch-tree-quit binding is somewhat redundant, since it is handled by notmuch-bury-or-kill-this-buffer which is bound to q. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 3 ++- 1 file changed, 2

[PATCH v2 3/8] emacs/tree: add notmuch-tree-matching-message

2019-11-28 Thread William Casarin
This functions removes some duplicate logic between notmuch-tree-{next,prev}-matching-message We do this because we will be adding some additional logic similar to the notmuch-show-next-open-message function, and it will help if this logic is all in one place. Signed-off-by: William Casarin

[PATCH v2 4/8] emacs/tree: add kill-both prefix argument to notmuch-tree-quit

2019-11-28 Thread William Casarin
This allows us to close both windows at the same time. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index b9173790..367b10c4 100644 --- a/emacs/notmuch-tree.el

[PATCH v2 0/8] Port notmuch-show's x/X bindings to notmuch-tree

2019-11-28 Thread William Casarin
William Casarin (8): emacs/tree: return true if a thread was found in next-thread emacs/tree: add notmuch-tree-goto-matching-message emacs/tree: add notmuch-tree-matching-message emacs/tree: add kill-both prefix argument to notmuch-tree-quit emacs/tree: add notmuch-tree-archive-message-than

[PATCH v2 2/8] emacs/tree: add notmuch-tree-goto-matching-message

2019-11-28 Thread William Casarin
This function captures some common logic when jumping to matching messages in notmuch-tree mode. We also add a new return value (t or nil), that indicates if there was a next matching message in the thread to show. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 17

[PATCH v2 1/8] emacs/tree: return true if a thread was found in next-thread

2019-11-28 Thread William Casarin
This will allow us to pop back to parent buffers when there are no more threads to jump to. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index c00315e8..4bc05160

Re: [PATCH 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2019-11-18 Thread William Casarin
David Edmondson writes: > On Sunday, 2019-11-17 at 15:17:58 -08, William Casarin wrote: > >> I'll push out a v2 later if this gets enough Concept ACKs. > > The changes make sense to me in principle, but I don't use > notmuch-tree. It would be good if someone who does could t

Re: [PATCH 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2019-11-17 Thread William Casarin
William Casarin writes: > This is the notmuch-tree version of > notmuch-show-archive-message-than-next-or-exit. > > Signed-off-by: William Casarin > --- > emacs/notmuch-tree.el | 30 -- > 1 file changed, 20 insertions(+), 10 deletions(-) &

[PATCH 0/7] Port notmuch-show's x/X bindings to notmuch-tree

2019-11-17 Thread William Casarin
These patches bring notmuch-tree more in line with the user experience of notmuch-show by adding the x/X bindings. id:20191113225752.26502-1-j...@jb55.com is also recommended, it adds a bind for opening a thread in notmuch-tree mode. William Casarin (7): emacs/tree: return true if a thread

[PATCH 7/7] emacs/tree: add x/X bindings

2019-11-17 Thread William Casarin
Add x and X binds to notmuch-tree for functionally that we have in notmuch-show. The notmuch-tree-quit binding is somewhat redundant, since it is handled by notmuch-bury-or-kill-this-buffer which is bound to q. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 3 ++- 1 file changed, 2

[PATCH 4/7] emacs/tree: add kill-both prefix argument to notmuch-tree-quit

2019-11-17 Thread William Casarin
This allows us to close both windows at the same time. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index b9173790..367b10c4 100644 --- a/emacs/notmuch-tree.el

[PATCH 3/7] emacs/tree: add notmuch-tree-matching-message

2019-11-17 Thread William Casarin
This functions removes some duplicate logic between notmuch-tree-{next,prev}-matching-message We do this because we will be adding some additional logic similar to the notmuch-show-next-open-message function, and it will help if this logic is all in one place. Signed-off-by: William Casarin

[PATCH 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2019-11-17 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-message-than-next-or-exit. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index

[PATCH 2/7] emacs/tree: add notmuch-tree-goto-matching-message

2019-11-17 Thread William Casarin
This function captures some common logic when jumping to matching messages in notmuch-tree mode. We also add a new return value (t or nil), that indicates if there was a next matching message in the thread to show. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 17

[PATCH 1/7] emacs/tree: return true if a thread was found in next-thread

2019-11-17 Thread William Casarin
This will allow us to pop back to parent buffers when there are no more threads to jump to. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index c00315e8..4bc05160

[PATCH 6/7] emacs/tree: add notmuch-tree-archive-thread-then-exit

2019-11-17 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-thread-then-exit Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 ++ 1 file changed, 6 insertions(+) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index fd6f9f83..b8844b64 100644 --- a/emacs/notmuch-tree.el

[PATCH] emacs: bind M-RET to notmuch-tree-from-search-thread

2019-11-13 Thread William Casarin
This is an unbound function that is quite useful. It opens a selected thread in notmuch-tree from the current search query. Signed-off-by: William Casarin --- This is a simpler alternative to id:20191113080004.32214-1-j...@jb55.com emacs/notmuch.el | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] emacs: bind C-u Z to notmuch-tree-from-search-thread

2019-11-13 Thread William Casarin
Teemu Likonen writes: > William Casarin [2019-11-13T00:00:04-08] wrote: > >> This is an unbound function that is quite useful. It opens a selected >> thread in notmuch-tree from the current search query. > > I agree that it is good idea to bind notmuch-tree-from-search-t

Re: [PATCH] emacs: bind C-u Z to notmuch-tree-from-search-thread

2019-11-13 Thread William Casarin
David Edmondson writes: > On Wednesday, 2019-11-13 at 00:00:04 -08, William Casarin wrote: > >> This is an unbound function that is quite useful. It opens a selected >> thread in notmuch-tree from the current search query. > > Seems fine to me. Not crazy about the bind

Re: Unread handling

2019-11-12 Thread William Casarin
Teemu Likonen writes: > Teemu Likonen [2019-11-12T16:54:35+02] wrote: > >> But indeed, a command like "notmuch-search-show-thread-tree" (M-RET, >> C-u RET, C-RET...) would be useful: open current thread directly in >> tree view and with current search terms. > > But that is already there

Re: Unread handling

2019-11-12 Thread William Casarin
David Edmondson writes: > On Tuesday, 2019-11-12 at 05:17:46 -08, William Casarin wrote: > >> David Edmondson writes: >>> On Monday, 2019-11-11 at 00:16:17 +01, Johan Parin wrote: >>>> I'm trying instead to use the tree view, this seems to me the >>&g

Re: Unread handling

2019-11-12 Thread William Casarin
Teemu Likonen writes: > William Casarin [2019-11-12T05:17:46-08] wrote: > >> I find myself doing `c i z Ctrl-v` to open the tree view for a >> specific thread, but perhaps it would make sense if there was a >> default keybind for this. > > Seems like the same as pre

Re: Unread handling

2019-11-12 Thread William Casarin
David Edmondson writes: > On Monday, 2019-11-11 at 00:16:17 +01, Johan Parin wrote: >> I'm trying instead to use the tree view, this seems to me the >> more natural way to view threads. So I immediately do `Z' >> whenever I enter a thread. I would like to have the option to >> enter tree view

Re: v3 of legacy-display cleanup

2019-06-24 Thread William Casarin
Daniel Kahn Gillmor writes: > This is the third revision of the series that cleans up legacy-display > protected headers parts so that notmuch users only have to look at one > subject line. > > version 2 can be found at id:20190531075907.17035-1-...@fifthhorseman.net > version 1 can be found at

Re: [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display

2019-06-24 Thread William Casarin
Daniel Kahn Gillmor writes: > This is a utility function designed to make it easier to > "fast-forward" past a legacy-display part associated with a > cryptographic envelope, and show the user the intended message body. > > The bulk of the ugliness in here is in the test function >

Re: [PATCH 1/7] mime-node: split out _mime_node_set_up_part

2019-06-24 Thread William Casarin
Daniel Kahn Gillmor writes: > This is a code reorganization that should have no functional effect, > but will make future changes simpler, because a future commit will > reuse the _mime_node_set_up_part functionality without touching > _mime_node_create. > > In the course of splitting out this

Re: [PATCH] emacs: add keywords to notmuch-emacs-mua.desktop

2019-06-24 Thread William Casarin
Daniel Kahn Gillmor writes: > Ping! If there is a reason that this trivial patch has languished, i'd > be happy to receive critical feedback. Or maybe we can just merge it? > >--dkg Looks good to me! -- https://jb55.com ___ notmuch mailing list

[PATCH] perf-tests: #!/bin/bash -> #!/usr/bin/env bash

2019-05-31 Thread William Casarin
I couldn't run the performance tests on my machines due to a hardcoded bash path. Use env for finding bash in weird systems like NixOS. Signed-off-by: William Casarin --- performance-test/M00-new.sh | 2 +- performance-test/M01-dump-restore.sh| 2 +- performance-test/M02-show.sh

Re: [PATCH] Fix notmuch-describe-key

2019-03-03 Thread William Casarin
Yang Sheng writes: > Fix notmuch-describe-key crashing for the following two cases > 1. format-kbd-macro cannot deal with keys like [(32 . 126)], switch to > use key-description instead. > 2. if a function in the current keymap is not bounded, it will crash > the whole process. We check if it is

Re: [PATCH] emacs: filter tag completions by current query

2018-11-24 Thread William Casarin
William Casarin writes: > When filtering by tags in notmuch-search-filter-by-tag, only return tags > related to the current query. > > Before, it was returning all tags. There's no reason to refine the > current query with tags that don't exist in the current result set.

Re: How do you sync your mail constantly?

2018-11-03 Thread William Casarin
Vika Shleina writes: > And to maybe think of alternative solution, I ask you - what do you use > to seamlessly sync your mail? I use a script[1] that connects to my imap server. New mail comes into my sieve-filtered inbox[2] which then triggers the imap-notify[1] script on my local machine.

Re: Proposed New sort API

2018-10-20 Thread William Casarin
David Bremner writes: > William Casarin writes: > >> Another thought I had that I wanted to throw out there for >> consideration. It would be nice to be able to sort by "popular" threads, >> aka sort by the number of messages in each thread. Not sure

Re: [PATCH RFC] index: add body: search query term

2018-10-10 Thread William Casarin
William Casarin writes: > I wonder if it's all worth the effort though, since a workaround could > be: > > notmuch search and not subject: > > If it's too annoying to have a body prefix, due to index bloat or > performance issues, would doing something hacky such a

Re: [PATCH RFC] index: add body: search query term

2018-10-10 Thread William Casarin
David Bremner writes: > William Casarin writes: > I think you'll find you broke non-prefixed queries. Does the test suite > still pass? If so, we need more tests. yeah they seem to pass. but you're right, something seems a bit off: ./notmuch count subject:github or bo

[PATCH RFC] index: add body: search query term

2018-10-09 Thread William Casarin
This adds the ability to search specifically on the body eg. notmuch search tag:notmuch and body:PATCH Signed-off-by: William Casarin --- Hey there, I'm looking to add the ability to search specifically on the body. I was poking around in the indexer, added these lines and reindexed

Re: Proposed New sort API

2018-10-08 Thread William Casarin
David Bremner writes: > I started looking at William's sorting patches [1], but the > proliferation of sorting options bugged me a bit. I decided to sketch > out a new more flexible API. > > In the new API, there is is a sort "key", currently mapped one-to-one > to value slots, but potentially

Re: [PATCH 1/2] WIP: groundwork for new sorting API

2018-10-08 Thread William Casarin
David Bremner writes: > --- a/lib/notmuch.h > +++ b/lib/notmuch.h > @@ -773,6 +773,10 @@ notmuch_query_create (notmuch_database_t *database, > * Sort values for notmuch_query_set_sort. > */ > typedef enum { > +/** > + * Value was not set > + */ > +NOTMUCH_SORT_UNSET = -1, >

[PATCH] emacs: filter tag completions by current query

2018-10-08 Thread William Casarin
When filtering by tags in notmuch-search-filter-by-tag, only return tags related to the current query. Before, it was returning all tags. There's no reason to refine the current query with tags that don't exist in the current result set. Signed-off-by: William Casarin --- emacs/notmuch.el | 2

Re: unused/total message counts in hello screen?

2018-09-30 Thread William Casarin
Jeff Templon writes: > An alternative would be if I could toggle the entire page to show just > the unread tags (so any tags for which all messages were read would > just not show up). Maybe even preferable, that last one. This can be done setting "notmuch-hello-tag-list-make-query" to

Re: Sorting & grouping

2018-07-23 Thread William Casarin
Leonard Lausen writes: > What do you think about adding a 'group' option that will group mails > with the same set of tags (possibly minus a list of tags to be ignored > when grouping) and apply the normal search. Hmm. I think could be simplified by sorting by a specific tag, and then by date,

Re: GitHub + notmuch scripts/hacks

2018-06-24 Thread William Casarin
William Casarin writes: > I've started collecting[1] a bunch of notmuch+GitHub hacks from some of > the discussions @ id:87d16jtsdj@kyleam.com > [..] > > [1] https://github.com/jb55/notmuch-github > [2] > https://github.com/jb55/notmuch-github/commit/fb2d80cf9ee9a5967c7

Re: Proposed New sort API

2017-12-10 Thread William Casarin
David Bremner writes: > I started looking at William's sorting patches [1], but the > proliferation of sorting options bugged me a bit. I decided to sketch > out a new more flexible API. > > In the new API, there is is a sort "key", currently mapped one-to-one > to value

Re: [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments

2017-10-14 Thread William Casarin
Tested ACK 1-3 + id:20171014201836.4486-1-j...@nikula.org ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments

2017-10-14 Thread William Casarin
Jani Nikula writes: > *blush* I screwed those enums up. Here's a patch that takes care of both > issues id:20171014201836.4486-1-j...@nikula.org. It's independent of > this series. Works, thanks. -- https://jb55.com ___ notmuch

Re: [bug] [emacs] notmuch-show: names not shown on some mailing lists

2017-10-14 Thread William Casarin
Nevermind, the issue seems to go away on master Sorry for the noise... ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments

2017-10-14 Thread William Casarin
Hey Jani, Patches look good so far, concept ack for sure. Jani Nikula writes: > For example, you can use --no-exclude instead of --exclude=false in > notmuch show. If we had keyword flag arguments with some flags > defaulting to on, say --include=tags in notmuch

Re: [bug] [emacs] notmuch-show: names not shown on some mailing lists

2017-10-14 Thread William Casarin
William Casarin <j...@jb55.com> writes: > Jani Nikula <j...@nikula.org> writes: > >> The information comes from the cli. Can you reproduce this using some >> notmuch show --format=sexp --body=false query, perhaps on just one of >> the messages? > > I get

Re: [bug] [emacs] notmuch-show: names not shown on some mailing lists

2017-10-14 Thread William Casarin
Jani Nikula writes: > The information comes from the cli. Can you reproduce this using some > notmuch show --format=sexp --body=false query, perhaps on just one of > the messages? I get this: :From "Person via Mailing list\011" --

GitHub + notmuch scripts/hacks

2017-10-13 Thread William Casarin
Hey there, I've started collecting[1] a bunch of notmuch+GitHub hacks from some of the discussions @ id:87d16jtsdj@kyleam.com I've added the ability to comment on/approve/reject pull requests from a GitHub pull-request email[2]. It can also open a magit-log view of the PR from an email, as

Re: Washing GitHub emails to include inline patch?

2017-10-13 Thread William Casarin
Kyle Meyer writes: > Looking at what I wrote again, I'd change DONT-FETCH to FORCE-FETCH and > then do something like > > (when (or force-fetch > (not (magit-ref-exists-p local-ref))) > (magit-call-git "fetch" "origin")) > > where local-ref is bound to

Re: Washing GitHub emails to include inline patch?

2017-10-12 Thread William Casarin
Kyle Meyer writes: > --8<---cut here---start->8--- > > (defun km/notmuch-github-pr-number () > "Return the PR number for this message." > (let (pr) > (with-current-notmuch-show-message > (goto-char (point-min)) > (if

  1   2   >