On Tue, 9 Aug 2011 19:32:49 +0200, Daniel Schoepe wrote:
> This patch adds completion with in the minibuffer for
> notmuch-search and notmuch-search-filter.
Finally pushed.
d
On Tue, 9 Aug 2011 19:32:49 +0200, Daniel Schoepe
wrote:
> This patch adds completion with in the minibuffer for
> notmuch-search and notmuch-search-filter.
Finally pushed.
d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/m
This patch adds completion with in the minibuffer for
notmuch-search and notmuch-search-filter.
---
emacs/notmuch.el | 37 +++--
1 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index f11ec24..bb7565c 100644
---
On Fri, 05 Aug 2011 23:09:23 -0700, Jameson Graef Rollins wrote:
> Hey, Daniel. I actually just ran into a little bug with this patch.
> After applying this patch, if I try to scroll/search through my
> mini-buffer history after a search I get the following error:
>
> previous-history-element: W
On Tue, 09 Aug 2011 19:31:44 +0200, Daniel Schoepe
wrote:
> Turns out, I just used `read-from-minibuffer' incorrectly, here's an
> updated version.
Hey, Daniel. Thanks so much for the quick fix! This new patch seems to
work great.
Signed-off-by: Jameson Graef Rollins
jamie.
On Tue, 09 Aug 2011 19:31:44 +0200, Daniel Schoepe wrote:
> Turns out, I just used `read-from-minibuffer' incorrectly, here's an
> updated version.
Hey, Daniel. Thanks so much for the quick fix! This new patch seems to
work great.
Signed-off-by: Jameson Graef Rollins
jamie.
This patch adds completion with in the minibuffer for
notmuch-search and notmuch-search-filter.
---
emacs/notmuch.el | 37 +++--
1 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index f11ec24..bb7565c 100644
---
On Fri, 05 Aug 2011 23:09:23 -0700, Jameson Graef Rollins
wrote:
> Hey, Daniel. I actually just ran into a little bug with this patch.
> After applying this patch, if I try to scroll/search through my
> mini-buffer history after a search I get the following error:
>
> previous-history-element:
Hey, Daniel. I actually just ran into a little bug with this patch.
After applying this patch, if I try to scroll/search through my
mini-buffer history after a search I get the following error:
previous-history-element: Wrong type argument: symbolp, "tag:signed"
I get this error no matter what m
Hey, Daniel. I actually just ran into a little bug with this patch.
After applying this patch, if I try to scroll/search through my
mini-buffer history after a search I get the following error:
previous-history-element: Wrong type argument: symbolp, "tag:signed"
I get this error no matter what m
On Mon, 06 Jun 2011 18:32:41 +0200, Daniel Schoepe wrote:
> [..]
I've been using this patch for the past two months now and it has been
working fine. Are there any more suggestions or criticisms about this?
Cheers,
Daniel
-- next part --
A non-text attachment was scrubbed
From: Daniel Schoepe
This patch adds completion with in the minibuffer for
notmuch-search and notmuch-search-filter.
---
This is a slightly tweaked version of this original patch that removes
an errant space and uses "search --output=tags" instead of the
deprecated "search-tags".
emacs/notmuch
From: Daniel Schoepe
This patch adds completion with in the minibuffer for
notmuch-search and notmuch-search-filter.
---
This is a slightly tweaked version of this original patch that removes
an errant space and uses "search --output=tags" instead of the
deprecated "search-tags".
emacs/notmuch
On Fri, 05 Aug 2011 17:17:56 +0200, Daniel Schoepe
wrote:
> On Mon, 06 Jun 2011 18:32:41 +0200, Daniel Schoepe
> wrote:
> I've been using this patch for the past two months now and it has been
> working fine. Are there any more suggestions or criticisms about this?
Hey, Daniel. This is a real
On Fri, 05 Aug 2011 17:17:56 +0200, Daniel Schoepe wrote:
> On Mon, 06 Jun 2011 18:32:41 +0200, Daniel Schoepe googlemail.com> wrote:
> I've been using this patch for the past two months now and it has been
> working fine. Are there any more suggestions or criticisms about this?
Hey, Daniel. Th
On Mon, 06 Jun 2011 18:32:41 +0200, Daniel Schoepe
wrote:
> [..]
I've been using this patch for the past two months now and it has been
working fine. Are there any more suggestions or criticisms about this?
Cheers,
Daniel
pgpoxgMn2II98.pgp
Description: PGP signature
__
I accidentally left a, now unnecessary, defvar in the patch from one of
the previous attempts, here is the updated version (thanks Austin for
noticing).
-- next part --
A non-text attachment was scrubbed...
Name: 0001-emacs-Tab-completion-for-notmuch-search-and-notmuch-.pat
: [PATCH] emacs: Tab completion for notmuch-search and
notmuch-search-filter
This patch adds completion with in the minibuffer for
notmuch-search and notmuch-search-filter.
---
emacs/notmuch.el | 33 +++--
1 files changed, 31 insertions(+), 2 deletions(-)
diff --git a
On Sat, 4 Jun 2011 17:55:24 -0400, Austin Clements wrote:
> Oh, sorry, I wasn't suggesting setq'ing a global. I agree that that's
> really ugly. Rather, something like
>
> (defun notmuch-query-completions (string)
> ... as you have it now ...)
>
> (defun notmuch-read-query (prompt)
> (let
Sorry, forgot to actually test notmuch-search entirely with this change
and not just the completion.
-- next part --
A non-text attachment was scrubbed...
Name: 0001-emacs-Tab-completion-for-notmuch-search-and-notmuch-.patch
Type: text/x-diff
Size: 3281 bytes
Desc: not avail
On Sat, 4 Jun 2011 11:32:15 -0400, Austin Clements wrote:
> Dynamic scoping is obnoxious, but I think programmed completion is
> steeped in the assumption that you'll use it. This code would be much
> simpler if notmuch-query-completions took only `string' and used the
> dynamically-bound all-com
Quoth Daniel Schoepe on Jun 04 at 9:55 pm:
> On Sat, 4 Jun 2011 11:32:15 -0400, Austin Clements
> wrote:
> > Dynamic scoping is obnoxious, but I think programmed completion is
> > steeped in the assumption that you'll use it. This code would be much
> > simpler if notmuch-query-completions took
is how some of
> the standard completing read functions appear to work:
Ah right, I forgot that using macros from cl is fine even in library
code.
From 7768f41ac44213c5e2c1dc3b0f13e3edf1d97a26 Mon Sep 17 00:00:00 2001
From: Daniel Schoepe
Date: Sat, 4 Jun 2011 14:17:44 +0200
Subject: [PATCH]
This patch adds completion with in the minibuffer for
notmuch-search and notmuch-search-filter.
---
emacs/notmuch.el | 33 +++--
1 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 3311fe8..7b63dc9 100644
--- a/em
Quoth Daniel Schoepe on Jun 04 at 9:55 pm:
> On Sat, 4 Jun 2011 11:32:15 -0400, Austin Clements wrote:
> > Dynamic scoping is obnoxious, but I think programmed completion is
> > steeped in the assumption that you'll use it. This code would be much
> > simpler if notmuch-query-completions took on
This patch adds completion with in the minibuffer for
notmuch-search and notmuch-search-filter.
---
emacs/notmuch.el | 33 +++--
1 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 3311fe8..49a82be 100644
--- a/em
Sorry, forgot to actually test notmuch-search entirely with this change
and not just the completion.
From cb172efc1dea2507566db587f960c073373e0159 Mon Sep 17 00:00:00 2001
From: Daniel Schoepe
Date: Sat, 4 Jun 2011 14:17:44 +0200
Subject: [PATCH] emacs: Tab completion for notmuch-search and
5f65574a792e7 Mon Sep 17 00:00:00 2001
From: Daniel Schoepe
Date: Sat, 4 Jun 2011 14:17:44 +0200
Subject: [PATCH] emacs: Tab completion for notmuch-search and
notmuch-search-filter
This patch adds completion with in the minibuffer for
notmuch-search and notmuch-search-filter.
---
emacs/notmuch.el |
Nifty!
On Sat, Jun 4, 2011 at 8:19 AM, Daniel Schoepe
wrote:
> + ? ? ? ?(minibuffer-completion-table (completion-table-dynamic
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?`(lambda (s) (notmuch-query-completions
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? (quote ,all-compls) s)
> + ? ?;; ^
Nifty!
On Sat, Jun 4, 2011 at 8:19 AM, Daniel Schoepe
wrote:
> + (minibuffer-completion-table (completion-table-dynamic
> + `(lambda (s) (notmuch-query-completions
> + (quote ,all-compls) s)
> + ;; ^
This patch adds completion with in the minibuffer for
notmuch-search and notmuch-search-filter.
---
emacs/notmuch.el | 33 +++--
1 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 3311fe8..7b63dc9 100644
--- a/em
This patch adds completion with in the minibuffer for
notmuch-search and notmuch-search-filter.
---
emacs/notmuch.el | 33 +++--
1 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 3311fe8..49a82be 100644
--- a/em
32 matches
Mail list logo
