[PATCH] test/emacs: globally force the html renderer to html2text
On Sat, Sep 20 2014, David Bremner wrote: > Previously we did this for a single test, but some other proposed > tests ( id:1398105468-14317-3-git-send-email-amdragon at mit.edu ) show > similar breakage when switching renderers. LGTM. Tomi PS: in that file we don't seem to have unified style with comment capitalization, trailing periods and newlines between comment and code. > --- > test/T310-emacs.sh | 2 +- > test/test-lib.el | 5 + > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh > index ac966e5..c302402 100755 > --- a/test/T310-emacs.sh > +++ b/test/T310-emacs.sh > @@ -483,7 +483,7 @@ test_expect_equal_file OUTPUT EXPECTED > test_begin_subtest "Reply within emacs to an html-only message" > add_message '[content-type]="text/html"' \ > '[body]="Hi,This is an HTML test message. />OK?"' > -test_emacs "(let ((message-hidden-headers '()) (mm-text-html-renderer > 'html2text)) > +test_emacs "(let ((message-hidden-headers '())) > (notmuch-show \"id:${gen_msg_id}\") > (notmuch-show-reply) > (test-output))" > diff --git a/test/test-lib.el b/test/test-lib.el > index 36afe63..bbc03cb 100644 > --- a/test/test-lib.el > +++ b/test/test-lib.el > @@ -181,3 +181,8 @@ nothing." > ;; suite > (setq notmuch-tag-deleted-formats >'((".*" nil))) > + > +;; force a common html renderer, to avoid test variations between > +;; environments > + > +(setq mm-text-html-renderer 'html2text) > -- > 2.1.0 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] test/emacs: globally force the html renderer to html2text
On Sat, Sep 20 2014, David Bremner wrote: > Previously we did this for a single test, but some other proposed > tests ( id:1398105468-14317-3-git-send-email-amdra...@mit.edu ) show > similar breakage when switching renderers. LGTM. Tomi PS: in that file we don't seem to have unified style with comment capitalization, trailing periods and newlines between comment and code. > --- > test/T310-emacs.sh | 2 +- > test/test-lib.el | 5 + > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh > index ac966e5..c302402 100755 > --- a/test/T310-emacs.sh > +++ b/test/T310-emacs.sh > @@ -483,7 +483,7 @@ test_expect_equal_file OUTPUT EXPECTED > test_begin_subtest "Reply within emacs to an html-only message" > add_message '[content-type]="text/html"' \ > '[body]="Hi,This is an HTML test message. />OK?"' > -test_emacs "(let ((message-hidden-headers '()) (mm-text-html-renderer > 'html2text)) > +test_emacs "(let ((message-hidden-headers '())) > (notmuch-show \"id:${gen_msg_id}\") > (notmuch-show-reply) > (test-output))" > diff --git a/test/test-lib.el b/test/test-lib.el > index 36afe63..bbc03cb 100644 > --- a/test/test-lib.el > +++ b/test/test-lib.el > @@ -181,3 +181,8 @@ nothing." > ;; suite > (setq notmuch-tag-deleted-formats >'((".*" nil))) > + > +;; force a common html renderer, to avoid test variations between > +;; environments > + > +(setq mm-text-html-renderer 'html2text) > -- > 2.1.0 > > ___ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] test/emacs: globally force the html renderer to html2text
Previously we did this for a single test, but some other proposed tests ( id:1398105468-14317-3-git-send-email-amdragon at mit.edu ) show similar breakage when switching renderers. --- test/T310-emacs.sh | 2 +- test/test-lib.el | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh index ac966e5..c302402 100755 --- a/test/T310-emacs.sh +++ b/test/T310-emacs.sh @@ -483,7 +483,7 @@ test_expect_equal_file OUTPUT EXPECTED test_begin_subtest "Reply within emacs to an html-only message" add_message '[content-type]="text/html"' \ '[body]="Hi,This is an HTML test message.OK?"' -test_emacs "(let ((message-hidden-headers '()) (mm-text-html-renderer 'html2text)) +test_emacs "(let ((message-hidden-headers '())) (notmuch-show \"id:${gen_msg_id}\") (notmuch-show-reply) (test-output))" diff --git a/test/test-lib.el b/test/test-lib.el index 36afe63..bbc03cb 100644 --- a/test/test-lib.el +++ b/test/test-lib.el @@ -181,3 +181,8 @@ nothing." ;; suite (setq notmuch-tag-deleted-formats '((".*" nil))) + +;; force a common html renderer, to avoid test variations between +;; environments + +(setq mm-text-html-renderer 'html2text) -- 2.1.0
[PATCH] test/emacs: globally force the html renderer to html2text
Previously we did this for a single test, but some other proposed tests ( id:1398105468-14317-3-git-send-email-amdra...@mit.edu ) show similar breakage when switching renderers. --- test/T310-emacs.sh | 2 +- test/test-lib.el | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh index ac966e5..c302402 100755 --- a/test/T310-emacs.sh +++ b/test/T310-emacs.sh @@ -483,7 +483,7 @@ test_expect_equal_file OUTPUT EXPECTED test_begin_subtest "Reply within emacs to an html-only message" add_message '[content-type]="text/html"' \ '[body]="Hi,This is an HTML test message.OK?"' -test_emacs "(let ((message-hidden-headers '()) (mm-text-html-renderer 'html2text)) +test_emacs "(let ((message-hidden-headers '())) (notmuch-show \"id:${gen_msg_id}\") (notmuch-show-reply) (test-output))" diff --git a/test/test-lib.el b/test/test-lib.el index 36afe63..bbc03cb 100644 --- a/test/test-lib.el +++ b/test/test-lib.el @@ -181,3 +181,8 @@ nothing." ;; suite (setq notmuch-tag-deleted-formats '((".*" nil))) + +;; force a common html renderer, to avoid test variations between +;; environments + +(setq mm-text-html-renderer 'html2text) -- 2.1.0 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch